- 11 Nov, 2020 40 commits
-
-
Eric Orth authored
Previously worked only for address requests. Other request types (e.g. HTTPS), on seeing any unrecognized (and therefore unparsable) record type in the response, would fail the whole response as malformed. Bug: 1147247 Change-Id: Icd9e5ab2e39cf09ffe7c3945b011ebf1d4b45778 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529619 Commit-Queue: Eric Orth <ericorth@chromium.org> Auto-Submit: Eric Orth <ericorth@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#826462}
-
Dan Sinclair authored
This reverts commit 4ec67b1c. Reason for revert: Breaks Dawn Bots. Original change's description: > Roll Tint from 7b750dc7337d to dbcc1e0e804e (11 revisions) > > https://dawn.googlesource.com/tint.git/+log/7b750dc7337d..dbcc1e0e804e > > 2020-11-10 rharrison@chromium.org [inspector] Extract Sampled Texture data > 2020-11-10 dsinclair@chromium.org [hlsl-writer] Emit texture types > 2020-11-10 dsinclair@chromium.org [spirv-writer] Hash names > 2020-11-09 bclayton@google.com wsgl parser: Have Expect & Maybe operator-> deref > 2020-11-09 bclayton@google.com wsgl parser: Add ParserImpl::Maybe<T> > 2020-11-09 bclayton@google.com wsgl parser: Add ParserImpl::Expect<T> > 2020-11-09 bclayton@google.com wsgl parser: Migrate more code to use expect & match > 2020-11-09 bclayton@google.com wsgl parser: expect for storage_class > 2020-11-09 bclayton@google.com wsgl parser: expect for variable_ident_decl > 2020-11-09 sarahmashay@google.com [validation] relax rule v-0002: return is mandatory for non-void functions > 2020-11-09 bclayton@google.com wsgl parser: Remove pointless nullptr checks > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/tint-chromium-autoroll > Please CC sarahmashay@google.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md > > Bug: None > Tbr: sarahmashay@google.com > Change-Id: Ie9c4ae8f0af8baacbe90d08aaba4e9cac233a22a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530974 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#826083} TBR=chromium-autoroll@skia-public.iam.gserviceaccount.com,sarahmashay@google.com Change-Id: If5ec34d94eceb4c10291ea60bdf617d936973bd7 No-Tree-Checks: true No-Try: true Bug: 1147959 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533417 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Dan Sinclair <dsinclair@google.com> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#826461}
-
David Van Cleve authored
NavigationControllerBrowserTest.SameDocumentNavigationToHttpPortZero is flaky on multiple platforms. This CL disables the test; crrev.com/c/2472460, which should land in the next week or so, updates the underlying behavior the test covers and should unflake the test. Bug: 1138540 Change-Id: Iae329806219363c1c007230afe6078b26e8ab474 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532975 Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Auto-Submit: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#826460}
-
Thomas Guilbert authored
This CL hooks up the platform decoders to the MediaLog, and populates certain fields. Bug: 1139089 Change-Id: Ie5c8e0a9c1ba5eaa91318866952c1b775fd45b16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531133 Auto-Submit: Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#826459}
-
W. James MacLean authored
This CL adds a DwoC to monitor for cases where CanAccessDataForOrigin encounters zero BrowsingInstanceIds. We believe these were fixed in https://chromium-review.googlesource.com/c/chromium/src/+/2523732 and https://chromium-review.googlesource.com/c/chromium/src/+/2522904 but in case there are other pathways that can lead to this condition we need to be vigilant. This is being landed in a separate CL to make it easy to revert. Bug: 1135539, 1141721 Change-Id: I387693c4d8543bda79cee5e2c2d2c9cae57b0f0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532873Reviewed-by:
-
Phillis Tang authored
Adds a CallbackFactory that creates callback for each os hook, and DCHECK on destruction to make sure that all os hooks type have created callback. Bug: 1129193 Change-Id: I82a44dc7fa8a1c40c7caba8fcaa6134620e80d4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517438 Commit-Queue: Phillis Tang <phillis@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#826457}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/48a46dd6..90a57536 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I9f483eda27a0c0151945f6faa722897256786350 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533197Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#826456}
-
Vidhan authored
Change-Id: I6756bbb4c19eae9bd35283fc52569c08273c849c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532260 Commit-Queue: Dominic Battré <battre@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#826455}
-
Evan Stade authored
If the MediaStreamManager were destroyed after a MediaStreamUi was created but before it started recording, it wouldn't call OnManagerGone on the MediaStreamUi. Switch to using a WeakPtr. Bug: 1147646 Change-Id: I72010ed73daa26c4f682e2779efe046d1ddb2020 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532966Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#826454}
-
Chrome Metrics Logs authored
Updates the expires_after attribute for 195 histograms that show frequent access in the past 90 days. These are the 95% most frequently used histograms over that time that do not already have a date later than or within 60 days of 2021-02-08. TBR=chromium-metrics-reviews@google.com Change-Id: I59b01ec4d105ce2a7a4673c6c5a61440d80276a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530616Reviewed-by:
Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#826453}
-
Gavin Williams authored
Calls LorgnetteManagerClient CancelScan API to cancel the currently running scan job. Bug: 1059779 Change-Id: I31da3b2a37caa472eac1f7b781cd3d9f6ca9f465 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532723 Commit-Queue: Gavin Williams <gavinwill@chromium.org> Reviewed-by:
Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#826452}
-
Mario Bianucci authored
RenderWidgetHostDelegatedInkMetadataTest. FlagGetsSetFromRenderFrameMetadata is mildly flaky on various release builds, but I have not been able to repro it once across several thousand runs on win10 and linux chromeos. In an effort to try to get to the bottom of the issue, this CL slightly changes the test. The goal here is to make the test fail in a more obvious way if the issue is that the presenter promise did not resolve in time. With this change, if the promise hasn't been resolved, then updateInkTrailStartPoint will be called on a null presenter, so the error will be much more obvious. Bug: 1096994 Change-Id: I45dd80bb22cbcd874c5c7412e9a91f8bf55b1399 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527823Reviewed-by:
Daniel Libby <dlibby@microsoft.com> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Mario Bianucci <mabian@microsoft.com> Cr-Commit-Position: refs/heads/master@{#826451}
-
Sigurdur Asgeirsson authored
ScopedObserver is being deprecated in favor of two new classes: - base::ScopedObservation for observers that only ever observe a single source. - base::ScopedMultiSourceObservation for observers that do or may observe more than a single source. This CL was uploaded by git cl split. R=ftirelo@chromium.org Bug: 1145565 Change-Id: Icad7d2607d3f5820af9ea1648beab6661c502a5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532876 Auto-Submit: Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#826450}
-
Jonah Chin authored
This CL introduces an OOPR compatible version of VideoTextureBacking and updates PaintCanvasVideoRenderer::UpdateLastImage() to use this new version in the OOPR codepath. More details about overall PaintImage effort: crbug.com/1023259 Info about the OOPR-Canvas2D project: crbug.com/1018894 Bug: 1115217 Change-Id: I4590cf16d6faef0e5575b0b4006ea88de89aa13d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419653Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Jonah Chin <jochin@microsoft.com> Cr-Commit-Position: refs/heads/master@{#826449}
-
Rohit Agarwal authored
Screenshot: crbug.com/1104180#c17 Bug: 1104180 Change-Id: I7458816b407692832f88a9d124597e6ab235f38f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532246Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Rohit Agarwal <roagarwal@chromium.org> Cr-Commit-Position: refs/heads/master@{#826448}
-
Sigurdur Asgeirsson authored
ScopedObserver is being deprecated in favor of two new classes: - base::ScopedObservation for observers that only ever observe a single source. - base::ScopedMultiSourceObservation for observers that do or may observe more than a single source. This CL was uploaded by git cl split. R=jdiggs@igalia.com Bug: 1145565 Change-Id: I7c12763d1b3461e3d66280174dc6164c46b63c1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526902Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Auto-Submit: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#826447}
-
Xiang Ji authored
Easier to refractor in the future Validation: tryjob Bug: 1104909 Change-Id: I6b92ca2f877dad19be8535ea9482d126f3c3a759 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528206 Commit-Queue: Xiang Ji <jxiang@google.com> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#826446}
-
Lukasz Anforowicz authored
Fixed: 1141158 Change-Id: Iae559652ee39fb2f63c8658e5cfdf8e199df149d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521229 Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#826445}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/17f22b43ebf7..ea473b133142 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC estade@google.com,wjmaclean@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1040645,chromium:1147179 Tbr: estade@google.com,wjmaclean@google.com Change-Id: Ib12a520a8d026a61bccf35aaafc72d91482432c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532980Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#826444}
-
Sigurdur Asgeirsson authored
ScopedObserver is being deprecated in favor of two new classes: - base::ScopedObservation for observers that only ever observe a single source. - base::ScopedMultiSourceObservation for observers that do or may observe more than a single source. This CL was uploaded by git cl split. R=anthonyvd@chromium.org Bug: 1145565 Change-Id: Ic75c0df148d4ef69da3675276ad5728dd6dcf864 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532960 Auto-Submit: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#826443}
-
Eric Lawrence [MSFT] authored
Reword the error message shown when a Policy lacks a required field. Change-Id: I654ee95f2b5e2a57f9bd31f2626900240a1ef121 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529696Reviewed-by:
Chris Sharp <csharp@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Eric Lawrence [MSFT] <ericlaw@microsoft.com> Cr-Commit-Position: refs/heads/master@{#826442}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0d4297e6b205..dfff133590c2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I8b0d6d973cc4dcc790635d0a949075b37a6acf51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533414Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#826441}
-
sandromaggi authored
This adds an optional waiting step for the ShowCast action to ensure the element is stable before trying to scroll to it. This change also makes ElementPositionGetter configurable in terms of rounds and interval. This change also removes the settings from WebController as they are no longer needed. Bug: b/172334699 Change-Id: I5ffd532c5c7ae8eab4b5d0809d17d6fec9b82749 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532293 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#826440}
-
Evan Stade authored
This reverts commit 74dbe648. Reason for revert: suspected of making TabSearchAppTest.All flaky see crbug.com/1148009 Original change's description: > Tab Search: Infinite list component > > A list component that renders DOM items on demand based on the viewable > scroll area and user navigation and scrolling interactions. Provides a > performance gain for use cases where users have several dozens of items > that should be available while scrolling the list by deferring scripting > and rendering costs until necessary to fill the current scroll view. > > Bug: 1099917 > Change-Id: Ib22c0edf5ebc5febe3d8d6d4f7d8ac319e9bd0a2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503401 > Commit-Queue: Roman Arora <romanarora@google.com> > Reviewed-by: Thomas Lukaszewicz <tluk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#826287} TBR=tluk@chromium.org,romanarora@chromium.org,romanarora@google.com Change-Id: I5bb4c3d348ad739d2d503522dc84d8654c21f117 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1099917 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532987Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#826439}
-
Ryan Sturm authored
Bug: 1141912 Change-Id: I0f19902b98bffffcf72422f0fe062c7dce33dc19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515020Reviewed-by:
Robert Ogden <robertogden@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#826438}
-
Nicolas Ouellet-Payeur authored
HttpCredentialCleaner tried to use the PrefService in a posted task. This caused a use-after-free when the DestroyProfileOnBrowserClose flag was enabled. Make CredentialsCleanerRunner a KeyedService, so its lifetime (and its attached HttpCredentialCleaner) is tied to the Profile's lifetime, letting us avoid the crash by using WeakPtrs. Bug: 88586, 1141055 Change-Id: I77ebd7daa87257d562c9c12bf63681f16ffc2d10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511073 Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#826437}
-
Ian Clelland authored
This enables the detection and parsing of the "Permissions-Policy" HTTP response header, but does not remove support for the "Feature-Policy" header. If both headers are returned with a document, then any feature mentioned in both headers will use the allowlist specified by Permissions-Policy. A console message will be emitted in that case, to alert developers to the potential conflict. Intent-to-Ship thread: https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOMQ%2Bw-hVfxO8YYX_WAKNCD96sg_bnFmTDbYDsaL4pfw3s9f4A%40mail.gmail.com Bug: 1095641 Change-Id: I02f9eb34405bf3c842705bf2c18a14b62fa076e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530793 Commit-Queue: Ian Clelland <iclelland@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#826436}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/0bfdbc37e9ec..06bbeb3398af 2020-11-11 danilchap@webrtc.org in Av1 encoder wrapper communicate end_of_picture flag similar to VP9 2020-11-11 alessiob@webrtc.org Reland "RNN VAD: pitch search optimizations (part 3)" 2020-11-11 alessiob@webrtc.org Reland "RNN VAD: pitch search optimizations (part 2)" 2020-11-11 alessiob@webrtc.org Reland "RNN VAD: pitch search optimizations (part 1)" 2020-11-11 kwiberg@webrtc.org CallbackList: Don't allow reentrancy 2020-11-11 gvaish@chromium.org Allow AudioAttributes to be app/client configurable If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I2075a0ca623580f1bec26d6942f6f03f38c1679e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532639Reviewed-by:
-
Peng Huang authored
When SkiaRenderer::PrepareRenderPassOverlay() is preparing the render pass overlay, current_frame()->current_render_pass could be used. However it is nullptr, then crash happens. Fix the problem by setting it to current_frame()->root_render_pass. Bug: 1147583 Change-Id: I3b67ba792631b3ad24e927edab609563f1cbc0a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533014 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#826434}
-
Sigurdur Asgeirsson authored
ScopedObserver is being deprecated in favor of two new classes: - base::ScopedObservation for observers that only ever observe a single source. - base::ScopedMultiSourceObservation for observers that do or may observe more than a single source. This CL was uploaded by git cl split. R=jkarlin@chromium.org Bug: 1145565 Change-Id: Id5414833dd0227489e629f56ea4a94a7ad86df58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533023 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Auto-Submit: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#826433}
-
Moe Ahmadi authored
After crrev.com/c/2527531, clicking the MV tile action menu or delete button results in navigation to the MV tile's destination URL. Prior to crrev.com/c/2527531, calling preventDefault() on the click event targeted at the action menu or the delete buttons would have prevented the default browser action on the parent <a> element. After the said change, navigations are no longer handled implicitly and thus a navigation occurs in NewTabPageHandler::OnMostVisitedTileNavigation. This CL fixes that bug by ignoring previously handled events targeted at the tile's child elements. Fixed: 1147255, 1147746 Change-Id: I71749e533f23689ce7a869b74d6df65a3e44497d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531357Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Auto-Submit: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#826432}
-
Ying Ye authored
Bug: internal b/171233251 Test: triggered crash and checked crash report Change-Id: If24d4a2d74969b9ddb6cab002baba95c241cb210 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530794Reviewed-by:
Sergey Volk <servolk@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Ying Ye <yingye@google.com> Cr-Commit-Position: refs/heads/master@{#826431}
-
Sam Sebree authored
This CL addresses a bug in which, when the OS color scheme is changed, the scrollbars on the page maintain their old color scheme. Bug: 1137169 Change-Id: I22416b906aa06e0476dc298fd2d3a0e9653305d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522563Reviewed-by:
Yu Han <yuzhehan@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Sam Sebree <sasebree@microsoft.com> Cr-Commit-Position: refs/heads/master@{#826430}
-
Peter Wen authored
Some aar files (e.g. androidx) that chrome depends on contain a lint.jar file and/or a annotations.zip file. The lint.jar file includes custom android lint checks. The annotations.zip file contains @IntDef and other annotations needed for lint checks that are usually available by source but are not available in aars. By using these files, we can make our existing lint checks more comprehensive as well as benefit from lint checks by the aar library authors. See newly ignored checks in lint-baseline.xml which is updated in this CL as an example. Actually fixing these errors is left for future CLs in order to enable them quicker and avoid unnecessary relands. Original CL: https://crrev.com/c/2510793 Fixed: - Avoid ../../ prefix in temporary extraction of aar files. Tbr: Reland with trivial fix. Bug: 1078229 Change-Id: I0236043cf949e94bf0dee5714a620a9e96239616 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532664Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#826429}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1605063577-aa3ba3d5531ffbb5406af499dbbeda6119384c8a.profdata to chrome-win64-master-1605084700-9619bbd46776ec532a7f848b4f703ffd6d373199.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ida93665697134636935ef4b9b032ea02d6bb8331 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532916Reviewed-by:
-
Dave Tapuska authored
Remove duplicated hit testing implementation and use the base version of it. BUG=1097816 Change-Id: I79feb29cf0712ee8554336b3a26e10c05fa1c348 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527263 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#826427}
-
Sammie Quon authored
Starts tracking when a desk switch animation starts. Sets up a timer which then records the number of traversals during a sequence of desk animations. There may be multiple animations during the timer duration, they will notify the metrics collector class on animation end with how many traversals have happened. For touchpad swipes, add some logic to track how much visible desk switches the user has seen. This is different from the number of desk activations. For all other desk switch sources, the number of traversals during an animation is 1 + #Replacements. Test: manual, added tests Bug: 1146479 Change-Id: Ie3c46ebe80e35a768a89eb6e7105d807db087529 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523061 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#826426}
-
danakj authored
Although extensions now uses mojo to receive SkBitmaps, even those still have a variety of color types. And some of those colortypes use other pixel sizes than 32bpp, which can lead to buffer overflow bugs. So we convert any incoming arbitrary bitmaps received from (extensions) renderer processes to be N32 upon receipt. R=reillyg@chromium.org Bug: 1144462 Change-Id: I66acc7fbfcc0565411a1b9b9bc5a01b70558c5b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532663Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#826425}
-
Maria Kazinova authored
Bug: 1131038, 1075444 Change-Id: Ic120ef48c37885ecc93c18a5ecbf4731240f02c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532559Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#826424}
-
Majid Valipour authored
Implement a new web-otp-backend auto which uses two existing backends and can automatically switch between them when necessary. It first tries to use a preferred backend (i.e., verification backend) and automatically switches over to the fallback backend (i.e., user consent) when that is not available. In order to be able to automatically switch between the two backends we move the backend API switch-over logic to the Java implementation side and add a new component SmsProviderGms which can use two types of receivers. The provider callers can specify which backend to use. This is used to emulate the existing behavior and in tests. Alternatively callers can specify the new auto backend. This also enabled multiple refactoring: - The receivers now only talk to the provider and don't need to be aware of the native code. - A single test suite for both backends which means we can de-dupe common tests. - A single fake can be used for all backends. Follow up: - The onSuccess callback should return the method used so that the caller can decide which user consent handler to use. Test: ./bin/run_content_unittests --gtest_filter=*SmsProvider* Bug:1141024 Change-Id: I2094496ee759fe50d7e6981c490ecc18066dfb5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495910 Commit-Queue: Majid Valipour <majidvp@chromium.org> Reviewed-by:
Yi Gu <yigu@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Reviewed-by:
-
![Eric Lawrence [MSFT]'s avatar](https://secure.gravatar.com/avatar/16e6d745c0e05bade0525857d18118ce?s=80&d=identicon "Eric Lawrence [MSFT]")
