GitLab

As per the specification, the iframe's name should be an empty string if unset:
http://www.whatwg.org/specs/web-apps/current-work/multipage/the-iframe-element.html#attr-iframe-name

Instead, Chromium was using the iframe's id as window name if the name was
unset. This change makes us behave like Firefox 27 and IE 11, verified using:
http://jsfiddle.net/xf5H7/9/

This CL sets the name attribute iframe in a lot of layout tests so that
testRunner.dumpChildFramesAsText() keeps printing the same result.

R=arv@chromium.org, tkent@chromium.org, abarth, arv, tkent
BUG=347169
TEST=fast/frames/iframe-no-name.html

Review URL: https://codereview.chromium.org/187103002

git-svn-id: svn://svn.chromium.org/blink/trunk@168553 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Also, apply zoom to layer div sizes to keep resulting layers small.

BUG=

Review URL: https://codereview.chromium.org/177353005

git-svn-id: svn://svn.chromium.org/blink/trunk@168552 bbb929c8-8fbe-4397-9dbb-9b2b20218538

- webaudio/codec-tests/vorbis/vbr-128kbps-44khz.html
- webaudio/codec-tests/vorbis/vbr-70kbps-44khz.html
- webaudio/codec-tests/vorbis/vbr-96kbps-44khz.html

TBR=rtoy@chromium.org,dalecurtis@chromium.org
BUG=349662

Review URL: https://codereview.chromium.org/187323008

git-svn-id: svn://svn.chromium.org/blink/trunk@168551 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=cbiesinger@chromium.org
BUG=346132

Review URL: https://codereview.chromium.org/184223007

git-svn-id: svn://svn.chromium.org/blink/trunk@168549 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=168519

BUG=345609
TBR=tkent@chromium.org

Review URL: https://codereview.chromium.org/180743023

git-svn-id: svn://svn.chromium.org/blink/trunk@168548 bbb929c8-8fbe-4397-9dbb-9b2b20218538

All noncharacter code points are >= 0xD800 so we can use more liberal condition when detecing characters that needs to be esscaped.

BUG=347899

Review URL: https://codereview.chromium.org/180113008

git-svn-id: svn://svn.chromium.org/blink/trunk@168547 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Two websocket tests are still failing.

See https://codereview.chromium.org/162923002 for the change that removed these
lines.

Example of the failure:
http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7/builds/13889

TBR=ricea@chromium.org
BUG=

Review URL: https://codereview.chromium.org/187913003

git-svn-id: svn://svn.chromium.org/blink/trunk@168546 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Huge texts reduce rendering performance drastically, nor they are more helpful than a truncated version.

BUG=347917
R=pfeldman, loislo

Review URL: https://codereview.chromium.org/186693002

git-svn-id: svn://svn.chromium.org/blink/trunk@168545 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch adds two UMA metrics:

WebFont.BlankTextShownTime histogram tracks the time we spent showing
blank text. This measures the time between when the "loading fallback"
font is drawn for the first time, and when FontData for the downloaded
web font is created.

WebFont.HadBlankText is recorded once per page load if the page uses
any web fonts. The value is 1 if we ended up showing blank text at
least once, 0 otherwise.

BUG=345839
TEST=Manually tested with chrome://histograms

Review URL: https://codereview.chromium.org/180273020

git-svn-id: svn://svn.chromium.org/blink/trunk@168541 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This change removes many pixel baselines that were trivial enough
to be expressed as reference html. Some of the tests were slightly
modified to make them work as ref tests.

R=senorblanco@chromium.org
BUG=349536

Review URL: https://codereview.chromium.org/187393007

git-svn-id: svn://svn.chromium.org/blink/trunk@168540 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The aim is to avoid SkPaint setup time for the common case of filling and stroking shapes. We can't entirely do that, as some of the paint content is not controlled by GraphicsContextState (such as text or temporary paint state set for specific draw operations).

Perf tests on the record_and_rasterize micro-bench indicate a 1-3% average improvement on record times.

BUG=343240
R=adamk@chromium.org, fmalita@chromium.org, senorblanco@chromium.org

Review URL: https://codereview.chromium.org/169283008

git-svn-id: svn://svn.chromium.org/blink/trunk@168536 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Removing the TextTrackClient interface because it was obscuring calls
made to the HTMLMediaElement and wasn't really providing much value.
Calls made to the HTMLMediaElement are much clearer now and it is
easier to follow what happens when tracks are removed from the
TextTrackList.

BUG=249427
TEST=All existing LayoutTests still pass
R=adamk@chromium.org

Review URL: https://codereview.chromium.org/177003025

git-svn-id: svn://svn.chromium.org/blink/trunk@168534 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch keeps m_blocksForFingerprint in sync with m_fingerprints when
adding a new entry to m_fingerprints. Here's a quick summary about
these maps:
m_blocksForFingerprint maps Fingerprint -> list of RenderBlocks
m_fingerprints maps RenderObject -> Fingerprint

Previously, when adding a block to m_fingerprints we could neglect to
update m_blocksForFingerprint. By removing entries from
m_blocksForFingerprint before registering a new block fingerprint, we
prevent a crash on [1].

[1] http://www.chicagotribune.com/news/sns-wp-blm-news-bc-inventor01-20140301,0,255272.story

TEST=Added an assert that crashes all over our layouttests without this fix. Manually verified [1] no longer crashes.
BUG=348463
NOTRY=true

Review URL: https://codereview.chromium.org/186453002

git-svn-id: svn://svn.chromium.org/blink/trunk@168533 bbb929c8-8fbe-4397-9dbb-9b2b20218538

A few more WebSocket layout tests now pass with the new
implementation. Remove them from the TestExpectations.

BUG=339373
TEST=run_webkit_tests --debug http/tests/websocket

Review URL: https://codereview.chromium.org/162923002

git-svn-id: svn://svn.chromium.org/blink/trunk@168532 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When XMLHttpRequest.responseType is specified to "blob", we
download the resource into a file and on XMLHttpRequest.response
call, we create a Blob object from m_response.downloadedFilePath()
and m_downloadedBlobLength. m_downloadedBlobLength is accumulated on
WebCore::XMLHttpRequest::didDownloadData() handler call but not
reset on clearResponse() call. So, if you use the XHR instance again
after calling open(), uncleared invalid size will be used.

We should just reset it to 0 on clearResponse() call.

BUG=349321

Review URL: https://codereview.chromium.org/183333005

git-svn-id: svn://svn.chromium.org/blink/trunk@168531 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Move HTMLContentElement & HTMLShadowElement out of shadow/ and
into html/.

Reference CL: https://codereview.chromium.org/27009005/

Review URL: https://codereview.chromium.org/183893019

git-svn-id: svn://svn.chromium.org/blink/trunk@168530 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=317931
R=dpranke@chromium.org

Review URL: https://codereview.chromium.org/181233010

git-svn-id: svn://svn.chromium.org/blink/trunk@168529 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Related to this w3c mailing list thread:
http://lists.w3.org/Archives/Public/www-style/2014Mar/0013.html

BUG=231754

Review URL: https://codereview.chromium.org/186943003

git-svn-id: svn://svn.chromium.org/blink/trunk@168528 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert "Consider text alignment and direction when computing the left offset for horizontal writing modes."

This caused layout to fail in the filmstrip for Google Hangouts.
This reverts r167732 and r168295.
Landing with NOTRY=true because bots167732 seem busted.

BUG=347889,157539
NOTRY=true

Review URL: https://codereview.chromium.org/176763011

git-svn-id: svn://svn.chromium.org/blink/trunk@168527 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This fixes scaling (including z-scaling) caused by page zoom and high dpi settings (pinch zoom still todo).

This also fixes the light position, since the light origin was misplaced when a non 0 filter effect region x and y parameters were used (which is the case by default). The origin was affected by these values, which shouldn't be the case, as these provide extra space to render an effect, like a blur, for example, but should not changed the effect's coordinate system.

BUG=

Review URL: https://codereview.chromium.org/181943003

git-svn-id: svn://svn.chromium.org/blink/trunk@168526 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Add various performance tests for CSS Shapes taken from
https://bugs.webkit.org/show_bug.cgi?id=128188.

BUG=349093
NOTRY=true

Review URL: https://codereview.chromium.org/186783003

git-svn-id: svn://svn.chromium.org/blink/trunk@168525 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Trying to add this first before https://codereview.chromium.org/186783003/

NOTRY=true

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168517

Review URL: https://codereview.chromium.org/187673007

git-svn-id: svn://svn.chromium.org/blink/trunk@168524 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=dstockwell@chromium.org, steveblock@chromium.org
BUG=349552

Review URL: https://codereview.chromium.org/183023015

git-svn-id: svn://svn.chromium.org/blink/trunk@168523 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Add a bit more smarts to StyleBuilder jinja machinery to make
it understand how fonts are made. Custom is bad. Generated is good.

R=ksakamoto@chromium.org,eae
BUG=

Review URL: https://codereview.chromium.org/186403002

git-svn-id: svn://svn.chromium.org/blink/trunk@168522 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Range::didSplitTextNode() fails to update RangeBoundaryPoint's
m_childBeforeBoundary correctly, if either boundary point is located
immediately after the split text node. This change fixes this bug and adds
a couple of unit tests that make sure text splits are handled correctly.

This is a bug I found while I was investigating on a ClusterFuzz crash. The bug
above was the root cause of the crash. The crash happens in the following way:
  1. Range::surroundContents() removes some nodes during its operation,
     which causes DOMNodeRemoved event to fire *before* surroundContents()
     completes.
  2. A user-supplied event handler does something causing text to split.
  3. Due to the bug above, Range's boundary points may get into an inconsistent
     state; i.e. m_start may be located *after* m_end.
  4. If certain conditions are met, an invalid Range object created during
     Range::surroundContents() causes a crash within checkDeleteExtract().
  5. Sad face.

This change adds a new layout test that reproduces this crash.

BUG=343798

Review URL: https://codereview.chromium.org/178543013

git-svn-id: svn://svn.chromium.org/blink/trunk@168521 bbb929c8-8fbe-4397-9dbb-9b2b20218538

It is now agreed in blink that 'nullptr' is used
to represent a null value for smart pointers.
This patch makes HashTraits<RawPtr> use 'nullptr_t'
as 'EmptyValueType' making it consistent with
HashTraits<RefPtr> and HashTraits<OwnPtr>.

Review URL: https://codereview.chromium.org/185903002

git-svn-id: svn://svn.chromium.org/blink/trunk@168520 bbb929c8-8fbe-4397-9dbb-9b2b20218538

r168130 updated -webkit-appearance:menulist-button implementation. We should
update the CSS ruleset for input[type=color][list] too because it uses
menulist-button when it is styled.

BUG=345609
TEST=automated

Review URL: https://codereview.chromium.org/180163012

git-svn-id: svn://svn.chromium.org/blink/trunk@168519 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Trying to add this first before https://codereview.chromium.org/186783003/

NOTRY=true

Review URL: https://codereview.chromium.org/187673007

git-svn-id: svn://svn.chromium.org/blink/trunk@168517 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=168491

BUG=313447
TBR=jchaffraix@chromium.org

Review URL: https://codereview.chromium.org/181233009

git-svn-id: svn://svn.chromium.org/blink/trunk@168516 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=kinuko@chromium.org, tyoshino@chromium.org
BUG=349537

Review URL: https://codereview.chromium.org/186723006

git-svn-id: svn://svn.chromium.org/blink/trunk@168515 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=tommyw@chromium.org
BUG=349528

Review URL: https://codereview.chromium.org/187413005

git-svn-id: svn://svn.chromium.org/blink/trunk@168514 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Number input type maximum value increased from float to double. Float allowed only max value of 3.402823466e38, it has now been increased to 1.7976931348623158e+308, by using double.

InvalidStateError exception is removed from NumberInputType::setValueAsDouble and NumberInputType::setValueAsDecimal, as HTMLInputType::setValueAsNumber checks if value is infinite.
As NumberInputType functions will not be called, they have been removed.

HTMLParserIdioms has also been updated as the functions are triggered in NumberInputType functions and has check for max values, thus updated.

R=tkent, ch.dumez@samsung.com
BUG=336020
TEST=Max value number can hold and exception thrown in case higher value than double is set

Review URL: https://codereview.chromium.org/172223003

git-svn-id: svn://svn.chromium.org/blink/trunk@168513 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Which are:

- webaudio/dynamicscompressor-simple.html
- webaudio/realtimeanalyser-fft-scaling.html

BUG=349523
TBR=rtoy@chromium.org

Review URL: https://codereview.chromium.org/183063009

git-svn-id: svn://svn.chromium.org/blink/trunk@168512 bbb929c8-8fbe-4397-9dbb-9b2b20218538

RenderReplaced::computeReplacedLogicalWidth walks up to it's
containingBlock in some cases and asks for the containingBlock's
width. If the containingBlock's width itself depends on the
RenderReplaced's width, then we infinite loop. Avoid the
infinite loop by making sure that width/min-width/max-width
are all specified on the containingBlock, which will keep
the width from depending on it's children.

Added FIXMEs. I think we should delete all this containingBlock
walking code, but it needs to be done carefully to make sure
percentage widths on <svg> keep working. The spec actually
considered this undefined behavior, but suggests doing the
crazy that we do here.

BUG=344647

Review URL: https://codereview.chromium.org/186913003

git-svn-id: svn://svn.chromium.org/blink/trunk@168511 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=349518
TBR=rtoy@chromium.org

Review URL: https://codereview.chromium.org/187383005

git-svn-id: svn://svn.chromium.org/blink/trunk@168510 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Reattach which means everything will work fine for ::first-letter changes.

However, if there is a change in ::first-letter style, but the element had
::first-letter style both before and after the change, we would not try to
recalc any ::first-letter pseudo for LocalStyleChange.

The introduction of LocalStyleChange for :hover/:active/:focus caused a
regression for the combination of ::first-letter and e.g. :hover.

This fix does a SubtreeStyleChange for :hover/:active/:focus updates when
the existing renderStyle is marked as having ::first-letter pseudo.

::first-line is working fine. Added a layout test to make sure it will
continue to do so.

R=esprehn
BUG=344322

Review URL: https://codereview.chromium.org/169643002

git-svn-id: svn://svn.chromium.org/blink/trunk@168509 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Before this change it was not possible to easily distinguish when RuleData represented a single item and when it represented an array.

This change is prerequisite for moving RuleSet/RuleData into the GC managed heap because tracing routines are largely type driven.

BUG=
NOTRY=true

Review URL: https://codereview.chromium.org/181403005

git-svn-id: svn://svn.chromium.org/blink/trunk@168508 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=

Review URL: https://codereview.chromium.org/184293003

git-svn-id: svn://svn.chromium.org/blink/trunk@168507 bbb929c8-8fbe-4397-9dbb-9b2b20218538

icudtl.dat is not copied to an Android device for webkit_unit_tests
leading to the failure of tests depending on ICU.

Add icu.isolate explicitly to get icudtl.dat copied.

TBR=jamesr@chromium.org
BUG=72633
TEST=build/android/test_runner.py gtest -s webkit_unit_tests --verbose
--gtest_filter=WebFrameTest.SelectRange*

Review URL: https://codereview.chromium.org/183013006

git-svn-id: svn://svn.chromium.org/blink/trunk@168506 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=none
R=abarth@chromium.org

Review URL: https://codereview.chromium.org/186863002

git-svn-id: svn://svn.chromium.org/blink/trunk@168505 bbb929c8-8fbe-4397-9dbb-9b2b20218538