GitLab

It was reverted in crrev.com/c/2135834 because of crbug.com/1067845.
This reland avoids the change of CompositorElementId for sticky
elements.

Original change's description:
> [CompositeAfterPaint] Allow non-atomic effects in multicol
>
> This is not fully correct, but we have to accept it in our current
> multicol painting based on FragmentClips.
>
> Actually we have already allowed non-atomic effects in multicol within
> composited layers since SlimmingPaintV175. A fragmented element with
> effect applies the effect on each fragment separately. We have to do
> this because each fragment has its own fragment clip, and its own paint
> properties because they may depend on the fragment clip.
>
> This CL enables non-atomic composited effects for CompositeAfterPaint.
> This is not an issue in pre-CompositeAfterPaint which doesn't allow
> fragmentation of composited layers (which is incorrect).
>
> The root issue will be fully fixed by LayoutNG block fragmentation
> which doesn't need FragmentClips.
>
> Bug: 1064341
> Change-Id: Id6ae4c263381f24d037f3c2bc493d73cd050598e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124340
> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
> Reviewed-by: Philip Rogers <pdr@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#754166}

Bug: 1064341
Change-Id: I48682c9d84441acd9cf90d4429281916423ef4de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137506
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757069}

Adds tests for docked magnifier, dictation, switch access, and some more
for select-to-speak.

Adds coverage for lines which change checked state of the
HoverHighlightViews, and also checks checked state as well as
the bool for tests. Total line coverage increase from 64% to 96%
in tray_accessibility.cc.

Some clean-up to reduce common lines in helper functions within
the test.

Bug: 1067399
Relnotes: N/A
Change-Id: I05ae85ac043c9fa71e0813a1f0948d990d82afbf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135022
Commit-Queue: Katie Dektar <katie@chromium.org>
Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757068}

Change-Id: I97ab5e565227dbce08081c262ba992572b9f446f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139759
Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Reviewed-by: Richard Knoll <knollr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757067}

The code after was assuming the arrays were the correct list which
was resulting in crashes when the tests were failing.

Change-Id: Ibf10202085fc6ec29012b28ce94a09825e68add2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139895
Auto-Submit: Chris Sharp <csharp@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757066}

TBR=apotapchuk@chromium.org

Bug: 1047176
Change-Id: Ic25a9fcde0a23cdc488ab86c1ab52837d9616b72
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139898Reviewed-by: Chris Sharp <csharp@chromium.org>
Commit-Queue: Chris Sharp <csharp@chromium.org>
Auto-Submit: Chris Sharp <csharp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757065}

https://chromium.googlesource.com/angle/angle.git/+log/d14735b25df3..eb298a024032

git log d14735b25df3..eb298a024032 --date=short --first-parent --format='%ad %ae %s'
2020-04-07 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/glslang/src b5757b95005b..9c3204a1fde0 (1 commits)

Created with:
  gclient setdep -r src/third_party/angle@eb298a024032

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC jonahr@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: jonahr@google.com
Change-Id: Ia6f63664e57092db0a07c6dfa9e0aa8068d7033d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139939Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#757064}

It's needed for ENABLE_SESSION_SERVICE flag.

Change-Id: I799a9d3ae17fa4716273e5b77a3cc6614017fff6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139715
Auto-Submit: Tomasz Moniuszko <tmoniuszko@opera.com>
Reviewed-by: François Doray <fdoray@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757063}

With CreateNewHostForSameSiteSubframe enabled, a new frame is created
and so we expect the embedding token to change.

Bug: 1064944
Change-Id: I8f9833cc5942c847b78a93ddfa021597771f5c34
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138991Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Calder Kitagawa <ckitagawa@chromium.org>
Commit-Queue: Fergal Daly <fergal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757062}

This interface will be re-used for non-downloads notifications so it
gets a more generic name.

- DownloadBroadcastReceiver -> BroadcastReceiver
- onReceivedDownloadNotification -> onReceivedBroadcast

Bug: 1025662
Change-Id: Ib52429b7ef4ec1c4a85c05a7b7c13a4aa457b48d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137588Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757061}

These tests verify that data flows normally through senders/receivers
of one kind when the peer connection has enabled insertable streams
for the other kind.

These tests cover the changes in
https://chromium-review.googlesource.com/c/chromium/src/+/2139231

Bug: 1068125
Change-Id: If00ab2cc554eae8632cb0a4fb1d010a7fe5fba3f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139213Reviewed-by: Harald Alvestrand <hta@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757060}

Rename {blink->network}::mojom::WebSandboxFlags.

This patch is a step in the following direction:
~~~
Stop parsing the HTTP CSP sandbox header in blink. Parse it in the
network service CSP parser. This allows the browser process to compute
the Origin of the new document before loading it.
~~~
https://docs.google.com/document/d/1PechV73KKMF8leh7uTlyGkR32kD5qILvu3ZeG8TYGfk/edit?usp=sharing

This CL touch many files (Sorry). To easy review, here is the list of
changes to look at:

1) Interesting files:
   - *.DEP
   - services/network/public/cpp/sandbox_flags.h
   - services/network/public/mojom/sandbox_flags.mojom
   - third_party/blink/renderer/core/frame/sandbox_flags.h
   - third_party/blink/public/mojom/feature_policy/feature_policy.mojom

2) The enum blink::kPresentationReceiverSandboxFlags was defined in:
   third_party/blink/...
   .../public/common/presentation/presentation_receiver_flags.h but it
   was not used in blink. It has been moved to the content/browser.  See
   content/public/browser/presentation_receiver_flags.h

3) The operator<<(ostream, Sandbox) is removed. It was defined both in
   sandbox_flags.h and in the generated mojo files. The bot
   "win_chromium_compoile_dbg_ng" was not able to inline the calls and
   ends up with a linker errors. See the trybot for:
   https://chromium-review.googlesource.com/c/chromium/src/+/2062336/4.

TBR=thakis@chromium.org

Bug: 1041376
Change-Id: I9f6cbb3b04ac07ecee22b3fca43cf19a260269cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062336Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Lucas Gadani <lfg@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757059}

Platform keys service functions rely on getting NSS certificate database
to operate on it. Before this CL, platform keys service functions were
retrieving the NSS database using GetNSSCertDatabaseForResourceContext
which expects a user signed in so that it can create the Nss certificate
database by getting a public slot for the signed in chromeos user.
Platform keys service can be used on signin screen for operating on
system token. SystemTokenCertDbInitializer class initializes an NSS
certificate database with only system slot. This CL uses the database
created by SystemTokenCertDbInitializer if on signin screen.

Bug: 1045895, 1067591
Test: For regression testing: browser_tests *PlatformKeys*
Change-Id: I99b58034f3ff611f3c4b6590a07a4a110dc53362
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134255Reviewed-by: Pavol Marko <pmarko@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Commit-Queue: Omar Morsi <omorsi@google.com>
Cr-Commit-Position: refs/heads/master@{#757058}

Focus rings should not animate when set not to animate for tests. We were
reaching a race condition where sometimes
AccessibilityFocusRingGroup::AnimateFocusRings was being called which
may have been moving the focus rings around. This should keep any
animation code from being called during tests so that rings are where
we expect.

Test: Ran tens of times locally with --test-launcher-jobs=500
Bug: 950049, 1067399
Change-Id: I6f374db1d931b7f9d251a3d4264e00655abbeb3e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135831Reviewed-by: Anastasia Helfinstein <anastasi@google.com>
Commit-Queue: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757057}

Change-Id: Ie5915b1d8c8ef6593ae77fa453f73ac288423f45
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140031
Commit-Queue: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Auto-Submit: Joshua Pawlicki <waffles@chromium.org>
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757056}

This CL changes the task type of AudioWorklet to improve the
responsiveness of the task runner when the actual task runner
implementation can prioritize the real-time tasks.

Bug: 1068311
Change-Id: Ifa13e535474a979d15738ecaa24ca08c90a77dfd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138152Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Hongchan Choi <hongchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757055}

This CL adjusts the cursor events for the toggle buttons located inside
the new Safe Browsing radio controls such that disabling the collapse
radio button they are inside does not prevent interaction with the
toggles.

Additionally cursor settings are adjusted such that when the toggles are
disabled because Safe Browsing Standard is not selected, hovering over
them does not display the pointer cursor, incorrectly indicating an
interaction is possible.

Bug: 1067385
Change-Id: I03b3b269af3660f8c16a172d241cbd1100dbe92f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134986Reviewed-by: Esmael Elmoslimany <aee@chromium.org>
Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com>
Cr-Commit-Position: refs/heads/master@{#757054}

An isolated script doesn't see git files, so it can't determine the
revision from repo. So we parse the DEPS file instead.

Bug: b/148778752
Change-Id: Ic156d48f983bb65792f904efdadf6929d9cbc961
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139817Reviewed-by: Eric Seckler <eseckler@chromium.org>
Commit-Queue: Mikhail Khokhlov <khokhlov@google.com>
Cr-Commit-Position: refs/heads/master@{#757053}

* This CL changes the accelerator matching logic so that it
  uses DomKey and convert to VKEY+modifier as if it happened on
  US Keyboard Layout. This allows a user to use the key that produces
  the same key on the other layouts, with additional modifiers.

* Reject "ASCII punctuation + shift only" acccelerator because
  this will not work well on non US keyboard. (We don't and shouldn't
  have such shortcut even now but added just in case)

* Add new shortcuts that doesn't rely on ASCII punctuation for
  virtual desks and display zoom (uses Arrow keys)

* Add new shortcuts for shortcuts that uses alt + punctuation,
  because it can cause ghosting when combined with altgr.
  (snap/minimize/maximize)

See bug for design doc and new shortcut key combination.

Bug: 1067269
Test: covered by unittests. manually tested on chromeos devices.

Change-Id: I1f2eb31923abf9c9b1a901eb6a84689c813d8b53
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124867
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Kevin Schoedel <kpschoedel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757052}

TBR=adithyas@chromium.org,dmazzoni@chromium.org

Bug: None
Change-Id: I05c520ed1ce9e0405e7db2cbc671ea245c834962
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138220Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757051}

Hit testing needs the document lifecycle to be in kCompositingClean.
Fortunately, the lifecycle already is in kCompositingClean.

- Expect caller of hit testing to ensure correct lifecycle
- Add DCHECK for this expectation
- No further lifecycle adjustments
  in AXLayoutObject::AccessibilityHitTest()

Bug: None
Change-Id: Icd9f78fd7d1e96f0d04c5a070ec4640fb6156248
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136038Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Adam Ettenberger <Adam.Ettenberger@microsoft.com>
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757050}

The probe sets DevToolsId and DevToolsToken, so that they can be sent
to the DevTools frontend whenever an issue is detected in the mixed
content check.

Previously DevToolsId and DevToolsToken were set in PrepareRequest(),
which is executed only after the check for mixed content has already
happened. When generating a DevTools issue in the mixed content check,
we need DevToolsId and DevToolsToken to be available. Therefore this
CL adds a core probe, which allows setting DevToolsId and DevToolsToken
earlier.

Bug: chromium:1053468

Change-Id: I42f50ae34dad7a09095447fb398f2af2cc23bd0e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117735
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757049}

https://dawn.googlesource.com/dawn.git/+log/c3c6694d8f0f..2d10e954cec2

git log c3c6694d8f0f..2d10e954cec2 --date=short --first-parent --format='%ad %ae %s'
2020-04-07 cwallez@chromium.org BUILD.gn: rename libdawn_native/wire to dawn_native/wire
2020-04-07 cwallez@chromium.org Split dawn_(native|wire|platform) to their own BUILD.gn files

Created with:
  gclient setdep -r src/third_party/dawn@2d10e954cec2

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-chromium-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
Bug: chromium:1064305
Tbr: cwallez@google.com
Change-Id: I5ee81bc3302286abea38e25f50c2a0fc9acf14e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139942Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#757048}

Fixed: 1051170
Change-Id: I50cc48e9e6acaa3e8b8d835be048ebeff041dfb1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106568Reviewed-by: James MacLean <wjmaclean@chromium.org>
Commit-Queue: Domenic Denicola <domenic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757047}

Replace ChromeSigninController in SigninManager.isSignInAllowed with
IdentityManager.GetPrimaryAccountInfo(). This is safe to do, because
the native side is already loaded if SigninManager exists.

Bug: 1058981
Change-Id: I34d469463fe6d5f03ba8ce02a9efd326474b7ab9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089763Reviewed-by: Alice Wang <aliceywang@chromium.org>
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757046}

ImageDataBuffer may trying to be copying an uninitialized SkImage.
Adding an MSAN check to check before doing the copy to ensure that has
been initialized.

Bug: 1052492
Change-Id: I6cfefffe42f5cf11eaf5119df1352338c2b00010
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134662
Commit-Queue: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Auto-Submit: Juanmi Huertas <juanmihd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757045}

- Wait to perform the exhaustive cleanup operation until all
  uninstallers have been run.
- Fix a bug in CleanRegistryEntry whereby the contents of a "forbidden"
  key were removed but not the key itself.

BUG=698997,1059314
R=zmin@chromium.org

Change-Id: Ib5632dfa5e37631ca7908b2e9833990b4d104fea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139721
Auto-Submit: Greg Thompson <grt@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Reviewed-by: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757044}

This is the "V1" feature. It:
* Creates a new "Sync your settings" section in Chrome OS settings
* Provides a separate toggle for OS preferences, distinct from browser
  preferences
* Moves "Apps" and "Wallpapers" to OS settings
* Makes the OS ModelTypes run in sync transport mode, controlled by a
  master pref for the OS sync feature

This also unblocks the launch of Wi-Fi configuration sync.

Bug: 1013466
Change-Id: Ie203fc96a1cf6a812d4c2b1a7c994d2978964b56
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137999Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757043}

Bug: 1065608
Change-Id: I06a99fbe1ad2d3168ed08503da6b13f7433e906d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139751Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757042}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e29095b1961e..8e129de0bc1a

git log e29095b1961e..8e129de0bc1a --date=short --first-parent --format='%ad %ae %s'
2020-04-07 tmrts@chromium.org [deps] revert "Update DevTools DEPS." containing a depot_tools bug
2020-04-07 sigurds@chromium.org [issues] Add issue counter to console counters in top menu bar
2020-04-07 wolfi@chromium.org Reland "Add infobar about issues panel to console"

Created with:
  gclient setdep -r src/third_party/devtools-frontend/src@8e129de0bc1a

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:1057979,chromium:1061876,chromium:1068126
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I5737b9d9e8ba09452b11351105bd123dfc20280e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139941Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#757041}

Currently payments uses the deprecated org.chromium.url.URI class,
so we should replace URL class with GURL class.
this patch replace it at PaymentHandler area.

Bug: 1065577
Change-Id: I980546c6c57bde62e10401e34cf2cb09a4f814b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2126333Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com>
Cr-Commit-Position: refs/heads/master@{#757040}

The crash is because the VulkanSurface::Reshape() could be fail
for some reason, and then swap_chain_ in VulkanSurface could be
nullptr, accessing the nullptr swap_chain causes the crash.
Fix the problem by checking the return value of Reshape call of
VulkanSurface. If it returns false, VulkanSurface::Reshape() will
return false too. So the SkiaOutputSurfaceImplOnGpu will handle
it, and mark context lost.

TODO: investigate why reshape() fail with NVIDIA GPU.

Bug: 1062728
Change-Id: I3defd05466d98448599e5fc836ac229c2ce35b84
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139938Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757039}

"Settings sync" (aka OS sync) has a gear icon.
"Chrome sync" has the sync arrows logo.

https://screenshot.googleplex.com/R1h1o2EfxMY

The spacing of the second icon is still wrong, but I'll pursue that in a
follow up CL, because I may have to restructure the HTML.

Bug: 1067212
Change-Id: Ie40e75b1d245c8b0c4f74799204f61f295e61a02
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137869Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757038}

This reverts commit b4687c72.

This WPT testcase is failing on FF and Safari because its chrome
specific behaviour.

feConvolveMatrix does specify conditions for attributes but does not
specify what happens if those conditions were not fulfilled by the
author and there is a on going dicussion in W3C github [1].

[1] https://github.com/w3c/fxtf-drafts/issues/237

Bug: 1063749
Change-Id: I56ae0883f9891ff336128e5b3e15014c7e4b384f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138937Reviewed-by: Fredrik Söderquist <fs@opera.com>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com>
Cr-Commit-Position: refs/heads/master@{#757037}

Change files from cpp to objc++.
CredentialProviderService will use Objective-C classes, and needs to be
converted to Objective-C++ instead of C++.

Bug: 1066803
Change-Id: Ibd74a815177cb05b84bf05ee423ad3342c02a53d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139652
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Auto-Submit: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757036}

This CL ensures that a sender or receiver gets at most one transformer
and that the transformer is of the correct type.
Prior to this CL, it was possible for an audio sender or receiver
to get a video transformer if insertable streams were enabled for
video. This resulted in data not flowing due to no transformer
being set, or in crashes due to the wrong type of transformer being
executed.

Tests added in
https://chromium-review.googlesource.com/c/chromium/src/+/2139213

Bug: 1068125,1068164
Change-Id: I68a701098b09e0dfc8edaec82bc7161ae686b915
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139231
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757035}

This CL removes unneeded public API from the BVC, primarily the public
dispatcher property. The NTP perf test and the BVC unit tests were the
remaining places where these dependencies were used.

In addition to the command dispatcher, the public TabModel and
BrowserState properties of the BVC are removed. Some other properties
(FullscreenController, TypingShield) are just moved internally.

The ContentArea property was only used in the BVC unit test, and only
to check that the BVC was attached to the containing view controller.
Since the container is provided to the BVC as well, that can be tested
without using any direct BVC API.

Other minor cleanup:

 - Some BVC includes are pruned.
 - Internally, the protocols that the dispatcher conforms to are
   reduced in number.
 - The internal -shieldWasTapped: method was removed, since
   it just forwarded to the dispatcher.

Change-Id: I2f0ae3382e32867e5aad7a083b8fcbbb384b5c53
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135620
Commit-Queue: Mark Cogan <marq@chromium.org>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757034}

Enforcing the layout constraint for 20% image height in the sign-in
view.

https://drive.google.com/open?id=1hwaiM1Oj3C_mLUQQqvzwNwSmJwVB_rIk
(blue and yellow color are just for debug reasons, not part of this
patch)

Related:
https://chromium-review.googlesource.com/c/chromium/src/+/1543399

Bug: 971989
Change-Id: Id4f1792203dfb11e70dea715ef2700b74e1b5cd2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139714Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Auto-Submit: Jérôme Lebel <jlebel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757033}

The -[GradientView updateColors] needs to be called at least once, to
initialize correctly the gradient colors.

Before:
https://drive.google.com/open?id=1WJnG8ahbljpr0hSR8fut8ezGyIJ1i9s6
After:
https://drive.google.com/open?id=1y0xTlrpu3ssvrlw7Kx05d5lqK56a1-Ko
(the blue background was set just for the screenshots)

Bug: 971989
Change-Id: I08c1fe12f5b142fde038da9b779a7399f1771f3b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133937
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Auto-Submit: Jérôme Lebel <jlebel@chromium.org>
Reviewed-by: Nohemi Fernandez <fernandex@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757032}

https://skia.googlesource.com/skia.git/+log/852ebea2d55d..24627887555a

git log 852ebea2d55d..24627887555a --date=short --first-parent --format='%ad %ae %s'
2020-04-07 westont@google.com Changing ~everything (mostly recipe related stuff) to reference Debian10 jobs

Created with:
  gclient setdep -r src/third_party/skia@24627887555a

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC csmartdalton@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: csmartdalton@google.com
Change-Id: Ib85001ffe182a5126854da6ac85422dc2d4e22c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139934Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#757031}

https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/b5757b95005b..9c3204a1fde0

git log b5757b95005b..9c3204a1fde0 --date=short --first-parent --format='%ad %ae %s'
2020-04-07 cepheus@frii.com Error message: Finish addressing #2097, better texture error message.

Created with:
  gclient setdep -r src/third_party/glslang/src@9c3204a1fde0

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/glslang-chromium-autoroll
Please CC radial-bots+chrome-roll@google.com,jonahr@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64
Bug: None
Tbr: radial-bots+chrome-roll@google.com,jonahr@google.com
Change-Id: Ibdb9205a6f3ce9c832352d5059f073ffe7701f06
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139376Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#757030}