GitLab

BUG=chromium-os:29835
TEST=1. Double click on an image A to open the Gallery, navigate to image B in the Gallery, exit the Gallery. Image B should be selected in the File Manager.
2. Select several images, click "Open", exit the Gallery. The selection should stay the same.

Review URL: https://chromiumcodereview.appspot.com/10184008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133647 0039d316-1c4b-4281-b951-d872f2087c98

IDL defines close behavior as it ignores the reason argument if the type of
reason is PP_VARTYPE_UNDEFINED.

BUG=124609
TEST=browser_tests --gtest_filter='*WebSocket*'


Review URL: http://codereview.chromium.org/10167028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133646 0039d316-1c4b-4281-b951-d872f2087c98

This change suppresses NSS leaks happening after changing the "Chromium OS Heapcheck" bot from i386 to x86_64.

TBR=thakis
BUG=51988
TEST=make the "Chromium OS Heapcheck" bot greener.
Review URL: https://chromiumcodereview.appspot.com/10206012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133645 0039d316-1c4b-4281-b951-d872f2087c98

Replace them with GetOperationRegistry(), in favor of less
public member functions from GDataFileSystem class, which is
overly large.

BUG=chromium-os:29813
TEST=compiles

Review URL: https://chromiumcodereview.appspot.com/10196007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133644 0039d316-1c4b-4281-b951-d872f2087c98

Make functions being routed by NativeHandlers throw an exception if there is no ModuleSystem in the current context.


BUG=124208
TEST=existing tests


Review URL: http://codereview.chromium.org/10208001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133643 0039d316-1c4b-4281-b951-d872f2087c98

This CL is for crbug.com/123856 (Aura shell applies accelerators without giving apps the option of handling key events). Currently, shortcuts for IME/layout switching (Shift+Alt, Ctrl+space, and so on) are processed before InputMethodEventFilter, and other Ash global shortcuts are processed after the filter. This is for ensuring that the IME shortcuts always work even if an IME (or an IME extension - http://dev.chromium.org/developers/design-documents/extensions/proposed-changes/apis-under-development/input-method-editor) tries to consume the shortcuts. However, this strategy is not compatible with crbug.com/123856. In order to fix crbug.com/123856, we sometimes have to process an Ash global shortcut key (including IME ones) after the key is passed to a web page.

This CL modifies accelerator_table.cc and shell.cc so that they process IME shortcuts after InputMethodEventFilter, and also simplifies ash/accelerators/ and ui/base/accelerators/accelerator_manager.cc by removing code for processing pre-IME shortcuts.

BUG=123856
TEST=ran aura_shell_unittests and ui_unittests

Review URL: https://chromiumcodereview.appspot.com/10155015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133642 0039d316-1c4b-4281-b951-d872f2087c98

BUG=124605
TEST=none


Review URL: http://codereview.chromium.org/10175005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133641 0039d316-1c4b-4281-b951-d872f2087c98

This change adds suppression rules for the leaks happening in the above test. Also, it removes an obsolte suppression for GoogleURLTrackerTests.

TBR=thakis,pkasting
BUG=124766
TEST=make the "Linux Test (valgrind)(8)" bot, the "Linux Heapcheck" bot, and the "Chromium OS Heapcheck" bot greener.
Review URL: https://chromiumcodereview.appspot.com/10203007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133640 0039d316-1c4b-4281-b951-d872f2087c98

Replace them with GetCacheDirectoryPath(), in favor of less
public member functions from GDataFileSystem class, which is
overly large.

Wanted to make them just utility functions in gdata_util.cc
but turned out we needed Profile* to compute these directory paths.

BUG=chromium-os:29813
TEST=compiles

Review URL: https://chromiumcodereview.appspot.com/10198003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133639 0039d316-1c4b-4281-b951-d872f2087c98

BUG=114148
TEST=browser_tests --gtest_filter=ExtensionApiTest.FontSettings


Review URL: http://codereview.chromium.org/10177003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133638 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10207005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133637 0039d316-1c4b-4281-b951-d872f2087c98

This was a bit tricky since some of the functions had no instance context, so I added global functions on the PpapiGlobals interface for them. It would be nice to add a PP_Instance argument and fix this in the future.

I did a new style of doing the thunking. The "function APIs" haven't really worked out since it's almost always easier to add the functions directly on the instance one. Since this is a larger and more separable chunk, I just added a getter on the instance API for the flash API and thunk through that. I'd like to convert the remaining ~3 function APIs to either call directly on the instance or use this method, but that's not addressed by this patch.

I moved the flash command line switch to plugin_switches so this could be hooked up properly. It allowed me to delete the delegate API for this.

I combined the flash fullscreen functions into the new Flash API which removed a bit of code.

Review URL: https://chromiumcodereview.appspot.com/10091003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133636 0039d316-1c4b-4281-b951-d872f2087c98

This change updates suppression rules for Bug 90013 to remove unknown symbols as much as possible. We need to install more debug symbols, though.

TBR=thakis
BUG=90013
TEST=make the "Chromium OS Heapcheck" bot greener.
Review URL: https://chromiumcodereview.appspot.com/10140015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133635 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10206007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133634 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:16557
TEST=unit_test --gtest_filter="CrosNetworkFunctions*"


Review URL: http://codereview.chromium.org/10162027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133632 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:16557
TEST=unit_tests --gtest_filter="CrosNetworkFunctions*"

Review URL: https://chromiumcodereview.appspot.com/10134028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133631 0039d316-1c4b-4281-b951-d872f2087c98

This change widens a suppression rule for Bug 51988, widens the suppression rule for Bug 119677, and adds a new rule for Bug 124758.

TBR=thakis
BUG=51988,119677,124758
TEST=make the "Chromium OS Heapcheck" bot greener.
Review URL: https://chromiumcodereview.appspot.com/10155021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133630 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:16557
TEST=unit_tests --gtest_filter="CrosNetworkFunctions*"

Review URL: https://chromiumcodereview.appspot.com/10164026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133629 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=build success


Review URL: http://codereview.chromium.org/10163016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133628 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133627 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133626 0039d316-1c4b-4281-b951-d872f2087c98

BUG=112749
TEST=See 112749 or 121262 for the test case that works now.


Review URL: http://codereview.chromium.org/10084022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133625 0039d316-1c4b-4281-b951-d872f2087c98

Modify FlimflamDeviceClient's PIN operation methods and Register to use CallMethodWithErrorCallback
Modify FlimflamServiceClient::Connect to use CallMethodWithErrorCallback

BUG=chromium-os:16557
TEST=chromeos_tests

Review URL: https://chromiumcodereview.appspot.com/10170020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133624 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=more angry emails
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/10200009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133623 0039d316-1c4b-4281-b951-d872f2087c98

The JSON schema compiler can now handle binary data as an
internal type.

BUG=123687
TEST=None


Review URL: http://codereview.chromium.org/10198005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133621 0039d316-1c4b-4281-b951-d872f2087c98

Trace events collected from suid sandbox'd threads need to report
their real pid and not the sandbox'd pid so data can be correlated
with system event data.

BUG=chromium-os:27809
TEST=check sandbox'd trace data against the output of ps

Change-Id: Ia8c7725ac6e4f18a2114de027a5d19ba15f49e60


Review URL: http://codereview.chromium.org/10165015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133619 0039d316-1c4b-4281-b951-d872f2087c98

A user reported a case where their safe-browsing database was not
updating.  Corrupt data in the add_chunks and sub_chunks area was
causing a 413 server response (even though the post was not
excessively large).  This change explicitly checks the checksums,
causing invalid databases to be reset.

This case could happen if the user's computer crashes before a
previous update was entirely committed to disk.  In most cases,
finalizing the next update would detect the corrupt data, but in this
case he error response from the server prevented the corruption from
being detected.

BUG=120219
TEST=none

Review URL: http://codereview.chromium.org/10093004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133618 0039d316-1c4b-4281-b951-d872f2087c98

BUG=124642
TEST=none


Review URL: http://codereview.chromium.org/10180008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133617 0039d316-1c4b-4281-b951-d872f2087c98

1) Don't pass the path as the site. We don't support site-specific clearing,
   so just pass an empty string.
2) Append the plugin's name to the profile-specific Pepper data directory.


Review URL: http://codereview.chromium.org/10202002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133616 0039d316-1c4b-4281-b951-d872f2087c98

Remove DOMView.

BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10171006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133615 0039d316-1c4b-4281-b951-d872f2087c98

BUG=124736

Review URL: https://chromiumcodereview.appspot.com/10155020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133614 0039d316-1c4b-4281-b951-d872f2087c98

Currently all 1x art files are repacked into chrome.pak files.

This is a problem on Windows where we want to choose which pak file to load based on metro and DPI scale.

As a first step this CL does the following:
 - add a new enable_hidpi build flag. This allows us to test HiDPI mode on Windows Chrome.
 - stop packing theme_resources_standard.pak and ui_resources_standard.pak into chrome.pak
 - update the Mac and Windows installer code to package the extra pak files.

Note, I'll be updating the Linux installer script in a separate CL. I'm still looking into the ChromeOS situation.

BUG=114311
TEST=Ran on Windows, and Mac and Linux.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132517

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132760

Review URL: https://chromiumcodereview.appspot.com/10024050

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133613 0039d316-1c4b-4281-b951-d872f2087c98

This change updates a couple of suppression rules started after switching "Chromium OS" memory bots from i386 to x86_64.

TBR=thakis
BUG=68069,119677
TEST=make the "Chromium OS UI (valgrind)" bots and the "Chromium OS Heapcheck" bot greener.
Review URL: https://chromiumcodereview.appspot.com/10196008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133610 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:25279
TEST=visual inspection of changes since R18
TBR=zelidrag

Review URL: http://codereview.chromium.org/10065004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133609 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:27899
TEST=build success

Review URL: https://chromiumcodereview.appspot.com/10168027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133608 0039d316-1c4b-4281-b951-d872f2087c98

On the Mac, we populate NSImage from bitmaps in resource bundles. Introduce ImageSkia which contains vector of SkBitmaps. Previously this functionality was within ImageRepSkia. ImageSkia exposes this.

Move gfx::Image::GetSkBitmapAtIndex and gfx::Image::GetNumSkBitmaps to ImageSkia

BUG=122992
TEST=None

Review URL: http://codereview.chromium.org/10086023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133607 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=build with chromeos=0/1 use_titlecase=0/1


Review URL: http://codereview.chromium.org/10167025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133606 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=Manual

Review URL: https://chromiumcodereview.appspot.com/10198006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133605 0039d316-1c4b-4281-b951-d872f2087c98

Fix gesture events and touch events to scale delta and touch radius information as well

Review URL: http://codereview.chromium.org/10175002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133604 0039d316-1c4b-4281-b951-d872f2087c98

- Make LauncherView::CalculateIdealBounds to return last visible index;
- In LauncherView::LauncherItemAdded, use the last visible index to determine if
  we need the animation;

BUG=122482
TEST=Verify fix for issue 122482.


Review URL: http://codereview.chromium.org/10068027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133603 0039d316-1c4b-4281-b951-d872f2087c98