GitLab

We currently refer to displays with integer display_ids. This patch
changes them to display::Display for better type safety. It also allows
us to remove some code in display_utils.

Change-Id: Ib996613eebf1b7dcb32e5b683ad33fe6c6a6d084
Reviewed-on: https://chromium-review.googlesource.com/1056932Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558914}

This CL makes MockScriptLoader::IsReady() just to call
PendingScript::IsReady(), and mocks PendingScript::IsReady() instead.

This is to remove ScriptLoader dependency from IsReady(), and
in a subsequent CL [1] ScriptLoader::IsReady() is replaced with
PendingScript::IsReady()

This requires MockScriptLoader to have a corresponding
MockPendingScript reference, and thus this CL adds
MockScriptLoader::mock_pending_script_.

MockScriptLoader::mock_pending_script_if_script_is_async_
will be removed in [1].

[1] https://chromium-review.googlesource.com/1053220

Bug: 842349
Change-Id: Ia61b3ccbeb175bece4add5c0a4f2a542118f0f26
Reviewed-on: https://chromium-review.googlesource.com/1041072Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558913}

The comment implies that a review from one of these owners is required,
however owners of the directories in which permission_context files live
can also approve changes.

Change-Id: I94c7c8eb48340bd04214d02f42d5482805f0229f
Reviewed-on: https://chromium-review.googlesource.com/1059978Reviewed-by: Timothy Loh <timloh@chromium.org>
Commit-Queue: Raymes Khoury <raymes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558912}

https://chromium.googlesource.com/native_client/src/native_client.git/+log/f9564e9d1b15..93deff44b49f

$ git log f9564e9d1..93deff44b --date=short --no-merges --format='%ad %ae %s'
2018-05-15 thomasanderson Fix arm build with glibc 2.27

Created with:
  roll-dep src/native_client
BUG=chromium:843240


The AutoRoll server is located here: https://nacl-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mseaborn@chromium.org

Change-Id: I0b78d4f6fc37182149fbf7c70e55751edc47706d
Reviewed-on: https://chromium-review.googlesource.com/1060567
Commit-Queue: nacl-chromium-autoroll <nacl-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: nacl-chromium-autoroll <nacl-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#558911}

Refactor and clean up BoxPainterBase to improve legibility and to reduce
code duplication.

Bug: 714962
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ib738b19e62117046391a9c7b45dcddd1c2ecbb23
Reviewed-on: https://chromium-review.googlesource.com/1060568Reviewed-by: Stefan Zager <szager@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558910}

Bug: 843369,841789
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Id6c695fc7aa3e4ae3019d3b82568dd1453385ebb
Reviewed-on: https://chromium-review.googlesource.com/1060521
Commit-Queue: James Darpinian <jdarpinian@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558909}

Notable changes:

1.) Use C-functions helpers instead of WebIntTest method. This will
    allow to switch NavigationAndLoadCallbacksTest to a simpler base
    class in the future.
2.) Added test::WaitForPageToFinishLoading C-function, which can be
    used across multiple tests to wait for pageload.
3.) Removed extra usage of web:: because NavigationAndLoadCallbacksTest
    is already placed into web namespace.
4.) Removed web_state()->SetDelegate(nullptr); calls, because unlike
    WebIntTest, WebTestWithWebState does not set a web delegate.

Bug: None
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: If5f26f1da40a90fde6378964b0f29a6ac30c16bb
Reviewed-on: https://chromium-review.googlesource.com/1056203
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558908}

This reverts commit 1726f18f.

Reason for revert: crbug.com/843199 Chrome fails to start on Win7 bots due to app compatibility dialog popping up

Original change's description:
> Reland "Reland "win: Link with lld instead of link.exe by default""
>
> This reverts commit de77cb76.
>
> Reason for revert: https://crbug.com/842408 should now be fixed.
>
> Original change's description:
> > Revert "Reland "win: Link with lld instead of link.exe by default""
> >
> > This reverts commit a25e3672.
> >
> > Reason for revert: broke Windows tests using ANGLE's GL back-end.
> > Breaks the CQ for graphics-related tests, and ANGLE's CQ.
> >
> > example builds:
> > https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20FYI%20Release%20%28NVIDIA%29/1063
> > https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20FYI%20dEQP%20Release%20%28NVIDIA%29/3528
> >
> > Original change's description:
> > > Reland "win: Link with lld instead of link.exe by default"
> > >
> > > The nacl browser_test failures on Win7 that caused the last revert are fixed.
> > > There's a known bug about this regressing binary size (crbug.com/838449),
> > > but with in-progress patches binary size will soon be 200 kB smaller and
> > > these should all be rolled in by branch point, so let's reland this to find
> > > more unknown unknowns.
> > >
> > > Original change's description:
> > > > win: Link with lld instead of MSVC's link.exe by default
> > > >
> > > > lld is LLVM's linker. It produces PE/COFF and PDB files just like
> > > > link.exe, but it's significantly faster and it can also handle LLVM's
> > > > internal representation, which will enable us to do link-time
> > > > optimization and control-flow integraty checks with Clang.
> > > >
> > > > While lld is much faster at linking, it doesn't support incremental
> > > > links, meaning builds that only touch a few files and re-link a large
> > > > executable may become slower.
> > > >
> > > > This is the first attempt at switching everything over, with the
> > > > purpose of gathering data and finding unknown unknowns. It's likely
> > > > temporary until something breaks.
> > > >
> > > > is_win_fastlink is implicitly ignored when using lld, as lld without
> > > > fastlink is faster than link.exe with it.
> > > >
> > > > Also switch the CrWinClangLLD bots on chromium.clang to use MSVC's
> > > > link.exe to make sure that configuration keeps working.
> > > >
> > > > Bug: 792131
> > >
> > > Change-Id: I18aba7a66c54c87092a13745f0ca213171ec25db
> > > Reviewed-on: https://chromium-review.googlesource.com/1054521
> > > Commit-Queue: Nico Weber <thakis@chromium.org>
> > > Reviewed-by: Reid Kleckner <rnk@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#557987}
> >
> > TBR=thakis@chromium.org,rnk@chromium.org
> >
> > Change-Id: Ida516adc6708c59407b817c8425c14bd3153d5b8
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Reviewed-on: https://chromium-review.googlesource.com/1056327
> > Reviewed-by: Jamie Madill <jmadill@chromium.org>
> > Commit-Queue: Jamie Madill <jmadill@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#558055}
>
> TBR=thakis@chromium.org,rnk@chromium.org,jmadill@chromium.org
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Change-Id: Ided62bd7fb25d17d7a318539f41c308fb738797e
> Reviewed-on: https://chromium-review.googlesource.com/1057767
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Commit-Queue: Nico Weber <thakis@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#558402}

TBR=thakis@chromium.org,rnk@chromium.org,jmadill@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: Ifdea343a643c790b531737be6bfac9c765a355c2
Bug: 792131, 843199
Reviewed-on: https://chromium-review.googlesource.com/1059860
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558907}

NoTry: true
Change-Id: Ibe620664f28f16338e5860ebc24c7ca89941b095
Reviewed-on: https://chromium-review.googlesource.com/1060170Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558906}

The event dispatcher synthesizes mouse move events add feeds it to
FullscreenControlHost immediately after the browser enters fullscreen,
which interferes with the tests and makes the tests somewhat flaky.

This CL prevents WindowEventDispatcher from synthesizing mouse move
events. Note that this doesn't effect mouse move events coming from a
real device.

Bug: 841340
Change-Id: I850e4719e94c6a46dfbf14ae6a542b6ad76c6b7f
Reviewed-on: https://chromium-review.googlesource.com/1058557
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558905}

This CL removes special exceptions made for renderer side navigation for the
DeclarativeNetRequestResourceTypeBrowserTest. This is no longer needed as
renderer side navigation is deprecated.

BUG=696822

Change-Id: I8ef1c2cae5efdbeded1a9d715fbd26b3acb884c7
Reviewed-on: https://chromium-review.googlesource.com/1056495Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558904}

This behavior is defined in the HTML spec:

  Step 13: "If the algorithm asynchronously completes with null, queue a task to
  fire an event named error at worker, and return."
  https://html.spec.whatwg.org/multipage/workers.html#worker-processing-model

An ErrorEvent is created on a worker thread, and passed to the main thread to
dispatch it on a worker object in a document context.

Bug: 843031
Change-Id: I1fd82cba1e02b1658bb2b556742f7a206ee754a7
Reviewed-on: https://chromium-review.googlesource.com/1058998
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558903}

This doesn't include client notification, but it's a good point to
send out for review.

BUG=837696
TEST=covered by tests

Change-Id: I38450a98efa24ee96a3273d3cebe1ea6bc87a5da
Reviewed-on: https://chromium-review.googlesource.com/1060420
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558902}

This CL moves two webRequest auth events related browser tests to a new
category.

Bug: 841827
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I09d64ad7aef47c5388151b7e7ae50b0db382cfb1
Reviewed-on: https://chromium-review.googlesource.com/1060306Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Jun Cai <juncai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558901}

1) Updates the script that executes the tests on the swarming bot by
accepting a flag for the benchmark to shard map.  We now have at least
three use cases for this: main perf waterfall android and desktop,
smoke testing, testing on our trybot and potentially android go.

2) Updates the custom merge script to not upload perf results when
we are in smoke test mode.

Bug:840427
Change-Id: Idec8f45cc2d1b5a3cd336ef3d1698d3d86161ba3

NOTRY=true  # win_7_chromium_rel_ng flaky

Change-Id: Idec8f45cc2d1b5a3cd336ef3d1698d3d86161ba3
Reviewed-on: https://chromium-review.googlesource.com/1055614
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#558900}

This class represents a two-way communication channel which is
authenticated and encrypted.

This CL also integrates this class with the rest of the classes in
//chromeos/services/secure_channel.

Bug: 824568, 752273
Change-Id: Ic72a026002f2c229d20b9b355078e8b43c281119
Reviewed-on: https://chromium-review.googlesource.com/1058834
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558899}

This allows WebBT to work if we were connected before or after the WebBT
application starts.

Remove BluetoothAdapterCast::OnServicesUpdated because Connect now
implies services are discovered. Dynamic service updating is also
deprecated:
https://cs.chromium.org/chromium/src/device/bluetooth/bluetooth_adapter.h?rcl=21e8d8c8dc11cd4b8f77c47b7f37098ebde13d3a&l=142

BUG=internal b/79542125
TEST=device_unittests. Manual

Change-Id: I99ed5dc61942cb310ed76581648fdab6c31316a1
Reviewed-on: https://chromium-review.googlesource.com/1058605
Commit-Queue: Bailey Forrest <bcf@chromium.org>
Reviewed-by: Stephen Lanham <slan@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558898}

Record the encryption scheme reported in the video for both the audio and
video streams. Reported when the first AudioDecoderConfig/VideoDecoderConfig
is seen for the file.

BUG=658026
TEST=tested locally

Change-Id: Id210e18f0cedc11800abdce5286eb8488271516a
Reviewed-on: https://chromium-review.googlesource.com/1038784Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Commit-Queue: John Rummell <jrummell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558897}

This CL:
1, Added a static separator between header and web contents
2, Removed site settings' icon

Bug: 840803
Change-Id: I0a2cfdf1f5d6d128054faec5edde0ba3d390f28e
Reviewed-on: https://chromium-review.googlesource.com/1057409Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Commit-Queue: Ganggui Tang <gogerald@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558896}

BUG: 726621
Change-Id: I48fcd9addcf7a056563efa023ed1eea305f27233
Reviewed-on: https://chromium-review.googlesource.com/1060021Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Commit-Queue: apacible <apacible@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558895}

Currently, the initial media control state for play/pause is incorrect.
It shows the opposite control than intended.

Tests forthcoming in a future patch once we have test infrastructure
set up.

BUG: 836389
Change-Id: Ie7be9bfb384f62ac925d6cb1c1ee30cc6baf2cfc
Reviewed-on: https://chromium-review.googlesource.com/1060244Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Commit-Queue: apacible <apacible@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558894}

Currently, DragDescriptor is a simple class with a bunch of getters.
The C++ style guide suggests that DragDescriptor is better off as a
struct.

Change-Id: I0b982aea715627226bb2cd3ff924cde0d3c61f7c
Reviewed-on: https://chromium-review.googlesource.com/1056942Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558893}

Generated by luci-check.

Change-Id: I8fbba7ab4df17dd2dd1db07a17fb4bace6304aa9
Reviewed-on: https://chromium-review.googlesource.com/1060562
Commit-Queue: Ryan Tseng <hinoka@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558892}

This is just an internal cleanup / refactor and has no functional changes.

Change-Id: I4a90d631d5e66822d47df3cc521d6095c6f141fe
Reviewed-on: https://chromium-review.googlesource.com/1054197Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558891}

Suspected flags are flipped back to see if the cronet perf regression is fixed:
FLAGS_quic_reloadable_flag_quic_simplify_pacing_sender,
FLAGS_quic_reloadable_flag_quic_incremental_loss_detection,
FLAGS_quic_reloadable_flag_quic_enable_ack_decimation,
FLAGS_quic_reloadable_flag_quic_early_retransmit_detects_in_flight_packet_lost.

Bug: 842677
Change-Id: I86bbd84988de2f2eb5933d58d9c43c7a12a88b02
Reviewed-on: https://chromium-review.googlesource.com/1060426Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Zhongyi Shi <zhongyi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558890}

As part of issue 787924, we will no longer handle gesture pinch events
on the main thread. We now run the relevant layout tests with
--enable-threaded-compositing

Bug: 787924, 787615
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I818a8eef8ada92bc4ba9c297f2165cf906e00c2f
Reviewed-on: https://chromium-review.googlesource.com/1026035
Commit-Queue: Kevin McNee <mcnee@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Reviewed-by: ccameron <ccameron@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558889}

Newer versions of rpmlib add the dependency "rpmlib(FileDigests) <= 4.6.0-1".
The only distro where this requirement would not be satisfied is RHEL 5, which
has extended support until 30 November 2020, but we've already broken support on
that release anyway.

The lack of listing rpmlib(FileDigests) as an expected dependency was causing
the RPM build to fail on gLinux, so this CL adds it.  Additionally, it's added
as a manual dependency to prevent the RPM build from breaking when using older
versions of rpmlib (like on the bots).

BUG=None

Change-Id: I243e49330d938795c2b1e502004294e80ee722ac
Reviewed-on: https://chromium-review.googlesource.com/1060077
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558888}

This fixes a bug where if STS was on in the login screen, it would not work
properly once logging in, because the profile for the loader was incorrect.

Bug: 843269
Change-Id: Id0f176d4be85258b0e0358274078e339db52c91e
Reviewed-on: https://chromium-review.googlesource.com/1060454Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558887}

This reverts commit 57b825bc.

Reason for revert: Speculatively reverting to see if it unbreaks `sizes` on Google Chrome Mac on chromium.chrome; see crbug.com/843351 and https://ci.chromium.org/buildbot/chromium.chrome/Google%20Chrome%20Mac/33204

Original change's description:
> Roll buildtools a9e946f166..e0b3d0a721
> 
>   In order to roll GN 0fbf0789..ccbeab67 (r555198:r558753) and pick up
>   the following changes:
> 
>   443b70db Fix GN doc formatting.
>   e8a3ce91 GN: do not make indirect dependency to direct dependency
>   ea15ea06 Fully move PathService into the base namespace.
>   ae62ba99 GN: Make the linker output file depend on the inputs.
>   629ba73c [MessageLoop] Fix message_loop.h includes
> 
> TBR=brettw@chromium.org
> 
> Change-Id: I982bbe01bad86a66e7aed379ee1155bdfaa76ff8
> Reviewed-on: https://chromium-review.googlesource.com/1060095
> Commit-Queue: Dirk Pranke <dpranke@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#558795}

TBR=brettw@chromium.org,dpranke@chromium.org

Change-Id: I738965808d3c746b0b61e752511634f118a07e39
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/1059861Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558886}

The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio
TBR=cr-fuchsia+bot@chromium.org

Change-Id: I270979d123425a08f19387536f2723199f1a7d33
Reviewed-on: https://chromium-review.googlesource.com/1060559
Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#558885}

This change removes PageLoad.Clients.DataReductionProxy.LoFiOn.* and
adds PageLoad.Clients.Previews.LitePages. The key difference in these
two histograms is the earlier triggers for all pages that use server
LoFi or server LitePages, whereas the new UMA will only trigger for
pages that use server LitePages.

Bug: 720035
Change-Id: I48c6f349aa5e1a6dfc2e261729ca8d3d624cb08d
Reviewed-on: https://chromium-review.googlesource.com/1060098Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558884}

Bug: 733662
Bug: 826609
Change-Id: I48905b1983db528043cf89a4ec24f56e7cfe8698
Reviewed-on: https://chromium-review.googlesource.com/1056447Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Jiaquan He <hejq@google.com>
Cr-Commit-Position: refs/heads/master@{#558883}

We no longer need to display withheld permissions in the
extension install prompt, even with the runtime host permissions
feature enabled. Clean up the relevant code.

Bug: 841099

Change-Id: If295d36859f8664928c83923a010057f2fb4d1c1
Reviewed-on: https://chromium-review.googlesource.com/1053178Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558882}

Revert "Alias 4KB at the beginning of JSONParser::ConsumeDictionary() to help diagnose issue 791487."

This reverts commit f09eb6cc.

Reason for revert: diagnosis of issue complete.

Original change's description:
> Alias 4KB at the beginning of JSONParser::ConsumeDictionary() to help diagnose issue 791487.
> 
> R=​siggi@chromium.org
> 
> Bug: 791487
> Change-Id: I4535df5a52167f2f5b10424a07e035e1c46e8cfb
> Reviewed-on: https://chromium-review.googlesource.com/850722
> Commit-Queue: Gabriel Charette <gab@chromium.org>
> Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#527154}

TBR=gab@chromium.org,siggi@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 791487
Change-Id: Ic9dff2009411498a97ba3c1e488254414659a5ef
Reviewed-on: https://chromium-review.googlesource.com/1059735Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558881}

Unexpectedly, the test seems to randomly time out on Win dbg bots only.
Disable the test for debug builds, with a TODO to root-cause/revisit to
fix and re-enable.

TBR=olka@chromium.org

Bug: 842428
Change-Id: I8524c31247f452675e6c91d4ac5c3fc471a9525e
Reviewed-on: https://chromium-review.googlesource.com/1059858Reviewed-by: Yuri Wiitala <miu@chromium.org>
Commit-Queue: Yuri Wiitala <miu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558880}

TBR=inferno@chromium.org,tsepez@chromium.org

Bug: 789981
Change-Id: Iaf8f289ca01a78c194a54a5ecdbb9ca3c13a057d
Reviewed-on: https://chromium-review.googlesource.com/1060527
Commit-Queue: Max Moroz <mmoroz@chromium.org>
Reviewed-by: Max Moroz <mmoroz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558879}

This reverts commit f948761e.

Reason for revert: Re-enabling VR for M-68 on standalones.

Original change's description:
> VR: Disable VR on standalone VR devices.
>
> Bug: 841850
> Change-Id: I0249210c8fe387a3732715be2650ce9aea5af800
> Reviewed-on: https://chromium-review.googlesource.com/1054211
> Reviewed-by: Biao She <bshe@chromium.org>
> Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#557623}

TBR=bshe@chromium.org,mthiesse@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 830041
Change-Id: I02ba6b8adb27293cdc67b1c4676ae2eb208a346b
Reviewed-on: https://chromium-review.googlesource.com/1060382
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558878}

Disables support by default for PAC script file URLs when network
service is enabled. This is in preparation for sandboxing the network
service which won't have access to the file system anymore.
Eventually we'll disable it without the network service.

Bug: 839566
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Iee68c35615f3566f0eac7a5d9ae39a28eb3d1b8d
Reviewed-on: https://chromium-review.googlesource.com/1043097
Commit-Queue: Jay Civelli <jcivelli@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558877}

Bug: 768881
Change-Id: Ie82d66ef053ea88461ae9d65eface09e513ba3c7
Reviewed-on: https://chromium-review.googlesource.com/1057432
Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558876}

BUG=843212

Change-Id: Iab38833fabfe1c6729c76419d50e39cfe7eb098a
Reviewed-on: https://chromium-review.googlesource.com/1060384Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558875}