- 20 Dec, 2019 40 commits
-
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: Ie7b7b6806f5d40baa6e1a4046911169859709aa3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979106Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#726921}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/47e7bed70800..efb804d60cd7 git log 47e7bed70800..efb804d60cd7 --date=short --first-parent --format='%ad %ae %s' 2019-12-20 chonggu@google.com [Telemetry] Add Fuchsia device support. Created with: gclient setdep -r src/third_party/catapult@efb804d60cd7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC nuskos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1014642 Tbr: nuskos@google.com Change-Id: I2debf26ffc9dffbf9965736c745b539f70f4eeea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978152Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#726920}
-
Stephen Chenney authored
The new Graphics.Smoothness.Latency event reports the latency of each pipeline stage, along with flags for which frame sequences are active for the frame and whether the frame missed the deadline. The Viz breakdown is reported but not the Blink breakdown because the latter duplicates data found in the Blink.UpdateTime event (and shortly the frame sequence info will be added to Blink's event, if possible). Note that the event and sampling strategy has been designed to optimize the data quality for a given data volume. The UKM dashboard will have the latency info but not the frame sequence info because aggregated frame sequence type information is not useful. The sampling strategy mirrors that of Blink.UpdateTime because both potentially generate an event on every single frame, and we want to sensibly pick an informative set of frames within the available data volume. Note that the sampling rate is tuned in coordination with the UKM team. The UKM collection request has been approved here: https://docs.google.com/document/d/1SDxdua997Gm7ihJFVjinHz9qTdBzTJrEzC7GEeQHs-8/edit# Bug: 852482 Change-Id: Ie636446aa5726d797625caf264071b4af1572e07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974331Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#726919}
-
Daniel Murphy authored
This web platform test ensures that indexes update correctly for cursors. If an implementation creates tombstones for index updates, then this should test that those tombstones are ignored. R=jsbell@chomium.org, pwnall@chromium.org Bug: 1033996 Change-Id: I07585d9ec065b1ad4f8b720efceaca0987984869 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972579 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#726918}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a16932a784b6..e10a22d68021 Created with: gclient setdep -r src-internal@e10a22d68021 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1034098 Tbr: jbudorick@google.com Change-Id: I120ca23d5947c45f47d5aedba9b13dea0c4a0e36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979119Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#726917}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/b1a4f570b72f..f04938adfc40 git log b1a4f570b72f..f04938adfc40 --date=short --first-parent --format='%ad %ae %s' 2019-12-20 lalitm@google.com Merge "perfetto: allow building metrics protos in Java using Android" Created with: gclient setdep -r src/third_party/perfetto@f04938adfc40 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I290b5a5defff22c3f909615d7bf5dabbfdbcad86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979118Reviewed-by:
-
Matthew Denton authored
This CL modifies nss_ocsp.* to separate out the parts interfacing with NSS and the parts using URLRequest/URLRequestContext. nss_ocsp.h defines an interface, OCSPRequestSessionDelegate, which is implemented in nss_ocsp_session_url_request.*. nss_ocsp.h also defines an interface, OCSPRequestSessionDelegateFactory, to create the OCSPRequestSessionDelegate's. The usual SetURLRequestContextForNSSHttpIO (now defined in nss_ocsp_session_url_request.*) still works--but now it will create a factory instance (OCSPRequestSessionDelegateURLRequestFactory, which stores the provided URLRequestContext) that exposes CreateOCSPRequestSessionDelegate, which will hand out instances of OCSPRequestSessionDelegateURLRequest. This factory is then set as the global OCSPRequestSessionDelegateFactory using the new SetOCSPRequestSessionDelegateFactory function defined by nss_ocsp.h. This should pave the way to being able to implement an OCSPRequestSessionDelegate with URLLoader in the browser process, instead of with URLRequest in the network process. The URLLoader version will implement its own OCSPRequestSessionDelegate and OCSPRequestSessionDelegateFactory classes and a different SetURLLoaderFactoryForNSSHTTPIO can be implemented. Also implements a max size on OCSP response bodies. There should be no actual behavioral change in this CL, except for the size limit on response bodies. Bug: 1015164 Change-Id: I46814d1532c907f72cc10a8fdc6f50c24d22dd3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1952202Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Matthew Denton <mpdenton@chromium.org> Cr-Commit-Position: refs/heads/master@{#726915}
-
Martin Barbella authored
These are leading to startup crashes in fuzzing builds. It can be re-enabled once those are fixed or suppressed. R=inferno@chromium.org Change-Id: Ie5c8320bdabfd389fa514d71981f8d10dd6b174e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978899 Auto-Submit: Martin Barbella <mbarbella@chromium.org> Reviewed-by:
Abhishek Arya <inferno@chromium.org> Commit-Queue: Abhishek Arya <inferno@chromium.org> Cr-Commit-Position: refs/heads/master@{#726914}
-
Aaron Krajeski authored
This change was landed and reverted https://chromium-review.googlesource.com/c/chromium/src/+/1960469 We were flushing mid-draw and this was causing problems. Flush after DidDraw instead. Change-Id: I0d40c5f823014601203c84469749314add107e58 Bug: 1016727, 1015729, 1035865, 1035865 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976501 Commit-Queue: Aaron Krajeski <aaronhk@chromium.org> Reviewed-by:
Aaron Krajeski <aaronhk@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#726913}
-
Brian Sheedy authored
Updates the golden images for the VR browser fullscreen video test. AA changed slightly, causing the play and fullscreen buttons to have a few differing pixels along their edges. TBR=alcooper@chromium.org Change-Id: I01ada1870aa8e94e65c42d9adeeb1202e7d35eed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978897Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#726912}
-
Kristi Park authored
As of https://crrev.com/c/1975110, this will no longer be used. Bug: 1024586 Change-Id: Ibd51ef128bd1b990268b4ce803abde7c8528b7db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976722 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Jeffrey Cohen <jeffreycohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#726911}
-
Manas Verma authored
Moving UnmaskDetails struct to PaymentsClient, in order to be more consistent with other payments requests structs. Also changing `base::Value fido_request_options` to `base::Optional<base::Value> fido_request_options` Bug: 949269 Change-Id: I31742d5ecfcfa611d81b9061cb06a9ceea591551 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972615Reviewed-by:
sebsg <sebsg@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Manas Verma <manasverma@google.com> Cr-Commit-Position: refs/heads/master@{#726910}
-
Wenbin Zhang authored
[benchmarking] disabling blink_perf.canvas/draw-static-canvas-2d-to-hw-accelerated-canvas-2d_RAF.html?RAF for mac-10.12 We're seeing infra failures on mac-10.12 on waterfall. Both build 5800 and 5808 are failed by the same issue on the following story: blink_perf.canvas/draw-static-canvas-2d-to-hw-accelerated-canvas-2d_RAF.html?RAF We need to disable it for now to keep waterfall running. NOTRY=true Bug: chromium:1036446 Change-Id: If8b234f6bb1d82ff15a702c1f481e40e7d7c5504 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979266Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Wenbin Zhang <wenbinzhang@google.com> Cr-Commit-Position: refs/heads/master@{#726909}
-
Saman Sami authored
TearDownDisplayAndUnregisterRootFrameSink() performs a sync call to the GPU process and in the meantime a sync call arrives from the renderer that attempts to modify the FrameSink hierarchy and we get in a bad state. Always check that the root FrameSinkId is registered before attempting to add a child. Bug: 1030618 Change-Id: Ibb58dc65ef71ce9c4af063a0d255729d6a277124 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976558Reviewed-by:
-
kylechar authored
It's not used after VizDisplayCompositor launched. Bug: 936425 Change-Id: I3cc7ad28be32b253bac18b86902248dc842a6da5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976907Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#726907}
-
Juanmi Huertas authored
Serializer: The enums have been renamed, but they have the very same functionality. Previously the kRGBA8 was effectively handled internally in CanvasColorParams as if it was Native, and the kForceRGBA8 was being handled as kRGBA8. This CL fixes the internal behavior of CanvasColorParams without needing a forceRGBA. Bug: 1021986 Change-Id: I32517a0455f41f05113304b95bb8a7d6fd593229 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947546 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
-
David Benjamin authored
Set _LIBCPP_DEBUG=1 in release builds in addition to in debug builds if enable_iterator_debugging is set I added an is_debug gate to be consistent with the old (system STL) enable_iterator_debugging logic, which only enabled iterator debugging when both enable_iterator_debugging is set AND config("debug") is used. I suspect this is a remnant of back when our debug build automatically enabled libstdc++'s iterator debugging. Iterator debugging has long since been made off by default and, if we ever do want to enable it, GN can make defaults for settings depend on other settings. Thus make enable_iterator_debugging do what the name suggests and simply enable iterator debugging. In particular, adding iterator debugging adds a ton of code so asking the compiler to optimize that code makes testing things a bit more tractable. (I default to release + dcheck_always_on builds for local testing these days.) Bug: 923166 Change-Id: Ib9fe5d6ec7af1af644c86089c8f58b3c47058c80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977153Reviewed-by:Nico Weber <thakis@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Auto-Submit: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#726905}
-
John Lee authored
This CL splits up tab_strip_ui.cc into multiple files, to separate UI and Handler code and to also add a header file for the Handler to allow for unit-testing. Change-Id: I992a78b3bd1bec555ecb207eee36841b40754e8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977199Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#726904}
-
Bettina authored
Log the reused password account type of the Safe Browsing requests so that we can if any UNKNOWN account types slipped in. Bug: 1035941 Change-Id: I061a80b45d2f87756092c1fcfc8827ce1009491b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976279Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#726903}
-
Peter K. Lee authored
This feature has been default enabled for at least one release. Removing disabled code path and any tests associated with that. Removed translate_ui_egtest.mm because there's only one test and it tests kLanguageSettings in disabled state only. The test for accessibility for the Languages Settings is already in language_settings_egtest.mm Bug: 1008433 Change-Id: I227bcd257741af574078ea1a37de421c5c847197 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974609 Commit-Queue: Peter Lee <pkl@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#726902}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b47eb188cc52..2fad846c0b1c git log b47eb188cc52..2fad846c0b1c --date=short --first-parent --format='%ad %ae %s' 2019-12-20 reed@google.com simplify asClipRgn to not rely on pathops Created with: gclient setdep -r src/third_party/skia@2fad846c0b1c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC borenet@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: borenet@google.com Change-Id: If9610684c8318575fafe537fd7f3b24a8f76e431 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979117Reviewed-by:
-
Avery Musbach authored
After [1] has modified UpdateSplitViewDragIndicatorsWindowDraggingStates such that it calls ComputeWindowDraggingState only once instead of twice, UpdateSplitViewDragIndicatorsWindowDraggingStates can be simplified and can have only two parameters instead of four. Some of the calling code can then be simplified, especially in DragWindowFromShelfController::Drag. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1977155 Bug: 961171 Change-Id: I367502b9477fc749ea18fd24b23e3603caf9afe2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978688Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#726900}
-
rbpotter authored
Removing showOsSettings, and code that is behind this boolean, from the browser settings about page: - Moving channel switcher dialog, detailed build info, and update warning dialog to the OS settings - Moving tests for these elements to OS settings - Since UI for updating Chrome is no longer reachable in browser settings on Chrome OS, removing Chrome OS specific pieces of this and moving the rest behind "if not chromeos" tags. Bug: 990170 Change-Id: Ied5104f8f7732cf759cc233a29c557273b9c32a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977737Reviewed-by:
-
Caleb Rouleau authored
Bug: 1035957 Change-Id: Ia1e5ac2001c8c165d9a70545ed12456ad577d75a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978874 Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Auto-Submit: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#726898}
-
Aran Gilman authored
Bug: 1027612 Change-Id: I41a4123acfe3cb56b52466e37777945f70f70f05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976299Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Aran Gilman <gilmanmh@google.com> Cr-Commit-Position: refs/heads/master@{#726897}
-
Brandon Goddard authored
This CL adds an aXe test to validate the console after an error message has been logged. This is a follow up to: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1958573 Bug: 1032579 Change-Id: I1d621e4977169b759a1ad6c69e2b4cff7e026f3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979000Reviewed-by:
Lorne Mitchell <lomitch@microsoft.com> Commit-Queue: Brandon Goddard <brgoddar@microsoft.com> Cr-Commit-Position: refs/heads/master@{#726896}
-
Ryan Hansberry authored
The KeepAlive window on the phone-side is 10 minutes; by reducing the period at which we send KeepAlive heartbeat messages to 3 minutes, we give the Chrome OS device 3 chances, instead of 2, to ping the phone before the window expires -- increasing the stability of the Instant Tethering session. Bug: b:143982534 Change-Id: I472139bfa88385c34eb2916cb6d1c2777627a006 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1969774 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#726895}
-
evliu authored
Bug: 1033227 Change-Id: I0f861a5ade999588616d67fa859de20adfc443b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956282 Commit-Queue: Evan Liu <evliu@google.com> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#726894}
-
Victor Vasiliev authored
QuicTransportClient is a top-level API for establishing and using QuicTransport connection. It handles DNS and proxy resolution, and creates all of the necessary infrastructure (socket, certificate verifier, etc) for the underlying QUIC session. Currently, this is only covered by the basic end-to-end test. An in-depth unit test covering this would require QuicTestPacketMaker integration, which would make this CL too large in scope. Bug: 1011392 Change-Id: I19f37aed23440acb6a8eaa655c3af9170eade2a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970141Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Victor Vasiliev <vasilvv@chromium.org> Cr-Commit-Position: refs/heads/master@{#726893}
-
Mario Sanchez Prada authored
Convert remaining references to old mojo types in //components/arc and other paths referencing the ARC-related types (i.e. //ash, //chrome), but without touching the signature of the method implementing the actual mojo interfaces as defined in the .mojom files in //compoments/arc/mojom, which are being handled separately, as part of crbug.com/1035484. TBR=jam@chromium.org Bug: 955171 Change-Id: I452c7cfa2d1fc783eb4e629c4504c040c1f82908 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975875 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#726892}
-
Moe Ahmadi authored
Creates a new helper class to encapsulate the request annotations as well as the observer class logic for fetching bitmaps from BitmapFetcherService Bug: 1030911 Change-Id: Ie12e41da08b6baeaea660c155273b0b0add0bc69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976297 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#726891}
-
Maggie Chen authored
The GPU watchdog will not crash if we're not on the TTY of our host X11 server. But simply doing return without calling OnAcknowledge() will stop the watchdog. Add OnAcknowledge() before return to fix this bug. Bug: 1036444 Change-Id: I6d6ce9ebf57a4d7fa2b6f88162afa3a2cb2689d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977307 Commit-Queue: Maggie Chen <magchen@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#726890}
-
Francois Doray authored
Remove DumpWithoutCrashing in FirstWebContentsProfiler to stop sending reports to the crash server now that the problem is understood. The fix is coming in https://crrev.com/c/chromium/src/+/1976500, landed separately as it may take more time to review. Bug: 1035419 Change-Id: I2c6ce4bd783018bf329e4a3e543052dc419590bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978877 Commit-Queue: François Doray <fdoray@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#726889}
-
Torne (Richard Coles) authored
Several more targets need to either refer to system_webview_apk via the variable or just not defined when !public_android_sdk. This gets it building for now, until we decide how to deal with this properly in future (see crbug.com/1001544) Bug: 1000763 Change-Id: I0995e56eee0390e270a33ef0b6add42dd176d57c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978161 Auto-Submit: Richard Coles <torne@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#726888}
-
Ken Rockot authored
Migrates some directories off of deprecated base::Bind, base::Callback, etc, and onto the newer APIs. Specifically this covers components/dom_distiller/ Fixed: 1007683 Change-Id: Id7dc6470f5fa684593fa01c0b41184f9e250ff16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978875 Commit-Queue: Ken Rockot <rockot@google.com> Commit-Queue: Matthew Jones <mdjones@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Auto-Submit: Ken Rockot <rockot@google.com> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
-
Gustavo Sacomoto authored
This reverts commit 4364277e. Reason for revert: The base::mac::CFCastStrict<CFNumberRef>(ask_for_password) cast returns NULL in some cases, and causes a crash. I'll re-land the original CL (which actually fixes a memory leak), with the proper guards to avoid the crash. Original change's description: > Address missed CL comments for chrome.enterprisePrivate.getDeviceInfo() CL. > > Original CL was at: > https://chromium-review.googlesource.com/c/chromium/src/+/1951561 > > Change-Id: I8784ec61cec5834b17afe04ea8b1d474178af15e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1961211 > Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Commit-Queue: Tim Song <tengs@chromium.org> > Cr-Commit-Position: refs/heads/master@{#723985} TBR=pastarmovj@chromium.org,tengs@chromium.org,rsesek@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I38286e8d12aa82faff4fc798bc81857ac3576f4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978419Reviewed-by:
Gustavo Sacomoto <sacomoto@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Gustavo Sacomoto <sacomoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#726886}
-
Gyuyoung Kim authored
This CL cleans up unnecessary mojo/public/cpp/bindings/binding.h includes in //chrome. Bug: 955171 Change-Id: I40ab783873f4e6f4eb6b09e0f7f946af67c37678 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977886 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#726885}
-
Gyuyoung Kim authored
This CL cleans up unnecessary mojo/public/cpp/bindings/binding.h includes in //device Bug: 955171 Change-Id: I9fd2e4b43446f7333654adccbcc0cd1c0a331a0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977891 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
-
Monica Basta authored
This CL fixes two bugs: (1) When creating a new signed in profile, we copy the account info to the new profile's account tracker except for the account image which means the account tracker will not have the GAIA image till it refreshes after 24 hours. This problem became more visible as the |ProfileInfoCache| started to rely on the data in the |AccountTracker| instead of the |ProfileDownloader| to re-download the account image. This CL saves the account image to the new signed in profile. (2) Identity animation is crashing in a |DCHECK| for new signed in profiles. The reason is |OnRefreshTokens()| is called twice. This happens because in the case of new signed in profiles, the event |OnRefreshTokensLoaded()| leads to the creation of |AvatarToolbarButtonDelegate()| which during its intialization adds its self to the |identityManager| observer list, checks if refresh tokens loaded and calls |AvatarToolbarButtonDelegate::OnRefreshTokensLoaded|, back to the |identityManager| that continues the loop to notify observers, it will call |AvatarToolbarButtonDelegate::OnRefreshTokensLoaded()| again while the identity animation is already showing. Bug: 1035480 Change-Id: I4658332ef0d0303a282a941ceb0e689a858ff2c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978744 Commit-Queue: Monica Basta <msalama@chromium.org> Reviewed-by:
-
Wenyu Fu authored
Integrate the HomepagePolicyManager with HomepageManager, HomepagePreference and HomeButton. This CL includes several behavior changes when HomepageLocation Policy is set to enabled: 1. Homepage will be set to the one assigned by policy 2. Long press on HomeButton will be disabled 3. In Homepage preference, the switch and the edit will be disabled This CL does not include layout changes of Homepage Preference UI. Bug: 978197 Change-Id: I42f022866cf346b9a3e82dd30b9e57e6d3a10af4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929492 Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Auto-Submit: Wenyu Fu <wenyufu@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#726882}
-
