- 19 Feb, 2018 40 commits
-
-
David Roger authored
The Sync confirmation dialog title has four versions: 1. signin disallowed 2. non-dice and non-unity 3. dice and non-unity 4. unity (which requires dice too) Before this CL, the unity version of the dialog was shown in case (3). This CL changes the logic to instead show the non-unity version of the dialog, with just a different title. Bug: 807801 Change-Id: I87b2e023d431a3c20f191a81622984d4d3cc8f59 Reviewed-on: https://chromium-review.googlesource.com/913576Reviewed-by:
Scott Chen <scottchen@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#537630}
-
Patrik Höglund authored
Bug: chromium:811764 Change-Id: I2d41e6941135dc9bd23f840a0ed7d992b85afa95 Reviewed-on: https://chromium-review.googlesource.com/920992Reviewed-by:
Hans Wennborg <hans@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Patrik Höglund <phoglund@chromium.org> Cr-Commit-Position: refs/heads/master@{#537629}
-
Ivan Sandrk authored
This policy is a potential security vulnerability and it's not really used therefore removing. More details on the linked bug. Only removing the policy decoding part, and keeping some of the internals as it's used for a cros setting. Bug: chromium:809463 Change-Id: I487b2ae5c029e59846aeb935bb6c094588e06b03 Reviewed-on: https://chromium-review.googlesource.com/909218Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Ivan Šandrk <isandrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#537628}
-
Trent Apted authored
Bug: 801583 Change-Id: I5818718ae8304925390ddf6e758f510130fc214f Reviewed-on: https://chromium-review.googlesource.com/915781 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
Patti <patricialor@chromium.org> Cr-Commit-Position: refs/heads/master@{#537627}
-
Raphael Kubo da Costa authored
There was a flurry of activity in upstream WPT on February 15th when Mozilla exported several changes to web-animations/. Some tests were renamed and later heavily modified, and our infrastructure cannot recognize those renames. Since some of the changed tests had entries in TestExpectations, I'm manually adding ones with the new names so that things continue to work (some of those tests have been blocking WPT imports for several days). TBR=smcgruer, robertma, lukebjerring No-Try: True Change-Id: I90bef1595da67f6fe5f8ce4f399c98284537e3f7 Reviewed-on: https://chromium-review.googlesource.com/924192Reviewed-by:
Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#537626}
-
Daniel Bratell authored
wincrypt.h and OpenSSL can't be in the same translation unit since both define X509_NAME. There is a crypto/wincrypt_shim.h to use instead of wincrypt.h but in this case the includes were left by mistake when code moved elsewhere and can be removed. This fixes jumbo build in Windows. TBR=pmonette@chromium.org Bug: 746957 Change-Id: I3fa0dadaf8e423302c353bfb7bc7e5484b58ff68 Reviewed-on: https://chromium-review.googlesource.com/924223Reviewed-by:
Daniel Bratell <bratell@opera.com> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#537625}
-
Kent Tamura authored
It must not be possible to create elements with invalid namespace and prefixes, and the DOM specification doesn't ask to check it. This CL must have no behavior changes. Bug: 812089 Change-Id: I598081857d10116a195ecb572c9c65588d6a7734 Reviewed-on: https://chromium-review.googlesource.com/923618Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#537624}
-
Jens Widell authored
This typically means a path based on the directory containing the BUILD.gn file that defined the jumbo target, which generally makes sense. The old solution of finding a suitable directory by looking at the directories containing the target's source files can generate the same name for multiple targets, meaning such targets can't all be jumbo enabled. This is rare, but is the case for the targets //extensions:test_support and //extensions/browser:test_support since the former has source files from //extensions/browser/ that end up being used as the target directory. Change-Id: Ie0c9ee2fcef25c6b0705e0fed3f1dce060459537 Reviewed-on: https://chromium-review.googlesource.com/924023Reviewed-by:
-
Thomas Tangl authored
When there's only one web account to turn on sync, the "Sync to another account" button should directly open the sign-in flow for a new account instead of opening a submenu with only the "Use another account" button. Bug: 812269 Change-Id: I99757042f9a03b78c8145cb13faea893b64db32a Reviewed-on: https://chromium-review.googlesource.com/924185 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#537622}
-
Thomas Tangl authored
The DiceSigninButton should show an arrow pointing downwards instead of to the right. This CL fixes this. Screenshot from before: https://drive.google.com/file/d/13T9Wv99rezwCDQ9EnW3drrSmrGIoAtor/view?usp=sharing Screenshot from after: https://drive.google.com/file/d/1d9_N_IOvjLhohMrm4eEWE8-4ElaC7qBv/view?usp=sharing Bug: 812283 Change-Id: Ic0c2229c24532f45fbdb236fe222505cd36cd572 Reviewed-on: https://chromium-review.googlesource.com/924070Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#537621}
-
Satoshi Niwa authored
ConvertToContentUrl is a new async function being added by crrev.com/c/906222 It can handle ARC media URLs that the existing function can't handle. Bug: chromium:767982 Bug: chromium:811679 Test: out/Default/exo_unittests --gtest_filter="DataOffer.*" Change-Id: Ibfacfe3ce86687b45b2f60ed18d6dfefbbe6f685 Reviewed-on: https://chromium-review.googlesource.com/910540Reviewed-by:
Shuhei Takahashi <nya@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Commit-Queue: Satoshi Niwa <niwa@chromium.org> Cr-Commit-Position: refs/heads/master@{#537620}
-
Koji Ishii authored
This patch captures 3 SkFontMgr in minidump so that we can figure out how SkFontMgr was initialized better from minidump. Bug: 561873 Change-Id: Icafac73fc0ccc8df4ffffcd01697e2227055eb02 Reviewed-on: https://chromium-review.googlesource.com/923925 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#537619}
-
Ramin Halavati authored
Following patchsets crrev.com/c/924061 and crrev.com/c/924062, SHA1 for traffic annotation auditor executable for Windows is updated. Bug: 690323 Change-Id: Ic6112c60ea6d98c16bffcd596b669d69df8d1d3b Reviewed-on: https://chromium-review.googlesource.com/924004Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#537618}
-
Thomas Tangl authored
When the drop down arrow on the DiceSigninButton is clicked, a submenu listing all GAIA web accounts except the first one should be displayed. This CL adds this feature. Screenshot: https://drive.google.com/file/d/1va4fXSFtf7PastkuXgVUc5B5mrFIEZzJ/view?usp=sharing Bug: 812282 Change-Id: I52a73392dc6543fc44d2553c76f046685fb17672 Reviewed-on: https://chromium-review.googlesource.com/922204 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
-
Dominik Röttsches authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/4a03f17449ae..713d68ee9f47 $ git log 4a03f1744..713d68ee9 --date=short --no-merges --format='%ad %ae %s' 2018-02-17 wl [sfnt] Prefer `CBDT'/`CBLC' over `glyf' table (#53154). 2018-02-17 wl Split off ChangeLog.28. 2018-02-17 wl s/sub-pixel/subpixel/. Created with: roll-dep src/third_party/freetype/src Bug: pdfium:1016 Change-Id: I7fd6f0278075546e9be8a58ff5aa7cc51705f93c Tbr: bungeman@chromium.org, eae@chromium.org Reviewed-on: https://chromium-review.googlesource.com/924152Reviewed-by:
-
Takashi Toyoshima authored
CORS::GetErrorString takes multiple arguments, and required parameters depend on error kinds. This will make developers who want to call it be confused, when we add more parameters, we need to modify all call sites. This patch introduces CORS::ErrorParameter to unify parameters for GetErrorString. This solves problems mentioned above, and also allows us to have better coding error checks. Once the OOR migration is done, we will be able to remove error specific ErrorParameter builders, or can even remove ErrorParameter again because we can remove the most intermediate call sites from Blink. Bug: 803766 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I2647ddfea4c48aa48a744b8b636d032aec3531e1 Reviewed-on: https://chromium-review.googlesource.com/918323 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Takeshi Yoshino <tyoshino@chromium.org> Cr-Commit-Position: refs/heads/master@{#537615}
-
Hayato Ito authored
Address the review comment of https://chromium-review.googlesource.com/c/chromium/src/+/920329/7#message-b9399a526b29ba08927301f8baec6c8d30c20682 TBR=futhark@chromium.org Bug: 776656 Change-Id: I3e6084b7dde05df54fddf38bfeb3220c9c585bb2 Reviewed-on: https://chromium-review.googlesource.com/923667 Commit-Queue: Hayato Ito <hayato@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#537614}
-
Hajime Hoshi authored
This is part of efforts to replace default timer task runners with other appropriate task runners in the renderer. Bug: 624694, 804694 Change-Id: I72ba24174da8d1557d4963b0f4336b50b2f01667 Reviewed-on: https://chromium-review.googlesource.com/925124Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#537613}
-
Mattias Nissler authored
Show the reset screen immediately if powerwash has previously been requested before reboot. This addresses a case where the screen wouldn't show because the pending TPM availability test incorrectly turns the eligibility check negative immediately after reboot. BUG=chromium:780817 TEST=Reboot-to-powerwash-with-TPM-firmware-update flow works for enrolled devices Change-Id: Ia9c56a2422c70d19dc2cccea6b5fb21c62fa510a Reviewed-on: https://chromium-review.googlesource.com/921842Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Mattias Nissler <mnissler@chromium.org> Cr-Commit-Position: refs/heads/master@{#537612}
-
Makoto Shimazu authored
Bug: 807127 Change-Id: I29dc398b9b2809abc0d2eba7345d00aa03acfc9a Reviewed-on: https://chromium-review.googlesource.com/920566 Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
-
Ramin Halavati authored
'remoting/client' and 'remoting/host' are added to the set of targets that network traffic annotation tests are activated for them. Bug: 690323 Change-Id: I415cf930df8d788437ac48ba5bfb2bcef925a4ab Reviewed-on: https://chromium-review.googlesource.com/888618 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
-
Rakina Zata Amni authored
Internal elementFromPoint call might allow HitTest to get child frame content, in which case retarget is not needed. In this case, we don't call retarget for the hit test result. Bug: 812138 Change-Id: I17047f5e4b407cbe2ce58ffd0e191f73413ac3bc Reviewed-on: https://chromium-review.googlesource.com/923247 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
-
Gauthier Ambard authored
This CL adds the fullscreen capability for the bottom toolbar. The other bottom toolbar are still not connected to the bottom toolbar. Bug: 804728 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I966b5dca9b92e1e31b9746d2eb3ee146e809a419 Reviewed-on: https://chromium-review.googlesource.com/919166 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#537608}
-
Takeshi Yoshino authored
Bug: 813481 Change-Id: I63ca84f2e191082b2685aafdaaa5fed5072221e6 TBR: halliwell@chromium.org Reviewed-on: https://chromium-review.googlesource.com/923745 Commit-Queue: Takeshi Yoshino <tyoshino@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
-
Makoto Shimazu authored
This patch is to split sandboxed-iframe-fetch-event.https.html into small chunks. Each promise_test has smaller number of assertions, so that now we can see the results for each situation. Bug: 771815 Change-Id: I75cdd67f92bbb07d6b538b209e1f0819752c3bc8 Reviewed-on: https://chromium-review.googlesource.com/923901 Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
-
Kinuko Yasuda authored
(Partly as a preparation to add more logic for htxg-specific prefetch plumbing) Introduce prefetch-specific URLLoader which does: - Basically just forwards the request to the underlying network loader - Doesn't forward back the data to the renderer process, which used to be just discarded in the renderer process anyways. This is hooked as follows: - When NetworkService is enabled LinkLoader gets PrefetchURLLoaderFactory via PrefetchURLLoaderService and sets it as ResourceLoaderOptions. url_loader_factory. - When NetworkService is NOT enabled this is directly hooked from the ResourceMessageFilter. In both cases the URLLoaderFactory is owned by StoragePartition, partially because it makes various plumbing (including tests) easier. Optionally we can make it live longer than the client process, though it is not currently implemented. (So no behavior change is expected with this one) Bug: 803776 Change-Id: Ia4b33048a7c6d27a80044d99b62a1cc5faad5681 Reviewed-on: https://chromium-review.googlesource.com/912051 Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#537605}
-
Christopher Cameron authored
This should not have been removed in https://crrev.com/536430 Move tracking from RenderWidgetHostImpl (where it is tracked only in non-viz mode) to BrowserCompositorView, where it is tracked in both modes. Bug: 772576, 812505, 812156 Change-Id: I006c1c78f2dc148602f08253745993f8a57a7e16 Reviewed-on: https://chromium-review.googlesource.com/923379 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#537604}
-
Michael Lippautz authored
Trace calls should just dispatch and register at the visitors. This is in preparation to override visitation behavior. Bug: chromium:802273 Change-Id: I0d7d6f95a7adcf121123316af7cb5b837c9e262f Reviewed-on: https://chromium-review.googlesource.com/923731Reviewed-by:
-
Naoki Fukino authored
It is flaky. Disabling it for now. not run anything. Bug: 813483 Test: unit_tests --grest_filter=FileManagerFileWatcherTest.WatchLocalFile did Change-Id: I826f3f4ca942c939916207bca97569661d92351d Reviewed-on: https://chromium-review.googlesource.com/923616Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/heads/master@{#537602}
-
Gauthier Ambard authored
This CL removes the deprecated rotations methods. Those methods are not called on iOS 8+ devices. Bug: none Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I9093e24645c7adbe16ec220fac5cb4d0a32669a8 Reviewed-on: https://chromium-review.googlesource.com/924021Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#537601}
-
Fady Samuel authored
This CL reports whether an OOPIF is causing invariants violations. Bug: 791154, 672962 Change-Id: Ida943b8a6bb21cd5baed00bd0065f77e5a358033 Reviewed-on: https://chromium-review.googlesource.com/923041 Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#537600}
-
Takeshi Yoshino authored
Bug: 813320 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ia7434352408d5327a72d4c9a80da31542ddeba05 Reviewed-on: https://chromium-review.googlesource.com/923770Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Takeshi Yoshino <tyoshino@chromium.org> Cr-Commit-Position: refs/heads/master@{#537599}
-
Kinuko Yasuda authored
- Decide when to call ProceedWithResponse depending on the loader option (rather than checking kNetworkService flag), so that the same loader code can run for subresource loading too - Decide when to return SSLInfo back also depending on the loader option Bug: 803774, 803776 Change-Id: I1e5d4bddcfc054339ca4cd4b83068af6c1d0ec24 Reviewed-on: https://chromium-review.googlesource.com/923664 Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
-
Takeshi Yoshino authored
Mark a layout test external/wpt/offscreen-canvas/the-offscreen-canvas/offscreencanvas.convert.to.blob.html as flaky Bug: 813462 Change-Id: I1218269ed75ff50b991505f6f67f770c29e2d593 Reviewed-on: https://chromium-review.googlesource.com/923743 Commit-Queue: Takeshi Yoshino <tyoshino@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#537597}
-
Hayato Ito authored
Add me as an owner of these directories. Change-Id: I0baadafda1c4989956dd477b6e6ddab0195916ea Reviewed-on: https://chromium-review.googlesource.com/923746Reviewed-by:
Takayoshi Kochi <kochi@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#537596}
-
Yoshifumi Inoue authored
This patch introduces test cases for |PreviousWordPosition()| to record current behavior as a preparation of the patch[1]. Note: The patch[2] introduces test case for |NextWordPosition()|. [1] http://crrev.com/c/737981 Introduce TextOffsetMapping to simplify word/paragraph selection [2] http://crrev.com/c/895236 Introduce test cases for NextWordPosition() Bug: 778507 Change-Id: Ie1b3933336ddd9d6afca246700a9f7e9a588d61d Reviewed-on: https://chromium-review.googlesource.com/923686 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#537595}
-
Kim Paulhamus authored
and handle empty or missing rpIds. Add layout tests for various combinations of origins and rpId to get(publicKey) just like the existing ones for create(publicKey). Bug: 807774, 664630 Change-Id: I86d3d36c3f3825743f003da69245c74bdca10d5b Reviewed-on: https://chromium-review.googlesource.com/896384 Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#537594}
-
Takeshi Yoshino authored
This reverts commit d9b74d0c. Reason for revert: See the FindIt message. It looks this CL has broken the "Linux Chromium OS ASan LSan Tests" bot Original change's description: > Add user to active sessions reporting. > > Previously, active sessions and recent users were reported separately, > that is confusing on the server side. > This change adds 'user_email' field to ActiveTimePeriod proto message > and populates it for affiliated users that are eligible for reporting. > Also, user email is reported only if user reporting is turned on. > > BUG=810093 > TEST=Browser tests added. > > Change-Id: I92fec6725349972895ec0a439f78efa59853670e > Reviewed-on: https://chromium-review.googlesource.com/904527 > Reviewed-by: Maksim Ivanov <emaxx@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Commit-Queue: Sergey Poromov <poromov@chromium.org> > Cr-Commit-Position: refs/heads/master@{#537435} TBR=xiyuan@chromium.org,emaxx@chromium.org,poromov@chromium.org,pmarko@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 810093 Change-Id: I96152915d5da8d763c32132bade51b2bc5a4bcd7 Reviewed-on: https://chromium-review.googlesource.com/923228Reviewed-by:
-
Takayoshi Kochi authored
We no longer have multiple shadow roots, <shadow> behaves almost identical to <content> without select attribute. We only have to care for the case when <content> and <shadow> are used in the same shadow root. This CL simplifies code that used to handle multiple shadow cases for <shadow> elements in V0 distribution logic. No visible behavioral change is expected. Bug: 624724 Change-Id: I88f237f2d26519cd400ef13605f4b3115843b4b7 Reviewed-on: https://chromium-review.googlesource.com/923446Reviewed-by:
-
Adam Rice authored
StaticSocketDataProvider and SequencedSocketData do not modify the MockRead and MockWrite arrays that they are passed. Mark them const. Change-Id: I0eea9dce572e2fd1c9c8cf8e2f08cdfb14b4fc1c Reviewed-on: https://chromium-review.googlesource.com/917886Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#537591}
-
