- 11 Jul, 2019 40 commits
-
-
Miyoung Shin authored
This CL adds an audit check for the banned std containers to ensure the new usage of std::unordered_set and std::unordered_map doesn't come in, and updates the warning message to clarify to allow the use case at the boundary layer between Blink and Chromium. Bug: 952716 Change-Id: Idca01e5d96a515a9dcff7e8f347248944a540a81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1691909 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#676367}
-
Clemens Arbesser authored
This CL adds a new enum histograms for tha autofill assistant payment request. The histogram measures whether the payment request was successful as a function of whether the PR was initially complete autofilled or not. This is a first step towards investigating why many users stop the flow in the payment request. The current hypothesis is that an initially incomplete payment request will result in more users cancelling the flow, compared to initially complete payment requests. Bug: b/133124492 Change-Id: Ibdbd11174a2372011a580244e652505dcc78bc4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680179 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#676366}
-
Vaclav Brozek authored
As described in the design doc [1], a new class, CSVPassword, is introduced as a wrapper around a single line of a CSV text representing a credential. [1] https://docs.google.com/document/d/1wsZBl93S_WGaXZqrqq5SP08LVZ0zDKf6e9nlptyl9AY/edit?usp=sharing Bug: 934326 Change-Id: I681f95d8b6abbf707cc346e2f83a7fd201924310 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1690588Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#676365}
-
Edvard Thörnros authored
The WTF::Vector datatype has not had a way to insert with an iterator, which is the preferred way to iterate through all elements. This new method takes an iterator and saves you the trouble of thinking and making silly iterator-math errors. Bug: 981522 Change-Id: I4850606e4072668406e55b97ee65208aaf35d33d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1690961 Auto-Submit: Edvard Thörnros <edvardt@opera.com> Commit-Queue: Edvard Thörnros <edvardt@opera.com> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/b79dda949e88..379aec0e1afe git log b79dda949e88..379aec0e1afe --date=short --no-merges --format='%ad %ae %s' 2019-07-11 perezju@chromium.org [Telemetry] Remove all results.pages_that_* properties Created with: gclient setdep -r src/third_party/catapult@379aec0e1afe The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:973837 TBR=zhanliang@google.com Change-Id: I55716cc8183d6b4dc007ab4c0b4f1d5f8a8f1fef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697923Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#676363}
-
Tanmoy Mollik authored
Bug: 872809 Change-Id: I02335d7101535724035c100681080a4992c81d3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1689793 Commit-Queue: Tanmoy Mollik <triploblastic@google.com> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#676362}
-
Yuki Shiino authored
Bug: 839389 Change-Id: Ib131f7dcc043af790bd91ec586f52c4849591165 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695748Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#676361}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/16850598db2b..ca160215c9d1 git log 16850598db2b..ca160215c9d1 --date=short --no-merges --format='%ad %ae %s' 2019-07-10 ilnik@webrtc.org Update rtc_tools/rtp_generator to compile Created with: gclient setdep -r src/third_party/webrtc@ca160215c9d1 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I8cb5a1d451c5238822efbf304002f37fe22041ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697922Reviewed-by:
-
Eldar Rello authored
Spec: https://w3c.github.io/webrtc-pc/#dom-rtcpeerconnection-onicecandidateerror Intent: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/fs-Y4awdYj0 Bug: webrtc:3098 Change-Id: I9c4a3ec75050e85f2a13b896f580bc16206ca2c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1607800 Commit-Queue: Eldar Rello <elrello@microsoft.com> Reviewed-by:
Qingsi Wang <qingsi@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#676359}
-
Rayan Kanso authored
Update the OfflineContentProviderAggregator with content entries and visuals. TBR=avi@chromium.org Bug: 973844 Change-Id: I059fcf53a2e4a5a9b388dbbfed929f6270bc85de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1688788 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#676358}
-
Julie Jeongeun Kim authored
This CL is a part of moving access token management to OAuth2AccessTokenManager. It is specifically a step toward folding DeviceO2TSDelegate into DeviceO2TS now that the latter is no longer an O2TS subclass. It moves the refresh token encryption and decryption from DeviceO2TSDelegate to DeviceO2TS. The sequence is that if the system salt is available, it gets the encrypted refresh token from pref and decrypted it using the system salt. Previously DeviceO2TSDelegate had it. It's moved to DeviceO2TS with this CL. Bug: 967598 Change-Id: I668704ce0ac655c64ddfe493c4ee5f0cc6fa1559 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695281 Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#676357}
-
Gyuyoung Kim authored
Some files have been including account_reconcilor.h even though they don't use any AccountReconcilor stuff. This CL removes the unnecessary includes in the files. Bug: 970268 Change-Id: I9e4d62396273c4a52f38d577d5c2405e99ac1add Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697201 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/198be0a8bff1..67a281286c52 git log 198be0a8bff1..67a281286c52 --date=short --no-merges --format='%ad %ae %s' 2019-07-11 khokhlov@google.com Merge "Remove strings table" Created with: gclient setdep -r src/third_party/perfetto@67a281286c52 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Ib6ca836144e0e71d3673f0c4172386ba5f0ab3d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697921Reviewed-by:
-
Matt Falkenhagen authored
This adds ServiceWorkerNavigationLoaderInterceptor which lives on the UI thread. Currently it just delegates to the existing interceptor on the IO thread. The goal is to migrate things to the UI thread. There are no new tests added as this is still initial work, but it enables several of the existing browser tests. Change-Id: I69d9b09c308b0e2c711a304390c04574c734a2d9 Bug: 824858 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1688592 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#676354}
-
Omer Katz authored
Bug: 981043 Change-Id: Ie5f2181a6503224579b45f03686c6cb6482d19e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697625Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#676353}
-
Omer Katz authored
Existing code executed parent pre-finalizer before subclass pre-finalizer. Corrected the order. Bug: 981043 Change-Id: I4b25cf8c6ee1d8145f77e5ed46e87eeae22357f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696964Reviewed-by:
-
Rayan Kanso authored
Create a ContentIndexProvider implementation which is a keyed service. Clarify threading expectations, and make sure all tasks are posted to the right thread. Bug: 973844 Change-Id: I85d0a4e339a71b7ec53c9fac0190e5478166dd7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1687257 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
-
Xianzhu Wang authored
Now support --extra-browser-categories even if the test doesn't specify testRunner.tracingCategories. Bug: 981920 Change-Id: I8d5f990b020e4879d334e435cc6adcffb2893a6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693029 Auto-Submit: Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#676350}
-
Juan Antonio Navarro Perez authored
These were added long time ago as uploading statistics for all memory metrics in chart json format overwhelmed the dashboard. But these should be a no-op now, as we upload histograms instead. The code shows that as long as any of the stats is uploaded, then the entire histogram is added [1]. [1]: https://cs.chromium.org/chromium/src/third_party/catapult/telemetry/telemetry/internal/results/page_test_results.py?rcl=d2a5fee6e9409c644ea111f2a7d89e03c0ee1c05&l=438 TBR=etienneb@chromium.org Bug: 921000 Change-Id: I8c3c2e1e972966cce3a0f660f87710db1b7d64f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1688935 Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by:
Ben Hayden <benjhayden@chromium.org> Reviewed-by:
Mythri Alle <mythria@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#676349}
-
Yuzu Saijo authored
This CL makes PageMsg IPCs unfreezable (non-stoppable) all the time, regardless of its associated frame's frozen status. Currently, PageMsg IPCs sometimes share the same routing_id with its frame and they get posted to freezable per-frame task runners, which is a bug. This should fix some browser tests that were disabled. So this CL also enables the tests that were disabled because of the bug. Bug: 981886, 978021, 978028 Change-Id: I9761b020b1d569189ff3ddc1524a6bf9fcb43953 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1690052Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
Matt Falkenhagen authored
It wasn't actually waiting for |num_jobs| when NavigationLoaderOnUI is enabled. When that feature is enabled, the function is called directly from the UI thread, and if |ongoing_mock_requests_| doesn't have size |num_jobs| it would return without waiting. This was discovered by https://chromium-review.googlesource.com/c/chromium/src/+/1688592 which will introduce a thread hop in order to perform service worker interception before doing an outgoing network request, so WaitForJobs() will be called before a request is added to ongoing_mock_requests_. Bug: 824858, 978556 Change-Id: I7264f1a4f04e517694417affcd5a8d20d0f4b9b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1689979 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
-
Colin Blundell authored
Per offline discussion Change-Id: Ib48bf55a6fac69c2ede0c1261bc1283feaa4e04a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697184Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
Friedrich Horschig authored
With this CL, we will now show the origins as user info titles iff the the credential origin differs from the current site origin. Mock about how this will look like are in the linked bug. The changes only affect the not yet launched accessory V2. Bug: 981928 Change-Id: Id3c26c8d224222f2160965ca43f95cfafcd64767 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695294 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#676345}
-
Leon Han authored
This CL removes all includes of content/common/service_worker/service_worker_types.h from content/renderer/service_worker/, to facilitate merging service_worker_types.h into content/browser/service_worker/ later. BUG=789854 Change-Id: I918070fe6bc21972d32d330a93bdbab117ff37e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695062 Commit-Queue: Leon Han <leon.han@intel.com> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#676344}
-
Staphany Park authored
We expect https://crrev.com/c/1635430 to have fixed the flakiness and manually confirmed that the test now passes across 100 repeated runs. Bug: 827231 Change-Id: I4599671cf6db1192847585ba2789995b377d23aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696449 Commit-Queue: Staphany Park <staphany@chromium.org> Auto-Submit: Staphany Park <staphany@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#676343}
-
Julie Jeongeun Kim authored
This CL is a part of moving access token management to OAuth2AccessTokenManager. It is specifically a step toward folding DeviceO2TSDelegate into DeviceO2TS now that the latter is no longer an O2TS subclass. It moves GetRobotAccountId(), CheckRobotAccountId(), OnServiceAccountIdentityChanged(), and |service_account_identity_subscription_| which are related to the robot account ID. Bug: 967598 Change-Id: I63ffc5c9ee6f56bdadfdaf47b5b2eb870c77187f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1694901 Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Reviewed-by:
-
Matthias Körber authored
Bug: 881346 Change-Id: I68c6b18bcb21cca20ec194d2d9dcfee17d5cceec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662411 Commit-Queue: Matthias Körber <koerber@google.com> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#676341}
-
Tsuyoshi Horo authored
So that we can start the OriginTrial experiment in specific milestone's Chrome. Bug: 935267, 980828 Change-Id: Ibb7bf6f071023504adb1d3ddf74921b195a427a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697063Reviewed-by:
-
Michael Lippautz authored
- Remove eager sweeping as the support will be dropped - Extend pre-finalizer examples - Clarify that pre-finalizers are not allowed to resurrect Bug: 982754 Change-Id: Ia3a0a4bfa4c872d1eeacd568920ba5b820703828 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697603Reviewed-by:
-
Robbie Gibson authored
Bug: 932116 Change-Id: I5c53bb39d4edab10c7aba2ece6462ddf2ce12f18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695363Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#676338}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ffcc6abe..062d4a74 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ib7e683b3cc4f7aa60812fc66c7567c06718086bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695322Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#676337}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b1d9da985777..80fe6f05f6bd Created with: gclient setdep -r src-internal@80fe6f05f6bd The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=hcarmona@google.com,hajimehoshi@google.com,jbroman@google.com Change-Id: I95fd0e8ca790bce3eb46dd7ab041ea154a52934d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697177Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#676336}
-
Nazerke authored
Bug: 973040, 979183 Change-Id: I2ec413e4220129bcd8bc29975c51fd29c17190c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678177 Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
-
Yutaka Hirano authored
Fix mojo connection error handling on extensions to fix flaky tests. Document that in network_context.mojom. Bug: 981467, 967524 Change-Id: I51cd834ca71cb712b1538196ba5e2d730a0c2eed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1689554 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Adam Rice <ricea@chromium.org> Reviewed-by:
-
Darren Shen authored
There's a bug with SetCompositionRange: 1. XKB calls SetCompositionRange. 2. InputMethodEngine asks text client to underline the text. 3. InputMethodEngine does not update local composition, so it's empty. 4. XKB switches input methods. 5. When disabling the InputMethodEngine, we commit the composition text. But it thinks composition text is empty! 6. InputMethodEngine commits nothing and XKB will switch to new input method, with existing text left in composition. To avoid this stale cache issue, we'll use ConfirmCompositionText instead of committing the cached composition. We will remove the cached composition in a future patch. TEST=InputMethodChromeOSTest.ConfirmCompositionText* InputMethodEngineTest.TestDisableAfterSetCompositionRange Bug: 980437 Change-Id: Ia7cdf2d6be7d892595211dfaca67a1eefc71686c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1687720Reviewed-by:Shu Chen <shuchen@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#676333}
-
Adam Ettenberger authored
It's unsafe to look at any node other than the node being updated while handling AXTree::UpdateNode. Removing logic in |AXEventGenerator::OnNodeDataWillChange| which called |GetUnignoredParent| and moved it to where the event is handled with a stable tree in |BrowserAccessibilityManagerWin::FireGeneratedEvent|. Bug: 651614, 974444 Change-Id: I1e0254ea25003c827f625bbb9a256f66a3817a19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693776 Commit-Queue: Adam Ettenberger <adettenb@microsoft.com> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Cr-Commit-Position: refs/heads/master@{#676332}
-
chrome://autofill-internalsDominic Battre authored
This CL introduces logging mechanisms for chrome://autofill-internals that are more high fidelity than what we have today. They allow to log structured data, use colors to indicate the context, etc. As a first usecase, the CL starts logging parsed forms. Bug: 928595 Change-Id: Ib304de4dafe0686ed9f8d6720f43b2416c49c8dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1689204 Commit-Queue: Dominic Battré <battre@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
-
Gabriel Charette authored
This reverts commit 7c7e0f8d. Reason for revert: crbug.com/982998 (flaky on win7_rel) Original change's description: > UIA: Upon visibility change, fire UIA_AriaPropertiesPropertyId event > > - Implemented firing property changed event for > UIA_AriaPropertiesPropertyId - hidden upon visibility change > introduced by aria-hidden and visibility:hidden, accompanied by > associated browser dump tests. > > - Documentation on UI Automation AriaProperties > (see the second table's last column for AriaProperties > properties): > https://docs.microsoft.com/en-us/windows/desktop/WinAuto/uiauto-ariaspecification > > Bug: 928949 > Change-Id: I7808ba8fe352d515a054027217afc34892b38732 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659970 > Commit-Queue: Victor Fei <vicfei@microsoft.com> > Reviewed-by: Katie Dektar <katie@chromium.org> > Reviewed-by: Ian Prest <iapres@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#675876} TBR=katie@chromium.org,iapres@microsoft.com,vicfei@microsoft.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 928949, 982998 Change-Id: I401c2a439a35b22232655e3bba91977f3c450538 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696846Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#676330}
-
Colin Blundell authored
This CL moves the files that are currently in the //components/signin/core/browser:shared GN target into the structure described in this document: https://docs.google.com/document/d/1p_kahITGFgv7PehQ61-thRVR3Hrdaf3tLryMytTRPYs/edit# Namely, files intended for usage by the entire signin component and its consumers are moved into a new //signin/public/base/ directory. Files that are conceptually part of the IdentityManager public interface are moved into //signin/public/identity_manager/. This change was done in two parts: 1. A script that did the code moves and corresponding renames, include path changes, etc. 2. Manual followup that changed GN files and DEPS to reflect the new structure. For ease of reviewing, I uploaded 1 as the original PS and 2 as PS2. TBR=jochen@chromium.org Bug: 952788 Change-Id: I88afc79b426f3acc954d78006ed88d4cd0579672 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1687239Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
-
Aga Wronska authored
Bug: 975504 Change-Id: Id28552a8f51501accccbf0b640245ac981f9a13b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1691910Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#676328}
-
