Commits · e4e0b5092947e61450a49b77cdd0a8ec7d0663b6 · eriksson monteiro / tangled

01 Nov, 2019 40 commits

Reland "Fix about:webrtc-internals "Stats Tables"" · e4e0b509

Armando Miraglia authored Nov 01, 2019

This reverts commit 2302c7e1.

Reason for revert: relanding because without win-build-perf is broken (possibly needs manual work).

Original change's description:
> Revert "Fix about:webrtc-internals "Stats Tables""
> 
> This reverts commit f61878bc.
> 
> Reason for revert: [sheriff] it looks very likely that this change caused a crash in WebRTCInternalsIntegrationBrowserTest.IntegrationWithWebRtcEventLogger (https://ci.chromium.org/p/chromium/builders/ci/Mac10.10%20Tests/48280).
> 
> Original change's description:
> > Fix about:webrtc-internals "Stats Tables"
> > 
> > This is a fixup CL of [1] spotted and report by hbos@chromium.org
> > on [2].
> > 
> > [1] https://crrev.com/c/1842414 (Onion soup RTCPeerConnectionHandler and its direct dependences)
> > [2] https://crrev.com/c/1842414/14#message-daf2b117b98895c3692a635ac873e249e6f905c1
> > 
> > Basically the original CL was supposed to replace the code
> > that used to bound PeerConnectionTracker to its associated
> > mojom::Receiver instance in [3] by the corresponding code in
> > Blink.
> > However, the replacement code got accidentally missing while rebasing
> > the CL over and over.
> > 
> > [3] https://crrev.com/c/1842414/14/content/renderer/render_thread_impl.cc#b777
> > 
> > This CL amends the original CL with the proper code in
> > blink/renderer/modules/modules_initializer.cc@RegisterInterfaces().
> > 
> > TEST=<out>/browser_tests --gtest_filter=WebRtcInternalsPerfBrowserTest.MANUAL_RunsAudioVideoCall60SecsAndLogsInternalMetricsVp8 \
> > --run-manual --ui-test-action-max-timeout=100000 --test-launcher-timeout=100001
> > 
> > Manual test= Open Chromium load about:webrtc-internals and [4].
> > It is expected that WebRTC statistics appear.
> > 
> > [4] https://codepen.io/anon/pen/JQLEqR?editors=1010
> > 
> > R=haraken@chromium.org
> > TBR=guidou@chromium.org, hbos@chromium.org
> > 
> > BUG=787254
> > 
> > Change-Id: I88f26b8cbcc09b707f6db5c9e7ba40bdbd8e82e8
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893293
> > Reviewed-by: Kentaro Hara <haraken@chromium.org>
> > Reviewed-by: Henrik Boström <hbos@chromium.org>
> > Reviewed-by: Antonio Gomes <tonikitoo@igalia.com>
> > Commit-Queue: Henrik Boström <hbos@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#711647}
> 
> TBR=haraken@chromium.org,hbos@chromium.org,guidou@chromium.org,tonikitoo@igalia.com
> 
> Change-Id: If20ddd5622f30af1bfe1a8ca7d3b041b605bc7b2
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 787254
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895195
> Reviewed-by: Armando Miraglia <armax@chromium.org>
> Commit-Queue: Armando Miraglia <armax@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#711665}

TBR=haraken@chromium.org,hbos@chromium.org,guidou@chromium.org,tonikitoo@igalia.com,armax@chromium.org

Change-Id: I4bac5da3cae4161f788ac0d1ef602bccb1419da7
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 787254
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893868Reviewed-by: Armando Miraglia <armax@chromium.org>
Commit-Queue: Armando Miraglia <armax@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711668}

e4e0b509

Roll src/third_party/skia 7f680a638e96..8f062cdaa7fd (1 commits) · 3ae579f3

chromium-autoroll authored Nov 01, 2019

https://skia.googlesource.com/skia.git/+log/7f680a638e96..8f062cdaa7fd

git log 7f680a638e96..8f062cdaa7fd --date=short --no-merges --format='%ad %ae %s'
2019-11-01 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).

Created with:
gclient setdep -r src/third_party/skia@8f062cdaa7fd

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC jcgregorio@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=jcgregorio@google.com

Bug: None
Change-Id: Idfd09658cf1e078e76fb2ba522701ebb0688a988
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895213Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#711667}

3ae579f3

[Autofill Assistant] Add optional image and text to full overlay. · cdc959a4

Clemens Arbesser authored Nov 01, 2019

This CL adds support for an additional image with an optional subtitle. The image is rendered on top of full overlays only, and is anchored to the top such that viewport resizes do not affect its position.

See the linked bug for example screenshots.

Bug: b/143452916
Change-Id: Ic974b2e0f622edd2a917d1f2fe54b4a4ccd33949
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886851Reviewed-by: Brandon Wylie <wylieb@chromium.org>
Reviewed-by: Mathias Carlen <mcarlen@chromium.org>
Commit-Queue: Clemens Arbesser <arbesser@google.com>
Cr-Commit-Position: refs/heads/master@{#711666}

cdc959a4

Revert "Fix about:webrtc-internals "Stats Tables"" · 2302c7e1

Armando Miraglia authored Nov 01, 2019

This reverts commit f61878bc.

Reason for revert: [sheriff] it looks very likely that this change caused a crash in WebRTCInternalsIntegrationBrowserTest.IntegrationWithWebRtcEventLogger (https://ci.chromium.org/p/chromium/builders/ci/Mac10.10%20Tests/48280).

Original change's description:
> Fix about:webrtc-internals "Stats Tables"
> 
> This is a fixup CL of [1] spotted and report by hbos@chromium.org
> on [2].
> 
> [1] https://crrev.com/c/1842414 (Onion soup RTCPeerConnectionHandler and its direct dependences)
> [2] https://crrev.com/c/1842414/14#message-daf2b117b98895c3692a635ac873e249e6f905c1
> 
> Basically the original CL was supposed to replace the code
> that used to bound PeerConnectionTracker to its associated
> mojom::Receiver instance in [3] by the corresponding code in
> Blink.
> However, the replacement code got accidentally missing while rebasing
> the CL over and over.
> 
> [3] https://crrev.com/c/1842414/14/content/renderer/render_thread_impl.cc#b777
> 
> This CL amends the original CL with the proper code in
> blink/renderer/modules/modules_initializer.cc@RegisterInterfaces().
> 
> TEST=<out>/browser_tests --gtest_filter=WebRtcInternalsPerfBrowserTest.MANUAL_RunsAudioVideoCall60SecsAndLogsInternalMetricsVp8 \
> --run-manual --ui-test-action-max-timeout=100000 --test-launcher-timeout=100001
> 
> Manual test= Open Chromium load about:webrtc-internals and [4].
> It is expected that WebRTC statistics appear.
> 
> [4] https://codepen.io/anon/pen/JQLEqR?editors=1010
> 
> R=haraken@chromium.org
> TBR=guidou@chromium.org, hbos@chromium.org
> 
> BUG=787254
> 
> Change-Id: I88f26b8cbcc09b707f6db5c9e7ba40bdbd8e82e8
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893293
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Reviewed-by: Henrik Boström <hbos@chromium.org>
> Reviewed-by: Antonio Gomes <tonikitoo@igalia.com>
> Commit-Queue: Henrik Boström <hbos@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#711647}

TBR=haraken@chromium.org,hbos@chromium.org,guidou@chromium.org,tonikitoo@igalia.com

Change-Id: If20ddd5622f30af1bfe1a8ca7d3b041b605bc7b2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 787254
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895195Reviewed-by: Armando Miraglia <armax@chromium.org>
Commit-Queue: Armando Miraglia <armax@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711665}

2302c7e1

Rename all the const variables of V8PrivateProperty::SymbolKey · 7c275cad

Marina Sakai authored Nov 01, 2019

The name of const variables should be "k{{camel case name}}".
This CL follows the style.


Bug: 715418
Change-Id: I54c37152cebee1a863fceabb685480cdf08f93f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893603Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Marina Sakai <marinasakai@google.com>
Cr-Commit-Position: refs/heads/master@{#711664}

7c275cad

Revert "Make AppMenuModel keep most submenus in a vector." · dfd0e0a0

Armando Miraglia authored Nov 01, 2019

This reverts commit 849315dd.

Reason for revert: [sheriff] does not build on Mac per builder (https://ci.chromium.org/p/chrome/builders/ci/mac-builder-perf/125702)

Original change's description:
> Make AppMenuModel keep most submenus in a vector.
> 
> They are only needed for ownership, so no need to give them names and concrete
> types. Removes some forward declarations from the header and serendipitously
> happens to remove GOOGLE_CHROME_BUILD from the header as well.
> 
> No intended behavior change.
> 
> Bug: 961769
> Change-Id: Ibaaf3375bd9d367b4cc83b9a8ec3e64193750a69
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894032
> Commit-Queue: Robert Sesek <rsesek@chromium.org>
> Auto-Submit: Nico Weber <thakis@chromium.org>
> Reviewed-by: Robert Sesek <rsesek@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#711431}

TBR=thakis@chromium.org,rsesek@chromium.org

Change-Id: Id7abf98d32a424fdf3d8d0638c9967931eec30a8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 961769
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893867Reviewed-by: Armando Miraglia <armax@chromium.org>
Commit-Queue: Armando Miraglia <armax@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711663}

dfd0e0a0

Roll Fuchsia SDK from 889804785698 to 889801564777 · 1b265a17

chromium-autoroll authored Nov 01, 2019

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
TBR=cr-fuchsia+bot@chromium.org

Change-Id: Ie90acdb50b06f881dbdc80b2818583353d5f1c66
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895211Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#711662}

1b265a17

Roll src/third_party/angle e96039218e9d..076fae010165 (1 commits) · aa7e8001

chromium-autoroll authored Nov 01, 2019

https://chromium.googlesource.com/angle/angle.git/+log/e96039218e9d..076fae010165

git log e96039218e9d..076fae010165 --date=short --no-merges --format='%ad %ae %s'
2019-11-01 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/glslang/src b131630e7c74..48233ad3d45b (1 commits)

Created with:
gclient setdep -r src/third_party/angle@076fae010165

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC ynovikov@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=ynovikov@google.com

Bug: chromium:None
Change-Id: I198caaf01234ad353d71b9922b5f98ac07ae9e4b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895212Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#711661}

aa7e8001

[Sheriff] Followup on crrev.com/c/1891175 · b9459442

Armando Miraglia authored Nov 01, 2019

In the previous CL I incorrectly disabled TriggersOnEditDistance, since
I missed to rename the test. I am ammedning this here.

TBR=estark@chromium.org

Bug: 1020109
Change-Id: I1ce35929dd2082ee1b27c91e7e29da743e77df26
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895192Reviewed-by: Armando Miraglia <armax@chromium.org>
Commit-Queue: Armando Miraglia <armax@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711660}

b9459442

Rename named UTF-8 decode constructors in TextResourceDecoderOptions · b322a223

Eero Häkkinen authored Nov 01, 2019

This CL renames CreateAlwaysUseUTF8ForText to CreateUTF8Decode and
CreateAlwaysUseUTF8WithoutBOMForText to CreateUTF8DecodeWithoutBOM in
TextResourceDecoderOptions. This is to make it easier to distinguish
these two named constructors, to match with the spec names and to
shorten the names.

Bug: 796192
Change-Id: Ib3ee204b1e0c81a95ab0ca58f47def892525984e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893260
Commit-Queue: Eero Häkkinen <eero.hakkinen@intel.com>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Ben Kelly <wanderview@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711659}

b322a223

Convert mojom::URLLoaderClientPtrInfo to new Mojo types · 2a641e8a

Julie Jeongeun Kim authored Nov 01, 2019

This CL is a part of effort for converting mojom::URLLoaderClient
to new Mojo types.

It converts URLLoaderClientPtrInfo to new Mojo types using
PendingRemote and keeps URLLoaderClientPtr yet.
On a follow-up CL, URLLoaderClientPtr will be handled with
new Mojo types.

Bug: 955171
Change-Id: I659a7e0d409a8fe86e72e0dcb504fe7fa1082592
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893112Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Julie Kim <jkim@igalia.com>
Cr-Commit-Position: refs/heads/master@{#711658}

2a641e8a

Stop supporting -webkit-appearance:button for elements other than <button> and <input> buttons. · 183cb828

Kent Tamura authored Nov 01, 2019

It was deprecated in M79.

I2DR: https://t.co/ngv1jxRKwk

Bug: 981720
Change-Id: I5c365aaaa65c66a4dccd7224e4ad5d482b6ad2ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892971Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711657}

183cb828

media/gpu/DmabufVideoFramePool: Request new video frame via RequestFrames(). · bab32ffa

Chih-Yu Huang authored Nov 01, 2019

When we allocate frames with new layout, we always need to know the
maximum number of frames. This CL combines SetMaxNumFrames() and
NegotiateFrameFormat() to RequestFrames() to simplify the interface.

BUG=b:136716638
TEST=media_unittests --gtest_filter=PlatformVideoFramePoolTest*
TEST=video_decode_accelerator_tests on Kevin and Eve

Change-Id: I7c194a9107319f1a91da961140548216d2240e8d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861437
Commit-Queue: Chih-Yu Huang <akahuang@chromium.org>
Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711656}

bab32ffa

Remove a macro-generated function for a private property of NamedConstructor · 934360c8

Marina Sakai authored Nov 01, 2019

This CL removes a macro-generated fucntion for a private property of NamedConstructor, and replaces it with the new API GetSymbol, which uses an instance address of V8PrivateProperty::SymbolKey as a key to get Symbol.

Bug: 715418
Change-Id: I2e56fbf6354643f7d81e15774bb8774e98048288
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895020Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Marina Sakai <marinasakai@google.com>
Cr-Commit-Position: refs/heads/master@{#711655}

934360c8

Roll src-internal 95bb5f86b1c0..05ff793e61e6 (1 commits) · 70374606

chromium-internal-autoroll authored Nov 01, 2019

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/95bb5f86b1c0..05ff793e61e6


Created with:
  gclient setdep -r src-internal@05ff793e61e6

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=jbudorick@google.com

Bug: chromium:None
Change-Id: I6dd00adbd986e800813f48d21c129fb4a6208e41
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893787Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#711654}

70374606

Use DeleteSoon to delete BundledExchangesBlobDataSource's Core · 191a217d

Tsuyoshi Horo authored Nov 01, 2019

Bug: 1018640
Change-Id: Ifeed5db772abface2d6ed9a6b12c3f6e0a8481e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893127Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711653}

191a217d

Migrate references to the video_capture::mojom::VideoSourceProvider interface · 917706c0

Mario Sanchez Prada authored Nov 01, 2019

Convert the remaining bits referencing the VideoSourceProvider mojo interface
(from video_capture service) using the old APIs to the new mojo types, and
adapt unit tests.

Bug: 955171
Change-Id: I321f8d47bd0efc12bc054ad13e4ac44f02516da3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886854
Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711652}

917706c0

Migrate references to the video_capture::mojom::VideoSource interface · 2ca93eb0

Mario Sanchez Prada authored Nov 01, 2019

Convert the remaining bits referencing the VideoSource mojo interface
(from video_capture service) using the old APIs to the new mojo types,
and adapt unit tests.

Bug: 955171
Change-Id: Ib647a30ca7c95683bf9edca0e89d7bba1ce53d75
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886893
Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711651}

2ca93eb0

Remove a macro-generated function for a private property of Global · 33b2724e

Marina Sakai authored Nov 01, 2019

This CL removes a macro-generated fucntion for a private property of Global, and replaces it with the new API GetSymbol, which uses an instance address of V8PrivateProperty::SymbolKey as a key to get Symbol.

Bug: 715418
Change-Id: I12c60681dfa521d30dd4ec88f9cc9887e1770541
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895094Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Marina Sakai <marinasakai@google.com>
Cr-Commit-Position: refs/heads/master@{#711650}

33b2724e

Remove the function CreateCachedV8Private and the macro V8_PRIVATE_PROPERTY_SYMBOL_STRING · e631c948

Marina Sakai authored Nov 01, 2019

The function CreateCachedV8Private, which is not recommended to use because of calling ForApi(), is called only in one place.
So, this CL writes the contents of the function directly in the place where uses the function, and removes the function.

The macro V8_PRIVATE_PROPERTY_SYMBOL_STRING is also called only in one place. So, we replace the macro with a constant string.

Bug: 715418
Change-Id: Ie136200f3b87d760aa79556f835c8438e8ad47ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893602Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Marina Sakai <marinasakai@google.com>
Cr-Commit-Position: refs/heads/master@{#711649}

e631c948

Roll ChromeOS orderfile from 79-3940.0-1572257069-benchmark-79.0.3945.20-r1 to... · 0e5858e6

chromium-autoroll authored Nov 01, 2019

Roll ChromeOS orderfile from 79-3940.0-1572257069-benchmark-79.0.3945.20-r1 to 80-3940.0-1572255699-benchmark-80.0.3951.3-r1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-orderfile-chromium
Please CC c-compiler-chrome@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_EXTRA_TRYBOTS=
TBR=c-compiler-chrome@google.com

Change-Id: Iafdc442ccf05d89a137253a452b07de5ab56b52b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895152Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#711648}

0e5858e6

Fix about:webrtc-internals "Stats Tables" · f61878bc

Antonio Gomes authored Nov 01, 2019

This is a fixup CL of [1] spotted and report by hbos@chromium.org
on [2].

[1] https://crrev.com/c/1842414 (Onion soup RTCPeerConnectionHandler and its direct dependences)
[2] https://crrev.com/c/1842414/14#message-daf2b117b98895c3692a635ac873e249e6f905c1

Basically the original CL was supposed to replace the code
that used to bound PeerConnectionTracker to its associated
mojom::Receiver instance in [3] by the corresponding code in
Blink.
However, the replacement code got accidentally missing while rebasing
the CL over and over.

[3] https://crrev.com/c/1842414/14/content/renderer/render_thread_impl.cc#b777

This CL amends the original CL with the proper code in
blink/renderer/modules/modules_initializer.cc@RegisterInterfaces().

TEST=<out>/browser_tests --gtest_filter=WebRtcInternalsPerfBrowserTest.MANUAL_RunsAudioVideoCall60SecsAndLogsInternalMetricsVp8 \
--run-manual --ui-test-action-max-timeout=100000 --test-launcher-timeout=100001

Manual test= Open Chromium load about:webrtc-internals and [4].
It is expected that WebRTC statistics appear.

[4] https://codepen.io/anon/pen/JQLEqR?editors=1010

R=haraken@chromium.org
TBR=guidou@chromium.org, hbos@chromium.org

BUG=787254

Change-Id: I88f26b8cbcc09b707f6db5c9e7ba40bdbd8e82e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893293Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Reviewed-by: Antonio Gomes <tonikitoo@igalia.com>
Commit-Queue: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711647}

f61878bc

[web tests] Concatenate regex to speed up web test result JSON merging. · 8294a2f3

Daniel Cheng authored Nov 01, 2019

The JSON files that are merged by the helper script generally contain a
lot of values. The regex matcher in Python is quite optimized, so it's
faster to combine identical cases with '|' rather than adding multiple
merge helpers that execute the same thing.

Savings when run locally on my dev machine are around 500ms-1000ms.

Bug: 1014845
Change-Id: I36af02140b5efa2cbd306f7f1fb6c26f93f37a29
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894416Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Auto-Submit: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711646}

8294a2f3

Automated Commit: LKGM 12640.0.0 for chromeos. · fb80839d

3su6n15k.default@developer.gserviceaccount.com authored Nov 01, 2019

CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome

BUG=762641
TBR=chrome-os-gardeners@google.com

Change-Id: Ie4d22e3f2fc9bbdc1396cc26343d036cfd317063
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893299Reviewed-by: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#711645}

fb80839d

[IntentHandling] Sync Preferred App Setting to ARC. · fb0c1002

Maggie Cai authored Nov 01, 2019

This CL adds a method to add a preferred app with specific intent filter
to ARC. Currently the existing method uses the previous queried intent
info in the ARC code base, however, with the new intent handling
implementation, the query happened in Chrome OS and ARC does not have
this information anymore, we need to send the corresponding intent
filter to ARC to be able to set the preferred app.

BUG=853604

Change-Id: I7b3bf11deb920aadd9f6421d9f05d313bbdd8850
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882194
Commit-Queue: Maggie Cai <mxcai@chromium.org>
Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Nancy Wang <nancylingwang@chromium.org>
Reviewed-by: David Jacobo <djacobo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711644}

fb0c1002

Replace SafeJsonParser usage in extensions · dc32df89

Ken Rockot authored Nov 01, 2019

This switches extensions code to the new DataDecoder API.

As a result none of this stuff depends on the Service Manager anymore
so a bunch of Connector plumbing and awkward test setup is also deleted
here.

Bug: 977637
Change-Id: Ib4e995c75673e349c165aeb375bd78d4d7eb43af
Tbr: poromov@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881807
Commit-Queue: Ken Rockot <rockot@google.com>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711643}

dc32df89

Import wpt@7b222c0fd2cbce497a96021f2fd4e0671008548b · 9f6eced7

Chromium WPT Sync authored Nov 01, 2019

Using wpt-import in Chromium d2fe3087.
With Chromium commits locally applied on WPT:
1d5b803f "Add WebVTT support for inline styling - Web Platform Tests"
9be931cb "[WPT/common/security-features] Refactor navigable tests"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
bokan@chromium.org:
  external/wpt/visual-viewport

NOAUTOREVERT=true
TBR=raphael.kubo.da.costa

No-Export: true
Change-Id: I00d5adb0041cc07638610503b024321c35c81d49
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893298Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#711642}

9f6eced7

IDL compiler: Calculate overloaded group's exposure · cce64249

Yuki Shiino authored Nov 01, 2019

Bug: 839389
Change-Id: I2094369240b2174bf2cc874a79bec1f4222bc3d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893113Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711641}

cce64249

Roll src/third_party/chromite bf5ec7271d5c..98f3379d14d4 (6 commits) · bfbb36ea

chromium-autoroll authored Nov 01, 2019

https://chromium.googlesource.com/chromiumos/chromite.git/+log/bf5ec7271d5c..98f3379d14d4

git log bf5ec7271d5c..98f3379d14d4 --date=short --no-merges --format='%ad %ae %s'
2019-10-31 akeshet@chromium.org sysmon: add getty to the list of named counted processes
2019-10-31 vapier@chromium.org gs: drop ts_mon usage
2019-10-31 andrewlamb@chromium.org Add replication_util, which implements ReplicationConfig proto
2019-10-31 lamontjones@chromium.org gs: add "can't start new thread" transient error.
2019-10-31 saklein@chromium.org depgraph.proto: Compile newest version.
2019-10-31 tcwang@google.com afdo: Fix the AFDO names to check on afdo verify builders.

Created with:
gclient setdep -r src/third_party/chromite@98f3379d14d4

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromite-chromium-autoroll
Please CC chrome-os-gardeners@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@google.com

Bug: None
Change-Id: Iecf1818c3257b0a229865f3607c80c3356431124
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894800Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#711640}

bfbb36ea

Remove macro-generated functions for private properties for SCRIPT_PROMISE_PROPERTIES · 60ecbcff

Marina Sakai authored Nov 01, 2019

This CL removes macro-generated fucntions for private properties of SCRIPT_PROMISE_PROPERTIES, and replaces them with the new API GetSymbol, which uses an instance address of V8PrivateProperty::SymbolKey as a key to get Symbol.

Bug: 715418
Change-Id: I0f511b0cf8286ac133e473d32b44620d9d799dc4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893128Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Commit-Queue: Marina Sakai <marinasakai@google.com>
Cr-Commit-Position: refs/heads/master@{#711639}

60ecbcff

Disable CrossPlatformAccessibilityBrowserTest.LocalizedRoleDescription on linux · 9a56734f

Alice Boxhall authored Nov 01, 2019

TBR=dmazzoni@chromium.org

Bug: 1020456
Change-Id: I0cc01b417380f0ebdaae528cdd4dca0dbe720f65
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893489Reviewed-by: Alice Boxhall <aboxhall@chromium.org>
Commit-Queue: Alice Boxhall <aboxhall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711638}

9a56734f

Collect metrics for QUIC Connection Migration. · db047117

Zhongyi Shi authored Nov 01, 2019

When path degrading is detected, QUIC connection migration cannot start
until a new network becomes available. This change collect how long it
takes to have the new network become available after detecting path
degrading. And it can be used to help provide feedback to:
1. platform: decide how aggressive network switch should happen;
2. cronet embedders: decide how fast it should pull up the cellular
network when connection migration is enabled.

Change-Id: I746d80dfd0bd1e1db8856a939aa06067b1a9577d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894044Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Ryan Hamilton <rch@chromium.org>
Auto-Submit: Zhongyi Shi <zhongyi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711637}

db047117

Disable Failing vulkan_native_blink_tests · 6ef08a1d

Jonathan Ross authored Nov 01, 2019

This test is often causing a crash in the test runner.
With an incorrect message sent to
third_party/blink/tools/blinkpy/common/message_pool.py

TBR=backer@chromium.org
TEST= compositing/overflow/scrollbar-layer-placement.html
vulkan_native_blink_web_tests

Bug: 1018884
Change-Id: I1f61196f0c247e33574f7b0d46a3d2691ebb0028
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893378Reviewed-by: Jonathan Ross <jonross@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711636}

6ef08a1d

Allow set_xxx_response() methods to accept base::nullopt · 485a4432

Yusuke Sato authored Nov 01, 2019

This allows unit tests that uses FakeConciergeClient to test the
case where base::nullopt response is passed to these callbacks
without needing to modify the existing tests at all.

BUG=b:136128691
TEST=try

Change-Id: I25b31be7f060b419184e891413d21b5a645ac46b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894042Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Commit-Queue: Yusuke Sato <yusukes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711635}

485a4432

Update V8 to version 8.0.131. · 33a62ac8

v8-ci-autoroll-builder authored Nov 01, 2019

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/10d5ae79..5bb0ce8e

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Ie712fb29c2bf0ab94432857667d4e88a3f9496bd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893297Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#711634}

33a62ac8

Remove unused RAPPOR metrics · 6bced1ec

Mason Freed authored Nov 01, 2019

This CL removes (except for the enums) three unused RAPPOR metrics.
There are equivalent UKM metrics for these Web Components features.

Bug: 1016906
Change-Id: I13c14ab3113c5f39502ee00ec2b41140cbeaa19f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893519
Auto-Submit: Mason Freed <masonfreed@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711633}

6bced1ec

Utilize NGInlineCursor in {Start,End}PositionForLine() · b987258a

Yoshifumi Inoue authored Nov 01, 2019

This patch changes |{Start,End}PositionForLine()| to utilize |NGInlineCursor|
for prepeation of migraiting to |NGFragmentItem|.

This patch moves implementations of |Line{Start,End}Point()| to |NGInlineCursor|
from |NGPhysicalLineBoxFragment| to share code for improving code health.

Bug: 982194
Change-Id: I899c2ff9f1a38a5da74665d2208732c5de324c03
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888241
Auto-Submit: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711632}

b987258a

Migrate old Mojo types of Connector interface to new Mojo types · f27197f1

Gyuyoung Kim authored Nov 01, 2019

This CL converts old Mojo types of Connector interface to new Mojo types.
Major changes are as below,

  - Rename BindConnectorRequest to BindConnectorReceiver
  - Apply mojo::PendingReceiver to Connector::Create
  - Convert FooRequest to mojo::PendingReceiver
  - Convert FooPtr to mojo::PendingRemote or mojo::Remote

Bug: 955171
Change-Id: I51bfc5611f421f1754c3bda98b67d0d44b08745b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887250
Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#711631}

f27197f1

i18n strings for the summary feedback panel · c6466c39

Alex Danilo authored Nov 01, 2019

Adds percentage complete string for translation.

Bug: 1014771
Change-Id: I043b9f8127fe51732eb65ccbb68ed1257c02d901
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890401
Commit-Queue: Alex Danilo <adanilo@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711630}

c6466c39

Switch a bunch of //net to std::string::data and std::vector::data. · 739ef116

David Benjamin authored Nov 01, 2019

I don't have any immediate evidence that these are called on empty
strings or vectors, but this was an easy enough regex to write so just
fix them.

Bug: 923166
Change-Id: Iea616099c2ce755e2783e4929911e5844049bba8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894623Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Ryan Sleevi <rsleevi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711629}

739ef116