GitLab

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/7ed4b5d5..a4540654

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2040103002
Cr-Commit-Position: refs/heads/master@{#398205}

This adds support for mailboxes to ScopedWriteLockGL. Using the mailbox
requires using ScopedTextureProvider/ScopedSkSurfaceProvider which
ensures that the texture id for the mailbox is destroyed after use on
the worker context.

This CL also includes the following cleanup:
1. ResourceProvider locks don't keep resource pointers around.
2. ScopedSamplerGL does not inherit from ScopedReadLockGL.
3. GpuRasterizer is folded back into GpuRasterBufferProvider.
4. TileTaskManager does not own RasterBufferProvider.

BUG=525259
R=piman@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/1951193002
Cr-Commit-Position: refs/heads/master@{#398204}

BUG=602407

Review-Url: https://codereview.chromium.org/2042873004
Cr-Commit-Position: refs/heads/master@{#398203}

To expand field trials, enable flags on waterfall for testing.

BUG=591245

Review-Url: https://codereview.chromium.org/2045463002
Cr-Commit-Position: refs/heads/master@{#398202}

No intended behavior change.

BUG=579255

Review-Url: https://codereview.chromium.org/2043883002
Cr-Commit-Position: refs/heads/master@{#398201}

The Mac and iOS GN bots don't currently limit the number of concurrent
links. The official continuous win bots aren't on MB because they can't
limit the number of concurrent links through MB.

This CL adds a 'concurrent_links' arg to GN, which calls the
get_concurrent_links script to get the appropriate default value
(making this consistent across platforms), and also adds a hack
to MB to translate a gyp_link_concurrent "GYP_DEFINE" to the
GYP_LINK_CONCURRENCY env var.

The CL also adds a test for this MB hack and the similar, already existing
LLVM_FORCE_HEAD_REVISION hack.

R=scottmg@chromium.org, brettw@chromium.org
BUG=602480, 611491, 616390

Review-Url: https://codereview.chromium.org/2031233002
Cr-Commit-Position: refs/heads/master@{#398200}

mbstate_t is defined in <wchar.h>, which is often indirectly included
through <string>. However, that's not true for all implementations of
C++ standard library. This CL adds the missing inclusion of <wchar.h> in
base/strings/string16.h for the definition of mbstate_t.

BUG=None

Review-Url: https://codereview.chromium.org/2041633002
Cr-Commit-Position: refs/heads/master@{#398199}

There seems to be data cached by the OS which is not deleted by
DexLoader#deleteCachedDexes() which is causing the test to be flaky.
This CL changes DexLoaderTest#testLoadAfterDeleteCachedDexes() to test
DexLoader#deleteCachedDexes() in a scenario which is closer to how the function
is used in production.

The test used to test that calling DexLoader#deleteCachedDexes() would make
DexLoader#load() load a dex file from scratch.

The CL changes the test to test that:
- DexLoader#deleteCachedDexes() deletes previously extracted dexes from the local
data directory
- It is possible to use reuse a data directory to load several dexes

BUG=616923

Review-Url: https://codereview.chromium.org/2033953002
Cr-Commit-Position: refs/heads/master@{#398198}

BUG=617559

Review-Url: https://codereview.chromium.org/2039363002
Cr-Commit-Position: refs/heads/master@{#398197}

This allows the renderer to correctly interpret NV12 and other pixel formats.

BUG=574292

Committed: https://crrev.com/1ace3b00d9dad163255b8e73deaad53c0a43a79a
Review-Url: https://codereview.chromium.org/1942123002
Cr-Original-Commit-Position: refs/heads/master@{#396634}
Cr-Commit-Position: refs/heads/master@{#398196}

Currently this logic needs to be copied and called every time
chrome::AttemptRestart() is called. Moving it within chrome::AttemptRestart()
allows it to be reused. Moreover, it seems that calling
chrome::AttemptRestart() without the said logic (there are such occurrences),
is not correct.

This is in preparation of reducing the number of "Restart" codepaths in MD
Settings.

BUG=617830

Review-Url: https://codereview.chromium.org/2033173002
Cr-Commit-Position: refs/heads/master@{#398195}

ExternalNavigationHandler#intentsHaveSameResolvers() will be called on each
WebAPK navigation. Removing the duplicate call to
PackageManager#queryIntentActivities() saves 2ms per navigation.

BUG=609122
TEST=None

Review-Url: https://codereview.chromium.org/2035203002
Cr-Commit-Position: refs/heads/master@{#398194}

This CL mistakenly disabled the 'detach' behavior for ScrollbarManager:

https://codereview.chromium.org/1930183002

... because it seemed like DelayScrollPositionClampScope would be sufficient
to preserve all the necessary state for scrollbars as they were added and
removed during the multiple layout passes of flex layout.  However, that
was premature: even though the scroll positions were preserved, destroying
and recreating scrollbars during layout will invalidate the
ScrollingCoordinator's mapping from Scrollbar to WebScrollbarLayer.

One side effect is that if a scroll event handler forces layout to run during
a scrollbar drag, and the Scrollbar/WebScrollbarLayer association is broken,
then the compositor will think that the scrollbar drag has ended, even though
mouse-up has not yet happened.

This CL also sneaks in a tiny optimization: if auto scrollbars are frozen,
then childFlexBasSizeRequiresLayout should not return true due to the child
having auto scrollbars (since the scrollbars cannot change).

BUG=617498
R=eae@chromium.org,cbiesinger@chromium.org

Review-Url: https://codereview.chromium.org/2042923002
Cr-Commit-Position: refs/heads/master@{#398193}

This change decouples DesktopView(Interface) and TouchInputHandler(Interface) by
removing routing functions
DesktopViewInterface.onSoftInputMethodVisibilityChanged and
DesktopViewInterface.setInputStrategy. After this change, TouchInputHandler
takes responsibility to listen to onInputModeChanged and
onSoftInputMethodVisibilityChanged events of Desktop activity directly.

This is part remoting desktop Android client refactor work, a design doc is @
https://goo.gl/MA6zjx.

BUG=615277

Review-Url: https://codereview.chromium.org/2035303002
Cr-Commit-Position: refs/heads/master@{#398192}

BUG=610086

Review-Url: https://codereview.chromium.org/2046493005
Cr-Commit-Position: refs/heads/master@{#398191}

Spec: https://drafts.css-houdini.org/css-typed-om/#the-stylepropertymap

BUG=545318

Review-Url: https://codereview.chromium.org/1874623002
Cr-Commit-Position: refs/heads/master@{#398190}

When --isolate-extensions or --site-per-process modes are enabled, all
extensions frames run in extension processes and are not mixed in regular
web renderers. This causes a problem with security checks for
web_accessible_resources, which allow all navigations to extension pages
when they are performed in extension process. This is no longer true and
this patch addresses this by using a NavigationThrottle to perform the
proper checks on the UI thread (also PlzNavigate compatible).

BUG=616488
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2042483002
Cr-Commit-Position: refs/heads/master@{#398189}

It had been a while since I'd run `mb audit` and there were
a few new builders that didn't have entries. This adds those,
removes some builders that are gone, and fixes some typos.

TBR=brettw@chromium.org
BUG=605732

Review-Url: https://codereview.chromium.org/2047583002
Cr-Commit-Position: refs/heads/master@{#398188}

This CL corrects the timestamp sent with the encoded frame data from
VTVideoEncodeAccelerator. Recently, this functionality is added to the
VEA interface and we can use the frame's original capture timestamp.

BUG=350106
TEST=AppRTC loopback in Macbook Air.

Review-Url: https://codereview.chromium.org/2039423002
Cr-Commit-Position: refs/heads/master@{#398187}

This patch completes the implementation of multi-process find-in-page, as described in the design doc: https://docs.google.com/document/d/12S_6X2MWWLoyJslajcajL2ELU7zhodPxMOxa8Bg4Wg0/view

BUG=457440
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/1959183002
Cr-Commit-Position: refs/heads/master@{#398186}

Revert of Fix event page process cleanup when running in --isolate-extensions mode. (patchset #6 id:100001 of https://codereview.chromium.org/2028873002/ )

Reason for revert:
Speculative revert of this CL to check if it is the root cause of https://crbug.com/616989.

Original issue's description:
> Fix event page process cleanup when running in --isolate-extensions mode.
>
> With --isolate-extensions, navigations can start in one RenderFrameHost
> and complete in another. This was not possible to happen with extensions
> related RenderFrameHosts in the past, so the code wasn't able to handle
> it. This CL refactors the OnNetworkRequest(Started|Stopped) to use the
> navigation request id as the stable identifier instead of the associated
> RenderFrameHost.
>
> BUG=612668
>
> Committed: https://crrev.com/c25500369dd9a7f49d2b7d276556b2e22ba840c8
> Cr-Commit-Position: refs/heads/master@{#397328}

TBR=rdevlin.cronin@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=612668

Review-Url: https://codereview.chromium.org/2044643003
Cr-Commit-Position: refs/heads/master@{#398185}

Previous code change 2018643002 (for user menu redesign) modified code on the spot and did not put the changes behind any flag. This CL is to:
1. add flags for the previous code change;
2. add back some of the deleted resources as they will still be used when the flag is not turned on.

BUG=615893

Review-Url: https://codereview.chromium.org/2034093003
Cr-Commit-Position: refs/heads/master@{#398184}

Needed for downloads UI.

BUG=616324

Review-Url: https://codereview.chromium.org/2039413003
Cr-Commit-Position: refs/heads/master@{#398183}

EarlGrey typically handles synchronization with the UI, but it is
useful when manipulating non-UI APIs to be able to wait for a certain
state.

BUG=610837

Review-Url: https://codereview.chromium.org/2044433003
Cr-Commit-Position: refs/heads/master@{#398182}

These friend declarations were added because MSVC had a bug around the
visibility of nested classes. They are no longer necessary.

BUG=617504

Review-Url: https://codereview.chromium.org/2043633002
Cr-Commit-Position: refs/heads/master@{#398181}

Notifications content settings don't consider the embedding origin
when updating the content setting values. Remove unused embedder
param in SetNotificationSettingForOrigin.

Review-Url: https://codereview.chromium.org/2035323002
Cr-Commit-Position: refs/heads/master@{#398180}

This was added for the texture-layer code but not the surface layer. If
the viewport is changed but a new buffer isn't attached then the old
resource information will be re-sent with the new Surface. The
SurfaceFactory will handle refcounting uses of the buffer.

Review-Url: https://codereview.chromium.org/2032173002
Cr-Commit-Position: refs/heads/master@{#398179}

ShelfModel, ShelfItemDelegate and ShelfItemDelegate have no dependencies on
ash::Shell, ash::RootWindowController or aura::Window so they can be moved
as-is.

No functional changes.

BUG=615155
TEST=compiles

Review-Url: https://codereview.chromium.org/2046513003
Cr-Commit-Position: refs/heads/master@{#398178}

Otherwise, GN does not get that it's a ToT build and the build dir
is not clobbered.

BUG=617771

Review-Url: https://codereview.chromium.org/2039103003
Cr-Commit-Position: refs/heads/master@{#398177}

This change replaces the two tab switcher borders that existed
(standard and incognito) with a single white one that can be tinted
to any color it needs to be.

BUG=606612

Review-Url: https://codereview.chromium.org/2045733002
Cr-Commit-Position: refs/heads/master@{#398176}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/f8c7729d..7ed4b5d5

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2044713002
Cr-Commit-Position: refs/heads/master@{#398175}

Content settings are not used on all platforms. Some content settings are only
used on desktop platforms, or desktop and android. We shouldn't register these
types on other platforms that aren't using them, so that we don't create unused
prefs for them and more importantly so that we don't sync settings to these
platforms which would go unused but be a potential privacy concern.

In this CL, an enum WebsiteSettingsInfo::Platform is added and used when
registering content settings to indicate which platform set it is applied to.

BUG=604632

Review-Url: https://codereview.chromium.org/1991623005
Cr-Commit-Position: refs/heads/master@{#398174}

Have Resource::setRevalidatingRequest() just overwrite
m_resourceRequest, and keep an m_isRevalidating bit to track
whether a revalidation is progress.

Ideally we'd get to a point where the m_isRevalidating bit
isn't needed, or at least doesn't need to be accessible
outside of Resource and its subclasses.

BUG=

Review-Url: https://codereview.chromium.org/1997833002
Cr-Commit-Position: refs/heads/master@{#398173}

R=jamescook@chromium.org
TBR=jamescook@chromium.org
BUG=none
TEST=none

Review-Url: https://codereview.chromium.org/2040803006
Cr-Commit-Position: refs/heads/master@{#398172}

https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/ba8c5aa..f43726c

BUG=
TEST=bots
TBR=kbr@chromium.org
NOTRY=true
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.linux:linux_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2043913002
Cr-Commit-Position: refs/heads/master@{#398171}

No change in logic.

BUG=549781
TBR=jbauman@chromium.org

Review-Url: https://codereview.chromium.org/2048453002
Cr-Commit-Position: refs/heads/master@{#398170}

Since we no longer support WinXP/WS2K3 and Vista/WS2K8, we can clean up our
code a bit by removing logic and conditions which only apply to those versions.

BUG=607676

Review-Url: https://codereview.chromium.org/2037163002
Cr-Commit-Position: refs/heads/master@{#398169}

This is necessary in cases that document.write changes the effective
URL of the about:blank page, and then the user goes back.

BUG=446959
TEST=See bug for repro steps.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2032903007
Cr-Commit-Position: refs/heads/master@{#398168}

Some destruction flows don't seem to call OnWidgetActivationChanged
before destroying the window, which causes the extension keybinding
registry reference in the global registry to become stale. Update the
active registry on deletion.

BUG=616970

Review-Url: https://codereview.chromium.org/2046653002
Cr-Commit-Position: refs/heads/master@{#398167}

cr.sendWithPromise() is gaining traction outside of MD Settings, and the
C++ helpers to resolve/reject a JS Promise are more useful in the
superclass WebUIMessageHandler instead of SettingsPageUIHandler.

Review-Url: https://codereview.chromium.org/2040473002
Cr-Commit-Position: refs/heads/master@{#398166}