- 25 Sep, 2020 40 commits
-
-
Lingqi Chi authored
https://chromium-review.googlesource.com/c/chromium/src/+/821796 stopped using Net.ResourceLoader.ResponseStartToEnd..*. This CL adds the <obsolete> tag to remove these histograms. Bug: 686984 Change-Id: I30890e37016a6a30a5bfd8955aaed681f51f6011 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423676 Commit-Queue: Lingqi Chi <lingqi@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#810533}
-
harrisonsean authored
Safety Check on iOS has an update check, to support this we are adding the ability to do one off checks to Omaha for iOS. If there is an ongoing scheduled ping, or one is scheduled during the one off check, it is taken by the one off check. Otherwise it will send its own ping. The one off check updates all user defaults for update status, and makes Chrome think that it has just shown an update infobar (if an update is available) so that users triggering an update check aren't shown an update infobar soon after being told they are out of date by the update check. Adds another user default to track if the device is up to date as of the last check (scheduled or one off). A device that is unable to update is considered up to date in this user default. Bug: 1078782 Change-Id: I2e4a1982dd0b34258c78c85ecf23e2f199630f1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398725 Commit-Queue: Sean Harrison <harrisonsean@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#810532}
-
Alice Wang authored
This CL renames the sign-in methods in AccountManagerTestRule to signinAndEnableSync to be consistent with the new sign-in API. Bug: 1131936 Change-Id: I6507712ad38b37c987507bea549b4c9371946a2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429065 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#810531}
-
Ben Mason authored
Change-Id: I8ee6fc5e097c47b53fa8fd576ff60e97cbeca06c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429343 Commit-Queue: Ben Mason <benmason@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#810530}
-
Dom Schulz authored
Change-Id: I402355cc184d62341cdb6d2604113c6f7642d104 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426369 Auto-Submit: Dominic Schulz <dominicschulz@google.com> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#810529}
-
Nick Harper authored
Change-Id: I960a85c72784e1cce26c69455fe28dd51d97cd35 Bug: 1127947 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428536 Commit-Queue: Nick Harper <nharper@chromium.org> Commit-Queue: David Schinazi <dschinazi@chromium.org> Auto-Submit: Nick Harper <nharper@chromium.org> Reviewed-by:
David Schinazi <dschinazi@chromium.org> Cr-Commit-Position: refs/heads/master@{#810528}
-
Kramer Ge authored
Using a 4x4 sized opaque background will not regress performance in underlay cases because the root surface is still opaque. The background will be stretched out by wayland viewporter extension. This is 6/? CL for overlay forwarding using wl_subsurface. Change-Id: I59b0d4cdbfbb6727d578e286c9d19cf69a9bff32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352523 Commit-Queue: Kramer Ge <fangzhoug@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Maksim Sisov (GMT+3) <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#810527}
-
Rune Lillesveen authored
We have a DCHECK that ensures we start with initial style as the parent style if the element is the document root element, or if we are computing styles outside the flat tree, in which case we start at unassigned host children. A similar case is for fallback children of slots which are not part of the flat tree because the slot has assigned nodes from the host. Add that condition to the DCHECK along with a test. Bug: 1131767 Change-Id: Ic8a44f52273cc10a3a6936bf80b3b25ac0cb85d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426450Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#810526}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: Ibd795dce801aa79c63c0f33f75a0221ccec696fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429536Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#810525}
-
Jan Wilken Dörrie authored
This reverts commit 349707ef. Reason for revert: Suspected culprit of https://crbug.com/1132219. Original change's description: > Create separate class to handle creation of holding space bubble > > This class will own pinned_files_container and recent_files_container. > It will also be responsible for setting the max size for the pinned > files container based on available screen space and update it when > screen space changes. > > Bug: 1131268 > Change-Id: If09810570e59f7beeac0667e84d4cd558ee67bc0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427081 > Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> > Reviewed-by: David Black <dmblack@google.com> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#810423} TBR=xiyuan@chromium.org,dmblack@google.com,amehfooz@chromium.org Change-Id: Ia221abfb393dcd7f9cdfa7e539133477bd7852ca No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1131268 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429275Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#810524}
-
Yuta Hijikata authored
g_log_format has to be set within BaseInitLoggingImpl regardless of the log target. BUG: None TEST: base_unittests Change-Id: I4690d537600eb0eb7e88e897435cf014e013e251 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417738 Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#810523}
-
Gyuyoung Kim authored
As discussed on platform-architecture-dev ML[1], this CL adds the guideline to public/README.md file for claryfing the naming conventions in public/web/, platform/, and common/ [1] https://groups.google.com/a/chromium.org/g/platform-architecture-dev/c/qrZLqP4ndJE/m/uiBiljN9BwAJ Bug: None Change-Id: I51eceae18b16a282b61a65f7ff4d0f16c566c114 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429982Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#810522}
-
Josh Simmons authored
Replaced the existing icons with new icons that have a different style. Test: Looked at Files.app icon in launcher, shelf and switcher Bug: 1128673 Change-Id: I55e3a586dd6ea9ab7f03134d4992eb6e7e2ae92d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430564Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Josh Simmons <simmonsjosh@google.com> Cr-Commit-Position: refs/heads/master@{#810521}
-
Nela Kaczmarek authored
[Passwords] Use OneShotTimer to wait for the result of Affiliation Service prefetch before the redirect action. This change implements OneShotTimer that waits for the result of Affiliation Service prefetch. The result or timeout is followed by redirection to change password url or origin. The facet to be requested in Affiliation Service is now created from SchemeHostPort type which removes the relative path. Bug: 1108279 Change-Id: I2c47dc3b0b70bc9768b967441762b80a965386cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401165 Commit-Queue: Nela Kaczmarek <nelakaczmarek@google.com> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#810520}
-
Olivier Yiptong authored
This change ensures fonts are sorted before being cached. This change is due to a concern about fingerprinting: https://github.com/w3ctag/design-reviews/issues/399#issuecomment-530679815 This change ensures that fonts are sorted in lexicographical order. Bug: 1043306 Change-Id: Ia3acf2a45cb473124df4e489683bdc7bac15dde4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427040 Commit-Queue: Olivier Yiptong <oyiptong@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#810519}
-
Sebastien Marchand authored
The BrowserContextKeyedServiceFactory are leaked between tests (by design) and this is problematic with the SiteDataCacheFacadeFactory because it owns an SiteDataCacheFactory object in a SequenceBound wrapper. Leaking this between tests causes UAFs on the task runner used by this SequenceBound wrapper. The solution consists in tracking the number of alive SiteDataCacheFacade instances and releasing the SiteDataCacheFactory when this count reaches 0. As profiles always get destroyed before terminating a test this ensures that we don't leak the SiteDataCacheFactory anymore. Bug: 1127928 Change-Id: I88777d8761f60aeeb90322234f861d196ed9e548 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422079 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#810518}
-
Jan Wilken Dörrie authored
This reverts commit 5c550b35. Reason for revert: Suspected culprit of https://crbug.com/1132207. Original change's description: > Improve name calc handling of hidden objects, relation traversal > > - Display: none objects should not get an accessible name. > - EnsureComputedStyle() should not be called during a potentially unsafe > time. This is fixed by calling it during Init(), in cases where it > will likely be needed (inside a display:none subtree). > - Remove unnecessary and often incorrect heuristic for determining when > inside an aria-labelledby or aria-describedy calculation. This flag is > already passed in via recursion when following that kind of relation. > - Do not recurse into children that are explicitly hidden > - Improve explicitly hidden computation for CSS visibility. Explicitly > hidden means that the element was specifically hidden, and that it > didn't just inherit the fact that it's hidden. > - Improve results in name-calc-visibility, where an element explicitly > referenced by aria-labelledby wasn't included in the name because it > was visibility:hidden element. Elements that are explicitly referenced > must be included in a name or description even if they are hidden. > > Bug: 1130436 > Change-Id: I58b7b70b53c5c1d37ec1407bc2ecb35de3d17d4a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212795 > Reviewed-by: vmpstr <vmpstr@chromium.org> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#810426} TBR=dmazzoni@chromium.org,vmpstr@chromium.org,aleventhal@chromium.org Change-Id: Ia243d9fe2495af7646f6af6deb79b967bf4b0bec No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1130436 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428969Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#810517}
-
Ayu Ishii authored
This change ships the Cookie Store API to stable. It also removes some IDL changes that were necessary to get around an issue caused by the combination of Expose, partial interface and Origin Trial integration. More details on this can be found here [1], [2]. Intent 2 Ship: https://groups.google.com/u/2/a/chromium.org/g/blink-dev/c/zOsGZGMGiM4 [1] Work around implementation: https://crrev.com/c/2191240 [2] IDL crbug: https://crbug.com/839117 Bug: 729800 Change-Id: I26ffdabb316ef49f560d78945d818123fd64b39d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411149 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#810516}
-
Colin Blundell authored
This API was removed in https://chromium-review.googlesource.com/c/chromium/src/+/2225821. The continued presence of this permissions check for the deleted API causes a crash in debug builds. This CL removes the check, adjusts associated unittests, and deprecates the permission. Bug: 986981 Change-Id: I1b9a6596d8dd0af5a80f0fd2348b11569273cbaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428923Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#810515}
-
Trent Apted authored
Usage was removed in r801695 Bug: 909963 Change-Id: I57d8b7faabede399f62911e58c40c833a60312a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430684Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#810514}
-
harrisonsean authored
Add support for a timestamp of when safety check last found issues. Add support for initial unsafe states to only show if a safety check has previously found isses. Bug: 1078782 Change-Id: Ica710b284c066684cfad8488ada996295756ac29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421310 Commit-Queue: Sean Harrison <harrisonsean@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#810513}
-
Minoru Chikamune authored
[MBI] Add TRACE_EVENTs to show if the ThreadTaskRunnerHandle::Get() returns default task runner from MTS or AGS. [related design doc] https://docs.google.com/document/d/1y-vHkrD1z2RtyWYwT6rJkSLHClYNjDDpUbTtBU7l95A Bug: 1105403 Change-Id: Iab2c3c9e187f6961f3924222c8ba35c29be82afd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414329 Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Reviewed-by:
Dominic Farolino <dom@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Tal Pressman <talp@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#810512}
-
Maggie Cai authored
Currently there are couple of issues related to the preferred apps handling for browser apps in the intent picker. 1. Setting browser apps as preferred app will set it as preferred app for all urls. This is inconsistent with the behaviour for other apps. 2. If we set the browser as preferred app or set as always stay in chrome for the browser, then navigate to a website that has other apps that can handle the url, should we show the intent picker? It is reasonable for a browser to not suggest other browsers for handling http/https links, so this CL stops browser apps from appearing in the intent picker. Users can still open links in other browsers by opening them explicitly, matching Android's behaviour. BUG=853604, 1113124 Change-Id: I38b8f7be0d08becca2604ce6998bf40cab8a9729 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342331 Commit-Queue: Maggie Cai <mxcai@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#810511}
-
Yutaka Hirano authored
According to the flakiness dashboard the test is no longer timing out, but often failing. Fix the expectation. Tbr: bokan@chromium.org Bug: 1130876, 919789 No-Try: true Change-Id: Iab3443121eb7afd89f34eaa35a7af921170c2c0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428498Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#810510}
-
Joshua Pawlicki authored
I've tried to remove exception handling for unchecked exceptions caused by programmer error - catching these hides bugs that we would otherwise detect. Bug: 1110340 Change-Id: Id06136367c7b342ff5714118305eda6bf8ba652b Fixed: 1110340 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412134 Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Auto-Submit: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#810509}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/9e81182f8ea5..39a3f081c129 2020-09-24 gustaf@webrtc.org Disable transparent mode when ERL is bounded 2020-09-24 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision b70f108b..fb765f65 (810146:810252) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I9235502a8d1dcb4da7f7e3a0f5ed0d60c18ad869 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430230Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#810508}
-
Minoru Chikamune authored
[related design doc] https://docs.google.com/document/d/1y-vHkrD1z2RtyWYwT6rJkSLHClYNjDDpUbTtBU7l95A Bug: 1105403 Change-Id: I8a062b1bc4892c8cbc0b0bbc6d3b9b124ecf8950 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414428 Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Reviewed-by:
Dominic Farolino <dom@chromium.org> Reviewed-by:
Tal Pressman <talp@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#810507}
-
Sergey Poromov authored
Shows a toast when scripted printing is blocked due to Data Leak Prevention configuration. Bug: 1124651 Change-Id: I0cfd0c81fff0ca924a212ab988de3bc869bc53f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421515 Commit-Queue: Sergey Poromov <poromov@chromium.org> Reviewed-by:
Aya Elsayed <ayaelattar@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Nikita Podguzov <nikitapodguzov@chromium.org> Cr-Commit-Position: refs/heads/master@{#810506}
-
Sergey Poromov authored
By implementing GetRestrictionSetForURL() we finally connect on screen content restrictions to the policy rules engine (DlpRulesManager) and resolve the TODO. Bug: 1109783 Change-Id: I29e62a2b33e7051cfc00b40179bfe5c8d48d0e72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421895Reviewed-by:
Aya Elsayed <ayaelattar@chromium.org> Reviewed-by:
Nikita Podguzov <nikitapodguzov@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#810505}
-
Jinsuk Kim authored
IncognitoStateProvider uses a tab model to provide its incognito state, used by toolbar/omnibox. This CL moves it to tabmodel module, in an effort to reduce the omnibox's dependency on toolbar. Bug: 1127732 Change-Id: If5b1904e6d7d90165d92ce348f3bc704beec8a52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2408598 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#810504}
-
Allen Bauer authored
Added metadata to Tab, TabSlotView https://docs.google.com/document/d/1FXacwqJjW4ircJ19gsypRnLAWMYmM8sFTyDCpBH48jI/edit?usp=sharing Bug: 938501 Change-Id: I659ca7eea66d8b50e0609d08b29cfc8efd3b8809 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429515 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#810503}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/5b2e586ff35d..f7a0128b9441 2020-09-25 thestig@chromium.org Simplify interface to CJX_Object::SetAttributeValue(). 2020-09-25 thestig@chromium.org Simplify interface to CJX_Object::SetCData(). 2020-09-24 thestig@chromium.org Remove a parameter from CJX_Object::SetAttributeByString(). 2020-09-24 thestig@chromium.org Disambiguate CJX_Object methods. 2020-09-24 tsepez@chromium.org Rework bit-twiddling in CFGAS_Stringformatter 2020-09-24 asweintraub@google.com Fix a ClangTidy issue. 2020-09-24 tsepez@chromium.org Nest FX_LOCALE* enums. 2020-09-24 thestig@chromium.org Do IWYU for unowned_ptr.h, and remove some unused includes. 2020-09-24 thestig@chromium.org Clean up CXFA_Node::AddBindItem() and RemoveBindItem(). 2020-09-24 tsepez@chromium.org Avoid leaks on fuzzer exit. 2020-09-24 sdefresne@chromium.org Explicitly filter assigments to sources variable If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1018739,chromium:1131837 Tbr: pdfium-deps-rolls@chromium.org Change-Id: Ic843aef9ca85630b3dbea56dbefbb565c071866e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430350Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#810502}
-
Makoto Shimazu authored
Bug: 1129850 Change-Id: I1b1f7dbaa2f63fa7797cf9637a828e5379b7e39d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428302 Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Auto-Submit: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#810501}
-
My Nguyen authored
There is a bug in caching logic as since this file is evaluated before OWNERS file in os_settings_strings_grdp folder, thus presubmit failed. Making regex strings more specific to only apply to .grdp files. This doesn't affect other settings strings folders because they all have their OWNERS file. Bug: 1131197 Change-Id: I81abecaf2600756de12ed847fa8be5325c16d36c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430525Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: My Nguyen <myy@chromium.org> Cr-Commit-Position: refs/heads/master@{#810500}
-
Nidhi Jaju authored
The service worker codebase currently uses a lot of GURLs for origins. However, url::Origin should be used for origin instead of GURL where possible due to security decisions. This CL changes ServiceWorkerContextWrapper:: StopAllServiceWorkersForOrigin to use url::Origin instead of GURL. Some relevant callsites have also been modified accordingly. Bug: 1095896 Change-Id: I8571beeb38dc0dedc944e73521475bb518c8b9e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410066Reviewed-by:
David Bertoni <dbertoni@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Nidhi Jaju <nidhijaju127@gmail.com> Cr-Commit-Position: refs/heads/master@{#810499}
-
Kent Tamura authored
This CL fixes the following error: > ERROR at //third_party/blink/renderer/bindings/core/v8/serialization/serialized_script_value_fuzzer.cc:20:11: Can't include this header from here. > #include "third_party/blink/renderer/core/testing/dummy_page_holder.h" > ^---------------------------------------------------------- > The target: > //third_party/blink/renderer/bindings/core/v8:v8_serialized_script_value_fuzzer > is including a file from the target: > //third_party/blink/renderer/core:testing This CL has no behavior changes. Bug: 800764 Change-Id: I3a28e57876b52fba53a931c1b0bd0eaef99a0213 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428514 Auto-Submit: Kent Tamura <tkent@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#810498}
-
Keren Zhu authored
Bug: 772945 Change-Id: Ibfcd4c6fb74f39e95a5892573a30ff6ea9e200b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429534 Commit-Queue: Keren Zhu <kerenzhu@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#810497}
-
Lei Zhang authored
Per base/containers/README.md, base::flat_map is a better choice for a small, fixed map. Change-Id: I9a64ce59aadcfc26d7f986030f1732507009cf96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427550 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Piotr Pawliczek <pawliczek@chromium.org> Cr-Commit-Position: refs/heads/master@{#810496}
-
Thanh Nguyen authored
This CL adds suggested content toggle for dinner for one. Bug: 1028373 Change-Id: Iafae0bceaaecfd72dec37f983b18a35f06b5fcb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426215 Commit-Queue: Thanh Nguyen <thanhdng@chromium.org> Reviewed-by:
Rachel Wong <wrong@chromium.org> Reviewed-by:
Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#810495}
-
Darren Shen authored
As mentioned in: https://developers.google.com/closure/compiler/docs/limitations#implications-of-object-property-flattening 'this' should not be used outside of the constructor or prototype methods. Using 'this' in a static method will break under the --collapse_properties flag in Closure. --collapse_properties is a recommended flag in google3, hence fixing this makes it easier to use mojo lite bindings in google3. Bug: 1132142 Change-Id: I046615009d76f919cab6569285e9dfba6922b98e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428269Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#810494}
-