GitLab

One of the assumptions of the newly added tests was violated under a sanitizer
build. This is not particularly surprising, so I disabled that check for
sanitizer builds.

> I added two tests for memory leaks in the attachment brokering process. The
> first checks memory usage after brokering a single, large, shared memory object.
> The second checks memory usage after brokering a thousand, smaller memory
> objects.
>
> BUG=557387
> Committed: https://crrev.com/a519e56d03e1f6d69b7475bdd006f5e47b4f581e
> Cr-Commit-Position: refs/heads/master@{#360935}

BUG=557387

Review URL: https://codereview.chromium.org/1464413002

Cr-Commit-Position: refs/heads/master@{#361391}

This is an optional CL.  There was a question from Micael about using named keys
for the menu options rather than an array index.  This CL shows what that would
look like.

Performance side-effect: inconsequential (measured by hand).

BUG=531786

Review URL: https://codereview.chromium.org/1420533011

Cr-Commit-Position: refs/heads/master@{#361390}

Or is it the other way around...

Review URL: https://codereview.chromium.org/1477433002

Cr-Commit-Position: refs/heads/master@{#361389}

Without these tooltips, there's no way to read long folder names.

BUG=551259

Review URL: https://codereview.chromium.org/1471003005

Cr-Commit-Position: refs/heads/master@{#361388}

https://chromium.googlesource.com/skia.git/+log/0a0605d4de31..0f6cca8a2070

$ git log 0a0605d4d..0f6cca8a2 --date=short --no-merges --format='%ad %ae %s'
2015-11-24 cdalton Optimize visualbench offscreen blits
2015-11-24 herb Change XPS to use find and place glyph.
2015-11-24 robertphillips Sniff out rects, ovals & rrects in SkGpuDevice::drawPath
2015-11-24 kkinnunen Generate list of GPU contexts outside ImageTest tests
2015-11-24 msarett Cherry pick one more commit into libjpeg-turbo
2015-11-24 robertphillips Upgrade debugger to print more SkPath info (isOval & isRRect)
2015-11-24 hendrikw skia: Holding onto the image in the benchmark causes issues
2015-11-24 robertphillips Clarify when oval & rrects get devolved to paths in SkGpuDevice/GrDrawContext boundary
2015-11-24 mtklein Add SK_BEGIN_REQUIRE_DENSE / SK_END_REQUIRE_DENSE.
2015-11-24 djsollen Whitespace change to trigger android automerger

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=jvanverth@google.com

Review URL: https://codereview.chromium.org/1469373002

Cr-Commit-Position: refs/heads/master@{#361387}

All Lo-Fi directives for the "Chrome-Proxy" header should be added by the
ContentLoFiDecider. This includes "q=low" and "exp=lofi_active_control".

BUG=539934

Review URL: https://codereview.chromium.org/1463583003

Cr-Commit-Position: refs/heads/master@{#361386}

This change affects E2ETests only, the test is still enabled
on chromium waterfalls.

BUG=559250

Review URL: https://codereview.chromium.org/1460923004

Cr-Commit-Position: refs/heads/master@{#361385}

Just have callers call ContextUtils.initApplicationContext instead, the
extra indirection isn't useful.

BUG=552419
R=yfriedman@chromium.org

Review URL: https://codereview.chromium.org/1471273002

Cr-Commit-Position: refs/heads/master@{#361384}

Most Unix files end in newline, so by having the contents of
/proc/<pid>/cgroup by newline with SPLIT_WANT_ALL, the last entry was
always blank, triggering a NOTREACHED() and polluting the log. This
change uses SPLIT_WANT_NONEMPTY instead to get rid of empty lines.

BUG=548818
TEST=base_unittests --gtest_filter=ProcessTest.TestIsProcessBackgroundedCGroup

Review URL: https://codereview.chromium.org/1474483002

Cr-Commit-Position: refs/heads/master@{#361383}

This CL matches the GYP changes done in crrev.com/1462853002 for gn
build files.
In gn version, browser_extension, web_cache/browser already do not
depend on allocator.
chrome_child target already depends on allocator.
test_support_gpu does not exist in gn and content_browsertests directly
includes those dependencies.

All executables that are affected depend on allocator after this patch:
  browser_tests, chrome, chrome_app_unittests, interactive_ui_tests,
  performance_browser_tests, sync_integration_tests,
  sync_performance_tests, unit_tests, chromevox_tests

BUG=

Review URL: https://codereview.chromium.org/1469123002

Cr-Commit-Position: refs/heads/master@{#361382}

This CL does a refactoring of the dependencies and do not change any
behavior. The diff between the ninja files is presented in link:
http://pastebin.com/aG6eq5cb.

The test_support_gpu.gypi included allocator.gyp for no reason, and the
only other target that uses this file is content_browsertests, which
already includes allocatpor.gyp with same conditions. So, removing
this dependency here.

target:browser_ui - depends on allocator.gyp in windows
targets that depend on browser_ui:
  chrome_android_core: not used in windows

  Dependency on allocator.gyp exists already for:
  All, browser (explained below)

target:browser - depends on allocator.gyp in windows
targets that depend on browser:
  chrome_android_core: only android
  chromevox_tests: added dependency to allocator.gyp for windows

  Dependency on allocator.gyp exists already for:
    All, interactive_ui_tests, browser_tests, performance_browser_tests
    chrome_main_dll, chrome_initial, unit_tests, chrome_app_unittests

    test_support_sync_integration's executables:
      sync_integration_tests, browser_tests, sync_performance_tests

    test_support_common's executables:
      interactive_ui_tests, browser_tests, performance_browser_tests

    test_support_unit's executables:
      unit_tests

target:renderer - depends and exports dependency on allocator.gyp in
windows
targets that depend on renderer:
  chrome_android_core: not used in windows
  chromevox_tests: added dependency to allocator.gyp for windows
    chrome_child_dll - added dependency.

  Dependency on allocator.gyp exists already for:
    interactive_ui_tests, browser_tests, performance_browser_tests
    sync_integration_tests, chrome_main_dll, chrome_initial, unit_tests
    chrome_app_unittests

    test_support_common - explained earlier.

target:browser_extensions - depends on allocator.gyp in windows
targets that depend on browser_extensions:
  apps - browser (explained above)
  browser_ui (explained above)
  browser_chromeos
    browser (explained above)
    browser_tests
    apps - browser (explained above)

target:web_cache_browser - depends on allocator.gyp in windows
All the targets that depend on web_cache_browser already have
dependency on allocator.gyp:
  browser*, components_unittests

  extensions_browser
    extensions_unittests, browser_extensions*, apps*

    media_router
      browser_ui*, browser*, native_app_window - browser_ui*
      javascript_dialog_extensions_client - browser_ui*
      media_router_test_support
        browser_tests, test_support_unit*, unit_tests

    app_shell_lib
      extensions_browsertests, app_shell, app_shell_unittests

    extensions_test_support
      extensions_unittests, extensions_browsertests, app_shell_unittests
      test_support_common*

* - see previous sections for why it is fine for the target to not
depend on allocator.gyp

BUG=

Review URL: https://codereview.chromium.org/1462853002

Cr-Commit-Position: refs/heads/master@{#361381}

Deprecate FLAGS_quic_read_packets_full_recvmmsg.

Merge internal change: 107932700
https://codereview.chromium.org/1467453007/

removing a redundant way of checking if QUIC has pending crypto data.

Merge internal change: 107932405

Make QuicPacketCreator be able to serialize packet itself when it does not have room for next stream frame. No functional change expected.

For QuicPacketCreator, add DelegateInterface class, Flush function, move SerializePacket from public to private.
For QuicPacketGenerator, add OnSerializedPacket function, remove SerializeAndSendPacket.

Merge internal change: 107814957
https://codereview.chromium.org/1459343009/

These packets got reformatted at some point, maybe before the clang-format off annotation was added.

Merge internal change: 107790487

Get rid of unnecessary CompareSpdyHeaderBlocks method, use
operator== instead. No behavior change.

Merge internal change: 107784612

minor changes to batched write to make DCHECK happy.  Behind FLAGS_quic_batch_writes

Also includes a test fix to update bytes on the correct stream to get the no-op
we intended (rather than a no-op we didn't intend)

Merge internal change: 107783952
https://codereview.chromium.org/1472573002/

Deprecate FLAG_reset_cubic_epoch_when_app_limited.

Merge internal change: 107711408
https://codereview.chromium.org/1467453006/

Add ConsumeData method to QuicPacketCreator, ConsumeData wraps both CreateStreamFrame and AddFrame. No functional change expected.

Also move CreateStreamFrame from public to private in QuicPacketCreator.

Merge internal change: 107709890
https://codereview.chromium.org/1464153002/

Add WritePushPromise() method in QuicHeadersStream for server push.

Merge internal change: 107699435
https://codereview.chromium.org/1471583002/

Clear the connection's send alarm when a new ack is received.  Flag protected by FLAGS_quic_respect_send_alarm.

Merge internal change: 107697347
https://codereview.chromium.org/1466153002/

Remove the LOG(DFATAL) from QuicTestClient::address(), since it appears to be implemented.

Changing from QuicPriority to SpdyPriority.

Merge internal change: 107687942
https://codereview.chromium.org/1468773002/

Replacing EffectivePriority with Priority for QUIC.

The only place we had changing priority was "if the response headers were
serialized and not sent"  After we moved to having a separate headers stream
we never utilized the QuicWriter's header buffer, instead passing
headers directly to the QUIC layer which serialized them and sent them with
their own special priority.

Removing the idea of mutable priority enables having the write blocked list
track stream priorty, removing SPDY-specific logic from our shared code and
moving us closer to the new H2 style write scheduler logic.

Merge internal change: 107610692
https://codereview.chromium.org/1471573002/

Let QUIC streams write 16k before ceding. Behind FLAGS_quic_batch_writes.

Changing our round robin logic to prompt a given stream until it has finished
~16k (rounding up to the max quic packet payload).

Merge internal change: 107595145
https://codereview.chromium.org/1472563002/

Removing unused code to convert QUIC from SPDY3 to SPDY4

Now that QUIC version 24 is gone, we shouldn't need to worry about converting
headers from SPDY3 to SPDY4 as it should all be SPDY4

Merge internal change: 107581674
https://codereview.chromium.org/1463303002/

Cleanup: clang-formatting gfe/quic/quic_framer* to comply with Chromium style guide.

 clang-format -i --style="{BasedOnStyle: Chromium, Standard: Cpp11}"
 ./quic_framer*

Merge internal change: 107514106
https://codereview.chromium.org/1466693002/

QUIC proof source: allow construction with an |SSLContext| provider.

To support |SSLContext| swaps, the long-lived |ProofSourceChromium|
object must have a means of retrieving the new context.  The simplest
way to do that seems to be to pass in a getter method: the alternative
of calling |SSLGlobalData::ssl_context| is unavailable due to circular
dependencies.

n/a (Refactor. No functional change expected.)

Merge internal change: 107509393
https://codereview.chromium.org/1463603002/

Convert QuicPathIdPacketNumber struct to std::pair. Not used in production, no behavior change.

Chromium doesn't have the same support for custom hash functions. Makes it hard to port cl/106938391.

Merge internal change: 107505890
https://codereview.chromium.org/1465583002/

Fix bug in ReliableQuicStream::WritevData() where if the write failed and the connection was closed, the stream would attempt to mark itself write blocked leading to a crash in debug mode.

Merge internal change: 107452913
https://codereview.chromium.org/1458003004/

Deprecate FLAGS_quic_count_unfinished_as_open_streams.

Merge internal change: 107422215
https://codereview.chromium.org/1457233003/

Convince ASAN we're really not touching the factory pointers at the same time by adding explicit locks

n/a (test only)

Merge internal change: 107412764
https://codereview.chromium.org/1459163002/

R=rch@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1470713003

Cr-Commit-Position: refs/heads/master@{#361380}

Revert of Call PaintLayer::setNeedsRepaint in LayoutBoxModelObject::invalidateDisplayItemClientOnBacking() (patchset #1 id:1 of https://codereview.chromium.org/1469823004/ )

Reason for revert:
This is incorrect. We missed setNeedsRepaint() of the PaintLayers between the object's enclosingLayer and paintInvalidationContainer's layer.

Original issue's description:
> Call PaintLayer::setNeedsRepaint in LayoutBoxModelObject::invalidateDisplayItemClientOnBacking()
>
> To ensure layer is set needsRepaint().
>
> BUG=536999
> TEST=scrollbars/scrollbar-added-during-drag.html etc with sync painting enabled
>
> Committed: https://crrev.com/4c9d4570c68eddbc58f73b1fb4f4c95614bcf9d3
> Cr-Commit-Position: refs/heads/master@{#361179}

TBR=chrishtr@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=536999

Review URL: https://codereview.chromium.org/1475483003

Cr-Commit-Position: refs/heads/master@{#361379}

|using| directives should not be global, but they should be used on a per-file bases.  Therefore they should not be placed in header files.

Review URL: https://codereview.chromium.org/1458163002

Cr-Commit-Position: refs/heads/master@{#361378}

Check for the isolate-extensions flag as well as --site-per-process.

BUG=532666

Review URL: https://codereview.chromium.org/1469153003

Cr-Commit-Position: refs/heads/master@{#361377}

Also using a no_sanitize list for SANITIZER_HOOK_ATTRIBUTE instead of
separate attributes per tool.

BUG=
R=glider@chromium.org

Review URL: https://codereview.chromium.org/1474733002

Cr-Commit-Position: refs/heads/master@{#361376}

https://pdfium.googlesource.com/pdfium.git/+log/8840ec9..3647692

R=thestig@chromium.org
BUG=555784,558840

Review URL: https://codereview.chromium.org/1466223003

Cr-Commit-Position: refs/heads/master@{#361375}

Re-enable conformance2/textures/misc/tex-storage-compressed-formats.html. This test is now passing.

Suppress const-array-init, tex-image-and-sub-image-3d*,
and floor-div-cos-should-not-truncate failures.

BUG=295792, 560555, angleproject:1179, angleproject:1198
TBR=zmo@chromium.org

Review URL: https://codereview.chromium.org/1471943002

Cr-Commit-Position: refs/heads/master@{#361374}

BUG=295792
NOTRY=true

Review URL: https://codereview.chromium.org/1465993003

Cr-Commit-Position: refs/heads/master@{#361373}

Review URL: https://codereview.chromium.org/1471743002

Cr-Commit-Position: refs/heads/master@{#361372}

As a step along the way to componentizing SecurityStateModel, this CL
introduces a SecurityStateModelClient interface and a
ChromeSecurityStateModelClient implementation. The client has just a
couple methods for now but will expand such that the client will
eventually provide everything from //content and //chrome that the model
needs.

BUG=515071

Review URL: https://codereview.chromium.org/1470813002

Cr-Commit-Position: refs/heads/master@{#361371}

https://chromium.googlesource.com/external/swarming.client.git/+log/05e17879accc..df99a00d96fa

$ git log 05e17879a..df99a00d9 --date=short --no-merges --format='%ad %ae %s'
2015-11-24 maruel Ignore .pyc in client/.

R=tandrii@chromium.org
BUG=chromium:555827

Review URL: https://codereview.chromium.org/1470113003

Cr-Commit-Position: refs/heads/master@{#361370}

That change added gfx_geometry as a dep in .gyp files, but forgot
to do the same for .gn files, which broke the Windows component
builders.  (The Linux component build seems to inline this function,
I guess.)

Due to crbug.com/497970, this breakage went undetected for pretty
long.

BUG=486089,552545
TBR=christhr

Review URL: https://codereview.chromium.org/1471263002 .

Cr-Commit-Position: refs/heads/master@{#361369}

Revert of webgl: use immutable texture for the default FBO. (patchset #2 id:20001 of https://codereview.chromium.org/1449043005/ )

Reason for revert:
following test is broken.
WebglConformance.deqp_functional_gles3_readpixel

Original issue's description:
> webgl: use immutable texture for the default FBO.
>
> Use immutable texture for the default FBO like chromium compositor.
>
> In theory, it speeds up drawing speed, because immutable texture skips texture
> validation on drawing call.
>
> In addition, immutable texture allows GL_INTEL_framebuffer_CMAA more optimization.
>
> BUG=557848
> TEST=
> WebglConformance.conformance_renderbuffers_framebuffer_state_restoration
> WebglConformance.conformance_textures_misc_texture_size_cube_maps
> WebglConformance.conformance_textures_misc_texture_sub_image_cube_maps
> WebglConformance.conformance_textures_webgl_canvas_tex_image_and_sub_image_2d_with_webgl_canvas_rgb_rgb_unsigned_byte
> WebglConformance.conformance_textures_webgl_canvas_tex_image_and_sub_image_2d_with_webgl_canvas_rgb_rgb_unsigned_short_5_6_5
> WebglConformance.conformance_textures_webgl_canvas_tex_image_and_sub_image_2d_with_webgl_canvas_rgba_rgba_unsigned_byte
> WebglConformance.conformance_textures_webgl_canvas_tex_image_and_sub_image_2d_with_webgl_canvas_rgba_rgba_unsigned_short_4_4_4_4
> WebglConformance.conformance_textures_webgl_canvas_tex_image_and_sub_image_2d_with_webgl_canvas_rgba_rgba_unsigned_short_5_5_5_1
>
> Committed: https://crrev.com/fb9d8e245ac84c6c0806e86e7884b4775a84b4b5
> Cr-Commit-Position: refs/heads/master@{#361335}

TBR=kbr@chromium.org,adrian.belgun@intel.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=557848

Review URL: https://codereview.chromium.org/1474763002

Cr-Commit-Position: refs/heads/master@{#361368}

NOTE: This is the second attempt of https://crrev.com/1140723003/

TODO:
1. Edit core/frame/UseCounter.h accordingly.
2. Add UMA metric in OfflineAudioContext.idl.

Adds suspend() and resume() feature in OfflineAudioContext to support the
synchronous graph manipulation with the render block precision (k-rate) in the
non-realtime audio rendering.

The benefit of being able to suspend/resume the context with the render block
precision is:

1) The audio graph can be modified in a time-accurate way, independent of the
   hardware. Without this, setTimeout, completion events, or state change events
   are needed to manipulate the graph, and the results depend on when the events
   are fired and on how fast the hardware is.

2) Makes an OfflineAudioContext more symmetrical to the AudioContext, which
   already supports suspend/resume. (There are minor difference required by the
   difference between offline and online contexts.)

This feature also can be used in Blink layout tests to verify the behavior of
audio rendering. With this feature in the implementation, several flaky web
audio layout tests can be fixed.

http://webaudio.github.io/web-audio-api/#the-offlineaudiocontext-interface

https://github.com/WebAudio/web-audio-api/issues/302#issuecomment-106101885

BUG=497933, 545686
TEST=
webaudio/offlineaudiocontext-suspend-resume-basic.html
webaudio/offlineaudiocontext-suspend-resume-eventhandler.html
webaudio/offlineaudiocontext-suspend-resume-graph-manipulation.html
webaudio/offlineaudiocontext-suspend-resume-promise.html
webaudio/offlineaudiocontext-suspend-resume-sequence.html

Review URL: https://codereview.chromium.org/1405413004

Cr-Commit-Position: refs/heads/master@{#361367}

Necessitated adding a "write_asset_list" arg for creating the
assets_list file.

BUG=547162

Review URL: https://codereview.chromium.org/1435333008

Cr-Commit-Position: refs/heads/master@{#361366}

This includes:
- AssociatedBinding
- AssociatedGroup
- AssociatedInterfacePtr
- AssociatedInterfacePtrInfo
- AssociatedInterfaceRequest

BUG=546067

Review URL: https://codereview.chromium.org/1465293002

Cr-Commit-Position: refs/heads/master@{#361365}

Review URL: https://codereview.chromium.org/1468173007

Cr-Commit-Position: refs/heads/master@{#361364}

Currently code dchecks on the existence of the offline page for a given
bookmark, which might not be the case.
Removing DCHECK and only continuing execution if the offline page exists.

BUG=560518
R=jianli@chromium.org

Review URL: https://codereview.chromium.org/1473043002

Cr-Commit-Position: refs/heads/master@{#361363}

Previously It2Me host was stopped asynchronoulsy, which makes the
shutdown more complicated. Now it's synchronous and is significantly
simpler.
Also removed ChromotingHost::RejectAuthenticatingClient() which is no
longer needed.

Review URL: https://codereview.chromium.org/1458323002

Cr-Commit-Position: refs/heads/master@{#361362}

BUG=559284

Review URL: https://codereview.chromium.org/1469943002

Cr-Commit-Position: refs/heads/master@{#361361}

Also fixes up the GCM error code logging (using the wrong enum that relied on
positive net error codes, while GCM was sending negative)

BUG=556773

Review URL: https://codereview.chromium.org/1471103002

Cr-Commit-Position: refs/heads/master@{#361360}

This is the case for ContentShell.apk

BUG=

Review URL: https://codereview.chromium.org/1469113004

Cr-Commit-Position: refs/heads/master@{#361359}

The pref data_reduction_proxy::prefs::kDataReductionProxy should have
been part of data_reduction_proxy::RegisterPrefs() to avoid having
all embedder register it manually just before call said function.

BUG=557814

Review URL: https://codereview.chromium.org/1463973003

Cr-Commit-Position: refs/heads/master@{#361358}

It's one very trivial function that only has a single call-site. It
doesn't need its own file.

BUG=

Review URL: https://codereview.chromium.org/1474533004

Cr-Commit-Position: refs/heads/master@{#361357}

That way, we don't have to mess with the hidden values in the dtor.

BUG=558975
R=haraken@chromium.org,sigbjornf@opera.com

Review URL: https://codereview.chromium.org/1472823002

Cr-Commit-Position: refs/heads/master@{#361356}

BUG=

Review URL: https://codereview.chromium.org/1468043003

Cr-Commit-Position: refs/heads/master@{#361355}

BUG=528489

Review URL: https://codereview.chromium.org/1468163003

Cr-Commit-Position: refs/heads/master@{#361354}

BUG=

Review URL: https://codereview.chromium.org/1473553002

Cr-Commit-Position: refs/heads/master@{#361353}

Also changed the API for the prefixed version to maintain compatibility between the two.

This is an interop issue, Firefox bubbles the event while Safari does not, but I think we should match Firefox.

See http://www.w3.org/TR/page-visibility/#sec-processing-model

BUG=501821

Review URL: https://codereview.chromium.org/1435893003

Cr-Commit-Position: refs/heads/master@{#361352}