GitLab

TBR=ian
Review URL: http://codereview.chromium.org/6354019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72339 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/6377007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72338 0039d316-1c4b-4281-b951-d872f2087c98

The function is now only used with the CHROME_OMNIBOX point and the value is cached and returned from the cache on subsequent calls. All other access points will be always freshly fetched and returned.

Future calls to this function with another access point should either be done on the FILE thread or implement caching the way it is done for Omnibox. Moreover if they implement the caching mechanism they should be prepared     for using this function in asynchronous manner if called on another thread.

BUG=62337
TEST=A search from branded browser through the omnibox-the rlz parameter should be appended to the query string.

Review URL: http://codereview.chromium.org/6028012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72337 0039d316-1c4b-4281-b951-d872f2087c98

TBR=thakis
TEST=presubmit check is clearer
BUG=none

Review URL: http://codereview.chromium.org/6314017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72336 0039d316-1c4b-4281-b951-d872f2087c98

TBR=evan
BUG=70606
TEST=none


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72335 0039d316-1c4b-4281-b951-d872f2087c98

BUG=61609
TEST=none
Review URL: http://codereview.chromium.org/6260017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72334 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None
TBR=phajdan@chromium.org,nkostylev@chromium.org

Review URL: http://codereview.chromium.org/6257013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72333 0039d316-1c4b-4281-b951-d872f2087c98

(I copied the code from djb and still screwed it up!)

BUG=none
TEST=DnsRRResolver works on OS X

Review URL: http://codereview.chromium.org/6353011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72332 0039d316-1c4b-4281-b951-d872f2087c98

BUG=60211, 70097, 70119, 70131, 62626, 61143, chromium-os:11102, chromium-os:11104, chromium-os:11105, chromium-os:11106, chromium-os:11109
TEST=bots

Review URL: http://codereview.chromium.org/6272012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72331 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=watchlists.py chrome/browser/prerender/prerender_resource_handler.cc

Review URL: http://codereview.chromium.org/6385001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72330 0039d316-1c4b-4281-b951-d872f2087c98

strings, delete devtools_strings.grd.

These strings are only used for Ubuntu Chromium translations,
not affecting Chrome release process.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/6273009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72329 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=run out/Debug/views_examples, everything should works as before.

Review URL: http://codereview.chromium.org/6366008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72328 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None
Review URL: http://codereview.chromium.org/6327015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72327 0039d316-1c4b-4281-b951-d872f2087c98

TBR=chron
BUG=70380
TEST=None

Review URL: http://codereview.chromium.org/6315010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72326 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72322 0039d316-1c4b-4281-b951-d872f2087c98

- GeolocationBrowserTest.ErrorOnPermissionDenied, crashes, bug 70585
- GeolocationBrowserTest.TabDestroyed, hangs, bug 70588

TBR=jknotten

BUG=70585, 70588
TEST=browser_tests
Review URL: http://codereview.chromium.org/6326009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72320 0039d316-1c4b-4281-b951-d872f2087c98

s/5NPAPI/6webkit5npapi/

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/6275013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72319 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:11103
TEST=none

Review URL: http://codereview.chromium.org/6377003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72318 0039d316-1c4b-4281-b951-d872f2087c98

This fixes a 'Conflicting declarations of PRODUCT_NAME within message' crash when policy_templates.xmb is generated.

TBR=joi

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/6366009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72317 0039d316-1c4b-4281-b951-d872f2087c98

BUG=65664
TEST=test_shell_tests + valgrind/heapcheck

Review URL: http://codereview.chromium.org/6246017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72316 0039d316-1c4b-4281-b951-d872f2087c98

BUG=62566
TEST=unit_tests and browser_tests, installed extensions from chrome.google.com/extensions
TBR=tessamac@chromium.org
Patch from Tessa MacDuff <tessamac@chromium.org>.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72315 0039d316-1c4b-4281-b951-d872f2087c98

BUG=53977
TEST=None.

Review URL: http://codereview.chromium.org/6297013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72311 0039d316-1c4b-4281-b951-d872f2087c98

BUG=70279
TEST=manual, see bug.

Review URL: http://codereview.chromium.org/6360013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72310 0039d316-1c4b-4281-b951-d872f2087c98

This is effectively a pared-down version of the already reviewed:
http://codereview.chromium.org/6308014/
BUG=none
TEST=none
(tested locally for Mac OS X which is the only platform this affects)

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72308 0039d316-1c4b-4281-b951-d872f2087c98

This is a more limited version of the patch already reviewed here:
http://codereview.chromium.org/6308014/
BUG=none
TEST=none
(tested locally on Mac OS X to verify build and that the feature could be enabled)
Review URL: http://codereview.chromium.org/6388002

TBR=crogers@google.com
Review URL: http://codereview.chromium.org/6271014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72307 0039d316-1c4b-4281-b951-d872f2087c98

This is a more limited version of the patch already reviewed here:
http://codereview.chromium.org/6308014/
BUG=none
TEST=none
(tested locally on Mac OS X to verify build and that the feature could be enabled)
Review URL: http://codereview.chromium.org/6388002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72306 0039d316-1c4b-4281-b951-d872f2087c98

This should help simplifying project maintenance.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/6241012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72305 0039d316-1c4b-4281-b951-d872f2087c98

This change shifts standard download processing to wait on history
insertion (note that actual data download does not wait).  This makes the
download process less racy and is expected to make the download tests less
flaky.

Note that it also brings the rename to the download intermediate file rename
inline into standard download processing; i.e. now we always rename to the
intermediate file name and then to the final file name.  This again reduces
raciness and possibly tset flakiness.

BUG=63237
TEST=All current download tests.

Review URL: http://codereview.chromium.org/6096003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72301 0039d316-1c4b-4281-b951-d872f2087c98

Also move the implementation from header to the source file.

BUG=None
TEST=run out/Debug/views_examples, everything should works as before.

Review URL: http://codereview.chromium.org/6264010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72300 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=Run webkit layout test fast/canvas/webgl/framebuffer_test.html in embedded environment. 

Review URL: http://codereview.chromium.org/6365006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72299 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72295 0039d316-1c4b-4281-b951-d872f2087c98

BUG=67219
TEST=unit-tested
Review URL: http://codereview.chromium.org/6213002

TBR=georgey@chromium.org
Review URL: http://codereview.chromium.org/6259016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72293 0039d316-1c4b-4281-b951-d872f2087c98

BUG=67219
TEST=unit-tested
Review URL: http://codereview.chromium.org/6213002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72292 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=compiles

Review URL: http://codereview.chromium.org/6342016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72291 0039d316-1c4b-4281-b951-d872f2087c98

BUG=70511
TEST=greener tree
TBR= mpcomplete@chromium.org

Review URL: http://codereview.chromium.org/6352014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72290 0039d316-1c4b-4281-b951-d872f2087c98

Since new tab pages cannot be overridden in incognito windows, a note should be specified in the documentation. Some users I have seen in IRC and Forums have this confusion.

The reason why you cannot override is from the following bug, where extension developers discussed the following issue:
http://crbug.com/39372

BUG=None
TEST=Open the page and the content will be shown

Review URL: http://codereview.chromium.org/6295008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72286 0039d316-1c4b-4281-b951-d872f2087c98

Perf test done.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/6342017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72285 0039d316-1c4b-4281-b951-d872f2087c98

Will revert after getting a run on the perf cyclers.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/6288011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72284 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6308014

TBR=crogers@google.com
Review URL: http://codereview.chromium.org/6322007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72283 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6308014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72282 0039d316-1c4b-4281-b951-d872f2087c98