- 15 May, 2019 40 commits
-
-
Gary Kacmarcik authored
This contains a workaround for the DPI==0 problem on some user's machines. Rather than assume that the dpi=96, this caches the DPI value from the OnVideoSizeChanged message and uses that as the default when the display DPI==0. Also, add additional display DPI logging for debugging. Change-Id: I6afb7c1ffbfe3a4ad1881a7702ff427cde460c9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612031 Auto-Submit: Gary Kacmarcik <garykac@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#659988}
-
rajendrant authored
1. Tune the backoff policy for client config fetch aggressively. 2. Allow fetching client config even when in background in Android. Both these changes are under a feature flag and enabled by default. The tests are changed to use the same backoff policy as the source code Bug: 963021 Change-Id: I56e6ce2b0f37fd8bf815764a9ccdbeea819e90eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612232 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#659987}
-
John Budorick authored
asan_device_setup needs both the 32-bit and 64-bit libs on aarch64 and can accept the lib directory in both the 32-bit and 64-bit cases. Bug: 790202 Change-Id: I355ef4162fa890d4189e5f860f442233fc732dd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612092 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#659986}
-
Harald Alvestrand authored
TBR=grunell@chromium.org Bug: chromium:943975 Change-Id: I19c03824b57cc0617c759acf2e3129c361861722 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613185Reviewed-by:
Harald Alvestrand <hta@chromium.org> Reviewed-by:
Henrik Grunell <grunell@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#659985}
-
Aaron Colwell authored
This reverts commit ecda211d. Reason for revert: This is causing a failure on the Android FYI bot and it also results in creating a large amount of default SiteInstances for the same BrowsingInstance. Original change's description: > Fix default SiteInstance memory leak. > > Removing reference cycle between BrowsingInstance and default > SiteInstance that was accidentally introduced in > http://crrev.com/c/1452714 > > Bug: 958683 > Change-Id: I73e2a3ec5c0ece04e341a9206009aaf48528edbf > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610991 > Commit-Queue: Aaron Colwell <acolwell@chromium.org> > Reviewed-by: Charlie Reis <creis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#659930} TBR=creis@chromium.org,acolwell@chromium.org Change-Id: Ic97740a1d65b72d55d3e7c8cea81fde950bfcad3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 958683 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613375Reviewed-by:
Aaron Colwell <acolwell@chromium.org> Commit-Queue: Aaron Colwell <acolwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#659984}
-
Caleb Rouleau authored
Since the benchmark is fairly short, I just manually added it onto a shard that was supposed to be shorter. We can reshard later to rebalance after this benchmark has run enough to generate official timing data. This is the first benchmark to explicitly only schedule on a couple platforms, instead of defaulting to run on everything. The plan is to move more benchmarks to this pattern in the future in order to reduce load on platforms that we don't have many devices for. (See full list here: https://docs.google.com/spreadsheets/d/1wm6DNM9Zyr8Q_Z0ffjrycRTD5_bRP0vGob6p6kbLVSA/edit ) TBR: jbudorick@chromium.org Bug: 961830, 961322 Change-Id: I9b80da77e1d945c82809487a02039c3370d43693 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611313 Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#659983}
-
Daniel Rubery authored
To limit regression in the total analysis time from Safe Browsing, cutoff ZIP analysis at 10 seconds. This CL also removes a little dead code from the ZIP analysis. Bug: 948277 Change-Id: I4ab6d2457398e0d5d63c40f1b801d35eaa52b87d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598844Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#659982}
-
Aran Gilman authored
The option to both invert and grascale images was removed because a user survey run by tsteiner@ revealed almost no one preferred it to the other options. You can set image grayscale by running Chrome with the flag --blink-settings="darkMode=X,darkModeImageGrayscale=Y" where 0.0 (original) < Y < 1.0 (fully desaturated). Bug: 954318 Change-Id: I667455cfc5dab4f7ef2276518b471daa9b0be622 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611914 Commit-Queue: Aran Gilman <gilmanmh@google.com> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#659981}
-
Robbie McElrath authored
This should reduce the number of shutdown hangs we're seeing with the network service enabled. According to UMA, ~99.9% of all shutdowns complete within 1s on ChromeOS. Bug: 963512 Change-Id: Iec10ca59349be9d6fbbe2d1294f4aaf585711d3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613121Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#659980}
-
Xiyuan Xia authored
Bug: 962884 Change-Id: Ia6ce88211926c4ccb6726f3aab9e8677e196d6f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612851Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Xiaochu Liu <xiaochu@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#659979}
-
Scott Violet authored
If a block's size is not equal to the intrinsic size, then margins should not collapse. Bug: 769039 Change-Id: I13b343cf2421d8d49953a8f780d32772fd5eceef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610303Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#659978}
-
Ahmed Fakhry authored
- Windows with backdrops should show their backdrops properly in the desk's mini_views. - Fix a transform error. - Optimize refreshing the mini_views contents, and do it only when needed. BUG=866622 TEST=ash_unittests Change-Id: Iddbc5282f508a7256c795ed24847ff65d003683d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611240Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#659977}
-
Fan Yang authored
https://quiche.googlesource.com/quiche.git/+log/8eb45e950572..63d0bc4ae8dc $ git log 8eb45e950..63d0bc4ae --date=short --no-merges --format='%ad %ae %s' 2019-05-14 wub gfe-relnote: (n/a) Delete two unused member variables from QuicCryptoServerStream. Not protected. 2019-05-14 fayang gfe-relnote: In QUIC, change string to std::string for detailed_error. 2019-05-14 fayang gfe-relnote: Allow GFE to perform initial cwnd up and down experiment. Protected by --gfe2_reloadable_flag_quic_gfe_selected_initial_cwnd_experiments. 2019-05-13 zhongyi Rename ToDebugValue to ToDebuggingValue() for QuicBandwidth and QuicTime::Delta. This change will make all the logging methods have a consistent name. 2019-05-13 renjietang Skip static streams when destructing QuicSpdySession. 2019-05-13 renjietang Refactor QuicSession to allow subclasses to do their own thing on pending streams. 2019-05-13 quiche-dev QRTP: Implement Datagram Transport 2019-05-13 nharper Don't use a flow controller for QuicCryptoStream when it uses CRYPTO frames 2019-05-13 nharper gfe-relnote: Allow sending CRYPTO frames without full padding. Protected by QUIC_VERSION_99 2019-05-13 nharper gfe-relnote: Delete some dead Token Binding code in QUIC. Not flag protected 2019-05-13 wub gfe-relnote: (n/a) Remove the stateless reject variants from quic/core/http:end_to_end_test. 2019-05-13 dschinazi Deprecate gfe2_reloadable_flag_quic_use_new_append_connection_id 2019-05-13 fayang gfe-relnote: In QUIC, do not use framer object in QuicDispatcher. Protected by gfe2_restart_flag_quic_no_framer_object_in_dispatcher. 2019-05-13 wub gfe-relnote: (n/a) Delete some functions from QuicCryptoServerStream and tests that uses those function. Not protected. 2019-05-13 ianswett Add more logging to the QUIC_BUG when no decrypter is available. 2019-05-13 fayang gfe-relnote: In QUIC, use 2 burst tokens in bootstrapping experiment, protected by gfe2_reloadable_flag_quic_conservative_bursts. 2019-05-11 quiche-dev wdith -> width typo fix on java, cc, proto 2019-05-10 rch gfe-relnote: Deprecate --gfe2_reloadable_flag_quic_enable_version_43 2019-05-10 quiche-dev gfe-relnote: Construct QuicMemSliceSpans from a QuicMemSlices without copies. 2019-05-10 wub gfe-relnote: (n/a) Add QuicBandwidth::IsInfinite(). Not used yet. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: Ia95ec0a0fe8da95c175bec8880f8a0e1aefdfee4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611908 Commit-Queue: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#659976}
-
Maks Orlovich authored
This was supposed to be "a year from now", not "now" Bug: 962675, 962676 Change-Id: I8e135bec2bb6192c7dc3ae36e8362c87fa9ab892 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610431Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#659975}
-
Michael Crouse authored
Checks for DataSaver enabled users before allowing HintsFetching to occur. PreviewsOptimizationGuide is provided a PrefService and access to the DataReductionProxy to determine if DataSaver is enabled. Bug: 932707 Change-Id: I13fbbe7ca2669ce6b0b97a7199a40bf179c281cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604211 Commit-Queue: Michael Crouse <mcrouse@chromium.org> Auto-Submit: Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#659974}
-
Yuly Novikov authored
Crash should be fixed by https://chromium-review.googlesource.com/c/angle/angle/+/1586355 Suppress failures that regresses while the suite was disabled: conformance/extensions/webgl-compressed-texture-s3tc-srgb.html conformance/glsl/samplers/glsl-function-texture2dprojlod.html conformance/rendering/out-of-bounds-array-buffers.html TBR=kbr Bug: 935060, 963205, 963217, 963223 Change-Id: I85c8d12f1f7d41864929e8f56dfd6cd1ac8b75be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610847Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#659973}
-
Richard Knoll authored
This is an optimization to only try to close a notification after deleting its data, if we believe that it is still on screen. If the notification got closed by the user for example, we do not need to explicitly close it again as it is already gone. Bug: 962885 Change-Id: Id949ff4a15623070d6781e404d873361c433cf55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609852 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#659972}
-
Mounir Lamouri authored
Bug: 958364 Change-Id: Ifc87e6222df9de526f2900f13899af616604750e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1591878Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#659971}
-
Oystein Eftevaag authored
This reverts commit ff99845c. Reason for revert: Relanding with fix for use-after-free crashes. Original change's description: > Revert "Reland "Background tracing: Use the new Perfetto Consumer mojo endpoint"" > > This reverts commit 996da9c1. > > Reason for revert: Revering due to https://crbug.com/962478 > > Original change's description: > > Reland "Background tracing: Use the new Perfetto Consumer mojo endpoint" > > > > This reverts commit 5116072f. > > > > Reason for revert: Relanding with fix for fully waiting for trace shutdown. > > > > Original change's description: > > > Revert "Background tracing: Use the new Perfetto Consumer mojo endpoint" > > > > > > This reverts commit 67f4c2f3. > > > > > > Reason for revert: Revert while investigating new TSan warnings > > > > > > Original change's description: > > > > Background tracing: Use the new Perfetto Consumer mojo endpoint > > > > rather than the TracingController. > > > > > > > > This is in preparation for being able to handle proto traces > > > > in addition to JSON. > > > > > > > > R=ssid@chromium.org > > > > BUG=925151 > > > > > > > > Change-Id: I91ed3c9648587fb19a5102b869a5d5ab688e0187 > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546146 > > > > Commit-Queue: oysteine <oysteine@chromium.org> > > > > Reviewed-by: Avi Drissman <avi@chromium.org> > > > > Reviewed-by: ssid <ssid@chromium.org> > > > > Cr-Commit-Position: refs/heads/master@{#657413} > > > > > > TBR=avi@chromium.org,oysteine@chromium.org,ssid@chromium.org > > > > > > Change-Id: I92db1fa46353cfb960071f44d110a5faa0c25421 > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Bug: 925151 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600305 > > > Reviewed-by: oysteine <oysteine@chromium.org> > > > Commit-Queue: oysteine <oysteine@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#657520} > > > > TBR=avi@chromium.org,oysteine@chromium.org,ssid@chromium.org > > > > Change-Id: Ic3cc44a563a98871de8003221cb015fbc3b890d0 > > Bug: 925151 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601555 > > Reviewed-by: oysteine <oysteine@chromium.org> > > Reviewed-by: ssid <ssid@chromium.org> > > Reviewed-by: Avi Drissman <avi@chromium.org> > > Commit-Queue: oysteine <oysteine@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#657925} > > TBR=avi@chromium.org,oysteine@chromium.org,ssid@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 925151 > Change-Id: Id214d9547e18cb35b5ecf987f611b204944e51a7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610301 > Reviewed-by: oysteine <oysteine@chromium.org> > Commit-Queue: oysteine <oysteine@chromium.org> > Cr-Commit-Position: refs/heads/master@{#659204} TBR=avi@chromium.org,oysteine@chromium.org,ssid@chromium.org Change-Id: Ic0495ca0a4a245a326225b0c68bc69a84b30ff06 Bug: 925151 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610312Reviewed-by:
ssid <ssid@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#659970}
-
Clemens Arbesser authored
This change aims to at least partially move PR to use the MVC pattern. There are still some properties which should be in native, but are not (in particular, the chosen payment/contact info/address and the set of available profiles & credit cards). I plan to address them in a follow-up CL. This change is a refactorization - there should be no user-facing changes. Bug: 806868 Change-Id: Iab88f7f35ba746194344ab11e367401f1daea61a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604045 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#659969}
-
Jan Krcal authored
This CL makes sure that user events recorded in sync-paused state are dropped and not uploaded once the user signs back in. Bug: 963429 Change-Id: I2eb5c0074d89c4fae17139d30270722d9b5cb30c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611688 Auto-Submit: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#659968}
-
Charlie Harrison authored
What: Unify logic for deciding what higher level protocol the top frame resource loaded with. Why: DRY, and also ensure a unified place to update QUIC versions, without needing a page_load_metrics reviewer. This change is purely a refactoring and shouldn't change any behavior. Bug: None Change-Id: I4dd8989d95c38128a0cb3c05d23569d0016344ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610086Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#659967}
-
Sébastien Séguin-Gagnon authored
Adds a new "Send to your devices" activity in the iOS Activity Sheet. Sends the current tab to the other user's devices when it's used. Bug: 944596 Change-Id: Idef4bdedb8955dc89bcea6d4baae0152e257a756 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1596356Reviewed-by:
Peter Lee <pkl@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#659966}
-
Sadrul Habib Chowdhury authored
In some cases, the swap-ack happens *after* the frame has already been presented. In such cases, the 'wait-for-ack' step for the DrawAndSwap async trace-event ends later than the 'wait-for-present' step. This confuses the trace-viewer, resulting in some never-ending DrawAndSwap trace-events. This can also be confusing in general. So remove the intermediate 'wait-for-ack' step, since all frames now get a presentation-timestamp. BUG=944101 Change-Id: Ifd29adc0d54a662a314f7e624d17cc6f30d10de1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612379Reviewed-by:
Saman Sami <samans@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#659965}
-
Dan Erat authored
This reverts commit 58d0fc5b. Reason for revert: Breaks SyncChrome stage on Chrome OS builders. See https://crbug.com/963259. Original change's description: > Enable openscreen compilation in Chromium > > This change enables third_party/openscreen to be built as part of gn_all > so we can get coverage on linux bots which will help to ensure we aren't > breaking our Chromium compatibility while we are still pre-integration. > This doesn't cause anything to be linked into any shipping binaries. > > Bug: 951615 > Change-Id: I65a67054d9545865a51c5dc3cf8d1bb206fc8391 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562751 > Reviewed-by: Mirko Bonadei <mbonadei@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Commit-Queue: Brandon Tolsch <btolsch@chromium.org> > Cr-Commit-Position: refs/heads/master@{#659696} TBR=thakis@chromium.org,dpranke@chromium.org,mbonadei@chromium.org,btolsch@chromium.org Change-Id: Id26267e90640af73018933c2bc1d708f398ed36a No-Presubmit: true Bug: 951615, 963259 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612370Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Commit-Queue: Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#659964}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/4d4a190ba1f5..10186cb85fd6 git log 4d4a190ba1f5..10186cb85fd6 --date=short --no-merges --format='%ad %ae %s' 2019-05-15 chrisforbes@google.com Override imageview swizzles for channel replacement edge cases Created with: gclient setdep -r src/third_party/swiftshader@10186cb85fd6 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/119620767 TBR=swiftshader-team+autoroll@google.com Change-Id: Ibadfce499e7bbb1b07825537de23af8783cf53a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613236Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#659963}
-
Javier Ernesto Flores Robles authored
Updates the constraints related to dynamic type when the content size category changes. Sets all labels and text fields to automatically adjust fot the content size category. Bug: 959764, 951300 Change-Id: Ib072e40ef1821e20941740e07f194e5a17ccecdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611604 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Auto-Submit: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#659962}
-
Kush Sinha authored
After Chrome OS Account Manager becomes the source of truth for Google Accounts in Chrome OS, we need to route all Google Account management Intents from Android to Chrome OS Account Manager. Add IPC methods in auth.mojom to handle these requests. Bug: 871690 Change-Id: I6b0a0279f8a78412c24e21186f34e04a41c346a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1588640Reviewed-by:
Mattias Nissler <mnissler@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
David Jacobo <djacobo@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#659961}
-
Daniel Cheng authored
Looks like this was used for mus at one point, but is no longer needed: https://chromium-review.googlesource.com/c/chromium/src/+/673066/ Change-Id: I7a48df40b4b424fdd2dc823176be01204885ada7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612844 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#659960}
-
Andrew Grieve authored
It conflicts with TrichromeWebview's BuildConfig class. Fixes locale pak issues when running with is_java_debug=false Change-Id: I75a53119b1148c1c264554bbe5df49f912cb342f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613361 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#659959}
-
Robert Sesek authored
This adds a new buildflag controlled by the GN arg new_mac_bundle_structure. When this flag is set to true, the layout of the inner app bundle will change. Today, the Framework that contains all the code and resources for the product lives at the following path (or its branded equivalent): Chromium.app/Contents/Versions/VV.0.VVVV.V/Chromium Framework.framework/Versions/A With the flag set to true, the framework will move to: Chromium.app/Contents/Frameworks/Chromium Framework.framework/Versions/VV.0.VVVV.V This change will let Google Chrome be notarized. Under the existing bundle structure (i.e. when the flag is set to false), the Versions directory requires the use of the obsolete --resource-rules code signing flag so that the Keystone updater can stage new versions in the Versions directory, without invalidating the signature of the app. But --resource-rules are incompatible with notarization. To work around this, the change leverages the use of "nested code" in frameworks. Because a framework bundle can contain multiple versions, each version is signed in its entirety, but the outer framework containing those versions is not signed directly. When the framework (and its version) are embedded within an .app bundle, the signature of the framework is recorded along with the signing "Team ID". The code signing system allows a new version of the framework to be staged inside the framework's Versions directory so long as it is signed by the same "Team ID". Bug: 958976 Change-Id: Iacf78fa7d96e3a95a20d6248771e5da7e04bd81c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592230Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#659958}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/226668a14690..1f09898e9a8a git log 226668a14690..1f09898e9a8a --date=short --no-merges --format='%ad %ae %s' 2019-05-15 robertphillips@google.com Add GrVkFormatIsCompressed and GrVkFormatCompressedDataSize to rm uses of GrPixelConfig 2019-05-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skia/third_party/skcms 853f66269c16..1578d6b6f5dd (1 commits) 2019-05-15 brianosman@google.com Interpreter: Remove vectorized branches 2019-05-15 bungeman@google.com Move SkTSearch.h into src. 2019-05-15 robertphillips@google.com GrVkCaps: add isFormatRenderable and rename some isConfig* methods to isFormat* 2019-05-15 bungeman@google.com Remove tools/clang from .gitignore Created with: gclient setdep -r src/third_party/skia@1f09898e9a8a The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=michaelludwig@google.com Change-Id: I815194fb653a8ea54f4ebaf6dd00243942a89868 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613318Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#659957}
-
Raphael Kubo da Costa authored
IWYU after commit 153dd1a6 ("sqlite: Rewrite custom recovery code"), which also fixes the libstdc++ build: ../../sql/recover_module/integers.h:67:6: error: no template named 'pair' in namespace 'std' std::pair<int64_t, const uint8_t*> ParseVarint(const uint8_t* buffer, ~~~~~^ Bug: 957519 Change-Id: Iee9ae4cfb1c3531b6fcd2080f5b9a3bcfc25f5cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611690 Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#659956}
-
Igor authored
If the policy dictates to lock the device to single user, the failure to do so generates the user to be logged out. Here we add UMA stats to have metrics on how often this happens. BUG=b:77799573 TEST=None Change-Id: I5eea6616628c2130f25c746b3ce9cabd63d139a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1595868 Commit-Queue: Igor <igorcov@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Igor <igorcov@chromium.org> Cr-Commit-Position: refs/heads/master@{#659955}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/69250bb90295..023ca2db25ad git log 69250bb90295..023ca2db25ad --date=short --no-merges --format='%ad %ae %s' 2019-05-15 akahuang@google.com chromeos_config: Mark some CQs experimental. Created with: gclient setdep -r src/third_party/chromite@023ca2db25ad The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: I49a9068647647d434947d3d589eee151c8551491 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613377Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#659954}
-
Michael Lippautz authored
All uses must go through MakeGarbageCollected. Bug: 945806 Change-Id: I825ac265bb6a18cbaf0b5393e70bec671cf15ab1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613298 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#659953}
-
Sebastien Lalancette authored
The feature has been successfully rolled-out to 100% Stable. Now cleaning up flag in the client and the dead code. Bug: 920214 Change-Id: I55675ecc742ca36c17718bcc56e5107f9291f702 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610217Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Cr-Commit-Position: refs/heads/master@{#659952}
-
Shimi Zhang authored
To make it a little easier to read ShowContextMenu(), should have no logic change. Test: Current tests should pass. Bug: None Change-Id: I807f770f331673d5d003be63d2b606b0c60b004f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612216 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#659951}
-
Allen Bauer authored
Views cleanup: Changed to use GetVisible() and GetEnabled() instead of visible() and enabled(), respectively. NOTE: View::visible() and View::enabled() are still present for now. They'll be removed in a subsequent CL due to the sheer size of this CL. TBR=sky@chromium.org TBR=tapted@chromium.org TBR=pkasting@chromium.org TBR=oshima@chromium.org TBR=estade@chromium.org TBR=yhanada@chromium.org Change-Id: I8908242f1a8f1f4767c05c6f5ef8d8009c4ec585 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610082Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Commit-Queue: Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#659950}
-
Yue Zhang authored
This CL enables dragging to reorganize tabs in TabGridDialog and TabGridSheet. It is now behind the flag TabGroupsAndroidUiImprovements. Bug: 961433 Change-Id: Ib12025fdd1635962cb785399b7f7558d11ce6e58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611305 Commit-Queue: Yue Zhang <yuezhanggg@google.com> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#659949}
-