- 28 May, 2020 40 commits
-
-
Fergal Daly authored
R=cmp@chromium.org Change-Id: I41c75606cbf211cf472963174845aef65a756aad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2192992Reviewed-by:
Chase Phillips <cmp@chromium.org> Commit-Queue: Chase Phillips <cmp@chromium.org> Cr-Commit-Position: refs/heads/master@{#772721}
-
danakj authored
When dumping the navigation history, dump windows opened by the main test window also. R=avi@chromium.org Bug: 771003, 1069111 Change-Id: I6fad87666ee9542c51648dc7bf6cba493a105bab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218482Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#772720}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/70728ef8e71e..bbc6f0a82d92 2020-05-28 bungeman@google.com Initialize ICU before use in SkParagraph. 2020-05-28 bungeman@google.com Move SkParagraph bits into skparagraph directory. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC westont@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: westont@google.com Change-Id: Ifd4394847b638b990060d5ce4777632efe60472f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220167Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#772719}
-
danakj authored
The test is passing with the changes made to the test harness. R=avi@chromium.org Bug: 801992, 801338, 1069111 Change-Id: If56cf2756e5ce272eb8619ca438f6fb04ee82be7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218478Reviewed-by:
-
Leonard Grey authored
This reverts commit 43233e9d. Reason for revert: [Sheriff] Compile failure https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8879044512710669184/+/steps/compile/0/stdout Original change's description: > Android: Remove enable_turbine flag > > Now that r8 has been updated to remove unnecessary bridge methods and > turbine is turned back on for all targets, and robolectric has been > moved into android_deps, we no longer need this enable_turbine flag. Now > we can assume that all non-prebuilt java targets have a turbine header. > > Bug: 1056299 > Change-Id: Id3a1d77e572fcd5d231c61deb28b444603dc1a47 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219670 > Commit-Queue: Peter Wen <wnwen@chromium.org> > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Auto-Submit: Peter Wen <wnwen@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#772695} TBR=wnwen@chromium.org,agrieve@chromium.org Change-Id: I3a59f2ebe466bea657d7c18f039ed83f72ad1071 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1056299 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219515Reviewed-by:
Leonard Grey <lgrey@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#772717}
-
Dominique Fauteux-Chapleau authored
Bug: 1076083 Change-Id: I121c6a8c86efbd205e2886372691d295f0a13e90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214918Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#772716}
-
Dominique Fauteux-Chapleau authored
Bug: 1076083 Change-Id: Ia53108bb26aab9232c93e19514e0c63ddb1518d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216291Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4fb71e30e397..1a30c50dcab0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC lgrey@google.com,jdoerrie@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1085579 Tbr: lgrey@google.com,jdoerrie@google.com Change-Id: I7e1615050c22a738784e72ffd5c7e5a2905e3d3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219785Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#772714}
-
Akihiro Ota authored
(repros 0/10 times). was available for system language (at startup). Bug: 1086640 Test: Manually verify by running ChromeVox startup 10 times Change-Id: I8c735a58e6c943916792430bb96e6b2ccf3eeb88 AX-Relnotes: Fix voice switching issue where ChromeVox said no voice Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216379 Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#772713}
-
Sahel Sharify authored
Without this fix the following warning appears while reading the supported delegation meta data: W Bundle : Key org.chromium.payment_supported_delegations expected String[] but value was a java.lang.Integer. The default value <null> was returned. The fix is tested with a demo native payment app. Bug: 1026667 Change-Id: Ifcc372bfb035766b4ea874bba59692cb9999c5d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218752 Commit-Queue: Sahel Sharify <sahel@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#772712}
-
Leszek Swirski authored
Change-Id: Ib31acd25b1929d45137deec969a42e654f4c9755 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220087 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#772711}
-
Khushal Sagar authored
R=ellyjones@chromium.org Bug: 1056730 Change-Id: I7b23d7d9cc74a4f50be5a493009ac331377dc5b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218717 Auto-Submit: Khushal <khushalsagar@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#772710}
-
Roman Sorokin authored
This CL hardcodes signin profile test extension id for autotestPrivate api and for signin screen. The extension could be loaded on the test image only. Related CLs: CL:2172687 - tast test using the new test extension CL:*2942076 - key for the new test extension Bug: 941107 Change-Id: Ic057d2e0c8898fbb2a8e96054024b79651f132a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521272Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#772709}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/cb29d3aed1ca..f55afd74b600 2020-05-28 almuthanna@google.com Convert Layout test for long trace trimming 2020-05-28 alexrudenko@chromium.org Rename inspector overlay build target If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1078267 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I28c692c6656f9a5732735ab21471353c59b6de07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220166Reviewed-by:
-
Jan Wilken Dörrie authored
TBR=johnidel Bug: 1087406 Change-Id: I86e0a81bb5a304f387e68233d33976f0460f702b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220006Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
John Delaney <johnidel@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#772707}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 8f57d6dd. With Chromium commits locally applied on WPT: 4ad6e935 "Move mouseevent_key_pressed.html to wpt" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: mkwst@chromium.org, andypaicu@chromium.org: external/wpt/content-security-policy rego@igalia.com: external/wpt/css/css-grid NOAUTOREVERT=true TBR=smcgruer No-Export: true Change-Id: Ib68b1198c774d6af78706403fae21ded8ae8472b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219869Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#772706}
-
Antonio Gomes authored
... instead of WebMediaStreamTrack. This is part of the effort to reduce the needless use of public Blink APIs (wrappers) within renderer/modules. BUG=704136 R=guidou@chromium.org Change-Id: If1dfc2bb9fc3c754ce43e9e8e0beff3c95426709 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218451Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#772705}
-
Johannes Kron authored
Will be used to trace detailed events such as the sending of RTP packets. See https://webrtc-review.googlesource.com/c/src/+/176231 Bug: webrtc:11617 Change-Id: I3c0d17190805cf39e72e5615af7c4cc3482d8602 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219497 Commit-Queue: Johannes Kron <kron@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#772704}
-
Ben Kelly authored
Bug: 1059802 Change-Id: I75965b55127c5ae9319b309d5adad62f6923a943 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219074Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#772703}
-
David Van Cleve authored
To be in line with other new security-relevant Web Platform features, we only allow callers to execute Trust Tokens operations in secure contexts. Usually, WebIDL restricts functionality to secure contexts with the [SecureContext] extended attribute. This is how we initially implemented the restrictions on the three Trust Tokens interfaces (fetch, XHR, and iframe). However, this doesn't work for the fetch interface, because the [SecureContext] extended attribute doesn't work on dictionary members (like the `trustToken` member in request_init.idl); instead, it silently no-ops! This change: 1. removes the useless SecureContext attribute from RequestInit; 2. adds an explicit check that a Fetch request bearing Trust Tokens parameters is coming from a secure context, throwing a TypeError if not; and 3. for good measure, adds tests ensuring the XHR and iframe interfaces are only available in secure contexts, too. R=csharrison, yhirano Fixed: 1087200 Change-Id: If19f89251d9ab0ea16e8bb80216b5ef8d2f91b68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217855Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#772702}
-
Julie Jeongeun Kim authored
This CL moves printing::PrintHostMsg_DidPrintContent_Params to print.mojom to pass it to Mojo interfaces. This is a precursor CL to mojofy the preview UI messages. Bug: 1008939 Change-Id: I35449ebcf5ed89c9d1282997b6b10b2e674c78cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212110Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#772701}
-
gogerald authored
This CL also modifies the single tab switcher to explicitly selecting the current tab when clicking back button. Bug: 1085242 Change-Id: Ia2032d7e0f8a214d40f6554a5f2117be51b46c59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212483 Commit-Queue: Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Auto-Submit: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#772700}
-
Mike Klein authored
This moves where dither happens in CPU rendering to more closely match where it happens in GPU rendering. Bug: skia:10000 Change-Id: I184fd73599129596f3896ce716366f65fce60348 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219071 Commit-Queue: Mike Reed <reed@google.com> Auto-Submit: Mike Klein <mtklein@google.com> Reviewed-by:
Mike Reed <reed@google.com> Cr-Commit-Position: refs/heads/master@{#772699}
-
Olesia Marukhno authored
Add restarting the timer on user interaction. Bug: 1019129 Change-Id: I9c2fd0320761747cefbf5b0407ed6989ca804699 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214948 Commit-Queue: Olesia Marukhno <olesiamarukhno@google.com> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#772698}
-
Ehimare Okoyomon authored
Create PageInfoSubpageController and PageInfoSubpage for control of a specific section of the page info v2. Componentized the cookies section as an example. https://screenshot.googleplex.com/XnhMwuBkVzG.png Bug: 1077766 Change-Id: I7bf71c62859bcae7b2f24bd9509947c003a51c06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209070 Commit-Queue: Ehimare Okoyomon <eokoyomon@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#772697}
-
Annie Sullivan authored
Original CL: https://chromium-review.googlesource.com/c/chromium/src/+/2218908 The CL was reverted due to failures: https://chromium-swarm.appspot.com/task?id=4c70451b557f4a10 https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8879124242719394576/+/steps/browser_tests/0/logs/Deterministic_failure:_LayoutInstabilityTest.OOPIFSubframeWeighting__status_CRASH_/0 ../../chrome/browser/page_load_metrics/integration_tests/layout_instability_browsertest.cc:152: Failure Value of: cls_values[i].has_value() Actual: false Expected: true This looks like one of the scores in the loop isn't getting set correctly. I'm not sure which, so this CL also fixes the check of scores and is more explicit about which score is being checked. Bug: 943668 Change-Id: Icd0203fa8b6521b83605ab1c1210376c2f7a8356 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219112Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Annie Sullivan <sullivan@chromium.org> Cr-Commit-Position: refs/heads/master@{#772696}
-
Peter Wen authored
Now that r8 has been updated to remove unnecessary bridge methods and turbine is turned back on for all targets, and robolectric has been moved into android_deps, we no longer need this enable_turbine flag. Now we can assume that all non-prebuilt java targets have a turbine header. Bug: 1056299 Change-Id: Id3a1d77e572fcd5d231c61deb28b444603dc1a47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219670 Commit-Queue: Peter Wen <wnwen@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#772695}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/4d9848cbcdb3..616e38c720de 2020-05-28 fancl@chromium.org auto-bisect: Fix commit range from end:start to start:end If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1087355 Tbr: rmhasan@google.com Change-Id: I96cf44eb8d33085a9eef9a600c77ce4176aa81b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219917Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/a5b927e19e44..fdd70eae3267 2020-05-28 lalitm@google.com ui: plumb tp metatracing into the UI If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I0658ee38cdf7d6bdd48e7b33cccf2dcee961de68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218742Reviewed-by:
-
David Jin authored
If the 'Cookies' file has not been migrated, then we try to migrate the 'Cookies' and 'Cookies-journal file to new location. However, the 'Cookies-journal' is being moved to same location as 'Cookies' and thus overwriting it and losing the cookies data. This issue arises when updating from WebView which doesn't have the 'incomplete' migration logic to a WebView version with the fixed migration logic. Bug: 1080828 Change-Id: I520de8e65c3a7c5290ccfdeff8cd69acffa80fe1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2190278Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#772692}
-
Alice Wang authored
This CL adds robolectric tests for the class AccountPickerMediator. Bug: 1081218 Change-Id: Ib2e984491978e6c701486a426ec3c9b13f7eab77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214956 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#772691}
-
Jan Wilken Dörrie authored
TBR=lukasza Bug: 1087392 Change-Id: Iab95de864a2c06f5311dda371a07d21d5770468d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218117Reviewed-by:
-
ckitagawa authored
This is a reland of crrev.com/c/2032024, but is built on a refactoring of the browser side storage of embedding tokens. So it is not a clean reland. Patchset 1 is as close to the original CL as possible. This change was originally reverted due to an interaction with bfcache where embedding tokens were not cached on the bfcache navigation. The specific scenario that needs to be addressed is Document A -> Document A -> Document B -> Document A Has Token -> No Token -> No Token nav cached -> Use cached nav The cached navigation failed validation as an embedding token was expected. The fix for this is to ignore embedding tokens on the cached navigations. Original Description: This change add embedding tokens to the main frame. This has the same behavior as embedding tokens for remote frames except it doesn't propagate the token to a parent. Behaviors - Add a token on first navigation. - Swap the token on any cross-process navigation. Bug: 1072422 Change-Id: Ic658e3cce3b311b97b3021fe2f006f2c893c10b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133884 Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#772689}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/5aefbb372568..70728ef8e71e 2020-05-28 ethannicholas@google.com Revert "Reland "Revert "SkSL function inlining""" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC westont@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: westont@google.com Change-Id: I3a6366975cba569cef60985a1fb263574543e0ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219918Reviewed-by:
-
Friedrich Horschig authored
Similar to the dropdown, this CL adds a G icon to account-stored passwords in the Manage Passwords Bubble. Since the store might be relevant for a11y users when they intend to delete a password, an accessibility text informs screen-reader users. Flag-guarding the icon row is not necessary since it is only shown if at least one password is account-stored. Without the flag enabled, no password can be account-stored. Note: the only test for this surface is currently disabled on bots due to flakiness. The test passes locally but debugging the flakiness exceeds the scope of this CL. Screenshot in the linked bug is identical to IDS_MANAGE_PASSWORDS_ACCOUNT_STORE_ICON_DESCRIPTION: https://storage.cloud.google.com/chromium-translation-screenshots/fa9d35ac7a358c49def0764514a910c300ccf368 Bug: 1086888 Change-Id: Ica42938001219391d49dd339f3f414f45b109d38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218071 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#772687}
-
Denis Kuznetsov authored
Bug: 1084940, 1078294 Change-Id: I475453adce7fc98d96279434754cb3f09dac50e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218036 Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
-
Ben Kelly authored
Bug: 913107 Change-Id: I577f200311baff44c2986fcfa47a9e61c6ddb187 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219069Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Commit-Queue: Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#772685}
-
Wez authored
Runner script targets included "${target}.archive_manifest" in their |data|, since it was a required input to the package "bundling" step. Now that the fuchsia SDK provided GN rules are used, this file is no longer a build nor runtime dependency of the runner scripts. Recent SDK builds have re-named it, causing the errant dependency to block SDK rolls. TBR=kmarshall Bug: 1087301 Change-Id: If99ed213c9bea95d042402d6b1326029d1dca169 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218116Reviewed-by:Wez <wez@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/696a03e075a6..cb29d3aed1ca 2020-05-28 janscheffler@chromium.org Keep frames blocked by the heavy ads intervention 2020-05-28 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I54c682f01dc7094bd922898aa14fa645f849b112 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219915Reviewed-by:
-
Olivier Robin authored
Adapt the openURL logic for UIWindowSceneDelegate. The new API allows to open multiple URLs in the same launch, but it is not clear to me how to trigger that, so I could not test it. Bug: 1069748 Change-Id: I97f61c7cb1af73d79e3b5f9f958049a6a9d7d178 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215051 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#772682}
-
