- 21 Jun, 2018 40 commits
-
-
Xianzhu Wang authored
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ia34504e87196cb61433ef74d5aa93f357da585ca Reviewed-on: https://chromium-review.googlesource.com/1110496Reviewed-by:
Tien-Ren Chen <trchen@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#569456}
-
wutao authored
This cl is a prerequisite to allow assistant manager service to query and observe settings status changes. Changes: 1. Change VoiceInteractionObserver to mojo. 2. Add two query methods to VoiceInteractionController. Bug: b/110094434, b/80431063 Test: manual. Change-Id: Ie42083b53ce2794df82cfc4f3978bafc9ae87167 Reviewed-on: https://chromium-review.googlesource.com/1106606 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#569455}
-
Wenzhao Zang authored
The |tap_button_| in |LoginUserView| is responsible for handling tap events on the user view. Moving focus to the tap button when showing the messages is reasonable because 1) Tapping the user view will open the Gaia dialog, 2) It avoids the unnecessary blue ring focus. Bug: 845251 Change-Id: I522f41523750c0e1f95b7aedbdec862b3261317e Reviewed-on: https://chromium-review.googlesource.com/1111079Reviewed-by:
-
Darren Shen authored
There was an extraneous line that messed up the validator. Bug: 826617 Change-Id: Ie96b150093c2158187ab6751335cdec3bdbb2d4b Reviewed-on: https://chromium-review.googlesource.com/1109664Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#569453}
-
David Grogan authored
TBR=dschuyler@chromium.org Bug: 842405 Change-Id: I699bef0e846e54bbb4d5f104060a210c4a6f03e3 Reviewed-on: https://chromium-review.googlesource.com/1111034Reviewed-by:
David Grogan <dgrogan@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#569452}
-
Carlos Knippschild authored
This metric will assist in figuring out if there is the need to better track actual content changes to pages saved more than once by last_n. Tests were also updated to check this (and another) metric(s) are being properly reported. Bug: 853429 Change-Id: I79e84b9d0de543d202307a357556056a7f835781 Reviewed-on: https://chromium-review.googlesource.com/1103616Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Dmitry Titov <dimich@chromium.org> Commit-Queue: Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#569451}
-
Scott Chen authored
This CL makes it possible to give cr-input a tabindex larger than 0 and have the tab order work as expected. Bug: 832177 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I42b25c70ac614360c95140d026755ae66c3cae8c Reviewed-on: https://chromium-review.googlesource.com/1103002 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#569450}
-
Lei Zhang authored
BUG=556939 Change-Id: I96e2fc6f76cfb85e9dac760ab77e93b9a6a7a10e Reviewed-on: https://chromium-review.googlesource.com/1053274 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Drew Wilson <atwilson@chromium.org> Cr-Commit-Position: refs/heads/master@{#569449}
-
David Bienvenu authored
WindowEventDispatcher synthesizes a mouse move event when a window's visibility changes, and Windows OS generates a mouse move event if a window opens the current mouse position. For Windows, make menu_controller ignore mouse move events for the first 100ms after the menu opens. On other platforms, make menu_controller ignore synthesized mouse move events. BUG=810160 Change-Id: I234376efb4c635a0345b4ef7ebdbca7727684263 Reviewed-on: https://chromium-review.googlesource.com/988800 Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#569448}
-
Qiyu Hu authored
This is to make the API more general. The current API cannot parse any options other than DevicePath. In the case where we want to parse multiple options, the current API just throw them away and returns us a device path. BUG: b:78593133 TEST: Things are still going well, at least on Android CTS Verifier. Change-Id: I088492e280a023998d0295137bddcd6857088606 Reviewed-on: https://chromium-review.googlesource.com/1103659Reviewed-by:
Miao-chen Chou <mcchou@chromium.org> Commit-Queue: Qiyu Hu <qiyuh@google.com> Cr-Commit-Position: refs/heads/master@{#569447}
-
Bernhard Bauer authored
NodeVisitor has only been used in tests, and this removes domain-specific logic from the TreeNode interface so it aligns better with the Clank UI architecture. Bug: 805070 Change-Id: I1c9e9e200cc7a87b7da4160a0c85605304bafe4a Reviewed-on: https://chromium-review.googlesource.com/1108204 Commit-Queue: Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#569446}
-
David Reveman authored
This reverts commit 9e00c38a. Reason for revert: This seem to have caused at least 2 serious rendering artifacts: crbug.com/854790 crbug.com/854677 Original change's description: > cros: Enable underlay strategy > > Add "underlay" to the list of overlay strategies on all the CrOS > platform that are using drm atomic. > > This strategy will make it possible to use HW overlays for > content like video/webgl even when it's partially occluded by > other HTML content. > > Bug: 789288 > Change-Id: I834d129c7dcd359bfd00eed8df820a8d3b134ee2 > Reviewed-on: https://chromium-review.googlesource.com/1081307 > Reviewed-by: Kristian H. Kristensen <hoegsberg@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Commit-Queue: Daniele Castagna <dcastagna@chromium.org> > Cr-Commit-Position: refs/heads/master@{#563466} TBR=avi@chromium.org,dcastagna@chromium.org,hoegsberg@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 789288, 854790, 854677 Change-Id: Ia46fe68d42ced9f625553120dd3c98096a820b99 Reviewed-on: https://chromium-review.googlesource.com/1110778Reviewed-by:
David Reveman <reveman@chromium.org> Commit-Queue: David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#569445}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/04925ac3f7e5..4099daa97b38 git log 04925ac3f7e5..4099daa97b38 --date=short --no-merges --format='%ad %ae %s' 2018-06-21 jbudorick@chromium.org gclient: Use posixpath-style separators for cipd subdirs on all platforms. Created with: gclient setdep -r src/third_party/depot_tools@4099daa97b38 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:854219 TBR=agable@chromium.org Change-Id: Id415d42e688c6bf0351ca4f77eaeef4717cbbb78 Reviewed-on: https://chromium-review.googlesource.com/1110459Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#569444}
-
Qiang Xu authored
changes: Consolidate uma recording when executing app menu command. Both shelf and app list code record Apps.ContextMenuExecuteCommand in AppMenuModelAdapter code path. It was used to record in SimpleMenuModel::RecordHistogram. However, app list doesn't exercise through that path maybe due to the refactoring (it calls delegate()'s code path now). This CL fixes the regression. And it is more straightforward to find where Apps.ContextMenuExecuteCommand UMA is recorded. Bug: 846370 Test: manual test Change-Id: Ib59ab96f2647d068af55118e150b81b3758a4a60 Reviewed-on: https://chromium-review.googlesource.com/1107720 Commit-Queue: Qiang Xu <warx@google.com> Reviewed-by:
-
Stefan Zager authored
ScrollbarManager is now PLSA-specific. BUG=823365 R=skobes@chromium.org,pdr@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ia872266afb330836c10f6e36dce3e756a5895734 Reviewed-on: https://chromium-review.googlesource.com/1110881Reviewed-by:
Steve Kobes <skobes@chromium.org> Reviewed-by:
-
Lei Zhang authored
- Return bool instead of int for counts if the count does not matter. - Delete dead code. - Remove unused parameters in an observer. - Modernize code. Change-Id: I41548bcedf1ed3fc4ededa27b7069ee5a09de1ac Reviewed-on: https://chromium-review.googlesource.com/1053598 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
-
Philip Rogers authored
In [1] a bug was fixed where passing an integer through DoubleSize::RoundedIntRect would lose precision. This bug actually shouldn't happen because doubles can perfectly represent integers. The issue is that DoubleSize was incorrectly using roundf/ceilf which are the float versions [2]. [1] https://crrev.com/569121 [2] http://en.cppreference.com/w/c/numeric/math/round Bug: 854194 Change-Id: I1e51a03ab3fd9037ae0dd40f1f6788ffa2ad4811 Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees Reviewed-on: https://chromium-review.googlesource.com/1110552Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
-
Matt Reynolds authored
Most gamepads report their button state in a HID output report that associates HID usages with the state of each button. For most gamepads, the HID usages associated with buttons come from the Button usage page. For some gamepads, particularly those designed to work on Android devices, the Back and Home buttons are associated with usages outside the normal set of gamepad usages. For instance, the Xbox One S gamepad, when connected over Bluetooth, sends a SystemMainMenu usage for the Home button. The same gamepad, after receiving a firmware update to improve Android compatibility, reports the Home and Back buttons as Home and Back usages on the Consumer usage page. On Linux, we use the joydev input driver to enumerate connected gamepads and fetch the current gamepad state. However, HID buttons outside the normal set of gamepad usages are not reported through joydev and must be read through evdev instead. This CL allows these extra buttons to be detected and mapped by Chrome. BUG=824871 Change-Id: Ib873948c6632edb36675f45c948190cb99ce126e Reviewed-on: https://chromium-review.googlesource.com/1091464Reviewed-by:
Brandon Jones <bajones@chromium.org> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#569439}
-
Tommy Martino authored
This CL reverts the following 2 CLs: ---- Revert "[Autofill Views] Reimplement Scrolling" This reverts commit c53515cd. Revert "[af] Adjust dropdown so it doesn't look so close to the input element" This reverts commit f1c12e66. ---- The former increased the frequency of a crash on Canary. The latter is a one-line change which was blocking us from landing a clean revert of the former. I have an OK from ftirelo to revert it at the same time. Change-Id: Ief96e2e8902477f83b3999b6c7fdcb2dfbd73035 Bug: 854183 TBR=estade@chromium.org Change-Id: Ief96e2e8902477f83b3999b6c7fdcb2dfbd73035 Reviewed-on: https://chromium-review.googlesource.com/1110577Reviewed-by:
Tommy Martino <tmartino@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Commit-Queue: Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#569438}
-
Maks Orlovich authored
... to avoid leaking it to other tests, which may want to test the non-fetch behavior, or have things set up for that to be usable. ResetForTesting was adjusted to take care of that, which seems sensible. Bug: 852929 Change-Id: I84147090a80836e0296d011b966b153aa4a30543 Reviewed-on: https://chromium-review.googlesource.com/1102723Reviewed-by:
Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Michael Martis <martis@chromium.org> Commit-Queue: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#569437}
-
Ryan Tseng authored
Bug: 790329, 790336, 790324, 790332, 790304, 790314 Bug: 790298, 790289, 790297, 815386 TBR: tandrii Change-Id: I591ff27163844629bd5692b647aa1e16c3578b10 Reviewed-on: https://chromium-review.googlesource.com/1110751Reviewed-by:
Ryan Tseng <hinoka@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Ryan Tseng <hinoka@chromium.org> Cr-Commit-Position: refs/heads/master@{#569436}
-
Ryan Tseng authored
4 core -> 24 core. Bug: 790381, 790383 TBR: tandrii Change-Id: I1f80d45bddd904fc186a00cd1db50f436770173d Reviewed-on: https://chromium-review.googlesource.com/1110998Reviewed-by:
-
Ryan Tseng authored
Bug: 840631 TBR: tandrii Change-Id: I85ea736f70f7241734d37dc0e6f897ca04575b5f Reviewed-on: https://chromium-review.googlesource.com/1111022Reviewed-by:
-
Francois Doray authored
For some reason, ResourceCoordinatorTabHelper::DidFinishNavigation() currently skips updating the frame tree and notifying the PageResourceCoordinator of main frame navigation commit when there is a navigation to an error page. This causes multiple problems: - The error page stays in the LOADING state forever. - The main frame URL is not updated in PageCoordinationUnitImpl. A navigation to an error page is just like a navigation to a normal page (the error page has a main frame, a renderer process), so there is no reason to have special case for it in ResourceCoordinatorTabHelper::DidFinishNavigation(). Bug: 855180 Change-Id: Ifbe52ce714ef04af574e00041f8b970c13c08f5d Reviewed-on: https://chromium-review.googlesource.com/1110697Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#569433}
-
Jun Choi authored
This CL changes chrome://enable-webauthentication-ctap2-support flag to be enabled by default. Bug: 798573 Change-Id: I0eb29e0cffacf88d6cccbc09281a713c1eab94c3 Reviewed-on: https://chromium-review.googlesource.com/1110547 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#569432}
-
Sergey Ulanov authored
makesdk.go script has been moved in Fuchsia. Update local-sdk.py accordingly. Change-Id: I3e336d7c35db2555a50bea2a58c39a5b50779044 Reviewed-on: https://chromium-review.googlesource.com/1110952Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#569431}
-
dpapad authored
Bug: 845746 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I402268fc66478b76e11e09a31227dff1569ddb35 Reviewed-on: https://chromium-review.googlesource.com/1107039Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#569430}
-
Mike Dougherty authored
Initialize NSError with the designated initializer to prevent the following message from being printing to the console. -[NSError init] called; this results in an invalid NSError instance. It will raise an exception in a future release. Please call errorWithDomain:code:userInfo: or initWithDomain:code:userInfo:. This message shown only once. Bug: None Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I94ac7664f7254126a5e2095d7c22c76497615c04 Reviewed-on: https://chromium-review.googlesource.com/1110490Reviewed-by:Eugene But <eugenebut@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#569429}
-
David Grogan authored
This reverts commit ae116dff. Reason for revert: fast/events/wheel/wheelevent-in-text-node.html leaks memory as caught by https://test-results.appspot.com/data/layout_results/WebKit_Linux_Trusty_Leak/20616/layout-test-results/results.html Original change's description: > fast/events/wheel/* layout tests use gpu benchmarking. > > This cl changes the layouttests in fast/events/wheel to use gpu benchmarking > for sending events rather than event sender. > > The cl excludes the following tests for the following reasons: > > To change these tests we need to implement touchpad fling (swipe) in GPU > benchmarking: > -mainthread-touchpad-fling-latching.html > -wheel-fling-cancel.html > > These tests are skipped since they are related to wheel events only rather > than scrolling: > -wheelevent-constructor.html > -wheelevent-ctrl.html > -wheelevent-document-createevent.html > -wheelevent-handler-count.html > > This test will be changed in a different cl among with tests that need > platform specific wheel DOM event expectation. > -wheelevent-in-scrolling-div.html > > Bug: 846424 > Change-Id: I086e6a7f4f62dce61a838d616a471bd030139e93 > Reviewed-on: https://chromium-review.googlesource.com/1103149 > Reviewed-by: David Bokan <bokan@chromium.org> > Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#569371} TBR=bokan@chromium.org,sahel@chromium.org Change-Id: I02765feb066ba06534d0d6385432c64b21d0aaa7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 846424 Reviewed-on: https://chromium-review.googlesource.com/1110860Reviewed-by:
-
Becca Hughes authored
Add a DisplayCutoutClient mojo interface that is bound to a frame and called from the browser. This will set safe-area* CSS env() variables that websites can use to layout their content based on the safe area. DisplayCutoutClient will be called from Android in a future CL. BUG=847652 Change-Id: I6180aa5337e182fd1794586c47caef0f19fab718 Reviewed-on: https://chromium-review.googlesource.com/1083291Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#569427}
-
Ryan Hamilton authored
Change-Id: Ie696c5ccaee3c9aba76065383ea04b976f002c7c Reviewed-on: https://chromium-review.googlesource.com/1110887Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#569426}
-
Ryan Hansberry authored
This injects a ClientChannel into ProximityAuthMonitor, which is used if the chromeos::features::kMultiDeviceApi is enabled. The ClientChannel is used to get the current RSSI of the connected remote device. In the future, the "rolling average RSSI" that is calculated in ProximityAuthMonitor will be moved to the SecureChannel API, and returned by it. However, to reduce immediate migration work, that logic is kept in ProximityAuthMonitor for now. R=jhawkins@chromium.org, khorimoto@chromium.org Bug: 824568, 752273 Change-Id: I8d6485a5a0018fe43595b880c25a2fa9af5a1b75 Reviewed-on: https://chromium-review.googlesource.com/1106616 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
James Hawkins <jhawkins@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#569425}
-
Hector Carmona authored
Add WebUI at chrome://welcome/apps. WebUI is only shown when NuxGoogleApps feature is enabled. Bug: 832938 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I46721ac4474a4335d9c0dfdb977e09622ae0ac1c Reviewed-on: https://chromium-review.googlesource.com/1066503 Commit-Queue: Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
-
Stephen Martinis authored
Makes the isolated script test wrapper script know that metrics_python_tests is a typ based test suite, so that it passes the proper command line argument to it. Bug: 533481 Change-Id: Ifd45f947409989174e1da046be6a8342931f82eb Reviewed-on: https://chromium-review.googlesource.com/1109400Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#569423}
-
Dominic Mazzoni authored
When a frame is hidden, replace its accessibility tree with just the root, and suppress all accessibility events in that tree while it's hidden. By keeping the root in the tree, this allows us to propagate the change to the browser process and free up resources there too. The goal is that having lots of tabs open shouldn't significantly impact your experience. It may add a slight delay when switching to a tab. Bug: 854411 Change-Id: I78b45e8f5772f0c9745ee59952f27f6ba3557bbc Reviewed-on: https://chromium-review.googlesource.com/1107207 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#569422}
-
Hector Carmona authored
Bug: 854560 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I48820701f46e82e27a488f1b2b5a7feaaa20e436 Reviewed-on: https://chromium-review.googlesource.com/1108752Reviewed-by:
-
Xianzhu Wang authored
Bug: 854848 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Id1cf7b09fc32141758792c26f805fb73a1f131cb Reviewed-on: https://chromium-review.googlesource.com/1109500Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#569420}
-
Will Harris authored
BUG=767906 Change-Id: I79dfb0509a1acc532a97750b4609e8bd6e3a438e Reviewed-on: https://chromium-review.googlesource.com/1110356 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#569419}
-
Xiyuan Xia authored
- Add RunDragLoop and CancelDragLoop to WindowServiceDelegate interface; - WindowServiceDelegateImpl use ash::DragDropController to provide the actual impl; - WindowTree implements PerformDragDrop and CancelDragDrop via the WindowServiceDelegate; Bug: 837716 Test: WindowServiceDelegateImplTest.*Drag*, WindowTreeTest2.*Drag* Change-Id: Id5d609d30dd53171b01bfeec60e4547f7a61b4c3 Reviewed-on: https://chromium-review.googlesource.com/1110669 Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
-
Mounir Lamouri authored
Bug: 855051, 853609 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ieedad00a60f3a64cf256771dc234953a928b5073 Reviewed-on: https://chromium-review.googlesource.com/1110667Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#569417}
-
