- 21 Oct, 2020 40 commits
-
-
Marc Treib authored
ModelAssociationDone() was always called synchronously from StartAssociationAsync(). Inlining it there uncovers some more dead code: * The status passed back to DataTypeManagerImpl was in fact always OK, so no need to pass a status at all. * requested_types_ was unused. Bug: 1102837 Change-Id: I4d66c926189280e029630c68f58ab05ec7971844 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2479425 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#819327}
-
Aya ElAttar authored
EndpointType::kClipboardHistory was added in crrev.com/c/2362289, so that ClipboardHistory will have access to any clipboard data, but the logic of EnterpriseClipboardDlpController:: IsReadAllowed didn't include kClipboardHistory when it got implemented. Bug: 1139835 Change-Id: I5f7fcd9e05a2a2f424b7ff1932edec557d23180f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487288Reviewed-by:
Nikita Podguzov <nikitapodguzov@chromium.org> Commit-Queue: Aya Elsayed <ayaelattar@chromium.org> Cr-Commit-Position: refs/heads/master@{#819326}
-
Alexander Bolodurin authored
Add a special case for ARC DocumentsProvider URLs to the image loader to fetch thumbnails using a dedicated fileManagerPrivate function. The function checks document metadata for a thumbnail support flag, and, if set, fetches the actual thumbnail via a mojo call to ARC. If the document does not have a thumbnail, no thumbnail is rendered, rather than falling back to download the original file and resizing it into thumbnail. Mojo struct Size was moved from video_common.mojom to gfx.mojom as it's now used by the filesystem API as well. Bug: 1049966 Change-Id: I758c7558ede42b01ad877b6f14781d51f6e1f0a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473857 Commit-Queue: Alexander Bolodurin <alexbn@google.com> Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#819325}
-
Stepan Khapugin authored
Creates a new feature flag. Bug: 1138886 Change-Id: I74d3308e668bffdcce43fed8aacffb778c4fbe2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2475697 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#819324}
-
Anatoliy Potapchuk authored
This test has been previously failing on Linux, now it fails on Windows, see https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%281%29/109192 Change-Id: I6b7d3ac20280c7bd264aee8091443e6f023434b6 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490120Reviewed-by:
Anatoliy Potapchuk <apotapchuk@chromium.org> Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Cr-Commit-Position: refs/heads/master@{#819323}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/cca03ca6bfe9..e2cbcc956588 2020-10-21 hao.x.li@intel.com Query API: Record used query index in command encoder 2020-10-21 dsinclair@chromium.org Update WGSL struct syntax. 2020-10-21 jiawei.shao@intel.com Add the entry point of CreateReadyRenderPipeline If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC dsinclair@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: dsinclair@google.com Change-Id: I790ce40a11c5509cf75689acd2635131f6d52591 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489560Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819322}
-
Christian Dullweber authored
Flash is going to be removed in M88, so mark related extension APIs as deprecated and make them a no-op. Bug: 1135788, 1135791 Change-Id: Idd2ceefcbe8eb6baeb31f44a4f3b12283253939b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466236 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#819321}
-
Anatoliy Potapchuk authored
This reverts commit f7e31c9d. Reason for revert: this seems to cause breakages in mac builders https://ci.chromium.org/p/chromium/builders/ci/Mac10.14%20Tests/9647 Original change's description: > Set fallback focus to the accounts and sync dialog. > > Set the first container as initial focus, so focus manager will search > the first focusable item in case no other view is explicitly focused > (e.g. with Ctrl+Shift+M, focus is set to the profile list for quick > profile change). Setting focus inside the dialog is important for > accessibility: when focus changes to a view inside the dialog, screen > readers will announce the dialog to give context to the focus change. > > We don't need to override GetAccessibleWindowRole() any more because > the implementation in DialogDelegateView will set the 'dialog' role for > bubbles which have an initially focused view. > > Tests are altered to make up for the default focus change. Before, > default focus was set outside the dialog and you had to advance once > to reach the first element. Now, it's already placed on the first > element. > > Bug: 1098304 > Change-Id: Ie0db18193cb224497d311c8ae864ec4e532572b6 > AX-relnotes: set focus into, and read accounts and sync dialog when open > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2475056 > Reviewed-by: Ramin Halavati <rhalavati@chromium.org> > Commit-Queue: Jacobo Aragunde Pérez <jaragunde@igalia.com> > Cr-Commit-Position: refs/heads/master@{#819287} TBR=pbos@chromium.org,jkrcal@chromium.org,rhalavati@chromium.org,jaragunde@igalia.com Change-Id: I8ad7448148905434910bd1178594e6542935ed85 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1098304 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489882Reviewed-by:
Anatoliy Potapchuk <apotapchuk@chromium.org> Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Cr-Commit-Position: refs/heads/master@{#819320}
-
Koji Ishii authored
This patch: 1. Makes sure |ShapingLineBreaker| computes |is_hyphenated| for when it returns early. Before this change, it only when the given string wraps. Since |NGLineBreaker| pass one |NGInlineItem| at a time, it is not computed when a soft hyphen or hyphenation point appears at the end of a text node or |NGInlineItem| after segmentations. 2. Recovers the hyphen when |NGLineBreaker| rewinds to a hyphenated break opportunity. This patch fixes 6 tests, but `hyphens-out-of-flow-00[12]` now fail for other reason (crbug.com/1024331). They are relabled. Bug: 639223 Change-Id: Id510b53c64bf02a6b72299ffcd8ed551a52ed2c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476354 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#819319}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1603238376-a0754723f0cd6eaa7fc2494ab4a5f08c0cee1720.profdata to chrome-mac-master-1603259905-71f19f253a8b5311fb57e85e7e87c615112024a2.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I7247c4994debae0d519f3b60b5e3bc9b811a3f07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489660Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819318}
-
Christian Biesinger authored
In particular, this opts us into filing bugs for failures. R=ikilpatrick@chromium.org, mstensho@chromium.org Change-Id: I3b1eba3dd5b71f8eeb1fbf5fa49bba739fd7d7c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489720 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#819317}
-
Henrique Ferreiro authored
The cursor type mojom::CursorType::kNone is used to hide the cursor. Therefore, CursorLoader::SetPlatformCursor() should create an invisible platform cursor for that type. This CL adds a test that checks that that's the case for the different implementations of platform cursors. Bug: 1139157 Change-Id: If9cde827f820e6420d0298dcdf6df3b1dbaafd49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485101Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#819316}
-
Stephen Chenney authored
These are all font related histograms so I should own them as metrics lead for the Blink Rendering Core team. Change-Id: If7a2ab7fcf5d34810ca8dc5e6f155d3d93a28795 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485302 Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Auto-Submit: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#819315}
-
Anton Bikineev authored
This is to make it less error prone if checks are augmented in one place but not in the other. Bug: 11297512 Change-Id: Id5518f703bf7240f8634570996eb5ec4eda10f94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2471332 Commit-Queue: Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Takashi Sakamoto <tasak@google.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#819314}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d82ff002..d9ccb94f Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic433b4fc8287a7d664817f18b5d81bada20bb87a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489002Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819313}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/7a0246ff177e..cd48ca0493ce 2020-10-21 sadrul@chromium.org [uma metric] Restrict check for linear bins. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1139460 Tbr: skyostil@google.com Change-Id: Ia147c8d841c350afdaf1f5dd9ac54eeaa2d88f21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489228Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819312}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/e2147a58a233..553726a4c5c8 2020-10-21 m.maiya@samsung.com Vulkan: Add OES_shader_multisample_interpolation extension 2020-10-21 cnorthrop@google.com Tests: Add Free Fire trace If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: jonahr@google.com Test: Test: angle_perftests --gtest_filter="*free_fire*" Change-Id: Ica4cba1a2b331d96d56754eb9ad4862a0501f457 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489166Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819311}
-
Yunke Zhou authored
Bug: 1128051 Change-Id: Id6396804860ba7685e2df0ed1e1dbbe65302ff03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2474493Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Yunke Zhou <yunkez@google.com> Cr-Commit-Position: refs/heads/master@{#819310}
-
Ramin Halavati authored
Profile menu click tests are updated to cover ephemeral Guest profiles. Please see go/ephemeral-guest-profiles for more context. Bug: 1125474 Change-Id: I777f465213b21ebc9187e6ed308d4198bc5d4fe7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485053 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#819309}
-
Christoph Schwering authored
This CL fixes several unit tests that use the PatternProvider. Tbr: koerber@google.com Change-Id: Ia809f85015601a3fe8147209ea8c073875a50935 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489081Reviewed-by:
Christoph Schwering <schwering@google.com> Commit-Queue: Christoph Schwering <schwering@google.com> Cr-Commit-Position: refs/heads/master@{#819308}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1074330695a7..77e70cfcbb1a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC apotapchuk@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: apotapchuk@google.com Change-Id: I2d2026c2c6d767e8a868747a849a3767fb54b530 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489233Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819307}
-
Anatoliy Potapchuk authored
This reverts commit 1ae2f731. Reason for revert: a bunch of mac failures after this cl https://ci.chromium.org/p/chromium/builders/ci/Mac10.11%20Tests/56167 Original change's description: > Roll Chrome Mac PGO Profile > > Roll Chrome Mac PGO profile from chrome-mac-master-1603238376-a0754723f0cd6eaa7fc2494ab4a5f08c0cee1720.profdata to chrome-mac-master-1603259905-71f19f253a8b5311fb57e85e7e87c615112024a2.profdata > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/pgo-mac-chromium > Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md > > Cq-Include-Trybots: luci.chrome.try:mac-chrome > Tbr: pgo-profile-sheriffs@google.com > Change-Id: I092ce3c9f4cd2ab9d88dc393650ef291295c22f5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487957 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#819285} TBR=chromium-autoroll@skia-public.iam.gserviceaccount.com,pgo-profile-sheriffs@google.com Change-Id: Ia80fef015149557138e163db69d5b0529dc0da5b No-Presubmit: true No-Tree-Checks: true No-Try: true Cq-Include-Trybots: luci.chrome.try:mac-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489620 Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Reviewed-by:
Anatoliy Potapchuk <apotapchuk@chromium.org> Cr-Commit-Position: refs/heads/master@{#819306}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/9f9ea0f6f024..ef36cec5b92e 2020-10-21 yangguo@chromium.org Apply governance change 2020-10-21 sigurds@chromium.org Reland "Use Markdown for Mixed Content related messages in the Issue tab" 2020-10-21 alcastano@google.com Add isReportOnly field to CSP Issue messages Frontend 2020-10-21 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. 2020-10-21 wolfi@chromium.org [TS] Port ApplicationCacheItemsView to TypeScript If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1125465,chromium:1139223 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: If333d49d0c6cb39eabf3b40faa9224fe4873e914 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487959Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819305}
-
Alexey Baskakov authored
A publisher must handle the execution of context menu command, not AppServiceContextMenu/AppServiceShelfContextMenu. Publishers can handle the execution of a shortcut by using `int command_id` or/and `string shortcut_id` argument (whatever is preferable for their implementation) See usage of this new plumbing in the dependent CL: https://chromium-review.googlesource.com/c/chromium/src/+/2462899 Bug: 1140356 Change-Id: Idb7bc587e968bdf25757b3dc0bd9f53dd0ad6e67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435130 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#819304}
-
Anatoliy Potapchuk authored
This reverts commit 55f62f27. Reason for revert: causes QuickActionsViewTest.LocatePhoneToggle failures https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/20941 Original change's description: > [CrOS PhoneHub] Disable Locate Phone button when Silence Phone is on. > > - Add an observer for state change in Silence Phone so that Locate Phone > can be disable when Silence Phone is on. > - Refactor InitQuickActionsItems() since Locate Phone and Silence Phone > is no longer independent. > > BUG=1106937,1126208 > > Change-Id: I6f015e868d6d00df6a40447de62f3efd0b2f2ad0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480662 > Reviewed-by: Tim Song <tengs@chromium.org> > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Commit-Queue: Andre Le <leandre@chromium.org> > Cr-Commit-Position: refs/heads/master@{#819161} TBR=khorimoto@chromium.org,tengs@chromium.org,leandre@chromium.org Change-Id: Ibcaef1859c90cdfd1b4fb4ff1bf686e28601787f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1106937 Bug: 1126208 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489304Reviewed-by:
Anatoliy Potapchuk <apotapchuk@chromium.org> Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Cr-Commit-Position: refs/heads/master@{#819303}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/3ead01191215..ea52b3c2d270 2020-10-20 johnkslang@users.noreply.github.com Merge pull request #2427 from ben-clayton/gn 2020-10-20 johnkslang@users.noreply.github.com Merge pull request #2428 from Tobski/GL_EXT_fragment_shading_rate 2020-10-20 john@johnkgo.com SPV: Update to the latest SPIR-V header, includes variable-rate shading If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,jonahr@google.com Change-Id: I98b0196f63e09a56b5d304dcfd639e63aed9c19d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488143Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819302}
-
Jan Scheffler authored
Change-Id: I21a39c1f34f9e1e08a4f5cd1537179c3ac13169c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487083 Commit-Queue: Jan Scheffler <janscheffler@chromium.org> Reviewed-by:
Paul Lewis <aerotwist@chromium.org> Cr-Commit-Position: refs/heads/master@{#819301}
-
Henrique Ferreiro authored
Change-Id: Ibc3e3bef3e3d73131c39fdc9d6cc18ed5218ef72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488163Reviewed-by:
Alexander Dunaev <adunaev@igalia.com> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#819300}
-
sauski authored
Redesigns notification content setting page to use a 3 state radio group connected to the previously introduced notification generated pref. Bug: 1113642 Change-Id: I146613595de3762e383cbe424948c1fa5b0c1854 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397577Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Theodore Olsauskas-Warren <sauski@google.com> Reviewed-by:
Sean Harrison <harrisonsean@chromium.org> Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Cr-Commit-Position: refs/heads/master@{#819299}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/41d4c65a3396..b432d0b75765 2020-10-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from df17a76102df to 84f5eeb6dd9b (3 revisions) 2020-10-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 2be35682cd67 to e2147a58a233 (40 revisions) 2020-10-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 60b90a0b to 4bdce889 (441 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC egdaniel@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: egdaniel@google.com Test: Test: Test: FIFA Mobile MECTest: Test: LEGO MECTest: Test: Lots of traces were hitting thisTest: Test: TransformFeedbackTest.SwitchProgramBeforeDraw/ES3_OpenGLTest: Test: angle_deqp_egl_testsTest: Test: angle_perftest --gtest_filter="*arena*"Test: Test: angle_perftests --gtest_filter="*brawl_stars*" Change-Id: I51352ad333ac26e3640c15785961b18f7bb26381 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489164Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819298}
-
Jon Mann authored
This fixes a long standing bug where the focus moved back up to the first network when an update to the list of available networks came in. Bug: 720274 Change-Id: Iee036aa649a74eef1b1743317a07b35061e08d3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480712Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Jon Mann <jonmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#819297}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1603238376-41278602b445da41d1916a61de8117b0857ab174.profdata to chrome-linux-master-1603259905-a5ed8d755823b45d7d48d45a9bc14c01d1293c89.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Iaf4b83d76f169c50f6dcafa489621f30fe94e4c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487958Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819296}
-
Alice Wang authored
This CL changes the waited view from continue button to selected account for the collapsed screen of web sign-in bottom sheet. This is needed for the refactoring of account picker view states later. Bug: 1138824 Change-Id: I9122253daffd1da06910c52042f5e53efc00d9b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487084Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#819295}
-
Alice Wang authored
This CL refactors AccountPickerBottomSheetTest with onVisibleView. Bug: 1121536 Change-Id: If6385712bf6d6271d77d6ced98e4d2b3cba43f1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485060Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#819294}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-mac-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: I4931a2710e1ce3b15189f525ecbe0c58b1c81f45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489229Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819293}
-
Vincent Palatin authored
PermissionBroker is now able to re-attach properly kernel device drivers to USB device interfaces on detecting the closure of a lifeline pipe from Chrome. Uses the new function for devices opened by webusb/chrome.usb. Bug: 1090596 Change-Id: Iebeae21890869cbff565a6ac76f48a7daac04ee1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2475794 Commit-Queue: Vincent Palatin <vpalatin@chromium.org> Reviewed-by:
Fergus Dall <sidereal@google.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#819292}
-
Henrique Ferreiro authored
Change-Id: I9f94ee4c2a833be22c94dd57c6a2736048f64a2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488161 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#819291}
-
Mikel Astiz authored
There's no remaining code under components/sync that has a dependency to components/sync_preferences. The trivial leftovers are cleaned up and the DEPS entry removed. Change-Id: I429196d1f41b81d804bb7a7fe4cb42614d9eb9d6 Bug: 915154 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485154 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#819290}
-
Joel Hockey authored
Add FileOperationManager.restoreDeleted interface. Implementation to follow in crrev.com/c/2469340. Add trashedItems property to background FileOperationProgressEvent which is populated with a list of items moved to trash in a delete operation. Bug: 953310 Change-Id: If5067bdbcb605f63434c8efab2f8f81f57c76198 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487744 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#819289}
-
Fabian Sommer authored
The observer for CertificateProviderService now also observes when an extension updates the certificates it provides. Add equality comparator for CertificateInfo for testing purposes. Bug: 1131450 Change-Id: I7efdb3f2b372e3aba279d52fda8e123050403af2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481022Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Fabian Sommer <fabiansommer@chromium.org> Cr-Commit-Position: refs/heads/master@{#819288}
-