GitLab

Also updates third_party/microsoft_webauthn to a version that supports
credProtect.

Bug: 941120
Change-Id: I8e0fb6fd72bad6927ec7d1121c1a58888fb7ba3c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599771
Commit-Queue: Martin Kreichgauer <martinkr@google.com>
Commit-Queue: Martin Kreichgauer <martinkr@chromium.org>
Reviewed-by: Adam Langley <agl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657484}

If enable surface synchronization is disabled and the frame is
visible then DelegatedFrameHostAndroid::EvictDelegatedFrame()
will only reset content_layer_ to null but not evict the
surface as that causes https://crbug.com/933374.

Trouble is that if the frame is then hidden without any new
content_layer being created the next call to
DelegatedFrameHostAndroid::EvictDelegatedFrame() will do nothing
as content_layer_ is null but the frame is still in the list of
unlocked frames in FrameEvicitionManager causing the next
call to FrameEvictionManager::CullUnlockedFrames that tries to evict
the frame to do nothing and loop forever (or hit a DCHECK if those
are enabled).

Fix this by not doing early exit if content_layer_ is null as this
is not directly connected to if there is a frame to evict.

Bug: 959914
Change-Id: I3f83036d9a5ae2c734dfca720115d1faf4278c87
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1596571Reviewed-by: Eric Karl <ericrk@chromium.org>
Commit-Queue: Joel Klinghed <the_jk@opera.com>
Cr-Commit-Position: refs/heads/master@{#657483}

An error message is displayed when user requests a factory reset and
the reset fails. The error screen shows a button that returns the user
to the OOBE flow when clicked.

This CL fixes the user action event sent to the C++ handlers. The
previous event we were sending no longer has any handlers.

This CL also modifies existing tests to verify that the event is being
handled.

Change-Id: I2871ba19283325fc7535cd107d3d27719e8a18be
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598090Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Commit-Queue: Tony De Luna <tonydeluna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657482}

The experiment flag will be enabled only on Mac/Windows/Linux.

Summary of changes:
1) Add manage passwords icon only in new container if experiment is
enabled.
2) Change the bubble anchor point to the new container instead of
location bar when experiment is enabled.
3) Add some browser tests to cover experiment flow.

Bug: 932818
Change-Id: Iaf600b56bb1f84b026ea17d43588095b7d38a49e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1597471
Commit-Queue: Siyu An <siyua@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657481}

It was using UnescapeURLComponent(), which leaves certain characters
escaped ("%00" through "%1F", and certain UTF-8 sequences which are
unsafe to display in the omnibox, like lock icons and 0-width spaces).
This behavior is generally not useful in most contexts - it's almost
always better to fail on bad input than to use partially unescaped
strings, and the UTF-8 logic isn't useful here.
UnescapeBinaryURLComponent(), on the other hand, unescapes input
unconditionally.

This CL is part of a project to clean up uses of
UnescapeURLComponent(), as it's been used for wildly disparate
purposes, and much of its logic is only suitable for cases where
we want to format a URL for safe display to the user. We want
to make it leave more weird characters escaped, but need to
eliminate usage of it in other contexts before we can do that.

UnescapeBinaryURLComponent() should be used instead in most cases,
particularly where URL_SPECIAL_CHARS_EXCEPT_PATH_SEPARATORS is in use,
as all consumers of that option seem to either be slightly buggy, or
don't actually need to leave any characters unescaped. The primary
cases where switching to UnescapeBinaryURLComponent() may cause
problems (without additional checks), are cases where unescaping
path separators or funky characters (like %01) is a problem. In those
places, we should generally fail instead of partially unescaping a URL.

Bug: 959213
Change-Id: I88cd0aff55c7a5cefd5224d011562810d7c3d150
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598785Reviewed-by: Yue Li <updowndota@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657480}

Ensure destination settings and the preview area monitor for destination
errors that occur in the other element.

Bug: 959779
Change-Id: I944ef8c200375ad4b03a266baa275815f46a57f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598314Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657479}

The new code 99 means libcurl returns an internal error code when
sending HTTP request and could not get an HTTP response code.

BUG=chromium:927039
TEST=None

Change-Id: Iba5d9815e2d1eca849074baf3bdda42416b8431d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566150
Auto-Submit: Xiaochu Liu <xiaochu@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Xiaochu Liu <xiaochu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657478}

BUG=948866

Change-Id: Ie6bd1da5af6e7644d36736f9fe24e8c6ec321f46
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1583716Reviewed-by: Donn Denman <donnd@chromium.org>
Commit-Queue: Marcin Wiącek <marcin@mwiacek.com>
Cr-Commit-Position: refs/heads/master@{#657477}

This reverts commit 904c3de3.

Reason for revert: this does not handle issues described in crbug/949931. Going to revert this CL and https://chromium-review.googlesource.com/c/chromium/src/+/1544978.

Original change's description:
> WebUI: FocusRowBehavior, handle case where lastFocused is in row that is focused
> 
> Bug: 957940
> Change-Id: I2dff479015888e56efe3113f1dadb3973455808b
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1591006
> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
> Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#656175}

TBR=dpapad@chromium.org,aee@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 957940
Change-Id: I03ddc6898a8e1b5188bc11b554af64c1005ae33f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598845Reviewed-by: Esmael El-Moslimany <aee@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657476}

- Implemented firing property changed event for
  UIA_AriaPropertiesPropertyId and associated unit and
  browser dump tests for the following AriaProperties:
   - atomic
   - busy
   - checked
   - expanded
   - haspopup
   - invalid
   - multiline
   - required
   - selected

- Removed serializing popup logic in
  BlinkAXTreeSource::SerializeNode since it is redundant
  and already covered by AXStateFromBlink(src, dst) at
  the beginning of SerializeNode.

- Breakdown of UI Automation AriaProperties need to be
  implemented:
  atomic [part 1, this cl]
  busy [part 1, this cl]
  channel [part 2]
  checked [part 1, this cl]
  disabled [part 3]
  dropeffect [part 2]
  expanded [part 1, this cl]
  grabbed [part 2]
  haspopup [part 1, this cl]
  hidden [not implemented]
  invalid [part 1, this cl]
  level [part 3]
  live [part 3]
  multiline [part 1, this cl]
  multiselectable [part 3]
  posinset [part 4]
  pressed [part 4]
  readonly [part 4]
  relevant [part 4]
  required [part 1, this cl]
  secret [part 2]
  selected [part 1, this cl]
  setsize [part 5]
  sort [part 5]
  tabindex [part 2]
  valuemax [part 5]
  valuemin [part 5]
  valuenow [part 5]
  valuetext [part 5]

- Documentation on UI Automation AriaProperties
(see the second table's last column for AriaProperties
properties):
https://docs.microsoft.com/en-us/windows/desktop/WinAuto/uiauto-ariaspecification

- Link to part 1, UIA: Fire UIA_AriaPropertiesPropertyId event:
https://chromium-review.googlesource.com/c/chromium/src/+/1574834

- Link to part 2, UIA: Fire UIA_AriaPropertiesPropertyId event:
https://chromium-review.googlesource.com/c/chromium/src/+/1576280

- Link to part 3, UIA: Fire UIA_AriaPropertiesPropertyId event:
https://chromium-review.googlesource.com/c/chromium/src/+/1589100

- Link to part 4, UIA: Fire UIA_AriaPropertiesPropertyId event:
https://chromium-review.googlesource.com/c/chromium/src/+/1592640

- Link to part 5, UIA: Fire UIA_AriaPropertiesPropertyId event:
https://chromium-review.googlesource.com/c/chromium/src/+/1591487

Bug: 928949
Change-Id: Iee8a99c0d5868660976736af0f62eb8c41341d21
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574834Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Ian Prest <iapres@microsoft.com>
Commit-Queue: Victor Fei <vicfei@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#657475}

While the SurfaceControl is controlled by a global feature flag, we may
need to disable it for a particular android Surface in some cases. This
was added in [1], cleanup the implementation and add some comments.

[1]: https://chromium-review.googlesource.com/c/chromium/src/+/1573164

R=piman@chromium.org, dtrainor@chromium.org

Bug: 958981
Change-Id: Ia640c7ff9c99328593958254ac0dff6e5d625c5c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1597251
Commit-Queue: David Trainor <dtrainor@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Frank Liberato <liberato@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Auto-Submit: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657474}

Previously, when the LOG macro was called in Fuchsia, logs were written
to stderr. Now the macro also calls the Fuchsia syslog API and logs can
be received on the Fuchsia side.

Tested using a test version of the LogListener interface.

Bug: 951143
Change-Id: Ia9ea4ee4923729732329bae97b2d96857106d5e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566425Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657473}

Original commit e4a0701a
Original review crrev.com/c/1582438

This is a clean rollback of the rollback. All fixes were made upstream
(and the rollback was only ever done to ease rollback of a problematic
upstream change).

Bug: 934402
Change-Id: Ibaa58fdb6b7f4f72e7f5042207cbdd567fb48cf5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598338
Commit-Queue: Eric Orth <ericorth@chromium.org>
Reviewed-by: Asanka Herath <asanka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657472}

This reverts commit 18526eed.

Reason for revert: Multiple builders failing ConnectTest.BlockedPackagedApplication.

Original change's description:
> [service-manager] Simplify connection logic
> 
> This reduces the complexity of Service Manager's logic for handling
> interconnection between service instances. Much of the complexity was
> due to connection operations once upon a time being highly
> asynchronous within SM, but that hasn't been the case for a while.
> 
> Rather than having ServiceManager::Connect do way too much stuff, it's
> replaced with a simpler and more straightforward
> FindOrCreateMatchingTargetInstance, which does only what the name says.
> Previous work done by Connect() in various edge cases has been moved out
> to its prior call sites, now replaced with calls to FOCMTI.
> 
> Bug: 904240
> Change-Id: Ia276f6fa61477ddc141724d30484237498eef070
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1593722
> Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
> Commit-Queue: Ken Rockot <rockot@google.com>
> Cr-Commit-Position: refs/heads/master@{#657401}

TBR=rockot@google.com,oksamyt@chromium.org

Change-Id: Ibcd1fec093b39a7759b1473fa04f5ba0e1c13c4e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 904240,960544
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600393Reviewed-by: John Rummell <jrummell@chromium.org>
Commit-Queue: John Rummell <jrummell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657471}

It used to be the case that the format that Skia used for software
raster was a compile-time decision that couldn't be changed dynamically
at run-time. This could leave us in a situation where Skia rasters
the tiles in BGRA but at run-time we find out that the GL driver
doesn't support BGRA texture so we have to upload to an RGBA texture
instead. To make this work, a bit called |swizzle_contents| was
introduced to TileDrawQuad that would signal to the renderer that the
embedded texture needs to be swizzled in the fragment shader. However,
this code is now obsolete because Skia has allowed changing raster
formats for a while. This CL gets rid of swizzle_contents and instead
changes raster format to RGBA if BGRA textures aren't available.

TEST=manually disabled ext_texture_format_bgra8888 in
gpu::gles2::FeatureInfo and verified that colors look fine with
GLRenderer and SkiaRenderer.

Bug: 956754
Change-Id: I74d4c67017e01765ecf622887f61d92ce09704c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1595975
Auto-Submit: Saman Sami <samans@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: vmpstr <vmpstr@chromium.org>
Commit-Queue: Saman Sami <samans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657470}

DOMDebugger.setInstrumentationBreakpoint had a small race condition in
 one edge case (pausing before navigating when an instrumentation
breakpoint was set.)

On Linux sometimes the instrumentation breakpoint fires first before
pause can take effect. Since this is a very niche case and not
particularly interesting to validate, I have removed this part of
the test in order to stabilize it.

Bug: 960346
Change-Id: I9198c96e27314928ed48e9380b28dd68c7366e7a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599742Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Jeff Fisher <jeffish@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#657469}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/bebc1e506803..83679a3cd6a7


git log bebc1e506803..83679a3cd6a7 --date=short --no-merges --format='%ad %ae %s'
2019-05-07 bhthompson@google.com Disable CQ/PFQ builders for peach and derivatives
2019-05-07 dburger@chromium.org Switch to outputting milo URLs for build details pages.
2019-05-07 derat@chromium.org cbuildbot: Make TastVMTest report incomplete tests.
2019-05-07 gbiv@google.com afdo: add a release profile merger


Created with:
  gclient setdep -r src/third_party/chromite@83679a3cd6a7

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@chromium.org

Change-Id: Ica59c5703010a515184849824a7471aa994cf7d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599740Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#657468}

Even if a stickily positioned box sticks to the scrollport when
scrolling, that doesn't mean that the current distance to the start of
the scrollable container should make any difference during layout, as
far as overflow contribution from the stickily positioned box is
concerned.

Bug: 958803
Change-Id: I8a268c3ec2d5d62960f1f92322e75f932afe2a91
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1597588Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Aleks Totic <atotic@chromium.org>
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657467}

- Replace mojom::SessionControllerClient mojo interface with C++
- Move mojom::SessionController::SetClient to ash::SessionController;
- Update tests;

Bug: 958214
Change-Id: Iccf4204a5e3b052f55549002e662dcf714ab172b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1595044Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657466}

Original commit 6d837ba3.
Original review crrev.com/c/1582424.

Patchset 1 is clean rollback of the rollback.

This time, the new HostResolver::ManagerOptions::dns_client_enabled
functionality is actually implemented. Because testing required
injecting mock DnsClient at construction (where the option field is
used), added a DnsClientFactory optional testing parameter to the
constructor.

Reworked the unittests to use ManagerOptions::dns_client_enabled for
most Dns tests. Also added a test for enabling via SetDnsClientEnabled
now that the factory makes doing so more reasonable in tests.

TBR=mef@chromium.org

Bug: 934402
Change-Id: Ic337892a8ec765bd6a6fdd26177db44eead0c786
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1595297
Commit-Queue: Eric Orth <ericorth@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657465}

Since the resource type is trusted from the renderer, we can have the renderer pass this per-request based on data it has.

This is a step towards the TODO to remove this from network::ResourceRequest, since network service
shouldn't know about this enum.

Bug: 960143
Change-Id: I8afa72ff14236e7123196f47e17a574527ac1e3c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1597975Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657464}

The Media.Audio.Render.StreamCallbackError2 histogram is an important
metric for the health of the audio pipeline, so extend it by half a
year.

Bug: 960096
Change-Id: Id00b62398c9ce821c99a064c3c8c561e6217b045
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598819
Auto-Submit: Max Morin <maxmorin@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657463}

The difference between these functions and the existing functions is
the data structure.

The LabelFormatter classes for desktop labels use vectors because each
form type, e.g. address plus phone, is responsible for creating its own
labels and the order in which parts of a label should appear reflects
the order in which they are added.

The MobileLabelFormatter (CL forthcoming) uses a list because the order
in which parts of a label should appear does not reflect their relative
importance, and thus, does not reflect the order in which parts are
added to the collection of label parts. Note that MobileLabelFormatters
are responsible for building labels for all form types.

Example:

Suppose a mobile user is focused on an email field in an address plus
contact form.

If street address, phone number, and name disambiguate profiles, then
the label should be 1 Elm St, (508) 984-1081.

However, if only the phone number and name disambiguate, then the label
should be Robert, (508) 984-1081, which entails adding an element to
the front of the collection of label parts. Lists are better suited for
this than vectors.

Note:

In the interest of sending smaller CLs, I've separated these functions
from the upcoming MobileLabelFormatter CL.

These functions will be tested through MobileLabelFormatter unit tests.

Bug: 958333
Change-Id: I65eebe19f180afebff200c49ef18b36d1a09d0e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1597197
Commit-Queue: Caitlin Fischer <caitlinfischer@google.com>
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657462}

This reverts commit 23971187.

Reason for revert: <Waiting for the other V8 change rolling up into Chrome build. Revert this CL for now.>

Original change's description:
> Add a Finch experiment V8HugeMaxOldGenerationSizefor V8 heap size increase
> 
> Increase max_old_space_size to 4 GB based on availability of physical memory.
> The purpose of this finch is to support web apps that require more heap space
> for their data sets
> 
> Bug:958974
> 
> Change-Id: I7f6bb9e69a306331242434cfc03acd68ad32333d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592792
> Reviewed-by: Zhenyao Mo <zmo@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Reviewed-by: Brian White <bcwhite@chromium.org>
> Commit-Queue: Maggie Chen <magchen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#656851}

TBR=sky@chromium.org,zmo@chromium.org,bcwhite@chromium.org,magchen@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 958974
Change-Id: I304ebbd702a000ee5f4a6d5956d3c61075144711
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598484Reviewed-by: Maggie Chen <magchen@chromium.org>
Commit-Queue: Maggie Chen <magchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657461}

Previously when a scroll container's snap type is changed to 'none' its
data was discarded including all of its snap areas. However this is
incorrect. Because while the snap type is 'none', the element is still
a scroll container which per spec [1] means  that is should continue to
captures the snap areas in its subtree for whom it is the nearest
ancestor scroll container . The only difference is that it no longer
snaps.

The fix is that we no longer remove the snap container data just
because is has a 'none' snap type and instead keep it and its snap
areas. But we check the snap type before performing any snap.

To ensure this does not introduce any performance regression, this CL
also includes an optimization where we avoid re-calculating
snap_container_data when the snap type is 'none'. So keeping these snap
data should not be cheap.

Note that there is another problem where if the current snap container
is no longer a scroll container (e.g., overflow: scroll => overflow:
visible) we release its snap areas and they become "orphan". But if we
are to do this correctly, we should re-assign these areas to the next
stroller in the chain. Similarly when an element becomes a scroll
container, it can potentially take over snap areas from its parent snap
container.


This patch does not address that situation yet but fixes the easier
problem.

[1] https://drafts.csswg.org/css-scroll-snap/#overview

Bug: 953575
Test:
 - wpt/css/css-scroll-snap/scroll-snap-type-change.html => Changing snap-type should work correctly
 - wpt/css/css-scroll-snap/scroll-snap-type.html => Add a specific test for type 'none' to ensure it does not snap

Change-Id: Ie493ad68ecba818ed41c0ee103ccf44725ff6e3f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1589899Reviewed-by: Majid Valipour <majidvp@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657460}

Instead of decompositing transforms of pending layers before updating
cc transforms, now decomposite a pending layer's transforms just after
we create cc effect, clip and scroll nodes. We don't decomposite a
transform if the cc transform node has been created during creating
other cc property nodes.

Because decompositing transform of a layer is just to move the
transform pointer up along the transform path, it won't affect other
layers which may not decomposite the same transforms.

This improves performance by avoiding hash map accesses and additional
pending layer iteration and blink paint property tree walks.

Change-Id: Idfdc6bc510cfb83a1b3eb3956cc2fb0a11d457a2
Bug: 954520, 954493
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1597205
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657459}

If `requireResidentKey` is false an authenticator may, at least with
CTAP 2.0, still create a resident key. RPs might want to set credProtect
level two for that case even though it's moot for non-resident keys.

This change allows that stance.

Bug: 941120
Change-Id: If4be7aabbb2d5b002942a0dc033f49b4c71b8538
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1595972
Auto-Submit: Adam Langley <agl@chromium.org>
Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Commit-Queue: Adam Langley <agl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657458}

https://chromium.googlesource.com/catapult.git/+log/1b3bbd05bd7b..195bcae748c7


git log 1b3bbd05bd7b..195bcae748c7 --date=short --no-merges --format='%ad %ae %s'
2019-05-07 rmhasan@google.com [Telemetry] Add the --all command line argument to telemetry browser tests


Created with:
  gclient setdep -r src/third_party/catapult@195bcae748c7

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:937516
TBR=sadrul@chromium.org

Change-Id: Ifd6e4e83480121c9295bb008d5a964c4ffd5cffb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599739Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#657457}

This reverts commit 6bff67f4.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 657321 as the
culprit for flakes in the build cycles as shown on:
https://analysis.chromium.org/p/chromium/flake-portal/analysis/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vNmJmZjY3ZjQ5MjI4OWVhMzk1MzVmYTQ4M2Q3MDNjY2MwZDNkZTg1Nww

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-dbg/12268

Sample Failed Step: non_network_service_interactive_ui_tests

Sample Flaky Test: ScreenRotationTest.RotateInTable/1

Original change's description:
> [CrOS Perf Test] Rotatoin Animation Test
> 
> This runs the rotation ainmation with following conditions:
> with 2 or 8 windows,
> with NTP or blank page
> in overview mode or normal
> 
> Bug: 952885, 919707
> 
> Change-Id: I50f0a44a3c2a3f79d9ffd0d818f59d2e660784dc
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594043
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#657321}


Change-Id: Ie2de9b64e8f23cd991b9d290ed488747af412fbb
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 952885, 919707
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598325
Cr-Commit-Position: refs/heads/master@{#657456}

It was using UnescapeURLComponent(), which, unlike
UnescapeBinaryURLComponent(), leaves certain characters escaped. The
behavior difference doesn't really matter for the purposes of these
tests, we're just trying to reduce the consumers of
UnescapeURLComponent() to only those that need and expect it not to
unescape UTF-8 characters that are unsafe to display, so we can expand
that logic.

This CL is part of a project to clean up uses of
UnescapeURLComponent(), as it's been used for wildly disparate
purposes, and much of its logic is only suitable for cases where
we want to format a URL for safe display to the user. We want
to make it leave more weird characters escaped, but need to
eliminate usage of it in other contexts before we can do that.

UnescapeBinaryURLComponent() should be used instead in most cases,
particularly where URL_SPECIAL_CHARS_EXCEPT_PATH_SEPARATORS is in use,
as all consumers of that option seem to either be slightly buggy, or
don't actually need to leave any characters unescaped. The primary
cases where switching to UnescapeBinaryURLComponent() may cause
problems (without additional checks), are cases where unescaping
path separators or funky characters (like %01) is a problem. In those
places, we should generally fail instead of partially unescaping a URL.

Bug: 849998
Change-Id: I7d1f64b5fab51b8120a0c3504e4e8cd1610b79d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600092
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Chase Phillips <cmp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657455}

This is in an attempt to reduce the number of reviews that originally
get sent to us that should probably get sent to Caleb and his team.

R=eyaich@chromium.org,sullivan@chromium.org,crouleau@chromium.org

Change-Id: Ib57c78f369c2c4fbe0105975e0c55ff6719cdbf1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1596836Reviewed-by: Emily Hanley <eyaich@chromium.org>
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657454}

This change is a predecessor to moving AddTaskTime out of the
schedulers and into the PerformanceMonitor.  Since that requires a
large overhaul of the existing framework, this change will provide
actionable numbers for CPU performance on ad frames, even if some
events are still being missed (there is evidence rAF is a large
contributor to overall CPU time).

Bug: 937298
Change-Id: Ifd51400192cf008a3d4fd127f0cbead66955f5b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594692Reviewed-by: Nate Chapin <japhet@chromium.org>
Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Commit-Queue: Eric Robinson <ericrobinson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657453}

Some UrlConnection impls require this before getOutputStream()
is called.  Calling this should be a no-op on Android but should
allow the Cronet Java API impl based on UrlConnection to
work in Robolectric.  Internal bug b/35665404.

Change-Id: Ib911ff4bb7bc9a7906c3e723f6583df1d510b1ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598493
Auto-Submit: Paul Jensen <pauljensen@chromium.org>
Commit-Queue: Misha Efimov <mef@chromium.org>
Reviewed-by: Misha Efimov <mef@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657452}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/378f007f127e..b58501a3b11b


Created with:
  gclient setdep -r src-internal@b58501a3b11b

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome

BUG=chromium:944752
TBR=nhiroki@chromium.org,iclelland@chromium.org,dullweber@chromium.org,jrummell@chromium.org

Change-Id: Ie14b098723988d062965893df17f15d609abceaf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599738Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#657451}

Prevously we collected animation element ids after updating cc paint
properties, and traversed the parent chain until we find a node whose
element id had been collected. This might repeatedly traverse many
nodes without element ids unnecessarily.

Now collect animation element ids just after creating cc property
node to avoid the repeated traversal.

Bug: 954520
Change-Id: I923b610766d04d80041b8ddf46cc9828621d9237
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598328
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657450}

Tapping the Done key whenever editing a username will now dismiss the
keyboard. This is required since the Save/Update button might be hidden
by the keyboard.


Bug: 945478
Change-Id: Ic26b5f667b11d27f6fcfc7ac08824781ff3ce857
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599673Reviewed-by: Peter Lee <pkl@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657449}

If license allows, cast_shell always gets clear audio stream before
pushing buffer to media backend. Otherwise, playback fails.

Bug: internal b/131755006
Test: Stream mentioned in the bug, GPM
Change-Id: Ifcf4f6c6a856d4173d9b30b98b82943f8f0f1fca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1595508Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Reviewed-by: Sergey Volk <servolk@chromium.org>
Commit-Queue: Yuchen Liu <yucliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657448}

While the idea in
https://chromium-review.googlesource.com/c/chromium/src/+/1544880 was
correct, we forgot to consider what happens when a source stops and is
disconnected to the ScriptProcessorNode (AudioWorkletNode).  In this
case, the output of the node is disabled.  But that's incorrect in
general because the node's processing must continue because it has
user-defined outputs so a silent input does not imply a silent output.

Rather than adding a special case in DisableOutputsIfNecessary, let's
just revert the change.  The internal properties aren't exposed to the
developer.

Bug: 959125
Test: the-scriptprocessornode-interface/simple-input-output.html
Change-Id: I0f217be24eacff6031a537086df535e6c1e8d9d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598427Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657447}

Specify the custom background image via a <link rel="preload"...>
tag that's inserted at the time the page is served.

Bug: 853042
Change-Id: Id24b1815c66b32f04b1811e55c54b5066cfc9873
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592122Reviewed-by: Dan Beam <dbeam@chromium.org>
Reviewed-by: Kristi Park <kristipark@chromium.org>
Commit-Queue: Kyle Milka <kmilka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657446}

The new condition is the same as cc::PropertyTreeBuilder.
This avoids unnecessary PAC::Update in js_poster_circle benchmark.

Bug: 954520
Change-Id: Ib547c828d4dee7e97fe8e72e2ed69f7a2545d63c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1597209
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657445}