GitLab

ui/views dependency will be addressed as a part of
crbug.com/890403

Bug: b/116028711
Test: Tested using following apps with and without chrome caption, in
windowed, maximized, fullscreen using Japanese IME.

hangout, hangout inline reply (in notification),
Google play, FB chatheads

I couldn't test with Docs due to b/116855183

Change-Id: Ie371f44286ca0e42e6f0a7f4bb40c9e19e2717da
Reviewed-on: https://chromium-review.googlesource.com/1252012Reviewed-by: Elijah Taylor <elijahtaylor@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595756}

r595201 fixed how overflow is clipped in paint containment,
there were two tests failing because of that so we can now unskip them.

TBR=eae@chromium.org,vmpstr@chromium.org

BUG=882322

Change-Id: I029cad3f873f90894bd66a531aee2e2e94b62eb0
Reviewed-on: https://chromium-review.googlesource.com/1256682
Commit-Queue: Manuel Rego <rego@igalia.com>
Reviewed-by: Manuel Rego <rego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#595755}

With this change, Autofill Assistant only runs when the feature is
enabled and the Intent contains:
org.chromium.chrome.browser.autofill_assistant.ENABLED.

Bug: 806868
Change-Id: I6bc81181b9f16a2d13e56ff657c6bd9076621808
Reviewed-on: https://chromium-review.googlesource.com/1254281
Commit-Queue: Stephane Zermatten <szermatt@chromium.org>
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595754}

kMediaDeviceIdSalt is removed from incognito persistent preferences
list. After this CL, the changes to this preference in incognito mode
are not written to user profile.

Bug: 861722
Change-Id: If9328b582523573fb0f9cbcc7dbe89ff8b36c8b4
TBR: perkj@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1255525
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595753}

In theory, views::Widget::ReparentNativeView and
views::Widget::InitParams allow specifying any NSView* as the parent of
a views::Widget.

The only parent ever actually specified in production is the NSView*
corresponding to the root views::View of another views::Widget.

Add a CHECK to verify that this is the case. If the CHECK is not hit,
then we remove this functionality. Continue to allow testing of this
path (for now) by disabling this CHECK via a static method.

Bug: 859152
Change-Id: I70a9a22352e22b1949d37c86c36388ed5380316b
Reviewed-on: https://chromium-review.googlesource.com/1255863
Commit-Queue: ccameron <ccameron@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595752}

The NSView hierarchy for most windows is
- BridgedNativeWidget
  - WebContentsView (*)
    - RenderWidgetHostView
This patch adds a cross-process interface for WebContentsView. This
interface created via the NSViewBridgeFactory interface, using the
new mojo method CreateWebContentsNSViewBridge.

Add the mojo interface content::mojom::WebContentsNSViewBridge and
content::mojom::WebContentsNSViewClient.
- The interface that is exposed is motivated by the native Cocoa calls
  made by views::NativeViewHostMac (which are targeting the
  WebContentsViewCocoa).
- Note that this interface is public (unlike RenderWidgetHostNSView)
  because it doesn't have any content-private dependencies.

Add methods to the C++ interface ui::ViewsHostableView (which is
implemented by WebContentsViewMac), to perform all of the functions
currently done by Cocoa calls on WebContentsViewCocoa.

Add the class content::WebContentsNSViewBridge, which implements the
new mojo interface.
- This performs the same Cocoa calls that are done in the browswer
  process.
- Note that this class does not instantiate WebContentsViewCocoa (the
  NSView sub-class used by WebContents), rather, it uses a vanilla
  NSView. This may change in the future, if need be.
- Note that this NSView is in addition to the WebContentsViewCocoa
  created in the browser process (not in place of it).

Update RenderWidgetHostMac::MigrateNSViewBridge to take the arguments
that content::WebContentsViewMac will send it.

Bug: 821651
Change-Id: Ic1dd5c469a8dab32837cdf23cdda34d24d6240cb
Reviewed-on: https://chromium-review.googlesource.com/1253095
Commit-Queue: ccameron <ccameron@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595751}

- Resize on rotation.
- Disable scrolling of table when active.

Bug: 889012,889506, 889461
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I54d4f41d31a0fb3ec7e248a3cb25bb985e58cf72
Reviewed-on: https://chromium-review.googlesource.com/1249483
Commit-Queue: David Jean <djean@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595750}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/421d954080fe..9fe56ff9c6f8


Created with:
  gclient setdep -r src-internal@9fe56ff9c6f8

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I211ebf858b183eefe6dd0830ee82ebdffa50ccef
Reviewed-on: https://chromium-review.googlesource.com/1256074Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#595749}

Previously, ChildrenChanged() was being called while layout was
in-progress, potentially causing crashes as certain AXObject attributes
require walking the flattened DOM tree.

This change instead queues up changes which would trigger
ChildrenChanged() calls, and processes all updates to the accessibility
tree after layout is complete.

Change-Id: Ifd99b31a229cbabd48bfa6515951d0aba32c1cc6
Reviewed-on: https://chromium-review.googlesource.com/1239296
Commit-Queue: Alice Boxhall <aboxhall@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595748}

The QuickView text <webview> provides no signal that it is loaded, but
it does have a src attribute. That can used as a proxy for loaded, and
help make a test that is robust (to load / script timing) on the bots.

 - make the text <webview> selector precise (.text-content class)
 - change the text scroll test to check the webview src attribute
   is non-empty before proceeding.
 - change to use scrollBy, and send incremental scrolls until the
   the scroll limit is reached [1].

[1] if the bot misses or drops a JS scrollBy request, no problem: just
ask for it again.

Bug: 891150
Change-Id: I0bb49c2b08b3535172819a3c1088fca5ba6fda94
Reviewed-on: https://chromium-review.googlesource.com/1256469Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595747}

Add integer handles for NSViews that may be created in the app shim
process. This includes the BridgedNativeWidget content view and soon
will include the WebContentsView. A handle is not added for
RenderWidgetHostView because there are no planned methods that would
use it.

These handles will be needed for methods that require interactions
between NSViews created by different interfaces. Add as an example the
method RenderWidgetHostNSViewBridge::SetParentWebContentsNSView. This
will allow constructing the NSView hierarchy in the app shim process:
- BridgedNativeWidget
  - WebContentsView (coming in subsequent patches)
    - RenderWidgetHostView

Bug: 821651
Change-Id: I225eb03f122baa9aea770d28e98a44c938943434
Reviewed-on: https://chromium-review.googlesource.com/1253094
Commit-Queue: ccameron <ccameron@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Sidney San Martín <sdy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595746}

Web app selecting echo canceller type to system AEC is behind an
experimental origin trial. Removing the flag report from Chrome
OS system, so it's easier to control testing for this feature.

Bug: 880708
Change-Id: I10f981d2bd27e04a372d12644eae2903521c7ea1
Reviewed-on: https://chromium-review.googlesource.com/1248063
Commit-Queue: Hsinyu Chao <hychao@chromium.org>
Reviewed-by: Jenny Zhang <jennyz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595745}

Using wpt-import in Chromium 76a1ed51.
With Chromium commits locally applied on WPT:
92605c16 "[Unified Plan] Remote MediaStreamTracks should be muted by default."
534cd7bb "isXXX methods added to TrustedTypePolicyFactory"
a9d61b8e "Implement RTCIceTransport.onselectedcandidatepairchange"


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/25747

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=raphael.kubo.da.costa@intel.com

No-Export: true
Change-Id: Icf4d4ab700f254867844a14a518b4859326adea7
Reviewed-on: https://chromium-review.googlesource.com/1256366
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595744}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/4b7de4a5..573561bf

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Iece2651aa1d1ff01e4a211dc5477445ae0b5a007
Reviewed-on: https://chromium-review.googlesource.com/1256602Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#595743}

This CL may cause a small binary size increase, roughly proportional
to how long it's been since our last AFDO profile roll. For larger
increases (around or exceeding 100KB), please file a bug against
gbiv@chromium.org. Additional context: https://crbug.com/805539

Please note that, despite rolling to chrome/android, this profile is
used for both Linux and Android.

The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=gbiv@chromium.org

Change-Id: If9c1c2e59ed0f603be7a84a508bebd7d12566f8b
Reviewed-on: https://chromium-review.googlesource.com/1256075Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#595742}

This reverts commit 941c32aa.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> PaymentRequest: Fix a memory leak in retry()
> 
> In the current implementation, memory leaks occur becuase the internal
> view_stack_ for payment sheet grows incrementally whenver calling
> retry(). So, this patch uses GoBackToPaymentSheet() instead of
> ShowInitialPaymentSheet() in RetryDialog(). The method has a logic to
> reduce stack's size internally.
> 
> Bug: 861704
> Change-Id: I2cb94772485165d1fa96463f16f39edf20ccf7bc
> Reviewed-on: https://chromium-review.googlesource.com/1255082
> Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
> Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
> Cr-Commit-Position: refs/heads/master@{#595644}

TBR=rouslan@chromium.org,jinho.bang@samsung.com

Change-Id: Ibf67fa672afee9b3da73b6fb22f325641b011186
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 861704
Reviewed-on: https://chromium-review.googlesource.com/1256394Reviewed-by: Jinho Bang <jinho.bang@samsung.com>
Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
Cr-Commit-Position: refs/heads/master@{#595741}

We add integration test coverage for PREFERENCES under pseudo-USS, and
factor out some duplicated code to a newly introduced FeatureToggler, a
helper class to run tests with a feature switch enabled and disabled.

Bug: 870624
Change-Id: I6b1b446439969d5c6e948e21ca160876e14c5cdb
Reviewed-on: https://chromium-review.googlesource.com/1253762
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595740}

Bug: 851163
Change-Id: Ie02bf11865d1f84254d14723dfd55e26c1987609
Reviewed-on: https://chromium-review.googlesource.com/1256012
Commit-Queue: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595739}

In CL:1195175 we change the formula for Vaapi VEA. However, the
formula still failed at small resolution. According to the
investigation at crbug.com/889739 comment 1 and 2, using the fixed
buffer size might be the choice before we can update the buffer size
when the bitrate and framerate are changed.

Also, Because this function is general for Vaapi VEA and V4L2 VEA, we
move it to gpu_video_accelerator_util.

BUG=b:113309237
BUG=chromium:889739
TEST=pass VideoEncoderTest CTS on eve and scarlet device
TEST=pass RTC lookback on eve at H264 HD
TEST=pass VEA unittest on eve

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I0aa6fd8b67c19ad93bae6e62430105dc9ccf6a80
Reviewed-on: https://chromium-review.googlesource.com/1253315
Commit-Queue: Chih-Yu Huang <akahuang@chromium.org>
Reviewed-by: Pawel Osciak <posciak@chromium.org>
Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595738}

This reverts commit a9d61b8e.

Reason for revert: flaky test

Original change's description:
> Implement RTCIceTransport.onselectedcandidatepairchange
> 
> Bug: 864871
> Change-Id: I710b18f8644be51d08b33b9852c00f4fbacec286
> Reviewed-on: https://chromium-review.googlesource.com/1208961
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Reviewed-by: Henrik Boström <hbos@chromium.org>
> Reviewed-by: Harald Alvestrand <hta@chromium.org>
> Commit-Queue: Steve Anton <steveanton@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#595700}

TBR=dcheng@chromium.org,hta@chromium.org,haraken@chromium.org,hbos@chromium.org,steveanton@chromium.org

Change-Id: I946ade2587e49b3273d9dd303a3e383e8f5f16a0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 864871
Reviewed-on: https://chromium-review.googlesource.com/1256622Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Steve Anton <steveanton@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595737}

https://webrtc.googlesource.com/src.git/+log/40b52f789661..ee216640ddcc


git log 40b52f789661..ee216640ddcc --date=short --no-merges --format='%ad %ae %s'
2018-10-02 buildbot@webrtc.org Roll chromium_revision 7d2cf7c4..81efb6d0 (595610:595716)


Created with:
  gclient setdep -r src/third_party/webrtc@ee216640ddcc

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng

BUG=chromium:None
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I7f6f9edbe610f5d0f71de33a62a81695ed8a7a7e
Reviewed-on: https://chromium-review.googlesource.com/1256227Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#595736}

We leverage the recently introduced layer that allows integrating
legacy SyncableService implementations within the newest architecture,
USS. This requires forking the custom controller, because a different
class hierarchy is used.

The new codepath is behind feature toggle
kSyncPseudoUSSHistoryDeleteDirectives.

Bug: 870624
Change-Id: Ief8fb0d5f5d0472aeea1e0edf42e905632bc33fb
Reviewed-on: https://chromium-review.googlesource.com/1251262Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595735}

The crash stack shows OnGridEmpty being called because of WindowDestroyed
while overview is shutting down because of leaving tablet mode.

The feedbacks report say this is play store related, but i have been
unable to reproduce.

This cl introduces a early exit in OnGridEmpty if overview is currently
shutting down. The cause seems like play store is getting destroyed while
in overview tablet and perhaps causing a race condition, but we should
prevent overview from crashing if play store closes its window
unexpectedly.

Test: none
Bug: 881089
Change-Id: I8e8daceb53d2ac56f92662b14d33fd86979dff25
Reviewed-on: https://chromium-review.googlesource.com/1256168Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595734}

Add sendBrowserTestCommand that expects a 'string' result: this helper
retries until a 'string' result is received, and logs errors.

Update sendTestMessage docs (change message -> command) and update the
test extension harness to use sendBrowserTestCommand.

Bug: 891148
Change-Id: I5840668919672e68787eccd8dece3eae5f2d8c45
Reviewed-on: https://chromium-review.googlesource.com/1256482Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595733}

FileApp QuickView has an [open] attribute, present when it (QuickView)
is open, and removed when it's not open. Verify the attribute appears,
and disappears, for all quick_view.js tests.

No change in behavior, no new tests.

Bug: 891150
Change-Id: If90ae81cd60cd350497dece3896173f432571ccc
Reviewed-on: https://chromium-review.googlesource.com/1256465Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595732}

https://chromium.googlesource.com/catapult.git/+log/2ba11d1c2b02..95ed233ed1a3


git log 2ba11d1c2b02..95ed233ed1a3 --date=short --no-merges --format='%ad %ae %s'
2018-10-02 sadrul@chromium.org tracing: Avoid rAF callbacks when hidden.


Created with:
  gclient setdep -r src/third_party/catapult@95ed233ed1a3

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I7076194fb63ea4c393a28649f4c43d23bcd2c1ab
Reviewed-on: https://chromium-review.googlesource.com/1256025Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#595731}

Previously, the snapshot was displayed during disappearing animation.

We thought we were showing the recreated layer during the animation (see
L819). But that code didn't work for some reason and, actually the
shapshot was visible instead.

And after that, I added the code to hide snapshot correctly
(crrev.com/a128a1b9) and the issue became obvious.

This CL reverts the CL to hide snapshot (crrev.com/a128a1b9) for
temporary solution, and removes the unworking code (L819). I will
consider another solution later.

Bug: 890701
Change-Id: Ia5f1565408c2d13ceae6e9886a9cc1088bfed40b
Reviewed-on: https://chromium-review.googlesource.com/1256385Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595730}

Add a tall html document for scrolling tests. No change in behavior so
no new tests, just adding a resource.

Bug: 891150
Change-Id: I8069e481c098aae21564e5e3ba43e52b12372a04
Reviewed-on: https://chromium-review.googlesource.com/1256463Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595729}

Before this patch the DevToolsAgentHost was left with a pointer to
deleted client when Autofill Assistant finished, causing a crash when
the tab was destroyed.

This patch fixes that issue by having the client detach itself when it
is deleted.

Bug: 806868
Change-Id: Id10f0ba7fdaa0216d7b3053c25d965c7ce02bcc7
Reviewed-on: https://chromium-review.googlesource.com/1253106
Commit-Queue: Stephane Zermatten <szermatt@chromium.org>
Reviewed-by: Ganggui Tang <gogerald@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595728}

https://webrtc.googlesource.com/src.git/+log/957c62e0d63e..40b52f789661


git log 957c62e0d63e..40b52f789661 --date=short --no-merges --format='%ad %ae %s'
2018-10-01 buildbot@webrtc.org Roll chromium_revision 1190491c..7d2cf7c4 (595509:595610)
2018-10-01 orphis@webrtc.org Add support for send_encodings parameters in addTransceiver
2018-10-01 buildbot@webrtc.org Roll chromium_revision 148156b3..1190491c (595385:595509)
2018-10-01 ssilkin@webrtc.org Configure frame references in VP9 encoder wrapper.


Created with:
  gclient setdep -r src/third_party/webrtc@40b52f789661

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng

BUG=chromium:None,chromium:None
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Iafd0fc7e1e8f62417ce4d6d63d0b187b616af91e
Reviewed-on: https://chromium-review.googlesource.com/1256224Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#595727}

With the advent of HTTPS Server Previews, we need to remove the "not
HTTPS" verbage from these strings. See the bug for more info and where
I got the strings.

Bug: 889684
Change-Id: I6d3669f30415396a68b81e316a9cc3435fc33f37
Reviewed-on: https://chromium-review.googlesource.com/1255682Reviewed-by: Doug Arnett <dougarnett@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595726}

LazyThreadControllerForTest makes it hard to write tests related to task
runners. We aim to remove this class, and this CL is one of the steps.

In media unittests, LazyThreadControllerForTest is not necessary. Use
WebThreadScheduler::CreateMainThreadScheduler instead.

Bug: 870606
Change-Id: I0976c4db02e466f06247bf5a82654734f6c7d7bd
Reviewed-on: https://chromium-review.googlesource.com/1250684Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595725}

There is no need to use SingleThreadTaskRunnerForTesting here.

Bug: 870606
Change-Id: I2219ece19db82e1636f2cb83eb4570dd1d09b08f
Reviewed-on: https://chromium-review.googlesource.com/1253524Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595724}

Methods called in DestroyTask() assume that the input and output queues
have been acquired. However this is only true if Initialize() has been
successfully invoked, which only happens if a V4L2 codec device has been
found. Consequently, the V4L2VDA crashes on every non-V4L2 platform.

Fix this by explicitly checking that the queues have been acquired in
the relevant methods. Also add a few DCHECK() that check our assumptions
about the presence of input and output queues to make the code sturdier.

BUG=890952
TEST=Checked that VDA unittest was passing on Eve and Hana.

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ibfa39a85486330c4daa1c0d16c0051796c0011c2
Reviewed-on: https://chromium-review.googlesource.com/1256387
Commit-Queue: Alexandre Courbot <acourbot@chromium.org>
Reviewed-by: Pawel Osciak <posciak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595723}

Bug: 887888
Change-Id: I51557e114a1385e75476bae20dd8843c383c1b26
Reviewed-on: https://chromium-review.googlesource.com/1253103
Commit-Queue: John Budorick <jbudorick@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595722}

The logic changes depending on this histogram have not landed,
so let us keep it around for a bit longer.

BUG=884869

Change-Id: Idad11e54709533ce11e5b154aa06b16c003ced71
Reviewed-on: https://chromium-review.googlesource.com/1256203Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595721}

Bug: 884961
Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi
Change-Id: I4c0bbf99bf369e53f19b0566a8eac68636c69153
Reviewed-on: https://chromium-review.googlesource.com/1256009
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595720}

Having a large amount of <script> tags on a page with an invalid type
for execution (e.g. text/html) triggers the same path for event loop
yielding as JavaScript tags, causing slowness due to parser yields and
unnecessarily aggressive chunking. Avoid performing this logic if the
ScriptLoader can't recognize the script type.

This reduces the amount of time it takes for DOMContentLoaded in the script
attachment for issue 873648 from 367ms to 208ms, similar to the div attachment's
209ms.

R=kouhei@chromium.org

Bug: 873648
Change-Id: I4c7ea76feb2034f5ff97fe08b481c790b9a35122
Reviewed-on: https://chromium-review.googlesource.com/1247230Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Commit-Queue: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595719}

Nothing inherits from the Mac MenuController, except its own tests.
It also sends out some notifications that were once used by a test,
which was recently deleted.

Bug: 832676
Change-Id: Ie95206a3a17461c41683422d61f5a18e4ae5c95a
Reviewed-on: https://chromium-review.googlesource.com/1250466Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595718}

https://skia.googlesource.com/skia.git/+log/083bc1576a0e..16c9216905c1


git log 083bc1576a0e..16c9216905c1 --date=short --no-merges --format='%ad %ae %s'
2018-10-02 reed@google.com remove LEGACY_SVG code, as no one defines that flag anymore.


Created with:
  gclient setdep -r src/third_party/skia@16c9216905c1

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
TBR=mtklein@chromium.org

Change-Id: Ib325eecbe8973bf4cde4907cc49a749aed4fe0d4
Reviewed-on: https://chromium-review.googlesource.com/1256225Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#595717}