- 28 Apr, 2017 3 commits
-
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/67894d267da3..770ad6af2778 $ git log 67894d267..770ad6af2 --date=short --no-merges --format='%ad %ae %s' 2017-04-27 dtu [pinpoint] Add repo mappings to Dep object. 2017-04-27 ashleymarie Rewrite path to suppress a blocking crash resume dialog on mac 2017-04-27 simonhatch Dashboard - Default improvements to showing on group-report-page. Created with: roll-dep src/third_party/catapult Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I3dd325aec09ce0831d6a462637c34751c4d267a7 Reviewed-on: https://chromium-review.googlesource.com/489606 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#467802}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/827db14d7f3d..f452f56021f2 $ git log 827db14d7..f452f5602 --date=short --no-merges --format='%ad %ae %s' 2017-04-27 caryclark move pdfium skia build forward to match chrome 2017-04-26 tsepez Remove more |new|s, part 2 Created with: roll-dep src/third_party/pdfium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Change-Id: Ic822c1ec46a7c5cab27de3992aa49e62f554f9b7 Reviewed-on: https://chromium-review.googlesource.com/489664 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#467801}
-
Dirk Pranke authored
TBR=tandrii@chromium.org BUG=716089 Review-Url: https://codereview.chromium.org/2848653004 . Cr-Commit-Position: refs/heads/master@{#467800}
-
- 27 Apr, 2017 37 commits
-
-
Andrii Shyshkalov authored
NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=716089 TBR=dpranke@chromium.org,andybons@chromium.org Review-Url: https://codereview.chromium.org/2847903002 . Cr-Commit-Position: refs/heads/master@{#467799}
-
ntfschr authored
Revert of SafeBrowsing: update interstitial layouts (patchset #7 id:160001 of https://codereview.chromium.org/2837233002/ ) Reason for revert: Bot breakages Original issue's description: > Reland of SafeBrowsing: update interstitial layouts (patchset #1 id:1 of https://codereview.chromium.org/2842633002/ ) > > Reason for revert: > Fixing build issues > > Original issue's description: > > Revert of SafeBrowsing: update interstitial layouts (patchset #7 id:120001 of https://codereview.chromium.org/2788323002/ ) > > > > Reason for revert: > > This looks like the cause of failures here: https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29 > > > > First seen here: > > https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/37590 > > > > Original issue's description: > > > SafeBrowsing: change interstitial sizes > > > > > > This CL changes the CSS max-height, max-width, etc. dimensions for > > > determining when to use mobile vs. desktop interstitial layouts. In > > > particular, it targets: > > > > > > * wide and short views -> mobile landscape > > > * skinny and tall views -> mobile portrait > > > * wide and medium-height -> mobile landscape (w/ details on the same page) > > > > > > The phablet layout has been removed because it seems to actually be better > > > to just use the mobile layout instead. > > > > > > This also allows the mobile layout to remain centered even for very wide > > > views (parts of it were left-justified before), and reduces the > > > top-margin for the icon in the mobile layout, since we were leaving a > > > huge gap. > > > > > > BUG=707481 > > > > > > Review-Url: https://codereview.chromium.org/2788323002 > > > Cr-Commit-Position: refs/heads/master@{#466746} > > > Committed: https://chromium.googlesource.com/chromium/src/+/2f0527c9fcfdb3b53628acec1b3195563f71ec51 > > > > TBR=edwardjung@chromium.org,nparker@chromium.org,ntfschr@chromium.org > > # Skipping CQ checks because original CL landed less than 1 days ago. > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > BUG=707481 > > > > Review-Url: https://codereview.chromium.org/2842633002 > > Cr-Commit-Position: refs/heads/master@{#466811} > > Committed: https://chromium.googlesource.com/chromium/src/+/06dfd71d425ac5b0c7cef3060aee354946dc13b9 > > TBR=edwardjung@chromium.org,nparker@chromium.org,hcarmona@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=707481 > > Review-Url: https://codereview.chromium.org/2837233002 > Cr-Commit-Position: refs/heads/master@{#467789} > Committed: https://chromium.googlesource.com/chromium/src/+/9a822f4b8c9d7d1ec7df123e48d24118ad102f00 TBR=edwardjung@chromium.org,felt@chromium.org,jialiul@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=707481 Review-Url: https://codereview.chromium.org/2848483004 Cr-Commit-Position: refs/heads/master@{#467798}
-
https://codereview.chromium.org/2850553003/Andrii Shyshkalov authored
Reason for revert: CQ draining actually doesn't work :( Original issue's description: > CQ: start draining CQ. > > TBR=dpranke@chromium.org,andybons@chromium.org > NOTRY=True > NOPRESUBMIT=True > BUG=716089 > > Review-Url: https://codereview.chromium.org/2850553003 > Cr-Commit-Position: refs/heads/master@{#467795} > Committed: https://chromium.googlesource.com/chromium/src/+/ae8025b8658d55b0f6b74956f1b2381695a3c991 R=dpranke@google.com TBR=andybons@chromium.org, dpranke@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=716089 Review-Url: https://codereview.chromium.org/2850703002 . Cr-Commit-Position: refs/heads/master@{#467797}
-
Mark Pearson authored
Tested by enabling clipboard provider and the clipboard interactively on a device. Clipboard suggestions are persisted to and restored from prefs, which works even if I kill Chrome. I also added LOG(INFO) lines during this and saw the writes and reads happening at the correct time and with the right values. BUG=711574 R=bauerb@chromium.org, dcheng@chromium.org Review-Url: https://codereview.chromium.org/2832263002 . Cr-Commit-Position: refs/heads/master@{#467796}
-
tandrii authored
TBR=dpranke@chromium.org,andybons@chromium.org NOTRY=True NOPRESUBMIT=True BUG=716089 Review-Url: https://codereview.chromium.org/2850553003 Cr-Commit-Position: refs/heads/master@{#467795}
-
donnd authored
Fixes recent tablet failures. We have two tablet tests on long-press having the selection become empty after a sequence that includes selecting. For some reason the latest CS seems to change to an empty string instead of null so the tests fail on M. Not sure what the underlaying cause is, but seems to work fine to just check that the text is empty rather than checking explicitly for null. BUG=715978 TBR=twellington Review-Url: https://codereview.chromium.org/2844063006 Cr-Commit-Position: refs/heads/master@{#467794}
-
ericrk authored
Currently GPU Image Decode Controller uses a base::RefCounted object. This object isn't thread safe, which is fine, as GPUIDC holds a lock during access. However, the RefCounted object can't detect that the usage is safe and raises a DCHECK. This change just makes the object a RefCountedThreadSafe. Ref/Unref should be rare enough that this won't have a big impact. And is easier than working around the DCHECK in another way. R=vmpstr@chromium.org BUG=714245 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2836703003 Cr-Commit-Position: refs/heads/master@{#467793}
-
thakis authored
It got lost in https://codereview.chromium.org/2489443002/ (see changes to components/offline_pages/BUILD.gn and components/offline_pages/core/BUILD.gn in that change). BUG=654635,661774 Review-Url: https://codereview.chromium.org/2849513003 Cr-Commit-Position: refs/heads/master@{#467792}
-
yusufo authored
Adds DigitalAssetLinks handler which queries digitalassetlinks.googleapis.com/ for verifying the relationship between an Android app and a web domain. This is added in a new component digital_asset_links since this API is a generic web API for checking Android-Web relationships. It may be useful for iOS and ChromeOS as well. The component currently depends on base and net. Then custom tabs uses this handler for verifying postMessage origin declared by the client app when they send requestPostMessageChannel. This enabled third party apps to use postMessage related APIs with secure and verified origin declaration. BUG=704975 Review-Url: https://codereview.chromium.org/2767333006 Cr-Commit-Position: refs/heads/master@{#467791}
-
gogerald authored
The expiration days is set to 90 days. Note that the expired cached manifest will be refreshed by downloading it online. BUG=708508 Review-Url: https://codereview.chromium.org/2845753003 Cr-Commit-Position: refs/heads/master@{#467790}
-
ntfschr authored
Reland of SafeBrowsing: update interstitial layouts (patchset #1 id:1 of https://codereview.chromium.org/2842633002/ ) Reason for revert: Fixing build issues Original issue's description: > Revert of SafeBrowsing: update interstitial layouts (patchset #7 id:120001 of https://codereview.chromium.org/2788323002/ ) > > Reason for revert: > This looks like the cause of failures here: https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29 > > First seen here: > https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/37590 > > Original issue's description: > > SafeBrowsing: change interstitial sizes > > > > This CL changes the CSS max-height, max-width, etc. dimensions for > > determining when to use mobile vs. desktop interstitial layouts. In > > particular, it targets: > > > > * wide and short views -> mobile landscape > > * skinny and tall views -> mobile portrait > > * wide and medium-height -> mobile landscape (w/ details on the same page) > > > > The phablet layout has been removed because it seems to actually be better > > to just use the mobile layout instead. > > > > This also allows the mobile layout to remain centered even for very wide > > views (parts of it were left-justified before), and reduces the > > top-margin for the icon in the mobile layout, since we were leaving a > > huge gap. > > > > BUG=707481 > > > > Review-Url: https://codereview.chromium.org/2788323002 > > Cr-Commit-Position: refs/heads/master@{#466746} > > Committed: https://chromium.googlesource.com/chromium/src/+/2f0527c9fcfdb3b53628acec1b3195563f71ec51 > > TBR=edwardjung@chromium.org,nparker@chromium.org,ntfschr@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=707481 > > Review-Url: https://codereview.chromium.org/2842633002 > Cr-Commit-Position: refs/heads/master@{#466811} > Committed: https://chromium.googlesource.com/chromium/src/+/06dfd71d425ac5b0c7cef3060aee354946dc13b9 TBR=edwardjung@chromium.org,nparker@chromium.org,hcarmona@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=707481 Review-Url: https://codereview.chromium.org/2837233002 Cr-Commit-Position: refs/heads/master@{#467789}
-
chengx authored
The JumpList class is an observer of the TopSites class as well as the TabRestoreService class. Each time TopSites gets updated or a tab is removed, the JumpList is updated. Chrome JumpList has two categories, namely "Most visited" and "Recently closed", whose icon files are updated altogether in a single JumpList update run. The icon files are updated in the way that old icons are deleted followed by new icons' creation. However, updating icons for both categories together is unnecessary. When the TopSites class has changes, it affects the "Most visited" category only; while when the TabRestoreService class has changes, it affects the "Recently closed" only. In this sense, we should update each category on demand rather than in every JumpList update even when there's no change for that category. Initially, each JumpList update involves 24 icons' deletion and 24 icons' creation. After crrev.com/2816113002 (Fix to not create jumplist icon files that aren't used by shell) was landed, this number was reduced from 24*2 to 10*2. This CL further reduced this number to ~4*2 per JumpList update. As each icon file is 28 KB, these two CLs together have reduced the disk IO from 48*28=1344 KB to 8*28=224 KB by 83% per JumpList update. This CL also relieves the following issue. Currently, notifying the OS about the JumpList update takes place after the old icon files are deleted. This order is critical as it can avoid the JumpList folder from getting accumulated endlessly. On the other hand, if the OS notification step fails which does happen sometimes according to UMA data, the old JumpList will still be used. However, since the old icons have been deleted, there'll be nothing but the background color showing up where the icons should show up. This doesn't look good. With this CL, since only one category is updated for almost all the time, we'll still have icons for the other category if the OS notification step fails. That says, we'll still have about half of the icons instead of nothing, which's clearly better. This CL changes the JumpList related directory. Since the icon files for the two categories are dealt with separately, it's more efficient to put them in separate folders rather than in a single JumpListIcons folder. This CL introduces two new folders JumpListIconsMostVisited and JumpListIconsRecentClosed for this purpose. As the JumpListIcons folder is no longer needed, this CL posts a background task to delete it. BUG=40407, 179576, 715902, 716115 Review-Url: https://codereview.chromium.org/2836873003 Cr-Commit-Position: refs/heads/master@{#467788}
-
khorimoto authored
[CrOS Tether] Create TetherHostResponseRecorder, which records ConnectTetheringResponses and TetherAvailabilityResponses from tether hosts. This takes some existing functionality out of HostScanDevicePrioritizer and extends it to record the IDs of all ConnectTetheringResponses received instead of only the most recent one. This refactor is needed because the networking stack needs to know whether to show a warning dialog (stating that tethering will use mobile data and battery on the host device) before connecting to a device for the first time. Thus, it is necessary to record all previously received ConnectTetheringResponses instead of only the most recent one. Because this logic is unrelated to the host prioritization logic, I moved it to its own class. BUG=672263 Review-Url: https://codereview.chromium.org/2844973002 Cr-Commit-Position: refs/heads/master@{#467787}
-
warx authored
Revert of [Chromoting] Retrieve process resource usage (ProcessStats) and its tests (patchset #9 id:240001 of https://codereview.chromium.org/2775983003/ ) Reason for revert: Breaks x86-alex-tot-chrome-pfq-informational build: https://uberchromegw.corp.google.com/i/chromeos.chrome/builders/x86-alex-tot-chrome-pfq-informational/builds/23688 Original issue's description: > [Chromoting] Retrieve process resource usage (ProcessStats) and its tests > > ProcessStatsStub is an interface to receive process resource usage information > from a ProcessStats. > > ProcessResourceUsage is a structure to store the resource usage of one process. > AggregatedProcessResourceUsage is a structure to store the resource usgaes of > several processes. > > ProcessStatsAgent is an interface to retrieve resource usage of one process. > CurrentProcessStatsAgent is a ProcessStatsAgent implementation to retrieve > resource usage from current process. > ForwardProcessStatsAgent receives resource usage from a third-party and forwards > the latest usage as a ProcessStatsAgent. > > ProcessStatsSender is a class to regularly report resource usages from various > ProcessStatsAgent implementations to a ProcessStatsStub. It merges several > non-empty ProcessResourceUsage into one AggregatedProcessResourceUsage. > This is typical useful on Windows: we need to calculate the resource usages from > both network process and desktop process. > > R=sergeyu@chromium.org, jamiewalch@chromium.org > BUG=650926 > > Review-Url: https://codereview.chromium.org/2775983003 > Cr-Commit-Position: refs/heads/master@{#467753} > Committed: https://chromium.googlesource.com/chromium/src/+/5928f440f84065ab45f848dcd135e3c2f52ca5bb TBR=jamiewalch@chromium.org,sergeyu@chromium.org,joedow@chromium.org,zijiehe@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=650926 Review-Url: https://codereview.chromium.org/2847743004 Cr-Commit-Position: refs/heads/master@{#467786}
-
bsazonov authored
AndroidSyncSettingsTest depends on implementation details of MockAccountManager to wait for async method completion. These necessary details were removed by 4a6245e6. This CL fixes this test by adding callback to AndroidSyncSettings.updateAccount. BUG=605567 Review-Url: https://codereview.chromium.org/2847663003 Cr-Commit-Position: refs/heads/master@{#467785}
-
tsunghung authored
Before we have the chance to fully implement the function, we need a quick fix for (E)AC3. No ATV we know of that supports (E)AC3 decoder, so it relies on the audio sink device. BUG=Internal b/36896359 Review-Url: https://codereview.chromium.org/2845173002 Cr-Commit-Position: refs/heads/master@{#467784}
-
stevenjb authored
This CL: * Fixes the subpage arrow for bluetooth and focus it correctly. * Provides focus logic for internet-page -> internet-subpage -> internet-detail-page. * Fixes keyboard navigation to details page from cr-network-list-item BUG=714350 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2841873004 Cr-Commit-Position: refs/heads/master@{#467783}
-
zmin authored
Reland of name kDisableGestureRequirementForMediaPlayback and make it a test-only flag. (patchset #1 id:1 of https://codereview.chromium.org/2851453003/ ) Reason for revert: Reland the original patch as timvolodine and I believe it's not related to the compile failure early today. Original issue's description: > Revert of Rename kDisableGestureRequirementForMediaPlayback and make it a test-only flag. (patchset #2 id:20001 of https://codereview.chromium.org/2843913003/ ) > > Reason for revert: > broke clang-clankium-tot-builder crbug.com/716075 > > (FullscreenWebContentsActivityTest not updated) > > Original issue's description: > > Rename kDisableGestureRequirementForMediaPlayback and make it a test-only flag. > > > > The flag should only be set by tests and will allow all autoplay related > > restrictions such as autoplay policy and background playback to be > > disabled. > > > > BUG=714676 > > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > > > > Review-Url: https://codereview.chromium.org/2843913003 > > Cr-Commit-Position: refs/heads/master@{#467692} > > Committed: https://chromium.googlesource.com/chromium/src/+/d1f8f6ca6c8b7cdaf02150099ce6db0cfc7223f6 > > TBR=dalecurtis@chromium.org,jam@chromium.org,mlamouri@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=714676 > > Review-Url: https://codereview.chromium.org/2851453003 > Cr-Commit-Position: refs/heads/master@{#467715} > Committed: https://chromium.googlesource.com/chromium/src/+/54e35df000303d1a3b5214db2232aa2fb5c12e3a TBR=dalecurtis@chromium.org,jam@chromium.org,mlamouri@chromium.org,timvolodine@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=714676 Review-Url: https://codereview.chromium.org/2845973005 Cr-Commit-Position: refs/heads/master@{#467782}
-
fdoray authored
ScopedTaskEnvironment allows usage of ThreadTaskRunnerHandle and base/task_scheduler/post_task.h within its scope. It should be instantiated in everytest that uses either of these APIs (i.e. no test should instantiate a MessageLoop directly). Motivation for ScopedTaskEnvironment can be found in: https://docs.google.com/document/d/1QabRo8c7D9LsYY3cEcaPQbOCLo8Tu-6VLykYXyl3Pkk/edit BUG=708584 R=gab@chromium.org TBR=stevenjb@chromium.org Review-Url: https://codereview.chromium.org/2845973003 Cr-Commit-Position: refs/heads/master@{#467781}
-
khushalsagar authored
Mouse drag gestures on android are delivered using a stream of ACTION_MOVE events. If the view does not consume the ACTION_DOWN event that starts the gesture, it will not receive the following move events. Consume this event in the EventForwarder to ensure the ContentView gets the complete gesture. BUG=714845 Review-Url: https://codereview.chromium.org/2842823002 Cr-Commit-Position: refs/heads/master@{#467780}
-
zpeng authored
This CL adds PRESUBMIT script to chrome/android/webapk/shell_apk so that any time code in chrome/android/webapk/shell_apk/ changes, chrome/android/webapk/shell_apk/shell_apk_version.gni must be updated accordingly. See comments in presubmit.py for detailed rules. BUG=708053 Review-Url: https://codereview.chromium.org/2830343002 Cr-Commit-Position: refs/heads/master@{#467779}
-
fjhenigman authored
Mark as failing on Linux Intel HD 530: WebglConformance_deqp_functional_gles3_texturefiltering_3d_formats_0[4589]. BUG=715881 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2849443002 Cr-Commit-Position: refs/heads/master@{#467778}
-
hiroshige authored
BUG=715376 Review-Url: https://codereview.chromium.org/2843873002 Cr-Commit-Position: refs/heads/master@{#467777}
-
ben authored
Also removes some extraneous interface_registry.h #includes. R=rockot@chromium.org Review-Url: https://codereview.chromium.org/2844063003 Cr-Commit-Position: refs/heads/master@{#467776}
-
robertogden authored
BUG=715644 Review-Url: https://codereview.chromium.org/2852533002 Cr-Commit-Position: refs/heads/master@{#467775}
-
ccameron authored
TBR=thakis BUG=709341 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2816173002 Cr-Commit-Position: refs/heads/master@{#467774}
-
dgn authored
Fixes a bug causing suggestions to be added to the bottom sheet's Home tab every time it's opened. BUG=689962 Review-Url: https://codereview.chromium.org/2848663002 Cr-Commit-Position: refs/heads/master@{#467773}
-
meacer authored
We are suspecting that some error reports don't get sent properly even when the success callback runs. For that reason, we'll check the response code and classify the upload as failure if the response code isn't as expected. BUG=682933 Review-Url: https://codereview.chromium.org/2648713002 Cr-Commit-Position: refs/heads/master@{#467772}
-
msarett authored
NOTRY=true TBR=reed@google.com BUG=skia:6535 Review-Url: https://codereview.chromium.org/2850503003 Cr-Commit-Position: refs/heads/master@{#467771}
-
mdjones authored
In order to make transitions between bottom sheet contents look good, a background color was set on the toolbar container. This causes an issue in the tab switcher which needs the toolbar to be transparent. This change conditionally sets the background color of the toolbar container while the content transition animation is running. BUG=702717 Review-Url: https://codereview.chromium.org/2846883003 Cr-Commit-Position: refs/heads/master@{#467770}
-
dpranke authored
Revert of Ensure that builders that use goma strip absolute paths by default. (patchset #1 id:1 of https://codereview.chromium.org/2837863005/ ) Reason for revert: Reverting in case this is related to the goma errors in https://crbug.com/716089 Original issue's description: > Ensure that builders that use goma strip absolute paths by default. > > This CL tweaks the MB configs so that any builder that is using goma > also sets strip_absolute_paths_from_debug_symbols_by_default=true. > This helps ensure that we get the best goma cache hit rate possible. > We don't just make the default equal to use_goma=true because doing > so may make it harder for devs to debug binaries, and we want devs > to be able to both debug binaries and use goma by default; the > tradeoff is that their builds are slightly slower. > > R=thakis@chromium.org, jochen@chromium.org > BUG=603286, 712790 > > Review-Url: https://codereview.chromium.org/2837863005 > Cr-Commit-Position: refs/heads/master@{#467574} > Committed: https://chromium.googlesource.com/chromium/src/+/050dbe550d14e99ad4e83093d4f4e79642b9edc3 TBR=jochen@chromium.org,thakis@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=603286, 712790 Review-Url: https://codereview.chromium.org/2843403004 Cr-Commit-Position: refs/heads/master@{#467769}
-
mdjones authored
This change adds logic inside the OverlayPanelEventFilter to make sure that at least one down event is being passed to the internal gesture detector before a stream starts. BUG=715183 Review-Url: https://codereview.chromium.org/2843263003 Cr-Commit-Position: refs/heads/master@{#467768}
-
nasko authored
These tests are failing consistently on the Site Isolation FYI bots. Disabling them while they are investigated and fixed. BUG=710098,716085 Review-Url: https://codereview.chromium.org/2845093004 Cr-Commit-Position: refs/heads/master@{#467767}
-
dfalcantara authored
Add a dialog that can be triggered via LocaleManager that allows a user to choose their default search engine from a randomized list. DefaultSearchEnginePromoDialog: * Add a basic dialog that forces a user to select a default search engine. This dialog only shows up for the "existing user" case and (currently) randomizes the search engines available as defined in the TemplateUrlService. * Add the ability to show the DefaultSearchEnginePromoDialog from the LocaleManager. It currently never fires because the logic hasn't landed, but it is triggered from ChromeTabbedActivity and SearchActivity. Things to do: - Still trying to figure out how to test this. Screenshots: https://drive.google.com/corp/drive/u/0/folders/0B7c8ZkXVwskDRmlnZ1g0LXVpMGM BUG=714223,712836,712833 Review-Url: https://codereview.chromium.org/2838833002 Cr-Commit-Position: refs/heads/master@{#467766}
-
petewil authored
A Sheriff disabled these tests when they were found to be flaky. I've fixed two problems, an uninitialized pointer which might have been causing a crash (previous changelist), and in this changelist a missing call to PumpLoop() causing the test to fail when race conditions happened. BUG=712941 Review-Url: https://codereview.chromium.org/2837873006 Cr-Commit-Position: refs/heads/master@{#467765}
-
vadimt authored
4 possible dispositions are 4 combinations of Ctrl and Shift, combined with mouse click (or Enter on a link), as per this: https://support.google.com/chromebook/answer/183101?hl=en Bug=712331 Review-Url: https://codereview.chromium.org/2842413002 Cr-Commit-Position: refs/heads/master@{#467764}
-
shess authored
The 3.17.0 import seems to have stuck, so I think rollback is pretty unlikely at this point. BUG=701518 TBR=pwnall@chromium.org Review-Url: https://codereview.chromium.org/2846743003 Cr-Commit-Position: refs/heads/master@{#467763}
-