GitLab

BUG=331125
R=navabi@chromium.org, navabi@google.com, skyostil@chromium.org

Review URL: https://codereview.chromium.org/97983005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243372 0039d316-1c4b-4281-b951-d872f2087c98

Accidentally left disabled when the underlying issue was resolved.

BUG=172786,156800

Review URL: https://codereview.chromium.org/118333004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243370 0039d316-1c4b-4281-b951-d872f2087c98

Fix perf and build time output. Previously, times reported were a lot smaller than they really were since we weren't filtering out skipped steps and they were getting averaged in with actual build/run times. This is just a fix in output, no changes to logic.

BUG=
NOTRY=true

Review URL: https://codereview.chromium.org/126253002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243369 0039d316-1c4b-4281-b951-d872f2087c98

And into TransientWindowManager. Additionally moves handling of NULL
layer stacking into TransientStackingWindowClient. The tests that were
exercising these code paths have all been moved to ui/views/corewm.

Also wires up TransientStackingWindowClient in a couple of places that
didn't have it.

The order of removing from transient parent as well as destroying of
transient children is slightly differently than before. To get the
order exactly as it was would require some new specific observer
functions. I'm hoping we don't need those. Hopefully this doesn't
cause issues, if it does I'll revisit.

I ended up exposing convenience functions. That's because typing
something like:

views::corewm::TransientWindowManager::Get(window)->AddTransientChild()

was too much for me. There is also some subtlety in so far as the
Get() function that takes a const Window* may return NULL, where as
non-const never returns NULL.

Lastly I had to make Window friend TransientWindowManager. This is
temporary until I create a specific TransientWindowManagerObserver
that contains the two transient related observer functions in
WindowObserver.

BUG=none
TEST=none
R=ben@chromium.org

Review URL: https://codereview.chromium.org/115453004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243368 0039d316-1c4b-4281-b951-d872f2087c98

This reverts r237591. The added CHECK() breaks the Android WebView and
was added to help diagnose a now-fixed bug that turned out to be
unrelated.

BUG=332079
NOTRY=true

Review URL: https://codereview.chromium.org/106433010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243367 0039d316-1c4b-4281-b951-d872f2087c98

Also remove ChromeURLRequestUserData since no one else is using it.

BUG=304341
R=davidben@chromium.org

Review URL: https://codereview.chromium.org/124383008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243366 0039d316-1c4b-4281-b951-d872f2087c98

Finally remove ResourceRequestInfo::GetAssociatedRenderView. Also remove the shared worker plumbing that existed only to support it.

BUG=304341
R=nasko@chromium.org

Review URL: https://codereview.chromium.org/125513002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243365 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/125773002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243364 0039d316-1c4b-4281-b951-d872f2087c98

BUG=n/a
TEST=compile

Review URL: https://codereview.chromium.org/125553005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243363 0039d316-1c4b-4281-b951-d872f2087c98

BUG=240195

Review URL: https://codereview.chromium.org/124373004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243362 0039d316-1c4b-4281-b951-d872f2087c98

They are not offline available.
See the comments added in the patch and metadata_cache.js.

BUG=none

Review URL: https://codereview.chromium.org/103013004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243361 0039d316-1c4b-4281-b951-d872f2087c98

> IndexedDB: Fix cursor prefetching edge cases
> 
> Cursor prefetch caches must be discarded when other
> requests are made to ensure proper request sequencing.
> Two edge cases were handled improperly if new records
> was written just ahead of the cursor.
> 
> * A reset occurring before the prefetch results were
> received would be ignored; since the newly records
> weren't in the prefetch data, the cursor wouldn't see
> them.
> 
> * A reset occurring after the results are received
> would back up the cursor to before the new records,
> even though the prefetch itself is a "continue"
> and advanced past them already.
> 
> The fix is to reset the cache on receipt if necessary,
> and to ensure the reset state accounts for the implicit
> advance.
> 
> BUG=331570
> 
> Review URL: https://codereview.chromium.org/124323002

TBR=jsbell@chromium.org

Review URL: https://codereview.chromium.org/126263003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243359 0039d316-1c4b-4281-b951-d872f2087c98

> Revert 243291 "[Buildfix] Fix PlatformFileInfo usage in pdf_brow..."
> 
> > [Buildfix] Fix PlatformFileInfo usage in pdf_browsertest.cc
> > 
> > BUG=None
> > TBR=thestig@chromium.org
> > NOTRY=true
> > 
> > Review URL: https://codereview.chromium.org/125973003
> 
> TBR=tzik@chromium.org
> 
> Review URL: https://codereview.chromium.org/126093004

TBR=dxie@chromium.org

Review URL: https://codereview.chromium.org/109733004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243356 0039d316-1c4b-4281-b951-d872f2087c98

Label::OnPaint also draws a focus border, so Link doesn't need to do
it.

BUG=330675
TEST=none
R=ben@chromium.org

Review URL: https://codereview.chromium.org/124553006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243351 0039d316-1c4b-4281-b951-d872f2087c98

When a system menu is showing we continue to get and receive mouse
events while the mouse is over the menu. The tooltip code thinks the
mouse is over the aura::Window and will then show the tooltip. The fix
is to disable tooltips while system menus are showing.

I'm also making the only way to enable/disable tooltips be by way of a
scoper. This should hopefully be less error prone.

BUG=327970
TEST=none
R=varunjain@chromium.org

Review URL: https://codereview.chromium.org/109403008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243350 0039d316-1c4b-4281-b951-d872f2087c98

Fix remaining nits.

BUG=323697

Review URL: https://codereview.chromium.org/125253006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243346 0039d316-1c4b-4281-b951-d872f2087c98

sockets.udp permission is obsolete, as we now depend only on the "sockets" manifest key.

BUG=328973

Review URL: https://codereview.chromium.org/101843008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243345 0039d316-1c4b-4281-b951-d872f2087c98

Cursor prefetch caches must be discarded when other
requests are made to ensure proper request sequencing.
Two edge cases were handled improperly if new records
was written just ahead of the cursor.

* A reset occurring before the prefetch results were
received would be ignored; since the newly records
weren't in the prefetch data, the cursor wouldn't see
them.

* A reset occurring after the results are received
would back up the cursor to before the new records,
even though the prefetch itself is a "continue"
and advanced past them already.

The fix is to reset the cache on receipt if necessary,
and to ensure the reset state accounts for the implicit
advance.

BUG=331570

Review URL: https://codereview.chromium.org/124323002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243344 0039d316-1c4b-4281-b951-d872f2087c98

* Extracted non-Chrome-specific manifest handler registration into
  src/extensions/common/common_manfiest_handlers.cc
* Moved app_shell app load/launch code into ShellExtensionSystem so it can
  signal that the system is ready
* Refactored more of runtime API to use browser context instead of Profile
* Cleaned up or removed some uses of ExtensionService

This allows app_shell to get into the background page loading code before it crashes.

BUG=162530,288226,309909
TEST=existing browser_tests of extension system

Review URL: https://codereview.chromium.org/101203008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243343 0039d316-1c4b-4281-b951-d872f2087c98

BUG=320090
R=abarth@chromium.org, davemoore@chromium.org

Review URL: https://codereview.chromium.org/99623010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243341 0039d316-1c4b-4281-b951-d872f2087c98

BUG=331124
R=isherman@chromium.org

Review URL: https://codereview.chromium.org/123313002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243338 0039d316-1c4b-4281-b951-d872f2087c98

> [Buildfix] Fix PlatformFileInfo usage in pdf_browsertest.cc
> 
> BUG=None
> TBR=thestig@chromium.org
> NOTRY=true
> 
> Review URL: https://codereview.chromium.org/125973003

TBR=tzik@chromium.org

Review URL: https://codereview.chromium.org/126093004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243336 0039d316-1c4b-4281-b951-d872f2087c98

This CL just parses and stores the field for future use.

BUG=324165

Review URL: https://codereview.chromium.org/125553004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243335 0039d316-1c4b-4281-b951-d872f2087c98

This adds a build step to generate mirrored images for use in
right-to-left (RTL) languages. Images are mirrored by flipping the
original image over the vertical axis. Every image must be explicitly
listed as mirrorable or non-mirrorable in a config file.

The goal: ensure that our RTL image assets are always up-to-date.

BUG=290225
NOTRY=true

Review URL: https://codereview.chromium.org/106173002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243332 0039d316-1c4b-4281-b951-d872f2087c98

When setting up the ThreadIdNameManager we need to make a duplicate of the
thread handle on Windows. That handle is currently be leaked as pointed out by
Dr.Memory. This CL closes the handle after the ThreadIdNameManager has removed
the relevant entry.

BUG=315203

Review URL: https://codereview.chromium.org/75133004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243330 0039d316-1c4b-4281-b951-d872f2087c98

We force-include our own logging.h, which includes basictypes.h, which
now includes stdint.h. Without this change, this ends up being
minimal/hacky stdint.h (from sdch/open-vcdiff/vsprojects), which isn't
sufficient for the needs of the rest of basictypes.h.

R=brettw@chromium.org, jar@chromium.org
BUG=138542

Review URL: https://codereview.chromium.org/110273004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243329 0039d316-1c4b-4281-b951-d872f2087c98

In "all or none" mode, return "out of range" if the required amount of
space/data isn't available, unless the other end isn't open (in which
case return "failed precondition"). Don't return "should wait", since
you can't wait for a specified amount of space/data to be available.
(Only return "should wait" when waiting would actually solve your
problem.)

Note: Still have to write docs for the two-phase DataPipe APIs (but I
want to fully test/hash out their semantics first).

R=darin@chromium.org

Review URL: https://codereview.chromium.org/118873004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243327 0039d316-1c4b-4281-b951-d872f2087c98

(Re-landing with fixes from https://codereview.chromium.org/112663007/ )

Activity in Native Client plugins results in IPC messages
sent to the BrowserPpapiHostImpl and routed to call
extensions::ProcessManager::KeepaliveImpulse.

Testing patch, builds on implementation:
https://codereview.chromium.org/61063003/

Design doc:
https://docs.google.com/a/chromium.org/document/d/1mI0lS1rfAf-BAGLmWAEcWy37Xq9dOvgfMx8OqeUMXts/edit#

BUG=298339
No change to mseaborn owned file since last LGTM:

R=yzshen@chromium.org
TBR=mseaborn@chromium.org

Review URL: https://codereview.chromium.org/125353006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243326 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243324 0039d316-1c4b-4281-b951-d872f2087c98

This moves up the <outputs> and <translations> elements to the top
of the grd file to be consistent with other grd files.

R=tedchoc@chromium.org, thakis@chromium.org

Review URL: https://codereview.chromium.org/101463006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243320 0039d316-1c4b-4281-b951-d872f2087c98

This CL moves a few files to the translate component. It also layers the
structure of the component so that it is better suited for iOS.

BUG=331509
TBR=jochen, joi

Review URL: https://codereview.chromium.org/93603006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243319 0039d316-1c4b-4281-b951-d872f2087c98

In Blink r164582 ("Don't set document.title when there is no <head>") Blink
aligns the behavior of the "document.title" property with the HTML specification,
and now disregards users who set the title when no <head> or <title> element
exist yet.

This content_script extension runs at document_start, at which time no DOM is
available yet. Changing this to document_end means that the DOM is available, and
it's thus able to change the page's title (the sole purpose of the extension).

BUG=332106
R=wjmaclean@chromium.org

Review URL: https://codereview.chromium.org/117993006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243317 0039d316-1c4b-4281-b951-d872f2087c98

Static final fields can either be "true" constants, e.g.
  static final int HEIGHT_PX = 30;
  static final String TAG = "MyClass"

or can have mutable state or not "feel" like a constant, e.g.
  static final AtomicInteger sNextId;
  static final Runnable sSuspendTask;

This allows either naming convention, FIELD_NAME or sFieldName, at the
programmer's discretion.

NOTRY=true

Review URL: https://codereview.chromium.org/112023009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243316 0039d316-1c4b-4281-b951-d872f2087c98

This will allow individual cookies and other site data to be deleted via the
CookieTreeModel GUI. As a result of this change, updates to the various
storage systems will be pushed to the canned helpers after creation of the
CookieTreeModel.

Also removes a pimpl for BrowsingDataIndexedDBHelper since no other canned
helpers followed this pattern.

BUG=168996
TEST=No visible changes yet. Deleters covered by unit tests.
TBR=dbeam@chromium.org

Review URL: https://codereview.chromium.org/124183002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243315 0039d316-1c4b-4281-b951-d872f2087c98

This is a long overdue clean up to make future changes in this area
saner. Only shuffling code and these cosmetic changes:

Removed unused SynchronousCompositorImpl* argument from
SynchronousCompositorFactoryImpl::CompositorInitializedHardwareDraw
and SynchronousCompositorFactoryImpl::CompositorReleasedHardwareDraw.

Add virtual SynchronousCompositorFactory destructor.

BUG=
NOTRY=true

Review URL: https://codereview.chromium.org/102963010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243314 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243311 0039d316-1c4b-4281-b951-d872f2087c98

BUG=331991

Review URL: https://codereview.chromium.org/125733003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243309 0039d316-1c4b-4281-b951-d872f2087c98

As with for key and scroll events, change the RootWindowHostDelegate implementation
to use EventProcessor interface for dispatching touch events under-the-hood.

BUG=318879
R=ben@chromium.org

Review URL: https://codereview.chromium.org/110483004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243306 0039d316-1c4b-4281-b951-d872f2087c98

> Add a renderer side version of the referrer check in the net library
> 
> This should hopefully give us enough information to debug the issue
> 
> BUG=331097
> R=battre@chromium.org
> 
> Review URL: https://codereview.chromium.org/105853004

TBR=jochen@chromium.org

Review URL: https://codereview.chromium.org/93803005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243305 0039d316-1c4b-4281-b951-d872f2087c98

The FFmpegDemuxer would only compute the duration at the end of
playback for clips without a duration that contained audio. This was not
being done for video-only streams which resulted inconsistent behavior.
This change simply make the duration computation logic apply to all
stream types.

TEST=FFmpegDemuxerTest.Read_EndOfStream_NoDuration_VideoOnly, FFmpegDemuxerTest.Read_EndOfStream_NoDuration_AudioOnly

Review URL: https://codereview.chromium.org/105503011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243304 0039d316-1c4b-4281-b951-d872f2087c98