- 25 Feb, 2020 40 commits
-
-
Rachel Carpenter authored
To use SetManifestRequestFilter, need to move it to chromeos/components to avoid circular dependencies. This affects os_settings that was also using the function. Also adds the strings that will be used for additional search queries. Bug: b/149720483 Change-Id: Id1fe34dbb6a463963522bd256d0ccfa3366d1e05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062116Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Rachel Carpenter <carpenterr@google.com> Cr-Commit-Position: refs/heads/master@{#744414}
-
Michael Spang authored
This adds new bindings for the following functions [GL_ANGLE_memory_object_fuchsia] glImportMemoryZirconHandleANGLEFn [GL_ANGLE_semaphore_fuchsia] glImportSemaphoreZirconHandleANGLEFn Bug: 766360 Change-Id: I2f9e90fb67674393bcbfe3358f1df6cd57ef3a0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069177Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#744413}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/9aa1a9673a3c..63832e9056ec git log 9aa1a9673a3c..63832e9056ec --date=short --first-parent --format='%ad %ae %s' 2020-02-25 iannucci@chromium.org [vpython] Update depot_tools vpython to match fleet. Created with: gclient setdep -r src/third_party/depot_tools@63832e9056ec If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1051595 Tbr: agable@chromium.org Change-Id: I126812ea4096411f5f12a87a480bfee1f52c098c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072899Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#744412}
-
Fabrice de Gans-Riberi authored
* Add a read-only file, "config-default.json", to the Hub debug directory for the WebEngine component containing the default configuration. * Add a read/write file "config-override.json" to the Hub debug directory for the WebEngine component allowing to override the configuration for all subsequently created Contexts. * Add "blink-settings" as an allowed command-line argument to configurations. Bug: 1014670 Change-Id: I4be28996bcfdd598836aa64c1fc2c59a0ac4432a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032425Reviewed-by:
David Dorwin <ddorwin@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#744411}
-
behdad authored
High confidence intervals are not failing the test anymore (except for control test), so it should also not invalidate the recorded averages. Bug: chromium:1052054 Change-Id: I016bf25c6229102a9b74255d9ee4b6a32fc1e0f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072125 Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#744410}
-
Hesen Zhang authored
Enable client to customize config related to throttling - mainly suppression duration and number of negative action count threshold from client side API - std::unique_ptr<ThrottleConfig> GetThrottleConfig() {...} This API will give client the option to override the fields related to throttling in global config. Internally a Delegate of ImpressionHistoryTracker will be created, and the glue layer NotificationScheduler delegates this request. Cleaned up throttled related parameters from schedule_params, and impression struct and proto. Some task need to do: - Check consecutive negative actions instead of dismiss actions only. - Need to write more detailed unit test to go through whole flow. - May consider adding other way (positive impression - release throttle) - Apply this layer to current existing clients including a more functional web_ui for better test and play purpose. Bug: 1053659 Change-Id: I3c767bd2be9259e74926a83ef5231ab1940b3972 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063253 Commit-Queue: Hesen Zhang <hesen@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#744409}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/4cc54b409feb..da659b374113 git log 4cc54b409feb..da659b374113 --date=short --first-parent --format='%ad %ae %s' 2020-02-25 capn@google.com Fix ANGLE standalone build Created with: gclient setdep -r src/third_party/swiftshader@da659b374113 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I8ac039adb16ac6a7988c0412f95f37886500eee1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072838Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#744408}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f2c28cd7657f..651a1d860c99 git log f2c28cd7657f..651a1d860c99 --date=short --first-parent --format='%ad %ae %s' 2020-02-25 treehugger-gerrit@google.com Merge "Disable HeapprofdEndToEnd and HeapprofdCtsTest." Created with: gclient setdep -r src/third_party/perfetto@651a1d860c99 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I6b0c23de8ecc2c3ec9e1f3a91895d099011a97af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071268Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#744407}
-
Ben Joyce authored
Bug: 1052460 Change-Id: I14505aa242d7e646ec3feb2ab913893c881d34df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072664Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: benjamin joyce <bjoyce@google.com> Cr-Commit-Position: refs/heads/master@{#744406}
-
Yury Semikhatsky authored
This change complements the logic that throttles network navigation in new windows with the logic that allows to pause popup windows that load local content such as javascript: urls. Design document: https://docs.google.com/document/d/1hbTowhyfrf6CaYuNEHjY_OVx2KgZmnbp8kg_wUdGFiA/edit# Bug: 1051687 Change-Id: I7c4f01abaa6c7054f91157ea52cd498940ed1829 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2059127Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Yury Semikhatsky <yurys@chromium.org> Cr-Commit-Position: refs/heads/master@{#744405}
-
Chrome Metrics Logs authored
Updates the expires_after attribute for 99 histograms that show frequent access in the past 90 days. These are the 90% most frequently used histograms over that time that do not already have a date later than or within 60 days of 2020-08-23. Change-Id: I0caef1605a18d874bd81e86f8021982f615406a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072818 Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#744404}
-
Yusuf Sengul authored
Bug: 1054678 Change-Id: I5df40a6f381c5312df9c95a6a52dafd659e077cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067859Reviewed-by:
Tien Mai <tienmai@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Yusuf Sengul <yusufsn@google.com> Cr-Commit-Position: refs/heads/master@{#744403}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: If7e7bce0fccbc7e12d864374a2aa1fd5b6805e19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072840Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#744402}
-
Dong Hwi Lee authored
Change-Id: I8bbfa6893179d4c713b79852400d0f77d1754b1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071294 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#744401}
-
Caleb Rouleau authored
This reverts commit 21245a70. Reason for revert: broke official clank builds: https://ci.chromium.org/p/chrome/builders/ci/android_arm64-builder-perf/158467 Original change's description: > [xsurface]: Update SurfaceAdapter to SurfaceRenderer and spec > > Change-Id: Ib77234174ece4facb35596808fd964a18db04311 > Bug: 1054944 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048409 > Commit-Queue: Cathy Li <chili@chromium.org> > Reviewed-by: Justin DeWitt <dewittj@chromium.org> > Reviewed-by: Theresa <twellington@chromium.org> > Cr-Commit-Position: refs/heads/master@{#744352} TBR=dewittj@chromium.org,twellington@chromium.org,skym@chromium.org,chili@chromium.org Change-Id: I802a4f660a55ed403effb64fd1a49e04c1b33f4d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1054944 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071112Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#744400}
-
Gayane Petrosyan authored
This CL only saves the bitmap. Adding to complete downloads will be follow up. Bug: 993920 Change-Id: I917154b18f456cadcdf29d8f62474f6e4593d941 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062877 Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#744399}
-
Tommy Li authored
This CL adds the plumbing between Views and the WebUI message handler. It introduces a new OmniboxPopupHandler class meant to keep the popup related method calls separate from the chrome://omnibox calls. Eventually, the WebUI popup will be entirely divorced from the OmniboxPageHandler. Bug: 1046561 Change-Id: I9636f602a1df9761cb3570bb71bc805b08edf138 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072338Reviewed-by:
manuk hovanesian <manukh@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#744398}
-
Kent Tamura authored
This is a preparation to remove LayoutMenuList, and makes LayoutNG transition easier. This CL has no behavior changes. Bug: 1040828 Change-Id: I36d8fe2822555730a094eb21e4b07bb2dc7d0383 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067758Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
David Grogan <dgrogan@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#744397}
-
Denis Bessonov authored
In RenderProcessHostImpl::GetExistingProcessHost, there is a loop that enumerates all current process hosts. It is implement as a while loop having iter.Advance() at the end. Lets assume a situation when one decides to prohibit some process host from being put to suitable_renderers list. The obvious solution is to check some condition and use continue statement to move to next loop iteration... which results in an infinite loop if iter.Advance() isn't called prior to continue. So it looks more safe to use for loop instead as it executes its 3rd part automatically reducing the human factor influence. This CL is a pure refactoring so there is no behavior change at all. Change-Id: I456cd2ff5348172419e8561d4ebf75d886a02e15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071016 Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Auto-Submit: Denis Bessonov <dbessonov@yandex-team.ru> Cr-Commit-Position: refs/heads/master@{#744396}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/0fc949c8b168..82fae3cc60b5 git log 0fc949c8b168..82fae3cc60b5 --date=short --first-parent --format='%ad %ae %s' 2020-02-25 khamu@microsoft.com High contrast color fixed to toggle buttons, inputs and opacity Created with: gclient setdep -r src/third_party/devtools-frontend/src@82fae3cc60b5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1048378 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I7aa4dc1d64bec1a9fe147b6f429137bdac4162dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072476Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#744395}
-
Peter Kasting authored
This was never updated for the identity pill work. Bug: none Change-Id: I129b3184d997612c960253dfd596423d2beca068 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071576 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#744394}
-
Manu Cornet authored
Reading the code and its comments, it seems like calling the |ToEnclosingRect| method is more suitable than |ToNearestRect| for setting the ink drop's clip rectangle. |ToNearestRect| isn't the right method for arbitrary RectFs. Change-Id: If9d4befcd88be4d7ade4d5df043127a7ec3a9dd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071041 Commit-Queue: Manu Cornet <manucornet@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#744393}
-
Wez authored
Layout tests were migrated off RunLoop::QuitCurrentWhenIdleDeprecated() to an explicit Shell::QuitMainMessageLoopForTesting() API by https://chromium-review.googlesource.com/c/chromium/src/+/1106814 This changed the BlinkTestController's quit-main-message-loop semantics such that multiple requests to quit the loop are now fatal, where previously the second and subsequent requests would be silently ignored, but left the potential for bugs due to async tasks quitting the "current" loop rather than the one intended by the controller. Fix the Shell API such that BlinkTestController quits the loop directly rather than posting a quit task, and fix QuitMainMessageLoopForTesting() to support being called multiple times. Bug: 851416, 1051782 Change-Id: I3a9d3f78be2a22ceeef04611dc3a0cf0a25ee34c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071860Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Auto-Submit: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#744392}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7a6db4cbf48b..f8ef81b35e8f git log 7a6db4cbf48b..f8ef81b35e8f --date=short --first-parent --format='%ad %ae %s' 2020-02-25 reed@google.com remove private copy of SkM44.h Created with: gclient setdep -r src/third_party/skia@f8ef81b35e8f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jlavrova@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jlavrova@google.com Change-Id: I0e17c0b6ce62cba43c8edf93ee155152a501a1c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072472Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#744391}
-
Xing Liu authored
We may implement a new project related to the location dialog. This CL extends the expiration date for those metrics. Bug: 1053052,1053051,1053049 Change-Id: I27e588c21e48fe6df0e6adabac0ca62476c217f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070700 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#744390}
-
K. Moon authored
The PDF.LoadStatus metric expires on 2020-03-01. We're planning changes that might affect PDF loads, and so are still interested in tracking how successful PDF loads are. Fixed: 1043729 Change-Id: Ia1bf6833a280d4f82e229265aedef7df48bedfcb Bug: 1043729 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071375Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Auto-Submit: K Moon <kmoon@chromium.org> Cr-Commit-Position: refs/heads/master@{#744389}
-
sczs authored
Bug: 1049088 Change-Id: I435c8b4c0bbec9130cecf845321391914df529d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071241Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#744388}
-
nancy authored
Change-Id: I011eab8c3b2bd21ce1a9e3e2718c736d586d0a57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071455Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#744387}
-
Elly Fong-Jones authored
The value in the controller is const (yay!) so it's safe to simply set it once in the constructor. Bug: 1011446 Change-Id: I5d71936957717ccd5a15c1c81537f8d826d9b4ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072663Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#744386}
-
Collin Baker authored
Bug: 1009881 Change-Id: I0c784e4ac16bb14e5515b95680adfea3b5e3148c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069499Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#744385}
-
Rakesh Soma authored
Bug: 1055726 Change-Id: Ibbdfdaff9c56175dd6f3b795f08b395f0f3bbcfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072118 Commit-Queue: Rakesh Soma <rakeshsoma@google.com> Reviewed-by:
Yusuf Sengul <yusufsn@google.com> Reviewed-by:
Tien Mai <tienmai@chromium.org> Cr-Commit-Position: refs/heads/master@{#744384}
-
Daniel Cheng authored
This is a reland of 6c9388f9. This broke a number of legacy builders which have since been removed from the waterfall ^_^ Original change's description: > Allow FROM_HERE to be backed by base::Location::Current(). > > This allows the functionality of base::Location::Current() to be > verified in releases while still allowing a simple revert. > > One minor difference from before is that the helper macro > FROM_HERE_WITH_EXPLICIT_FUNCTION is no longer supported. Since > cc::BeginFrameTracker is the only user of this macro and doesn't > appear to need it, just revert it to use FROM_HERE directly. > > Bug: 974061 > Change-Id: Iae09bc02caf9f095a3ace9ea3ac70ded3dd493e4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990262 > Commit-Queue: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: danakj <danakj@chromium.org> > Reviewed-by: Alexander Timin <altimin@chromium.org> > Reviewed-by: Jeremy Roman <jbroman@chromium.org> > Auto-Submit: Daniel Cheng <dcheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#731804} Bug: 974061 Change-Id: I075a6340bf356883a044c4a87e2b0038c518782e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072579Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#744383}
-
Tom Anderson authored
This is a reland of 388f1d99 Original change's description: > Reland "Enable ATK and Glib on Linux/Ozone" > > This is a reland of 16c153e6 > > Original change's description: > > Enable ATK and Glib on Linux/Ozone > > > > BUG=988094,1014934 > > R=sky > > CC=nickdiego,msisov,adunaev > > > > Change-Id: I05b4bae5ccce53053ad4ae8269db849c2db9e569 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056570 > > Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> > > Reviewed-by: Nick Yamane <nickdiego@igalia.com> > > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#742233} > > TBR=sadrul,jamiewalch > > Bug: 988094, 1014934 > Change-Id: Ide8b89767eddbdd6e6751db58c92d64e2d756fec > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062911 > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > Reviewed-by: Jamie Walch <jamiewalch@chromium.org> > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#742315} R=sadrul CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng Bug: 988094, 1014934 Change-Id: I48b857751cfa3a1beaaf0555dcdba495dcde8670 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063729 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#744382}
-
Adam Langley authored
This change pulls the caBLE v2 handshake and message encryption out of FidoCableV2HandshakeHandler and FidoCableDevice, implements the authenticator side of it, and adds tests. BUG=1002262 Change-Id: I6370cab017407c9e4c62fe718303180b92b0cb26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067556 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#744381}
-
Andrew Grieve authored
And removes last remnant of JDK8: sun_java_tools Bug: 693079 Change-Id: I4a1988a739543a561accbd4d6a8dbaad75d545b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956048Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#744380}
-
Nico Weber authored
It existed for XP compat, and we dropped XP support long ago. Cq-Include-Trybots: chromium/try:win7-rel Bug: 1055787 Change-Id: I331d734becb0fa68e987d590dc118404afa0f66c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072357 Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#744379}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8f89b6c850ab..4be48f5a3603 Created with: gclient setdep -r src-internal@4be48f5a3603 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1050094,chromium:1051997,chromium:1055749 Tbr: jbudorick@google.com Change-Id: I50b083b22b045ef4cdbcd0ba367c02898296c80c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072452Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#744378}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/0165d5c32c87..d6fb409d463d git log 0165d5c32c87..d6fb409d463d --date=short --first-parent --format='%ad %ae %s' 2020-02-25 hbos@webrtc.org [Overuse] Make some should-be-const methods const. 2020-02-25 eshr@google.com Support injecting new Resources for overuse Created with: gclient setdep -r src/third_party/webrtc@d6fb409d463d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I153582d5a3bf12263d9d584282b8d2df7d8e2d25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072468Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#744377}
-
Bill Budge authored
- Remove WasmCodeCache feature flag, now that it has launched. Bug: chromium:719172 Change-Id: Ic84d2efc3dd27e4abe5ade7225fc8292c568f107 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068880Reviewed-by:
Andreas Haas <ahaas@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#744376}
-
Benjamin Beaudry authored
According to http://www.w3.org/TR/core-aam-1.1/#exclude_elements2, some elements (e.g., buttons) needs to hide their children to accessibility APIs. Apparently, this constraint is implemented in Narrator and explains why navigating with Scan Mode inside of such controls that contains other objects (like an image) fails. To an end user, Narrator simply 'gets stuck' on such elements. In CL:1828124, we added AXPlatformNodeWin::ShouldHideChildrenForUIA and more to prevent returning the descendant of a node that should hide its children and instead returning the ancestor node that shouldn't have children in AXPlatformNodeTextRangeProviderWin::GetEnclosingElement. In AXPlatformNodeTextRangeProviderWin::GetChildren, I noticed that we were still returning the children for a node even though that node should actually hide its descendants. This change ensures that we don't return any child for a node that shouldn't expose its children. In short: 1. Added HasPresentationalChildren to ax_role_properties.cc. 2. Updated the implementation of AXPlatformNodeWin::ShouldHideChildrenForUIA to use that new helper. 3. Moved and renamed BrowserAccessibility::GetDescendants to BrowserAccessibilityWin::GetUIADescendants. 4. Updated the implementation of GetUIADescendants for two reasons: 1. Fix issue with ignored nodes being returned. 2. Hide children that for objects that should hide their children. 5. Added two unit tests: 1. One for the new implementation of BrowserAccessibilityWin::GetUIADescendants. 2. One for the end user experience with UIA in ax_platform_node_textrangeprovider_win_unittest.cc. Bug: 928948 Change-Id: I81f392f5991d9e21f911b802fe0fc69b3ec774d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057863Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com> Cr-Commit-Position: refs/heads/master@{#744375}
-