- 05 Nov, 2019 40 commits
-
-
Julie Jeongeun Kim authored
This CL cleans up old Mojo types for mojom::Remoter, mojom::RemotingSource, and mojom::RemoterFactory using Remote, Receiver, PendingReceiver. Bug: 955171 Change-Id: I3b06bf38ceae5e357d7c6de615616302dad7bfce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892990 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#712448}
-
Koji Ishii authored
This patch adds a test to check the atomic inline+NBSP quirk[1] should not apply if `nowrap`. This issue was originally introduced in r694788 crrev.com/c/1792465, but was accidentally fixed in r700578 crrev.com/c/1827097. The fix did not have a test because it wasn't intended to fix this issue. [1] https://www.w3.org/TR/css-text-3/#line-break-details TBR=chrishtr@chromium.org, ikilpatrick@chromium.org Bug: 1017465, 1018309 Change-Id: Id505b894c02d6521766e2cf354e7c9c8c4a114ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888230Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#712447}
-
Donn Denman authored
Automatically adjusts the length of the Context and the Caption text views as the panel expands open. This fixes some issues with Definitions which can have long captions and uses the Context view to show the pronunciation. The Caption was supposed to auto-adjust, but was not calling super when expanding. The Context just needed to pass the adjustment parameters. BUG=1016973 Change-Id: Ie331cde2cc08a059197ea1e7178099c865e4dbc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898722 Auto-Submit: Donn Denman <donnd@chromium.org> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#712446}
-
Chromium WPT Sync authored
Using wpt-import in Chromium d8488bcd. With Chromium commits locally applied on WPT: 1d5b803f "Add WebVTT support for inline styling - Web Platform Tests" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: guidou@chromium.org, armax@chromium.org: external/wpt/mediacapture-streams mkwst@chromium.org, andypaicu@chromium.org: external/wpt/content-security-policy NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I9916e575b6c06c705390b0a3a7cd56898a30c3cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898177Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712445}
-
Ian Kilpatrick authored
Previously we were only using NGBoxFragmentPainter for blocks with inline children (those specifically with a PaintFragment()). As the NGBoxFragmentPainter removed its dependency on NGPaintFragment we can now use this for block-level fragments as well. Bug: 988015 Change-Id: Id839cb368454bf4c087676dbda2a3ead04e26bd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869076Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#712444}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8a0420a05d13..3f35966470fb Created with: gclient setdep -r src-internal@3f35966470fb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Ib5ce9883e711239cf9f277cdef22331c8977162b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896958Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712443}
-
Julie Jeongeun Kim authored
This CL converts URLLoaderRequest in //android_webview, //chrome, //chromecast, //components, //extensions, //srvices, and //storage to new Mojo types using PendingReceiver and Receiver. Bug: 955171 Change-Id: I089a195aa52fd74111c8ac819ee96c6cdbb87b9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886283 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Luke Halliwell (slow) <halliwell@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#712442}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/71b0f0b588d6..c898ec1a5e2f git log 71b0f0b588d6..c898ec1a5e2f --date=short --no-merges --format='%ad %ae %s' 2019-11-05 jmadill@chromium.org Add EGL GGP extensions. Created with: gclient setdep -r src/third_party/angle@c898ec1a5e2f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jonahr@google.com Bug: None Change-Id: I244baf4fe4a4c531511f21964b6acb5e9a71cc82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898815Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712441}
-
Ahmed Fakhry authored
My previous CL crrev.com/c/1842624 regressed determining if a browser window belongs to the current active Virtual Desk on Windows. This CL fixes this regression. BUG=1021337 Change-Id: Ia134df934530e590219de1a02747c350bb01cf81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898768Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#712440}
-
Dominick Ng authored
This CL flushes the App Service's mojo pipes immediately following login to deflake this test. This ensures that apps which are installed at login correctly percolate through the async callbacks. BUG=1006522 Change-Id: I76e1b24d530f206a55584e513f461f5cd1543c7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817876 Commit-Queue: Dominick Ng <dominickn@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#712439}
-
Ian Kilpatrick authored
wangxianzhu@ reopened bugs which these tests referenced. They were either marked as flakey, and/or just needed to be rebaselined. They were marked as flakey quite a few years ago, so lets try enabling them again. Bug: 453002, 605059, 663858 Change-Id: I6795d58efa741b83e8f3ced1ead603309371e5b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898439 Auto-Submit: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
-
Hayato Ito authored
I'm no longer responsible for core/dom/events code base. It'd be better to remove OWNERS file there to reflect the current status. Change-Id: Icf7411a5418b5f8e05e2ee23b349ca98ffb260cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898890Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#712437}
-
Vladimir Levin authored
This patch clean-up some unnecessary TODOs, and updates the code to remove an extra call to ComputeTrackSizes, which was introduced by the intrinsic-size patch earlier. R=rego@igalia.com, chrishtr@chromium.org Change-Id: Ie6c521ec0ca8f53b97fb84a0c62d7f4cfbdc0e5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897907Reviewed-by:
Manuel Rego <rego@igalia.com> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#712436}
-
Gabriel Charette authored
Instead use base::DeleteSoon which enforces usage of TaskTraits. This CL is a no-op as-is. It was recently discovered however that some callers did BrowserThread::DeleteSoon() with pending tasks running on different task queues (different traits -- e.g. TaskTraits to make this more obvious. Please review whether calls in this CL can be migrated as-is or need additional traits to match potentially pending tasks. Split from https://chromium-review.googlesource.com/c/chromium/src/+/1894109 for cursory review. This CL was uploaded by git cl split. R=thestig@chromium.org TaskPriority: :BEST_EFFORT) which can result in out-of-order deletion... BrowserThread: :DeleteSoon() is being migrated to base::DeleteSoon() w/ Bug: 1019767 Change-Id: Icabe0c2a24ccb44d27e6575b527baabe1824460e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894883 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#712435}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4a4f34b76f3a..f3d4109a793b git log 4a4f34b76f3a..f3d4109a793b --date=short --no-merges --format='%ad %ae %s' 2019-11-05 mtklein@google.com add (x,y) params to shader program() Created with: gclient setdep -r src/third_party/skia@f3d4109a793b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC ethannicholas@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ethannicholas@google.com Bug: None Change-Id: I98b7940bee73a02e8eedc5aa6f726dbbc500b2d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898866Reviewed-by:
-
Julie Jeongeun Kim authored
This CL cleans up old mojo types for mojom::SubresourceFilterAgent using AssociatedReceiver and PendingAssociatedReceiver. Bug: 955171 Change-Id: Iedd96df27c643c1bd307980d77c35231650631c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897396Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=abdulsyed@chromium.org Change-Id: Iaf90f1afcc14e22a8695b22f00b9b2e6b1c5d2a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897807Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712432}
-
Gabriel Charette authored
Instead use base::DeleteSoon which enforces usage of TaskTraits. This CL is a no-op as-is. It was recently discovered however that some callers did BrowserThread::DeleteSoon() with pending tasks running on different task queues (different traits -- e.g. TaskTraits to make this more obvious. Please review whether calls in this CL can be migrated as-is or need additional traits to match potentially pending tasks. Split from https://chromium-review.googlesource.com/c/chromium/src/+/1894109 for cursory review. This CL was uploaded by git cl split. R=wjmaclean@chromium.org TaskPriority: :BEST_EFFORT) which can result in out-of-order deletion... BrowserThread: :DeleteSoon() is being migrated to base::DeleteSoon() w/ Bug: 1019767 Change-Id: I08632c1a3a1b69fec27fa626b6d35b61da6bfe2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895641Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#712431}
-
dpapad authored
Bug: None Change-Id: I7923e5168b2f0e8a1df4b2e9af7db2b10d332f3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895077 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#712430}
-
Antonio Gomes authored
The following files were moved to third_party/blink/renderer/platform/mediastream from third_party/blink/public/platform/modules/mediastream: - media_stream_audio_level_calculator.h - media_stream_audio_processor_options.h - media_stream_audio_source.h - webrtc_uma_histograms.h Whereas the following files were moved to third_party/blink/renderer/platform/mediastream from third_party/blink/renderer/platform/export/mediastream - media_stream_audio_level_calculator.cc - media_stream_audio_processor_options.cc - media_stream_audio_processor_options_test.cc - media_stream_audio_source.cc - webrtc_uma_histograms.cc - webrtc_uma_histograms_test.cc Note that there are still headers left over deliberately in the public directory: (included in content/renderer): - media_stream_audio_track.h - web_media_element_source_utils.h - web_media_stream_audio_sink.h - (included from other public headers): - media_stream_audio_deliverer.h - media_stream_types.h - secure_display_link_tracker.h - web_media_stream_audio_renderer.h - web_media_stream_sink.h - web_media_stream_video_renderer.h - web_platform_media_stream_source.h - web_platform_media_stream_track.h web_media_stream_audio_renderer.h web_media_stream_audio_sink.h BUG=919392, 787254, 704136 R=guidou@chromium.org, haraken@chromium.org Change-Id: I40c0268fed8dafb2aa40620a5e4781324d4342a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891072 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#712429}
-
Andrew Grieve authored
This was always the intention. Change-Id: I7f49676d6cb682999dc0a3dcb1878f831d6a5f4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898947 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#712428}
-
Sergey Ulanov authored
Bug: 999736, b/141714552 Change-Id: I9abf0f01c2bbed6df322b6e822993960ff7bffdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898134 Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#712427}
-
Jinsuk Kim authored
The only callsite outside chrome.browser.tab package now caches its own TWCDA to avoid getting the reference through the Tab API. The API can then be a package private method. Moved TabTestUtils to target chrome_java_test_support. It now contains a helper method for tests to use to get TWCDA. Bug: 995903 Change-Id: I4614cc917710cd21f8be2e426dfcb29f0a4ba8da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881004Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#712426}
-
Wez authored
Content is typically rendered into a surface by the GPU process, and displayed into a window owned by the Browser process. In the Scenic Ozone platform this was implemented using import/export Nodes connecting the GPU & Browser. Content rendered to a ScenicSurface by the GPU process is now exported for display by a ScenicWindow via a nested View. This is a revert of https://chromium-review.googlesource.com/c/chromium/src/+/1661389 with additional changes to restrict what the embedded View can do with input. Bug: fuchsia:29945, 974826 Change-Id: Ib674ea1eab8f013e29606432300b368cdc582137 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895745Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#712425}
-
Mingjing Zhang authored
This CL adds a trace string that represents frame reporting events and will be output as part of the DCHECK message when the DCHECK fails. Each letter in the trace string represent one reporting function call. The length of the trace string is capped at 2,000 characters. Bug: 1017291 Change-Id: I377737730b1f78a7ca87e53db6acba591ee00090 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895379 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#712424}
-
Matt Menke authored
Nothing populates it yet, other than a test this CL adds. Bug: 997049 Change-Id: I19012744ce7333cf88a7a82e79fc4a4cc99b6cfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895859Reviewed-by:
Eric Orth <ericorth@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#712423}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/1776a0ea..d3f9d9a2 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Id39f9d10783280bf091e69369d3a5ba90af7fb8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898176Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712422}
-
Megan Jablonski authored
Bug: 1012746 Change-Id: I86a77ff45517796cfd12bff2eef7590b6fd04aed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888119Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Megan Jablonski <megjablon@chromium.org> Cr-Commit-Position: refs/heads/master@{#712421}
-
Min Qin authored
Bug: 1013759 Change-Id: I089b87ee804dfc7151f332f0d967eccaf3573dce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891472 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
-
Glen Robertson authored
Also fixes bug where web app would not be considered installed if replacement_web_app_url did not match start_url specified in the web app's manifest. https://docs.google.com/document/d/18ILBOp7lPP9faAC7mF9hwBC40egzrnGS8GUSkAdG3Lk/edit Bug: 1007860 Change-Id: I6e70d5ae4dda797b4760dad4b4876ff205873dd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847609 Commit-Queue: Glen Robertson <glenrob@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#712419}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6bfec1fd1dc3..8a0420a05d13 Created with: gclient setdep -r src-internal@8a0420a05d13 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:984162,chromium:1004848 Change-Id: I3b0216deeeded8d4e2824cf44d477fe15b73b1e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898751Reviewed-by:
-
Miguel Casas authored
Some test-only files under media/gpu/test use LOG_ASSERT(), which causes the test binary to crash and leave an unsymbolized callstack when run on the CrOs Tast infra. This CL changes some of those refs to GTest's ASSERT_TRUE(), that is equivalent to EXPECT_TRUE()+return (not all LOG_ASSERT()s are that easy to replace since they are inside functions returning something). Replacing video_decoder_client.cc should fix the VP9.2 not being initialized (since it's disabled temporarily)- the test is expected to fail but not to crash. Bug: 1020776 Change-Id: Iddd6ed9080db4abe62f93730c84e77bfcbc9305f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897358Reviewed-by:
David Staessens <dstaessens@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#712417}
-
Gabriel Charette authored
Instead use base::DeleteSoon which enforces usage of TaskTraits. This CL is a no-op as-is. It was recently discovered however that some callers did BrowserThread::DeleteSoon() with pending tasks running on different task queues (different traits -- e.g. TaskTraits to make this more obvious. Please review whether calls in this CL can be migrated as-is or need additional traits to match potentially pending tasks. Split from https://chromium-review.googlesource.com/c/chromium/src/+/1894109 for cursory review. This CL was uploaded by git cl split. R=ksakamoto@chromium.org TaskPriority: :BEST_EFFORT) which can result in out-of-order deletion... BrowserThread: :DeleteSoon() is being migrated to base::DeleteSoon() w/ Bug: 1019767 Change-Id: I5386adf1e71f5cd42566fdb64a6cdf5ba183849f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893537 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#712416}
-
Aaron Colwell authored
Temporary fix that creates an exception for 'no access' URLs like chrome-native://history. These URLs can cause a origin mismatch in the commit code because of slight differences between how url::Origin and blink::SecurityOrigin handle 'no access' URLs. This is intended as a low risk change that can be easily merged to the M79 branch. Bug: 1016711 Change-Id: I20734fe68b6919c06849a1ce1439624d6332898c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896863 Commit-Queue: Aaron Colwell <acolwell@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#712415}
-
Hiroki Sato authored
crrev/c/1875853 wired Android's ImportantForAccessibility to chrome's ignored state. This made all WebView nodes ignored as they don't have importance. This CL fixes it by checking whether it's a native web node and it's focusable. Bug: b:143435799 Test: unit_tests --gtest_filter="AXTreeSourceArcTest.*" Change-Id: I01b52b2542d771749c50f44be361572bb30916da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890407 Commit-Queue: Hiroki Sato <hirokisato@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Sara Kato <sarakato@chromium.org> Cr-Commit-Position: refs/heads/master@{#712414}
-
Takashi Sakamoto authored
This reverts commit c5f7284b. Reason for revert: suspect causing base_unittests failure on linux-chromeos-google-rel and chromeos-betty-google-rel: - StackTraceTest.OutputToStream Sample build: https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-google-rel/8635 Sample log: https://logs.chromium.org/logs/chrome/buildbucket/cr-buildbucket.appspot.com/8897671078839178960/+/steps/base_unittests/0/logs/Deterministic_failure:_StackTraceTest.OutputToStream__status_FAILURE_/0 Original change's description: > [base] Cleanup StackTraceTest.OutputToStream #ifdef soup. > > Change-Id: I7e43ea82867177c1aeab089f8f1e35abb802d1a1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1780074 > Commit-Queue: Wez <wez@chromium.org> > Reviewed-by: Albert J. Wong <ajwong@chromium.org> > Auto-Submit: Wez <wez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#712377} TBR=ajwong@chromium.org,wez@chromium.org Change-Id: I082cc38b748df06ce86324b13d2cd45dbdf1c7a6 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898888Reviewed-by:
Takashi Sakamoto <tasak@google.com> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#712413}
-
Erik Chen authored
There's no need for android kitkat to run lint or errorprone java compiler. These are already run by android_compile_dbg. See discussion at https://bugs.chromium.org/p/chromium/issues/detail?id=1020714#c2. Change-Id: Ibf82c9d46044855b3c25242e30200ae95906d578 Bug: 1020704 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896053Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Auto-Submit: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#712412}
-
Leon Han authored
As we have NDEFRecord#data now with which users can do whatever they want, so we just remove these helper getters for simplication. The spec change: https://github.com/w3c/web-nfc/pull/384 BUG=520391 Change-Id: I054b521b474433e81b4e8fd93dad0772698ac8a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897480Reviewed-by:
François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Leon Han <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#712411}
-
Leon Han authored
Makes it use the util function GetBytesOfBufferSource() to retrieve bytes from a BufferSource object. BUG=520391 Change-Id: I31684c36a7a98dc08520f48fcbc4a3618d8b92f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896899 Auto-Submit: Leon Han <leon.han@intel.com> Reviewed-by:
-
Leon Han authored
Before, we have both 'opaque' and 'json' NDEFRecord for reading/writing TNF_MIME_MEDIA records, and we just serialize the JSON object provided by users to get the payload bytes for the 'json' NDEFRecord. Now with the goal of making web nfc more of a low level API, this CL unifies them as a new 'mime' type that serves for reading/writing TNF_MIME_MEDIA records. TNF_MIME_MEDIA <---> 'mime' type NDEFRecord The spec change: https://github.com/w3c/web-nfc/pull/373 BUG=520391 Change-Id: If4052c70e48100185e72cb07da8363f5de92b4b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896154Reviewed-by:
-
