GitLab

BUG=31663
Review URL: https://codereview.chromium.org/11412286

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170602 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/11428117

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170601 0039d316-1c4b-4281-b951-d872f2087c98

BUG=163531
TEST=none


Review URL: https://chromiumcodereview.appspot.com/11421180

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170600 0039d316-1c4b-4281-b951-d872f2087c98

Add a new stack for DoLibpngWrite leak (issue 150995)

BUG=139998,150995
TBR=eugenis
Review URL: https://codereview.chromium.org/11415247

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170599 0039d316-1c4b-4281-b951-d872f2087c98

BUG=163713
TBR=stuartmorgan
Review URL: https://codereview.chromium.org/11434067

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170598 0039d316-1c4b-4281-b951-d872f2087c98

it was all janked up along the bottom. That's fixed. Also updated the close button to use the tab close resource rather than the bar close resource (to match Windows).

BUG=156749

Review URL: https://chromiumcodereview.appspot.com/11415220

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170597 0039d316-1c4b-4281-b951-d872f2087c98

When the "Search key acts as a Function key" option is enabled, the keyboard
overlay help screen (accessed with Control-Alt-/) will include "Search" in its
list of modifiers to press to see shortcuts. And when Search is pressed, the
appropriate keys are highlighted with shortcuts that exist for it.

The shortcuts are: Search-Backspace, Search-Up, Search-Down, Search-1, Search-2,
etc, from https://codereview.chromium.org/11421055/

R=yusukes@chromium.org
BUG=162268
Depends on: https://codereview.chromium.org/11421055/
Depends on: https://codereview.chromium.org/11417144/


Review URL: https://chromiumcodereview.appspot.com/11415124

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170596 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170595 0039d316-1c4b-4281-b951-d872f2087c98

Only resize the old front buffer (now back buffer) if we flipped.

BUG=159880
TEST=by hand as per bug


Review URL: https://chromiumcodereview.appspot.com/11280257

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170593 0039d316-1c4b-4281-b951-d872f2087c98

BUG=163653

Review URL: https://codereview.chromium.org/11421187

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170592 0039d316-1c4b-4281-b951-d872f2087c98

> Use AutoThread in ChromotingHostContext & NPAPI plugin.
> 
> Callers now create ChromotingHostContext to create a set of threads
> for host tasks to run on, and pass the threads' TaskRunners to each
> host component explicitly. The ChromotingHostContext can then be
> torn down as soon as the caller no longer needs to create new
> components using the threads, and the threads themselves will exit
> only when the created components no longer require them.
> 
> This is a re-land of 11094056, which failed on the valgrind & Windows TSan bots due to ChromotingHostContext.StartAndStop not running its message loop to allow the context's threads join tasks to execute. 
> 
> TBR=alexeypa
> 
> Review URL: https://chromiumcodereview.appspot.com/11316247

TBR=wez@chromium.org
Review URL: https://codereview.chromium.org/11419265

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170591 0039d316-1c4b-4281-b951-d872f2087c98

BUG=99504
TBR=joi

Review URL: https://chromiumcodereview.appspot.com/11414232

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170590 0039d316-1c4b-4281-b951-d872f2087c98

The way the perfbot works is that the benchmark name is used as the graph name.
Since the graph is historically named sunspider, this makes for a clean
transition with preserved history.

BUG=163680
TEST=None

Review URL: https://codereview.chromium.org/11348331

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170587 0039d316-1c4b-4281-b951-d872f2087c98

BUG=158821
TBR=fischman

Review URL: https://codereview.chromium.org/11428122

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170586 0039d316-1c4b-4281-b951-d872f2087c98

TBR=isherman@chromium.org
BUG=none
TEST=clang compiles

Review URL: https://codereview.chromium.org/11415240

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170585 0039d316-1c4b-4281-b951-d872f2087c98

Fix crash on win_aura buildbot because a RootWindow was getting multiple AddRootWindowObserver calls for the same window. The issue is that the observer wasn't unregistering itself at destruction. If another one happened to be created at the same memory address, then this check would trigger.

BUG=163506
Review URL: https://codereview.chromium.org/11418262

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170584 0039d316-1c4b-4281-b951-d872f2087c98

It looks like there are cases where we might get a tapDown followed by a flingStart
immediately without and scrollBegin from the Android framework. To avoid using the
tapDown in these situations have flingStart also remove the deferred tapDown like
scrollBegin and pinchBegin

BUG=135818


Review URL: https://chromiumcodereview.appspot.com/11418218

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170583 0039d316-1c4b-4281-b951-d872f2087c98

R=estade@chromium.org,isherman@chromium.org
TBR=jschuh@chromium.org
BUG=157661

Review URL: https://codereview.chromium.org/11348273

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170581 0039d316-1c4b-4281-b951-d872f2087c98

Decouple workspace animation from other actions on windows (e.g. hide/show), so that animations can be used separately.

It would fix focus loss upon locking issue, as well as remove flickering on partial lock/cancel locking.

BUG=162646


Review URL: https://chromiumcodereview.appspot.com/11419225

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170580 0039d316-1c4b-4281-b951-d872f2087c98

BUG=163690

This CL extends the UserManager to handle public accounts defined through
policy. User pods are dynamically added and removed when the list of
public accounts in policy changes. Any data belonging to obsolete accounts
is also removed, taking care not to remove it prematurely if a user is
currently logged into the account.

The CL also makes the user list handling more robust by checking for
duplicate entries in the user list prefs and logging these as errors.

The pods added for public accounts are not functional yet. The login flow
for public accounts will be the topic of another CL.

BUG=158509


Review URL: https://chromiumcodereview.appspot.com/11419184

TBR=bartfab@chromium.org
Review URL: https://codereview.chromium.org/11299284

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170579 0039d316-1c4b-4281-b951-d872f2087c98

This method is unused in Chromium and downstream, so remove it.

BUG=149477


Review URL: https://chromiumcodereview.appspot.com/11412274

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170578 0039d316-1c4b-4281-b951-d872f2087c98

BUG=163690

TBR=bartfab@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/11348327

TBR=isherman@chromium.org
Review URL: https://codereview.chromium.org/11421186

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170577 0039d316-1c4b-4281-b951-d872f2087c98

Also addresses an issue on Chrome OS where we'd unnecessarily spin up
the DataTypeManager if the user cancelled out of a sync setup (after a
dashboard clear), and adds some comments.

Lastly some tests were firing TOKEN_LOADING_FINISHED on a fake / mock
TokenService, but calling TokensLoadedFromDB was still returning
false -- fixed that (needed for this patch).

BUG=80194, 128692


Review URL: https://chromiumcodereview.appspot.com/11348220

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170576 0039d316-1c4b-4281-b951-d872f2087c98

Browser needs to communicate with the embedder when 
the guest renderer swaps hardware buffers.
Embedder needs to provide textures for the guest to render into.

BUG=143429


Review URL: https://chromiumcodereview.appspot.com/11364133

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170575 0039d316-1c4b-4281-b951-d872f2087c98

BUG=163607

Review URL: https://codereview.chromium.org/11415238

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170574 0039d316-1c4b-4281-b951-d872f2087c98

BUG=153777


Review URL: https://chromiumcodereview.appspot.com/11414204

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170572 0039d316-1c4b-4281-b951-d872f2087c98

Revert 170550 - Revert 170477 - Removes the |event| parameter from ActivationDelegate::ShouldActivate and makes the method const.

It is mostly unused, except for one place in RenderWidgetHostViewAura, where depending on the event type etc it will have a consequence. I think it's bad for a method with a const-sounding name like "ShouldActivate" to have side-effects.

Instead, I made the RWHVA store the data that would indicate a pointer activate and check that state during OnActivated(). It'd be a little cleaner if OnActivated had some way of knowing what the currently processed input event was, hence the TODO.

http://crbug.com/162100
R=sadrul@chromium.org
Review URL: https://codereview.chromium.org/11419251

TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/11416292

TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/11434062

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170571 0039d316-1c4b-4281-b951-d872f2087c98

This improves startup time by about 20ms.

BUG=163215

Review URL: https://chromiumcodereview.appspot.com/11411249

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170568 0039d316-1c4b-4281-b951-d872f2087c98

This intro has a very brief description of the API usage and a link to any related docs,
if available.

At the moment, the related docs are in the heading 4.
In a separate cl, I will add 'Availabile in' information, and may use a table format for both related doc and available in.

This cl also includes broken link fixes to app_hardware.html.

Note: this does not include experimental APIs or APIs with existing intros.
Additional improvements to be made in separate cls.

Review URL: https://codereview.chromium.org/11412117

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170567 0039d316-1c4b-4281-b951-d872f2087c98

BUG=6295515


Review URL: https://chromiumcodereview.appspot.com/11412076

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170565 0039d316-1c4b-4281-b951-d872f2087c98

The mac buildbots use an older version of python 2.6 that doesn't support
adding directories to zipfiles. Work around it by adding an empty file with the
same zip path (which is basically what later versions do anyway).

BUG=none
R=sbc@chromium.org
TBR=noelallen@chromium.org
NOTRY=true


Review URL: https://chromiumcodereview.appspot.com/11428111

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170564 0039d316-1c4b-4281-b951-d872f2087c98

BUG=153137
TEST=Add a ?id=<extension_id> to the chrome://extensions page url and that extension should become highlighted.
Review URL: https://codereview.chromium.org/11434024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170561 0039d316-1c4b-4281-b951-d872f2087c98

BUG=157800

Review URL: https://codereview.chromium.org/11280258

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170560 0039d316-1c4b-4281-b951-d872f2087c98

This gives a 5% increase in cc_perftests.

Before:
*RESULT SevenTabSwitcher: frames= 1519.00 runs/s
*RESULT 10_10_layer_tree: frames= 541.09 runs/s

After:
*RESULT SevenTabSwitcher: frames= 1594.62 runs/s
*RESULT 10_10_layer_tree: frames= 569.31 runs/s

BUG=163035
R=jamesr,sky


Review URL: https://chromiumcodereview.appspot.com/11414265

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170559 0039d316-1c4b-4281-b951-d872f2087c98

For the given repro case, textInputType seems to get stuck in the
previous input type whereas textInputInfo is checking whether
an editor exists for the focused frame and exiting early with
with TextInputType set to None. Switching to using textInputInfo
in getTextInputType, as the comments in the header suggests the use of
textInputType by itself as an API should be deprecated anyway.

BUG=162831


Review URL: https://chromiumcodereview.appspot.com/11419218

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170558 0039d316-1c4b-4281-b951-d872f2087c98

BUG=158379


Review URL: https://chromiumcodereview.appspot.com/11348311

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170557 0039d316-1c4b-4281-b951-d872f2087c98

The breakpad export has been unused for the last five months, so I suppose it's safe to remove it entirely.

BUG=162405
TEST=Chromium Win (aura) bot should be able to compile metro_driver.dll.

Review URL: https://chromiumcodereview.appspot.com/11412265

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170555 0039d316-1c4b-4281-b951-d872f2087c98

BUG=163548
TEST=manual


Review URL: https://chromiumcodereview.appspot.com/11416279

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170554 0039d316-1c4b-4281-b951-d872f2087c98

BUG=158308
TEST=manual

Review URL: https://chromiumcodereview.appspot.com/11428105

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170553 0039d316-1c4b-4281-b951-d872f2087c98

Adds ShellPanelAsh and window_type=panel support to ShellWindow

BUG=161102


Review URL: https://chromiumcodereview.appspot.com/11363250

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170552 0039d316-1c4b-4281-b951-d872f2087c98