- 17 Jan, 2020 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/91096f77a581..6d6e911b50e1 git log 91096f77a581..6d6e911b50e1 --date=short --first-parent --format='%ad %ae %s' 2020-01-17 fancl@chromium.org Reduce min_num_instances of sheriff-config 2020-01-17 dberris@chromium.org Remove dispatch.yaml 2020-01-17 dberris@chromium.org Add commas between distinct strings 2020-01-17 fancl@chromium.org Fix query by subscriptions 2020-01-17 bsheedy@chromium.org Fix minidump symbolize spam 2020-01-17 zhizhouy@google.com Use python 2 for trace2html Created with: gclient setdep -r src/third_party/catapult@6d6e911b50e1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1039776,chromium:1040775,chromium:1042949,chromium:953181 Tbr: rmhasan@google.com Change-Id: I2dc3f9402d0aa1087238b67e85528518edce4f8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006712Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#732765}
-
Josh Simmons authored
This UI is shown only when PerformanceHintsObserver is enabled. It is currently disabled by default. Bug: 1030813 Change-Id: I7f84e319871d5eb31c46faa8e0fc4255e87b5ed3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992263 Commit-Queue: Josh Simmons <jds@google.com> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#732764}
-
Rachel Sugrono authored
Add two non-consecutive files to check-select (aka multi- select). Quick View should open in check-select mode with the first file being opened. Left/right arrow keys should show the next selection in check-select. Bug: 1038799 Change-Id: I1164a19391920b9cc08d0f622d1c2a14c006b8d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006901 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#732763}
-
Jan Wilken Dörrie authored
This reverts commit 07b113c5. Reason for revert: Breaks create_tarball step on Deterministic Linux builders: https://crbug.com/1043039 Original change's description: > [Reland] WebUI: Stop auto-generating Polymer 3 version of cr-splitter. > > The Polymer 2 version is not used anymore, therefore no auto-generation > is necessary and the v3 version can be directly checked in. > > Fixed: 1042545 > Change-Id: Ia0267cef30dcf1eb08677d369fd3f8ded21c679f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006421 > Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> > Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> > Reviewed-by: Rebekah Potter <rbpotter@chromium.org> > Cr-Commit-Position: refs/heads/master@{#732725} TBR=dpapad@chromium.org,rbpotter@chromium.org Change-Id: I59eb715d4f775f98fb9a71d37889bbefbe3d86f7 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006349Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#732762}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/3ed344dd784e..b0ada80356ca git log 3ed344dd784e..b0ada80356ca --date=short --first-parent --format='%ad %ae %s' 2020-01-17 cepheus@frii.com HLSL: Fix #1974: ignore input primitives on non-entry-point functions. Created with: gclient setdep -r src/third_party/glslang/src@b0ada80356ca If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: radial-bots+chrome-roll@google.com,jonahr@google.com Change-Id: I94005182ab630196e10f9ce416f0559d3a58eef7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006718Reviewed-by:
-
Adam Rice authored
Add an API to receive datagrams from a QuicTransport connection. Bug: 1011392 Change-Id: I8d730f858dcf5127f186c6d58816f43a4b7c731b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006279Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#732760}
-
David Munro authored
Bug: chromium:914515 Test: CQ Change-Id: Ibfacf91020b5bd80c905967accb24c438c0293b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006838 Commit-Queue: David Munro <davidmunro@google.com> Commit-Queue: Julian Watson <juwa@google.com> Auto-Submit: David Munro <davidmunro@google.com> Reviewed-by:
Julian Watson <juwa@google.com> Cr-Commit-Position: refs/heads/master@{#732759}
-
David Munro authored
Users can opt to back up their existing container before attempting the upgrade and are prompted to restore if the upgrade fails. Almost all of this is by nverne@, I just fixed a use-after-free and am relanding it while he's OOO. Bug: 1024693 Test: Unit tests under ASAN, browser tests, manual tests. Change-Id: I5d366732e36157b98178aa97cefc84a35f713bbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985621Reviewed-by:
David Munro <davidmunro@google.com> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: David Munro <davidmunro@google.com> Auto-Submit: David Munro <davidmunro@google.com> Cr-Commit-Position: refs/heads/master@{#732758}
-
Patrick Rohr authored
InitSharedInstanceWithPakFileRegion() takes ownership of the passed file and assigns it to a static instance variable. This means that the next time base::File(pake_fd) is called on line 250, the file descriptor already has an owner (and a FdEntry respectively) and android_fdsan_exchange_owner_tag fails (in order to prevent a double close. See bionic/libc/bionic/fdsan.cpp for further information). Duplicating the file descriptor before calling InitSharedInstanceWithPakFileRegion should prevent this problem. Test: Tested on device. Casting a few times back to back does not trigger the error, while without the fix the error is thrown right away. Bug: b/142898745 Change-Id: I153ed21eaaa5280d63a296d272cd4f7b46d67859 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003321Reviewed-by:
Simeon Anfinrud <sanfin@chromium.org> Reviewed-by:
Luke Halliwell (slow) <halliwell@chromium.org> Commit-Queue: Patrick Rohr <prohr@google.com> Cr-Commit-Position: refs/heads/master@{#732757}
-
Christoph Schwering authored
Autofill uses AutofillClock and AutofillTickClock to allow for manipulating the clock for testing purposes. This presubmit script warns about usage of base::Time::Now() and base::TimeTicks::Now(). Bug: 1009364 Change-Id: I314303fde19edfc623cba96a01ed3a5e00c6815e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007048Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Christoph Schwering <schwering@google.com> Cr-Commit-Position: refs/heads/master@{#732756}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/3f0bc2c1766a..e4ddaa949540 git log 3f0bc2c1766a..e4ddaa949540 --date=short --first-parent --format='%ad %ae %s' 2020-01-17 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 112d1736..f1e98807 (732519:732621) 2020-01-16 steveanton@webrtc.org Explicitly wait for ICE to complete in VerifyBestConnection 2020-01-16 steveanton@webrtc.org Explicitly wait for ICE state to transition to 'completed' in VerifyIceStates Created with: gclient setdep -r src/third_party/webrtc@e4ddaa949540 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I2edfa1c0873993a6bec84cc60a01afc25c2528b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006815Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/41f6150edb16..9819e9ed7b10 git log 41f6150edb16..9819e9ed7b10 --date=short --first-parent --format='%ad %ae %s' 2020-01-17 sugoi@google.com GL_EXT_read_format_bgra support 2020-01-17 sugoi@google.com GL_EXT_float_blend support Created with: gclient setdep -r src/third_party/angle@9819e9ed7b10 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jonahr@google.com Change-Id: I79e0563b296310097c58258d1ef66e3c29df9b2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006814Reviewed-by:
-
Theodore Olsauskas-Warren authored
Original mocks for the new Security Page as part of friendly settings introduced usage of heading styles that did not have a precedent within settings. This CL changes the Security Page to align with existing usage patterns. Bug: 1032584 Change-Id: Iaf50a6713bb2465332e2ef10fdd5247b26815036 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002515Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Cr-Commit-Position: refs/heads/master@{#732753}
-
Jan Wilken Dörrie authored
TBR=sigurds Bug: 1042689 Change-Id: Ied0c235d3922cd7b355bcdb24b8bb4fbb38d5954 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003856 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#732752}
-
Rachel Sugrono authored
Add two non-consecutive files to check-select (aka multi- select). Quick View should open in check-select mode with the first file being opened. Up/down arrow keys should show the next selection in check-select. Bug: 1038799 Change-Id: Ib6c6288aaeeb10a82e7264336bb25a79d5b7d5c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006844Reviewed-by:
-
Austin Tankiang authored
The paper ripples were set to 150% width in order to speed them up, but this causes issues in RTL, so remove it. Bug: 977996 Change-Id: Iab53d635e9feaec323cea9e9addd11c6a182119f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006893Reviewed-by:
-
Wei Wang authored
This patch makes the order of the registrations returned by getRegistrations() be sorted by registration ID, which fixes the flaky test of getregistrations.https.html. Related Github issue is in https://github.com/w3c/ServiceWorker/issues/1465 Bug: 925740 Change-Id: Iaa5716eec886232df61bd23487fbae5c63413e9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984900Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Wei4 Wang <wei4.wang@intel.com> Cr-Commit-Position: refs/heads/master@{#732749}
-
David Staessens authored
The V4L2 encode accelerator currently has its own routines and thread to manage polling the V4L2 device. This CL changes the encoder to make use of the V4L2 device poller that was introduced recently. TEST=./video_encode_accelerator_unittest on hana BUG=None Change-Id: I7fb003ab3850c4a72b299a682a9a7f971777aa34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994545Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Commit-Queue: David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#732748}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/32e07f0513b0..2182260bce54 Created with: gclient setdep -r src-internal@2182260bce54 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1034629,chromium:1042660,chromium:1042741,chromium:981067 Tbr: jbudorick@google.com Change-Id: I5c7c1a6bc7df46ddfbd964e654151e1a2aab7820 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006623Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#732747}
-
Caleb Rouleau authored
This is necessary for Pinpoint, which still uses these isolates. This is a fix after https://chromium-review.googlesource.com/c/chromium/src/+/2003767 landed. See the bug for details. TBR=bsheedy@chromium.org Bug: 1042778 Change-Id: Iff81712f2e3f6d26171064922056361e9fc7b4e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006391Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#732746}
-
rbpotter authored
This fixes a Polymer timing issue where setting the margins in the margin-control-container was causing the observer in margins-settings that updated the UI to not fire. Also moving the margins setter in pages_per_sheet to margins for consistency. Bug: 1041378 Change-Id: I83bebfefe8fb306bc332844e5a146271a7ac2b96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000523Reviewed-by:
-
chromium-autoroll authored
Roll ChromeOS orderfile from 81-3987.18-1578307131-benchmark-81.0.4019.0-r1 to 81-3987.39-1578912426-benchmark-81.0.4019.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-orderfile-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ida8a7bcad16f06d55e8d2ec3eecdd0e258fbc104 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006714Reviewed-by:
-
Yi Xu authored
Metrics Compositing.Renderer.RasterTask.RasterUs.Software and Gpu are erroneously obsolete. This is because metrics Compositing.Renderer.RasterTask.RasterUs is marked obsolete. Bug: 817041 Change-Id: I6b96758790c33d21b1e6615920f6ce2cd99d4c63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006169Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Yi Xu <yiyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#732743}
-
Hitoshi Yoshida authored
Changes output path of dictionary files from third_party/blink/(core|modules)/xxx/yyy/zzz.{h,cc} to third_party/blink/bindings/(core|modules)/v8/v8_zzz.{h,cc} Bug: 839389, 1034398 Change-Id: I47504d8bd263b07d8ff74c8306bb48e702580f28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004363 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#732742}
-
Jiajun Ou authored
Change-Id: Ia1980395380f62708b89fff2f9d5208165d58e95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006830Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Commit-Queue: Jiajun Ou <garzonou@google.com> Cr-Commit-Position: refs/heads/master@{#732741}
-
Nicolas Ouellet-Payeur authored
Previously, update_annotations_sheet.py would "play nice" with existing rows that were for another platform. For instance, when running the script, it would leave the "chrome_cleaner" annotation (which is Windows-only) in the spreadsheet. This causes issues on waterfall, because running the bot on Windows creates empty rows (placeholders for Linux-only annotations), which cause it to fail on subsequent runs (as the script doesn't expect empty rows). This CL fixes the issue by making update_annotations_sheet.py delete annotations that are for other platforms. So running the script on Linux will delete Windows-only annotations from the sheet, and vice-versa. Change-Id: I8d0d026f7f4eb94e6c482ca70610b5be7224d0fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003307 Auto-Submit: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#732740}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7b186101c357..d58b643f10f5 git log 7b186101c357..d58b643f10f5 --date=short --first-parent --format='%ad %ae %s' 2020-01-16 reed@google.com undo SkMatrix() cast -- must be done by sksl machine 2020-01-16 egdaniel@google.com Remove GrPixelConfig from validateSurfaceParams 2020-01-16 egdaniel@google.com Pass in a GrColorType into our Copy call. 2020-01-16 mtklein@google.com little debug/profiling tool cleanups 2020-01-16 bungeman@google.com Avoid BOT/EOT setting in HarfBuzz. 2020-01-16 fmalita@chromium.org [skottie] Refactor property animators 2020-01-16 herb@google.com Isolate updating grTextStrike 2020-01-16 csmartdalton@google.com Add a --scale flag to skpbench 2020-01-16 reed@google.com Make converting from 4x4 to 3x3 explicit 2020-01-16 bsalomon@google.com Disallow GrTextureDomain::kIgnore_Mode in SkGpuBlurUtils::GaussianBlur. 2020-01-16 jvanverth@google.com Reland "Reland "Add new method for storing DrawOpAtlas texture index."" 2020-01-16 robertphillips@google.com Add SkImage::CompressionType::kBC1_RGBA8_UNORM support 2020-01-16 csmartdalton@google.com Fix single-pass tessellator wedges 2020-01-16 michaelludwig@google.com Re-enable QCOM_tiled_rendering, but check for gl functions 2020-01-16 mtklein@google.com DCI-P3 -> Display P3 in Skia Created with: gclient setdep -r src/third_party/skia@d58b643f10f5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: mtklein@google.com Change-Id: If527d60d0024946005f6b9bcc4aac3333d4fea31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006486Reviewed-by:
-
Rachel Sugrono authored
Add two non-consecutive files to a check-select (aka a multi- selection). Quick View should open in check-select mode with the first file being displayed. Bug: 1038799 Change-Id: I1fada68b30ae3bd48df69d96669255aa166787ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006892Reviewed-by:
-
Christopher Cameron authored
Bug: 1042781 Change-Id: Iebb86d120aab538517ae6c087f815f2eb89811de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003897Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#732737}
-
Keishi Hattori authored
ColorChooserPopupUIController's prefinalizer closing the popup allocates new objects which is not allowed. ColorChooserPopupUIController's prefinalizer which closes the popup should not exist. In normal use, the popup will be explicitly closed before ColorChooserPopupUIController is destroyed. The only exception is the Internals::endColorChooser() which releases the ColorChooser without closing the popup. This CL fixes Internals::endColorChooser(). Bug: 1040389, 1039092 Change-Id: Ib52c80e5288ac7a115409706c96c3ba226357dd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004365 Commit-Queue: Keishi Hattori <keishi@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#732736}
-
Xianzhu Wang authored
The tests are constantly passing. TBR=wangxianzhu@chromium.org Bug: 1018273 Change-Id: I1369632b918965f0864a3dba2c6792a2e5ee23ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2005548Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#732735}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/4c1086a36ade..3f0bc2c1766a git log 4c1086a36ade..3f0bc2c1766a --date=short --first-parent --format='%ad %ae %s' 2020-01-16 sansid@google.com Revert "Enable using a custom NetEqFactory in simulations" 2020-01-16 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 7356cb88..112d1736 (732376:732519) 2020-01-16 ivoc@webrtc.org Enable using a custom NetEqFactory in simulations 2020-01-16 srte@webrtc.org Reland "Moves TransportFeedbackAdapter to TaskQueue." 2020-01-16 kron@webrtc.org Distinguish between send and receive codecs 2020-01-16 danilchap@webrtc.org Replace RTC_FALLTHROUGH with ABSL_FALLTHROUGH_INTENTED Created with: gclient setdep -r src/third_party/webrtc@3f0bc2c1766a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1029737 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I67c71458afc5f42c15c7b23f33cca469b77ea7ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006609Reviewed-by:
-
Patrick Monette authored
The DedicatedWorkerService is a simple interface that can be used to subscribe to the lifetime of dedicated workers. This interface will be used by the Performance Manager to track dedicated workers. Bug: 993029 Change-Id: I9d189d828c7232bb691c2602c7cc99f7dede8ee3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990263 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#732733}
-
Wei Lee authored
Bug: b/147778989 Test: Manually tested with https://crrev.com/c/2004140 Change-Id: I495d4ca19b81a6d0f556e77d08f07f1b866f7266 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004430Reviewed-by:
Shik Chen <shik@chromium.org> Commit-Queue: Wei Lee <wtlee@chromium.org> Auto-Submit: Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#732732}
-
Hajime Hoshi authored
Page in back-forward cache can be hidden too, so rename the methods to avoid confusion. R=csharrisson@chromium.org BUG=1001087 Change-Id: I3e2a00ecbaf64275bc5cb46c8ab7662f5ad661cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004367Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#732731}
-
Aaron Colwell authored
Adding a crash key to make it easier to track down what document URLs are triggering renderer kills. Bug: 977169 Change-Id: I3133772d919d1ab5aabd32997a0ddc58e3af14b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006590 Commit-Queue: Aaron Colwell <acolwell@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Auto-Submit: Aaron Colwell <acolwell@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#732730}
-
Charlene Yan authored
Bug: 1041636 Change-Id: Ic36f25c04f117af7695b6c0b00cdca89478ee84b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2005390Reviewed-by:
Connie Wan <connily@chromium.org> Commit-Queue: Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#732729}
-
Alexandre Courbot authored
The Youtube Android app will sometimes send an invalid frame number after seeking, which triggers an error with the H264Decoder. Until this is fixed, this workaround prevents decoding from failing every second seek. BUG=b:146914440 BUG=b:129119729 TEST=Can seek without issue or artefacts in the Android Youtube app on Krane. Change-Id: I8b6ca5f4c53a67e934c918023ab987e7a0009ffb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000258 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#732728}
-
Kuo Jen Wei authored
Rename several view names as follows: camera -> view-camera expertsettings -> view-expert-settings gridsettings -> view-grid-settings message-dialog -> view-message-dialog photoresolutionsettings -> view-photo-resolution-settings resolutionsettings -> view-resolution-settings settings -> view-settings timersettings -> view-timer-settings videoresolutionsettings -> view-video-resolution-settings warning -> view-warning Bug: 1024811 Test: tast run <DUT> 'camera.CCAUI*' Change-Id: I2b1e6dc4b59d1c46e9c1add1363580cd4a992ae4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999898 Commit-Queue: Kuo Jen Wei <inker@chromium.org> Auto-Submit: Kuo Jen Wei <inker@chromium.org> Reviewed-by:
-
Anastasia Helfinstein authored
Bug: 1023035 Change-Id: Ie227ad87af4bba0cdb6f864e609b8b4103a2d603 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001412 Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#732726}
-
