- 24 Aug, 2020 40 commits
-
-
Ken Rockot authored
There are (effectively rare) edge cases where SequenceLocalSyncEventWatcher usage results in sequence's event staying signaled despite having no more registered clients to notify. This leaves the thread stuck in a state where any pending sync wait will effectively busy-loop until it gets a reply rather than blocking as intended. This CL fixes the edge cases to ensure that the event in question is always properly reset when appropriate. Fixed: 11202650 Change-Id: Ib8542f6945b92d0fbfcc232143aba8bcf48f23a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369676Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#801107}
-
Claude van der Merwe authored
These files have <if> statements which were included in os_settings_rollup.js because the preprocess="true" argument was omitted. Bug: 1045266 Change-Id: Ic458b7847262989f2ec8f681d8ac4110ef99259a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372587 Commit-Queue: Claude van der Merwe <cvandermerwe@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#801106}
-
Maks Orlovich authored
... To avoid crashing on memory reads from it when out of disk space. Bug: 305841, 1097518 Change-Id: Ie9a671db0d8db0f6fbfd168a69cdd003840b572e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369257 Commit-Queue: Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#801105}
-
Harald Alvestrand authored
Bug: chromium:1115080, chromium:1110833 Change-Id: I6c97e05225b8dc399d94cfb0e0817577a05db285 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368559Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#801104}
-
Theresa authored
This reverts commit 8e6f7aa5. Reason for revert: Suspected of causing test failures on bots, see crbug.com/1121265 Original change's description: > Move PhotoPicker to //components/browser_ui/photo_picker > > No behavior change is intended for Chrome. This simply relocates > code and assets and updates references. > > One fairly major change for WebLayer is that Base.Theme.Chromium > is folded into Theme.BrowserUI, which means that WebLayer may get > some slightly different theming in some places. This is necessary > because the photo picker uses Theme.Chromium.Fullscreen, which > builds on Base.Theme.Chromium. > > For now, DecoderService and the aidls live alongside the other > code, although they won't be usable by WebLayer as-is. They will > have to be shuffled around some more. > > Bug: 1110930 > Change-Id: I7a5c730b0dd67cb63f9323bcd6f98eb187745b57 > Skip-Translation-Screenshots-Check: True > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363639 > Reviewed-by: David Benjamin <davidben@chromium.org> > Reviewed-by: Will Harris <wfh@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Lijin Shen <lazzzis@google.com> > Reviewed-by: Finnur Thorarinsson <finnur@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Auto-Submit: Evan Stade <estade@chromium.org> > Commit-Queue: Evan Stade <estade@chromium.org> > Cr-Commit-Position: refs/heads/master@{#800993} TBR=palmer@chromium.org,dcheng@chromium.org,davidben@chromium.org,finnur@chromium.org,estade@chromium.org,tedchoc@chromium.org,tsepez@chromium.org,wfh@chromium.org,lazzzis@google.com Change-Id: I9ac47dc9f098cdb48b40d4f9a517d06969a20bf4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1110930,1121265 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372808Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#801103}
-
Xiaodan Zhu authored
Bug: 1010200 Change-Id: I602e1fd063b99a57713c6dfa24f6b45b3653a81d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2370150 Commit-Queue: Xiaodan Zhu <zxdan@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#801102}
-
Nnamdi Theodore Johnson-Kanu authored
Change-Id: Ia276e9af51540df765527977105ff2366eecf878 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359751 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#801101}
-
John Z Wu authored
- Test URLs that do not match the security origin are not handled. - Test invalid HTTP methods cause the request to fail. Bug: 1110195 Change-Id: I13ab6c290c752a459e57ba4446dd133bd6d844e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368146Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: John Wu <jzw@chromium.org> Cr-Commit-Position: refs/heads/master@{#801100}
-
Sean McAllister authored
Currently, ChromeOS defines the OS_LINUX directive as well as OS_CHROMEOS. We're working to separate these two, so we're making the fact that OS_LINUX == OS_LINUX || OS_CHROMEOS explicit. This is changes for /printing This CL was uploaded by git cl split. R=weili@chromium.org Bug: 1110266 Change-Id: I1967dae5a54195670fb618ee9f0758bbd2fd28db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2370732 Auto-Submit: Sean McAllister <smcallis@google.com> Reviewed-by:
Wei Li <weili@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#801099}
-
Abigail Klein authored
and fire an IA2 event. Object attributes on text, such as text-align and text-indent allow JAWS to know the current indentation level in VSCode. Firefox already exposes these attributes. This CL is part of an effort to expose these attributes and fire an object attribute changed event when they change. AX-Relnotes: Added functionality that will allow the JAWS screen reader to announce the indentation level of a paragraph in a rich text field, such as in Google Docs or VS Code. Bug: 1090995 Change-Id: Ia545b9a6584a8bfbee07625ae6294ce1d8d6854e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308231Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#801098}
-
Abigail Klein authored
The UI showed a "Detecting speech..." message in the caption bubble as soon as audio started playing to alert the user that Live Caption was beginning to detect speech. This caused a bug in which the caption bubble appeared when audio that does not contain speech began to play, such as short pings. The team decided to remove the "Detecting speech..." message from the UI as a result. This CL removes the text from the UI and removes the OnSpeechRecognitionReady message sent from the ChromeSpeechRecognitionClient to the caption UI, which is no longer necessary. It also introduces a new accessible label for the caption bubble, which is necessary so that the bubble can set the AXNodeData name when the bubble label does not contain any text. Bug: 1055150, 1114232 Change-Id: I85fdab48a34176e67733f4540ec534c6e7e0109f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368464Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Abigail Klein <abigailbklein@google.com> Cr-Commit-Position: refs/heads/master@{#801097}
-
Claude van der Merwe authored
This file has <if> statements which were included in os_settings_rollup.js because the preprocess="true" argument was omitted. Bug: 1045266 Change-Id: Iaaa99a177806d044a87a3af8a87877ab8fe5c39f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372728 Commit-Queue: Claude van der Merwe <cvandermerwe@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#801096}
-
kylechar authored
This CL modifies viz_unittests to remove tests that use either GLRenderer or SkiaRenderer+GL. For pixel tests they will continue to run with SoftwareRenderer and SkiaRenderer+Vulkan for Fuchsia. For other tests, if the tests was specific to GLRenderer it's been removed on Fuchsia as well. For tests that aren't running on SkiaRenderer+Vulkan yet I've left them running on GL backed renderers to avoid losing test coverage. Once the tests are switched over the GL backed renderers can be removed. Bug: 1117587, 1043849 Change-Id: Ic55b8eeb31045b3eec410c01fa4631503d1683c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367638 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#801095}
-
Travis Skare authored
Bug: 1121200 Change-Id: If5da42d788995911176e875f2cc0a19884bdc901 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372586Reviewed-by:
Tanya Gupta <tgupta@chromium.org> Commit-Queue: Travis Skare <skare@chromium.org> Cr-Commit-Position: refs/heads/master@{#801094}
-
Garrett Beaty authored
The fallback CQ group seems to be triggering against the M86 branch, possibly because the regexes intended to match against branches with numbers with fewer digits match the prefix of refs/branch-heads/4240. Bug: 1121272 Change-Id: I30d68fde2c27b523c29811ece6fa1b3f64a45d75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372893 Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Erik Staab <estaab@chromium.org> Commit-Queue: Erik Staab <estaab@chromium.org> Cr-Commit-Position: refs/heads/master@{#801093}
-
Olivier Yiptong authored
This is a reland of 1240db1f Original change's description: > FontAccess: Windows Platform Implementation > > This implements Font Enumeration and Data Access for Windows. The > implementation uses DirectWrite APIs that will work on Windows 7 > with Platform Update KB2670838 and above. > > Furthermore, the enumeration data is cached in the browser > process and shared with renderers using Read Only Shared Memory. > > Font Data Access is implemented using the backend for @font-face > src: local() matching. > > Fixed: 1103400, 1113876 > Change-Id: I31a16a90e980cd50b16a8f99a1633c1954555e11 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364009 > Reviewed-by: Martin Barbella <mbarbella@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Stephen Chenney <schenney@chromium.org> > Commit-Queue: Olivier Yiptong <oyiptong@chromium.org> > Cr-Commit-Position: refs/heads/master@{#800338} Change-Id: I899d3268b07f9686e94438662c57630a074a0cfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368439 Auto-Submit: Olivier Yiptong <oyiptong@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Reviewed-by:
Martin Barbella <mbarbella@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#801092}
-
Lei Zhang authored
There are some CHECKs and an include leftover from debugging. Remove them. Also remove unused SetClockForTesting(). Fix various nits along the way. Bug: 951571 Change-Id: Icfc7fcc75cf35697d3efaf5c271edc90ebe5af26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368913 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#801091}
-
Abigail Klein authored
text objects. Bug: 1090995 Change-Id: I0224f60fa70ac4ab8203c3587a68e9a8f64b34c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367744Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Abigail Klein <abigailbklein@google.com> Cr-Commit-Position: refs/heads/master@{#801090}
-
Adam Langley authored
When building larger QR codes, the previous code would read off the end of a buffer and interleaved blocks incorrectly, thus generating invalid QR codes. Change-Id: Id00dcd5c3d5f4bacde281baaa759c3920d664048 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369258Reviewed-by:
Travis Skare <skare@chromium.org> Commit-Queue: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#801089}
-
Sean McAllister authored
Currently, ChromeOS defines the OS_LINUX directive as well as OS_CHROMEOS. We're working to separate these two, so we're making the fact that OS_LINUX == OS_LINUX || OS_CHROMEOS explicit. This is changes for /chrome This CL was uploaded by git cl split. R=tedchoc@chromium.org Bug: 1110266 Change-Id: I7149d343729a0970bf5fbcd3bc3a254d5bb30271 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371220 Auto-Submit: Sean McAllister <smcallis@google.com> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#801088}
-
Aleks Totic authored
Prerequisite for landing algorithms: column visibility flag. Also, minor fix for computing orthogonal cell sizes in CreateCellInlineConstraint. Bug: 958381 Change-Id: I27de68a819ba5664e568cee58597d6edf6baa203 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368105Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#801087}
-
Weblayer Skew Tests Version Updates authored
Skew tests are being added for the following versions: 1, 83.0.4103.83 2, 84.0.4147.89 3, 85.0.4183.69 R=sky@chromium.org, estaab@chromium.org Bug: 1041619 Change-Id: I0a471bcc48b71d78fdef0363ac9e8733d4c17701 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364128 Commit-Queue: Rakib Hasan <rmhasan@google.com> Reviewed-by:
Erik Staab <estaab@chromium.org> Reviewed-by:
Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#801086}
-
Anders Hartvoll Ruud authored
The spec was recently updated to differentiate between the source being missing and the source being null. The former means that the source should default to document.scrollingElement, and the latter means that there is no source. Note: In the CSS API, this translates to 'auto' and 'none', respectively. Support for this has already landed in a previous CL. Bug: 1100907 Change-Id: I1436b16d06b7a7ae0de55e2706a7b5d87c0290b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367837Reviewed-by:
Kevin Ellis <kevers@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#801085}
-
Alexander Hendrich authored
ExternalCacheImpl's |extensions| reflects the "input" of which extensions it should try to load + cache. |cached_extensions_| reflects the "output" of which extensions are currently cached. When a damaged file is detected, that file + extension should be removed from the cache, which means that it should *only* be removed from |cached_extensions_|, not from |extensions_|. Also removing the extension entry from |extensions_| will result in ExternalCacheImpl's IsExtensionPending() returning an invalid result. Bug: 1115905 Change-Id: I4ca82caf3d27d65a31ba481a0320c273d80b2655 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362906Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Auto-Submit: Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#801084}
-
Mark Cogan authored
In some circumstances, the shutdown logic can run when there are no connected scenes (possibly when force-quitting). Asking for the browser interface in this situation will cause an array overflow. This CL is a quick patch to bypass that pending a cleaner fixup. Bug: 1113097 Change-Id: I3e14c9bbd887c7ef66ee7e6454f4484bad8cb03a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367080 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#801083}
-
Lan Wei authored
When we are using PerformActions from ChromeDriver to simulate three mouse click, it only set the click count to 2, not 3, so this test fails third_party/blink/web_tests/external/wpt/webdriver/tests/perform_actions /pointer_tripleclick.py. PerformActions should keep the mouse click count and decide if we should increase the count or set to 1 when we have a mouse press based on the interval of two mouse presses and difference between the current mouse positions and the last one. We should keep the click count in the session, and calculate the new click count based on the count stored in the session. Bug: 1119679 Change-Id: Iadac8e0f7dd13aebad6dc06c48c572426709a065 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368335Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Lan Wei <lanwei@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#801082}
-
Jeffrey Young authored
Record whether users set art gallery or google photos to provide ambient mode photos. BUG=b:163529280 Change-Id: Iaf6de9e36568b70b9f51c00ee50fd6058d66ac71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355212Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: Jeffrey Young <cowmoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#801081}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/ee4fc2e01505..ac74b9c703be 2020-08-24 chrome-bot@chromium.org Update config settings by config-updater. 2020-08-22 smcallis@google.com Re-enable drallion hardware tests. 2020-08-22 navil@google.com dependency: Get a list of relevant packages based on src_paths. 2020-08-22 bhanumaiya@google.com zork: add firmware-zork-13421.B firmware builder 2020-08-21 chrome-bot@chromium.org Update config settings by config-updater. 2020-08-21 kevinruvalcaba@google.com Completed visualization module for internship. 2020-08-21 chrome-bot@chromium.org Update config settings by config-updater. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: Iec8c59561ba902f6c2a3edbd5f4aca391797cf12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372763Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#801080}
-
Gary Miguel authored
Change-Id: I6ebfaf62eaf0a15ae8b0dea21481ac2913473161 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369733 Commit-Queue: Gary Miguel <garymm@google.com> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#801079}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/1c96e6739bbe..746445da75a4 2020-08-24 hjd@google.com Merge "Fix CSS for Saved configs" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I26f1e9bf1000f32d636ed1c959b87f9a7b6cd1e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372907Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#801078}
-
Liviu Tinta authored
Safari and Firefox fire pointerevents & compatible mouse events in a different order than Chrome. The order matches the PointerEvents specification for all browsers. Modify the test to reflect this difference in the browser implementation. Bug: 1085549, 1085647 Change-Id: I43ed0bbbabb0abbcbd93fbab7e5d8ee98a902611 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359588Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Commit-Queue: Liviu Tinta <liviutinta@chromium.org> Cr-Commit-Position: refs/heads/master@{#801077}
-
Aga Wronska authored
EDU coexistence launched in M83 and feature flags are no longer needed. Removing 'EduCoexistence' and 'EduCoexistenceConsentLog'. Bug: 1115409 Test: Manually Change-Id: I38df4e086162b71a654ddbbb01fc1fb891b7b4c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368081Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Anastasiia N <anastasiian@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#801076}
-
Maksim Sisov authored
The UseTestConfigForPlatformWindows wasn't in use for use_x11 case since https://crrev.com/c/822989 when window_tree_host_x11 was removed and UseTestConfigForPlatformWindows was moved to x11_window_base, which wasn't in use by use_x11. Also, this setting affects X11TopmostWindowFinder tests when they are enabled for Ozone/X11. The way how it affects them is that they simply fail to run and result in incorrect test expectations. It looks like this flag intercepts some events such as map and others... So, given that it's not used for use_x11 case, just leave that for ChromeOS as it has always been used by that (my judgement is based on https://codereview.chromium.org/2683033006) and remove that for another case, which is Linux. Bug: 789065 Change-Id: Ib30a3ec7b4352b91da63582027e17ac6ce5c05c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372385 Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#801075}
-
Peter Kasting authored
In addition to avoiding multiple versions of the same-named function, this is shorter and generally less-overlapping without loss of functionality. Bug: none Change-Id: Ic7252c960d3ca18ea78351ea3386993e9eae91bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363716Reviewed-by:
manuk hovanesian <manukh@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#801074}
-
Peter Wen authored
Many of these lint warnings were turned off because it was difficult to fix all of them when they were introduced (usually via a lint update) and fix incoming new errors at the same time. Adding existing issues to the baseline and enabling for new code. Bug: 1116130,807734,671170,831774,635567 Bug: 1069186,804427 Fixed: 807734,635567,804427 Change-Id: Id955384003a6928ea5ad3efe635a84515663b17b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369576 Commit-Queue: Peter Wen <wnwen@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#801073}
-
Michael Hansen authored
Replaces instances of "CHROME_OS" with "OS_CHROMEOS" in macros in FastInitiationManager. Original umbrella issue: crbug.com/1099858 Bug: 1119969 Change-Id: Ia0c1334f607cfd583a4c8c327dab196fd73ba808 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369736Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#801072}
-
Jeremy Leconte authored
With the landing of crrev.com/c/2364635, WebRTC has the below compile error when rolling chromium. ci.chromium.org/p/webrtc/builders/try/android_arm64_rel/40012 'base::android::JNI_TraceEvent_StartATrace' has internal linkage but is not defined 'base::android::JNI_TraceEvent_SetupATraceStartupTrace' has internal linkage but is not defined The error doesn't occur for functions like JNI_TraceEvent_BeginToplevel hence the proposed fix. Bug: 1095587 Change-Id: Iaf2cc152883ff7b991ce0567577bf937e634d2de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2370622 Commit-Queue: Jeremy Leconte <jleconte@google.com> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#801071}
-
Sean McAllister authored
Currently, ChromeOS defines the OS_LINUX directive as well as OS_CHROMEOS. We're working to separate these two, so we're making the fact that OS_LINUX == OS_LINUX || OS_CHROMEOS explicit. This is changes for /components/security_interstitials This CL was uploaded by git cl split. R=nparker@chromium.org Bug: 1110266 Change-Id: I2a2fada6c9b7dd6b9f90c95be41eac72f30d4b3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2370293 Auto-Submit: Sean McAllister <smcallis@google.com> Reviewed-by:
Nathan Parker <nparker@chromium.org> Commit-Queue: Nathan Parker <nparker@chromium.org> Cr-Commit-Position: refs/heads/master@{#801070}
-
chromium-internal-autoroll authored
Release_Notes:http://go/help_app-x20/relnotes/Nightly/help_app_nightly_202008240800_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/EkzqCcAxSpMTFOlOuO7kRf9laK1GtSbJMxH5sUk2zIgC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/152819348 Tbr: help-app@grotations.appspotmail.com Change-Id: I7a63dafca6d93b97cb21de5338e48ef4e953cb22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372765Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#801069}
-
Charlie Hu authored
Change-Id: I29503665e09272500b6f184c726beadb65bd6a2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367712 Commit-Queue: Charlie Hu <chenleihu@google.com> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#801068}
-