GitLab

The testrunner scripts were using underscores when they should have been
using hyphens.

BUG=934252

Change-Id: Ie3362193c423a76873328a779f48aaef108c3543
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849979Reviewed-by: Peter Lee <pkl@chromium.org>
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704371}

When information about a table was computed in AXTableInfo,
we were not taking account of layout table rows.
Also, went through the whole file and ensured that layout tables are
always accounted for.
Some screen readers, such as on Windows and ChromeVox,
treat layout and data tables the same.

R=dmazzoni@chromium.org, aleventhal@chromium.org

Bug: 1003972
Change-Id: If0bc7241780ccb98fa1649adfe9dd1c3a4b41a44
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847801
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704370}

These are just duplicated code at this point.

Bug: none
Change-Id: If99cae449d438299651d3c81504d7418a170fc82
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848871
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Reviewed-by: manuk hovanesian <manukh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704369}

Why it is okay to remove this method
====================================

The ChromeContentBrowserClientExtensionsPart::OverrideNavigationParams
method ensured that the referrer used in navigations never points at an
extension-specific URL.  This method is not needed - even without this
method, the referrer is never set to an extension-specific - this is
because of the following places in the code (*all* 4 places need to be
tweaked to start using extension-specific URL in the newly added browser
test):

1. //content: blink::mojom::ReferrerPtr Referrer::SanitizeForRequest:

  if (!request.SchemeIsHTTPOrHTTPS() ||
      !sanitized_referrer->url.SchemeIsValidForReferrer()) {
    sanitized_referrer->url = GURL();
    return sanitized_referrer;
  }

2. //third_party/blink:
2a. String KURL::StrippedForUseAsReferrer()

  if (!ProtocolIsInHTTPFamily())
    return String();

2b. URLSchemesRegistry

  allowed_in_referrer_schemes({"http", "https"})

4. //url: GURL GURL::GetAsReferrer()

  if (!SchemeIsValidForReferrer())
    return GURL();


Why new test is desirable
=========================

This CL adds a new end-to-end test:
ExtensionBrowserTest.NoExtensionsInRefererHeader.

This test is desirable, because after tweaking all 4 places above, all
other tests continued to pass, except for a
ReferrerSanitizerTest.OnlyHTTPFamilyReferrer unit test.


Why removing the method is desirable
====================================

If we can remove ContentBrowserClient::OverrideNavigationParams
(overrides deal with extensions and NTP), then we may be able to proceed
with removal of ContentRendererClient::ShouldFork.  Removing the
extension-specific part of OverrideNavigationParams helps toward these
goals.


Bug: 1003957
Change-Id: I31399d62cf86d1caeb935b0218faf18a7f590248
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834890Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704368}

Chrome loads unsigned bundled exchanges local files using "files://" origin.
So scripts in the file can't read/write the storages of arbitrary origins.

There is no larger risk compared to normal HTML local file.
So we don't need to show the bad flags prompt.

Bug: 995177
Change-Id: I4738c361914cd661fce32066807ba8488a7efbd0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847601Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704367}

All callers that were getting there through RenderView should instead
go through RenderFrame or RenderWidget to get to the methods.

R=avi@chromium.org
TBR=estade, rdevlin.cronin

Bug: 419087
Change-Id: I2b3c2198fcbfea65c7773b1a0ca8e2e15dcfd333
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850109Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704366}

The kernel release might include the '+' character, such as:
4.19.37-5+deb10u2rodete2-amd64

R=ganesh
BUG=1012751

Change-Id: If38c3b0358d518456fa5fe0ae133a7c08f0d953c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850631Reviewed-by: S. Ganesh <ganesh@chromium.org>
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704365}

We're updating the certificate for revoked.badssl.com (the previous
certificate expired on 2019/09/11) in
https://github.com/chromium/badssl.com/pull/410, and we should likewise
update the certificate/SPKI in the blocklist.

We are also updating the manually added list in CRLSet.

Change-Id: I95c50250cc0139cf82dac214c785efa2704ea599
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846018Reviewed-by: Adam Langley <agl@chromium.org>
Commit-Queue: Christopher Thompson <cthomp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704364}

Password protection is expanding to also cover
saved passwords so we need metrics to track it.

Bug: 1010764
Change-Id: Ib10a62a7bff930152953f93169e5b544e8c9d7e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847949
Commit-Queue: Bettina Dea <bdea@chromium.org>
Reviewed-by: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704363}

This PR enables navigation to the source of the computed styles using keyboard.

1. Adds a context menu item to navigate to the style in styles pane
2. Adds a context menu item to navigate to the style source in the sources panel

Gif: https://imgur.com/a/E2KGmrv

Bug: 963183
Change-Id: Iea561af075fcb89b0cd5ebe7a63fb8afbdb2aa05
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825790Reviewed-by: Lorne Mitchell <lomitch@microsoft.com>
Commit-Queue: Anubha Mathur <anubmat@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#704362}

This is a cleanup CL, and doesn't change behavior. It's not encouraged to call
Modulator::GetScriptState() outside of Modulator, so this CL removes callsites
from the (Service)WorkerModuleTreeClient.

Bug: n/a
Change-Id: Id15b91e0bbe04cb1dc543e013133549021562231
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847600Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704361}

If logged in with a child account, the chrome://extensions page shows
developer mode is disabled with an office building icon (used for
enterprise users) and the tooltip "This setting is enforced by your
administrator." The icon and tooltip should be Unicorn-specific. This
CL changes the icon to show the kite icon and tooltip "This setting
can't be changed by a child user."

Bug: 928543
Change-Id: Ic518d78c1304a957ba0cd007372232cbbb31a15e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842494
Commit-Queue: Toby Huang <tobyhuang@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704360}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/5c5de38d..ebc6287a

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Ia8f3cd23ffd91e120b63876497a445d2430e857a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850254Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#704359}

https://chromium.googlesource.com/chromium/deps/libjpeg_turbo.git/+log/38c693569427..9d3bf3e96801

$ git log 38c693569..9d3bf3e96 --date=short --no-merges --format='%ad %ae %s'
2019-10-07 efoo Add "# COMPONENT" to libjpeg OWNERS file

Created with:
  roll-dep src/third_party/libjpeg_turbo

TBR=efoo@chromium.org

Change-Id: I5d951466384680a28346ea922f950690a9089a90
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846817
Commit-Queue: Chris Blume <cblume@chromium.org>
Reviewed-by: Chris Blume <cblume@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704358}

This is just cleanup in preparation for larger data handle changes.
There's no need for ShareableFileReference to subclass
BlobDataItem::DataHandle as it doesn't implement any of its interfaces.
Its goal is to preserve the lifetime of the ScopedFile, and it's clearer
to do this by holding onto the ShareableFileReference in BlobDataItem
directly.

Bug: 1012869
Change-Id: Ieaad64adede4358d734aff8e3cc21bd9038566cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850198
Commit-Queue: enne <enne@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Auto-Submit: enne <enne@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704357}

Adds @provideGoog to compile_preamble.js to tell the compiler that the
file provides the goog namespace. Without this, compile_preamble.js is
compiled after bindings_lite.js and causes runtime errors when
"goog" methods get called by bindings_lite.js.

This issue only comes up when compiling with SIMPLE_OPTIMIZATIONS.
Compiling with ADVANCED_OPTIMIZATIONS worked correctly.

Change-Id: Ia26bdc31e13002c60503813a41ba9613cd764a88
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847608Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704356}

In order to decide whether an image will go through hardware decode
acceleration, we currently obtain the encoded data, parse it, and
extract relevant information to compare it against the supported
profiles advertised by the GPU process through GPUInfo.

This is unfortunate because getting the encoded data may require a copy
if the data is not already contiguous in memory. Not only that, but the
copy would need to be done even if the image will ultimately not go
through hardware decode acceleration.

This CL solves this issue by abstracting and plumbing the necessary
information to make the decision up from the DeferredImageDecoder to
PaintImage, and then passing it to the ImageDecodeAcceleratorProxy for
final decision.

Finally, we only make a contiguous copy of the encoded data if hardware
accelerated decoding is supported.

Bug: 995149, 995887
Change-Id: I99f85e1324126b038a576149b0666245639dc03a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778988
Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org>
Reviewed-by: Andres Calderon Jaramillo <andrescj@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Reviewed-by: Leon Scroggins <scroggo@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704355}

This is a reland of ffcd2de7

Problem that caused revert fixed by https://crrev.com/c/1849114

TBR=morlovich@chromium.org,mbarbella@chromium.org

Original change's description:
> Add GetAllCookiesWithAccessSemantics to CookieManager interface
>
> This CL adds a method, GetAllCookiesWithAccessSemantics, to the mojo
> interface CookieManager. This just directly calls
> CookieStore::GetAllCookiesWithAccessSemanticsAsync() on the
> CookieManager's underlying CookieStore.
>
> Bug: 978172
> Change-Id: Ic26298caf12d34ffd4de5bcf81058f6984528683
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845803
> Commit-Queue: Lily Chen <chlily@chromium.org>
> Reviewed-by: Maks Orlovich <morlovich@chromium.org>
> Reviewed-by: Martin Barbella <mbarbella@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#703916}

Bug: 978172
Change-Id: Id1e92255ad6a15caba08c3e11bd47d27e549a274
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850315Reviewed-by: Lily Chen <chlily@chromium.org>
Commit-Queue: Lily Chen <chlily@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704354}

BUG=1000662

Change-Id: Ifadcbec9a42cc7055138a6db121622621bd67892
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850413
Commit-Queue: Theresa  <twellington@chromium.org>
Commit-Queue: Sky Malice <skym@chromium.org>
Auto-Submit: Theresa  <twellington@chromium.org>
Reviewed-by: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704353}

Send the ShelfAction to Shelf -> ShelfLayoutManager. Then hide the
hotseat if an app is launched or swapped to.

Bug: 1011901
Change-Id: I32dd58045f75d7cf915ee4523acd21b58a370077
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847946
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Reviewed-by: Manu Cornet <manucornet@chromium.org>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704352}

The allowing of popups on close was brute-force merged to M78
with no flags. This change doesn't prohibit popups on close (that's
still returning in M80), but makes it a feature in about:flags that
can be flipped for testing.

BUG=1012762

Change-Id: I5b99c162e6fee8eabc37c7887c6bece08b478521
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848935
Commit-Queue: Avi Drissman <avi@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704351}

testActionsMultiTouchPoint is flaky, I change the test to wait 1500
more ms for the event handler to be executed before checking the length
of the touch events.

Bug: 1011225
Change-Id: I6989c958b5b5aedb35d7529cc59cf8ea9f501ec2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850571Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Lan Wei <lanwei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704350}

This is for a CL that fixes typo and documentation in auditor code:
https://chromium-review.googlesource.com/c/chromium/src/+/1814721

TBR=rhalavati@chromium.org

Bug: 1005537
Change-Id: Ie5555625b001ec472d5f649b2dd8dcb22f3a8055
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849978Reviewed-by: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704349}

Adds an |allow_threads_before_starting_sandbox| option to the
Linux sandbox, which enables TSYNC if there are already
multiple threads in the process.

Also adds |check_for_open_directories| option to the Linux
sandbox, which can be set to false to skip the check for
open directories, which is only relevant if we are engaging
the semantic layer of the sandbox, which we don't for the
GPU sandbox. And if we start the GPU sandbox with multiple
threads, and the above option will allow, then those other
threads may have opened directories and we don't want that
to be a failure.

Based on jorgelo@'s CL:
chromium-review.googlesource.com/c/chromium/src/+/1496305

Bug: 924759, 996455
Change-Id: Icee663f87d396f97ad7bb257c2709c15b06fab33
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829866
Commit-Queue: Matthew Denton <mpdenton@chromium.org>
Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Julien Isorce <julien.isorce@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704348}

This is a reland of d5023862

Original change's description:
> Update connectivity checker.
>
> 1) Use url_loader instead of URLRequest.
> 2) Use network_connection_tracker instead of
>    network change notifier.
>
> Bug: internal b/139539332
> Change-Id: Ia84e3d62d22fd97d440ecf7e148ce8e663a9568d
> Merge-With: eureka-internal/255804
> Merge-With: eureka-internal/305059
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762598
> Commit-Queue: Mohit Hotwani <hmohit@chromium.org>
> Reviewed-by: Maks Orlovich <morlovich@chromium.org>
> Reviewed-by: Junbo Ke <juke@chromium.org>
> Reviewed-by: Luke Halliwell <halliwell@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#690453}

Bug: internal b/139539332
Merge-With: eureka-internal/255804
Merge-With: eureka-internal/305059
Change-Id: I84a237477783cf15b5452a30d5de40b9497481f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1843171Reviewed-by: Maksim Orlovich <morlovich@chromium.org>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Commit-Queue: Junbo Ke <juke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704347}

https://webrtc.googlesource.com/src.git/+log/5963c7cf0a70..16d4c4d4fbb8

git log 5963c7cf0a70..16d4c4d4fbb8 --date=short --no-merges --format='%ad %ae %s'
2019-10-09 elrello@microsoft.com Implement rollback for setRemoteDescription

Created with:
  gclient setdep -r src/third_party/webrtc@16d4c4d4fbb8

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=webrtc-chromium-sheriffs-robots@google.com

Bug: chromium:980875
Change-Id: I936c92f71d22803f59a25c60455ad018d9922478
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850451Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#704346}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/baaf6bec019f..cb1eb4896663

git log baaf6bec019f..cb1eb4896663 --date=short --no-merges --format='%ad %ae %s'
2019-10-09 ehmaldonado@chromium.org Reland "gclient_utils: buffer output as bytestrings in Annotated"

Created with:
  gclient setdep -r src/third_party/depot_tools@cb1eb4896663

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC agable@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=agable@chromium.org

Bug: chromium:984182
Change-Id: Idd3ec3bb5beb61d2bcc09097dab5a0a449e6f5c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850195Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#704345}

In Optimization hints manager, fetch hints for
only the hosts that are due for refresh.
This is expected to reduce the number of network
calls that Chrome makes.

Right now, the code assumes that the hints are due for refresh
if they are going to expire in the next 72 hours.

Change-Id: I42f72d2ef78382adda82a276c730ac5c2af2cd45
Bug: 1004469
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844340
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Michael Crouse <mcrouse@chromium.org>
Reviewed-by: Sophie Chang <sophiechang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704344}

Prior to this change the Device properties were only fetched the first
time the page was displayed and when a device property changes.
(Navigating to the page with a new network type would not always fetch
the correct device properties). This ensures that the device properties
are always fetched.

The MAC address comes from Device properties and thus was not always
updated correctly.

This also makes the code in the details page and the details dialog
consistent.

Bug: 1012045
Change-Id: I9c39bee6f1077518add306100ff05802a4dc506f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849265
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704343}

This will allow GpuMemoryBufferFactoryTest and GpuMemoryBufferImplTest
to run on ozone platforms (e.g. Chromebooks).

BUG=958387

Change-Id: Iff5704b5ac3bdd04ebdd1151be844ddc8888613c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1806423Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Jonathan Backer <backer@chromium.org>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Commit-Queue: Mohsen Izadi <mohsen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704342}

This CL converts base::Bind to BindOnce or BindRepeating, and also changes
relevant base::Callbacks or base::Closures to appropriate types.

This CL is split from https://crrev.com/1831621.

This CL was uploaded by git cl split.

R=csharrison@chromium.org

Bug: 1007760
Change-Id: I7a5689ed0f5fe3d14063312230f774a61e1b0111
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849477
Auto-Submit: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704341}

Changes from https://crrev.com/c/1825661 ensured PDF compositor
failures are propagated to the print preview UI.  A new crash scenario
is from trying to propagate a failure notification being made when the
enclosing tab is already being closed.

Managed to reproduce the crash by introducing in a developer build a
long delay in PdfCompositorImpl::HandleCompositionRequest() (of several
seconds).  This allows for a human to time the destruction of the
window at a time when the PDF compositor is active.

Resolve by dropping the failure notification if the associated web
contents is known to be destroyed or in the process of being destroyed.

Bug: 1011583
Change-Id: I9dea997c00c3c117ae144ad21b7a5c82f0f569c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848433Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Alan Screen <awscreen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704340}

Added thread_checker in StreamProcessorHelper, SysmemBufferPool and
SysmemBufferWriterQueue. Also added sequence_checker in
Fuchsia*StreamDecryptor.

Change-Id: I467e53f3512bac5f105d18f6fa5d67fc01fa3d6f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838625
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Yuchen Liu <yucliu@chromium.org>
Reviewed-by: David Dorwin <ddorwin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704339}

During "normal" dragging from overview (not drag-to-close), the cannot
snap warning shall be suppressed on the dragged overview item.

Test: ash_unittests SplitViewOverviewSessionTest.OverviewUnsnappableIndicatorVisibilityWhileDragging/?
Bug: 1012413
Change-Id: I9036d6160231f3074e5e6f4472efe43c80571f32
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849414
Commit-Queue: Avery Musbach <amusbach@chromium.org>
Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704338}

I think there's enough content here for it to live on its own page.
This also adds more advice.

Change-Id: I84caac9fc80f92f8fcc7b3a3fbd07f45068425b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849095
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Sam Maier <smaier@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704337}

https://chromium.googlesource.com/external/github.com/google/shaderc/+log/621605ce2644..05b285760e40

git log 621605ce2644..05b285760e40 --date=short --no-merges --format='%ad %ae %s'
2019-10-09 rharrison@google.com Rolling 5 dependencies (#836)
2019-10-09 rharrison@google.com Add spvc compiler to returned result (#828)

Created with:
  gclient setdep -r src/third_party/shaderc/src@05b285760e40

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/shaderc-chromium-autoroll
Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=radial-bots+chrome-roll@google.com

Bug: None
Change-Id: I7d82ab364210d15bcbac2beaa1b6702f172516e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850104Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#704336}

This PR removes OVR_multiview2 as a draft extension and will now be available by default.

Bug: chromium:949249
Change-Id: I0b7ab9c35cc5b653dce0c6783fae187ee0d8c39b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849107Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Mingyu Hu <mihu@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#704335}

Bug: 1007887
Change-Id: Ic9ef9efe8069eb391a5b361950b7575a6a748f50
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850511Reviewed-by: Denis Kuznetsov <antrim@chromium.org>
Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704334}

This reverts commit 5ea745a6.

Reason for revert: The CL this one was dependent on, whose revert caused
this CL to be reverted, was relanded (crrev.com/c/1829544).

Original change's description:
> Revert "Disable stack sampling profiler under App Verifier"
>
> This reverts commit 17178955.
>
> Reason for revert: The CL this one was dependent on caused crashes and had to
> be reverted: crrev.com/c/1828234
>
> Original change's description:
> > Disable stack sampling profiler under App Verifier
> >
> > The StackSamplingProfiler has been observed to cause crashes when
> > running under Application Verifier, a Windows utility used to detect
> > subtle programming errors. Samples collected by the
> > StackSamplingProfiler while Application Verifier is running are unlikely
> > to hold any value, as Application Verifier slows down execution
> > significantly.
> >
> > Because StackSamplingProfiler and Application Verifier are not
> > compatible, this change detects whether Application Verifier is running,
> > and does not start up StackSamplingProfiler if so.
> >
> > This is not expected to impact data collection, as Application Verifier
> > is used only by a few developers.
> >
> > Bug: 1004989
> > Change-Id: I014b3cee440e99d832ae8d84a03fe70777676a2b
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783735
> > Commit-Queue: Jesse McKenna <jessemckenna@google.com>
> > Reviewed-by: Lei Zhang <thestig@chromium.org>
> > Reviewed-by: Mike Wittman <wittman@chromium.org>
> > Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#700356}
>
> TBR=thestig@chromium.org,wittman@chromium.org,brucedawson@chromium.org,jessemckenna@google.com
>
> Change-Id: I1c55ab21a28ceef6c3d49f83cdb5c7689ec2402f
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1004989
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827187
> Reviewed-by: David Bienvenu <davidbienvenu@chromium.org>
> Commit-Queue: Jesse McKenna <jessemckenna@google.com>
> Cr-Commit-Position: refs/heads/master@{#700491}

Change-Id: I7fbb6a7503b754bfc952e718b9bebd30e69742c0
Bug: 1004989
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829243Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: David Bienvenu <davidbienvenu@chromium.org>
Commit-Queue: Jesse McKenna <jessemckenna@google.com>
Cr-Commit-Position: refs/heads/master@{#704333}

Since we split settings between browser vs. OS, the settings page which
alerts the user about whether an OS update is available is part of OS
settings. However, some existing users were used to visiting
chrome://settings/help to check for this information. To ensure that
these users are not confused, this CL adds a link from the "About Chrome"
settings page to the "About Chrome OS" settings page.

Bug: 1010996
Change-Id: Ia7efc888195f444668d7b89617a698d03d4b9466
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847906Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704332}