- 22 Jan, 2020 40 commits
-
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/84dafa149509..56d4671ce783 git log 84dafa149509..56d4671ce783 --date=short --first-parent --format='%ad %ae %s' 2020-01-22 treehugger-gerrit@google.com Merge "tp: allow embedders to disable parsing typed ftrace into raw" 2020-01-22 primiano@google.com Merge "ui: small fixes to service worker / offline support" 2020-01-22 lalitm@google.com Merge "ui: fix async and global slice tracks" 2020-01-22 eseckler@google.com Merge "processor: Fix order of async events in json export" 2020-01-22 lalitm@google.com Merge "tp: add sorted flag to ref_set_id and fix costing of sorted cols" Created with: gclient setdep -r src/third_party/perfetto@56d4671ce783 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I50b408208d9cbb77d1cc91c8e00fe4f20bc61684 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015005Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#734091}
-
Robert Ogden authored
NavigationPredictor is currently tied to a RFH via mojo channels but the lifetime of a RFH is difficult to reason about, especially during a navigation to a different origin. This CL moves NavigationPredictor to a WebContents-centric approach with the added benefits of easier lifetime management and easier use in dependent code. Of important note: * The mojo channels that manage the lifetime of a NavigationPredictor are still tied to the main frame RFH since that maps to how renderers actually work. * A NavigationPredictor can enter a "lame duck" state where it is observing a WebContents that has been destroyed, but has yet to be destroyed itself by mojo. Thankfully, this is easily detected since a WebContentsObserver's web_contents() method returns nullptr when this occurs. Both places where web_contents() is used are now guarded by this check. * Multiple RFHs may belong to one WebContents, but only one NavigationPredictor will be created for each WebContents because the RFH must be the single mainframe to construct a NavigationPredictor. Bug: 1023485, 1041828 Change-Id: I6234225132048c70539395a3d1869602e7b0a0ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008775 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#734090}
-
Dave Tapuska authored
Get rid of multiple definitions of ResourceTimingInfo in blink and content. Move it to a single mojom implementation and move callees to use the mojo versions. BUG=1040100 Change-Id: Id4ecf49ee8ff651dde67aa3816278a60e7b31b87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003562Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#734089}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/3ff3368a..6b291043 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I1e103c473051ee0437aab7fe70733cc78fca2bb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015060Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#734088}
-
Stephen Nusko authored
v8.browsing_desktop/browse:search:google v8.browsing_desktop-future/browse:media:youtubetv:2019 NOTRY=true TBR=crouleau@chromium.org CC=mythria@chromium.org,ulan@chromium.org BUG=1044653 Change-Id: I131ca13b3e42865db1c8ea47c7353336a2f1a4f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015082Reviewed-by:
Stephen Nusko <nuskos@chromium.org> Commit-Queue: Stephen Nusko <nuskos@chromium.org> Auto-Submit: Stephen Nusko <nuskos@chromium.org> Cr-Commit-Position: refs/heads/master@{#734087}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/ba5dc20d6d6f..2e45f00d3687 git log ba5dc20d6d6f..2e45f00d3687 --date=short --first-parent --format='%ad %ae %s' 2020-01-22 aerotwist@chromium.org Fix JS config script 2020-01-22 tvanderlippe@chromium.org Generate proper tsbuildinfo and copy output files 2020-01-22 tvanderlippe@chromium.org Migrate heap_snapshot_worker/ to ESM internally 2020-01-22 tvanderlippe@chromium.org Remove whitespace at the end of the package.json lines 2020-01-22 aerotwist@chromium.org Migrates text_utils to ESM internally 2020-01-22 tvanderlippe@chromium.org Reland "Migrate accessibility/ to ESM internally" Created with: gclient setdep -r src/third_party/devtools-frontend/src@2e45f00d3687 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1006759,chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ibbc9efc3952f919bd4699acd1105a70896e25db1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015003Reviewed-by:
-
Mason Freed authored
Prior to this CL, out of range floating point numbers gave a confusing error message with details about the regex being used: The specified value "1.79E+309" is not a valid number. The value must match to the following regular expression: -?(\d+|\d+\.\d+|\.\d+)([eE][-+]?\d+)? Now they just give this error: The specified value "1.79E+309" cannot be parsed, or is out of range. Fixed: 785972 Change-Id: I7eaa56d170317d7387c0a096956a96d0f68099d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010064 Commit-Queue: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#734085}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/6ce033a863ac..ede69c0fbe58 git log 6ce033a863ac..ede69c0fbe58 --date=short --first-parent --format='%ad %ae %s' 2020-01-22 hbos@webrtc.org [Overuse] Setting the target bitrate through the interface. 2020-01-22 titovartem@google.com Propagate multicodec support to other places of PC level framework 2020-01-22 ilnik@webrtc.org Fix video_replay to build and actually work 2020-01-22 minyue@webrtc.org Add absolute capture time to video sender path. 2020-01-22 peah@webrtc.org Reduce the complexity of the multichannel echo subtractor test Created with: gclient setdep -r src/third_party/webrtc@ede69c0fbe58 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I607319caafff507fec03be00ea3cdde652a06827 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015004Reviewed-by:
-
Gabriel Marin authored
BUG=1043700 Change-Id: Ia0eb308bb4f171eaa32e5950d7345b81a7cc5ef0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012839 Commit-Queue: Gabriel Marin <gmx@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#734083}
-
Scott Graham authored
This was showing up as a -Wconversion error on gcc, when used via saturated_cast<int16_t>(...). Change-Id: Ie643478c1678387ddc4b0386998c77bd74d92700 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008277Reviewed-by:
Justin Schuh <jschuh@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#734082}
-
Dave Tapuska authored
This error description was largely unused (except for the Android PolicyAuditor) and the computation of it generates a localized string based on the user's locale. If we move the error description we can move the call of the API entirely into blink. BUG=1043768 Change-Id: I39c3e336ed212fc7c172761e01dba3fb8e365f17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011280Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#734081}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/b766e5e7fbf4..8fff8c3b7dc8 git log b766e5e7fbf4..8fff8c3b7dc8 --date=short --first-parent --format='%ad %ae %s' 2020-01-22 capn@google.com Don't use VK_TRUE comparisons Created with: gclient setdep -r src/third_party/swiftshader@8fff8c3b7dc8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I4581fee781df386a7d16646ceb9bda6575e61fe3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014678Reviewed-by:
-
Robert Liao authored
BUG=177450 Change-Id: I91fd7a22a58e1c9dc43bcfe279192e25dc9a5eff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1968153 Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Auto-Submit: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#734079}
-
Stephen Nusko authored
This reverts commit f0f19cb1. Reason for revert: pinpoint was unable to find cause of increased flakiness. Original change's description: > Disable rendering.mobile/canvas_animation_no_clear on android nexus 5x. > > NOTRY=true > TBR=crouleau@chromium.org > CC=sadrul@chromium.org,vmiura@chromium.org > BUG=1039344 > > Change-Id: Ib4d1567010f972ad1d58305f2d17d0430e45039f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985677 > Reviewed-by: Stephen Nusko <nuskos@chromium.org> > Commit-Queue: Stephen Nusko <nuskos@chromium.org> > Auto-Submit: Stephen Nusko <nuskos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#728567} TBR=crouleau@chromium.org,nuskos@chromium.org NOTRY=true CC=sadrul@chromium.org,vmiura@chromium.org Bug: 1039344 Change-Id: I6a215825a773b4a43b599b773c84709a9e58e09d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015102Reviewed-by:
-
Sebastien Lalancette authored
This reverts commit 4ccbed03. Reason for revert: Introduced a regression (test failing) Bug: 1044650 Original change's description: > Fix selected state when focused for ARIA gridcell and treeitem > > Before this change, focused gridcell were perceived as selected by ATs. > This is because we assumed that a focused gridcell was also selected, > but that can't be the case. > Gridcells are mentioned here, but all ARIA grid roles and treeitem were > affected by this misinterpretation of the specs. > > According to ARIA 1.0 and above, all ARIA grid cells, rows and columns > are selectable, but not necessarily selected. We can't assume a > relationship between the focused state and the selected state as they > are completely independent. We can only do so when the aria-selected > attribute is implied or required. To the best of my knowledge, it only > is implied and/or required for: > - ax::mojom::Role::kListBoxOption: > - ax::mojom::Role::kMenuListOption: > - ax::mojom::Role::kTab: > > This CL introduces AXLayoutObject::SelectionShouldFollowFocus(). > This method was implemented following the ARIA specs, so that only the > elements with an implied and/or required aria-selected attribute value > are also marked as selected when focused. > > Bug: 1030378 > Change-Id: I5875cf3f6198aeea73100806d365bb73f7a6c389 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1996138 > Reviewed-by: Aaron Leventhal <aleventhal@chromium.org> > Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com> > Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#734001} TBR=aleventhal@chromium.org,kschmi@microsoft.com,benjamin.beaudry@microsoft.com Change-Id: I5728dba84f6faa4d8503a5aa867f5ca067ff0ae5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1030378 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014175Reviewed-by:
Sebastien Lalancette <seblalancette@chromium.org> Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Cr-Commit-Position: refs/heads/master@{#734077}
-
weiliangc authored
This reverts commit 064c1945. Reason for revert: crbug.com/1044380 Original change's description: > viz: OverlayProcessor Sends Candidate Directly for Android Pre-SC > > For Andorid Pre-SurfaceControl, overlay processor can send the > overlay candidates directly. > > This is CL 6/? for sending the overlay candidates directly to gpu thread. > > R=rjkroege > > Bug: 979788 > Change-Id: I76d97e8c8cfece078f6ea8d90bf8d3e7ae02dbfc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985305 > Commit-Queue: weiliangc <weiliangc@chromium.org> > Reviewed-by: Robert Kroeger <rjkroege@chromium.org> > Cr-Commit-Position: refs/heads/master@{#733619} TBR=rjkroege@chromium.org,weiliangc@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 979788 Change-Id: I9cc2033bf6145b5d0b59e0680b7265403927b913 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013811Reviewed-by:
weiliangc <weiliangc@chromium.org> Commit-Queue: weiliangc <weiliangc@chromium.org> Cr-Commit-Position: refs/heads/master@{#734076}
-
Omer Katz authored
Blink concurrent marking tsan bot currently times-out on some tests. Copying relevant exceptions from bot "Linux TSan Tests" to make sure the bot has enough resources to finish the tests. Bug: 986235 Change-Id: Id805c02f0b8bd0786194d9115b78269673e26bc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013054 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#734075}
-
Mason Freed authored
The [1] CL enabled the FormControlsRefresh feature by default for Windows, Linux, and ChromeOS. In the process, many layout tests were disabled, because the form controls have a different appearance with the feature enabled. This is one of several patches rebaselining those disabled tests. SHERIFFS: If one of the tests touched in this CL becomes/is flaky, *please* add it to TestExpectations beneath the section for bug 1035582, and mark it with a *new* bug number. At this point, any further failing tests are flaky on their own, not because of this rebaseline. Thanks! [1] http://crrev.com/c/1967608 Bug: 1035582 Change-Id: Icf39d2aca9cf8c3d12c3f4e0709e3601ef30a014 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008353 Commit-Queue: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#734074}
-
Mohammad Refaat authored
Use SessionRestorationAgent to restore the session directly using the browser instead of calling it through tabModel. Bug: 1010164, 783777 Change-Id: Ib1dd37941eccd3e85d0c6c72c2d463ea2cfc69f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007519Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#734073}
-
Oleh Lamzin authored
Introduce wilco_dtc NetworkContext to be able to continue establish TLS connection when server ask client authentication certificate. Bug: b:144545936 TEST=browser tests TEST=verified manually on the device that we are able to setup connection and receive response from the server Change-Id: I039c683fed6859641ea42a1bb79536a7629419de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1964071 Commit-Queue: Oleh Lamzin <lamzin@google.com> Reviewed-by:Pavol Marko <pmarko@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#734072}
-
Alexei Svitkine authored
Bug: 1037118 Change-Id: If86843e59b7880878e39eda8d39aad72208f577e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003399Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Auto-Submit: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#734071}
-
Ben Wagner authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/50b013871c53..e5038be70414 $ git log 50b013871..e5038be70 --date=short --no-merges --format='%ad %ae %s' 2020-01-19 wl Update all copyright notices. 2020-01-04 wl [base] Fix `FREETYPE_PROPERTIES=type1:hinting-engine=adobe`. Created with: roll-dep src/third_party/freetype/src R=bungeman@chromium.org,drott@chromium.org CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_msan_rel_ng Change-Id: Id71ab1c45b05cb211948381805f3fe2a491845d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014054 Commit-Queue: Ben Wagner <bungeman@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#734070}
-
Marc Treib authored
Before this CL, the pref kAccountStorageOptedInAccounts was a map from hash of account ID to bool. Now it is generalized to a map from hash of account ID to dictionary, and the previous bool is just one entry in the dictionary. This will make it easy to add other account-keyed settings later. Since the previous pref was never launched, there's no need for any migration logic. Bug: 1035407 Change-Id: Ib60f30c644bdf457da841b709c433f35572df543 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014449 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#734069}
-
Matt Menke authored
It's only used on Cast, which we're not currently focusing on, but presumably we'll roll out network isolation there at some point as well. Bug: 997049 Change-Id: Ic9d2845fa7010c06030046d770cc8122aa462869 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994430 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#734068}
-
George Steel authored
Fix of https://chromium-review.googlesource.com/c/chromium/src/+/1986325 due to ClusterFuzz DCHECK failure (flaky). SVGElement::RemovedFrom was not tearing down elements_with_relative_lengths_ correctly when those references crossed a shadow root. Downgrade the SECURITY_DCHECK on the relative lengths list to a regular DCHECK as it was preventing dangling pointers to Elements in the pre-oilpan days and is no longer protecting against any kind of security issue (the pointers are now WeakMembers). Bug: 1043184 Change-Id: I0ba614a0217dea4df80a743b0628f7fe94117cd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008624Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: George Steel <gtsteel@chromium.org> Cr-Commit-Position: refs/heads/master@{#734067}
-
Robbie Gibson authored
The reason the DCHECK was being hit is because this forwarder wasn't being properly cleaned up. Fixed: 1044606 Change-Id: Iae58f7af86a6bc0af57a6f93756c0954fba43413 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013132 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
-
Sebastien Lalancette authored
See details in bug (flakes portal link, sample failure). TBR=nicolaso@chromium.org Bug: 1044619 Change-Id: I10c5cca2dab7f90749e6e603db288596daf00bd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013757Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/ed94ccdde306..7d45184d4baa git log ed94ccdde306..7d45184d4baa --date=short --first-parent --format='%ad %ae %s' 2020-01-22 jmadill@chromium.org Vulkan: Fix naming in CommandGraphResource. 2020-01-22 aleino@nvidia.com Reduce fail expectations dEQP-GLES31.functional.program_interface_query.buffer_variable.* 2020-01-22 aleino@nvidia.com Reduce D3D11 skips in dEQP-GLES31.functional.program_interface_query.buffer_variable.* 2020-01-22 sugoi@google.com Extensions suffixes Created with: gclient setdep -r src/third_party/angle@7d45184d4baa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: timvp@google.com Change-Id: I5b1b46619d6ca30110cf1348e137dcb2fc8d2405 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014674Reviewed-by:
-
Bailey Berro authored
Extends metric capturing usage of Screen Lock keyboard shortcuts until the end of June. Bug: 1041515 Change-Id: I9b39dc2e4d4975cbd25b27cb2ae262e04900ed3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997765 Auto-Submit: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#734063}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/c8ebd366bc29..b9cc8d75a2ad git log c8ebd366bc29..b9cc8d75a2ad --date=short --first-parent --format='%ad %ae %s' 2020-01-22 phoglund@google.com Fix gn gen --check breakage on the unit test target. Created with: gclient setdep -r src/third_party/catapult@b9cc8d75a2ad If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC nuskos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1029452 Tbr: nuskos@google.com Change-Id: I33e6ad9870edac3075ba3e264c486683904d9aae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013559Reviewed-by:
-
evliu authored
This CL adds a pre hook for the SODA sandbox that dlopens the libsoda.so and grants the necessary broker file permissions required by the speech recognition library. Bug: 1039824 Change-Id: I8999cec6b6e8c29b7fbe4dc47dff2b971a6e963d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995953Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Evan Liu <evliu@google.com> Cr-Commit-Position: refs/heads/master@{#734061}
-
Xianzhu Wang authored
The only test ScrollingCoordinatorTest.UpdateUMAMetricUpdated is duplicated with the same test in scrolling_test.cc. Most of the tests in scrolling_coordinator_test.cc were moved into scrolling_test.cc in crrev.com/b2a068a8 because the tests are not just unit tests of ScrollingCoordinator. This test was to be kept in scrolling_coordinator_test.cc but was also copied unintentionally into scrolling_test.cc. This CL just removes scrolling_coordinator_test.cc for simplicity. Change-Id: I4f7d3010f7a22d56ec225e9418773730af860a24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013805 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#734060}
-
Nikita Podguzov authored
This CL adds: * IDL declaration of submitJob() function * Its implementation Bug: 996785 Change-Id: Ic3077e6c5999d83578e6e0e48338a6430f7747e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959979 Commit-Queue: Nikita Podguzov <nikitapodguzov@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#734059}
-
Pâris MEULEMAN authored
The spec states about COEP "If creator is not null, set document’s embedder policy to creator embedder policy.". This is done in this patch. Note: This is required for COOP, because it cares about COEP in the case of "same-origin" and needs it to be available on the initial empty document of a new popup. Also adds a WPT about a potential COEP exploit using WindowProxy to circumvent COEP restrictions on fetching. Bug: 922191 Change-Id: Ie3097618be825c5031449d997970e33fad3d4f8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007747 Commit-Queue: Pâris Meuleman <pmeuleman@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#734058}
-
Aran Gilman authored
This should either fix the attached bug or at least help with debugging by DCHECKing when the icon is destroyed without being removed from all observer lists. Bug: 1017341 Change-Id: I8a7457f7f82f3dc4936fb60112742af2a05a7d70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006468Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Aran Gilman <gilmanmh@google.com> Cr-Commit-Position: refs/heads/master@{#734057}
-
Elly Fong-Jones authored
These both have unqualified usernames but the actual correct email addresses are at domains other than chromium.org. Bug: None Change-Id: If1e1153fa53cd43b24008c43b2892025a74bc554 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014103Reviewed-by:
Cliff Smolinsky <cliffsmo@microsoft.com> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#734056}
-
Elly Fong-Jones authored
Leaving _node set while posting the notification can lead to VoiceOver re-entering AXPlatformNodeCocoa while the AXPlatformNodeBase it corresponds to is already being destroyed. Bug: 1037855 Change-Id: I8ff959998f05821b5f258d32f4a9328cb29d234c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014104Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#734055}
-
Alex Ilin authored
This CL marks org.chromium.android_webview.test.AwAutofillTest#testPageScrollTriggerViewExitAndEnter and org.chromium.android_webview.test.AwAutofillTest#testPageScrollTriggerViewExitAndEnter__multiprocess_mode as flaky. TBR=michaelbai@chromium.org Bug: 1033179 Change-Id: I5829718f47165867ac1041bf8d24e972f55f1948 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014941 Commit-Queue: Alex Ilin <alexilin@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#734054}
-
Antonio Gomes authored
Today, this mojo call comes from LocalFrameClientImpl::DispatchDidHandleOnloadEvents(), which used to make sense when RenderFrameImpl::DispatchDidHandleOnloadEvents() used to send the respective message to content::mojom::FrameHost interface, and calling observers. Now that this mojo message got moved from content.mojom.FrameHost to blink.mojom.LocalFrameHost [1], it seems logical to call it from out of LocalFrameClientImpl class. BUG=1043760 R=dtapuska@chromium.org Change-Id: Ie3917cca5fa687a3d7ede91970321c6d1aa8f3a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014763Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#734053}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d59053987a27..b19c78ebad84 git log d59053987a27..b19c78ebad84 --date=short --first-parent --format='%ad %ae %s' 2020-01-22 robertphillips@google.com Add compressed backend textures to Metal Created with: gclient setdep -r src/third_party/skia@b19c78ebad84 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC benjaminwagner@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: benjaminwagner@google.com Change-Id: Icd9a409d1bd0546f8af719acde6f26c8a7d18fe0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014673Reviewed-by:
-
