GitLab

New minimum height (77 dip) is matched for a single custom notification.

BUG=642804

Review-Url: https://codereview.chromium.org/2296863004
Cr-Commit-Position: refs/heads/master@{#417473}

Revert of service worker: Add CHECKs to catch if SWProcessManager isn't releasing ref counts. (patchset #1 id:1 of https://codereview.chromium.org/2318443002/ )

Reason for revert:
SWProcessManager is innocent. The CHECKs aren't failing.

Original issue's description:
> service worker: Add CHECKs to catch if SWProcessManager isn't releasing ref counts.
>
> We're still not sure where the non-zero ref counts on shutdown come from.
>
> BUG=636377
>
> Committed: https://crrev.com/e7ffbf80d3b612521a7c2564b21b96695586274a
> Cr-Commit-Position: refs/heads/master@{#416596}

TBR=horo@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=636377

Review-Url: https://codereview.chromium.org/2320713003
Cr-Commit-Position: refs/heads/master@{#417472}

BUG=582312

Review-Url: https://codereview.chromium.org/2324643002
Cr-Commit-Position: refs/heads/master@{#417471}

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/9d8799334bb0e9b4082b900d99862d29583b6d48 Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
depot_tools:
  https://crrev.com/3454ae85da8913a18a67adaaf8727fa9783127d3 Reland "Delete lots of svn logic from bot_update" (agable@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=472386

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2320363002
Cr-Commit-Position: refs/heads/master@{#417470}

https://pdfium.googlesource.com/pdfium.git/+log/0ca160fbf31a..cf7ac195266f

$ git log 0ca160fbf..cf7ac1952 --date=short --no-merges --format='%ad %ae %s'
2016-09-08 tsepez explicit operator bool for CFX_RetainPtr and CFX_CountRef
2016-09-08 weili Reland of Fix leaked internal font

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2328793002
Cr-Commit-Position: refs/heads/master@{#417469}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/0cb5bdd1..3d918b93

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2325563004
Cr-Commit-Position: refs/heads/master@{#417468}

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/3a2fd516556039032859dc057036402afdd9c709 Turn on Android N5X Swarm Builder for the chromium gatekeeper. (stip@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=589168

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2323163002
Cr-Commit-Position: refs/heads/master@{#417467}

It will allow streaming the profile tree.

BUG=406277

Review-Url: https://codereview.chromium.org/2321163003
Cr-Commit-Position: refs/heads/master@{#417466}

The flaky was due to the issue when trying to load OfflinePageModel, it
would crash with SQLite Error 1802. Fixed by mock the OfflinePageModel
if we're in a testing environment.

BUG=644570

Review-Url: https://codereview.chromium.org/2322793003
Cr-Commit-Position: refs/heads/master@{#417465}

I had to implement a custom callback dispatch handler.
Used MutationObserver code as a template.

Added a test case.

BUG=641353

Review-Url: https://codereview.chromium.org/2303893003
Cr-Commit-Position: refs/heads/master@{#417464}

In very rare circumstance (<5% connection attempt)
GlRenderer::OnPixelTransformationChanged is called when SurfaceCreated has not
been called, which crashes the app since |canvas_| has not been set. This CL
adds check for |canvas_| to prevent crashing. For now we don't know in that
case whether the transformation was set before SurfaceCreated or the surface
had actually been created before the surface callback was registered. If former
is true then this CL will fix the problem since SurfaceCreated will implicitly
cause TransformationChanged. If latter is true then nothing will be drawn on
the view although the app doesn't crash, and we will need to investigate why
this can ever happen.

BUG=644924

Review-Url: https://codereview.chromium.org/2322623003
Cr-Commit-Position: refs/heads/master@{#417463}

We can't use references to large objects with std::move,
so change the code to use the vector of pointers itself
instead  of a reference to a vector of pointers.

BUG=637077

Review-Url: https://codereview.chromium.org/2262423002
Cr-Commit-Position: refs/heads/master@{#417462}

Introduced a new Material Design controller called IsImmersiveModeMaterial,
which controls the default behavior of ash immersive mode. By default, the
immersive mode hints on top chrome and on shelf are hidden. The hints are
showing when the flag ash-md is set to disabled.

TEST=Shelf_layout_manager_unittests, immersive_mode_controller_ash_unittests

BUG=641951, 623432

Review-Url: https://codereview.chromium.org/2326703002
Cr-Commit-Position: refs/heads/master@{#417461}

Revert of Use the URL passed to navigator.share(). (patchset #2 id:40001 of https://codereview.chromium.org/2309403002/ )

Reason for revert:
Causing compile failure on Blimp Linux (dbg)

Original issue's description:
> Use the URL passed to navigator.share().
>
> BUG=644034
>
> Committed: https://crrev.com/746afbd5808e9daa0333e66a7608e0d98283a9c8
> Cr-Commit-Position: refs/heads/master@{#417452}

TBR=esprehn@chromium.org,dcheng@chromium.org,dtrainor@chromium.org,mgiuca@chromium.org,sammc@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=644034

Review-Url: https://codereview.chromium.org/2327713002
Cr-Commit-Position: refs/heads/master@{#417460}

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2324523003
Cr-Commit-Position: refs/heads/master@{#417459}

These tests have been keeping the site isolation bots red after recent
framebusting changes in https://codereview.chromium.org/2092293002.

BUG=644997
NOTRY=true

Review-Url: https://codereview.chromium.org/2324703003
Cr-Commit-Position: refs/heads/master@{#417458}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/fe40502b6dd4..d674036d5ba7

$ git log fe40502b6..d674036d5 --date=short --no-merges --format='%ad %ae %s'
2016-09-08 nednguyen Make Charlie owner of style guide

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2327633002
Cr-Commit-Position: refs/heads/master@{#417457}

Incorrectly named. We don't include type selectors.

R=ericwilligers@chromium.org

Review-Url: https://codereview.chromium.org/2321013002
Cr-Commit-Position: refs/heads/master@{#417456}

Check for nullptrs and avoid adding them to vectors.

Review-Url: https://codereview.chromium.org/2318223002
Cr-Commit-Position: refs/heads/master@{#417455}

this was only enabled on Windows using #if OS(WIN). It is now implemented as a
RuntimeFeature, and is still enabled by default on Windows. This feature is
renamed from Pan Scrolling which wasn't self-explanatory.

BUG=522011

Review-Url: https://codereview.chromium.org/2289213002
Cr-Commit-Position: refs/heads/master@{#417454}

The BlimpCompositor has a 1:1 mapping with the RenderWidgetCompositor,
there is no need for explicit create methods for the LayerTreeHost.

Next change will pull blimp specific code from BlimpCompositor to a
higher layer.

BUG=644326
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2320823003
Cr-Commit-Position: refs/heads/master@{#417453}

BUG=644034

Review-Url: https://codereview.chromium.org/2309403002
Cr-Commit-Position: refs/heads/master@{#417452}

(anonymous function) is oft-seen and could use a better signal:noise ratio. Furthermore, in the case of callstacks, we don't want to elide a filename to prioritize showing this function "name".

BUG=644580

Review-Url: https://codereview.chromium.org/2297903005
Cr-Commit-Position: refs/heads/master@{#417451}

I was not computing entry.contetRect location correctly for <svg> elements.
It should be 0,0

BUG=641364

Review-Url: https://codereview.chromium.org/2305893002
Cr-Commit-Position: refs/heads/master@{#417450}

This reverts commit fe1468fe.

Reland wpt update with [ Failure Timeout ] for type-per-property.html

Restore original thai-line-breaks-expected.png

BUG=645177,645181

Review-Url: https://codereview.chromium.org/2326613004
Cr-Commit-Position: refs/heads/master@{#417449}

BUG=644983

Review-Url: https://codereview.chromium.org/2325843002
Cr-Commit-Position: refs/heads/master@{#417448}

https://codereview.chromium.org/2318223003 landed just before my
change to remove ash.gyp, so no conflict and build broke. I've updated
the build files appropriately.

TBR=msw@chromium.rog
BUG=none
TEST=none
R=msw@chromium.org

Review URL: https://codereview.chromium.org/2320333002 .

Cr-Commit-Position: refs/heads/master@{#417447}

Making requestFullscreen and exitFullscreen async like the spec will
mean that no state on the Fullscreen instances will be modified
synchronously in the request/exit calls, and the instances may in fact
end up not being created at all.

The code arguably ends up looking worse with this change alone, but it
does make it very clear that all events are put in the queue of the
requesting document, and not for each document involved.

This should not be observable at all, and makes future CLs smaller.

BUG=402421,402376

Review-Url: https://codereview.chromium.org/2325663002
Cr-Commit-Position: refs/heads/master@{#417446}

The translate team pointed out that "this" doesn't bind to anything
in this sentence. We really want to say "the certificate that Chrome
received" but it would be unweildy, so just changing it to "its".

Internal bug: b/31354544
R=lgarron@chromium.org

Review-Url: https://codereview.chromium.org/2320843004
Cr-Commit-Position: refs/heads/master@{#417445}

The reason is that certificate IDs depend on the process, and with
PlzNavigate the process ID isn't known when the resource loading is
happening.

BUG=598073, 504347
TBR=tsepez
NOTRY=true

Review-Url: https://codereview.chromium.org/2327433002
Cr-Commit-Position: refs/heads/master@{#417444}

https://boringssl.googlesource.com/boringssl/+log/bc61769e49df6c84de636051ecd8b8104c07caf4..3e5619d121901089e39ad5491de15bb919552a60

BUG=none
TBR=svaldez@chromium.org

Review-Url: https://codereview.chromium.org/2326843002
Cr-Commit-Position: refs/heads/master@{#417443}

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/46159003d0e22c06a991165cbb2112b9da30595f Remove spurious assert. (stip@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=589168.

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2320873005
Cr-Commit-Position: refs/heads/master@{#417442}

Add secondary_abi_shared_libraries to pack all the secondary abi
shared libraries into APK.

BUG=622855

Review-Url: https://codereview.chromium.org/2319273002
Cr-Commit-Position: refs/heads/master@{#417441}

CL 2196493002 brought ANGLE libGLESv2 dependency to the remoting unittest on
Windows. For some reason the Windows clang tester built 64-bit unittest
binary but tries to link it with a 32-bit ANGLE binary. Since the OpenGL
renderer is not used on Windows anyway, we may just disable the unit test on
Windows until we figure out what went wrong with the build setup.

BUG=642027

Review-Url: https://codereview.chromium.org/2303883004
Cr-Commit-Position: refs/heads/master@{#417440}

* Expose DownloadItem::DownloadState to Java as an enum.

* Pass all DownloadItem updates to Java so that the DownloadHistoryAdapter
  can process them.  We're still ignoring everything but the COMPLETE state.

BUG=616324

Review-Url: https://codereview.chromium.org/2320693003
Cr-Commit-Position: refs/heads/master@{#417439}

Because attestation-based enrollment is automatic, we want the
message in case of sucess to have the following elements:

  1. The domain that the device has been enrolled into.
  2. A note letting the user what to do in case that enrollment is
     unexpected. (E.g. someone just bought a device off eBay.)

BUG=644002
TEST=manual
NOPRESUBMIT=true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Presubmits will be skipped due to http://crbug.com/639691

Review-Url: https://codereview.chromium.org/2323593002
Cr-Commit-Position: refs/heads/master@{#417438}

After running update-w3c-test-expectations, w3c-test-autoroller is now failing to run `git cl set-commit`.

For example: https://build.chromium.org/p/chromium.infra.cron/builders/w3c-test-autoroller/builds/7496/steps/update%20wpt/logs/stdio

After this, I'm expecting that it should update expectations/baselines, then try to commit, and then likely fail to pass the commit queue and abort.

BUG=629275

Review-Url: https://codereview.chromium.org/2319763002
Cr-Commit-Position: refs/heads/master@{#417437}

I'm going to separate out tests into their own BUILD.gn, but want to
start here first.

BUG=none
TEST=none
R=msw@chromium.org

Review-Url: https://codereview.chromium.org/2322883003
Cr-Commit-Position: refs/heads/master@{#417436}

https://chromium.googlesource.com/skia.git/+log/85c922acec37..b3cb2142725f

$ git log 85c922ace..b3cb21427 --date=short --no-merges --format='%ad %ae %s'
2016-09-08 bsalomon Benchmarks for testing changes to GrResourceCache replacement policy when over budget.
2016-09-08 msarett Checking for valid colorType, alphaType, colorSpace in SkCodec
2016-09-08 bsalomon Move prepareForExternalIO implementation from GrContext to GrDrawingManager GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2324473002
2016-09-08 mtklein Apple devices do not support CRC32 instructions.  Don't believe Clang's lies.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=caryclark@google.com

Review-Url: https://codereview.chromium.org/2322003003
Cr-Commit-Position: refs/heads/master@{#417435}

This CL prevents appearing an item on the shelf when Arc app gets
active during the secondary user session.

BUG=b/31154158
BUG=644751
BUG=642649
TEST=Manually on device
TEST=Added intial unit_test coverage for Arc multi-user

Review-Url: https://codereview.chromium.org/2325743002
Cr-Commit-Position: refs/heads/master@{#417434}