GitLab

The issue is that the set of datatypes requested for configuration doesn't
match the set of update handlers registered with ModelTypeRegistry. This causes
segfault. The reason for it is that the types to configure are decided at the
time of configuration call in DataTypeManagerImpl on UI thread, while update
handlers are settled at the time of sync cycle execution (couple of posts on
sync thread later). Some update handlers can get unregistered by this time (the
bug has a description of scenario that can lead to this issue). This issue is
only applicable to configuration sync cycle since during normal sync cycle set
of datatypes is derived from ModelTypeRegistry.

The fix is to remove unregistered types from types to configure in
Syncer::ConfigureSyncShare.

BUG=703253
R=skym@chromium.org

Review-Url: https://codereview.chromium.org/2804743004
Cr-Commit-Position: refs/heads/master@{#462727}

These are getting thrown, but don't make any sense because we explicitly ask for
INTERNET permission.  Guessing rooted devices aren't playing nice with our
manifests.

BUG=708908

Review-Url: https://codereview.chromium.org/2805063002
Cr-Commit-Position: refs/heads/master@{#462726}

BUG=

Change-Id: Idbd1d57aa18e0fb15b0b4fdf23bebffc34090d91
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2801053002
Cr-Commit-Position: refs/heads/master@{#462725}

We are attempting to log metrics before native is initialized.

BUG=706400

Review-Url: https://codereview.chromium.org/2803943005
Cr-Commit-Position: refs/heads/master@{#462724}

This test just verifies that if a score is injected for a single URL then
that URL will appear in the site engagement WebUI, to protect against
changes which break some part of the pipeline from the scoring service
to the UI.

BUG=703848
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2780873003
Cr-Commit-Position: refs/heads/master@{#462723}

BUG=707487
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2796343004
Cr-Commit-Position: refs/heads/master@{#462722}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/ea02aa5af9f1..e650872309eb

$ git log ea02aa5af..e65087230 --date=short --no-merges --format='%ad %ae %s'
2017-04-06 eakuefner [Catapult] Prune unused dependencies from third_party/polymer
2017-04-06 eakuefner [Catapult] Roll bower dependencies
2017-04-06 eakuefner [Catapult] Roll paper-styles only

Created with:
  roll-dep src/third_party/catapult

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2798393004
Cr-Commit-Position: refs/heads/master@{#462721}

BUG=

Review-Url: https://codereview.chromium.org/2799983002
Cr-Commit-Position: refs/heads/master@{#462720}

https://skia.googlesource.com/skia.git/+log/9a121cc6ad74..7d3d87233190

$ git log 9a121cc6a..7d3d87233 --date=short --no-merges --format='%ad %ae %s'
2017-04-06 mtklein jumper, gather_i8
2017-04-06 robertphillips Update stencil ops to have a parallel proxyID
2017-04-06 mtklein jumper, more gathers

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=jvanverth@chromium.org

Change-Id: Ib41d69656ee1ef494c8923f16c0580fb43e9ab26
Reviewed-on: https://chromium-review.googlesource.com/470746Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#462719}

The 32-bit Win-Clang build has been broken due to this for days.

This reverts the following comits:

62b2a2 "Roll ANGLE 60e17ea..fa416b1"
e8d6c3 "Roll ANGLE e93daba..60e17ea"
2751d5 "Update robust read pixels to output number of columns and rows written."

BUG=708591
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=jmadill,geofflang,piman

Review-Url: https://codereview.chromium.org/2802613006 .
Cr-Commit-Position: refs/heads/master@{#462718}

This makes the MainMenuItem accessible with a keyboard.

BUG=708902

Review-Url: https://codereview.chromium.org/2805763002
Cr-Commit-Position: refs/heads/master@{#462717}

Fix printer flaky bugs by adding another wait.
The bug is flaky because tests only wait for UI tasks to be completed,
but since PrintersManagerFactory uses
content::BrowserThread::GetBlockingPool() to schedule ModelTypeStore
initialization, and then reply result to UI thread, so we need to wait
on content::BrowserThread::GetBlockingPool() as well.

Remove unnecessary changes from
https://codereview.chromium.org/2758643002 since that did not really
fix this waiting issue.

BUG=689662, 701999

Review-Url: https://codereview.chromium.org/2799103002
Cr-Commit-Position: refs/heads/master@{#462716}

BUG=None
TEST=None

Change-Id: Id8697dae440df7f2d247dc06d69ba5c424ea50a6
Review-Url: https://codereview.chromium.org/2799943003
Cr-Commit-Position: refs/heads/master@{#462715}

This CL:
* Hides the subpage arrow when Bluetooth is disconnected.
* Fixes the dropdown text to 'Connect' for paired but disconnected

BUG=709079,705682
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2799163003
Cr-Commit-Position: refs/heads/master@{#462714}

These __gCrWeb APIs are only used in crw_context_menu_controller.mm.
They are moved to a new context-menu.js file:
- getElementFromPoint
- suppressNextClick
- getPageWidth

TEST=ran ios_web_unittests locally

BUG=614092

Review-Url: https://codereview.chromium.org/2800003002
Cr-Commit-Position: refs/heads/master@{#462713}

This class covers the entire connection process, from a UI callback (when the user clicks a tether network) to connecting to the associated device's Wi-Fi network.

BUG=672263

Review-Url: https://codereview.chromium.org/2792483002
Cr-Commit-Position: refs/heads/master@{#462712}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/126ec661..c5350347

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2807533002
Cr-Commit-Position: refs/heads/master@{#462711}

Copy some colors, actually simulate the toolbar.
Generally make things super fast.

R=esprehn@chromium.org
BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2803653003
Cr-Commit-Position: refs/heads/master@{#462710}

Using wpt-import in Chromium 2ad62ba5.

Directory owners for changes in this CL:
dom-dev@chromium.org:
  external/wpt/dom
  external/wpt/html
  external/wpt/media
domenic@chromium.org, ricea@chromium.org, tyoshino@chromium.org:
  external/wpt/streams
dtapuska@chromium.org:
  external/wpt/uievents
foolip@chromium.org, maksim.sisov@intel.com:
  external/wpt/webvtt
hta@chromium.org:
  external/wpt/webrtc
jfernandez@igalia.com:
  external/wpt/css/css-align-3
jrummell@chromium.org:
  external/wpt/encrypted-media
jsbell@chromium.org:
  external/wpt/storage
  external/wpt/IndexedDB
  external/wpt/FileAPI
kojii@chromium.org:
  external/wpt/css/css-rhythm-1
  external/wpt/css/css-writing-modes-3
mcasas@chromium.org:
  external/wpt/mediacapture-record
mek@chromium.org:
  external/wpt/webmessaging
michaeln@chromium.org, jsbell@chromium.org:
  external/wpt/webstorage
nhiroki@chromium.org:
  external/wpt/workers
ortuno@chromium.org, scheib@chromium.org:
  external/wpt/bluetooth
rego@igalia.com:
  external/wpt/css/css-ui-3
  external/wpt/css/selectors4
shimazu@chromium.org:
  external/wpt/service-workers
style-dev@chromium.org:
  external/wpt/css/cssom-view-1
  external/wpt/css/cssom-1
suzyh@chromium.org:
  external/wpt/web-animations

TBR=qyearsley@chromium.org
NOEXPORT=true

Change-Id: I82e0d83896434defda8a6a864d07dbbfcfa78d96
Reviewed-on: https://chromium-review.googlesource.com/470328Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Reviewed-by: Manuel Rego Casasnovas <rego@igalia.com>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#462709}

Make |using_ssl_| a const. This makes the code slightly easier to read.

BUG=475060

Review-Url: https://codereview.chromium.org/2803023004
Cr-Commit-Position: refs/heads/master@{#462708}

Currently, extensions which are disabled in incognito mode are also loaded in an
incognito renderer. This is redundant and can cause non-required bindings to be
generated in the renderer. Also, it has potential security implications.

Prevent this by only loading incognito-enabled extensions in an incognito
renderer. However extensions which can't be enabled in the incognito mode (e.g.
platform apps etc.) still need to be loaded in incognito renderers, so that
incognito tabs can connect with them (issue 305394).

Also, add tests for the same.

BUG=527548

Review-Url: https://codereview.chromium.org/2766263003
Cr-Commit-Position: refs/heads/master@{#462707}

Also, re-enables switching from sw to accelerated canvas.

BUG=704571

Review-Url: https://codereview.chromium.org/2799033002
Cr-Commit-Position: refs/heads/master@{#462706}

This patch edits Element::rebuildPseudoElementLayoutTree() to make sure
it mirrors Element::updatePseudoElement() called in
Element::recaclStyle() by calling Element::updateFirstLetter() in the
case the PseudoElement is firstLetter as is done in
Element::updateFirstLetter() to ensure we don't call
Element::retachLayoutTree() uncoditionally.

Adds crash test and expectation as well.

BUG=700655

Review-Url: https://codereview.chromium.org/2752163003
Cr-Original-Commit-Position: refs/heads/master@{#462373}
Committed: https://chromium.googlesource.com/chromium/src/+/6d202487ff823def4672599f51e9f13880e6b877
Review-Url: https://codereview.chromium.org/2752163003
Cr-Commit-Position: refs/heads/master@{#462705}

It's possible for the app to make CORS requests from its guests without
any webview-accessible-resources, via injected content scripts.

BUG=613335
TEST=See bug comment 37 for a repro app.

Review-Url: https://codereview.chromium.org/2803963002
Cr-Commit-Position: refs/heads/master@{#462704}

BUG=597347
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2799563003
Cr-Commit-Position: refs/heads/master@{#462703}

Currently people-page uses listenOnce() from util.js, which it only got access to transitively from other deps and is fragile.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2807513002
Cr-Commit-Position: refs/heads/master@{#462702}

Disabling the test, because it has been consistently failing
for the last 3 builds on Mac10.9 Tests (dbg).  OTOH, note that
FindIt says that it cannot find the culprit CL and thinks that
the test is just flaky.  In either case, disabling the test seems like
the right thing to do.

BUG=709231
TBR=hta@chromium.org

Review-Url: https://codereview.chromium.org/2799663006
Cr-Commit-Position: refs/heads/master@{#462701}

The HTML5 spec indicates that a load of an invalid URL via links or the
window.location API should be a no-op.  However, window.open calls
with an invalid URL should still create a new window, but pointed to
about:blank.

BUG=709059

Review-Url: https://codereview.chromium.org/2799953002
Cr-Commit-Position: refs/heads/master@{#462700}

TBR=jochen
BUG=709136

Review-Url: https://codereview.chromium.org/2802083002
Cr-Commit-Position: refs/heads/master@{#462699}

The last couple import jobs failed when uploading the second patchset;
I think that it failed at this point (and not when uploading the
CL initially) because when initially uploading the CL it uses -f.

We want to use -f in general to ignore presubmit warnings for things
like tabs.

Review-Url: https://codereview.chromium.org/2802093002
Cr-Commit-Position: refs/heads/master@{#462698}

In my last CL I added the serialization code but not deserialization.

TBR=danakj@chromium.org
BUG=704972

Review-Url: https://codereview.chromium.org/2801603009
Cr-Commit-Position: refs/heads/master@{#462697}

Reland of Changed CSSParserContext argument from * to & for null safety. (patchset #1 id:1 of https://codereview.chromium.org/2801893003/ )

Reason for revert:
This patch was reverted for breaking tests when it was landed at the same time as a clashing patch https://codereview.chromium.org/2783543002/. Both of these patches were reverted.

Landing them one at a time and rebasing should solve the problem.

Original issue's description:
> Revert of Changed CSSParserContext argument from * to & for null safety. (patchset #4 id:60001 of https://codereview.chromium.org/2786153004/ )
>
> Reason for revert:
>
> Findit identified CL at revision 462380 as the culprit for
> failures in the build cycles as shown on:
> https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzkxMmU1Zjc4N2VlNDE1Zjg3NDkyOGI5Njg0ZWE1MGRjNzVmODVkNDAM
>
> Original issue's description:
> > Changed CSSParserContext argument from * to & for null safety.
> >
> > Changed the CSSParserContext argument to the parseSingleValue method in
> > the property APIs from a pointer to a reference to ensure that nullptr
> > cannot be passed.
> >
> > Note that this patch changes the syntax inside parseSingleValue
> > implementations to get the address of CSSParserContext references to pass to
> > utility methods that still expect a pointer. Future patches should change these
> > utility methods to also take references instead of pointers, at which point the
> > syntax inside parseSingleValue implementations can be changed back to pass the
> > object.
> >
> > This patch:
> > - changed the CSSParserContext parameter to parseSingleValue in
> >   CSSPropertyAPIMethods.json5 so that the generated API header files (including
> >   the base class header file) would update
> > - changed the parameter in each of the .cpp files for the property APIs in
> >   core/css/properties
> > - updated the single call site in CSSPropertyParser.cpp
> > - updated the implementations of parseSingleValue in the property APIs to use
> >   reference syntax
> >
> > Diff of generated files:
> > https://gist.github.com/BugsNash/1850f85afc7313dd3dac1a890299ad07/revisions
> >
> > BUG=668012
> >
> > Review-Url: https://codereview.chromium.org/2786153004
> > Cr-Commit-Position: refs/heads/master@{#462380}
> > Committed: https://chromium.googlesource.com/chromium/src/+/912e5f787ee415f874928b9684ea50dc75f85d40
>
> TBR=shend@chromium.org,meade@chromium.org,bugsnash@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=668012
>
> Review-Url: https://codereview.chromium.org/2801893003
> Cr-Commit-Position: refs/heads/master@{#462383}
> Committed: https://chromium.googlesource.com/chromium/src/+/b7aae4a78d2902cb83671f7ef7792b14180ee462

TBR=meade@chromium.org,lukasza@google.com,jkrcal@google.com,foolip@google.com,ellyjones@google.com,shend@chromium.org,findit-for-me@appspot.gserviceaccount.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=668012

Review-Url: https://codereview.chromium.org/2805153002
Cr-Commit-Position: refs/heads/master@{#462696}

BUG=708808

Review-Url: https://codereview.chromium.org/2799843002
Cr-Commit-Position: refs/heads/master@{#462695}

Skip things mushrome doesn't have yet:
* Cursor manager
* DeviceDataManager

Also fix some dbus service initialization.

After this CL we boot to the login screen. You can't log in yet because
input events are still broken.

BUG=709097
TEST=manual, chrome --mash and --mus start on desktop and on device

Review-Url: https://codereview.chromium.org/2801023004
Cr-Commit-Position: refs/heads/master@{#462694}

|force_quic_port_| is a dead field.

BUG=475060

Review-Url: https://codereview.chromium.org/2802123002
Cr-Commit-Position: refs/heads/master@{#462693}

Now supporing "video/webm; codecs=vp09...." in calls to EME's
requestForMediaKeySystemAccess(). Must run with the following flag:
--enable-new-vp9-codec-string.

This CL does not modify existing support for "video/mp4". To enable
in MP4 run with --enable-vp9-in-mp4.

Runtime flags are checked in MimeUtilInternal ParseVp9CodecID().

BUG=687627

Review-Url: https://codereview.chromium.org/2793163003
Cr-Commit-Position: refs/heads/master@{#462692}

Add a feature to enable the new settings page with site breakdown. Also,
add support so that when Data Saver is enabled on Android, compression
stats collects site information. Don't collect site info when Data Saver
is disabled, and when data usage reporting is disabled (when the proxy
is turned off) keep the stats. The stats can be manually deleted using
a button on the settings page.

BUG=615560

Review-Url: https://codereview.chromium.org/2791563002
Cr-Commit-Position: refs/heads/master@{#462691}

Add support for load/remove persistent license at Android level.

Load:
1. Load eme session ID to key set ID map from persistent storage.
2. MediaDrm.restoreKeys.

Remove:
1. Generate key release request.
2. Update session with key release response.
3. Clear persistent storage.

BUG=493521
TEST=test page

Review-Url: https://codereview.chromium.org/2796843002
Cr-Commit-Position: refs/heads/master@{#462690}

Follow up to https://codereview.chromium.org/2639303004

BUG=668012

Review-Url: https://codereview.chromium.org/2752563002
Cr-Commit-Position: refs/heads/master@{#462689}

https://skia.googlesource.com/skia.git/+log/2e2b27fcc150..9a121cc6ad74

$ git log 2e2b27fcc..9a121cc6a --date=short --no-merges --format='%ad %ae %s'
2017-04-06 robertphillips Revert "Make GrCopySurfaceOp friendlier to GrSurfaceProxy"
2017-04-05 hans Specialize boxBlur(Interp) based on 'transpose' parameter
2017-04-06 msarett Revert "Manual revert: Add support for writing ICC profiles to webp encoder"
2017-04-06 mtklein jumper, gather_8888
2017-04-06 robertphillips Make GrCopySurfaceOp friendlier to GrSurfaceProxy
2017-04-06 mtklein tweaks to make gather_* easier in SkJumper
2017-04-06 mtklein jumper, turn off a few fancy features
2017-04-06 reed make copyTo_with_allocator android only

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=jvanverth@chromium.org

Change-Id: I1cc80e87fd3411abe7b0e9e40a9d98b20045280c
Reviewed-on: https://chromium-review.googlesource.com/470527Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#462688}