GitLab

Specifically, when the PrivacySettingsRedesign flag is on:
 - Split content settings types to two categories "permissions"
   and "content settings"
 - Within each category show 5 items by default, and place all remaining
   items within an expandable section.

Achieved by introducing a new settings-site-settings-list custom
element, and moving some logic previously in site-settings-page to
the new element.

The old codepath where PrivacySettingsRedesign is off, is also
leveraging the newly introduced settings-site-settings-list element.

Bug: 1032584
Change-Id: Id7c7b3d01aa319371374ae1379ea617703934abb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065338
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Esmael Elmoslimany <aee@chromium.org>
Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744075}

Using wpt-import in Chromium 01dabee6.
With Chromium commits locally applied on WPT:
d5cd6b98 "SharedWorker: Assign unique names to SharedWorkers to avoid unintentional matching"
76ee218c "Split html/.../query-encoding/ tests"
1ce9585a "Clear-Site-Data must uncontrol affected service worker clients"
ea6dba31 "Align <pattern> and <*Gradient> attribute collection"
7d52b1d5 "[v8][wasm] Fix WebAssembly streaming tests"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
foolip@chromium.org, lpz@chromium.org, robertma@chromium.org:
  external/wpt/tools
jsbell@chromium.org:
  external/wpt/resources
mkwst@chromium.org, andypaicu@chromium.org:
  external/wpt/content-security-policy

NOAUTOREVERT=true
TBR=raphael.kubo.da.costa

No-Export: true
Change-Id: I5ee8bcc66072dc9fff1f1e1085f7009f234575c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070391Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#744074}

ChromeLauncherController::LaunchApp could be called from
AppServiceAppItem::Activate, which is not from Shelf as the launch
source, so convert and get the correct launch source from the LaunchApp
function's parameter.

BUG=1043205

Change-Id: I9ca32bc50340b861938afffadfd5c8a823d83f15
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066503Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Nancy Wang <nancylingwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744073}

These flags are default enabled and can be removed to simplify a ton
of code.

Bug: 1012975, 1018268
Change-Id: I606ea81d3cef3f9bead86276467c1aeb27fce350
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068864
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744072}

CRAS registered a media player with the Chrome OS Bluetooth stack
(BlueZ) following the Bluetooth AVRCP (Audio/Video Remote Control
Profile). The media player is capable of providing media status, track
information, metadata, and etc to the remote Bluetooth device.

This patch (as a part of more changes) adds new functions to support
Playback Status, Player Identity, and Player Position information flow
to the lower level through DBUS.

BUG=b:147365563

Cq-Depend: chromium:2067192
Change-Id: Ib6255a455d97200ba1c7ee2fadb6905f5a6b46d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069273
Commit-Queue: Jenny Zhang <jennyz@chromium.org>
Auto-Submit: Michael Sun <michaelfsun@google.com>
Reviewed-by: Jenny Zhang <jennyz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744071}

The new constants are necessary because GTK differentiates between
dropdowns (which it calls comboboxes) and menus.  On the Ambiance
theme (the default on Ubuntu), dropdowns are light but menus are dark,
so this change is necessary for consistency with GTK apps.

BUG=914974
R=pkasting

Change-Id: I4805526eee93322c4e7d57b879e0528b0998c933
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069021
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Auto-Submit: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744070}

Create exceptions so that the CI Fuchsia bot does not run the test suites yet.

Bug: 1054545
Change-Id: I27e777ac691d290c2ce3f9ce9a4c6b4573e1f5ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067451Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Chong Gu <chonggu@google.com>
Cr-Commit-Position: refs/heads/master@{#744069}

Numbers like 0xC0000005 and 0x80000003 are easily recognizable in hex
(access violation and breakpoint respectively) but confusing and
unrecognizable in decimal. So, print these in hex.

This change is based on crrev.com/c/1962589

Bug: 803617, 1007013
Change-Id: I53db7e6cadaaa41315180021bcaff84f540de990
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067652Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744068}

Bug: 1048332
Change-Id: Ic8da15679fdc89ee4304a28ec14ca235618ae07b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065311
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744067}

Create(Default,Square)InkDropHighlight() are never called.  Removing
these removed the only caller of set_explode_size(), which meant the
explode size was always the same as the nomal size.  This in turn
allowed removing the scaling transform machinery.

Bug: none
Change-Id: I63e6dca81db75ec16d2d1c079de4bdc0e6589625
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067550Reviewed-by: Peter Boström <pbos@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744066}

This reverts commit ecf7a6f3.

Reason for revert: Chrome OS side CL (crrev/2043892) not landed yet.

Original change's description:
> Drop "enterprise.owned" install attribute support.
> 
> |enterprise.owned| == true is the same as
> |enterprise.mode| == "enterprise" ||
> |enterprise.mode| == "enterprise_ad" ||
> |enterprise.mode| == "demo_mode" from M19:
> https://crrev.com/9403010
> 
> All such old devices (pre-2012) are EOL:
> mario(56), alex(58), zgb(58), lumpy(65), stumpy(65),
> snow(75), parrot(69), stout(69).
> So we effectively can deprecate the field.
> 
> See https://crrev.com/c/2043892 for Chrome OS change.
> 
> TBR=antrim@chromium.org
> 
> Bug: 725918
> Test: Unit tests updated.
> Change-Id: I9c07991d09d1016b819015e5b8a3157de5d24e12
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043836
> Commit-Queue: Sergey Poromov <poromov@chromium.org>
> Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
> Reviewed-by: Igor <igorcov@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#742162}

TBR=antrim@chromium.org,emaxx@chromium.org,igorcov@chromium.org,poromov@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 725918
Change-Id: Idd957178e2170afc59f55cb84086127ee227bf14
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070164Reviewed-by: Sergey Poromov <poromov@chromium.org>
Commit-Queue: Sergey Poromov <poromov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744065}

This CL moves chromeOS strings for settings multidevice page strings
from settings_strings.grdp to os_settings_strings.grdp. It continues
the process of moving all chromeOS specific strings.

Bug: 967883
Change-Id: I706428944be8facb40b69ebb4eea0ff6e77cda1f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067677
Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744064}

Move url_lookup_service to UI thread because it is now managed by
keyed service on a per profile basis. Obtain it at chrome level and
pass it to the caller in IO thread. The caller will hop to UI thread
if real time url lookup is enabled.

Previously url_lookup_service is managed by database_manager. Remove
this dependency in the CL.

The next step is to clean up the parameters passed into
safe_browsing_url_checker_impl. Since each profile has its own
url_lookup_service object, their dependencies such as identity_manager
and cache_manager can be self-contained in url_lookup_service.

For more details, see: go/chrome-protego-refactor-profile.

Bug: 1050859
Change-Id: Ie42ba990be6f83c02382d33dad684ecb4de6a335
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049027
Commit-Queue: Xinghui Lu <xinghuilu@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744063}

Bug: 1041093
Change-Id: Idc9c23461a794c736f230d79391f7f37e738f8c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065313
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744062}

Bug: 963165
Change-Id: I782470e37747c460da3ba167a966af6d21023306
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069478
Commit-Queue: Xinghui Lu <xinghuilu@chromium.org>
Reviewed-by: Xinghui Lu <xinghuilu@chromium.org>
Auto-Submit: Varun Khaneja <vakh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744061}

The previous patch missed a file. See:
https://chromium-review.googlesource.com/c/chromium/src/+/2019479

Bug: 1046181
Change-Id: I3b8f76acd34adb61430b134eedd82e460e49827c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067931Reviewed-by: Gang Wu <gangwu@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Auto-Submit: bttk <bttk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744060}

This adds logic into the ArImmersiveOverlay to keep track of multiple
pointers present in MotionEvent & propagates this information to
ArCoreGl. ArCoreGl will still send only the touch event information
about the primary pointer to the renderer.

Part 1/2(?).

Changes:
- ArImmersiveOverlay now keeps track of the state of all the pointers.
- Switch ArImmersiveOverlay to use MotionEvent.getActionMasked() - some
  ACTION_* values contain pointer information that need to be discarded
  for the purposes of comparing with ACTION_* constants.
- Propagate the information about primary pointer and pointer id from
  ArImmersiveOverlay to ArCoreGl through OnScreenTouch.
- ArCoreGl now maintains an unordered map from input source ID to
  event data, and from pointer id to input source ID assigned to it.
  Pointer IDs are recycled by Android when it passes MotionEvents to the
  application - ArCoreGl ensures that the input source IDs are assigned
  appropriately.

Bug: 1048329
Change-Id: I8834adfc5b601eb883993114636b551fe0bf8fbb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067538
Commit-Queue: Piotr Bialecki <bialpio@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744059}

In certain cases, second DidStartNavigation event will occur prior to
prior navigation's DidFinishLoad, leading to that CastWebContentsImpl
would drop second main frame loading event.

DidStartNavigation -> DidStartNavigation -> DidFinishLoad ->
DidFinishLoad. (LOADING->ignore same LOADING -> LOADED -> IGNORE SAME
LOADED event). Ignored event won't be broadcasted to
CastWebContents::Observer. BindingsManagerCast might not work as
intended under this specific circumstance.

To resolve that, another page loading notification should be added on
ReadyToCommitNavigation.

Bug: Internal b/149898650
Test: Verified with manually build.
Change-Id: Ie119b21495fde6db7b4dd24515ceac3a080c5166
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067870Reviewed-by: Sean Topping <seantopping@chromium.org>
Reviewed-by: Yuchen Liu <yucliu@chromium.org>
Commit-Queue: Jiawei Li <lijiawei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744058}

https://skia.googlesource.com/skia.git/+log/02497d40161f..659cc1c90705

git log 02497d40161f..659cc1c90705 --date=short --first-parent --format='%ad %ae %s'
2020-02-24 herb@google.com Make the strike cache hash table own the strike
2020-02-24 robertphillips@google.com Remove SkDDLTmpRedirect.h
2020-02-24 dmazzoni@chromium.org Allow passing multiple node IDs per PDF structure node.
2020-02-24 bsalomon@google.com Fix GrTextureEffect with kRepeat/kRepeat/kBilerp.
2020-02-24 jvanverth@google.com Reland "Create D3D device and queue"
2020-02-24 jcgregorio@google.com [assets] Add CockroackDB as an asset for testing.

Created with:
  gclient setdep -r src/third_party/skia@659cc1c90705

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC jlavrova@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: chromium:607777
Tbr: jlavrova@google.com
Change-Id: I0970029a43a5ebe58681d57d2be2b09c28099cd5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069334Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#744057}

https://dawn.googlesource.com/dawn.git/+log/33466973bc4c..1249ada986fc

git log 33466973bc4c..1249ada986fc --date=short --first-parent --format='%ad %ae %s'
2020-02-24 cwallez@chromium.org Vulkan: Load promoted extensions or core entrypoint as needed

Created with:
  gclient setdep -r src/third_party/dawn@1249ada986fc

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-chromium-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
Bug: None
Tbr: cwallez@google.com
Change-Id: I313dc996811446d08e11e6ef88e5d22e7eaa5573
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070323Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#744056}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e0897515da03..b3a40936b9f0

git log e0897515da03..b3a40936b9f0 --date=short --first-parent --format='%ad %ae %s'
2020-02-24 brcui@microsoft.com Add high contrast support to the What's New tool (Help module)

Created with:
  gclient setdep -r src/third_party/devtools-frontend/src@b3a40936b9f0

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: Ib54a9140c354e8eb4ce8731be88e544f16f8126c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069049Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#744055}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/207c622c1ef0..fd7c149eef90


Created with:
  gclient setdep -r src-internal@fd7c149eef90

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1040143,chromium:1041701,chromium:1050094,chromium:1054683
Tbr: jbudorick@google.com
Change-Id: I31bc04afc7c5ce844001cbdb3f85234a73deadbc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069047Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#744054}

Bug: 1049185
Change-Id: Ia34aad31bf40f5ba5dfbfa52c41982666b3335d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066791
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744053}

This removes several entries from fieldtrial_testing_config.json for
features that are in the FEATURE_ENABLED_BY_DEFAULT state.

Methodology:
- Make a script that list all the features listed in
  fieldtrial_testing_config.json
- Run git grep for all these features in the chrome codebase, save the
  first line of the output in a file (this could be improved for
  features that wrap over multiple lines).
- Find the line containing FEATURE_ENABLED_BY_DEFAULT, check if the
  entry is trivial (no param changes etc) and if the feature isn't
  behind a #ifdef block, remove it if it sounds safe.

A follow up CL will remove all entries that don't have a corresponding
feature in the codebase.

Bug: 1053702
Change-Id: Ifb526b74d988bdf18f8997f536463956a4d9578e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062697Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744052}

This CL fixes all currently-enabled clang-tidy warnings in
//content/browser/appcache. The main benefit here is to prevent
distractions while pursuing further refactoring in AppCache.

This CL introduces no functional changes.

Change-Id: I81176a48ac8a3362d75cdde6672e462590cb397f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069849
Commit-Queue: Victor Costan <pwnall@chromium.org>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744051}

This reverts commit a799e280.

Reason for revert: <Android crashes blocking M-82 crbug.com/1055463>

Original change's description:
> Release GrContext during OnBackgroundCleanup on low end device
> 
> To reduce Gpu memory on low end device, GrContext and associated
> resources should be released. Abandoning GrContext directly results
> in resources associated to theVkDevice becoming lost. It's preferable
> to destroy entire vulkan context during background cleanup and
> re-initialize when chrome is foregrounded.
> 
> Bug: 1048692
> Change-Id: I6bb0740edee72413f0ac083d847d06e4427133ea
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047828
> Commit-Queue: Kramer Ge <fangzhoug@chromium.org>
> Reviewed-by: Peng Huang <penghuang@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#742815}

TBR=penghuang@chromium.org,fangzhoug@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1048692
Change-Id: Ice1010228ccade56edbb4b3a7b54ba40cbd8dd22
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070663Reviewed-by: Peng Huang <penghuang@chromium.org>
Commit-Queue: Kramer Ge <fangzhoug@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744050}

Now that all processes which can launch from the zygote are doing so,
we should ensure future launchers are safe by default and that
exceptions are intentional.

Additionally adds file://sandbox/OWNERS for relevant files.

Fixed: 22703
Test: All existing tests pass.
Change-Id: I188f4314fbf5cf4659bf555b14b572f657a8720c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067541
Auto-Submit: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744049}

This change implements StartBulkLeakCheck() and StopBulkLeakCheck() in
the BulkLeakCheckServiceAdapter and makes it listen to the OnEdited()
event issued by the SavedPasswordsPresenter.

Bug: 1047726
Change-Id: I043edbdcaf901eff784ffe1d7740fedfee462d03
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070198
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744048}

https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/c22aa6b47ff6..a0ee3aa5b911

$ git log c22aa6b47..a0ee3aa5b --date=short --no-merges --format='%ad %ae %s'
2020-02-23 michaelfsun system_api: Add CRAS media player D-Bus constants
2020-02-11 zuan cryptohome: Port allow user to selectively remove keysets to UserDataAuth.
2020-02-10 zuan cryptohome: Port allow users to create data restore key to UserDataAuth.
2019-12-24 cylai system_api: protobuf message for new dbus service |pca_agent|.
2020-02-18 pmoy power: add three more fields to proto

Created with:
  roll-dep src/third_party/cros_system_api

Change-Id: I6f9ef976ce4c697182bc350cdd36738c7fd69948
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067192
Auto-Submit: Michael Sun <michaelfsun@google.com>
Commit-Queue: Michael Sun <michaelfsun@google.com>
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744047}

TestContentSettingImagePressed() wasn't actually verifying that the
image in question was visible before "pressing" it.  Fixing this
caused several different tests to start failing because they weren't
actually triggering the permission requests they thought they were
(but didn't previously detect it).  Fix these tests and improve the
InvokeUi cases to all show a requesting URL (of "example.com").

Bug: none
Change-Id: Ic64e233163d82d71e88cbb09e3da9a26ed2aede5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067745Reviewed-by: Orin Jaworski <orinj@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744046}

Refactors three Switch Access classes for clarity, consistency, and
readability.

Bug: None
Change-Id: Ib81a279cef24348f997f870f208413245a8c2357
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064790Reviewed-by: Akihiro Ota <akihiroota@chromium.org>
Commit-Queue: Anastasia Helfinstein <anastasi@google.com>
Cr-Commit-Position: refs/heads/master@{#744045}

This change makes DialogDelegate::Close non-virtual. It also splits
DialogTest.AcceptAndCancel into several smaller tests, to avoid it
needing to return false from Accept/Cancel/Close; this also makes the
tests easier to follow.

A followup CL will delete DialogDelegate::Close completely, replacing
it with a new method DialogDelegate::CloseDialog(), for unit tests that
want to simulate closing a dialog but have not created a Widget for it.

Bug: 1011446
Change-Id: I2cb64c3c757e7685d32c1d3b99406999a2cf626d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068299
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744044}

The desktop needs to be fundamentally different from other root nodes
in Switch Access because it is the only root that does not have a back
button.

Bug: 1054482
Change-Id: I47d1f8f5383d271debf1ef5749c106015102679a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065732
Commit-Queue: Anastasia Helfinstein <anastasi@google.com>
Reviewed-by: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744043}

https://android.googlesource.com/platform/external/perfetto.git/+log/3bde4517dec7..1cb4a3a99d23

git log 3bde4517dec7..1cb4a3a99d23 --date=short --first-parent --format='%ad %ae %s'
2020-02-24 rsavitski@google.com Merge "traced_perf: enable SMB scraping + cts improvements"
2020-02-24 rsavitski@google.com Merge "traced_perf: record "expired" (skipped) samples in the trace"
2020-02-24 hjd@google.com Merge "ui: Fix formatting of dev_server errors"

Created with:
  gclient setdep -r src/third_party/perfetto@1cb4a3a99d23

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: perfetto-bugs@google.com
Change-Id: I1d81a67265b9b4cb5e399d84ecf4f8216b19bf5f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070437Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#744042}

In previous CL, a bug on type name where 'bool' should have be 'Bool'
causes bool value calling PolicyValue constructor for double, with
extra param.

This CL fixes the bug and add tests on parse_default_value function.

Change-Id: Ica555f337336fe83ad061f3455769b5a0b3ffe67
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069856
Commit-Queue: Charlie Hu <chenleihu@google.com>
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744041}

chrome://downloads was previously displaying the in progress UX for
downloads that were in the middle of scanning. This could be confusing
given that we may remain in this state for several minutes. Instead, we
should indicate to the user that the file is being scanned.

This CL also removes the ".dangerous #description" selectors that could
cause warning text to change color. These currently aren't doing
anything (the text is black).

Screenshot: https://screenshot.googleplex.com/sTApKg55f4n.png
Bug: 1048891
Change-Id: I3fb736818814dd0343871c08ca230435899bf5aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063043Reviewed-by: Min Qin <qinmin@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744040}

Previously, Switch Access would get stuck in the virtual keyboard when
it was hidden, and would not jump to it when it was activated by any
method other than the Switch Access menu.

This change listens to events corresponding to the keyboard being shown
and hidden, and reacts appropriately.

Bug: 996899
Change-Id: Ic6c58c8f66afdbf7422b74a8dc86b0d64c700607
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062584
Commit-Queue: Anastasia Helfinstein <anastasi@google.com>
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744039}

Bug: 1054636
Change-Id: I46529471783a15c504b7b12c2f5998f84b8d3e92
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067799
Commit-Queue: Bettina Dea <bdea@chromium.org>
Reviewed-by: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744038}

https://chromium-review.googlesource.com/c/chromium/src/+/1945923
change erroneously initializes hold_time_ to null when scroll
timeline is inactive. This makes assert to fail in
Animation::CommitPendingPlay at:
DCHECK(start_time_ || hold_time_);

Bug: 1042924
Change-Id: I98060d065da93bb633d6cbc1506c591194a11692
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037348
Commit-Queue: Olga Gerchikov <gerchiko@microsoft.com>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744037}

https://chromium.googlesource.com/angle/angle.git/+log/959d077f605e..c7f63a01d344

git log 959d077f605e..c7f63a01d344 --date=short --first-parent --format='%ad %ae %s'
2020-02-24 jmadill@chromium.org Fix debug callback in perf tests.

Created with:
  gclient setdep -r src/third_party/angle@c7f63a01d344

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC geofflang@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: geofflang@google.com
Change-Id: Ib4766d1bd355d1ad722635b87bbe1753838aedef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070435Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#744036}