GitLab

StartupBrowserCreatorTest.ProfilesWithoutPagesNotLaunched is flaking with a
timeout on Windows in viz_browser_tests. Filtering it out.

TBR=kylechar@chromium.org
TEST=StartupBrowserCreatorTest.ProfilesWithoutPagesNotLaunched

Bug: 829300
Change-Id: I78a776cd133edc17caa9291612ac980d8c500943
Reviewed-on: https://chromium-review.googlesource.com/997758Reviewed-by: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548393}

This is a preparation CL for enabling to establish WebSocket connection off the
main thread.

In the current implementation, mixed content checks for WebSocket are bound
with LocalFrame. This blocks off-main-thread WebSocket.

To unblock it, this CL introduces IsWebSocketAllowed() in MixedContentChecker
that can do the checks based on both LocalFrame and WorkerGlobalScope.

Bug: 825740
Change-Id: I2cb951b4c23b072605602d6a5dc4a38e28ac5bd5
Reviewed-on: https://chromium-review.googlesource.com/983076Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Adam Rice <ricea@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548392}

This patch adjusts the `SecureContext` IDL attribute to take an argument,
as we need to restrict the relevant bits and pieces to secure contexts
iff a specific flag is set. We'll unfortunately need to keep that in place
until and unless we decide that we can reasonably remove an enterprise
opt-out.

Intent to Deprecate/Remove: https://groups.google.com/a/chromium.org/d/msg/blink-dev/ANnafFBhReY/1Xdr53KxBAAJ
Spec bug: https://github.com/whatwg/html/issues/3440

Bug: 588931
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I5bedd2ca6f420a88ddbcff65e4223fad224ac0a7
Reviewed-on: https://chromium-review.googlesource.com/982625Reviewed-by: Yoav Weiss <yoav@yoav.ws>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Commit-Queue: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548391}

Removing all includes of base/ios/ios_util.h in files where base::ios::
is actually not used anymore. In a handfull of places this required
replacing it with an import of base/logging.h.

Bug: None
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ia5b06338c40f7e4f52ca11dc88b12b85d7078f11
Reviewed-on: https://chromium-review.googlesource.com/988013Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Eric Noyau <noyau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548390}

These were created following the instructions from
https://chromium.googlesource.com/chromium/src/+/master/docs/win_order_files.md
using Chromium #548362.

Bug: none
Change-Id: I42f81cf7c67a3f5ec499f062057600c3eb8efc22
Reviewed-on: https://chromium-review.googlesource.com/997734Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548389}

* When Chrome's cache is cleared, remove pending WebRTC event logs
  as well.
* Logs which are currently being written to are not cleared; this
  is by design.
* Logs which are currently being uploaded are also not cleared.
  It is debatable whether they should be. Erring on the side of
  caution is probably more user-friendly here; a TODO is left for
  a later CL to clear those logs as well.

Bug: 775415
Change-Id: Icf13c363ff7d04e082ed0ccf52e000b5bdbf75a4
Reviewed-on: https://chromium-review.googlesource.com/966562
Commit-Queue: Elad Alon <eladalon@chromium.org>
Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Reviewed-by: Christos Froussios <cfroussios@chromium.org>
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: Tommi <tommi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548388}

https://webrtc.googlesource.com/src.git/+log/76d9bd5b459b..4c9b3c840df3

$ git log 76d9bd5b4..4c9b3c840 --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src/third_party/webrtc
BUG=chromium:None


The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Ib788b4cca15899b9ec09951eb4627a5c7a772956
Reviewed-on: https://chromium-review.googlesource.com/997575
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#548387}

The code guide doesn't allow "using namespace", and they have
a tendency to cause problems with jumbo builds so this is just
a cleanup to avoid possible future problems.

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ibf519c5e4ddb0497961f1befa8de416039e4fc61
Reviewed-on: https://chromium-review.googlesource.com/992318Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#548386}

Scheduler classes are being renamed as part of scheduler
architecture refactoring.

RendererScheduler is used in very many places, so this patch affects
a lot of files. The diffs are basically simple renames of classes,
functions or variables.

TBR=kinuko@chromium.org,dalecurtis@chromium.org

Bug: 826203
Change-Id: I4fd701b5e8b35e9ec5ab44f136af2fbe00f07d83
Reviewed-on: https://chromium-review.googlesource.com/994854
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548385}

The tests are failing consistently on chromium.webkit/WebKit Mac10.10.

TBR=thomasanderson@chromium.org

Bug: 787020,829282
Change-Id: Ibad916df060e441b99cb13b8970ce85c1f34bec0
Reviewed-on: https://chromium-review.googlesource.com/997555Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548384}

This CL allows base::ThreadChecker in //src/third_party/WebKit/Source and uses
it in WorkerThreadLifecycleContext as an example.

WorkerThreadLifecycleContext is now bound with the main thread and
DCHECK(IsMainThread) checks it, but the restriction will be removed by ongoing
CLs soon (see the associated issue). base::ThreadChecker should be useful in
such a case.

Bug: 829119
Change-Id: I01a2d8663829e6e2ad2d572664ff0a5ced14a4ae
Reviewed-on: https://chromium-review.googlesource.com/997232Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548383}

It was accidentally disabled in
https://codereview.chromium.org/2176753003.

Bug: 783818
Change-Id: I52f53bd0130737486e97989643421f9dc93df749
Reviewed-on: https://chromium-review.googlesource.com/997352Reviewed-by: Patrik Höglund <phoglund@chromium.org>
Commit-Queue: Max Morin <maxmorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548382}

This CL ensures that desktop PWAs have their full SSL status checked
by the BookmarkAppHelper prior to creating the installation prompt.
Previously, PWAs with mixed content would be considered installable.

BUG=829209

Change-Id: I343298e8d7f41af513721b08671df4f206259d76
Reviewed-on: https://chromium-review.googlesource.com/997037
Commit-Queue: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Matt Giuca <mgiuca@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548381}

Previously the requestAnimatioNFrame timestamp would start from a
very large possibly negative number when the date was overidden.

Change-Id: I5faf417a035488ea651c35fc2bc8f45c3b8ba7d4
Reviewed-on: https://chromium-review.googlesource.com/972985Reviewed-by: Eric Seckler <eseckler@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Alex Clarke <alexclarke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548380}

Duplicates of kTrafficAnnotation and g_is_fake_official_build_for_testing
just appeared and caused problems for certain (extreme) jumbo build
configurations.

In jumbo builds much code is compiled in the same translation
unit which means that they share the same anonymous namespace.

This patch renames the variables following the pattern of similar clashes.

(nopresubmit because any changes to net::URLFetcher are currently
 blocked and this just changes a name)

NOPRESUBMIT=true

Change-Id: Ib55f61c2c8a76c235de45f509df493c875a3a12b
Reviewed-on: https://chromium-review.googlesource.com/992313
Commit-Queue: Daniel Bratell <bratell@opera.com>
Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Reviewed-by: Matt Mueller <mattm@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548379}

This reverts commit a776bce4.

Reason for revert: new layout test is failing on multiple platforms; see https://bugs.chromium.org/p/chromium/issues/detail?id=823109#c2 .

Original change's description:
> [Picture in Picture] Add modern media control.
> 
> Currently, there is only a PiP button for the legacy / non-modern
> set of media controls. This adds and enables the modern version.
> 
> BUG: 726619 823109
> Change-Id: Iddb2d8393d5cf519bb6e32639d5f640bc341fc6f
> Reviewed-on: https://chromium-review.googlesource.com/966980
> Commit-Queue: apacible <apacible@chromium.org>
> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
> Reviewed-by: Tommy Steimel <steimel@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#548358}

TBR=mlamouri@chromium.org,apacible@chromium.org,steimel@chromium.org

Change-Id: I8b2b26e40ed3743858c99d993a1535899bfcbf36
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/997612Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548378}

In Vaapi VEA, We push the input frame at the queue
|encoder_input_queue_| first, and then push to the second queue
|submitted_encode_jobs_| when we prepare the submit the frame.

To flush the frame correctly, we should push a "fence" (nullptr)
into the first queue |encoder_input_queue_|, then pass the fence to
the second queue.

Bug: chromium:820313
Test: Pass video_encode_accelerator_unittest at Eve device

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Id4ce02973297e678fd7fb1d35ae6946d667315d5
Reviewed-on: https://chromium-review.googlesource.com/997233Reviewed-by: Ricky Liang <jcliang@chromium.org>
Commit-Queue: Chih-Yu Huang <akahuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548377}

This CL adds the preparation steps before presenting the popup menus.
In those preparation steps, the browser is dismissing all the other
menus the user can be interacting with.

Bug: 828326
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ib4b34686790fa8c8acf2bdbf5abb099e916366bd
Reviewed-on: https://chromium-review.googlesource.com/991992
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548376}

Updated the SiteSettingsCounter to use period endtime for counting.
HostContentSettingsMap::ClearSettingsForOneTypeWithPredicate() takes end_time.

Bug: 243833
Change-Id: I0a801beb4c415c0df08aa7b9b9d0f66d4f7695f7
Reviewed-on: https://chromium-review.googlesource.com/912949Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Adam Langley <agl@chromium.org>
Reviewed-by: James MacLean <wjmaclean@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Jialiu Lin <jialiul@chromium.org>
Commit-Queue: Sarath Singapati <sarath.singapati@huawei.com>
Cr-Commit-Position: refs/heads/master@{#548375}

If a touch/mouse event occurs and it is interpreted as a floating
keyboard drag event, do not propagate the event to the javascript
keyboard extension as there is no reason to.

This was causing the drag event to cause the gesture swiping to be
active while dragging the keyboard around, particularly if the keyboard
was bounded to the bottom of the screen and the user's finger is able
to move around on the keys while still moving the keyboard (see
attached bug for repro/video).

Bug: 826078
Change-Id: I40c859f979d41a5d61e88ff0bd41808dcf3940c2
Reviewed-on: https://chromium-review.googlesource.com/997195Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Commit-Queue: Blake O'Hare <blakeo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548374}

The test is failing consistently on Linux.

TBR=kenrb@chromium.org

Bug: 827431
Change-Id: Iadc01b50a477f8030b9043bf668aad82dc18c0b6
Reviewed-on: https://chromium-review.googlesource.com/997432Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548373}

Fixed a regression introduced by r537588 which showed a location bar on
all non-https pages. Extension pages are secure, but have scheme
chrome-extension, so did not pass this test. Now chrome-extension pages
are special-cased to be allowed without a location bar.

Bug: 828233
Change-Id: Ic792007ddb8d8d29ab0dc0b82500e4833f6f2c7c
Reviewed-on: https://chromium-review.googlesource.com/991932
Commit-Queue: Matt Giuca <mgiuca@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548372}

Likely failing due to incorrect rebaselining from:
https://chromium.googlesource.com/chromium/src/+/7a8765a7a7e0158e7f82681d06ce798bf8901328

TBR=beccahughes@chromium.org
TBR=thomasanderson@chromium.org

Bug: 829228
Change-Id: Icf2894aae0a4c0ed3baa85d82f7dd47417410d23
Reviewed-on: https://chromium-review.googlesource.com/997197Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548371}

Stop relying on the header being included implicitly. This fixes the build
with libstdc++ after b1303e03 ("Add support in CloudPolicyClient for
machine enrollment and reporting"):

    ../../components/policy/core/common/cloud/cloud_policy_util.cc: In function ‘std::__cxx11::string policy::GetMachineName()’:
    ../../components/policy/core/common/cloud/cloud_policy_util.cc:33:17: error: ‘HOST_NAME_MAX’ was not declared in this scope
       char hostname[HOST_NAME_MAX];
                     ^~~~~~~~~~~~~
    ../../components/policy/core/common/cloud/cloud_policy_util.cc:33:17: note: suggested alternative: ‘_SC_HOST_NAME_MAX’
       char hostname[HOST_NAME_MAX];
                     ^~~~~~~~~~~~~
                     _SC_HOST_NAME_MAX
    ../../components/policy/core/common/cloud/cloud_policy_util.cc:34:19: error: ‘hostname’ was not declared in this scope
       if (gethostname(hostname, HOST_NAME_MAX) == 0)  // Success.
                       ^~~~~~~~
    ../../components/policy/core/common/cloud/cloud_policy_util.cc:34:19: note: suggested alternative: ‘basename’
       if (gethostname(hostname, HOST_NAME_MAX) == 0)  // Success.
                       ^~~~~~~~
                       basename

While HOST_NAME_MAX is only used in the Linux code path, it should be
harmless to include the header unconditionally.

BUG=812641

Change-Id: I6769792efe188ff437753e4cb1ba134c341c20e9
Reviewed-on: https://chromium-review.googlesource.com/987895Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Cr-Commit-Position: refs/heads/master@{#548370}

BUG=782120,811578

Change-Id: I240ed465ddab68c363fdbbac99c86ccd3ffd0194
Reviewed-on: https://chromium-review.googlesource.com/996833Reviewed-by: Ben Wells <benwells@chromium.org>
Commit-Queue: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548369}

This reverts commit 3c0ee4b6.

Reason for revert: this is breaking the downstream autoroller as the file ios/public/provider/chrome/browser/voice/voice_search_presenter.h is still included.

Original change's description:
> [iOS] Remove StartVoiceSearchCommand.
> 
> This is patch 3 of a 3-way patch, and must be landed after
> crrev.com/c/981777 and crrev.com/i/595643.
> 
> Bug: 805123
> Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
> Change-Id: I71dd8dfa19f57b964e7ac08154e94db6614bb895
> Reviewed-on: https://chromium-review.googlesource.com/981779
> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
> Reviewed-by: Mark Cogan <marq@chromium.org>
> Reviewed-by: Justin Cohen <justincohen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#548355}

TBR=marq@chromium.org,justincohen@chromium.org,kkhorimoto@chromium.org

Change-Id: I597a099df96888857173632ebfb92bde002d95d3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 805123
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Reviewed-on: https://chromium-review.googlesource.com/997373Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548368}

This CL replace "base::Bind" to "base::BindOnce" or
"base::BindRepeating".

BUG=none
TEST=git cl format
TEST=Run video_encode_accelerator_unittest at scarlet device

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I1cb8ba08334c0bd082bca6c164eba10a7b8e8d4c
Reviewed-on: https://chromium-review.googlesource.com/991628Reviewed-by: Ricky Liang <jcliang@chromium.org>
Commit-Queue: Chih-Yu Huang <akahuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548367}

Use of R raw string literal was causing code review to stop syntax
highlighting for most of the file. Changed to a regular
backslash-escaped string literal.

Change-Id: I89b24951508160d61017e374f2ebca0069f0cabc
Reviewed-on: https://chromium-review.googlesource.com/997252Reviewed-by: Ben Wells <benwells@chromium.org>
Commit-Queue: Matt Giuca <mgiuca@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548366}

The 2nd patch of a large rebaselines following CL:997255.

This patch extends rebaselines to where all of the below stand:
* Images match.
* Text dumps do not match after nomalizations. By quickly going
  through them, they are most likely from where the text intrinsic
  size changes. Easy ones are just changes in the size and
  positions of LayoutInline/LayoutText. Complex ones include size
  change of shrink-to-fit ancestors, in which case, reviews may
  not be really reliable.

1st patch (CL:997255) recovered 162, and this patch recovers 292,
total 454. The rest might have changed images and that we'll need
image reviews.

TBR=eae@chromium.org, mstensho@chromium.org
NOTRY=true

Bug: 591099
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: Id65a2818dc99a6b46c7ef6aa365909ce6d1516f1
Reviewed-on: https://chromium-review.googlesource.com/997257
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548365}

ProceedWithResponse doesn't have to be implemented for
ServiceWorkerNavigationLoader since it's not using MojoAsyncResourceHandler.
This CL just removes the NOTREACHED() there.

Bug: 822131
Change-Id: I5fb97dd8c0a0428b642f74368409b787e47f9315
Reviewed-on: https://chromium-review.googlesource.com/994496Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548364}

Previously URLSearchParamsIterationSource iterated over a copy of
URLSearchParams, but it is specified in the standard as iterating over
the live list.

Modify it to reference the original URLSearchParams object instead of
making a copy.

Also add web-platform tests for delete during foreach, and a chromium-
specific test for GC of URLSearchParams during iteration.

Remove failing expectations.

BUG=677322

Change-Id: I8c53fd8dd9863fe1146c5b7849d4f08245b37bc1
Reviewed-on: https://chromium-review.googlesource.com/987839Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548363}

GetAssertionRequestHandler guarantees at most one successful response to
be sent to the relying party.

Bug: 780078
Change-Id: Ibe8cb2374713f25fbabc73d23615349edb8589fb
Reviewed-on: https://chromium-review.googlesource.com/942368
Commit-Queue: Jun Choi <hongjunchoi@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548362}

This patch changes extent of |AttachContext| to its lifetime for improving
code health.

Change-Id: I18b38b1a0e5f1299d8cdbf20c21608be1493a596
Reviewed-on: https://chromium-review.googlesource.com/996774Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548361}

Bug: 714579
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I4459f9a3b2e024ce6305f93a4c886600a81b73b6
Reviewed-on: https://chromium-review.googlesource.com/995243Reviewed-by: Naoki Fukino <fukino@chromium.org>
Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548360}

Since the job 4583, ~1000 text/image failures started, probably
due to further progress on Linux font change crbug.com/787020.

CL:994554 added them as failures. This is a series of efforts
to rebaseline pixel/text changes that are LayoutNG improvements.

As a starter, this patch rebaselines 162 of them, where images
match, and also text dump match after normalizations.

A few more patches that apply different methods, combined with
manual reviews, will follow.

TBR=eae@chromium.org, mstensho@chromium.org
NOTRY=true

Bug: 591099
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I0eece6d2420568454c60df459a082188ed06a8ee
Reviewed-on: https://chromium-review.googlesource.com/997255
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548359}

Currently, there is only a PiP button for the legacy / non-modern
set of media controls. This adds and enables the modern version.

BUG: 726619 823109
Change-Id: Iddb2d8393d5cf519bb6e32639d5f640bc341fc6f
Reviewed-on: https://chromium-review.googlesource.com/966980
Commit-Queue: apacible <apacible@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548358}

Stylesheets from link elements that previously have rel = "stylesheet"
but then changed to something else should be removed/not considered
anymore until the rel attribute is changed back to "stylesheet" again.

Currently this works correctly for link elements in the document tree,
but fails in link elements within a shadow tree because link elements
in shadow tree with rel attribute != "stylesheet"  are skipped from
processing. Because of that, the stylesheet in the link element was
never cleared and no style recalc happened.
JSBin from bug: http://jsbin.com/bojunajaju/edit?html,console,output


Bug: 817355
Change-Id: I57c71c79c0cc471d36eb988b8a81eef82c33548a
Reviewed-on: https://chromium-review.googlesource.com/995116
Commit-Queue: Rakina Zata Amni <rakina@chromium.org>
Reviewed-by: Hayato Ito <hayato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548357}

Following bot results are included.
4558 4561 4566 4569 4572 4573 4576 4577 4579 4580 4583

2 lines were removed and 0 lines were deflaked by consecutive
results since 4509.

TBR=eae@chromium.org, mstensho@chromium.org
NOTRY=true

Bug: 591099
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I7e0e9549c60cd5e504a7540f6c78fd9fa017aaea
Reviewed-on: https://chromium-review.googlesource.com/994554
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548356}

This is patch 3 of a 3-way patch, and must be landed after
crrev.com/c/981777 and crrev.com/i/595643.

Bug: 805123
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I71dd8dfa19f57b964e7ac08154e94db6614bb895
Reviewed-on: https://chromium-review.googlesource.com/981779
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548355}

When changing a layout object from in-flow to out-of-flow positioned, we
used to just remove it from the flow thread, risking that there'd no
longer be a column set to associate it with. However, an out-of-flow
positioned descendant may be contained by something that's inside the
flow thread, e.g. if the containing block of an absolutely positioned
object is a relatively positioned object, and that relatively positioned
object is contained by the flow thread.

Since it's hard to detect what the new containing block of an object is
going to be before it has actually gone out of flow, we'll still remove
it from the flow thread, but we'll now detect that we need to re-insert
it when computed style has updated.

Bug: 827424
Change-Id: I413348b0d3ecd0c4b5051e6e9d2a4526863bef60
Reviewed-on: https://chromium-review.googlesource.com/995439Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548354}