- 17 Mar, 2020 40 commits
-
-
Omer Katz authored
When calling ConstructAndNotifyElement, we assume the element already exists and can be concurrently traced. In such cases updating the member should use atomics. Using operator= in this case takes care of both atomics and the write barrier. Construct still calls the member ctor since this is assumed to be a new buffer that cannot be traced yet. Bug: 986235 Change-Id: I6c7053e8d084e9c2852bee1e3192196483bfb727 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105373 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#751023}
-
nancy authored
This CL moves ExtensionUninstaller back to the ui/ash/launcher directory to uninstall extensions from extenions context menus. BUG=1061892 Change-Id: Icd08981c95bc07ca9eda0645a53952873ba45eac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105687Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#751022}
-
Henrique Nakashima authored
Bug: 1041473 Change-Id: Iafb3db8f2d11924614cd563428541e983538ea47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099295Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#751021}
-
Hsin-Yu Chao authored
NextHandsfreeProfile feature flag triggers ChromeOS audio server to register HFP 1.7 to BlueZ. This will be used for dev team to qualify ChromeOS for HFP 1.7 and end users to enable wideband speech feature. verify WBS is enabled using Sony WH-1000XM3 headset. Bug: b/149188379 Test: Manual enable NextHandsfreeProfile in chrome://flags and Change-Id: If3539cc4d6d589152ab4244a7cc4a8b738396799 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094519 Commit-Queue: Hsinyu Chao <hychao@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Reviewed-by:
Heng-ruey Hsu <henryhsu@chromium.org> Cr-Commit-Position: refs/heads/master@{#751020}
-
Christoph Schwering authored
This CL makes the whole as opposed to only the <cr-icon-button> clickable. Bug: 1062231 Change-Id: I740cc90e6806ebb33678fbd3e5572d1d44984560 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106088 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#751019}
-
Daniel Cheng authored
Hopefully, this will help confirm the theories... Bug: 1061138 Change-Id: Id452de7f436f9970517814540db06343fbc896c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106536Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#751018}
-
Boris Sazonov authored
Removes gogerald@chromium.org from chrome/browser/android/signin/OWNERS and chrome/android/java/src/org/chromium/chrome/browser/signin/OWNERS. Bug: None Change-Id: I6994892311d67973f1222f910cfd9407005cddeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095099 Auto-Submit: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#751017}
-
Mehran Mahmoudi authored
This adds a null check on back press handling logic in ChromeTabbedActivity. Bug: 1062244 Change-Id: I91da10c179568e95182818e4d5ab5d6aa3e9dc65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107165 Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Auto-Submit: Mehran Mahmoudi <mahmoudi@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#751016}
-
Rainhard Findling authored
* Removes outdated safety check focus code that on click of the safety check button tries to focus the safety check parent, which is no longer focusable (see crrev.com/c/2100823). Bug: 1015841 Change-Id: I9806232b054278116734efbf0f3cf159432945c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106089Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Rainhard Findling <rainhard@chromium.org> Cr-Commit-Position: refs/heads/master@{#751015}
-
Fredrik Söderqvist authored
While using the "wrong" PaintInfo may not actually be "wrong" as such, it raises questions. Thus, update PaintInfo usage so that it matches the expected scoping/lifetime at a certain spot to avoid confusion. Change-Id: I2a8aec6ca847beebed477589f3abf08f412ba8c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106172Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#751014}
-
Xiaocheng Hu authored
We want to eliminate Font::Update(), as it allows switching the FontSelector of a Font, which is a bad pattern. This patch eliminates all call sites that calls the function with an explicit nullptr, by replacing it with on-demand creation of Font::font_fallback_list_ with a null FontSelector. Note that: - We can't DCHECK non-null FontSelector for Font::Update(). Some callers may call it with a nullable parameter - We can't create a FontFallbackList on all Font objects. Otherwise, we may get a memory regression. So we use on-demand creation. Bug: 1049295 Change-Id: Icc1e87c8517220a2ff8d92f00b311546e8e77541 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106394Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#751013}
-
Scott Violet authored
cached_feature_flags.cc includes CachedFeatureFlags_jni, so it's target (//chrome/browser/flags:flags_android) needs to depend upon the target that generates the header. BUG=none TEST=none Change-Id: I015f67257754c2af565c1935c1b58b3f11badbfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106964Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#751012}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Icd71c87ecaf14e57249ed5091208aafc2614bf1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107324Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#751011}
-
chrome://managementRoger Tawa authored
Bug: 1062259 Change-Id: I327a62f258c3c6a5bc6fb139204aba8b35748968 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106459 Commit-Queue: Roger Tawa <rogerta@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#751010}
-
Fredrik Söderqvist authored
Since ScopedSVGPaintState has its own "internal" PaintInfo (accessed via GetPaintInfo()) we don't need to have local PaintInfos in a number of SVG painters, but can use the one passed in (or one that is actually being locally mutated like in SVGContainerPainter). Add a comment in SVGForeignObjectPainter about the seemingly frivolous PaintInfo usage. Also drop some level of indentation where possible. Change-Id: I59efc150c666a725d626b1b5ca643d3041d3fe3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106167 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#751009}
-
Peter Kasting authored
* Use a ScopedObserver * Init in declaration * Move functions in .cc to better align with order in .h Bug: none Change-Id: I3e961c61f17356414d1d0b9124da9e9da883e069 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107154 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#751008}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/c19ea32ca5dd..e73d36798847 git log c19ea32ca5dd..e73d36798847 --date=short --first-parent --format='%ad %ae %s' 2020-03-17 tvanderlippe@chromium.org Add coverage reporting to ninja typescript 2020-03-17 aerotwist@chromium.org [global] Remaps self.Bindings.networkProjectManager Created with: gclient setdep -r src/third_party/devtools-frontend/src@e73d36798847 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1058320,chromium:1061125 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ie80225a37dad82f0c9af3f1890fc7af12e53fd2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107323Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#751007}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/17637854..f9434816 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ifdfc9db693c4b1bb5ab139415d2a5e4bfaa2a5a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107434Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#751006}
-
Morten Stenshorne authored
This flag was hardly checked at all in the code. It has been implied by LayoutNG for a long time already. There's also a linux-layout-tests-fragment-paint bot still lying around, but I couldn't figure out how to remove it. Bug: 988015 Change-Id: I4f7099a0127c51721e5baaeb6200f3143382f715 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106060Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#751005}
-
danakj authored
The test watches for IPC messages sent to a process, but if multiple frames/widgets end up sharing a process it can see messages it didn't intend to watch. So we ensure we're watching messages only to the intended frame tree, and since each frame has a unique size this is sufficient to also watch only the intended frame+widget. The watcher causes the RunLoop to exit when it sees the value it was looking for, but then another message may happen before it finishes exiting which replaces the value. R=avi@chromium.org, wjmaclean@chromium.org Bug: 1061934 Change-Id: I89abce4aece1dedea267e732619cc2c5db159460 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106116 Commit-Queue: danakj <danakj@chromium.org> Auto-Submit: danakj <danakj@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#751004}
-
Katie D authored
It was accidentally removed in https://chromium-review.googlesource.com/c/chromium/src/+/1881497. Change-Id: I8b1a830895522dcc3e11ee1f5b6b2f149aeb5fd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107169 Commit-Queue: Katie Dektar <katie@chromium.org> Commit-Queue: Aran Gilman <gilmanmh@google.com> Auto-Submit: Katie Dektar <katie@chromium.org> Reviewed-by:
Aran Gilman <gilmanmh@google.com> Cr-Commit-Position: refs/heads/master@{#751003}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/0663bde5f91e..d6e1e088f7f1 git log 0663bde5f91e..d6e1e088f7f1 --date=short --first-parent --format='%ad %ae %s' 2020-03-17 gredelston@google.com Run api/compile_build_api_proto 2020-03-16 saklein@chromium.org cros_run_unit_tests: Remove hardcoded parallelism limit 2020-03-16 gredelston@google.com Remove pytestmark.requires_sudo 2020-03-16 seanabraham@chromium.org config OWNERS: make Bernie an owner Created with: gclient setdep -r src/third_party/chromite@d6e1e088f7f1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel Bug: None Tbr: chrome-os-gardeners@google.com Change-Id: I6b7441ecf272165a47fa40224a54bb96072444ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107321Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#751002}
-
Oksana Zhuravlova authored
Since the browser does not bind the BadgeService on Android, this change adds corresponding conditions to the renderer side. Bug: 1062106 Change-Id: I905676ec94d5aaa697ef279167a15efd5b8ddd5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106921Reviewed-by:
Chris Mumford <cmumford@google.com> Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#751001}
-
Christopher Cameron authored
Add this as a parameter to AppShimManager's constructor. This will allow us to move ExtensionAppShimManagerDelegate out of app_shim, and then remove all extensions dependencies from there. R=loyso TBR=avi Bug: 1057195 Change-Id: Ibcd126a26e7fb1654e7147668be4a49a787e7f57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106480 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#751000}
-
Jeroen Dhollander authored
When launching the Assistant UI from the launcher search result page, pressing <escape> returned to the launcher search result page. This forced the user to press <escape> 3 times to actually close the launcher, which was deemed too much. This CL causes the launcher to skip the search result page when exiting the Assistant UI. This CL also contains some minor code and test cleanups. Bug: b/144047154 Change-Id: I1e3f711142e6f19e25d9e7e710867ca38923ff55 Tests: |app_list_unittests| with filter "AppListViewTest*" and manual. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106337 Commit-Queue: Jeroen Dhollander <jeroendh@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Auto-Submit: Jeroen Dhollander <jeroendh@google.com> Cr-Commit-Position: refs/heads/master@{#750999}
-
kylechar authored
1. Remove expired histograms that aren't useful anymore. 2. Extend expiry for the AliveSurfaces histogram. 3. Update histogram owners with current team members. Bug: 1036992, 1036993 Change-Id: I76356542cc1450ee6dbada9bea15ba2f10c2109f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105759Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#750998}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9b395cb8769a..2c3c88819af7 Created with: gclient setdep -r src-internal@2c3c88819af7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I8b63e118b457f2f4717e2ddbc6a36086d5201d75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107320Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#750997}
-
Christian Dullweber authored
Disable the per-site cookie ui when cookie settings are enforced by enterprise policy. When third-party cookies are allowed in regular mode, this can not be changed in incognito mode and the controls are disabled as well. In a followup CL, some UI will be added to indicate why the control is disabled. Bug: 1015767 Change-Id: I03e96c0b0e2c0520b2983f99b125d103969b446b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100859Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#750996}
-
Abhijeet Singh authored
Change the hover-behavior for the user-consent view for Quick Answers from changing the color to black, to remaining static with the same color. Bug: b:151365389 Test: Tested on Chrome OS VM. Change-Id: I1fd68e8721b5588d804ab5c4f2709690f5a16035 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101730Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Abhijeet Singh <siabhijeet@google.com> Cr-Commit-Position: refs/heads/master@{#750995}
-
Takuto Ikuta authored
This was introduced in crrev.com/c/1636973 But I don't think we need to have this in dev. https://luci-milo-dev.appspot.com/p/chromium/builders/try/mac_upload_clang Bug: 731375 Change-Id: Id1e122ce468922bd80fd172b6f6961acc6c5bf06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107335 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#750994}
-
Eric Orth authored
The HostResolver cache invalidation is required to be an atomic process to ensure results end up cached for the correct connection. But the invalidation also recently tied into DoH activation probe restarts, which itself is not an issue because probe results do not affect the host cache and they're keyed by DnsSession, but in some corner cases, running the probe can synchronously lead to making URLRequests that call back into HostResolver to create more requests. That reentrancy breaks the cache invariants and thus fires some strategic DCHECKs. To fix, add an additional DCHECK into ProbeRequestImpl to ensure current tests catch the potential issue, and then change the probe restart call to be asynchronous and thus occur after cache invalidation is complete. Bug: 1061937 Change-Id: Ie1315dbd6ccab5036fa09b6870542bb647b12a73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105463Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#750993}
-
Manoj Gupta authored
Chrome OS now uses LLD everywhere so the issue with vendor graphics libraries should be fixed. Bug: 356580, 959491, 988073 Change-Id: Idd2ac5f2253adf15b3cc9235fb6e848a1f45aa3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106749 Auto-Submit: Manoj Gupta <manojgupta@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#750992}
-
Rainhard Findling authored
* Adds the new safety check icon. * Changes the safety check parent icon behavior to always show the safety check icon, and to always show it in the same color (removes the spinner while safety check is running). Bug: 1015841 Change-Id: If4bbeb844435dafd4f97d979dae5d29aaadf7e46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106185Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Rainhard Findling <rainhard@chromium.org> Cr-Commit-Position: refs/heads/master@{#750991}
-
Rainhard Findling authored
* Safety check does no longer show a "Running..." label with children elements, as this info is captured in the spinner icon already. Bug: 1015841 Change-Id: I9b8ec8578edd497a8a69cc277016561e1e6f88e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106187Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Rainhard Findling <rainhard@chromium.org> Cr-Commit-Position: refs/heads/master@{#750990}
-
Dominique Fauteux-Chapleau authored
Also includes refactors: - UploadFileForDeepScanning now takes a BinaryUploadService::Result parameter in order to return earlier if a result was found locally (large file, etc.). This makes the BlockLargeFileTransfer policy behave the same as AllowPasswordEncryptedFiles and BlockUnsupportedFiletypes. - CreateFilesForTest into the base class to reuse it in the DeepScanningDialogViews browser tests. This is required since these tests previously didn't create their test files and would have UNKNOWN results, meaning the new early return would break those tests. Bug: 1061021 Change-Id: I54874e3dc4e6d190105fc47a7445495d1ad10511 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102644 Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#750989}
-
Justin Miron authored
This change adds use counters for third party usage of the LocalStorage, SessionStorage, FileSystem, IndexedDb, and CacheStorage APIs. It will be measured in both UMA and UKM. It records use counters upon callback to OnStorageAccessed when the url requesting storage access is valid and does not match the first party url. These metrics will be used to understand how third party storage is used today to motivate future decisions for third party storage API changes. BUG=1059915 Change-Id: I70225e1371778acfe479e384012b574f56587203 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097373 Commit-Queue: Justin Miron <justinmiron@google.com> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Yao Xiao <yaoxia@chromium.org> Reviewed-by:
John Delaney <johnidel@chromium.org> Cr-Commit-Position: refs/heads/master@{#750988}
-
Simon Zünd authored
When dumping console messages that contain LiveLocations, we need to properly await rendering updates. This CL adds the necessary call to a TestRunner helper as well as {await}s. R=petermarshall@chromium.org Bug: chromium:1032016 Change-Id: I251eb7e2265f837690d005470f442b877a7915aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106084Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#750987}
-
Michael Ershov authored
CertProvisioningWorker class implements core logic for building a CSR with DM server and importing corresponding certificate. Bug: 1045895 Test: CertProvisioningWorkerTest.* Change-Id: Ida540f2b330d0dac9e86f53568f29287559a1ad8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078582 Commit-Queue: Michael Ershov <miersh@google.com> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#750986}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/02d73f58b81e..f368dcbb7d8a git log 02d73f58b81e..f368dcbb7d8a --date=short --first-parent --format='%ad %ae %s' 2020-03-17 cepheus@frii.com SPV headers: Bump up to the latest header. Created with: gclient setdep -r src/third_party/glslang/src@f368dcbb7d8a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: radial-bots+chrome-roll@google.com,courtneygo@google.com Change-Id: I57df657610b62775843a7a02c78e01552af45bb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107283Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#750985}
-
Olivier Yiptong authored
This change adds read-through caching for font enumeration in FontCache. Invalidation is triggered whenever the invalidation of FontCache happens. The Mac implementation has been changed and the results on my machine are as follows: The enumeration of 591 fonts took ~160 ms and now take an amortized 0.45 ms in a benchmark run with 10k iterations. The performance benefits come mostly from avoiding IPC between the renderer process and fontd. Bug: 1043306 Change-Id: If9543287b26f4552b256bb909593150e32b6cdb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099471Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Olivier Yiptong <oyiptong@chromium.org> Cr-Commit-Position: refs/heads/master@{#750984}
-