- 16 Nov, 2020 40 commits
-
-
Boris Sazonov authored
This reverts commit dbf8c7e8. Reason for revert: caused crashes and test failures (https://crbug.com/1149348, https://crbug.com/1149382). Original change's description: > [ToolbarMVC] Move child coordinator initialization and ownership to LBC > > This puts LocationBarCoordinator in charge of constructing and > destroying UrlBarCoordinator, StatusCoordinator, and > AutocompleteCoordinator. This allows us to wire a few more > dependencies into constructors instead of via setters. The > coordinators are still passed to LocationBarLayout for it to use via > a new initialize() method that consolidates a few different setter > methods on LocationBarLayout. initialize() helps avoid bugs that > could arise when calling these setters out of order. There is an > additional change to LocationBarLayoutTest that fixes a DCHECK when > running tests on a debug build. > > Bug: 1146057, 1146062 > > Change-Id: Ie6c7e871d6cb0eb4bbffff0ab3ed275968d84e85 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495969 > Commit-Queue: Patrick Noland <pnoland@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Reviewed-by: Filip Gorski <fgorski@chromium.org> > Reviewed-by: Tomasz Wiszkowski <ender@google.com> > Reviewed-by: Peter Conn <peconn@chromium.org> > Cr-Commit-Position: refs/heads/master@{#827494} TBR=fgorski@chromium.org,tedchoc@chromium.org,peconn@chromium.org,pnoland@chromium.org,ender@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1146057, 1146062, 11493484, 1149382 Change-Id: Ie6578c072ab9bc1d5da8f9a5e29676ba3321442d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2540587 Commit-Queue: Patrick Noland <pnoland@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#827851}
-
Brandon Wylie authored
mocks: https://www.figma.com/file/b1CT6jM3mj0MdBvgQicy4b Bug: 1117271 Change-Id: I67cba57fce298e5ddf83edef10d331ee136cf289 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538356Reviewed-by:
-
Mike Dougherty authored
CRWContextMenuController was previously used with WKWebViews which were not associated with a WebState. This added complexity to the context menu feature which is no longer necessary. Bug: None Change-Id: I8c07675da49dd0a9cf07b14e9b14ce73d14c9ebd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523754 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#827849}
-
Leonard Grey authored
This reverts commit 11191b81. Reason for revert: Causing checkdeps failures on linux-trusty-rel Example: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8863455424170691152/+/steps/checkdeps/0/stdout Original change's description: > Correct c/b/c/input_method/DEPS > > - fix the regex that was matching against .*(...|)\.(cc|h) > (aka all *.cc, *.h). > - add a rule for dependees of tts_controller.h with commentary. > > Bug: 1148093, b/173144152 > > Change-Id: I0e1ca36fdeec5e838fa845f6f9520d130f11a68d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538141 > Reviewed-by: Darren Shen <shend@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Commit-Queue: David Tseng <dtseng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#827804} TBR=avi@chromium.org,dtseng@chromium.org,shend@chromium.org Change-Id: I102b9b65dfb5e34b0c6a24b5f8baec0c02ae645d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1148093 Bug: b/173144152 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541922Reviewed-by:
Leonard Grey <lgrey@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#827848}
-
Boris Sazonov authored
This reverts commit 7c26f582. Reason for revert: this CL depends depends on https://crrev.com/c/2495969 that has to be reverted due to test failures and crashes (https://crbug.com/1149348, https://crbug.com/1149382). Please contact bsazonov@chromium.org or pnoland@chromium.org if you have any questions. Original change's description: > [ToolbarMVC] Observe incognito state changes in location bar. > > This lets us remove LocationBar#updateMicButtonState() which was > a "poke" method on the interface. > > Do not submit before M88 branch point (Nov 12th) > > Bug: 1142883 > Change-Id: If7564ac95e6ca69e28e6de7a609f0db9fa916c9e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518202 > Commit-Queue: bttk <bttk@chromium.org> > Reviewed-by: Patrick Noland <pnoland@chromium.org> > Reviewed-by: Filip Gorski <fgorski@chromium.org> > Cr-Commit-Position: refs/heads/master@{#827544} TBR=fgorski@chromium.org,pnoland@chromium.org,bttk@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1142883, 11493484, 1149382 Change-Id: Ia30a5089a20687be350892b75411eec2a27f7691 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2540528Reviewed-by:
bttk <bttk@chromium.org> Reviewed-by:
-
Nico Weber authored
This key's value makes the build output machine-dependent, and it's not clear that we need to set it. So try not setting it. Keep setting it in iOS builds, since the key might be used by the app store submission process, and the iOS build doesn't use a hermetic Xcode anyways. Bug: 1149401 Change-Id: I86f804e60f4ba1a9dcefa46cd3f14910b654ae9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2540578 Auto-Submit: Nico Weber <thakis@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#827846}
-
Henrique Nakashima authored
https://chromium-review.googlesource.com/c/chromium/src/+/2538118 will use this parameter, but it needs to be added preemptively so that the recipe can be updated preemptively. Bug: 1146478 Change-Id: Ie9a3bc8d1885ae42fb921844bda4ae3131230ba5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538312Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#827845}
-
Dave Tapuska authored
We can move this implementation into base and DCHECK that it is only called for subframes. BUG=1097816 Change-Id: I0b89c52f1574507d5aea0b04ba4bcb4fb95bc8fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536509 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#827844}
-
yjliu authored
This flag indicates if a render pass draw quad intersects the damage from other quads under it rendering to the same target. Previously this flag was only used to tell if a backdrop filter on a render pass needed to recompute or if it could use the cached texture computed from the previous frame. In face, this flag can also be used for optimization during surface aggregation where damage on non-root render passes has been cleared out. Renaming the flag to improve readability and facilitate easier understanding in the corresponding contexts. Bug: 1142892 Change-Id: I1a3f7973bc2c23aa6a54e5c86396f95f5b302c34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538997Reviewed-by:
weiliangc <weiliangc@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Jun Liu <yjliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#827843}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f9474249e20d..1e5da6b5b505 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC hkamila@google.com,lgrey@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1144732 Tbr: hkamila@google.com,lgrey@google.com Change-Id: I82e24c15f745495d1cd80aadadc4cd3268b5ada2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538127Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#827842}
-
Zentaro Kavanagh authored
- -Wfinal-dtor-non-final-class warns on classes with final dtors but not final classes. - Error messages are better when the class is marked final. - Fix existing issues in code base and a follow up will remove warning exemption. Bug: 999886 Test: no errors building Change-Id: I1c7d6c834958298ff1b369f47be2efd2a8227338 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508187Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#827841}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/dc4637c1a983..c4294f0266f1 2020-11-16 tvanderlippe@chromium.org Typecheck sources/NavigatorView.js with TypeScript 2020-11-16 tvanderlippe@chromium.org Update Rollup and rollup-plugin-terser 2020-11-16 tvanderlippe@chromium.org Typecheck object_ui/JavaScriptAutocomplete.js with TypeScript 2020-11-16 kimanh@chromium.org [e2e] Temporarily disable flaky color swatch test If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:11493585 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ib2ed0888735046fc97bbc66b0469cd2d0ccf03f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2540648Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#827840}
-
Liquan (Max) Gu authored
In an effort to move the following showAppSelector logic into PRService: - mJourneyLogger.setNotShown(NotShownReason.OTHER); - disconnectFromClientWithDebugMessage(error); - mObserverForTest.onPaymentRequestServiceShowFailed(); this CL moves this logic out of buildUi() for the convenience of further moving. Bug: 1148902 Change-Id: Iaea07a8d2c71cd3523b59401ce3faf44d517fc80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537114 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#827839}
-
Alice Wang authored
This CL modularized the incognito_interstial package with its source files, resource file and junit tests. Bug: 1148766 Change-Id: I5ddc9a8734ff6ee7ea39d2701fe096ac39a41816 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2540469Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#827838}
-
bttk authored
Before this change there are two files named LocationBarModelTest.java Touching either of these files triggers a presubmit warning: WARNING: multiple definitions of org.ch.c.b.toolbar.LocationBarModelTest: _/src/c/a/javatests/src/org/ch/c/b/toolbar/LocationBarModelTest.java _/src/c/a/junit/src/org/ch/c/b/toolbar/LocationBarModelTest.java Now the file in junit is renamed to LocationBarModelUnitTest.java Change-Id: I10b746ae043a05414433835c33c70062b7f71f08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538016 Commit-Queue: bttk <bttk@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Reviewed-by:
-
Jan Wilken Dörrie authored
This change adds all server predictions to the log output in chrome://password-manager-internals. Before: Server predictions: { Signature of form: 8608767706003284200 - 193 Origin: https://www.dkb.de/ Action: https://www.dkb.de/ Form fields: j_username: 94183295, type=text, renderer_id = 59, autocomplete=off, SERVER_PREDICTION: NAME_FULL j_password: 1796512061, type=password, renderer_id = 60, autocomplete=off, SERVER_PREDICTION: PASSWORD } After: Server predictions: { Signature of form: 8608767706003284200 - 193 Origin: https://www.dkb.de/ Action: https://www.dkb.de/ Form fields: j_username: 94183295, type=text, renderer_id = 31, autocomplete=off, Server Type: NAME_FULL, All Server Predictions: [NAME_FULL, USERNAME] j_password: 1796512061, type=password, renderer_id = 32, autocomplete=off, Server Type: PASSWORD, All Server Predictions: [PASSWORD] } Bug: 1140493 Change-Id: I3a6e685e02e7d960d4df053cd1b9885c1f509a33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2540610Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#827836}
-
Evan Stade authored
This removes a dependency on Chrome code and makes AppBannerManager one step closer to componentization. No behavioral change is expected. Bug: 1147268 Change-Id: Ibee4bc572cba7089591ec217abce8e6446f56aa2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538040Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#827835}
-
Viktor Semeniuk authored
Removing flaky test as it is not particularly useful. There is a similar test doing the same (LastTimePasswordCheckCompletedReset). Bug: 1148791 Change-Id: Id82a00300f02336e9091d33bbd3999d78ffe4f18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2540606Reviewed-by:
-
Liquan (Max) Gu authored
This CL moves the method-types logging into CPRService because the logging is shareable with the payment request service on WebLayer. Note that the original method depended on mPaymentUiService.merchantSupportsAutofillCards(). Since this method is equivalent to BasicCardUtils.merchantSupportsBasicCard(), this CL do a replacement such that PRService does not have to depend on PaymentUiService. Bug: 1131059 Change-Id: Iaa7181494b3ab169bef9bd0895abeb1d61119017 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537139 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
-
Nazerke authored
This CL is renaming the GridItem to be the TabSwitcherItem to make it usable by the TabStrip as well as by the TabGrid. Bug: 1128249 Change-Id: Ic7736156f9cff5b6218261ce29f047b37b37253f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536435Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Cr-Commit-Position: refs/heads/master@{#827832}
-
Nina Satragno authored
Implement support for the minPINLength and forcePINChange CTAP 2.1 flags on the make credential user journey: * The minPINLength option is routed to the UI when entering a PIN, except when entering an existing PIN with forcePINChange = true. * When the correct PIN for a security key with forcePINChange = true is entered, the user is prompted to change their PIN. This change also fixes the virtual authenticator's change PIN implementation, which was validating the pin param using the wrong parameters. Follow up features will be support on GetAssertion & the chrome settings page. Bug: 1143427 Change-Id: I4188c3da2c5c49408f837217414fecdbe394c08e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518799Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Commit-Queue: Nina Satragno <nsatragno@chromium.org> Cr-Commit-Position: refs/heads/master@{#827831}
-
Liquan (Max) Gu authored
PaymentUIsObserver plays the same role as PaymentUiService#Delegate and so should be merged into one. This CL moves the PaymentUIsObserver methods into PaymentUiService#Delegate without any change. Bug: 1025619 Change-Id: I6e951168c7ed9c0e3459e55671aec9cbb69742da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536992 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/62a9a329373a..02736010cb17 2020-11-16 mbonadei@webrtc.org Stop setting mac_xcode_version in DEPS If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1147839 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I5cb3dc6908a41d53311c270c50eb0c2ed2c9c2ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538129Reviewed-by:
-
Rakina Zata Amni authored
To move the newly-created chunk instead of copying it. Bug: 1148064 Change-Id: Id1f0615f32ae58a010d7616fc347ee7b2ad228cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537508 Auto-Submit: Rakina Zata Amni <rakina@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#827828}
-
Anatoliy Potapchuk authored
In some cases, when the number of networks was too big, the network configuration buttons were not visible. Let's move them to the footer so they will always be there. Bug: 1130381 Change-Id: I67cbcab2b014a4662a93a9472c1a40e0e8525215 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537355Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Cr-Commit-Position: refs/heads/master@{#827827}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/0fc077e0651c..9f94f31cc09d 2020-11-16 bsalomon@google.com Add convenience method SkYUVAInfo::makeSubsampling. 2020-11-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 9eff98952674 to 60570b859f7c (17 revisions) 2020-11-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 3fae5295 to 2c493e0e (528 revisions) 2020-11-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from b6f4d53126d3 to 575729e8dd25 (11 revisions) 2020-11-16 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version 2020-11-13 johnstiles@google.com Stop the inliner after it has inlined 2500 statements in a program. 2020-11-13 michaelludwig@google.com Accept SkFilterQuality in SkImageFilters::Shader 2020-11-13 brianosman@google.com Fix step & smoothstep on Vulkan 2020-11-13 johnstiles@google.com Add unit test for O(n^3) behavior in the inliner. 2020-11-13 johnstiles@google.com Disallow usage of private types ($vec, etc) in non-builtin code. 2020-11-13 johnstiles@google.com Fix fuzzing error with duplicate function definitions. 2020-11-13 johnstiles@google.com Replace skslc worklist files with -- delimited command lines. 2020-11-13 fmalita@chromium.org [skottie] Initial direction for text shaping 2020-11-13 reed@google.com Add temporary Make for SkSamplingOptions If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: lovisolo@google.com Test: Test: Test: KHR-GLES31.core.texture_buffer.texture_buffer_parametersTest: Test: TextureBufferTestES31.QueryWidthAfterBufferResizeTest: Test: TransformFeedbackTest.BufferOutOfMemory/ES3_MetalTest: Test: angle_perftests --gtest_filter="*real_commando_secret_mission*"Test: Test: dEQP-GLES31.functional.state_query.texture_level.texture_buffer.width_*Test: Test: dEQP-GLES31.functional.texture.texture_buffer.state_query.texture_buffer_size_integer Change-Id: I5cdbbe815af3941fb7e04b4d76558cb94c33d571 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2540245Reviewed-by:
-
Nico Weber authored
We added this back when nacl couldn't be built on macOS 10.15. Now that that works, we no longer use machine_os_build_major, so remove it. Bug: 1049832,1147069 Change-Id: I5c52631cc3500e9cd0057d32ccba1b8da97bd8b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536783 Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#827825}
-
Vidhan authored
every task posted Currently, |AlternativeStateNameMap::LoadStatesData()| takes a |done_callback| as a parameter and inserts this callback to |pending_init_done_callbacks_| for every task posted which results in an error since |done_callback| is of |base::OnceClosure| type and can be fired only once. With this change, |done_callback| is added to |pending_init_done_callbacks_| before the tasks are posted. Bug: 1111960 Change-Id: If6fdf4a6af2a3ee9eaa0f5ac21075a7ca7ead754 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536630 Commit-Queue: Vidhan Jain <vidhanj@google.com> Reviewed-by:
Matthias Körber <koerber@google.com> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#827824}
-
Sophie Chang authored
This doesn't actually do anything with the downloads (i.e. verification, storage, etc.) but just requests for the Download Service to download models based on the URLs that the Opt Guide server sends us Bug: 1146151 Change-Id: Ifc25e7266bd2a5388036fd2f325d891a66754690 No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530760 Commit-Queue: Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#827823}
-
yjliu authored
|intersects_damage_under|. The |can_use_cached_backdrop_filtered_result_| flag on a |RenderSurfaceImpl| is set during damage tracking to mark if there's any intersecting damage from layers or other render surfaces under this |RenderSurfaceImpl| rendering to the same target. Previously this flag was intended only for a render surface with a backdrop filter to avoid recomputation of the backdrop filter, i.e. to use cached result, if there was no intersecting damage from under it. As this flag is already on |RenderSurfaceImpl|, we can use it for a more general purpose optimization at a later stage (during surface aggregation) in the pipeline if we set it appropriately for every render surface, with or without a backdrop filter. Bug: 1142892 Change-Id: Icc0e418bc4f7c09bb2825dc21fb1f8706ebcf64a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538957Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/e4c1a25cc679..8dceaddf8503 2020-11-16 capn@google.com Enable Reactor Print() in Debug/RelWithDebInfo builds If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I4049f187e65280bcbe69f288078f0aa4b1ec8b40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2540240Reviewed-by:
-
Lily Chen authored
This adds UKM metrics recording the source and target of each postMessage event. For cross-process postMessages, this is recorded from the browser side as the source ID of the source page (navigation). For same-process postMessages, this is recorded from the renderer side as the source ID of the source frame (which may be a subframe), which can then be correlated with the source page (navigation) via the DocumentCreated event. Change-Id: I1ba8fcb5d493f97d80e2de4c5c3f031025488310 Bug: 1112491 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530774Reviewed-by:
Aaron Colwell <acolwell@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#827820}
-
Chris Sharp authored
Bug: 1018157 Change-Id: I8d87afcfb665c514a4cb76ce63904d4245dc1cc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533034 Commit-Queue: Chris Sharp <csharp@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#827819}
-
kylechar authored
This function binds a callback to a task runner. The functionality already existed in media::BindToLoop() so it's intended to replace it and is built on the same BindPostTaskTrampoline logic. BindToLoop() and BindToCurrentLoop() will be replaced in a follow up CL since they are used rather widely already. There are some changes to the existing BindToLoop implementation: 1. Get the FROM_HERE location from the caller automatically rather than using the BindPostTask() location. 2. If BindPostTaskTrampoline has a OnceClosure, don't rebind the closure before posting a task. 3. Add static_assert to provide a readable error message explaining the input callback must have a void return type. 4. Don't support RepeatingCallback. This is more problematic since we will always PostTask() to destroy the callback. This is easier to add later than it would be to remove support. Bug: 1140582 Change-Id: Ibb224b44c0b0c01dd88d29e94c7e9449d3353ef5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495055 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
-
Rohit Rao authored
On the bots, these tests appear to fail because they can't find the Restore infobar after a crash. This CL changes the test to wait for the infobar to become visible, rather than doing a single check, in case the test runs so quickly that the infobar hasn't yet had a chance to appear. BUG=1149370 Change-Id: I8b65c1796408e8151582398d4b2c3c12534c209b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2540426Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#827817}
-
Liquan (Max) Gu authored
Currently, mIsUrlPaymentMethodIdentifiersSupported is computed whether it's used or not. This CL is to turn the computation into a method, and compute it only when it's needed. This change will also help moving JourneyLogger.setRequestedPaymentMethodTypes into PRService. Bug: 1131059 Change-Id: I405631119a6bf6d6dce467335ea1c53dcb37ba1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537138 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
-
Clark DuVall authored
This is a reland of c7a74ee0 Fix for manifest issue is in http://crrev.com/c/2538369, will reland after that change is submitted. Original change's description: > Enable isolated splits in canary and dev > > All major crashes have been fixed and numbers look good. M88 branch was > just cut, so should be safe to enable now. > > Bug: 1126301 > Change-Id: I351d565e68f14af2411c71fa80f34852bab5455a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529729 > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Commit-Queue: Clark DuVall <cduvall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#827387} Bug: 1126301 Change-Id: I6aa825bde70b184cdc412d37d5e5e8850f00bac0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2539667Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#827815}
-
Aaron Tagliaboschi authored
This reverts commit ce09536e. Reason for revert: Changing how the field trial for GREASEing works and simplifying change for possible merge Original change's description: > [UA-CH] Put GREASEing behind feature flag and refactor > > Leaving the possibility of turning off for compat issues. > > Bug: 1070922, 1091285 > Change-Id: Ic11ce489705c1c1b4388f24cdbf0ebdd2dca966f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532595 > Commit-Queue: Aaron Tagliaboschi <aarontag@chromium.org> > Reviewed-by: Maksim Orlovich <morlovich@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#827310} TBR=avi@chromium.org,morlovich@chromium.org,aarontag@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1070922 Bug: 1091285 Change-Id: I764fc28dc36f932538ea43febb09a5acaa387445 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536780Reviewed-by:
Aaron Tagliaboschi <aarontag@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
-
Mihai Sardarescu authored
The header X-Chrome-Connected header was sent to Gaia and Drive even when Mirror is disabled. However it seems that this header is ignored server-side, so it is better from privacy perspective to stop sending it. Bug: 1149163 Change-Id: I361754ed4d74b10a4347975d614efbd29be41d1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537838Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Auto-Submit: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#827813}
-
Clark DuVall authored
DFMs should keep manifest declarations even if resources are pulled into the base module, otherwise Android won't load the components from the correct split. Bug: 1149022 Change-Id: I21e0675004011b2b57c1b58efda0f9c85eda420e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538369Reviewed-by:
-
