GitLab

Renderer processes may die without clearing its |WebSocketBridge|s.
It is helpful to send a close frame with code = 1001 in such a case.

BUG=392534
R=ricea@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285557

Review URL: https://codereview.chromium.org/390773002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285884 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285883 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=178999:179004&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/422803002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285882 0039d316-1c4b-4281-b951-d872f2087c98

Before ScopedTestNSSDB affected several slot getters from nss_util.h .
This change reduces ScopedTestNSSDB to solely setup a temporary test DB and not influencing the global state in nss_util anymore.

As a replacement for some of its old behavior, a new ScopedTestSystemNSSKeySlot is added, which allows to override the slot returned by GetSystemNSSKeySlot().

With this change it's now possible to write tests that need both a user and system NSS DB by using ScopedTestSystemNSSKeySlot.

As a side-effect, GetPersistentNSSKeySlot() is now compiled on !OS_CHROMEOS only.

BUG=210525
(For include changes:)

R=rsleevi@chromium.org
TBR=nkostylev@chromium.org, stevenjb@chromium.org

Review URL: https://codereview.chromium.org/401623006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285881 0039d316-1c4b-4281-b951-d872f2087c98

In some senario image source url has full image data starts with
"data:" so context menu in that case returns source url starts with
"data:" and full contents.In those senario we should show only link url
instead of source url.

BUG=395511

Review URL: https://codereview.chromium.org/398893006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285880 0039d316-1c4b-4281-b951-d872f2087c98

A writable option for provided file systems has been added recently. This CL
adds checks at early stage to fail writing related operations on file systems
which were not mounted as R/W.

TEST=unit_tests: *FileSystemProvider*ReadOnly*
BUG=393506

Review URL: https://codereview.chromium.org/427493002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285878 0039d316-1c4b-4281-b951-d872f2087c98

Split the usage of Parition Alloc from mmap-catch-all. Partition Alloc
is the allocator used in Blink, and it would be helpful if we could see
the usage of this separately.

NOTRY=true

Review URL: https://codereview.chromium.org/423793003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285877 0039d316-1c4b-4281-b951-d872f2087c98

This removes the code that resolves the webstore URL which doesn't seem
too work any more. Instead it just navigates to the webstore page and
uses WebstoreInstallWithPrompt to install the app.

BUG=341353

Review URL: https://codereview.chromium.org/412043003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285876 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285875 0039d316-1c4b-4281-b951-d872f2087c98

As such, update telemery to html imports as well.

TBR=dtu,dsinclair

Review URL: https://codereview.chromium.org/418883003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285874 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285873 0039d316-1c4b-4281-b951-d872f2087c98

https://skia.googlesource.com/skia/+log/048f422ec666cb18089c8fa7507e6bdca60d373c..e5ad0dde25ffde2f8cf7491240559c999be6ab24

CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_layout_rel
TBR=bensong@google.com
BUG=

Review URL: https://codereview.chromium.org/422723002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285872 0039d316-1c4b-4281-b951-d872f2087c98

> Revert 285832 "Disable accessible touch exploration by default."
> 
> This change was to disable the feature on M37. Reverting so that
> accessible touch exploration is enabled again on trunk.
> 
> > Disable accessible touch exploration by default.
> > 
> > Touch exploration was too buggy in M37, we don't want to launch it.
> > The plan is to land this change and merge to M37, then revert it to aim for
> > a launch of touch exploration in M38.
> > 
> > BUG=396193
> > 
> > Review URL: https://codereview.chromium.org/414493004
> 
> TBR=dmazzoni@chromium.org
> 
> Review URL: https://codereview.chromium.org/419423003

TBR=dmazzoni@google.com

Review URL: https://codereview.chromium.org/419423004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285871 0039d316-1c4b-4281-b951-d872f2087c98

To stop depending on resources under chrome/ from AutocompleteMatch.

Add a new file autocomplete_scaled_resources.grdp.
Inline AutocompleteMatch::TypeToLocationBarIcon() to its exclusive user omnibox_view.cc.

BUG=388510
TEST=build

Review URL: https://codereview.chromium.org/415073003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285870 0039d316-1c4b-4281-b951-d872f2087c98

r281335 left the header definition.

BUG=389703

Review URL: https://codereview.chromium.org/421143002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285869 0039d316-1c4b-4281-b951-d872f2087c98

This patch fixes random linter issues.

TEST=Cleanup only. All current tests pass.
BUG=393506, 393142

Review URL: https://codereview.chromium.org/412163002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285868 0039d316-1c4b-4281-b951-d872f2087c98

This change was to disable the feature on M37. Reverting so that
accessible touch exploration is enabled again on trunk.

> Disable accessible touch exploration by default.
> 
> Touch exploration was too buggy in M37, we don't want to launch it.
> The plan is to land this change and merge to M37, then revert it to aim for
> a launch of touch exploration in M38.
> 
> BUG=396193
> 
> Review URL: https://codereview.chromium.org/414493004

TBR=dmazzoni@chromium.org

Review URL: https://codereview.chromium.org/419423003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285867 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285866 0039d316-1c4b-4281-b951-d872f2087c98

This pulls in the following Native Client changes:

r13507: (noelallen) Reapply patch which was reverted due to conflict.
r13508: (dschuff) PNaCl Driver: do not generate temp file names beyond Windows' MAX_PATH limit
r13509: (jvoung) Add a flag to pnacl-finalize that allows users to keep function names.
r13510: (dschuff) Disable flaky sandboxed translator tests on mac
r13511: (dschuff) Update revision for PNaCl r13466->r13509
r13512: (ncbray) Fix untrusted.gypi and build_nexe.py
r13513: (noelallen) Cleanup bionic build script.
r13514: (dyen) Added initial pass of nacl_irt_code_data_alloc.
r13515: (sbc) Use custom exception class for errors in package_version.
r13516: (hidehiko) Non-SFI mode: SCONS_NONSFI_TC clean up.
r13517: (hidehiko) Non-SFI Mode: Refactoring. Provide non-SFI version of nacl_irt_query_core.
r13518: (binji) Revert "Non-SFI mode: SCONS_NONSFI_TC clean up."
r13519: (bradnelson) Make the trybots fail early if 'git cl try' is mistakenly used.
r13520: (bradnelson) Make build_nexe.py rebuild when script itself has changed.
r13521: (noelallen) Updates GN dep, and cleans up some toolchain prep definitions to make it easier to debug what's going on.
r13523: (teravest) Add embedder interface for fatal log messages.
r13524: (bradnelson) Passing --config-name to build_nexe.py for all arches.
r13525: (teravest) Create a sel_ldr_launcher_base target.
r13526: (teravest) Revert "Add embedder interface for fatal log messages."
r13527: (hidehiko) Non-SFI mode: Get rid of socketcall on ARM.
r13528: (teravest) Add embedder interface for fatal log messages.
r13529: (sbc) Drop .ARM.exidx segment in nacl_helper_bootstrap linker script.
r13530: (binji) Disable tests that fail on mac10.7-newlib-dbg-asan bot.
r13531: (binji) Another try at disabling mac-asan tests from r13530.
r13532: (sbc) Allow cross compiled trusted components to be disabled in core_nacl_sdk.gyp.
r13533: (jvoung) Revert "Update revision for PNaCl r13466->r13509"
r13534: (binji) Disable more tests that fail on mac10.7-newlib-dbg-asan.
r13535: (binji) Fix typo introduced in r13534.
r13536: (sbc) Add cast operators to call to __builtin___clear_cache.

BUG=none
TEST=browser_tests and nacl_integration
TBR=bradnelson@google.com

Review URL: https://codereview.chromium.org/420083002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285865 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285864 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=178992:178998&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/426493003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285863 0039d316-1c4b-4281-b951-d872f2087c98

The --app flag is gone, now it is called --app-shel-app-path.

BUG=None
TEST=see README
R=jamescook@chromium.org
TBR=yoz@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/414223010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285862 0039d316-1c4b-4281-b951-d872f2087c98

BUG=389016

Review URL: https://codereview.chromium.org/420713002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285861 0039d316-1c4b-4281-b951-d872f2087c98

Note even base compiles with the change to disable it.

TBR=pkasting

Review URL: https://codereview.chromium.org/422773002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285860 0039d316-1c4b-4281-b951-d872f2087c98

Installing an ephemeral app bypasses download of the CRX from the
webstore and thus also bypasses post-install UI. This patch ensures
that post-install UI is shown, such as showing the app launcher with
the app highlighted.

BUG=394997
TEST=See bug

Review URL: https://codereview.chromium.org/407483002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285859 0039d316-1c4b-4281-b951-d872f2087c98

Causing UAFs on ClusterFuzz

BUG=397656

> Make DataSource::Stop() synchronous.
> 
> In a lot of filters in media code, Stop() has been folded into the dtor.
> This model doesn't apply directly to DataSource because DataSource::Stop()
> is called by the FFmpegDemuxer, but the DataSource is owned by
> WebMediaPlayerImpl.
> 
> TBR=gbillock@chromium.org
> BUG=349211
> TEST=All existing tests pass.
> 
> Review URL: https://codereview.chromium.org/413243002

TBR=xhwang@chromium.org

Review URL: https://codereview.chromium.org/421843004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285858 0039d316-1c4b-4281-b951-d872f2087c98

Some purely mechanical changes left over from r283694, now that
aura::test::EventGenerator has moved to ui::test in src/ui/events.

Moves aura/test/event_generator.* to event_generator_delegate_aura.*
Removes `using ui::test::EventGenerator;` declaration and redirects
includes that don't extend the delegate to include the ui/test
event_generator.h directly

BUG=378134

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285209

Review URL: https://codereview.chromium.org/406413004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285857 0039d316-1c4b-4281-b951-d872f2087c98

Ifdef out MemoryTest.Invalid until I convert it. This lets me remove the
old (now otherwise-unused) Verify...() functions.

Also delete UserPointerValue, etc.: It's easier to just add a
GetPointerValue() method to UserPointer.

R=darin@chromium.org

Review URL: https://codereview.chromium.org/425523002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285856 0039d316-1c4b-4281-b951-d872f2087c98

Make --output-format=csv uses the new OutputFormatter instead of
subclassing PageMeasurementResults.

BUG=346956

Review URL: https://codereview.chromium.org/416993008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285855 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285854 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=178991:178991&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/419423002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285853 0039d316-1c4b-4281-b951-d872f2087c98

BUG=NONE
R=darin

Review URL: https://codereview.chromium.org/406913002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285852 0039d316-1c4b-4281-b951-d872f2087c98

Previously, the x509 cert implementation only had SHA-1 based fingerprinting for
quickly creating indexing appropriate hashes. Since SHA-1 is likely
cryptographically broken, these fingerprints should not be used for any security
decisions. This adds slow SHA-256 fingerprint support for when fingerprints are
needed for security decisions.

R=rsleevi@chromium.org
BUG=262615

Review URL: https://codereview.chromium.org/412263003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285851 0039d316-1c4b-4281-b951-d872f2087c98

This reverts r285292, but avoids modifying
RendererPreference::subpixel_positioning's default value, as
it appears to be used by layout tests on Android.

BUG=285292
TBR=msw@chromium.org,boliu@chromium.org,jln@chromium.org,jochen@chromium.org

Review URL: https://codereview.chromium.org/417953006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285850 0039d316-1c4b-4281-b951-d872f2087c98

If the Runner wasn't actually told to Start(), the DelegateSimpleThread would
DCHECK for not having been Started. This patch makes it so we don't allocate
a DST unless we need to.

Also adds basic unittest files for DynamicServiceLoader and Runner.

BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285650

Review URL: https://codereview.chromium.org/414173004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285849 0039d316-1c4b-4281-b951-d872f2087c98

To fix tree-closer in Linux ASan LSan Tests (1) since
http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%281%29/builds/4338

errors like

Direct leak of 72 byte(s) in 1 object(s) allocated from:
    #0 0x44145b in operator new(unsigned long) /usr/local/google/work/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:55
    #1 0x5e8afd in device::HidService::Create(scoped_refptr\u003Cbase::MessageLoopProxy>) device/hid/hid_service.cc:26
    #2 0x509324 in device::HidServiceTest_Create_Test::TestBody() device/hid/hid_service_unittest.cc:15

BUG=367145
NOTRY=true
NOTREECHECKS=true
TBR=rockot@chromium.org

Review URL: https://codereview.chromium.org/424623002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285848 0039d316-1c4b-4281-b951-d872f2087c98

BUG=397888
TBR=jchaffraix@chromium.org

Review URL: https://codereview.chromium.org/421843002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285847 0039d316-1c4b-4281-b951-d872f2087c98

R=maruel@chromium.org

Review URL: https://codereview.chromium.org/419973006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285842 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285841 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285840 0039d316-1c4b-4281-b951-d872f2087c98