Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 23 Nov, 2018 31 commits
  3. 22 Nov, 2018 9 commits
    • Luciano Pacheco's avatar
      Fix some more with flag MyFilesVolume enabled · 7dd3be88
      Luciano Pacheco authored 
      Change EntryList method from children to use getUIChildren so it has
the same API as VolumeEntry.

Change util.isDescendantEntry to check getUIChildren for EntryList and
VolumeEntry if the filesystem of both entris are different. These 2
types contain entries with different filesystem thus we should check
those.

Add toEntryList helper just to be able to check that an entry has the
method getUIChildren without closure complaining that Entry and
FilesAppEntry don't have such attribute, this method is only available
in EntryList and VolumeEntry.

Change directory_tree EntryListItem to add the volume type attribute
to have it compatible with and without MyFilesVolume flag.

Change file_display.js selector to use volume-type-icon makes downloads
folder selector compatible with/without MyFilesVolume flag.

Change FileManager to check if MyFiles actually exist before assigning
to nextCurrentDirEntry, this happens if MyFiles is a volume and isn't
mounted. Also in this condition (MyFiles being a volume but not
mounted) change NavigationListModel to create a EntryList for MyFiles
so it can display Linux or Play files if they exist.

before this change.

Test: Enabled a few tests with MyFilesVolume flag that were broken
Bug: 873539
Change-Id: I66d2b95d5ea5897c2f2db558f46b0bcfcfd0c900
Reviewed-on: https://chromium-review.googlesource.com/c/1345708
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Reviewed-by: default avatarJoel Hockey <joelhockey@chromium.org>
Reviewed-by: default avatarLuciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610505}
      7dd3be88
    • Nicolas Pena's avatar
      [EventTiming] Move tests to WPT · f1fb6d61
      Nicolas Pena authored 
      This CL moves Event Timing tests to web-platform-tests. Relevant changes:
* Move to using test_driver.click.
* Replace setTimeout with step_timeout.
* Move to using a python-based slow image resource.

Bug: 841224
Change-Id: I21f322546815d7d6bcec4dd1703de50a9296d992
Reviewed-on: https://chromium-review.googlesource.com/c/1348855
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Reviewed-by: default avatarTimothy Dresser <tdresser@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610504}
      f1fb6d61
    • Nick Harper's avatar
      Update bulk entries in HSTS preload list · a3da5edf
      Nick Harper authored 
      TBR=bnc@chromium.org

Change-Id: Ibdd3ce5b262be153ba4219e5864e5394323e82b6
Reviewed-on: https://chromium-review.googlesource.com/c/1345092Reviewed-by: default avatarNick Harper <nharper@chromium.org>
Reviewed-by: default avatarBence Béky <bnc@chromium.org>
Commit-Queue: Nick Harper <nharper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610503}
      a3da5edf
    • Lucas Furukawa Gadani's avatar
      Disable WebViewTest.InterstitialPageFocusedWidget with committed interstitials. · 03630eda
      Lucas Furukawa Gadani authored 
      Bug: 752372
Change-Id: Icc7b51b58168982b0237cd6a3fe06259c8a6f7ac
Reviewed-on: https://chromium-review.googlesource.com/c/1348971
Commit-Queue: Lucas Gadani <lfg@chromium.org>
Reviewed-by: default avatarCarlos IL <carlosil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610502}
      03630eda
    • Peng Huang's avatar
      Reland "Using PaintCanvas for HUD" · 3d087e98
      Peng Huang authored 
      
Original change's description:
> Revert "Using PaintCanvas for HUD"
> 
> This reverts commit 25718190.
> 
> Reason for revert: It breaks FPS counter on Mac
> https://bugs.chromium.org/p/chromium/issues/detail?id=906570
> 
> Original change's description:
> > Using PaintCanvas for HUD
> >
> > To support OOPR, we need switch from SkCanvas to PaintCanvas which is for
> > OOPR.
> >
> > Bug: 895568
> > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
> > Change-Id: I94b5430c7ee8ed2f5140d352214ec43f2ff0f8ad
> > Reviewed-on: https://chromium-review.googlesource.com/c/1286950
> > Commit-Queue: Peng Huang <penghuang@chromium.org>
> > Reviewed-by: enne <enne@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#609033}
> 
> TBR=penghuang@chromium.org,enne@chromium.org
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Bug: 895568, 906570
> Change-Id: I935de60977c0374139ae1eb22670d234f85e0df6
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
> Reviewed-on: https://chromium-review.googlesource.com/c/1342049
> Commit-Queue: Peng Huang <penghuang@chromium.org>
> Reviewed-by: Peng Huang <penghuang@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#609333}

TBR=penghuang@chromium.org,enne@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 895568, 906570
Change-Id: I65448fa5e72d1aa9bf79aa8513944f2ce953b91f
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/c/1348864
Commit-Queue: Peng Huang <penghuang@chromium.org>
Reviewed-by: default avatarPeng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610501}
      3d087e98
    • sebsg's avatar
      [AF] Remove HasSeenDynamicForm bucket logging. · cf5aed7e
      sebsg authored 
      The value was so big it was making analysis of other values difficult.
It also was not useful anymore.

Change-Id: I0163b1d9c6183c4791ca19baf825f9e82311e547
Reviewed-on: https://chromium-review.googlesource.com/c/1348953
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: default avatarRoger McFarlane <rogerm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610500}
      cf5aed7e
    • Nicolas Pena's avatar
      Reland "Unify input delay computations" · 4d820bcd
      Nicolas Pena authored 
      This is a reland of 5d945012

Original change's description:
> Unify input delay computations
>
> This CL unifies the timestamp computations for FID as reported to UMA and FID as
> exposed in the Web Perf API. It moves the UMA reporting from the
> PageWidgetDelegate to the EventTiming class. After this CL, the same types of
> events are logged by both the UMA metric and the webexposed metric. In addition,
> this CL removes the check that there are default actions or event handlers from
> EventTiming, which means that now the webexposed API will expose events even if
> they have no associated event handlers. In particular, this means that a click
> will now trigger mousedown, click, and mouseup entries, in that order. This is
> reflected in changes to the layout tests.
>
> Bug: 897656
> Change-Id: Ibeee0ffe9ff1fc0df74585da96a8fd3a6f2d17dc
> Reviewed-on: https://chromium-review.googlesource.com/c/1334564
> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
> Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
> Reviewed-by: Timothy Dresser <tdresser@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#610201}

TBR=dtapuska@chromium.org

Bug: 897656, 843184
Change-Id: I4d97f2731fe957696c0e908d5ef3493235b52d49
Reviewed-on: https://chromium-review.googlesource.com/c/1348254Reviewed-by: default avatarNicolás Peña Moreno <npm@chromium.org>
Reviewed-by: default avatarTimothy Dresser <tdresser@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610499}
      4d820bcd
    • Matt Falkenhagen's avatar
      Remove caching of CORS info from CanvasRenderingContext. · 889ddafc
      Matt Falkenhagen authored 
      Before this CL, CanvasRenderingContext remembered which request URLs
were CORS same-origin and which were CORS cross-origin. This worked
relatively well in a pre-service-worker world. But with service workers,
the same request URL can have different response URLs. Also, even if two
things have have the same response URL, they could differ in whether
they were CORS approved or not.

The solution is to remove the caching entirely. This causes more calls
to CanvasImageSource::WouldTaintOrigin(), but the implementations of
those look relatively lightweight so I don't expect performance to be
worse than tracking URLs in two HashSets.

Test: fetch-canvas-tainting-double-write.https.html added in
https://chromium-review.googlesource.com/c/chromium/src/+/1347952.

Bug: 907047
Change-Id: I4cf6289174935dee40ccad0364eb425d717b9f7f
Reviewed-on: https://chromium-review.googlesource.com/c/1347953Reviewed-by: default avatarFernando Serboncini <fserb@chromium.org>
Reviewed-by: default avatarMakoto Shimazu <shimazu@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610498}
      889ddafc
    • chromium-autoroll's avatar
      Roll src/third_party/webrtc f25907800923..2c977b4cc57d (6 commits) · e373f9b9
      chromium-autoroll authored 
      https://webrtc.googlesource.com/src.git/+log/f25907800923..2c977b4cc57d


git log f25907800923..2c977b4cc57d --date=short --no-merges --format='%ad %ae %s'
2018-11-22 terelius@webrtc.org Remove RSID from stream configs in new event log format.
2018-11-22 yvesg@webrtc.org [GN] Fix dependency rebasing in BUILD.gn files.
2018-11-22 srte@webrtc.org Routing BitrateAllocationUpdate to audio codec.
2018-11-22 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 1500c78c..f9be7d3d (610314:610432)
2018-11-22 peterhanspers@webrtc.org Metal: Don't render into an empty view.
2018-11-22 gustaf@webrtc.org AEC3: Clockdrift detection


Created with:
  gclient setdep -r src/third_party/webrtc@2c977b4cc57d

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng

BUG=chromium:None
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Ic20882afbd8663158dfe2db60496ac5d7c98f874
Reviewed-on: https://chromium-review.googlesource.com/c/1348574Reviewed-by: default avatarchromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#610497}
      e373f9b9