- 19 Feb, 2020 40 commits
-
-
gogerald authored
Bug: 1051226 Change-Id: Ieee0fcb41ff6f3d1282b709cffd23ed381102687 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050754Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#742804}
-
John Smith authored
Bug: 1052427 This follows up http://crrev.com/c/1941064. The hue shift, with certain accent colors could cause unexpected changes like a red accent titlebar turning to blue when inactive. This change is to remove the hue shift so the color overall stays in the same space but to still maintain as close to the kGoogleGrey900 (0x20, 0x21, 0x24) -> kGoogleGrey800 (0x3C, 0x40, 0x43) as possible. With kGoogleGrey900 as the input, this code outputs (0x3B, 0x3E, 0x44). I chose this one because it was very close to (0x3C, 0x40, 0x43) and kept the overall color biased towards the green and blue channels. Some other options considered were: return {-1, 0.53, 0.567}; #3C3E43 return {-1, -1, 0.57}; #3F4043 return {-1, -1, 0.569}; #3F4042 return {-1, -1, 0.572}; #404144 return {-1, -1, 0.568}; #3E3F42 return {-1, 0.55, 0.567}; #3B3D44 return {-1, 0.54, 0.567}; #3B3E44 return {-1, 0.54, 0.57}; #3D3F45 Boosting the red channel and losing the green were resulting in slightly warm and faded colors that didn't feel like they fit in the Chromium color set. Tested against the default Windows set of accent colors and saw differentiation between active and inactive windows without unexpected color shifts. As a note on existing behavior, the colors of the new tab button and background tab text can switch between active/inactive window states. Change-Id: Ib67d11c720c58036cb255aee743916d6a8f2bab9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063737 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#742803}
-
Nnamdi Theodore Johnson-Kanu authored
This CL continues the process of separating the strings into specific files. Strings used by both Chrome OS and Chrome browser settings sync control subpage and settings signout subpage are removed from setting_strings.grdp and added into shared_settings_strings.grdp. This effort was started in parent 2042733. Bug: 967883 Change-Id: I2c41bd3589f357bd5b2496f4eaeecccae2e00ebd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044478 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#742802}
-
Ella Ge authored
TBR=sahel@chromium.org No-try: true Bug: 1054103 Change-Id: I609442d233fdca819d1070087b2fec9a54b61edb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064473Reviewed-by:
Ella Ge <eirage@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#742801}
-
Ahmed Fakhry authored
TBR=oshima@chromium.org BUG=none Change-Id: I2b483d216edc3d12c8b64a926d0e68de6efdfab0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064814 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#742800}
-
Daniel Murphy authored
For the histograms: WebCore.IndexedDB.BackingStore.DeleteDatabaseStatus WebCore.IndexedDB.BackingStore.OpenFirstTryResult The data is good, I just have the wrong enum specified. This change fixes that. R=mpearson@chromium.org Bug: 1026889 Change-Id: I7213c6b576e9a94c50e875c856721181d7efb1e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064817Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Auto-Submit: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#742799}
-
Travis Skare authored
This is towards servicification. Bug: 1050259 Change-Id: Ia32c670da08b2026b46b8e64030e1f2054a19a22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2045136 Commit-Queue: Travis Skare <skare@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#742798}
-
Ella Ge authored
test is flaky. TBR=sahel@chromium.org No-try: true Bug: 1054062 Change-Id: I761b165af9cfa93747cedd55ba96416c5c96a810 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064825Reviewed-by:
-
Ella Ge authored
test is flaky TBR=rouslan@chromium.org No-try: true Bug: 1054058 Change-Id: I5cde06091075615d5d879455154bf20c7cf288db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065134Reviewed-by:
-
Nic Champagne Williamson authored
This change fixes updating the hovered and pressed states of toolbar buttons in hovered and pressed states on linux when in incognito. The |COLOR_TOOLBAR_BUTTON_ICON_HOVERED/PRESSED| theme properties now correctly update when the theme changes in GtkUi::UpdateColors(). Bug: 1053856 Change-Id: I5d7a98edd2174baeff6f14aa72cdc767779ffec4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065050Reviewed-by:
-
Robert Ogden authored
Unblocks //net work that assumes NIK and site for cookie match. Bug: 1053585 Change-Id: I249070ccad9540ffd13649887df6e63c00f9875f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063934Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#742794}
-
Ahmed Fakhry authored
Since https://crrev.com/c/2044644, the desk bar is an activatable window placed in the active desk's container. Removing the active desk from overview means hiding its container, and showing another one. The desk bar should be one of those windows that move to the newly-activated desk's container when its original (previously-active) desk is removed. BUG=1053771 TEST=Manually, expanded an existing test. Change-Id: Id4bb2084ac0117fab4334819c9d79e40e8a565d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063810Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#742793}
-
Maks Orlovich authored
The passed in site_for_cookies_ (which considers the entire frame hierarchy) is what should be used, not origin, which is for local frame only. (Android Webview is the only embedder in Chrome tree that uses this knob) Bug: 1052454 Change-Id: I9d25321648d6312df9c3113a3c681fbbb6e71f60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062937 Commit-Queue: Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#742792}
-
Sven Zheng authored
This reverts commit 6d8aca62. Reason for revert: We decide not adding a bot in chromium.win. Original change's description: > Move win pixel tests from fyi to chromium.win > > Now Skia Gold can make comments on gerrit, so it's time to move this > out of fyi. > > Bug: 958242 > Change-Id: I1274cc5da4feb7e9904bf788b9d9d7633dfeac5b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053803 > Reviewed-by: Garrett Beaty <gbeaty@chromium.org> > Commit-Queue: Sven Zheng <svenzheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#741231} TBR=bsheedy@chromium.org,gbeaty@chromium.org,svenzheng@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 958242 Change-Id: Iec0093cf4ca9959b71f15e5fe28d669990ed5ebd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063913Reviewed-by:
Sven Zheng <svenzheng@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Sven Zheng <svenzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#742791}
-
Min Qin authored
BUG=103742 Change-Id: I214cd5413b01aae5fc022c45f72965dd360b889e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055971Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#742790}
-
Ella Ge authored
Test is flaky. TBR=sahel@chromium.org No-try: true Bug: 1054108 Change-Id: Iba8f8b36d7f972928571462f50493efc36892d35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062886Reviewed-by:
-
Ian Barkley-Yeung authored
ChromeOS already has an OS-level consent system governing creation and uploading of crash reports. Remove the separate crashpad one. FYI, crashpad's upload consent was already being ignored. This is just ensuring that fact is clear. BUG=chromium:1037656 TEST=Ran on Linux with --enable-crashpad, could enable and disable crash uploading. Ran on ChromeOS with --enable-crashpad, crash reports still generated. Change-Id: I1a8bbafb3292009fdb02ecc84dd1506535766e61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044641 Commit-Queue: Ian Barkley-Yeung <iby@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#742788}
-
Olivier Li authored
The calls update the work id before doing internal work and/or waiting for it. Bug: 851163 Change-Id: I6fc302a5b160800aef0973e1d21681555b1f924a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063036 Commit-Queue: Oliver Li <olivierli@chromium.org> Reviewed-by:
Mike Wittman <wittman@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#742787}
-
Sami Kyostila authored
This change makes it a requirement to pass in TaskTraits to base::PostDelayedTask(), bringing it in line with the other task posting APIs. This patch has no functional changes. Bug: 968047 Change-Id: I67daf3c1560f9c386578d458a45a3c791786141e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985773 Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I4c5b6724a26aa5acbe5e359a21f66b9ecb94933c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062572Reviewed-by:
Ben Mason <benmason@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#742785}
-
Felicia Lim authored
Tested media/test/data/opus-trimming-test.ogg/webm/opus-trimming-test.ogg playback in a chrome session (see https://bugs.chromium.org/p/chromium/issues/detail?id=1051111#c6) Bug: 1051111 Change-Id: Ib9a4b3a91d09720939286f9101c5ac61048b1dc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057642Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#742784}
-
Xiaohui Chen authored
Bug: 149759085 Test: run integration tests Change-Id: Ib6ef5db411f7e1eb6571ca5568178536e726b1a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062685 Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#742783}
-
Nnamdi Theodore Johnson-Kanu authored
Before this CL, the route list of settings subpage routes in isOSSettingsSubPage was incomplete. The CL adds chromeOS routes that were missing. ChromeOs pages which can be opened by android intents are added to the ChromePage enum. Originally this listed was curated and only whitelisted chrome pages could be added. This was because of security concerns. https://chromium-review.googlesource.com/c/chromium/src/+/750501/. In https://chromium-review.googlesource.com/c/chromium/src/+/784396/ whitelisting was removed and all settings URLs where now accessible to android intents. Bug: 982445 Change-Id: I67a1bb665f4705fe5a379f7da920878732606628 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036935Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
Long Cheng authored
This is a reland of ace0df39 Original change's description: > Fix default page break for Krane devices. > > Adding default page break too early will cause the default page break > gets deleted immediately. > > Now move the installation of default page break after ChromeOS settings > app is installed. > > Bug: 1031410 > Test: Manual > > Change-Id: If8d6522993518ccc109ac0bf368cdd077a97f301 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056578 > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Commit-Queue: Long Cheng <lgcheng@google.com> > Cr-Commit-Position: refs/heads/master@{#742304} Bug: 1031410 Change-Id: I6367b3ae44a05f85a014723078c6718ac4832c97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064601 Commit-Queue: Long Cheng <lgcheng@google.com> Reviewed-by:
-
Sven Zheng authored
Fix test failure when binary built with --dcheck_always_on=true. Bug: 958242 Change-Id: Ic4645e517c0f29169e444fb1b6d3b1b2921720d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063223 Auto-Submit: Sven Zheng <svenzheng@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#742780}
-
Piotr Bialecki authored
Bug: https://crbug.com/1054042 Change-Id: I5b3009997f76ec79f9ffc6abb1ba669f3f010ce9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063671 Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#742779}
-
Xiaoqian Dai authored
- The back gesture contextual nudge ui will appear when a user navigates to the second page within any Chrome apps in tablet mode. Show frequency: * It only shows once per active day for over 3 days per user * and the user hasn't been done back gesture successfully for 7 times Bug: 1009005b Change-Id: Ide2dbf46be1dfcd0963d4466448f5a6ff5d62f9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062917 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
-
Anastasia Helfinstein authored
There have been a few major refactors of Switch Access recently. This change looks at AutoScanManager and cleans up things that are now overly complex, or need adjusting. Bug: None Change-Id: Ic77fb49a143ce91ff90099f773f613bd2f9e55ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056502Reviewed-by:
Katie Dektar <katie@chromium.org> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#742777}
-
Jose Lopes authored
This is a repeating callback because the field: EncryptedMediaInitDataCB encrypted_media_init_data_cb_ defined in: https://cs.chromium.org/chromium/src/media/filters/chunk_demuxer.h?rcl=44124afc1e06fad84a6e6df7b728f80c6de5b5ac&l=477 binds in: https://cs.chromium.org/chromium/src/media/filters/chunk_demuxer.cc?rcl=44124afc1e06fad84a6e6df7b728f80c6de5b5ac&l=674 against a base::RepeatingCallback declared in: https://cs.chromium.org/chromium/src/media/filters/source_buffer_state.cc?rcl=44124afc1e06fad84a6e6df7b728f80c6de5b5ac&l=152 to a type alias defined in: https://cs.chromium.org/chromium/src/media/base/stream_parser.h?rcl=44124afc1e06fad84a6e6df7b728f80c6de5b5ac&l=108 This is part of the base::Callback migration. Context: https://cs.chromium.org/chromium/src/docs/callback.md?rcl=9fcc3764aea8f97e9f6de4a9ee61d554e67edcda&l=40 Bug: 714018 Change-Id: I393047264102bc9b847e6603f8e79913acd6d009 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036062Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Auto-Submit: Jose Lopes <jabolopes@google.com> Cr-Commit-Position: refs/heads/master@{#742776}
-
Jose Lopes authored
I accidentally hit submit on a CL with an open comment asking to replace reset with make_unique. So I am sending another CL with that change. Bug: 714018 Change-Id: I147f54feafd86c970096f6385273a7fa57e96227 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062402Reviewed-by:
-
Alison Maher authored
Add support for fieldset fragmentation. This change assumes that fieldset content (including the legend) is monolithic. Follow up CLs will handle the fragmentation for fieldset content. Tests added to NGFieldsetLayoutAlgorithmTest. Bug: 875235 Change-Id: I08c30d1a99715d3a326b9c2064166a82385048f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057584 Commit-Queue: Alison Maher <almaher@microsoft.com> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#742774}
-
liberato@chromium.org authored
TextureWrapper::ProcessTexture is now given the d3d texture, array slice directly. By decoupling the decoder and copy / bind steps, it makes it easier to build the standalone TextureImporter to handle the latter. Change-Id: I9c4261172e8d2c868f34751831b1e7b184c67c57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003077 Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by:
Ted Meyer <tmathmeyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#742773}
-
Will Harris authored
BrowserRenderProcessHost.OnChannelError Removed because it was not being used. Windows.GetVersionExVersion Windows.PatchLevel Expires never, because used to determine Windows population for security mitigations and other features/deprecations. CrashExitCodes.Extension CrashExitCodes.Renderer Both of these are critical stability metrics for analysing stability spikes. ChildProcess.Crashed2 ChildProcess.Killed2 Used to determine spikes in child process terminations. BUG=1053238,1053188,1052955,1052945 Change-Id: Ie73b80c98ba7724a59207511580c40f9aa8699d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062757Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#742772}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/5f1ad0dc47b5..28abea51fa9b git log 5f1ad0dc47b5..28abea51fa9b --date=short --first-parent --format='%ad %ae %s' 2020-02-19 mtklein@google.com dip our toes into c++11 style [[attributes]] 2020-02-19 cwallez@chromium.org Fix compilation of Dawn backend after GrMesh/GrPrimitiveType change 2020-02-19 jlavrova@google.com layout/relayout with different widths and justification 2020-02-19 csmartdalton@google.com Improve the mechanism to suppress warning messages during testing 2020-02-19 jvanverth@google.com Reland "Manage renderCmdEncoder over lifetime of GrMtlOpsRenderPass." Created with: gclient setdep -r src/third_party/skia@28abea51fa9b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: lovisolo@google.com Change-Id: I4cecfc2adefd03d8aba203d2a506a352962f4c04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064439Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#742771}
-
Paul Moy authored
Add current, technology and status to the battery metrics already collected by DeviceStatusCollector. Of these three, only technology is expected to change infrequently, so sample current and status more frequently. CrosHealthdServiceConnectionTest.ProbeTelemetryInfo Bug: chromium:1053755 Test: DeviceStatusCollectorTest.TestCrosHealthdInfo and Change-Id: I30f7abfcdd35e71972ce4f053b9433ba61f71cb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064458Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
-
Johannes Henkel authored
... in https://bugs.chromium.org/p/chromium/issues/detail?id=1044989 Change-Id: I8ee0c982f0770e76dd23df3a84749af98bf8c2d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063851Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/master@{#742769}
-
Matt Jones authored
The current set of experiments are not slated for launch, this patch updates the field trial config to match that expectation. Change-Id: I0299edbcc9cc38f49e55f725c31c67dbdf4ef951 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057153 Auto-Submit: Matthew Jones <mdjones@chromium.org> Commit-Queue: Jesse Doherty <jwd@chromium.org> Reviewed-by:
-
Michael Sun authored
Unlike most keyboards, which have a single Play/Pause toggle key, Bluetooth devices with AVRCP (Audio/Video Remote Control Profile) generate separate Play and Pause key events based on the media status. This patch adds handling for the Play media key. BUG=b/147364135 Change-Id: Ie3cbc4c02ceab8e317f79d089eb8b163aa3ed658 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062941Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Michael Sun <michaelfsun@google.com> Cr-Commit-Position: refs/heads/master@{#742767}
-
Evan Stade authored
The shared parts of TabModalPresenter, which include layout inflation, animations, and some accessibility, are moved into //components. Chrome-specific specialization is delegated via abstract methods. Bug: 1045499, 1025256 Change-Id: I2e37561338344495c6ee5cf5e0606c0f76e2c6d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048846 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#742766}
-
Jerome Jiang authored
https://chromium.googlesource.com/webm/libvpx.git/+log/36133b04c0d3..55f2e4a0a80d $ git log 36133b04c..55f2e4a0a --date=short --no-merges --format='%ad %ae %s' 2020-02-18 marpan vp9-rtc: Increase partition threshold to 8x8 for high Q 2020-02-18 jianj Cap delta_q_uv to -15..15 2020-02-18 marpan vp9-rtc: Set enable_adaptive_subpel_force_stop to 0 2020-02-14 jzern vp8_decode: add missing vpx_clear_system_state 2020-02-14 jzern vp8,GetSigned: silence unsigned int overflow warning 2020-02-14 jzern move common attribute defs to compiler_attributes.h 2020-01-27 chengchen Add a unit test to check partition info 2020-02-10 chengchen Set mv to zero if the second ref does not exist 2020-02-10 angiebird Do save/restore_encode_params when rate_ctrl is on 2020-02-06 angiebird Replace NULL by nullptr in simple_encode.c/h 2020-02-06 angiebird Sync simple_encode.h 2020-02-06 angiebird Rename inverse_vpx_rational to invert_vpx_rational 2020-02-02 chengchen Consistency test for motion vector info 2020-02-02 chengchen Pass motion vector info to encode frame result 2020-02-03 angiebird Let SimpleEncode be able to output bitstream 2020-01-23 angiebird Add coded_frame to EncodeFrameResults 2020-01-27 chengchen Store frame motion vector info Created with: roll-dep src/third_party/libvpx/source/libvpx R=johannkoenig@google.com Change-Id: Ia40bb8ec844923e9a5452ca45a5042d72c303b9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063907Reviewed-by:
Johann Koenig <johannkoenig@google.com> Commit-Queue: Jerome Jiang <jianj@google.com> Cr-Commit-Position: refs/heads/master@{#742765}
-
