GitLab

clang-tools-extra contains several useful utilities for refactoring such
as clang-format and (eventually) clang-format-diff.py.

BUG=none

Review URL: https://codereview.chromium.org/12213081

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181992 0039d316-1c4b-4281-b951-d872f2087c98

BUG=175509
TEST=Manual tests on Lumpy


Review URL: https://chromiumcodereview.appspot.com/12217133

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181991 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/12207091

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181989 0039d316-1c4b-4281-b951-d872f2087c98

R=reveman,ccameron
BUG=174572


Review URL: https://chromiumcodereview.appspot.com/12208123

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181988 0039d316-1c4b-4281-b951-d872f2087c98

BUG=172404


Review URL: https://chromiumcodereview.appspot.com/12207099

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181987 0039d316-1c4b-4281-b951-d872f2087c98

BUG=175000
TEST=run_all_tests.py


Review URL: https://chromiumcodereview.appspot.com/12224116

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181985 0039d316-1c4b-4281-b951-d872f2087c98

Getting rid of some of the last BrowserList:: iterator methods :)!

Also making BrowserListImpl const-safe (otherwise GetLastActive(), required in this CL, couldn't be used on a const BrowserListImpl*).

BUG=129187

Review URL: https://codereview.chromium.org/12213091

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181984 0039d316-1c4b-4281-b951-d872f2087c98

through the ViewsDelegate::OnBeforeWidgetInit(). This way if the
delegate needs top_level (as we do for win-aura) its set correctly.

BUG=175115
TEST=covered by unit test now.
R=ben@chromium.org


Review URL: https://chromiumcodereview.appspot.com/12212136

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181983 0039d316-1c4b-4281-b951-d872f2087c98

The grey bar is added to the primary display to denote the launcher.
This doesn't make sense because now we provide a launcher for each
display, and we decided to just remove the launcher rather than
keeping it to every displays.

BUG=175569


Review URL: https://chromiumcodereview.appspot.com/12208121

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181982 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=Tested with x64 Linux build with chromeos=1.

Review URL: https://codereview.chromium.org/12217144

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181981 0039d316-1c4b-4281-b951-d872f2087c98

Looks like this is a bug in https://codereview.chromium.org/10910242.

BUG=175211
TEST=manual. see bug

Review URL: https://chromiumcodereview.appspot.com/12211121

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181980 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/12209080

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181979 0039d316-1c4b-4281-b951-d872f2087c98

BUG=164555
TEST=content_unittests
TBR=wiltzius
Review URL: https://codereview.chromium.org/12225142

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181977 0039d316-1c4b-4281-b951-d872f2087c98

Add makefile rules to install the built webkit string paks into
the system image.



Review URL: https://chromiumcodereview.appspot.com/12223093

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181976 0039d316-1c4b-4281-b951-d872f2087c98

This fixes the dialog-like confirm "bubble" class.
(make it a window-modal dialog delegate subclass)
Call new SpellingBubbleModel::SetPref(false) on 'No thanks'.
(clicking ok then cancel in two windows yields feature off)

See pics of the change at http://crbug.com/166075#c31

TODO(followup): Remove ConfirmBubble*? (only used by spelling).
TODO(followup): Fix insets after tweaking the new dialog style.
TODO(followup): Fix dialog 'extra view' placement.

BUG=166075
TEST=Spelling bubble (web textfield context menu -> "Spell-checker options" -> "Ask Google for suggestions") looks/works reasonable on Win/CrOS/Aura.
R=rlp@chromium.org,sky@chromium.org

Review URL: https://chromiumcodereview.appspot.com/12222003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181975 0039d316-1c4b-4281-b951-d872f2087c98

The check being removed here basically says "if you're offscreen, and have no time to visible, then you should go in the never bin."

The problem is that when a layer stops moving, then its offscreen tiles are put in never bin. That means that we lose all those tiles we put effort into painting. This increases the frequency at which one sees blurry tiles after the page goes stationary. 

R=ccameron,reveman
BUG=175276

Review URL: https://chromiumcodereview.appspot.com/12220115

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181974 0039d316-1c4b-4281-b951-d872f2087c98

Handle if search_provider == NULL when constructing aqs CGI parameter.

BUG=175428
TEST=AutocompleteProviderTest::GetDestinationURL

Review URL: https://chromiumcodereview.appspot.com/12218104

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181973 0039d316-1c4b-4281-b951-d872f2087c98

BUG=v8::2487


Review URL: https://chromiumcodereview.appspot.com/12210035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181970 0039d316-1c4b-4281-b951-d872f2087c98

R=estade@chromium.org
BUG=171567


Review URL: https://chromiumcodereview.appspot.com/12209101

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181969 0039d316-1c4b-4281-b951-d872f2087c98

This CL changes the spell check correction to replace the misspelled range
within a selection instead of replacing the whole selection. This change enables
spell check of words selected with surrounding whitespace or punctuation. Such
selection happens on a double-click of a word with a trailing underscore in
Windows, for example. This CL requires the change in https://webkit.org/b/108513.

BUG=167485,169659

Review URL: https://chromiumcodereview.appspot.com/12038037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181968 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jochen@chromium.org
BUG=170097


Review URL: https://chromiumcodereview.appspot.com/11348046

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181967 0039d316-1c4b-4281-b951-d872f2087c98

BUG=129050
TBR=sky

Review URL: https://codereview.chromium.org/12225139

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181966 0039d316-1c4b-4281-b951-d872f2087c98

Make zoom using ctrl+mouse wheel work in win aura. Windows non-aura had a hack that was a layering violation which sent a custom win32 message from RenderWidgetHostViewWin to WebContentsViewWin. Instead do this properly from RenderWidgetHostImpl to its delegate (WebContentsImpl), which works for both aura and non-aura windows builds.

BUG=175055
Review URL: https://codereview.chromium.org/12221144

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181965 0039d316-1c4b-4281-b951-d872f2087c98

BUG=174821

Review URL: https://codereview.chromium.org/12210057

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181964 0039d316-1c4b-4281-b951-d872f2087c98

> Distribute extra memory evenly among visible clients
> 
> After computing all clients' memory budgets, take any
> extra memory left over and distribute it amongst the
> visible clients (so that, if their memory requirments
> suddenly jump, they don't need to wait for a roundtrip
> to the GPU process to get extra memory).
> 
> Disallow keeping around backgrounded tabs' contents on
> Android, to keep the maximum for the main tab.
> 
> Explicitly limit the memory to use for prepainting by
> specifying NiceToHave on Mac to avoid performance problems.
> 
> BUG=175125
> 
> Review URL: https://codereview.chromium.org/12226082

TBR=ccameron@chromium.org
Review URL: https://codereview.chromium.org/12208134

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181962 0039d316-1c4b-4281-b951-d872f2087c98

Prevent translated key events (WM_CHAR) associated with key events that focus the WebContents from being sent to the renderer, as they are not intended to target the renderer.

Example:

When the focus is in the omnibox, and a new URL is typed and Enter is pressed, the Enter keypress should focus the WebContents but the WebContents should not send the Enter char event to the current page.

BUG=175634
TEST=open print preview, select "save as pdf" as the destination and then navigate in the url bar by typing a url then enter. The "choose file" dialog shouldn't come up.
Review URL: https://codereview.chromium.org/12221133

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181958 0039d316-1c4b-4281-b951-d872f2087c98

There are some cases where WebCore internally needs to "reposition" the origin
point about which CSS transforms are applied. For example, when a perspective
container becomes composited, the composited location/bounds may change
depending on the positioning of its children. The perspective-origin from the
original DOM tree should not change, but internally it does require a new
origin to be given to the compositor. It turns out that WebCore uses the anchor
point layer property to communicate these cases. So, the compositor needs to
apply the sublayer transform about the anchor point instead of about the layer
center.

BUG=157961


Review URL: https://chromiumcodereview.appspot.com/12224113

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181957 0039d316-1c4b-4281-b951-d872f2087c98

With this command line flag, this store a detailed dump of all tile data into the trace buffer, including tile quads in screenspace. This provides enough foundation for cc-frame-viewer to visualize what impl-side painting is doing.

NOTRY=True

Review URL: https://chromiumcodereview.appspot.com/12096112

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181956 0039d316-1c4b-4281-b951-d872f2087c98

Custom implementation of VectorPlatformDeviceEmf::drawBitmapRect, to shield it from changes in SkDevice::drawBitmapRect

Review URL: https://chromiumcodereview.appspot.com/12221116

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181955 0039d316-1c4b-4281-b951-d872f2087c98

BUG=170956

Review URL: https://codereview.chromium.org/12221145

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181954 0039d316-1c4b-4281-b951-d872f2087c98

CHROMIUM_async_pixel_transfers doesn't have a way to abort a pending
upload but deleting texture and query has the same effect.

BUG=173704
NOTRY=true

Review URL: https://codereview.chromium.org/12223050

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181952 0039d316-1c4b-4281-b951-d872f2087c98

BUG=175604
TEST=None

Review URL: https://codereview.chromium.org/12208118

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181951 0039d316-1c4b-4281-b951-d872f2087c98

After computing all clients' memory budgets, take any
extra memory left over and distribute it amongst the
visible clients (so that, if their memory requirments
suddenly jump, they don't need to wait for a roundtrip
to the GPU process to get extra memory).

Disallow keeping around backgrounded tabs' contents on
Android, to keep the maximum for the main tab.

Explicitly limit the memory to use for prepainting by
specifying NiceToHave on Mac to avoid performance problems.

BUG=175125

Review URL: https://codereview.chromium.org/12226082

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181950 0039d316-1c4b-4281-b951-d872f2087c98

Initialize ManagedUserService after ExtensionSystem to register as extension management policy provider.


BUG=169819


Review URL: https://chromiumcodereview.appspot.com/12225051

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181949 0039d316-1c4b-4281-b951-d872f2087c98

Patch by leozwang@chromium.org (https://codereview.chromium.org/12218036/).

This CL JUST enables audio capture on Android, further tunning and
making audio work better might take extra time, I think it's better to
first enable it. A few TODOs are added and minor changes are added into
CL too.

BUG=161417

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181948 0039d316-1c4b-4281-b951-d872f2087c98

Fix crash when closing a constrained window in win aura. The crash happens because the aura::Window for the constrained window is removing itself from its parent window, and its parent_ pointer is already NULL'd before the focus manager is retrieved which fails because aura::client::GetFocusClient can't get to a root window. See the bug for the callstack.

BUG=174727
Review URL: https://codereview.chromium.org/12226102

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181947 0039d316-1c4b-4281-b951-d872f2087c98

This eliminates possible sources of non-determinism in the integration tests.

BUG= none

Review URL: https://codereview.chromium.org/12213117

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181946 0039d316-1c4b-4281-b951-d872f2087c98

Original CL (reverted for leaks): https://codereview.chromium.org/12225042/
http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20OS%20Heapcheck/builds/14990
http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20OS%20%28valgrind%29%283%29/builds/22339
Leaks are fixed here by having the tabbed pane own its tab content Views.
(all Valgrind and Heapcheck leaks observed locally are fixed by this change)

TBR=sky@chromium.org

The original CL description is copied below:
========================================
Remove NativeTabbedPane[Win|Wrapper]; promote Views impl.

Remove NativeTabbedPaneWin and NativeTabbedPaneWrapper.
( its last use was eliminated in http://crrev.com/180924 )
Write a TabbedPane based on NativeTabbedPaneViews.
Update unit tests; cleanup; etc.

BUG=138059
TEST=No observable tabbed pane appearance/behavior changes (see the WebsiteSettingsPopupView and CollectedCookiesView); unit tests.
R=markusheintz@chromium.org,sky@chromium.org,ben@chromium.org

Review URL: https://chromiumcodereview.appspot.com/12211122

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181945 0039d316-1c4b-4281-b951-d872f2087c98

> Turn on threaded compositing in OSX for continuous builds.
>
> BUG=172015
> TBR=vangelis
>
> Review URL: https://codereview.chromium.org/12223055

This is causing the mac_rel trybot to become flakey (although none
of the waterfall bots are being flakey).

BUG=175686
TBR=vangelis

Review URL: https://codereview.chromium.org/12212128

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181944 0039d316-1c4b-4281-b951-d872f2087c98

Rather than requiring manual intervention, we can use Get/SetProtectedFileContents.

TEST=tools/telemetry/run_tests --browser=android-chrome TabConsoleTest
BUG=175127


Review URL: https://chromiumcodereview.appspot.com/12218091

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181943 0039d316-1c4b-4281-b951-d872f2087c98