- 09 Apr, 2019 40 commits
-
-
Miyoung Shin authored
This is a part of moving manifest implementation to blink. This CL moves content::ManifestFetcher to blink and introduces WebManifestFetcher in blink/public/web to expose the fetcher to content::ManifestManager. Bug: 704441 Change-Id: Ia4114390f124973542aca0151d06baec82fdaec1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548972Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#649147}
-
Jimmy Gong authored
- Add new Object property, pendingPrinter_, to cups_edit_printer_dialog. This object serves as a copy of activePrinter and is used as the main property for changes in edit printers dialog. - Previously, activePrinter was being directly edited in the edit printer dialog. This resulted in activePrinter's property values to change even if the user clicks on the cancel button. The new pendingPrinter_ object fixes this by making a copy of activePrinter and only modifying activePrinter when the user clicks on the save button. - Edit BrowserTests to reflect this change. Bug: 893986 Test: End to End, BrowserTest/gtest_filter=CrSettingsPrinting* Change-Id: Ia015fcda1e53dc8848556365d49c215492418d40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1490378 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#649146}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/0086a8acd879..fc15ae5571b3 git log 0086a8acd879..fc15ae5571b3 --date=short --no-merges --format='%ad %ae %s' 2019-04-09 syoussefi@chromium.org Vulkan: parallelize internal shader compilation 2019-04-09 jmadill@chromium.org Formalize preference for handling generated code. Created with: gclient setdep -r src/third_party/angle@fc15ae5571b3 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: I98bce45cf3776e8759d3d13d1b5ff7d18197bb72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1558759Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649145}
-
Elly Fong-Jones authored
This also removes a now-unneeded include in about_flags.cc. TBR=avi@chromium.org Bug: None Change-Id: I9c553e4604ab2d101accb35916ff639fce53dcce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559872 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#649144}
-
Emily Stark authored
This class is not ref-counted for any particular reason and the shared ownership is confusing/unnecessary. This CL removes its refcounting; it is now passed around mostly as a const ref, and copied where necessary, as described in detail below. The AuthChallengeInfo for a request is created and populated by HttpAuthController, and ownership is then handed off to HttpResponseInfo. HttpResponseInfo stores the AuthChallengeInfo inside a base::Optional rather than a unique_ptr so that HttpResponseInfo remains copyable (and rather than as a member field directly because consumers need to tell when the auth_challenge has been set or not). The AuthChallengeInfo is then passed to delegates as a const ref so it is clear that delegates don't own it and can't modify it. It is copied on the UI thread when we get to the point of creating the LoginDelegate/ LoginHandler. Bug: 949197 Change-Id: I8b91fd80d20b4771c38cf4785ea0ca33ddb25ab5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1550631Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#649143}
-
Adam Langley authored
When changing a PIN, the error message under the current PIN can get quite long because it may highlight that only a single attempt remains. When this was shown, the error message was wrapped to the length of the cr-input, and took two or three lines. This change sets only the width of the input itself, allowing the containing cr-input, and any error messages, to be longer. With this change, the error message wraps only when it reaches the with of the whole dialog, and our error messages aren't that long. Bug: 870892 Change-Id: I69fc9b96454cf88f3bd0fd01333cb8c170772014 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548239 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Auto-Submit: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#649142}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/865cad89b916..2d4c66d2b865 git log 865cad89b916..2d4c66d2b865 --date=short --no-merges --format='%ad %ae %s' 2019-04-09 ynovikov@google.com Revert "Rename texture.createTextureView to createView to match WebGPU" 2019-04-09 enga@chromium.org Update ComputePipelineDescriptor to use PipelineStageDescriptor 2019-04-09 enga@chromium.org Rename texture.createTextureView to createView to match WebGPU 2019-04-09 enga@chromium.org Remove sampler border color from Dawn to match WebGPU Created with: gclient setdep -r src/third_party/dawn@2d4c66d2b865 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:877147,chromium:877147,chromium:877147,chromium:877147 TBR=cwallez@chromium.org Change-Id: I4151ff5dbab96b4d276181be0b327c9767adecb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559200Reviewed-by:
-
Olivier Robin authored
Nested scoped feature must be used in ABBA pattern. Using ABAB pattern leads to features corruption and make following tests to fail. Follow-up of https://chromium-review.googlesource.com/c/chromium/src/+/1547984 Bug: 831123 Change-Id: Ic5538fca1e456947c126eaf8897e4ff2d5777d21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559085Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#649140}
-
Jan Krcal authored
This CL replaces if statements checking that count of typed visits is _non-negative_ by DCHECKs. Negative typed count should never occur and thus this CL simplifies the code. Bug: 907476 Change-Id: I13494454ff41f3a7f6fc202e63458a7142368d84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559318 Auto-Submit: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#649139}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/b04e2aaec8cc..3ef631ecd110 git log b04e2aaec8cc..3ef631ecd110 --date=short --no-merges --format='%ad %ae %s' 2019-04-09 evanhernandez@chromium.org Revert "scripts: Link build_api to wrapper.py." 2019-04-09 evanhernandez@chromium.org api: Regenerate proto. 2019-04-09 evanhernandez@chromium.org artifacts: Add BundleImageZip endpoint. Created with: gclient setdep -r src/third_party/chromite@3ef631ecd110 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: I30d6dc0b6ea2212937b7fbfe4825dbd087fcbb28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559201Reviewed-by:
-
Collin Baker authored
This reverts commit 5a8aa78d. Reason for revert: Causing test failures due to cast from IdentityManagerWrapper to TestIdentityManagerWrapper. Logs: - https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8916648927362689184/+/steps/browser_tests/0/logs/Deterministic_failure:_GetAuthTokenFunctionTest.InteractiveApprovalSuccess__status_CRASH_/0 - https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8916648927362689184/+/steps/browser_tests/0/logs/Deterministic_failure:_ChromePasswordProtectionServiceBrowserTest.ChromeEnterprisePasswordAlertMode__status_CRASH_/0 Original change's description: > Update IdentityManager to own ProfileOAuth2TokenService. > > With this change, ProfileOAuth2TokenService is now constructed only when > creating an IdentityManager, eliminating the need for > ProfileOAuth2TokenService factories. > > > Change-Id: Ie52e179058ef87193bbf6cb0dda45208392c9572 > Bug: 939372 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529018 > Reviewed-by: David Roger <droger@chromium.org> > Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> > Reviewed-by: Colin Blundell <blundell@chromium.org> > Commit-Queue: Lowell Manners <lowell@chromium.org> > Cr-Commit-Position: refs/heads/master@{#649073} TBR=droger@chromium.org,blundell@chromium.org,sdefresne@chromium.org,lowell@chromium.org Change-Id: Ie3c8a6f0188d27d2b05809f581c1e560e248df8f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 939372 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559389Reviewed-by:
Collin Baker <collinbaker@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#649137}
-
Shivani Sharma authored
Subframes can also abuse the back button by adding multiple history entries without user's interaction. This Cl prevents the back button from landing on those entries. If the user interacted with an ancestor frame but not with a cross origin subframe that is creating an entry, this CL will mark the last committed entry as skippable. If the user interacted with the subframe or a child of this subframe or same origin ancestor frame, the last committed entry will not be marked as skippable. This is based on how User Activation V2 API's frame propagation is implemented. In case the user interacts with this subframe or an ancestor/child frame after the entry is marked as skippable, the skippable flag will be reset as per an earlier CL. NavigationControllerHistoryInterventionBrowserTest. NoUserActivationSetSkipOnBackForwardSubframe Test: content_browsertests --gtest_filter= Bug: 907167 Change-Id: Icd24dd4fe5cb3c4863dc6328128696b2a4401d23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541665Reviewed-by:
Shivani Sharma <shivanisha@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Shivani Sharma <shivanisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#649136}
-
Miguel Casas authored
This CL adds a TRACE_EVENT_ASYNC_... for VideoFrameSubmitter's frame round trip (e.g. from the CompositorFrame delivery to the swap buffers event deep in the DRM Thread if on ChromeOS). E.g. for a webm playback from file on my gLinux box it looks like [1]. On a real time loopback webrtc conversation on my nocturne chromebook it looks much more jittery. [1] https://i.imgur.com/uyJk7cz.png (https://imgur.com/a/nbaBc7U) Bug: 950183 Change-Id: Ia95fb0e9b60128343eecf699ba0551b920a497ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554952Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#649135}
-
Matthew Jones authored
This patch has ChromeActivity consider whether the bottom sheet is in the process of closing before determining which container to place a snackbar in. This avoids inadvertently blocking snackbars that are shown when the sheet is about closed. Bug: 950739 Change-Id: Ib7e0b3d2bbd58580dad84c2d146b13b98dcb13ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559154Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#649134}
-
Peng Huang authored
Bug: None Change-Id: Ia1b7c8a1039d374d56d1235d66eda2b5950a2e7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559447 Auto-Submit: Peng Huang <penghuang@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#649133}
-
Austin Eng authored
Bug: 877147 Change-Id: I6dccf52a0d554f452a524fdc085fc06699f07056 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554244 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#649132}
-
Kevin Bailey authored
We weren't notifying the keyword hint view's elements when the theme changed. This CL remedies that, by populating OnThemeChanged() to update the colors of all the elements. Bug: 935265 Change-Id: I6975c13a621e77af255b7c9a4485f0ee5279b055 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1558490 Commit-Queue: Kevin Bailey <krb@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#649131}
-
Austin Eng authored
Bug: 877147 Change-Id: Ib797f942c597f949f4c503b4887ba9d717afb899 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546056 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by:
-
Elly Fong-Jones authored
This change makes DesktopMediaPickerViews use a views TableView for the list of tabs to cast, which brings the behavior of this control (especially wrt accessibility) significantly closer to the platform-native behavior and the behavior of other Views UI. Specifically this change: 1) Introduce a new View class named DesktopMediaTabList which uses a TableView to display a DesktopMediaList; 2) Adds a method to DesktopMediaListController to construct a DesktopMediaTabList; 3) Adds two interfaces to DesktopMediaListController: SourceListListener, which listens for changes to a DesktopMediaList, and ListView, which exposes the selection state of a visual source list; 4) Has DesktopMediaListView (the "old" list view class) implement both these interfaces; 5) Has DesktopMediaTabList implement both these interfaces; 6) Adds support to DesktopMediaPickerViewsTestApi for handling either DesktopMediaListView or DesktopMediaTabList; 7) Has DesktopMediaPickerViews use a DesktopMediaTabList (via DesktopMediaListController) when appropriate; 8) Reduces the minimum size of TabDesktopMediaList's thumbnail from 20x20 to 16x16, since TableView requires a 16x16 image; To test this change: From unit_tests run DesktopMediaPickerViewsTest.* From browser_tests run DesktopMediaPickerViewsBrowserTest.* and WebRtcDesktopCaptureBrowserTest.* Future work: Replacing DesktopMediaListView with another class, specialized for displaying a grid of SourceViews but using standard Views layout primitives, and excising the custom ::Layout and ::Paint methods. Bug: 726005 Change-Id: Iaa82711b2ed89ab3f47d6522219252dd290135be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1555042 Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#649129}
-
Mitsuru Oshima authored
Toggle maximize should use the target bounds so that it can restore the correct orginal bounds. (although this is probably less important because it's near impossible for a user to trigger this while animating) WindowResizer shoud use just bounds(), because that's where a use captured the window and started dragging. Bug: None Change-Id: I5e25805de92cc2afc616fda6068ec6ac50ecf700 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559350Reviewed-by:
Eliot Courtney <edcourtney@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#649128}
-
Charlene Yan authored
remain draggable)." This change makes the title area of a dialog act as the client. Also removed code so system menu does not appear on dialogs. This makes more sense since the system dialog has properties such as move (which is now illegal, also it doesn't work), and resize (illegal), and close with hints of using Alt+F4 (Alt+F4 does not close dialogs). This reverts commit 52b60b4e. Reason for revert: The earlier CL was reverted due to flaky dialog tests on Mac when the modal type was set to MODAL_TYPE_WINDOW rather than WINDOW_TYPE_NONE. Fixed by adding check to disable modal closure animation which makes tests flakily fail during TearDown. Change-Id: I208d9d7fa1fb7ab9df7b3b457a89111862244029 Bug: 949911, 930782 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554054Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#649127}
-
Brian Salomon authored
Bug: skia:8942 Change-Id: I2eb7ea2391d7e2c296fc26a7a5a0982362725ccc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554049 Auto-Submit: Brian Salomon <bsalomon@google.com> Reviewed-by:
Robert Phillips <robertphillips@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com> Cr-Commit-Position: refs/heads/master@{#649126}
-
Sylvain Defresne authored
This reverts commit 151e36ec. Reason for revert: see discussion in cwv_sync_controller.mm Original change's description: > Preparation to convert GetPrimaryAccount to return CoreAccountInfo > > Change client code to work as if IdentityManager::GetPrimaryAccount > where returning a CoreAccountInfo instead of an AccountInfo. Method > will be updated in a followup CL. > > Also provide an implementation of ReloadAccountsFromSystem for the > FakeOAuth2TokenServiceDelegate as it is required to have a correct > fake of the delegate on iOS. The real method synchronize the list > of accounts with the system and mark one as primary account, thus > the fake implementation insert fake refresh token for the primary > account (to behave as if this account was the only account known > by the system). > > This CL was uploaded by git cl split. > > Bug: 926204 > Change-Id: Ida52d6c768175b908ccc474795a0824edca98855 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1499475 > Reviewed-by: David Roger <droger@chromium.org> > Reviewed-by: Mikel Astiz <mastiz@chromium.org> > Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> > Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> > Cr-Commit-Position: refs/heads/master@{#647186} TBR=droger@chromium.org,sdefresne@chromium.org,mastiz@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 926204 Change-Id: I9aa77dc6f690fd7eac0bc5241d50d260d93dbadc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559081Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#649125}
-
Ivan Sandrk authored
This reverts commit 173fb79b. Reason for revert: Breaks Chrome OS Kiosk - crbug.com/950437 Original change's description: > Remove unnecessary window check change in InteriorResizeHandleTargeter > > ShouldUseExtendedBounds returns true only for children, which dones't > have its own window state, so this shouldn't be necessary. > > Bug: 912191 > Test: no functional change. all tests should pass. > Change-Id: Ia3ea35a59d860ad62a0517daa66f6f1a5b26c070 > Reviewed-on: https://chromium-review.googlesource.com/c/1385122 > Commit-Queue: Mitsuru Oshima <oshima@chromium.org> > Reviewed-by: Evan Stade <estade@chromium.org> > Cr-Commit-Position: refs/heads/master@{#618260} TBR=oshima@chromium.org,estade@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 912191, 950437 Change-Id: Icaa8bae2ca7fb27e30528b13e4b5948da9ef145d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559323Reviewed-by:
Ivan Šandrk <isandrk@chromium.org> Commit-Queue: Ivan Šandrk <isandrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#649124}
-
Mei Liang authored
In addition to the GTS crash with TabModalDialog, this CL also polishes TabModalDialog's scrim to not cover the bottom controls (e.g. Duet and TabGroup strip) if it is visible. This CL removes some dead code in TabModalDialog that are from ChromeHome as well. Bug: 941907 Change-Id: I1f6e45153b290a666457fcff8b127b64b750fdf8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553710 Commit-Queue: Mei Liang <meiliang@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#649123}
-
Dan Harrington authored
This CL introduces the concept of PageCriteria which describes some selection criteria for an offline page. This criteria is used to query for pages in GetPagesTask, but could be used for other tasks like deleting pages later. This criteria can be evaluate in C++, and additionally used to create sql for filtering a SQLite query. This CL also uses the new method to fix a bug in feed where we would sometimes attempt to open a tab-bound page, and end up failing. Because GetPagesWithCriteria is very general purpose, it replaced the other page query methods. In terms of binary size and efficiency, I think this is a good trade-off. We're replacing several smaller queries with a single larger one, shaving about 4KB off the binary size. Depending on the query, it may be faster or slower -- querying for multiple client_id or namespaces is improved. Bug: 949162 Change-Id: I58eb97014d8403ed248c1e38635cc0665ca5c18e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540063 Commit-Queue: Dan H <harringtond@google.com> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#649122}
-
Marc Treib authored
Bug: 842096 Change-Id: I43334b71da4ff0542f3f7c028f05dec860a2b0c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559149 Auto-Submit: Marc Treib <treib@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#649121}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/eba396cc66d3..42761d27612b git log eba396cc66d3..42761d27612b --date=short --no-merges --format='%ad %ae %s' 2019-04-09 sugoi@google.com vkGetImageMemoryRequirements2 dedicated allocation Created with: gclient setdep -r src/third_party/swiftshader@42761d27612b The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@chromium.org Change-Id: If25ced28e83f04530e7f6be36d03da66bef5ded8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559358Reviewed-by:
-
Jan Krcal authored
This CL gets rid of ProfileSyncService usage both in UserEventService and in its factory. This usage was for checking whether user events should get synced up. Part of these checks were obsolete (by having USER_CONSENT a separate data type now) as user consents are always enabled together with history sync. Part of these checks were moved to a new controller subclass for USER_EVENTS. This controller notably checks whether custom passphrase encryption is not enabled. Bug: 850428 Change-Id: Ie8be4e37c5c4a51d9c3c1f17c74cd9fb7449a52c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1349257Reviewed-by:
Markus Heintz <markusheintz@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
-
Guillaume Jenkins authored
- Add Armenian (hy) to the list of spellcheck languages. - Roll src/third_party/hunspell_dictionaries/ f7ce90e84..83f465973 (1 commit) https://chromium.googlesource.com/chromium/deps/hunspell_dictionaries.git/+log/f7ce90e84f5a..83f4659730b4 $ git log f7ce90e84..83f465973 --date=short --no-merges --format='%ad %ae %s' 2019-03-22 gujen Add Armenian dictionary (reformed orthography) Created with: roll-dep src/third_party/hunspell_dictionaries Note that the end to end scenario still requires the dictionary to be uploaded to the backend, and URL redirects to be created. Bug: 772200 Change-Id: I7f7ec8dab0e6ca987f5707d5c4eea1d8036df440 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554055Reviewed-by:Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
manuk hovanesian <manukh@chromium.org> Commit-Queue: Guillaume Jenkins <gujen@google.com> Cr-Commit-Position: refs/heads/master@{#649118}
-
Joshua Pawlicki authored
This reverts commit 46935a5d. Reason for revert: Flakily exposes unsatisfied include in chrome/updater. Original change's description: > Refactor update_client deps. > > This reduces the build artifacts necessary to build chrome/updater from > 5k to 1.7k. > > Change-Id: I7332c69a5f564a08786d7e21e5891448feca8f11 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557988 > Commit-Queue: Joshua Pawlicki <waffles@chromium.org> > Reviewed-by: Sorin Jianu <sorin@chromium.org> > Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Auto-Submit: Joshua Pawlicki <waffles@chromium.org> > Cr-Commit-Position: refs/heads/master@{#649098} TBR=thakis@chromium.org,rdevlin.cronin@chromium.org,sdefresne@chromium.org,sorin@chromium.org,waffles@chromium.org Change-Id: I87ae2b63eb8ae604dc038b4f14e9b9ada5459cc6 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559871Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#649117}
-
Denis Kuznetsov authored
1) Moved configuring fake attestation flow to PolicyTestServerMixin 2) Reorganized configuration-based oobe tests to 3 small classes to include only necessary mixins (to speed up tests). Bug: 950471 Change-Id: I7df6b3d8a3e4e84ff6e5663812371a84fd5ca12c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1558233 Commit-Queue: Denis Kuznetsov <antrim@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#649116}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/88192dcff2d1..6cdf3dcae851 Created with: gclient setdep -r src-internal@6cdf3dcae851 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=huangs@chromium.org,battre@chromium.org,collinbaker@chromium.org,tasak@chromium.org Change-Id: I0ff51b892667b536674f2cd971c85bc20ec7b6d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559575Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649115}
-
Raul Tambre authored
Most of the changes are for converting relative imports to be absolute, due to new restrictions on relative imports in Python 3. All callers where necessary were updated to work with the use of absolute imports. The scripts still works with Python 2. There are no intended behaviour changes. Bug: 941669 Change-Id: I39a8642f6cc02b9ea79e3bb7c6da4002444f2dfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1536068Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Reviewed-by:
David Turner <digit@chromium.org> Commit-Queue: Raul Tambre <raul@tambre.ee> Cr-Commit-Position: refs/heads/master@{#649114}
-
Nicolas Ouellet-Payeur authored
This CL imports the code for the Internet Explorer Browser Helper Object (BHO) used by Legacy Browser Support. The new rule is purposefully excluded from mini_installer.exe for now. The code is imported from //googleclient/chrome/chrome_browserswitcher The following changes were made to the original codebase: - Add BUILD.gn rules to build the BHO DLL - Remove unneeded code (e.g. XML parsing, InvokeAlternativeBrowser...) - Flatten ie_bho/ and core/ folders - Replace '#pragma once' with '#ifndef' guards, run 'git cl format' - Update copyright comment in each file - Add pre-generated header files from IDL Bug: 950039 Change-Id: Ic4d05b360f6e93ff28afc2e37722e26325058fd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1551704Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#649113}
-
Marina Ciocea authored
Previously, when creating a blink::RTCIceTransport, the corresponding webrtc::IceTransportInterface object was created by the IceTransportAdapterImpl. However, in DTLS transport implementation, the webrtc object is preexisting. Pass the preexisting webrtc object when creating the blink::RTCIceTransport object in this case. This change is a reland of https://crrev.com/c/1538181. The crash is fixed by checking in IceTransportAdapterImpl constructor that the webrtc ice transport channel hasn't been cleared on the webrtc networking thread while constructing the blink transport objects, hopping to main thread and back to webrtc networking thread. The ice transport channel could be cleared if the peer connection gets closed in the meantime. There is no need to check on callbacks as well that the transport hasn't been cleared because the callbacks are called synchronously on the webrtc networking thread. Bug: 907849 Change-Id: I64c7db30cfcc34c7fa03689627cd7d30fef063e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559145Reviewed-by:
Henrik Boström <hbos@chromium.org> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Cr-Commit-Position: refs/heads/master@{#649112}
-
Dan Harrington authored
includes copyright text and header guards TBR=cmp@chromium.org Change-Id: I59b788e124c377399f19397ceaa06313b01de0ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554125 Commit-Queue: Jianpeng Chao <chaopeng@chromium.org> Reviewed-by:
Jianpeng Chao <chaopeng@chromium.org> Cr-Commit-Position: refs/heads/master@{#649111}
-
Pavol Marko authored
Assign Enterprise Component to directories owned by the MUC Enterprise team. Also add myself to OWNERS for a few directories. Bug: none Test: none Change-Id: I58b3f987109c6a5b89d4c03b7dd372618c3b8142 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1543770Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Reviewed-by:
Bartosz Fabianowski <bartfab@chromium.org> Commit-Queue: Denis Kuznetsov <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#649110}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/3674ce2d885b..b04e2aaec8cc git log 3674ce2d885b..b04e2aaec8cc --date=short --no-merges --format='%ad %ae %s' 2019-04-09 evanhernandez@chromium.org osutils: CopyDirContents can copy to nonempty dir. Created with: gclient setdep -r src/third_party/chromite@b04e2aaec8cc The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: I8ec18c7d250e67d28a75991aef2633bfb132cfd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559576Reviewed-by:
-
Dominic Battre authored
This test currently has the second highest flakiness score as per https://analysis.chromium.org/p/chromium/flake-portal/flakes. Labeling the test as crashing. The bug has more details. TBR=adithyas@chromium.org Bug: 946335 Change-Id: I03cb847c29f7f783c079480b6f2f77816958cf52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559079Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#649108}
-
