- 18 Nov, 2020 40 commits
-
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/3644d1fc..de5334a0 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I98af6328e0a02d70076ee9f70f62827db078f3fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546902Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#828713}
-
David Lei authored
Without this, the unittests may fail if you inserted the entries arbitrarily. Change-Id: I805029532f36358e623eda7eae6a541c3bbc62a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546343 Auto-Submit: David Lei <dlei@google.com> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#828712}
-
Alice Wang authored
This CL disable the sync service when user signs in but no data is synced. Bug: 1148219 Change-Id: Ib8b8b96843b85db048d19122e5c6629212d460b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543047 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#828711}
-
David Bienvenu authored
Bug: 1007788 Change-Id: Ia46955803364a314fa1a7d5810ac8fd1269f3e59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533394Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#828710}
-
Maksim Ivanov authored
Migrate the chrome.certificateProvider API's apitests to use net::EmbeddedTestServer instead of net::SpawnedTestServer. The latter is outdated and doesn't support TLS 1.3. This commit is a preparation for introducing the TLS 1.3 / RSA-PSS support in chrome.certificateProvider. Bug: 792204 Change-Id: I207ccc1d898ac247b943382f5525ec12fb7cf8db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546004 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Fabian Sommer <fabiansommer@chromium.org> Cr-Commit-Position: refs/heads/master@{#828709}
-
Mark Cogan authored
To start to remove model-layer functionality from the BVC, this CL factors four web navigation methods out of the BrowserCommands protocol and moves them into a new Browser agent. WebNavigationBrowserAgent acts as a wrapper around a Browser, providing common navigation options (back, forward, stop, reload) on the active web state (if any) in the Browser's WebStateList, as well as similarly wrapping the CanGoBack and CanGoForward methods. BVC no longer provides these methods as part of BrowserCommands or KeyCommandsPlumbing. Call sites for the old commands instead fetch the new BrowserAgent in the usual way and call the methods on it. The KeyCommandsProvider has theagent injected into it. Only one part of these methods was heavily coupled to the BVC's innards: the special casing for reloading a page showing an NTP. Since the BVC owns a map of NTP coordinators, it needs to handle the NTP reloads. Factoring the NTP coordinator ownership out of the BVC will be the work of several CLs and is well beyond the scope for including in this one. As an interim solution pending a fix for this implementation, this CL adds a "web navigation NTP delegate" that abstracts out the functions needed for reloading the NTP. The BVC publicly conforms to this delegate while it is in use. Change-Id: I9c21549f6d8af5c7970dfc50baabb2c7fc4d93c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537795 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#828708}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/49ce691f0bca..d14436f82285 2020-11-18 aerotwist@chromium.org [unit test] Add flag for HTML report generation 2020-11-18 janscheffler@chromium.org [e2etest] Move hosted mode server to https 2020-11-18 tvanderlippe@chromium.org Use TypeScript-authored files in elements/ 2020-11-18 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-11-18 tvanderlippe@chromium.org Typecheck profiler/HeapSnapshotView.js with TypeScript 2020-11-18 szuend@chromium.org TypeScript-ify ui/UIUtils.js part 3 2020-11-18 szuend@chromium.org TypeScript-ify ui/UIUtils.js part 2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I6b9cac177113f037451b610d984c9c7ee69c6678 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546864Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#828707}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1605679120-9f3476b66a4fad3e32e51dc995f45ad61750f20a.profdata to chrome-linux-master-1605700503-b63c9b13eb8ce76349ecd0eadd611ab4ead01971.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I38b0a59b645853df89969c7449f7a505b0ba784d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546868Reviewed-by:
-
Fredrik Söderqvist authored
ApplyStyleCommand, ComputedStyleCSSValueMapping, StyleBuilderFunctions, CSSToStyleMap and StyleResolverState no longer appear to need these privileges. Update comments for FilterOperationResolver and StyleResolver. Change-Id: I1396f1bb79df6f8a36ab3f7c3f414c4a709cee07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546013 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#828705}
-
Rohit Agarwal authored
Incognito CCT is restricted to be used only by 1P apps. This makes the testing the feature on non-1P apps impossible. This CL adds kCCTIncognitoAvailableToThirdParty feature flag that would allow opening Incognito CCT from a 3P context and would be removed by M91. The flag is set to disabled by default and enabling this flag has no effect. Bug: 1150360 Change-Id: I164913e15e407262f976bd564d752fd4b61de393 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544895Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
-
Illia Klimov authored
This CL prevents Notification permission revocation for origins with abusive content or abusive prompts if warning is enabled. Bug: 1150379 Change-Id: Ifbb0732758c4f8e45c1ffca3fe2e79231bbc991e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545504Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Commit-Queue: Illia Klimov <elklm@google.com> Cr-Commit-Position: refs/heads/master@{#828703}
-
Sylvain Defresne authored
Passing pointer to C++ objects to blocks is dangerous as it can lead to use after free. Change BookmarkHomeViewController implementation to instead pass GURL or node ids (recovering the node by iterating over the bookmarks). This causes edit/move/remove operation to do a linear search of the BookmarkNode* in the BookmarkModel which can cause those operations to become slower if the user has a large number of bookmarks. If it is a problem, then BookmarkHomeViewController should probably use a proxy object instead of directly referencing the BookmarkNode* with the proxy listening for node deletion. Bug: 1113618 Change-Id: I15cb714f15950194ed7a0cf821a3ff36cb52417b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544705 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Sebastien Lalancette <seblalancette@chromium.org> Cr-Commit-Position: refs/heads/master@{#828702}
-
Nohemi Fernandez authored
The current CHROME_CONNECTED cookie tests in AccountConsistencyService use the update time to approximate whether a cookie has been set. This patch switches the test to use a fake cookie manager to instead simulate interactions with the cookie store. Because the |last_cookie_update_map| is not updated by the external source, we no longer rely on it as the source of truth for number of cookies in the cookie store. We can, however, use it to understand the last time the service updated a cookie for a given domain. Bug: 1148814 Change-Id: Iebcd137272ab77a14fa25971f5786d00f0ad34c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2540466 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#828701}
-
Fredrik Söderqvist authored
Everything uses ConvertStyleColor() now, so drop this helper since it is dead. This also allows removing the friend declaration from ComputedStyle. Change-Id: I2a516d74d6e1cf52877fc007db84a34117737a40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545627 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Auto-Submit: Fredrik Söderquist <fs@opera.com> Reviewed-by:
-
Julie Jeongeun Kim authored
This CL removes crash key logging added to debug DCHECK error at WebRequestPermissions::HideRequest(). Bug: 1145496 Change-Id: I73728e5e85907b52bc63c7c267934300a4b2f8cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546386Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#828699}
-
Dave Tapuska authored
WebViewFrameWidget overode SetPageScaleStateAndLimits to force notification for remote frames. This can be pushed into the base implementation. BUG=1097816 Change-Id: I93247b9e2125a63f9b7579cfc60ab0960fa27fe4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2540579 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#828698}
-
Maksim Ivanov authored
Make sure that the chrome.certificateProvider API rejects certificate descriptions that contain empty lists of algorithms/hashes. Such descriptions have always been documented as invalid, but this commit makes sure they're treated as such. Besides making the API's behavior more consistent, this also makes sure that the apitests will work correctly after migrating to a different HTTPS test server, since an empty algorithm is treated as "any algorithm is supported" by some of them, which would make the tests fail due to hitting unexpected algorithms. Bug: 792204 Change-Id: Ia14a37841f7ce0e5f56fa40b8ccbe8a197926bd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545385 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Fabian Sommer <fabiansommer@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f1f7c370eb0d..dda9c164cb3b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I01362a67fbe4c7738e68397ed8b9a4c884e3d839 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546901Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a1112b326a79..2efafe688dd1 2020-11-18 kjlubick@google.com Fix debugger auto-deploy If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: lovisolo@google.com Change-Id: Icb75aa6c966ca076b32a30817aa5373ddc44c774 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546861Reviewed-by:
-
Gauthier Ambard authored
The histogram is still used. Fixed: 1149534 Change-Id: I4da9757d4751ddc09ee798e1ce2439b461a2b9ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542985 Auto-Submit: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#828694}
-
Luciano Pacheco authored
Add a new HTML file to load the Audio Player as JS modules and use this new HTML based on the feature flag "AudioPlayerJsModules". Add all missing dependencies to preprocess_grit() to be able to generate the JS bundle using optmize_webui(). Note that <repeat-button> and <control-panel> import <files-toggle-button> and <files-icon-button> using a "chrome-extension://" which causes the imported files and its dependencies to not be included in the bundle. This means these resources are loaded at runtime and have to be individually added to: * generate_grd() to be available in a PAK file. * File Manager's manifest.json "web_accessible_resources", otherwise the browser blocks access to these resources from Audio Player to File Manager. Bug: 1133186, 1149811 Change-Id: Ib8c76f593fe38b3b223dc95a8bf6c1865aea13ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543536Reviewed-by:
Jeremie Boulic <jboulic@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#828693}
-
James Vecore authored
Fixed: 1150301 Change-Id: Iffe9817a796d8c34f34f811230428b0ef0d06993 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545366Reviewed-by:
Josh Nohle <nohle@chromium.org> Commit-Queue: Josh Nohle <nohle@chromium.org> Auto-Submit: James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#828692}
-
Side Yilmaz authored
This CL gives ability to Incognito CCT to show title on toolbar. For screenshot: https://drive.google.com/file/d/1WQFhK3yhVsF-OazSSrUh9d8mfpNb1ZeK Bug: 1104180 Change-Id: I317c79c807fead5f024d197d09a190cd79841e55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545625Reviewed-by:
Rohit Agarwal <roagarwal@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Cr-Commit-Position: refs/heads/master@{#828691}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/99c5551368ff..49ce691f0bca 2020-11-18 szuend@chromium.org [ts] TypeScript-ify highlightRanges method in UIUtils.js 2020-11-18 aerotwist@chromium.org [unit test] Adds missing entrypoints 2020-11-18 jacktfranklin@chromium.org Make Linkifier actions take LinkInfo objects 2020-11-18 kimanh@chromium.org [LMI] Add LinearMemoryInspectorPane test 2020-11-18 bmeurer@chromium.org [sdk][bindings] Introduce DebuggerModel._computeAutoStepRangesCallback. 2020-11-18 kimanh@chromium.org [LMI] Remove unintuitive Boolean field and fix faulty event name If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1018234,chromium:1083146,chromium:1110202,chromium:1136814,chromium:1137302,chromium:1148296,chromium:1149403,chromium:1150029 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I01c964f0528dc62e14d7c972bf325fa5cd9380a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545753Reviewed-by:
-
Guido Urdaneta authored
This CL prevents the creation of a TabSharing UI for tabs that are destroyed before the UI is even started. Bug: 1138683 Change-Id: I4849b2b78e6e3a5efebe590d0d0e532e231285fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545164Reviewed-by:
Marina Ciocea <marinaciocea@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#828689}
-
Jasmine Chen authored
We deprecate the old RegisterCameraHalClient method, renaming it to RegisterCameraHalClientLegacy and add a new RegisterCameraHalClient that takes in a result callback that would indicate whether we've successfully registered CameraHalClient. BUG=b:170075468 TEST= \ 1. Build and deploy simplechrome 2. Verify pi-arc (eve) could still use the old method to register. 3. Apply ag/13017293 and ag/13026196 and verify the client is identified as Android. Change-Id: Ib3e9cf137acea50d3d39601d31ef8a2c34f3df46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526650Reviewed-by:Shik Chen <shik@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Wei Lee <wtlee@chromium.org> Commit-Queue: Jasmine Chen <lnishan@google.com> Cr-Commit-Position: refs/heads/master@{#828688}
-
Jan Wilken Dörrie authored
This change modifies the recently introduced base::MakeFixedFlatMap and base::MakeFixedFlatSet to also support unordered data. This required the implementation of a few compile time helpers to work around the lack of constexpr in the STL in C++14. Bug: 682254 Change-Id: I1e20ddb396684a4411442eb760ba9e29c0f50c26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543386 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#828687}
-
Denis Kuznetsov authored
Bug: None Change-Id: I12ba0bb13c5bb3f8426f468b7c078732918156cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544948 Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Auto-Submit: Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#828686}
-
Mirko Bonadei authored
Change Log: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+log/a4798817e8..4ae6730677 Full diff: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+/a4798817e8..4ae6730677 Bug: None Change-Id: I579bcf3224688870762fa706829cf88c4aecda2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545526Reviewed-by:
Danil Chapovalov <danilchap@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#828685}
-
Ioana Pandele authored
This reverts commit fa8de986. Reason for revert: StartupBrowserCreatorPickerTest.OpensPicker failing on multiple Mac bots. See https://ci.chromium.org/p/chromium/builders/ci/Mac10.11%20Tests/57259 Original change's description: > [Profile picker] Use system profile on startup when showing the picker > > This CL changes the logic to load the startup profile whenever the > profile picker should be loaded. It instead loads the guest profile > to indicate the picker should be open. This speeds up showing the picker > when the last profile used is heavy to load. The CL also unifies the > logic to decide whether to show the new picker (or the old user manager) > into one function, GetStartupProfile(). > > There is one behavioral difference: the new code directly opens browser > windows if the user had multiple profiles open last time. This is desired > because having multiple profiles open simultaneously the last time is a > strong signal the user wants to continue this way. Note that having > multiple profiles open the last time happens only in limited situations, > e.g. via chrome://restart or via session restore (when logging out / > switching off the machine with multiple profiles' windows open). > > Bug: 1150330 > Change-Id: Iae9744f44bc242e9aaaf8f287cc29e1089326786 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532460 > Commit-Queue: Jan Krcal <jkrcal@chromium.org> > Reviewed-by: David Roger <droger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#828665} TBR=droger@chromium.org,tmartino@chromium.org,jkrcal@chromium.org Change-Id: I52c105374343df095e18b0f9e8dadb8a92f4413e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1150330 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545529Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#828684}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/2ffff6d024c7..d1219d7bc85c 2020-11-18 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from d8a32653 to 45b78e7b (529 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cnorthrop@google.com Change-Id: I3b80781442d8ffc792b6b731e0df831c24cac727 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546636Reviewed-by:
-
Alice Wang authored
This CL adds separate ImageView and TextView to incognito_interstitial_bottom_sheet_view layout instead of reusing account_picker_bottom_sheet_logo and account_picker_bottom_sheet_title. The will facilitate the refactoring of account picker view states with separate xml for each state in the future. Bug: 1149865 Change-Id: If3ea975b0c2d1d211f4837ff7904162f9617d107 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544125Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#828682}
-
Ioana Pandele authored
TBR=agawronska@chromium.org Bug: 1150349 Change-Id: Iebacde87f186bacc0b98940db71d1e4d3ef15e50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545165 Commit-Queue: Ioana Pandele <ioanap@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1605646753-d9430b027373a1a39dfc015bcf61461b4f7377b7.profdata to chrome-win32-master-1605657601-251cbeeaa0b5b4101237d76ae6bfe2e9e499decd.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ibea30fbf798f577d02eb23c33f778b30fb624117 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546266Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/bb96f79d0e15..50066a3edffa 2020-11-18 caramelli.devel@gmail.com Subzero: inconsistency in registered threads option for the CommandLine with external LLVM If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Ief77cba2e839420701e8065c03ae9f76c2023fa0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546635Reviewed-by:
-
Ioana Pandele authored
This reverts commit 693f0f09. Reason for revert: CaptureModeTest* and some RecordingServiceBrowserTest* failing on MSan because fine_tune_position_ is uninitialized. See: https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/21353 Original change's description: > Capture mode: Put cursor setting logic together. > > Fullscreen, window, region capture mode now all require change mouse > cursor. This CL put mouse cursor setting logic in a central place and > auto decide which cursor to use based on the current event location. > It unified the cursor behavior on the capture bar and button, and also > fixed a few bugs in the original implementation, like the mouse cursor > can be disappear after clamshell->tablet->clamshell transition. > > Bug: 1142937 > Change-Id: I982e3be0fd9c513f108a8dd7cfe4e8aea60905e1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537939 > Commit-Queue: Xiaoqian Dai <xdai@chromium.org> > Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> > Cr-Commit-Position: refs/heads/master@{#828564} TBR=xdai@chromium.org,afakhry@chromium.org Change-Id: I9ba956eae8fd2e54d4ee89dfcf86936ff89d250a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1142937 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545166Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f1f7c370eb0d..dda9c164cb3b 2020-11-17 fmayer@google.com Merge "Do not wrap unwindstack::FrameData." 2020-11-17 treehugger-gerrit@google.com Merge "Skip reading peer credentials from IPC clients" 2020-11-17 fmayer@google.com Merge "Allow to delay free in mulithreaded_alloc." 2020-11-17 midaschieh@google.com Merge "Add dpu and g2d ftrace event in gfx category" 2020-11-16 rsavitski@google.com Merge changes Ie70f0117,I05ef7862,I80c51246 2020-11-16 fmayer@google.com Revert "Update NDK to r21." 2020-11-16 fmayer@google.com Update NDK to r21. 2020-11-16 primiano@google.com Merge "Reland "Add version consistently in all build configs and UI"" 2020-11-16 treehugger-gerrit@google.com Merge "metrics: Force modified_rail_slices to be empty if not valid" 2020-11-16 treehugger-gerrit@google.com Merge "metrics: Refactor RAIL Mode power queries" 2020-11-13 ccross@android.com Revert "Add version consistently in all build configs and UI" 2020-11-13 ccross@android.com Revert "bazel: fix for google3 import" 2020-11-13 primiano@google.com bazel: fix for google3 import 2020-11-13 rsavitski@google.com Merge "PRESUBMIT.py: update arg name to avoid warnings on newer depot_tools" 2020-11-13 primiano@google.com Merge "Add version consistently in all build configs and UI" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I3fec7490c6cc5084352aeba23586d2dab2598e9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546781Reviewed-by:
-
Nohemi Fernandez authored
Bug: 1043080 Change-Id: I7bd96ba2327ce5bc292990cf863f968c4029a4c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538214Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
-
Sean Harrison authored
Gettings icons is taking longer than expected, so pushing back flag expiration milestone, also removes ex-intern from flag owners. Bug: 1113642 Change-Id: I9cab96d6119c7ac33a18dfc46bd8c81911bd33ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545307 Commit-Queue: Sean Harrison <harrisonsean@chromium.org> Reviewed-by:
Theodore Olsauskas-Warren <sauski@google.com> Cr-Commit-Position: refs/heads/master@{#828675}
-
Christoph Schwering authored
This CL launches the AutofillSkipFillingFieldsWithChangedValues experiment that fixes a common cause of Autofill overriding user-filled fields. Bug: 966873, 949094, 1075533, 1150167, 1121552 Change-Id: I14cd67a33ad15a32b7be1e88105c83f72ed2007e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545305Reviewed-by:
Matthias Körber <koerber@google.com> Commit-Queue: Matthias Körber <koerber@google.com> Auto-Submit: Christoph Schwering <schwering@google.com> Cr-Commit-Position: refs/heads/master@{#828674}
-
