GitLab

This reverts commit fbb09263.

Reason for revert: Test is flaky

Original change's description:
> [profile-menu] Re-enable browser test _WithUnconsentedPrimaryAccount
> 
> ... and wait for SyncTransportActive during the setup.
> 
> Bug: 995720, 1012167
> Change-Id: Ib0523c68738f226a29171fabc64264cf36c03f37
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856061
> Commit-Queue: Thomas Tangl <tangltom@chromium.org>
> Reviewed-by: David Roger <droger@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#705126}

TBR=droger@chromium.org,tangltom@chromium.org

Change-Id: I44760e6374571726196153bf32022c9735fb7984
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 995720, 1012167
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856958Reviewed-by: Thomas Tangl <tangltom@chromium.org>
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705197}

No behavioral change intended.

Change-Id: I6905ee8f089812ee46eb454de7062a35b10db26f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849266Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705196}

This CL changes how credential entries are bound to the corresponding
views in the ListView - now PropertyModel is used to provide Credential
instances. The same PropertyModel contains FAVICON property for the
favicon.

Bug: 1012646
Change-Id: I1943220e6b716224d3e7ae5fb7ec226edc70e299
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852430
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Auto-Submit: Boris Sazonov <bsazonov@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Friedrich [CET] <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705195}

https://skia.googlesource.com/skia.git/+log/9b33e3602340..27c4369651a8

git log 9b33e3602340..27c4369651a8 --date=short --no-merges --format='%ad %ae %s'
2019-10-11 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-10-11 herb@google.com Introduce SkGlyphDrawableBuffer

Created with:
  gclient setdep -r src/third_party/skia@27c4369651a8

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC kjlubick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=kjlubick@google.com

Bug: None
Change-Id: Ib2a9806f52e52d9bd56986206f6fa897c743c158
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856678Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#705194}

This change performs minor clean-ups of base::AutoReset such as making
use of std::exchange in its move operations, taking the constructor
argument by forwarding reference and getting rid of the branch to
protect against self-move assignment.

Bug: None
Change-Id: I7cac40c037dc1e18367b42d3057bc984f14cb472
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855838Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705193}

Scroll view to show auto-selected toggle.
Fix layout issue with zero height divs.

Bug: 1010166
Change-Id: I56399b4a43da16797b3b25a818b8d39f3a4c89e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848380Reviewed-by: Denis Kuznetsov <antrim@chromium.org>
Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Commit-Queue: Roman Aleksandrov <raleksandrov@google.com>
Cr-Commit-Position: refs/heads/master@{#705192}

Problem:
In third_party/blink/renderer/core/input/gesture_manager.cc, the
function GestureManager::HandleGestureLongTap did not process
kGestureLongTap for Android, but it is not enough.
In web_view_impl.cc, function WebViewImpl::HandleGestureEvent processes
kGestureLongTap, it clears the context menu, but does not generate new
data for the context menu since GestureManager ignores kGestureLongTap.
Then in some conditions, it will make the context menu in Android
totally useless, click anything on the context menu won't do anything.

Fix:
In this CL, we check if we should process long_tap action before clear
ContextMenuController.

Bug:1012068

Change-Id: I2d490d5bde19f016d117437bcb793459b92a0cc0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849171Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: Gang Wu <gangwu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705191}

No functional changes intended, please revert if things break.

This function is a large, and hard to follow. I'm hoping to break out a
bunch of functions that are clearer about what they're doing and make
ordering clearer.

Bug: 1006927
Change-Id: Icd6c09563e577153829c8243758b8c98aff1b6c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837872
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705190}

Protected memory and HW decoders are not supported on x64 devices,
so WebEngine wasn't working properly when WIDEVINE_CDM feature was
enabled. This CL adds IsFuchsiaCdmSupported() that indicates that
that FuchsiaCdm is supported on the device. For now it's just a stub
that returns true only in arm64 builds.

With this change WebEngine will not try to use protected memory on
x64 devices where it's not supported.

Bug: 1013412
Change-Id: Ib9c323c725886ea7397bc7f2633a44fad56ee13a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854547
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Auto-Submit: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705189}

Remove this for now since it is not launched
anywhere but breaks newly added browser-tests.

Bug: 932818
Change-Id: Ic28350544eab1afb03862b650b09bb60cb829e3b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855205Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Siyu An <siyua@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705188}

This CL moves SlideOutController out of ui/message_center and into
ui/views/animation. This will allow the SlideOutController to be used
for swiping to dismiss notifications from the GMC dialog in
crrev.com/c/1829671

Bug: 1008905
Change-Id: I3ba95fe85ba18763324529d6e4fa450d7f78c143
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853855
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705187}

This reverts commit fc5ad208.

Reason for revert: Use of the GPUProgrammablePassEncoder and GPURenderEncoderBase interfaces aren't installing the function templates properly.

Original change's description:
> WebGPU: Add GPUProgrammablePassEncoder interface
>
> This is a spec match-up with[1]
>
> [1] https://github.com/gpuweb/gpuweb/pull/459
>
> Bug: 877147
> Change-Id: I080324cbb083160ae84aa109623e311f24a875cb
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845132
> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
> Cr-Commit-Position: refs/heads/master@{#704061}

TBR=jinho.bang@samsung.com,haraken@chromium.org,cwallez@chromium.org

Bug: 1013649
Change-Id: I0d401cece6c5dcfb94d17c3cc32965512d4ec2b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856618Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Commit-Queue: Austin Eng <enga@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705186}

Renames https_invalid.icon since the triangle icon will be used
for HTTP pages as well as part of crbug.com/997972.

Bug: 1008218
Change-Id: I031ab884361c5085f7ef0f7b93935e235540005a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846567Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Livvie Lin <livvielin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705185}

RtlCaptureStackBackTrace on Windows ARM64 relies on frame pointer chain to walk
the stack which is guaranteed by "/Oy-" option for clang-cl.exe/cl.exe. This
option is enabled in optimized build but not in debug build which could cause
missing Chromium modules in stack trace.

Bug: 893460
Change-Id: I60c3196aa8917209cfcf059eecc1660c291f5c17
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854825Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Tom Tan <Tom.Tan@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#705184}

I intend to reuse them to test a navigation throttle, but it's a little
crowded to put them in the same .cc file.

Bug: 1013389
Change-Id: Ie67cbff281ee7ca753b01d06743036a74764fa8b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854219
Auto-Submit: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Lucas Gadani <lfg@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Lucas Gadani <lfg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705183}

Using wpt-import in Chromium 530939ea.
With Chromium commits locally applied on WPT:
23748e60 "Change text directive to text="
2f7c5562 "Fetch Metadata: Split `sec-fetch-dest` out from other headers' tests."
d52a9d07 "Port IndexedDB Blob Web Tests to web-platform-tests."
6386d9d8 "Update service_worker_unregister_and_register()"
1644eff7 "Update scroll to text feature detectability API"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=robertma

No-Export: true
Change-Id: I01cb61e3c28497ca0b10c4b45636b0b915caea2a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856418Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#705182}

This feature was added to support the mustash project, which was using
the mojo pref service to support Chrome OS UI code running outside
the browser process. The mustash project was cancelled, none of the
remaining users of the mojo pref service need synced prefs, and the
mojo pref service will be removed soon.

This CL is partially a manual revert of these changes:

"Reland "Support late registration of syncable preferences.""
https://chromium-review.googlesource.com/c/chromium/src/+/1074688/

"Properly distinguish between regular and priority preferences in sync."
https://chromium-review.googlesource.com/c/chromium/src/+/1099381/

This CL keeps the code to reset prefs on type mismatches between
server and client.

One of the histograms added in the CLs above is marked obsolete.

Bug: 1012462, 840332
Change-Id: I702bfbfbb2c9e6e5c84496391efb6f48a4c07c3a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848267
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Reviewed-by: Tim Schumann <tschumann@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705181}

Bug: 268984
Change-Id: I3e31bd137be5df84c1fcad094813965d23b2cc44
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848502Reviewed-by: Daniel Rubery <drubery@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705180}

-Currently when a user has ChromeVox turned on and a printer is
 successfully added, a success toast pops up but ChromeVox does not
 announce it. This change forces ChromeVox to read out the contents of
 the toast.

Bug: 987343
Change-Id: I9ffa73d8765ddfbdaad421bf13d3ab4efaaadfef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850250Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>
Commit-Queue: Gavin Williams <gavinwill@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705179}

RenderWidget used to start closing and then post a task to self-delete.
But now it deletes synchronously inside Close(). So when closing_
becomes true, the RenderWidget will be deleted in the same stack. Thus
we do not need to guard against closing_ since blink will not be using
the RenderWidget afterward - it would be a UAF.

The LayerTreeViewDelegate methods used to check for a null WebWidget
which would be the case once closing_ became true, before RenderWidget
was destroyed. Now the RenderWidget disconnects itself from the
LayerTreeView and deletes immediately, so these methods are never
called with a null WebWidget unless they were used while the
RenderWidget is undead. But the compositor does not run while the
RenderWidget is undead, and the LayerTreeViewDelegate will not be used
unless the compositor posted the task and then runs it after the
RenderWidget becomes undead. The methods in this CL are all part of the
BeginMainFrame step which only runs when the compositor is visible and
the RenderWidget is not undead.

R=avi@chromium.org

Bug: 419087
Change-Id: If0158f2ffeaf0c5d334a80aed3cdb9e686002fb6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854878Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705178}

https://android.googlesource.com/platform/external/perfetto.git/+log/8f41e5d14063..dbcebd185da3

git log 8f41e5d14063..dbcebd185da3 --date=short --no-merges --format='%ad %ae %s'
2019-10-11 treehugger-gerrit@google.com Merge "processor: Fix some potential crashes in json exporter"
2019-10-11 fmayer@google.com Merge "Add roots to heap_graph proto."

Created with:
  gclient setdep -r src/third_party/perfetto@dbcebd185da3

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=perfetto-bugs@google.com

Bug: None
Change-Id: I2cdbf3923d1a9439fadd131e6c5bdfdbe96e79ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856284Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#705177}

This is a reland of 825856a2

Original CL was reverted because the new API wasn't ready for M78. Now the API
is changing (https://crrev.com/1816002) so we re-land the new origin trial name.

Original change's description:
> Migrate Badging origin trial name to BadgingV2.
>
> This invalidates all existing Badging origin trial tokens, as we are
> moving to a new (slightly incompatible) Badging API. New origin trial
> tokens will become available.
>
> Bug: 1000960
> Change-Id: Ic9ca1b56a390a601b2591a27352d205650df2c33
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787018
> Commit-Queue: Matt Giuca <mgiuca@chromium.org>
> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> Auto-Submit: Matt Giuca <mgiuca@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#693555}

Bug: 1000960
Change-Id: Ic7a7e87f58ec4bc060a68f2adfcd7e5021b20909
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855078
Auto-Submit: Matt Giuca <mgiuca@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705176}

Bug: 984550
Change-Id: Ib2705c3e1121a24bffa147e24ed8b3ecc9241f32
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853845Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Lucas Gadani <lfg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705175}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/ddd5171b..4e284d62

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I615d6e5567999acccbc67e344b436a48a3a86835
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855419Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#705174}

This change contains a small fix for the Profiler Datagrid, which is
used in the Top down and bottom up views for Memory Panel Allocation
samples and the Javascript Profiler tool.

It adds an aria label to the percentage columns to separate the raw
number from the percentage of the Heap/CPU
(uses a comma in the aria label,
which causes screen readers to separate the 2 numbers when reading)

Before:
Screen Reader: https://imgur.com/OA0scyB

After:
Screen Reader: https://imgur.com/a/Ke7m76C

Bug: 963183
Change-Id: I6e8f9fe59cbe17b90d581a52fc08d0024fe09107
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730595
Commit-Queue: Brandon Goddard <brgoddar@microsoft.com>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Reviewed-by: Jeff Fisher <jeffish@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#705173}

* Use EditText instead of TextView for TabGridDialog title as the
  entrance for tab group naming.
* Implement a TabGroupTitleEditor in TabListMediator for tab group
  naming.
* Add unit tests for mediator-side logic and DummyUiActivity tests for
  binder-side changes.

Bug: 1001738
Change-Id: I3a4ca5d4c581749ce059e3475e8182efae600332
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815988
Commit-Queue: Yue Zhang <yuezhanggg@chromium.org>
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705172}

This patch makes the rendersubtree attribute activate by default.
It replaces the activatable flag with two:
1. skip-activation: this indicates that we don't want to activate the
   lock in any situation
2. skip-viewport-activation: this indicates that we don't want to
   activate because the element enters visility range (ie don't use
   intersection observer).

R=chrishtr@chromium.org, rakina@chromium.org

Change-Id: Ie70660ea2ec9e4840cbe53f31f6f063631a1e44e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853854
Commit-Queue: vmpstr <vmpstr@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705171}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e3703bb8b8af..12265a8f7de0

git log e3703bb8b8af..12265a8f7de0 --date=short --no-merges --format='%ad %ae %s'
2019-10-11 ehmaldonado@chromium.org Revert "depot_tools: Add httplib2 to .vpython"

Created with:
  gclient setdep -r src/third_party/depot_tools@12265a8f7de0

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC agable@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=agable@chromium.org

Bug: chromium:1002153
Change-Id: Ic5e2b8c0ff7aecdad7d6acff6f2f6c737337bba9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856459Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#705170}

https://chromium.googlesource.com/angle/angle.git/+log/a21362f5a6ae..741c0aa6f5a1

git log a21362f5a6ae..741c0aa6f5a1 --date=short --no-merges --format='%ad %ae %s'
2019-10-11 ianelliott@google.com Vulkan: Update GLES 3.0 expectations files
2019-10-11 b.schade@samsung.com Vulkan: finishToSerial only if the buffer is in use
2019-10-11 cnorthrop@google.com Vulkan: Handle 2Darray base/max level change

Created with:
  gclient setdep -r src/third_party/angle@741c0aa6f5a1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC geofflang@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=geofflang@google.com

Bug: None
Change-Id: If8a821cf67b66034d047cb3891b9189ccec011d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856579Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#705169}

After recent cleanups, these were completely unused:

DomDistillerStore was purely a wrapper around DomDistillerModel,
containing no functionality whatsoever.

DomDistillerModel itself was always empty in practice: The only way it
ever got any data was through an |initial_data| param passed to the
constructor, which only tests used.

TBRing mechanical ios/ changes
TBR=noyau

Bug: 1007942
Change-Id: Ibe96f0d1ed7692b6d38c401a6feb76ea612a57f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853405
Commit-Queue: Marc Treib <treib@chromium.org>
Auto-Submit: Marc Treib <treib@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705168}

The order of operations for making a new RenderWidget for a frame is:
1. new RenderWidget.
   Now we have a pointer but it is not used because it is not
   initialized.
2. pass RenderWidget to WebFrameWidget as the WebFrameWidgetClient
   This gives the pointer out but it's just stored, which allows the
   WebFrameWidget to function correctly once it is used.
3. Initialize RenderWidget
   This includes calling into the WebWidget, which is why step 2 was
   important.

Reviving a widget from undead should look like this too, but currently
in step one, instead of just marking the widget as not undead, we also
jump ahead and start to do initialization. That means the
initialization code requires null checks around the WebFrameWidget
being present or not, and fails to do some of its normal initialization
steps in the revive-from-undead case.

This CL fixes revive from undead to look like creating a new
RenderWidget. Step one only marks the RenderWidget as no longer
undead and performs the equivalent steps if needed as the
RenderWidget's constructor. All initialization is deferred to the
InitForRevivedMainFrame() which will run as step 3.

The creation path is modified to be more explicit as well. When step 3
initialization happens, if the widget is undead, the LivingInit() steps
are skipped. They will be run when the widget is revived from undead.
And they will be run each time the widget is revived, if it happens
multiple times over its lifetime.

RenderWidget-specific logic is moved out of RenderViewImpl in the
process. The RenderWidget::SetIsUndead(true) method is the replacement
for Close() and it can do partial shutdown such as closing the
WebWidget. This removes the need for SetWebWidgetInternal(), making
the RenderWidget API for undead-ness closer to the normal APIs.

As compositor and WebWidget initialization in step 3 is now always
after the WebWidget is set, null pointer checks for the WebWidget can
be removed, as was the original intention in this CL.

R=avi@chromium.org

Bug: 419087
Change-Id: I024c852d00110015308640f272220ed7d560d5b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854818
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705167}

This avoids re-encoding thumbnail images by requesting compressed image
data directly from ThumbnailImage.

Additionally, this changes the data URI generating code to reduce usage
of temporary std::strings.

Bug: 991393
Change-Id: Ia5cc679c383e5ef4a084c5b220492c824124b7d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836146
Commit-Queue: Collin Baker <collinbaker@chromium.org>
Reviewed-by: John Lee <johntlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705166}

The terminal experiment was initially proposed in 2016 [1]. Since then,
no maintenance work was performed on promoting the experiment to a
stable feature.

Closer inspection of the feature shows that it does not work. After
enabling the experiment, issueing the command "Show Terminal" results in
an internal error in xterm.

If we want to reconsider this experiment, we should re-evaluate the
approach and come up with a proper design for the feature. For now, I
would propose on removing the dead code.

[1]: https://codereview.chromium.org/2372303003

Bug: 1006759,1011466
Change-Id: Ib433b44924d9ccb1f5665afba9affcccd04c2bd8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855923
Commit-Queue: Yang Guo <yangguo@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705165}

chrome://sync-confirmation is only available on Win,Mac,Linux, but its resources
where unnecessarily included on CrOS as well.

Moreover IDR_SIGNIN_SHARED_CSS_HTML was erroneously included in Android too.

Bug: 1012533
Change-Id: Id9bacdea1f085beb3cf58b718152f8d6f45f5fa9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854793
Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705164}

This reverts commit 7fda4612.

Reason for revert: testAggregateTraces is failing.

Original change's description:
> [tools/perf] Implement traces aggregation in Results Processor
> 
> Bug: 981349
> Change-Id: I1a47afea1dedcd352a0d6999f7119246b74b737f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849855
> Commit-Queue: Mikhail Khokhlov <khokhlov@google.com>
> Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#704705}

TBR=perezju@chromium.org,khokhlov@google.com

Change-Id: I480141f37e0b8420615e7fda92b3392d6c3e230f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 981349, 1013519
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856360Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705163}

Adjust to https://github.com/w3c/wake-lock/pull/234. Screen wake lock
requests could be rejected with either AbortError or NotAllowedError
depending on when the document became hidden.

For consistency, always reject the promise with NotAllowedError.

Bug: 257511
Change-Id: I00eb478af62a794692a8c439926ce89480cd0510
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856166
Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705162}

ScopedFeatureList is unsafe to use after browser threads have been
started. This constraint will imminently be enforced by DCHECK to
prevent further erroneous usage from landing.

This CL corrects usage within chrome/browser/ui/

This is split from a larger CL where in some rare cases, correction
was too complex to resolve before landing the DCHECK, so corresponding
test(s) may be disabled instead of fixed.

Bug: 846380
Change-Id: Icf7980a928f4462e21f6d252fc04170a79be9393
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850735
Commit-Queue: Ken Rockot <rockot@google.com>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Reviewed-by: Carlos IL <carlosil@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705161}

There is no need to remove the method entirely, it serves a purpose
in the end.

Bug: 752327

Change-Id: Iab58f934be779a9e4bc0f53d19e1d82966e5af6f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842632
Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Reviewed-by: Stefan Zager <szager@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Auto-Submit: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705160}

Previously, service workers were resurrected when they were updated
or when the same script was registered while the service worker was
still alive. Now, registering a service worker will always create a
new instance, regardless of whether there already is a running
instance or not.

Chrome status:
https://chromestatus.com/feature/5646687634718720

Intent to Implement and Ship:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/r176Lvgxfys/4W4IGM4uAgAJ

Bug: 971571,988582
Change-Id: Id7748377af107099d7c10fb2e455f30f7423e5f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768759
Commit-Queue: Yannic Bonenberger <yannic.bonenberger@gmail.com>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705159}

Right now a FrameSequenceTracker would report its throughput data at the
end of a frame sequence only. That is, if we have a very long sequence,
it would report once. That could easily bias the data.

This CL makes changes such that a tracker would report data every 5s.

Bug: 996752
Change-Id: I768583e71ad3431c5c29dddc7f07ddad8d9eba39
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827580
Commit-Queue: Xida Chen <xidachen@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705158}