GitLab

Bug: 
Change-Id: I8cae31aaf14516949aa812f2fd65db7503bfeeb2
Reviewed-on: https://chromium-review.googlesource.com/823963
Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org>
Reviewed-by: Drew Wilson <atwilson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524136}

This is the initial test config for the Linux Viz FYI bot. I'll be adding more
tests as we prepare them.

Bug: 793820
Change-Id: I13140ef85c2b0c4819b099a83cee343814b8970c
Reviewed-on: https://chromium-review.googlesource.com/826424Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524135}

This CL moves Profile instance obtaining from ProfileDataCache clients
to ProfileDownloader. It improves testability of ProfileDataCache and
dependent code by removing requirement for Profile object and allowing
simple faking with FakeProfileDataSource.

Bug: 746519
Change-Id: Ia81ef9c429384f2b9ec5e04ecb220f9aba90358a
Reviewed-on: https://chromium-review.googlesource.com/824662
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524134}

This CL contains 3 small cleanups.
1.Removed unused functions isAutofilled/setAutofilled (setAutofilled is used,
but isAutofilled is not used, so no reasons to keep them)
2.Removed try/catch in getPasswordFormDataList, this function is called only
for main frame or same origin iframes. So no need in try/catch. Moreover
function fillPasswordFormWithData_, which is called in the same circumstances,
doesn't have try/catch.
3.Rewritten for loop by iframes with one line with call of .some().

Bug: 782224
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I72a07181ffd643329b7217825ec182e948b3c57b
Reviewed-on: https://chromium-review.googlesource.com/825998Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524133}

Flip quic_reloadable_flag_quic_explicit_close_after_tlp to true.

Fix direct reference to FLAGS_quic_reloadable_flag_quic_2rtt_drop_client_cached_certs.

Merge internal change: 178764077

https://chromium-review.googlesource.com/c/chromium/src/+/825467

Deprecate FLAGS_quic_reloadable_flag_quic_bbr_fully_drain_queue and gfe2_reloadable_flag_quic_bbr_slower_startup.

Merge internal change: 178696596

https://chromium-review.googlesource.com/c/chromium/src/+/824986

In QUIC, add OnStreamFrameLost to QuicSession and QuicStream. No functional change expected.

When QuicStream gets chance to write, it will try to retransmit lost
data if any before write new data.
Add list of streams with lost data to QuicSession. When QuicSession gets
chance to write, it will try to let streams retransmit lost data.
A special case is crypto stream, as the data needs to be retransmitted
with appropriate encryption level.

Merge internal change: 178674419

https://chromium-review.googlesource.com/c/chromium/src/+/825146

Deprecate FLAGS_quic_reloadable_flag_quic_frames_deque3.

Merge internal change: 178636591

https://chromium-review.googlesource.com/c/chromium/src/+/825145

Add quic_array_size.

Merge internal changes: 178382821, 178776675

https: //chromium-review.googlesource.com/c/chromium/src/+/825164
Change-Id: I1006534e79cfaf2890674ea2a4841ab5419838eb
Reviewed-on: https://chromium-review.googlesource.com/826083
Commit-Queue: Fan Yang <fayang@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524132}

It looks like some of the bots are still having problems with the
preloading browser test. This ensures we use full paths for referencing
files.

BUG=794629

Change-Id: I814d74bf973968350207e4b6f4879f767c82a225
Reviewed-on: https://chromium-review.googlesource.com/827135Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524131}

We want to begin getting coverage of browser_tests with --enable_viz.
To start we would like to run them on a Windows FYI bot to find flakes.

I'll be triaging the failures found so far, and updating the filter
later on with the associated bugs.

TEST: viz_browser_tests
BUG: 794961
Change-Id: I554af1c3d308da1b7fd0496c08efa24e17bd6799
Reviewed-on: https://chromium-review.googlesource.com/822295Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524130}

64-bit builds have been working for a while now.
32-bit chrome/win still cannot build on Mac hosts due to bug 794838.

TBR=brettw

Bug: 774209,794838
Change-Id: I762853e7e5d2b4470642402e8b585dfe8f84b53e
Reviewed-on: https://chromium-review.googlesource.com/826010
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524129}

GrBackendObject is deprecated and going away in Skia so switch to its
replacement: GrBackendTexture.

This does rely on the following Skia CL having rolled into Chrome:
    https://skia-review.googlesource.com/c/skia/+/82823 (Update SkImage::MakeFromYUVTexturesCopy to GrBackendTexture)

Change-Id: I3a6445ac44d4799ce6f4d10d1ff19cda6743f955
Reviewed-on: https://chromium-review.googlesource.com/824563Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Reviewed-by: Brian Salomon <bsalomon@chromium.org>
Commit-Queue: Robert Phillips <robertphillips@google.com>
Cr-Commit-Position: refs/heads/master@{#524128}

LLVM fixed the bug where framepointers were not located next to the return
address in thumb mode. https://bugs.llvm.org/show_bug.cgi?id=18505

With that fix, enabling framepointers on arm32 bring it in line with other
build configurations and allows for better stack traces.

Bug: 786450
Change-Id: I01a1c9f82fac22b2bbc15c6f52deed8aca7263ea
Reviewed-on: https://chromium-review.googlesource.com/826255Reviewed-by: Brett Wilson <brettw@chromium.org>
Commit-Queue: Albert J. Wong <ajwong@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524127}

https://chromium.googlesource.com/catapult.git/+log/4b9d944868d0..0e2365136c55

$ git log 4b9d94486..0e2365136 --date=short --no-merges --format='%ad %ae %s'
2017-12-13 bsheedy Add ACCESS_VR_STATE to blacklist

Created with:
  roll-dep src/third_party/catapult


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: Icc2670ba271f69e3027cfd6bbf449146e3a334a6
Reviewed-on: https://chromium-review.googlesource.com/826701
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524126}

Support displaying the errors dialog from drag-and-dropped directories.
To do this, notify the developerPrivate API when a drag begins to
cache the directory that is being dragged. Also add an additional
parameter to loadUnpacked, useDraggedPath, to use the cached dragged
path rather than prompting the user to choose a path or using a retryId.
When the user drops the directory, use this to load the extension.
Going through the loadUnpacked method like this has the advantage of
displaying load errors to the user and allowing them to retry.

Note that we cannot simply provide the filepath directly from the JS to
the C++ for security reasons (in the case of a compromised renderer, we
don't want to be able to add an arbitrary extension - this ensures that
the user dragged the extension over the extensions page).

The fact that the drag_and_drop_handler is also used by the non-MD
version complicates this slightly, because we have to work for both
versions of the code. This means there's a bit more mess than I'd
otherwise like. This can be cleaned up when MD extensions launches.

Bug: 788926

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I888b2094dcda1e964bca0f2680573387e714ea77
Reviewed-on: https://chromium-review.googlesource.com/809953
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524125}

https://chromium-review.googlesource.com/c/chromium/src/+/823219 rolled
clang past the revision including -finstrument-function-entry-bare. This
reduces the instrumentation size and runtime overhead.

Use this new instrumentation when possible.

Size of libchrome.so:
Before: 67MB
After: 55MB
No Instrumentation: 47MB

Bug: 776702
Change-Id: I74bea84e7e6b0fa98c841ce0f2c492b6a7a7e31f
Reviewed-on: https://chromium-review.googlesource.com/826623Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Matthew Cary <mattcary@chromium.org>
Commit-Queue: Benoit L <lizeb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524124}

A change in Chrome 63 causes Chrome to urlencode the fragment component
of URLs. The Chrome omnibox should decode the fragment component as it
does for other URL components and matching Firefox.

Bug: 789163
Change-Id: If82d72445d904495c8d3e4129ab63be141745328
Reviewed-on: https://chromium-review.googlesource.com/822819
Commit-Queue: Eric Lawrence <elawrence@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524123}

The switch is used to enable out-of-process chrome os system ui (ash).
It used to be used by the Linux Ozone build, but isn't anymore.
Limit it to OS_CHROMEOS builds to make it clear where it is actually
used.

Bug: 722527
Test: bots, chrome --mash, browser_tests --mash
Change-Id: If980d1f843950f93f89404b658108ae0091639d9
Reviewed-on: https://chromium-review.googlesource.com/823259
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524122}

This is a follow-up to https://crrev.com//f41d2d3d4e8af.

Reason: Previously, the results argument from MockGitCL
would sometimes be a CLStatus, and sometimes be a dict
of Build to TryJobStatus. Furthermore both try_job_results
and wait_for_try_jobs would return the same type, which
is longer the case for the real GitCL.

The purpose of this CL is to make MockGitCL easier to use
and also reflect the behavior of the actual GitCL class.

Change-Id: I6d08dbdc205a1191b47039002b4a18a9579b022b
Reviewed-on: https://chromium-review.googlesource.com/826707Reviewed-by: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524121}

All usages of gconf have now been removed, so we can remove the build
flag too. After this, I will remove gconf from the instrumented
libraries, sysroots, and install-build-deps.sh.

Bug: 768027
Change-Id: Idf5e8d60da387b3287f875092feba488217ca642
Reviewed-on: https://chromium-review.googlesource.com/826046Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Tim Brown <timbrown@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524120}

As part of page lifecycle, we need to notify the page that it is getting
STOPPED. This CL introduced window.onfreeze, a new callback that will
fire when the page is STOPPED. If the page is resumed and not killed,
then window.onresume is called.

Currently, the page is stopped on Android after being backgrounded for a
few minutes. More stopping scenarios are being added. When a page is
stopped, all the timers will stop firing, and any load activities will
be halted. The onfreeze is the last callback made to the page before
it is either resumed or killed. When the page re-enters the ACTIVE or
HIDDEN states, window.onresume is called.

This feature is currently under a "test" RuntimeEnabled flag.

Bug: 765401
Change-Id: I09486e4298a80f4a08c6c8d78bf060745e81d687
Reviewed-on: https://chromium-review.googlesource.com/764503Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Nate Chapin <japhet@chromium.org>
Reviewed-by: Shubhie Panicker <panicker@chromium.org>
Commit-Queue: Fadi Meawad <fmeawad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524119}

Update the Security Overview Page in DevTools to MD.
Modified the strings and introduced a title value to
SecurityStyleExplanation. Updated tests to reflect
this change.

Screenshot: https://screenshot.googleplex.com/Qqjc0TmkaS5.png

Bug: 617311
Change-Id: If7893e2fd795c53e6a9fed0542f84bbe7006f59b
Reviewed-on: https://chromium-review.googlesource.com/772002Reviewed-by: Emily Stark <estark@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Eric Lawrence <elawrence@chromium.org>
Commit-Queue: Sarah Chan <spqchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524118}

This change configures Chrome to
- Download asset component version 1.y,
- Load and decode background.png/.jpeg,
- Only register assets component on Chromes (not Chromiums).

Bug: 793977, 793405, 793384
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I33de68ac0c3317360c0e26ae4274242e87092ff5
Reviewed-on: https://chromium-review.googlesource.com/822835
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Biao She <bshe@chromium.org>
Reviewed-by: Chris Palmer <palmer@chromium.org>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524117}

This reverts commit 5fc3b9d0.

Reason for revert: crashes, see crbug.com/794927.

Original change's description:
> [DevTools] Implement waitForDebugger for OOPIFs
> 
> Using NavigationThrottle for this. Since during throttling
> the navigation has not committed yet, we have to create
> agent host for soon-to-be-committed frame in advance.
> 
> Bug: 750901
> Change-Id: I88dbd982481b88eeec36209b6bf3ad7f74863200
> Reviewed-on: https://chromium-review.googlesource.com/818076
> Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
> Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#523835}

TBR=dgozman@chromium.org,caseq@chromium.org,pfeldman@chromium.org

Change-Id: I367776fd716614f4fd113c2f88ed3bfcbc5ac5c6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 750901
Reviewed-on: https://chromium-review.googlesource.com/826496Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524116}

Bug: 598854
Change-Id: Ia8bf724deef748dafa262125bad8e8b1bdaf64bd
Reviewed-on: https://chromium-review.googlesource.com/826002Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524115}

Removes "help-" prefix from the classnames as none of those styles are
used on an actual help screens. Also, disables Ctrl+A on settings
screens.

Bug: 778585
Change-Id: I28bcd05122c1e06952db4597db2038d73f15e089
Reviewed-on: https://chromium-review.googlesource.com/822924Reviewed-by: Joel Einbinder <einbinder@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Eugene Ostroukhov <eostroukhov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524114}

This is a small follow-up to https://crrev.com//f41d2d3d4e8af.

Change-Id: I7d79d97a385fc964e39bd56f323dfe448cb82b89
Reviewed-on: https://chromium-review.googlesource.com/826268Reviewed-by: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524113}

This changes about 50 files, mostly in ash, to use the new API.

There about 200 more files to update. A forwarding function is left for
backwards compatibility for these files.

Clarify usage of GridLayout::CreateAndInstall and fix
payment_sheet_view_controller.cc which was installing the layout
manager twice.

The only functional change should be in sidebar_widget.cc where some
calls are reordered.

Change-Id: Iab5bad2055cc561dbc9a92600da838660849944e
Reviewed-on: https://chromium-review.googlesource.com/825402
Commit-Queue: Brett Wilson <brettw@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524112}

If the process launch fails it ends up trying to track PID #0 which
causes a DCHECK.

Bug: 757946
Change-Id: If4558b1707aad237273127365c5b5be64d32f327
Reviewed-on: https://chromium-review.googlesource.com/826085Reviewed-by: Will Harris <wfh@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Will Harris <wfh@chromium.org>
Commit-Queue: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524111}

This test was assuming that calling minimize() and maximize() followed
by restore() without waiting for onMinimized or onMaximized would
trigger onRestored. This is not the case on Mash, and is also a likely
cause of flake on other platforms.

Bug: 232330,678687,794771
Change-Id: I2a6a0f1e0b527583add555ed5ab8bfdc3a073df6
Reviewed-on: https://chromium-review.googlesource.com/821310Reviewed-by: Ben Wells <benwells@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524110}

Currently we have an issue that the Control group always read the
default configuration of parallel download defined in the code.

However, when tweaking the server config, we can use different slice
size, which will result in experiment groups comparing different sample
sets.

This CL adds a Finch parameter to alternatively disable parallel
download in an enable experiment group, and also read configs from
the server.


Bug: 794718
Change-Id: I9cf91233cbaf3dd22917af2e026c736803bd8e19
Reviewed-on: https://chromium-review.googlesource.com/825984
Commit-Queue: Xing Liu <xingliu@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524109}

This will allow certificates to be typed even if we send an empty
PEM certificate which the server can act on.

Bug: 778535
Test: unit_tests
Change-Id: Iadc2d94c4cdd558dc46086b7cea629f7f92e8ae7
Reviewed-on: https://chromium-review.googlesource.com/822164Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Yves Arrouye <drcrash@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524108}

Bug: 765334
Change-Id: I8b88d07d40314fb3c4554530e3e1918f301b0202
Reviewed-on: https://chromium-review.googlesource.com/827035Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524107}

Change-Id: Ib01ff5242683a9d67c89558ab0c52d9a08d61196
Reviewed-on: https://chromium-review.googlesource.com/826263Reviewed-by: Jeff Carpenter <jeffcarp@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524106}

Create directly with std::make_unique instead.

TBR: boliu@chromium.org, tedchoc@chromium.org
Bug: 792192
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I97442118fef4efb6dd0be4e64b5f140499a469f2
Reviewed-on: https://chromium-review.googlesource.com/826428Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524105}

Bug: 
Change-Id: Ia17a468fdbb5b70ddac99594aa2c2a9903b55a4f
Reviewed-on: https://chromium-review.googlesource.com/825103Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: Eric Stevenson <estevenson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524104}

https://skia.googlesource.com/skia.git/+log/63789ccc03f6..e9188850ec2f

$ git log 63789ccc0..e9188850e --date=short --no-merges --format='%ad %ae %s'
2017-12-14 kjlubick Revert "Revert "Disable extra CPUs during Nanobench""
2017-12-14 mtklein add back purgeResourcesNotUsedInMs() temporarily
2017-12-14 mtklein Revert "Disable extra CPUs during Nanobench"

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=liyuqian@chromium.org

Change-Id: I6fea8c36e32eb67487da8bda42201291d529f544
Reviewed-on: https://chromium-review.googlesource.com/827083Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524103}

Do not return ROLE_SYSTEM_WINDOW ourselves as that is a special MSAA
system role used to indicate a real native window object. It is
automatically created by oleacc.dll as a parent of the root of our
hierarchy, matching the HWND.

For AX_ROLE_WINDOW, we should expose something similar to what Firefox
exposes, namely ROLE_SYSTEM_APPLICATION.

This helps NVDA not read superfluous text when the user navigates
to the toolbar or location bar.

Bug: 794931
Change-Id: I123f07cb477304da1f016d65ea8c2b23b7a92ef4
Reviewed-on: https://chromium-review.googlesource.com/826866Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524102}

https://chromium.googlesource.com/catapult.git/+log/97e6e42e3e39..4b9d944868d0

$ git log 97e6e42e3..4b9d94486 --date=short --no-merges --format='%ad %ae %s'
2017-12-13 simonhatch Dashboard - Remove call to GetOrCreateAncestors in /add_histograms

Created with:
  roll-dep src/third_party/catapult


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: Ia440f4c31039dea476abad558c74f0c4b32b43b4
Reviewed-on: https://chromium-review.googlesource.com/826803
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524101}

This patch enables checker imaging subject to heuristics for images that
were explicit marked as decoding=async by the developer.

R=khushalsagar@chromium.org, chrishtr@chromium.org

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I460402d0f0ff9eb0bbb1262f87b275f5410d5c2a
Reviewed-on: https://chromium-review.googlesource.com/825650
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524100}

This reverts commit 241cb0e4.

Reason for revert:
Internal Android ToT broken, please review and update
downstream usage before relanding.

Original change's description:
> [WebPayments] Drop trans. layer for Mojo structs
> 
> Full Title: Drop Translation Layer for Some PaymentRequest Mojo Structs
> 
> Currently we have C++ classes duplicating our Mojo structs; it turns out
> this is unnecessary and adds a lot of complexity. This change removes
> two of them (PaymentAddress, PaymentCurrencyAmount) as a first step
> towards removing all of them. To allow using these structs on iOS, which
> does not use WebKit, we have to move these back to the components
> directory, where they originally lived. My tentative plan is to move
> the remaining mojo structs to components, split between the
> payment_request_data file added in this CL, and a new
> payment_request_interface file for the bits which will not be included
> on iOS (where communication with the renderer does not use Mojo).
> 
> Bug: 775631
> Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
> Change-Id: I7e4a4b21fe8c75c37b95fb12658114d1994f4a66
> Reviewed-on: https://chromium-review.googlesource.com/738515
> Commit-Queue: Tommy Martino <tmartino@chromium.org>
> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
> Reviewed-by: Ted Choc <tedchoc@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Chris Palmer <palmer@chromium.org>
> Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
> Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#524087}

TBR=palmer@chromium.org,dcheng@chromium.org,rouslan@chromium.org,sdefresne@chromium.org,tedchoc@chromium.org,tmartino@chromium.org,mahmadi@chromium.org

Change-Id: I02b048666c4b510ec98bacb8f52bfffbee00d18a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 775631
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Reviewed-on: https://chromium-review.googlesource.com/826224Reviewed-by: Nicolas Dossou-Gbété <dgn@chromium.org>
Commit-Queue: Nicolas Dossou-Gbété <dgn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524099}

The issue was in:
AwCookieAccessPolicy::GetShouldAcceptThirdPartyCookies()

AwContentsIoThreadClient::FromID(render_process_id, render_frame_id) was
used, but at this point a navigation request is not associated with a
renderer process yet. It caused the cookies not being sent with the
request.

The solution was to use
AwContentsIoThreadClient::FromID(frame_tree_node_id) instead.

Bug: 793648, 794939
Change-Id: I5bda7affab67645cfd64c105b06c8a628047dd79
Reviewed-on: https://chromium-review.googlesource.com/827018
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524098}

The Client interface was diluted down to a single method at this point.
Different implementations of overriding Delegate's Run() methods will
need different behaviors from ShouldQuitWhenIdle(). Making it easily
overrridable is key.

One such example behaviour is when overriding a MessageLoopForUI/IO.
When waiting inside a Run() with no more tasks, control needs to
remain in the hands of the overridden MessageLoop as it may receive
work first (from the system) and therefore shouldn't quit-when-idle
when the overriding Delegate is out of work (the overriding Delegate
can let it know to wake by posting a task to it if it gets work
first).

R=thestig@chromium.org

Bug: 708584
Change-Id: I27a449bc3be5858b0e8d4d6482714523ad5e2b67
Reviewed-on: https://chromium-review.googlesource.com/817962
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524097}