- 06 Apr, 2020 13 commits
-
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=srinivassista@chromium.org Change-Id: Id077aa4055c31e519a58f2db634cdd7325429d07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136849Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#756567}
-
Ian Kilpatrick authored
This was introduced in: https://chromium-review.googlesource.com/c/chromium/src/+/2099322 It turns out this was reachable! Bug: 1064432 Change-Id: I742f706434cd45ea8c30505e565b193921c3f6ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136880 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#756566}
-
Luciano Pacheco authored
This reverts commit 6f300726. Reason for revert: We want the flag enabled in ToT (for M-84 branch). Original change's description: > Revert "Reland "Files app: Enable flag files-ng by default"" > > This reverts commit aed7a18a. > > Reason for revert: Disabling for M-83, feature moved to M-84. > > Original change's description: > > Reland "Files app: Enable flag files-ng by default" > > > > This reverts commit 7545fd48. > > > > Reason for revert: We want to enable the flag by default on ToT, the revert was intended to disable the flag on M-82, on ToT it should be > > enabled. > > > > Original change's description: > > > Revert "Files app: Enable flag files-ng by default" > > > > > > This reverts commit ea497580. > > > > > > Reason for revert: Feature moved from M-82 to M-83. > > > > > > Original change's description: > > > > Files app: Enable flag files-ng by default > > > > > > > > Add files-ng classes and attribute to main.html so files-ng styles are > > > > applied during app startup (to avoid a FOUC flash of non-files-ng blue > > > > color). > > > > > > > > Enable file-ng by default in FilesApp and its browser test harness. > > > > > > > > Bug: 992818 > > > > Change-Id: If437271c5604d36b4b0908abb663a84e52b6ae35 > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087308 > > > > Reviewed-by: Alex Danilo <adanilo@chromium.org> > > > > Commit-Queue: Alex Danilo <adanilo@chromium.org> > > > > Cr-Commit-Position: refs/heads/master@{#747421} > > > > > > TBR=noel@chromium.org,lucmult@chromium.org,adanilo@chromium.org > > > > > > Bug: 992818 > > > Change-Id: I8b1c770e2c43823eff9a2a9aceae650fcb25a3f8 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103992 > > > Reviewed-by: Luciano Pacheco <lucmult@chromium.org> > > > Reviewed-by: Noel Gordon <noel@chromium.org> > > > Reviewed-by: Alex Danilo <adanilo@chromium.org> > > > Commit-Queue: Luciano Pacheco <lucmult@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#750448} > > > > TBR=noel@chromium.org,lucmult@chromium.org,adanilo@chromium.org > > > > # Not skipping CQ checks because original CL landed > 1 day ago. > > > > Bug: 992818 > > Change-Id: I94e63a873d4e2970d201a32dca0944a4e8fa520f > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116152 > > Reviewed-by: Luciano Pacheco <lucmult@chromium.org> > > Reviewed-by: Noel Gordon <noel@chromium.org> > > Commit-Queue: Luciano Pacheco <lucmult@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#752674} > > TBR=noel@chromium.org,lucmult@chromium.org,adanilo@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 992818 > Change-Id: I3e6a3a82ded4953ea6c9757c0b94b500cd21563f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128045 > Reviewed-by: Luciano Pacheco <lucmult@chromium.org> > Reviewed-by: Alex Danilo <adanilo@chromium.org> > Reviewed-by: Noel Gordon <noel@chromium.org> > Commit-Queue: Luciano Pacheco <lucmult@chromium.org> > Commit-Queue: Noel Gordon <noel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#754834} TBR=noel@chromium.org,lucmult@chromium.org,adanilo@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 992818 Change-Id: I55c7aaeaa2184c4433792c9538a9b23727d4d3c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135653Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#756565}
-
Joseph Kim authored
Details of this change can be found here: 2114014: Demo Mode: Display descriptive progress during Demo setup https://chromium-review.googlesource.com/c/chromium/src/+/2114014 Bug: b:148753805 Change-Id: Id101eb2dde6ed43939cc5012fb09982f1250d08e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136009Reviewed-by:
Patti <patricialor@chromium.org> Commit-Queue: Joseph Kim <josephkimsh@google.com> Cr-Commit-Position: refs/heads/master@{#756564}
-
Mei Liang authored
This CL setup the path to get a composed favicon from native for the group tab in tab switcher. Native currently has dummy implementation, so the group tab falls back to use a default favicon. Change-Id: I4707632a240f05f6b81aac314eaad198e8262e76 Bug: 1064153 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117649 Commit-Queue: Mei Liang <meiliang@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#756563}
-
Meredith Lane authored
To avoid the settings icon from being highlighted when a user enters the "text" into the Find In Page, the icon ligature "text_format" has been replaced with the relevant numeric code point. Bug: 1027612 Change-Id: Ic39f9dd05b7ee23cc4af568d40bf81feeb79e192 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133533Reviewed-by:
Katie Dektar <katie@chromium.org> Reviewed-by:
-
Darren Shen authored
Passing unique_ptr to AddChildView as recommended. Moved some default values to the header file too. Change-Id: I72f4ca718bf2ac55615a51072b97b970d254e8c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134175Reviewed-by:
Keith Lee <keithlee@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#756561}
-
Hiroshi Ichikawa authored
Simplify based on the fact that we can now assume that self.underlyingScrollView is never nil. Especially, simplify the properties preservation by deleting CRWPropertiesStore and simply assigning them from the old scroll view to the new scroll view. Bug: 1023250 Change-Id: I29e97ff154a92b1ec0ad9ea91d27bc7a393f4ecf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132892 Auto-Submit: Hiroshi Ichikawa <ichikawa@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#756560}
-
Alice Boxhall authored
This reverts commit a7c7613c. Reason for revert: Sorry, this seems to be causing test failures: https://ci.chromium.org/p/chromium/builders/ci/chromeos-kevin-rel/24801 Original change's description: > Reland "Remove launch service." > > This is a reland of d07c4196 > > TBR=ericwilligers@chromium.org > TBR=dominickn@chromium.org > > Original change's description: > > Remove launch service. > > > > BUG=1061843 > > > > Change-Id: I12efd2899403cb9cc5e9dafc04300a7156342ed9 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116156 > > Commit-Queue: Nancy Wang <nancylingwang@chromium.org> > > Reviewed-by: Nancy Wang <nancylingwang@chromium.org> > > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > > Reviewed-by: Eric Willigers <ericwilligers@chromium.org> > > Reviewed-by: Dominick Ng <dominickn@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#756170} > > Bug: 1061843 > Change-Id: I020be92154b0f5fad0d45f1f5c83f2d8539684d0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134036 > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: Eric Willigers <ericwilligers@chromium.org> > Reviewed-by: Nancy Wang <nancylingwang@chromium.org> > Commit-Queue: Eric Willigers <ericwilligers@chromium.org> > Cr-Commit-Position: refs/heads/master@{#756556} TBR=xiyuan@chromium.org,ericwilligers@chromium.org,dominickn@chromium.org,nancylingwang@chromium.org Change-Id: I5d1c9b2e82f3bbca4d482ab0909639ca553c81a2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1061843 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137099Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#756559}
-
Timothy Loh authored
Change-Id: I88c3e2ddbf86f19cc649fd5b7f442756309ce4aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134176 Commit-Queue: Timothy Loh <timloh@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#756558}
-
John Z Wu authored
It was pure coincidence that it worked in the past. Change-Id: I97d2b649055bf7ca527f5a8ad214252929d35f26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134777 Auto-Submit: John Wu <jzw@chromium.org> Commit-Queue: Hiroshi Ichikawa <ichikawa@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#756557}
-
nancy authored
This is a reland of d07c4196 TBR=ericwilligers@chromium.org TBR=dominickn@chromium.org Original change's description: > Remove launch service. > > BUG=1061843 > > Change-Id: I12efd2899403cb9cc5e9dafc04300a7156342ed9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116156 > Commit-Queue: Nancy Wang <nancylingwang@chromium.org> > Reviewed-by: Nancy Wang <nancylingwang@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: Eric Willigers <ericwilligers@chromium.org> > Reviewed-by: Dominick Ng <dominickn@chromium.org> > Cr-Commit-Position: refs/heads/master@{#756170} Bug: 1061843 Change-Id: I020be92154b0f5fad0d45f1f5c83f2d8539684d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134036Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#756556}
-
Matthew Warton authored
This will be used for loading specific container images during automated testing. This allows the images to be loaded using the same code paths in lxd and other system components rather than the current approach which is quite different from the way that users actually install Crostini. Design proposal at https://docs.google.com/document/d/1-T0tpU9szQxXVHtK_qXXG6JYjiQazQAQ28sIz8WNt_Q/edit#heading=h.5irk4csrpu0y Bug: None Change-Id: Ib4753fd1e4fd33b3207f0624e1325ffc7a742b7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135095Reviewed-by:
Nic Hollingum <hollingum@google.com> Commit-Queue: Matthew Warton <mwarton@google.com> Cr-Commit-Position: refs/heads/master@{#756555}
-
- 05 Apr, 2020 22 commits
-
-
Roman Aleksandrov authored
Create new method which helps to move showing condition from wizard_controller to dedicated screen classes. Bug: 1064561 Change-Id: I6f48ff86b959b91f3330e6e4d7512ced5061186b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120500 Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#756554}
-
chromium-autoroll authored
Roll ChromeOS orderfile from 83-4085.6-1584956258-benchmark-83.0.4097.3-r1 to 83-4091.0-1585562740-benchmark-83.0.4099.3-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-orderfile-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Iafae32b4184c1b3fe9681e794a128bfe97655c57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136419Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#756553}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ic44fedef6d378bca32c4dbf5591238dc50ea7ee2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136417Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/aa68109a592e..0ba30328d0ea git log aa68109a592e..0ba30328d0ea --date=short --first-parent --format='%ad %ae %s' 2020-04-05 fmalita@chromium.org [skottie] Corner pin effect 2020-04-05 mtklein@google.com the return of bit_clear Created with: gclient setdep -r src/third_party/skia@0ba30328d0ea If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC csmartdalton@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: csmartdalton@google.com Change-Id: Ic1843731516f5b5ffa8ad94ec845edfcd5c7f213 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136416Reviewed-by:
-
danakj authored
Currently only a renderer crash causes the test to fail, and a network process crash is not noticed but is a problem! Crash the browser when this happens in a web test so the test will fail. R=nasko@chromium.org Bug: 1067445 Change-Id: I070eeaa9865bbf5f23a72db35ae8a4ca181dc114 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136112Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#756550}
-
Gang Wu authored
TBR=msramek@chromium.org Bug:1062568 Change-Id: I49862b53e2d8a86928c11127a2f102c41dbfb57c No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: I49862b53e2d8a86928c11127a2f102c41dbfb57c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136884 Commit-Queue: Gang Wu <gangwu@chromium.org> Auto-Submit: Gang Wu <gangwu@chromium.org> Reviewed-by:
Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#756549}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/81dd8abf97e6..aa68109a592e git log 81dd8abf97e6..aa68109a592e --date=short --first-parent --format='%ad %ae %s' 2020-04-05 mtklein@google.com special-case overhaul 2020-04-05 michaelludwig@google.com Use the LICENSE provided by Microsoft Created with: gclient setdep -r src/third_party/skia@aa68109a592e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC csmartdalton@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: csmartdalton@google.com Change-Id: I4a6847666b56ee6afff8ac72f9234c77bb1f04cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136415Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 5356ce47. With Chromium commits locally applied on WPT: d0ad7cf8 "UpgradeInsecureRequest: Add WPTs for static-import in dedicated/shared workers" 2688e49a "De-flake two lazyload WPT tests." edb8adb1 "Implement and ship RTCRtpSendParameters.degradationPreference" 7e979350 "Handle k-rate AudioParam inputs for PannerNode" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I59546c23a39061c6304c8792e6a1b72bde0422c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136248Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#756547}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1f8a1d0e1e20..81dd8abf97e6 git log 1f8a1d0e1e20..81dd8abf97e6 --date=short --first-parent --format='%ad %ae %s' 2020-04-05 reed@google.com More infix for skvm, add poly() helper for polynomial evaluations Created with: gclient setdep -r src/third_party/skia@81dd8abf97e6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC csmartdalton@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: csmartdalton@google.com Change-Id: I2c2041fc306f3982ba63fff25abb87eb9aef8765 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136930Reviewed-by:
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: I811d70747cc9c9ab018e3023206a9a19b7ca1deb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136413Reviewed-by:
-
Saurabh Nijhara authored
This CL adds a new feature for using OOBE screen priority. The screen priority is used by the wizard controller to find out if advancing to the new screen is allowed. Only higher and equal priority screens can replace the current screen. This CL also makes the login display hosts to reuse the existing wizard controller object instead of creating a new one. Bug: 1064271 Change-Id: I5f8f2476a874457f80df666cf2b8cff7f512f93f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120583 Commit-Queue: Saurabh Nijhara <snijhara@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e63558923a2b..676162732328 Created with: gclient setdep -r src-internal@676162732328 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I5bb4e40cbc138a466acd2beabeaad7d09174911a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136929Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#756543}
-
Koji Ishii authored
This patch makes |NGFragmentItem| RefCounted. Bug: 982194 Change-Id: I04340c91b52ad4e274c70f3c99f8e4a3e32f4ad3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135672 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#756542}
-
Saurabh Nijhara authored
The test was based on the assumption that the wizard controller is recreated in the login display host and hence, had the expectations according to that. If instead the wizard controller object is reused, this test fails the expectations. We were set the device type in the class constructor and invoking the login wizard in SetUpOnMainThread(). Due to this, when the device type is changed to Chromebook in the test, the test assumed that invoking login wizard would recreate wizard controller with no HID screen. Hence, extracting out the test to a separate class and setting the device type to Chromebook in it's constructor. Bug: 1064271 Change-Id: I23e57dcedf3e1ea6d8e37bf8064784d8e27a5d9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135615 Commit-Queue: Saurabh Nijhara <snijhara@google.com> Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I293b9da8d2a74a61fee85f2f1c9a3dac6a52dcd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136927Reviewed-by:
-
Rainhard Findling authored
* SafetyCheckHandlerTest::CheckParentRanDisplayString tests that certain time offsets (like 24h) produce the right result. This necessarily breaks around DST time changes. As a result it started failing for a short time on March 30th, ~2 days after the DST change. * The updated test uses a hard-coded test time instead to not be affected by DST changes. Bug: 1066576 Change-Id: I5d311589d618f52ec54b90b6a37427d5ffd12edb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130269Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Rainhard Findling <rainhard@chromium.org> Cr-Commit-Position: refs/heads/master@{#756539}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a5efd68b524a..1f8a1d0e1e20 git log a5efd68b524a..1f8a1d0e1e20 --date=short --first-parent --format='%ad %ae %s' 2020-04-05 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version 2020-04-05 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go Deps Created with: gclient setdep -r src/third_party/skia@1f8a1d0e1e20 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC csmartdalton@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: csmartdalton@google.com Change-Id: I5dace144fc3ed172713308fe281487f78dd16c67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136835Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ifead155117e351e0c89b59bdcb10ad8a3f26888f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136830Reviewed-by:
-
rajendrant authored
Image metadata fetch logic is implemented for lazyload, but not used or experimented anymore. TBR=ryansturm@chromium.org Change-Id: Idec342219d54883f4a20bf54ac25c320bb123f35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125570 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
Scott Little <sclittle@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#756536}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: I3864aaa1d180fd52f9df862af5993edfa7f84f8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136841Reviewed-by:
-
Jinsuk Kim authored
TaskRecognizer is not used any longer. Delete the class using TabImpl.getActivity(), and the related codes around it. Bug: 952703 Change-Id: If66868faed48a01dc288915a313ccf715134891f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131166Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/10d86ab5dafa..a5efd68b524a git log 10d86ab5dafa..a5efd68b524a --date=short --first-parent --format='%ad %ae %s' 2020-04-04 michaelludwig@google.com Add license for include/third_party/d3d Created with: gclient setdep -r src/third_party/skia@a5efd68b524a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: michaelludwig@google.com Change-Id: I7f8de0d0f05c48437faf7fc778aba64aaff38e93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136458Reviewed-by:
-
- 04 Apr, 2020 5 commits
-
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/ad6d1b30e0f1..b8d47928094f git log ad6d1b30e0f1..b8d47928094f --date=short --first-parent --format='%ad %ae %s' 2020-04-04 bclayton@google.com Vulkan: Destruct the list of vk::Query in QueryPool Created with: gclient setdep -r src/third_party/swiftshader@b8d47928094f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I36b7b07fb8d89b60bf377619fb0c3ba7319f3a9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136457Reviewed-by:
-
Krishna Govind authored
TBR=benmason@chromium.org Change-Id: I5c1338168a47ebe31e75e041d3e15cdf578a6b4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136668 Commit-Queue: Krishna Govind <govind@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#756531}
-
Sarah Jochum authored
Relnotes: N/A Bug: 1067811 Test: browser_tests --gtest_filter="*SwitchAccess*" Change-Id: I68f8693716e0f16d4ed6f9b59dcab777a151a745 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136406Reviewed-by:
Anastasia Helfinstein <anastasi@google.com> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#756530}
-
Peng Huang authored
The GPU driver on bot win10 gtx1660 has been updated to the latest version. Let's enable the test to try it on that bot. TBR=cwallez@chromium.org Bug: 1066854 Change-Id: Ibc9d078f9a7bb96fe83f03ebada357b63b72bf04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136453Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#756529}
-
Harry Cutts authored
Looks like the target document was moved during review without the link being updated. Bug: None Change-Id: Ic4f376662c7909b7021d6c268d053448ce16906b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136110 Auto-Submit: Harry Cutts <hcutts@chromium.org> Reviewed-by:
Jason Chase <chasej@chromium.org> Commit-Queue: Jason Chase <chasej@chromium.org> Cr-Commit-Position: refs/heads/master@{#756528}
-
