- 18 Aug, 2020 40 commits
-
-
Rakina Zata Amni authored
This was previously used as a condition instead of a DCHECK because of crbug.com/1107269. Bug: 1107269 Change-Id: I16c814fb60b40bb508c8fa43fa91f41b27feb5af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359970 Auto-Submit: Rakina Zata Amni <rakina@chromium.org> Commit-Queue: Charlie Reis <creis@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#799260}
-
Maksim Sisov authored
The effort to have a single Linux config that can either use ozone/x11/wayland or non-ozone/x11 path revealed one problem with the "remoting" component. Basically, what we are doing is that we make use_x11 == use_ozone == is_linux. That means that we have 1) just one Linux config 2) user can switch to OzonePlatform by passing --enable-features=UseOzonePlatform. However, the condition to enable remoting is based on old assumption that is_linux == use_x11 && use_ozone != use_x11. Given that, the remoting targets are disabled and linux-rel bot starts to complain. Thus, as an initial remoting support on Ozone/Linux, make these targets compiled for is_linux regardless if it has ozone set or not. Further investigation and verification of the feature is required to close the bug. Bug: 1112776 Change-Id: I7d8c523c96d5f430b8f9891a4568894bd523f3d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362667Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#799259}
-
Mason Freed authored
This test already had a bug, in progress. TBR=schenney@chromium.org Bug: 1115661 Change-Id: Ic6205cc36b34f04c043e2bd6bd215fdcc60fde0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363354Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#799258}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/c2cee61d1ff6..abfdfbb66838 2020-08-18 bsheedy@chromium.org [Telemetry] Add Android emulator support If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1084352 Tbr: rmhasan@google.com Change-Id: Ie45bec0f5dd544834559709e8d5ed69d2ded6c4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363312Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#799257}
-
Dan Harrington authored
Added asserts for xsurface APIs that need to be called on the UI thread. For processViewAction(), I'm using postTask because the caller does not call on the UI thread. We can fix this on the other side of xsurface once it has a postTask API. Bug: 1117586 Change-Id: I16f298353f7a8f3999215f3aa2e667e7fa282398 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363352Reviewed-by:
Cathy Li <chili@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#799256}
-
Daniel Rubery authored
The SafeBrowsingNetworkContext is being profile-keyed, and this CL changes the PingManager to use the new per-profile NetworkContexts. Bug: 1049833 Change-Id: I70c068ad5a0a5b7008550c44ae61c2410c40b2ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358054Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#799255}
-
Anqing Zhao authored
To fulfill the requirement of accessibility settings page (secondary window in the Web Kiosk session), the fullscreen mechanism was replaced from using ash::WindowPinType::kTrustedPinned to SHOW_STATE_FULLSCREEN. See: https://chromium-review.googlesource.com/c/chromium/src/+/2170227. But this change introduced the visible shelf which should always be hidden. In this CL, one new conditional is added to forcedly hidden it based on the new mechanism. Bug: 1102359 Change-Id: I30c6b2f71089e924c6b8751c943cce1c4ce994b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359131 Commit-Queue: Anqing Zhao <anqing@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Anatoliy Potapchuk <apotapchuk@chromium.org> Cr-Commit-Position: refs/heads/master@{#799254}
-
Dan Harrington authored
See bug for detailed problem. This change adds a new signal sent to the feed component, informing that the feed is shown. This happens the first time feed content is seen, even if a card is hardly shown. Bug: 1117265 Change-Id: Ic0eb7fbb67a16b7f06554bc1ae48efa34662d106 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360600Reviewed-by:
Ian Wells <iwells@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#799253}
-
Alan Ding authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/63c9de2bf41a..bbd71acf57db $ git log 63c9de2bf..bbd71acf5 --date=short --no-merges --format='%ad %ae %s' 2020-08-06 stevenjb shill: add kErrorDisconnect for dropped wifi connections 2020-08-14 alanding system_api: Add "ignore_dev_conf" field to StartArcVmRequest 2020-07-06 cujomalainey system_api: remove mic position constant Created with: roll-dep src/third_party/cros_system_api Bug: b:159953121 Change-Id: I030dcd3e029893a4da8cffdb9dbead635cd155bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2361285Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Commit-Queue: Alan Ding <alanding@chromium.org> Cr-Commit-Position: refs/heads/master@{#799252}
-
Lily Chen authored
This change makes RestrictedCookieManager report a bad Mojo message and close the pipe when the URL setting a CanonicalCookie does not match the domain attribute of the cookie. The histogram Net.RestrictedCookieManager.SetCanonicalCookieDomainMatch was previously added to measure the frequency of mismatch. It was determined that mismatches occur very rarely, so it seems safe to enforce that the domains must match. This histogram is removed, since it has served its purpose. Bug: 996786, 1109832 Change-Id: I4456a2eb9d3449c89933a903ce3c038816f7018d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360316Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
David Schinazi <dschinazi@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#799251}
-
Olivier Yiptong authored
Enables Origin Trial for the Font Access API. Bug: 535764 Change-Id: I257a329c3bcb52696c043eebe2d809542733f6e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359470Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Commit-Queue: Olivier Yiptong <oyiptong@chromium.org> Cr-Commit-Position: refs/heads/master@{#799250}
-
Justin Donnelly authored
Currently it's possible to run all the Pedals code but not actually show the Pedals if the button row Feature is not enabled. This change makes the dependence of Pedals on button row explicit. Bug: 893183 Change-Id: Ib30cec31fa21e8dac138aa0341ace6bc8ea124ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362993 Commit-Queue: Orin Jaworski <orinj@chromium.org> Reviewed-by:
Orin Jaworski <orinj@chromium.org> Cr-Commit-Position: refs/heads/master@{#799249}
-
Anders Hartvoll Ruud authored
This CL adds support for expanding animation-timeline from the animation shorthand. As of [1], we support multiple shorthand expansions based on runtime flags, so there is no web-facing change to the animation shorthand (or anything else) unless the CSSScrollTimeline runtime flag is turned on. According to [2], we are supposed to omit the value from the shorthand serialization if doing so doesn't change the meaning of the overall value of the shorthand (i.e. if it's 'auto'). Unfortunately we generally don't adhere this guideline for the existing longhands, and are therefore not equipped to handle this as gracefully as I would like. For now I am checking for 'auto' "manually". Long term we might want to generalize this "skip-if-initial" mechanism somehow, since it has come up before [3], and will definitely come up again. Note that: - Animation::CSSValueFromComputedStyleInternal is the code responsible for the serialization used when calling getComputedStyle(elm).animation, and: - StylePropertySerializer::GetLayeredShorthandValue is the code responsible for the serialization used when calling (e.g.) elm.style.animation. The fact that we have two completely separate code paths for this is ... suboptimal, but that's a different story. [1] https://crrev.com/c/2250242 [2] https://drafts.csswg.org/cssom/#serializing-css-values [3] http://crrev.com/c/2241677 Bug: 1074052 Change-Id: I6f5266ca202276e78536a845835242181b8cd40a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358837 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#799248}
-
Noah Rose Ledesma authored
This change allows the MediaNotificationContianerImplView to dynamically respond to size changes of the audio device selector. This will be helpful in redesign of that UI in which the size of the view will vary. To facilitate communication between the device picker and the container a new delegate class was created. Because the container should support varying sizes, its observer class was modified to eliminate the notion of expanded vs unexpanded. Instead observers will be notified of a size change and should query the container for its new size. Bug: 1116694 Change-Id: Id832b77a4617645a6c48672670c22ccda88eab82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358890 Commit-Queue: Noah Rose Ledesma <noahrose@google.com> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#799247}
-
Brian Sheedy authored
Adds data dependencies to chrome_telemetry_test_without_chrome that are necessary to run Telemetry tests in an Android emulator. Bug: 1084352 Change-Id: I7ebdbf6ebee81b9cf67c1d2618d227540ff2c576 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360483 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#799246}
-
Ankit Kumar 🌪️ authored
Updated all direct instances of pp::Point to gfx::Point/gfx::Vector2d based on context. pp::Point is used to represent both a point as well as a 2D-vector. gfx provides two separate classes for point and 2D-vectors. Switching to them based on the context. The CL only migrates pp::Point without changing PDFEngine interface layer. In pepper model, we have used pp::Point to denote a point as well as a 2D vector. Based on the usage of the pp::Point migrate it to gfx::Point or gfx::Vector2d. A position is represented by gfx::Point while an offset is represented by gfx::Vector2d. Bug: 1101101 Change-Id: I7e6e4eba3ad141ac76b6590fe10286cd6b38aaae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327770Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
K. Moon <kmoon@chromium.org> Commit-Queue: Ankit Kumar
🌪 ️ <ankk@microsoft.com> Cr-Commit-Position: refs/heads/master@{#799245} -
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/1756465158d3..b6a272ffee65 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: If32a74b7c2bb70a7bc3486357ab6edfa3e1a06c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363187Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#799244}
-
Brian Sheedy authored
Adds the configurations for the upcoming GPU arm64 Mac CI builder + its manual trybot mirror. Submitted with no-try due to crbug.com/1117624 blocking submission. No-Try: True Bug: 1105648 Change-Id: Ie2e6edb623469f470da99389e07d51089d177a84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360555 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#799243}
-
Nicolás Peña Moreno authored
This CL adds some optimization to do an early return when we know that the PaintTimingDetectors are not going to do any work. This is the case when the documentElement is visible and there is some opacity:0 (as those paints are going to be ignored), as well as when the documentElement is invisible and there is an opacity:0 depth higher than 1. Bug: 1113723, 1113411, 1113067 Change-Id: If7a5a0224a89aa1da659b177da0d45d8dca30d57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360480Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#799242}
-
Naomi Musgrave authored
chrome/services/sharing/* - Introduced InitiateBandwidthUpgrade to request a higher-bandwidth connection for a particular endpoint chrome/browser/nearby_sharing/nearby_connections_manager* - Browser side usage of InitiateBandwidthUpgrade. NearbyConnectionsManager uses InitiateBandwidthUpgrade to request a higher connection data rate. This is triggered by the NearbySharingService receiving an incoming payload. Bug: 1076008 Change-Id: Iea1d38c4298aade06556b23baa6761cf51bb1da9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359140Reviewed-by:
Alex Chau <alexchau@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Commit-Queue: Naomi Musgrave <nmusgrave@chromium.org> Cr-Commit-Position: refs/heads/master@{#799241}
-
Sky Malice authored
TBR: nektar@chromium.org Bug: 1117594 Change-Id: Ie9af44ad9167823be6267ef866ace58038f07d28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363469Reviewed-by:
Sky Malice <skym@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#799240}
-
Nohemi Fernandez authored
Deprecated 'showMessage:' causes Chrome internal BUILD failures. Use [MDCSnackbarManager.defaultManager showMessage:] instead. Bug: 1117399 Change-Id: Ib7e187d685b53c625bfed785d1753afb3d22762d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362248Reviewed-by:
Yuwei Huang <yuweih@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#799239}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 93e63ac8. With Chromium commits locally applied on WPT: 4a594343 "Rename Unforgeable to LegacyUnforgeable." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=foolip@google.com No-Export: true Change-Id: I5778982ab0d225b2479279cf4ad03ed72b968f94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363188Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#799238}
-
chromium-internal-autoroll authored
Release_Notes:http://go/media_app-x20/relnotes/Nightly/media_app_202008180800_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/hLTZZ4vz2oQFQPe2pAvOkB6NqZ4vopQFwiRzac_A23YC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: media-app@grotations.appspotmail.com Change-Id: Ia86640450e02ae36feb816c6a617e608efa14a66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363059Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#799237}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/d5044cd209a6..9d0f7dea2a59 2020-08-18 treehugger-gerrit@google.com Merge "ui: fix bug when idle is not present in trace" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ic2de9037525394fa7f3316bbfe3d020bebd7b960 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363309Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#799236}
-
Domenic Denicola authored
This renames window.originIsolationRestricted to window.originIsolated per the latest spec changes. This largely amounts to massive test updates. window.originIsolationRestricted is retained as an alias for the duration of the origin trial so as to avoid breaking deployed code, and a wpt_internal test ensures this. Bug: 1103866 Change-Id: I4f570c79d19dc783d40beb3549d677555d1c81af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353013 Commit-Queue: Domenic Denicola <domenic@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#799235}
-
cfredric authored
study. This IDL annotation will automatically generate code to measure the entropy that can be used to establish users' cross-site identity using this API. Bug: 973801 Change-Id: Ib93b5421d0f63ff0158d5cf9b46d22dacda3c2a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356909 Auto-Submit: Chris Fredrickson <cfredric@google.com> Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Chris Fredrickson <cfredric@google.com> Cr-Commit-Position: refs/heads/master@{#799234}
-
Haoyue Wang authored
https://quiche.googlesource.com/quiche.git/+log/d2bf0ba74c74..e1e5e502ea64 $ git log d2bf0ba74..e1e5e502e --date=short --no-merges --format='%ad %ae %s' 2020-08-17 wub Move the implementation of GetReleaseTime from QuicBatchWriterBase to QuicGsoBatchWriter. No behavior change. 2020-08-17 dschinazi Deprecate quic_google_transport_param_omit_old 2020-08-17 renjietang Move OnZeroRttRejected() debug event from HTTP layer to QUIC transport layer. 2020-08-17 fayang Deprecate gfe2_reloadable_flag_quic_support_handshake_done_in_t050. 2020-08-14 wub Internal QUICHE change 2020-08-14 wub Default enable MTU discovery in QUIC server. Protected by --gfe2_reloadable_flag_quic_enable_mtu_discovery_at_server. 2020-08-14 fayang Stop blackhole detection when a duplicate ACK causes packets to be detected lost. Protected by existing gfe2_reloadable_flag_quic_default_enable_5rto_blackhole_detection2. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: Ic442251f8328e5bbfaaf84b1bf9aea211c28e413 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360926 Auto-Submit: Haoyue Wang <haoyuewang@chromium.org> Commit-Queue: David Schinazi <dschinazi@chromium.org> Reviewed-by:
David Schinazi <dschinazi@chromium.org> Cr-Commit-Position: refs/heads/master@{#799233}
-
Russ Hamilton authored
This is part of the identifiability study. Bug: 973801 Change-Id: I5a7105c77ffbaa68d0f61384b9700ab1337332d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357612Reviewed-by:
Nate Chapin <japhet@chromium.org> Commit-Queue: Russ Hamilton <behamilton@google.com> Cr-Commit-Position: refs/heads/master@{#799232}
-
Vladimir Levin authored
This patch is an optimization patch that ensures that we only update ancestor counters if we have crossed a style containment boundary. The update is required since otherwise counters and content fields that are separated by a style boundary don't behave correctly (we elide updating counters if there is no content present; and then we stop updates when they cross a style boundary). However, this update is only needed on the other side of the containment boundary (and indeed if there is a style containment boundary). R=chrishtr@chromium.org, futhark@chromium.org Bug: 1112978 Change-Id: I19e2e2c6132f1203c90a1e86a32a748a81066bd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363252Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#799231}
-
Daniel Hosseinian authored
Add a deprecation warning message for the "Save to Drive" destination under the destination select. Screenshot of change: https://imgur.com/ix1GjIB Bug: 1112581 Change-Id: Icecc4e90e97f0e4faae0ceca32e19fe10a5de51f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353555 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#799230}
-
Yi Gu authored
This UKM helps us to understand whether WebOTP increases phone number collection. We will first use UMA to analyze the portion of each bucket in the metric. If certain buckets have high volume, we need to turn to UKM for better understanding. See detailed design doc [1]. UKM collection review: https://docs.google.com/document/d/1xlV8thqJ3Vt_uYr0Dbi8PR_cctRzUXcDS2y1BiPGCm8/edit?usp=sharing [1] https://docs.google.com/document/d/1OPqPNY9l76kvaBPBCS5wbBQv2HNhmNlsDAcUvmYgyNI/edit#heading=h.xlif2jhriq2t Bug: 1107590 Change-Id: Ia6f87d35861879cfd586a20b2eb0e2baf31b9190 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359403Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#799229}
-
Ilya Sherman authored
This is essentially pulling https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2351775 into the Chromium repo, so that it can be maintained alongside the proto definition that it is parsing and formatting. R=mathias Bug: 1103854 Change-Id: I25707cf94678682d856f085b3aa259b02361dfa0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360517Reviewed-by:
Mathias Bynens <mathias@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#799228}
-
Akihiro Ota authored
When the system tray bubble updates, we should notify accessibility features too (namely switch access). with ChromeVox. Bug: 1105196 AX-Relnotes: N/A Test: Manual; test that bug is fixed for switch access and still works Change-Id: I5a48d43601502846de9b7acf934a02370d0b5c52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360558 Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#799227}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a8b16365f92a..a5a97b4858fb 2020-08-18 johnstiles@google.com Replace various C-style casts in SkSLCompiler with as<T>. 2020-08-18 johnstiles@google.com Mark helper functions as static to prevent external linkage. 2020-08-18 johnstiles@google.com Add as<StatementSubclass> to downcast Statements more safely. 2020-08-18 bungeman@google.com Fix SkBitmap::allocPixels logging 2020-08-18 scroggo@google.com Switch Skia's libjpeg-turbo used for testing to Chromium version 2020-08-18 johnstiles@google.com Add as<ExpressionSubclass>() to downcast Expressions more safely. 2020-08-18 robertphillips@google.com Enhance assert to dump more information 2020-08-18 johnstiles@google.com Fix constness of ExternalValue* inside ExternalValueReference. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC stani@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1116848,chromium:922430 Tbr: stani@google.com Change-Id: I3fa286b9f5e4df2ce4c1ef3eaa582ebad1208659 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363311Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#799226}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/5664586374b9..5cff4e3b5cf3 2020-08-18 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I8e3bb3f279e063b73a0f3e75c4479c087b86985f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363310Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#799225}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/b6a272ffee65..d5044cd209a6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I40a1f552f84035df0bb378f88cc34d8cb2785086 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363082Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#799224}
-
Daniel Hosseinian authored
Prepare destination select update status tests for cloud print deprecation messages, allowing for testing of when warnings are suppressed and not, while avoiding duplicating code. Bug: 1112581 Change-Id: I7cf97c9ed5a5629c7112c396b7219fcf1b2c23d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360115 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#799223}
-
Yuke Liao authored
This CL runs browser_tests on linux-lacros-rel to prevent regressions. Bug: 1116180 Change-Id: I5bf202bdbb368de6892267f08f913c8d6615e17d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363064Reviewed-by:
Sven Zheng <svenzheng@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#799222}
-
Tommy Li authored
This reverts commit a1d50a60. Reason for revert: Breaks here: https://ci.chromium.org/p/chromium/builders/ci/linux-bfcache-rel/7613 Original change's description: > webrtc: add wpt test that setCodecPreferences changes the sdp > > Adds a test which verifies that setCodecPreferences changes the > order of codecs in the SDP generated by createOffer. > > Drive-by: close all peerconnections after the tests, > https://bugs.chromium.org/p/chromium/issues/detail?id=836871 > > BUG=None > > Change-Id: I75d252bc43919ba2f27c6bd97493f94b3b5a2587 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362024 > Reviewed-by: Harald Alvestrand <hta@chromium.org> > Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com> > Cr-Commit-Position: refs/heads/master@{#799168} TBR=hta@chromium.org,philipp.hancke@googlemail.com,orphis@chromium.org Change-Id: I5c76ee9de7a660b14cfe56a4835ca4bcde59c432 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363471Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#799221}
-