- 26 Jun, 2019 40 commits
-
-
Avi Drissman authored
On the Mac, translate the z-order enum to the native window level values. On other platforms, treat everything other than "normal" as an undifferentiated "always on top" leaving open the possibility of implementing full window level support on ChromeOS later. There are six basic window levels. The "security sensitive" one is unused in this CL but will be used in a follow-up CL to fix a bug. BUG=865287, 869486 Change-Id: Icf3c39b79490a6490b7ad107a94cf5903d569777 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636606 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Leonard Grey <lgrey@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#672649}
-
Tina Wang authored
Put send tab to self icon to the left of other page action icons. Bug: 978520 Change-Id: I155ea9213ebe3405fa88f95e3c0b788cccd4c421 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676614 Commit-Queue: Tina Wang <tinazwang@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Tanya Gupta <tgupta@chromium.org> Cr-Commit-Position: refs/heads/master@{#672648}
-
Matt Wolenetz authored
Adds runtime experimental exposure of JS MediaSource constructor on workers context. This change does not include the actual constructor's implementation (later changes will add functionality behind this new feature flag). To differentiate from pre-existing JS MediaSource construction on the Window (blink main) thread, this change also adds a MediaSourceStable feature for use in the IDL for the constructor. This change also includes recording UMA for each execution context's thread type (window, dedicated worker, shared worker) that constructs a MediaSource instance. Anticipating the eventual need for recording a UseCounter in later changes to differentiate MSE objectUrl construction on main thread versus worker contexts, this change also includes the definition of that UseCounter. See the prototype combined full change (https://chromium-review.googlesource.com/c/chromium/src/+/1405697/) for expected usage of this new UseCounter from url_media_source.cc. Intent-to-implement: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/CNRywDqgKjY/F0nnA4tTAwAJ BUG=878133 Change-Id: I793a9d4f3a609352df773a96e3befd4d1bd66f5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674413 Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Auto-Submit: Matthew Wolenetz <wolenetz@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#672647}
-
Jazz Xu authored
Error handling for touchless controls. Bug: 976287 Change-Id: Ib28cbea20ec046745bdfe8caf240ceffea53c5cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663905Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Cr-Commit-Position: refs/heads/master@{#672646}
-
Alex Newcomer authored
Make sure the SBV corners are correct. Add a function to reset the state of the view before it is reshown. Bug: 976988 Change-Id: Ia726cc1244ba7a2cd47481a5dd67ed95734737ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677558 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#672645}
-
John Chen authored
This reverts commit af29dafa. Reason for revert: Perf test failures (https://crbug.com/978932) Original change's description: > heap: Enable unified GC scheduling > > This flips the default to enable unified GC scheduling where Oilpan's > numbers are reported to V8 and contribute to scheduling unified heap > GCs. No more Oilpan follow up or stand-alone GCs are scheduled unless > absolutely needed (e.g. worker teardown). > > This change may move around GCs. In the general case, there should be > less overall (Oilpan + V8) GC traffic at the expense of giving more > memory in scenarios where performance is needed. Scenarios that exhibit > memory pressure or can use idleness should preserve their memory > characteristics. > > Bug: 948807 > Change-Id: Iba0ffcf13830c4cfe3f8d5657098ea12bfd1ab04 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675425 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Hannes Payer <hpayer@chromium.org> > Commit-Queue: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#672409} TBR=haraken@chromium.org,hpayer@chromium.org,mlippautz@chromium.org Change-Id: I6f4d473c05211bbfc6389fa83d78c38f0666f15f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 978932, 948807 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1679244Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#672644}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/material-motion/motion-transitioning-objc/+log/8f360fc6f016..5bb0d577dd78 git log 8f360fc6f016..5bb0d577dd78 --date=short --no-merges --format='%ad %ae %s' 2019-06-26 featherless@google.com Merge branch 'release-candidate' into stable Created with: gclient setdep -r src/ios/third_party/motion_transitioning_objc/src@5bb0d577dd78 The AutoRoll server is located here: https://autoroll.skia.org/r/motion-transitioning-objc-chromium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:ios-internal-mdc TBR=bling-p10-rolls@google.com Change-Id: I5e6fd938f4e50565c0c5a5c6c7b2d5927425a611 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678781Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#672643}
-
Kristyn Hamasaki authored
Bug: 972256 Change-Id: Ib4aed2917ab444ca05451bf20647dab9196c1c11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678174Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Commit-Queue: Kristyn Hamasaki <khamasaki@google.com> Cr-Commit-Position: refs/heads/master@{#672642}
-
Sebastien Marchand authored
This is a reland of https://chromium-review.googlesource.com/c/chromium/src/+/1665913 A whitelist has been added to allow "bthprops.cpl" to fail to be delay loaded as the failure will be intercepted by bluetooth_init_win.cc -------- Original CL description ------------- This allows getting a crash report when failing to delay load a DLL. Example of the stack trace that this will provide: chrome_child!base::debug::BreakDebugger+0xc [C:\src\chrome\src\base\debug\debugger_win.cc @ 28] chrome_child!logging::LogMessage::~LogMessage+0x3f5 [C:\src\chrome\src\base\logging.cc @ 939] chrome_child!DllLoadHook+0x75 [C:\src\chrome\src\chrome\child\delay_load_failure_hook.cc @ 24] chrome_child!__delayLoadHelper2+0x13f [d:\agent\_work\3\s\src\vctools\delayimp\delayhlp.cpp @ 305] chrome_child!RtlUnwind+0x470 chrome_child!SkFontMgr::legacyMakeTypeface+0x13 [C:\src\chrome\src\third_party\skia\src\core\SkFontMgr.cpp @ 164] chrome_child!blink::DWriteVersionSupportsVariations+0x7f chrome_child!blink::WebFontTypefaceFactory::FontManagerForVariations+0xc Bug: 970893, 976241 Change-Id: I5a4981d81bcec92c4916481b5238a161bdb290f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676996Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#672641}
-
Henrique Grandinetti authored
Bug: 974002 Change-Id: I8658537c9557d686ab46bc2d57129cb74e23806b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1679136Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Henrique Grandinetti <hgrandinetti@chromium.org> Cr-Commit-Position: refs/heads/master@{#672640}
-
Peter Kasting authored
To avoid decreasing the supported platforms from today, this expands enable_hidpi from Linux (incl. CrOS)/Mac/Win to also include iOS. Bug: 564112 Change-Id: I246ea0dd25d93a174195489c2e388e3c7a890e8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670357 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#672639}
-
Natalie Chouinard authored
When this rule was previously added, it was narrowed to Preference Fragments, but there are other fragments in preferences (also instantiated via reflection), which extend the support library Fragment class directly. Tracking this change's binary size impact as part of the original regression tracker for this -keep flag. Bug: 978754, 972581 Change-Id: I9c5fe9c9bf621bad8755ecd8f677c840ed5ed32b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678941Reviewed-by:
Sam Maier <smaier@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#672638}
-
Tim Song authored
BUG=977535 Change-Id: Ic63e17a9ee2ddca1893b9e9f001870790c02068b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1679128Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#672637}
-
John Budorick authored
Tbr: bpastene@chromium.org Bug: 978773 Change-Id: Ida9e14a36eb16ced91a38e48771b4087d0d23556 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678943Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#672636}
-
Martin Kreichgauer authored
Currently, the cr-dialog key press handler only triggers an action button click when an enter keypress event has an 'CR-INPUT' target. This means that if a cr-input is embedded in another custom element inside the cr-dialog, enter key presses to that cr-input will be ignored because the corresponding event gets retargeted to the custom element. Instead, make the keypress handler check that the first element in the composedPath() is an 'INPUT'. Bug: 955859 Change-Id: I486158fadbc32b95c3c3284240bfe4ae690d78d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677597 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#672635}
-
Andrew Grieve authored
Moves initialization into ChromeApplication so that it will always happen in time. This was a regression introduced by a4c20235. TBR=agrieve # trivial refactor to a couple tests Bug: 978328 Change-Id: Iaf7c99b4d0c3e11f0419e076a5430f9a3cd48cda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677729Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#672634}
-
John Chen authored
Change-Id: I04675449d025bd2ad142c6ab1ef1e4d8cb36dc39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1679050 Auto-Submit: John Chen <johnchen@chromium.org> Reviewed-by:
Lan Wei <lanwei@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#672633}
-
Eric Orth authored
Used to trigger config update in SystemDnsConfigChangeNotifier on Android and ChromeOS where the update is triggered external to the network stack. Primarily needed for SystemDnsConfigChangeNotifier, but updated the current soon-to-be-modified code in NetworkChangeNotifierPosix to use the new unified method on DnsConfigService and removed its special DnsConfigService overrides in order to simplify and prepare for the transition to SystemDnsConfigChangeNotifier. Bug: 971411 Change-Id: I944073d4ff86e43aae40d0e1404a2cfbb1bb902a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1668147Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#672632}
-
Yue Zhang authored
Change the structure of tab_grid_card_item so that the close button zooms in with the card in drop-to-merge animations. Bug: 978642 Change-Id: Iba5b0e5c1269420615f20851934ca1f2710ef064 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677259Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@google.com> Cr-Commit-Position: refs/heads/master@{#672631}
-
Stephen McGruer authored
This is a code health CL which makes a number of changes: * Renames AnimationEffect::RepeatedDuration to ActiveDuration to align with the spec. * Adds a few links/descriptions to the AnimationEffect header. * Moves two functions in timing_calculations.h to the end, to properly group all spec-related functions and differentiate them from non-spec related. * Documents said moved functions. No behavior changes should be seen from this CL, its purely renames + comments. Bug: 630915 Change-Id: I8c9618212722d650ea009f54af0fa910214d3452 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678719Reviewed-by:
Kevin Ellis <kevers@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#672630}
-
Michael Lippautz authored
Disconnect ResizeObserver from media controls when the controls are hidden. Otherwise, the obervsers are have pending activities (are observed) which makes them roots for the object graph, ultimately keeping elements (including e.g. HTMLVideoElement) and nodes alive. Bug: 969049 Change-Id: I07a4470170f187631db307188f6cbe0052aa7d8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677053 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#672629}
-
Sungguk Lim authored
Use the new JSONReader::Read API that use the new API of base::Value (move semantic) and convert the surrounding code to the new API at the same time. Bug: 646113, 925165 Change-Id: I6d0a9e4d1f2131b756eb55fceb192153541695f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677846Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Sungguk Lim <limasdf@gmail.com> Cr-Commit-Position: refs/heads/master@{#672628}
-
Peter Wen authored
Allows editing files under components/module_installer/android/java/src-impl with Android Studio. Also lower verbosity for zip extraction (otherwise even a single -v is unreadable). Bug: 978011 Change-Id: Ia1df3871592d246b40f94c26da2803929d0ccda0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1679257 Auto-Submit: Peter Wen <wnwen@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#672627}
-
Wez authored
Bug: 945060 Change-Id: Ie9e85ef11bf47e8abbef5db96c5244ed7ccb1b9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1668072 Commit-Queue: Wez <wez@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Auto-Submit: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#672626}
-
Dana Fried authored
Now that PropertyHandler supports setting by value for complex assignable types, we can have flex specification treated the same as other properties of a view, and switch the way default values are handled by FlexLayoutEngine itself. The goal is to simplify code used with FlexLayout (and to a lesser extent, BoxLayout) by removing unnecessary heap allocations as well as streamlining API. Bug: 898632 Change-Id: I5ad7d235cb186e1f3aef6afd67ecac0e78baac4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1657388Reviewed-by:
Tim Song <tengs@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#672625}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/c57b0ee11c43..4d6951669cd8 git log c57b0ee11c43..4d6951669cd8 --date=short --no-merges --format='%ad %ae %s' 2019-06-26 oprypin@webrtc.org Don't use angle-bracket #includes for WebRTC's own files Created with: gclient setdep -r src/third_party/webrtc@4d6951669cd8 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I058c89d4b7ae74e22309ede3717a5c78df8491bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678262Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#672624}
-
May Lippert authored
When the list of users is disabled in chrome://settings/accounts, the disabled list should still show a scrollbar when scrolling. BUG=796119 Change-Id: If2765f939761b23b8393da634fdd46afb76e581a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676997 Commit-Queue: May Lippert <maybelle@chromium.org> Auto-Submit: May Lippert <maybelle@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#672623}
-
Becky Zhou authored
Update non emphasis url text to grey 700. Also update emphasized url text to grey 900. Bug: 968311 Change-Id: Iaf991c6a68151fc3dc6a989c531504adda395bfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677372 Commit-Queue: Becky Zhou <huayinz@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#672622}
-
Suzy Li authored
isUVPAA is currently implemented in AuthenticatorImpl.java by using fingerprintManager. GmsCore SDK v26 now provides its own implementation of isUVPAA as part of the FIDO2 APIs, so Clank should call that API instead. This is the third of three CLs for isUVPAA implementation that calls isUVPAA from FIDO2 Apis if using GmsCore SDK v26. If not, calls FingerprintManager. The first CL is here: https://chromium-review.googlesource.com/c/chromium/src/+/1671707 The second CL is here: https://chrome-internal-review.googlesource.com/c/clank/internal/apps/+/1409937/1 Bug: 976480 Change-Id: I02a802234ec1dbf4417d125c0b6cc7b3601c1b45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677548Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Suzy Li <suzyli@google.com> Cr-Commit-Position: refs/heads/master@{#672621}
-
Reilly Grant authored
This test is flaky on macOS. Bug: 978966 Change-Id: I2a5e9e387ba7870b2e8a6c5516c64aeb1dea0bee Tbr: pdr@chromium.org No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678850Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#672620}
-
John Rummell authored
On Android M devices, occasionally MediaDrm.getProvisionRequest() throws, resulting in a flaky test. Reenabling the test for all Android versions other than M. Bug: 973096 Test: reenabled test passes Change-Id: I87a78d737653cff3bd1a3727f0d673844cfa3db2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669176 Commit-Queue: John Rummell <jrummell@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#672619}
-
Karan Bhatia authored
This CL adds an early return to TestRunnerForSpecificView::SetIsolatedWorldInfo. This helps prevent a CHECK failure when a fuzzer provides invalid input. BUG=977801 Change-Id: If105f5d0e3502b7c67e72b5aa54447fbcef8d153 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673763 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Auto-Submit: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#672618}
-
Antonio Gomes authored
This is a reland of e2a060b2 Original change's description: > Use mojom-blink.h headers in blink/renderer/ > > ... instead of the respective mojom-shared.h variant. > > Today there is a mix of *mojom-shared and *mojom-blink.h usage > within third_party/blink/renderer. > > This CL replaces all instances of the former by the later, > except for one in renderer/modules/indexeddb, which seems to > require some more work. > > Next an amend on third_party/blink/PRESUBMIT.py will be done > to avoid further occurrences. > > TBR=dcheng@chromium.org > > BUG=973028 > R=haraken@chromium.org > > Change-Id: Ifab9a832c5435e37399e8d210b5c716daeba66ed > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658911 > Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#669501} TBR=dcheng@chromium.org,haraken@chromium.org Bug: 973028 Change-Id: Ic9fc503b3350da83b118fe9f95f71ab960957ac2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678173Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Auto-Submit: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#672617}
-
Lambros Lambrou authored
This fixes a problem where pausing the video-channel for several minutes sometimes resulted in frozen video. The problem was caused by signed int overflow when calculating the amount of "drops" to drain from the bucket, if time skips forward by a large amount, combined with a large bucket-drain rate. Test: Added new unittest which fails without the patch. Change-Id: I64d7640ab99f3fd2b13e0f5f1845ec3ddcf9fa9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678846 Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Auto-Submit: Lambros Lambrou <lambroslambrou@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#672616}
-
Matthew Webb authored
Clean up the enrollment handler, refactor sequence_checker, and use BindOnce for EnrollTemplate. Bug: 974046 Change-Id: I06ddd3caba96f335012cc6cd1c6aa250045b6ed0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678787 Auto-Submit: Matthew Webb <noviv@google.com> Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Commit-Queue: Matthew Webb <noviv@google.com> Cr-Commit-Position: refs/heads/master@{#672615}
-
Ben Pastene authored
Ran a led build after switching their recipe configs: https://ci.chromium.org/swarming/task/45ad9774aebf2610?server=chrome-swarming.appspot.com It's trying to read 'src/testing/buildbot/chrome.json'. This should take care of that. Bug: 938113 Change-Id: I20c88e6d66c4c3c6092f5449d40d6d50e80b1c2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678942 Commit-Queue: Ben Pastene <bpastene@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Auto-Submit: Ben Pastene <bpastene@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#672614}
-
Reilly Grant authored
This test is also crashing and timing out on other macOS platforms. Example: https://test-results.appspot.com/data/layout_results/WebKit_Mac10_13__retina_/16073/webkit_layout_tests/layout-test-results/results.html Bug: 976355 Change-Id: I6c11cfd7986c2881153bd25e434c40ff365e3117 No-Try: true Tbr: eae@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1679217 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#672613}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/677090083dad..02f19d2102ab git log 677090083dad..02f19d2102ab --date=short --no-merges --format='%ad %ae %s' 2019-06-26 treehugger-gerrit@google.com Merge "Added video marker flags" Created with: gclient setdep -r src/third_party/perfetto@02f19d2102ab The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Ic0954f65d25c4e5c84b05781ce541fcea5c004cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678261Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#672612}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/615ae1a71646..cc82c3f0f1e0 git log 615ae1a71646..cc82c3f0f1e0 --date=short --no-merges --format='%ad %ae %s' 2019-06-26 timvp@google.com Vulkan: Enable VertexAttributeTest* for ES3_Vulkan 2019-06-26 jmadill@chromium.org Vulkan: Refactor DynamicBuffer::init. 2019-06-26 syoussefi@chromium.org Vulkan: Output buffer memory barrier in graph dump 2019-06-26 aleino@nvidia.com Use D3D11 GetDimensions driver workaround for dynamic images Created with: gclient setdep -r src/third_party/angle@cc82c3f0f1e0 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=syoussefi@google.com Change-Id: I94ba5a5b6d6581a431fe705adfdde0deab949025 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678783Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#672611}
-
Christy Chen authored
In previous change https://chromium-review.googlesource.com/c/chromium/src/+/1600375, some strings are wrapped inside placeholders ${} in string literals for localization purposes. However, rjsmin couldn't process nested string literals properly so the white-spaces after commas or periods would get trimmed off. It causes the issue where words cannot break to the next line when Audits page resized, and leaves unwanted extra space. This change works around the issue by pulling the string with comma out to a variable to prevent nested string literal. Before fix: https://imgur.com/uMjr5Bp After fix: https://imgur.com/a/X5wq6Xo More details on the rjsmin issue: https://bugs.chromium.org/p/chromium/issues/detail?id=973285 Bug: 972969 Change-Id: I4b4cf243df0ce74c400e488f6c6b98595cf4ecca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655913 Commit-Queue: Christy Chen <chrche@microsoft.com> Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#672610}
-