GitLab

Bug: 818560
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ic201866380d80d40fa967a2f52342c9c81f656c2
Reviewed-on: https://chromium-review.googlesource.com/972741Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544730}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/ad47b297..b2c284af

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: Ie82580084359358ccb6e9cdb95e6416a72c50430
Reviewed-on: https://chromium-review.googlesource.com/973190Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544729}

Worklist is general concurrency-friendly data structure for building and
processing work.

It is built on segments that are either kept thread-locally or in a
global pool. It thus works well for incremental scenarios that don't
want to allocate huge batches of memory on the fly as well as concurrent
processing requiring work stealing.

Bug: chromium:757440
Change-Id: Iacf48c3d2d7a334bd750c3752a114fdc034b4ac7
Reviewed-on: https://chromium-review.googlesource.com/973304Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544728}

Bug: 821360
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I5665d51929d483f5f94130cffec9dd3fad601608
Reviewed-on: https://chromium-review.googlesource.com/971704Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544727}

BUG=823578
TBR=riajiang@chromium.org,sadrul@chromium.org,kenrb@chromium.org

Change-Id: Id67a578a183ad65a80f9a72f610cf554c164cd12
Reviewed-on: https://chromium-review.googlesource.com/973605
Commit-Queue: Alexander Potapenko <glider@chromium.org>
Reviewed-by: Alexander Potapenko <glider@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544726}

Make the list title a heading level 2

Bug: 820466
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ibc910786a94163da186671bc247670cb6d6a5d53
Reviewed-on: https://chromium-review.googlesource.com/964944Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544725}

TSan suppressions can't be applied to memory allocation stacks in
the reports, only to memory access stacks.
Therefore suppress the access that occurs in base::debug::SetCrashKeyString()

BUG=794920
TBR=rsesek@chromium.org

Change-Id: I607bf4f13af69eade9a5c745d556a615f4c2d1c2
Reviewed-on: https://chromium-review.googlesource.com/972984Reviewed-by: Alexander Potapenko <glider@chromium.org>
Commit-Queue: Alexander Potapenko <glider@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544724}

This reverts commit b93f6ee5.

Reason for revert: Reverting showed the relevant metrics regressed, so this change did have the expected improvement.

Original change's description:
> Revert "Cache brand code on Windows."
> 
> This reverts commit 9dd1ef42.
> 
> Reason for revert: Latest canary data did not have expected recovery on Omnibox.CharTypedToRepaintLatency and had a regression on Omnibox.CharTypedToRepaintLatency.ToPaint. Reverting to see if that movement is related to this CL or whether there were other changes in the meanwhile.
> 
> Original change's description:
> > Cache brand code on Windows.
> > 
> > Querying the registry is expensive and contributes to start up time,
> > omnibox query time and idle. Since the brand code is not expected to
> > change on Windows during the course of a session, this CL caches
> > the value, so that future queries are free.
> > 
> > This should restore the Omnibox perf that regressed by
> > https://chromium-review.googlesource.com/c/chromium/src/+/824363
> > and also improve perf elsewhere since the caching is now done at
> > a lower level than that change. Since this is expensive only on
> > Windows, the caching is done in the Windows codepath only.
> > 
> > Bug: 816698, 806130
> > Change-Id: I458fad29f18b1b1ff2d55b9334ae733fa448eec9
> > Reviewed-on: https://chromium-review.googlesource.com/947522
> > Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
> > Reviewed-by: Peter Kasting <pkasting@chromium.org>
> > Reviewed-by: Greg Thompson <grt@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#541009}
> 
> TBR=pkasting@chromium.org,asvitkine@chromium.org,grt@chromium.org
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Bug: 816698, 806130
> Change-Id: I09e12c17011f72f25ecb369ca3075e2067013f8a
> Reviewed-on: https://chromium-review.googlesource.com/958012
> Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#542506}

TBR=pkasting@chromium.org,asvitkine@chromium.org,grt@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 816698, 806130
Change-Id: Id70bcaa6be1e91240010e74990dd2bd81d673258
Reviewed-on: https://chromium-review.googlesource.com/973581Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544723}

When download is restarted after the failure the progress should be 0%.
This CL fixes the bug where download UI displayed 100% progress after
restarting the failed download.

Bug: 823968
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ia44961f9602ea76b0a731bae1829d48fa5fc533f
Reviewed-on: https://chromium-review.googlesource.com/972575Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544722}

Overlapped WriteFile() operations on named pipes do not report partial-
completion, so simplify the mojo::edk::ChannelWin implementation by
removing the partial-completion logic.

Bug: 821903
Change-Id: Iaa7132e86d7e88b097b4243342eccfe3959c7e69
Reviewed-on: https://chromium-review.googlesource.com/972625
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544721}

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I0d17c9f78e79f22aa54580eeea488583e7b5b080
Reviewed-on: https://chromium-review.googlesource.com/972644Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544720}

This changes the direction you need to scroll to increase the size of
the content window to match the spec.

It also adds sounds for repositioning (and introduces a struct ot hang
onto a bunch of sounds).

Bug: 799270
Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ifa538a70575e8c508db07d9d12d588e3ecbabc6e
Reviewed-on: https://chromium-review.googlesource.com/973263
Commit-Queue: Ian Vollick <vollick@chromium.org>
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544719}

Using OCMock was failing on devices but passing on simulator.
This CL uses a more reliable fake/test object rather than a mock.

Bug: 819658
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I101c7b0380a13f9972789b99bb88d4dcc52d7b59
Reviewed-on: https://chromium-review.googlesource.com/972664Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544718}

BridgedContentView can and should be first responder when a browser chrome
element is focused, but was changed to always respond |NO| to
|acceptsFirstResponder| in https://chromium-review.googlesource.com/c/chromium/src/+/670479

This doesn't prevent it from being made first responder explicitly, but
is meant to prevent mouse-clicks on non-interactable chrome from stealing
focus from web content*

Unfortunately, when ordering a window in, if the window's first responder
claims not to accept first responder, AppKit finds one which will.
I don't think this is reproable in normal use, but it breaks some
interactive_ui_tests.

This change is a variation on a comment tapted@ made on the original CL.
Now, we only claim to accept first responder if we are already first
responder.

* Though I can't actually repro this by changing the method to always
return |YES|, so who knows.

Bug: 822824
Change-Id: I7ed3334f5ddd8ef9334acb13f6b6ea71529b0196
Reviewed-on: https://chromium-review.googlesource.com/971945
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544717}

Update luci.chromium.{ci,try} defaults to use "cores:8" dimension.
Update builders and mixins not to specify default values for cores, cpu
and pool dimensions.

Update some Mac GPU/Angle builders and mixins to use cores:4 or clear
cores requirement because we have 4-core or a mix of 4-core and 8-core
Macs.

R=dpranke@chromium.org, kbr@chromium.org, tandrii@chromium.org
No-Try: true

Change-Id: I370a004c2c07e450a6c1426e5f7419b00d882536
Reviewed-on: https://chromium-review.googlesource.com/970907Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544716}

Bug: 758630
Change-Id: I6cfe03cb7f2fd2d210ee370554af4044a10cfb59
Reviewed-on: https://chromium-review.googlesource.com/973183Reviewed-by: Ashley Enstad <ashleymarie@chromium.org>
Commit-Queue: Emily Hanley <eyaich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544715}

The method require heap access for every single check so it should live
on Heap.

Bug: chromium:757440
Change-Id: Id9f4530bbd488b2e23e64c0f959427ad662d72fa
Reviewed-on: https://chromium-review.googlesource.com/973307Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544714}

As the experiment was successful we are now proceeding with the launch
of the overflow icons. This switches them on by default.

BUG=763301

Change-Id: If3f2cf5dc4537a7fa700c56775827ccb4cd4663d
Reviewed-on: https://chromium-review.googlesource.com/970342
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544713}

Cancel dialogs before destroying their View.

Bug: 821443
Change-Id: Ifb0eb47cc60efa3e0b7e6354754d5db0fef38cda
Reviewed-on: https://chromium-review.googlesource.com/969584Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Amirhossein Simjour <asimjour@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544712}

This regressed in be35cd67

Bug: 824141
Change-Id: I7975bc8dffbfafeec7f0a50bad4d75dfeefff0ee
Reviewed-on: https://chromium-review.googlesource.com/973383
Commit-Queue: agrieve <agrieve@chromium.org>
Reviewed-by: Paul Jensen <pauljensen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544711}

The bot is using ToT clang (by setting LLVM_FORCE_HEAD_REVISION
when running hooks), but it wasn't setting the corresponding gn flag.

Currently this was causing the builds to fail due to not suppressing the
new -Wignored-pragma-optimize warning in tip-of-tree clang.

Bug: 495204
Change-Id: I857faf0dfb149a938f892187e9830e9b030c82cf
Reviewed-on: https://chromium-review.googlesource.com/973284Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544710}

Modify HpackEntry::GetDebugString() to use SpdyStringPrintf instead of
the "+" concatenator. Some benefits:
  - Avoid the cost of the "+" operator.
  - Improve readability, slightly.
  - Avoid non-shared string methods.

This CL lands server changes 187876536 by dlj and 189639795 by diannahu.

BUG=488484

Change-Id: Ieb2dc7840460a4b7d38628a2e7c07440d4268139
Reviewed-on: https://chromium-review.googlesource.com/972431Reviewed-by: Helen Li <xunjieli@chromium.org>
Commit-Queue: Dianna Hu <diannahu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544709}

https://pdfium.googlesource.com/pdfium.git/+log/9a635e812788..a17ac192c043

$ git log 9a635e812..a17ac192c --date=short --no-merges --format='%ad %ae %s'
2018-03-21 hnakashima Explain how CPDF_Page::GetDisplayMatrix() inverts y.
2018-03-21 thestig Fix some param names in the public API.
2018-03-21 thestig Change FXSYS_RGB() to FXSYS_BGR().
2018-03-21 thestig Change FXSYS_Get{R,G,B}Value()'s input param to BGR.

Created with:
  roll-dep src/third_party/pdfium


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I44753f4c9360d3816f38f60622e5d3cef55abddd
Reviewed-on: https://chromium-review.googlesource.com/973462
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#544708}

Bug: 822908
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Iea189976c26ace0de8ff3461aef84ac2be01fc50
Reviewed-on: https://chromium-review.googlesource.com/972325
Commit-Queue: Danyao Wang <danyao@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544707}

It's used only by the browser process, so doesn't need to be in the main
dex.

Bug: 820570
Change-Id: I3f02e1f2d1255452f474db306e68583f8c7200e6
Reviewed-on: https://chromium-review.googlesource.com/971343
Commit-Queue: Peter Beverloo <peter@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544706}

Plumbs it through from client to service side. We track some
TextureMetadata on the service side. I've opted to keep the separate
from the per level metadata that TextureManager tracks. This will be
used in future CLs that implement TexStorage2D and BindTexImage2D.

Left a TODO for more validation in CreateAndConsumeTexture for
validation of BufferUsage and ResourceFormat because it can't be tested
until we implement TexStorage2D and/or BindTexImage2D.

Bug: 789238
Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I6012c0351b69eb86504102aba6bff94afe07d3e7
Reviewed-on: https://chromium-review.googlesource.com/963285Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: weiliangc <weiliangc@chromium.org>
Commit-Queue: Jonathan Backer <backer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544705}

Destroy WebRtcEventLogManager rather than leak it, so as to deflake
unit tests.

Bug: 823318
Change-Id: Ibe255217eafe13569e1d86091dc71929adbaf646
Reviewed-on: https://chromium-review.googlesource.com/968874
Commit-Queue: Elad Alon <eladalon@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Tommi <tommi@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544704}

Related to crrev.com/i/480972 and crrev.com/c/973229.

Bug: 516021
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I61578ae5d44d7b61b40ae5b4a6e1df9ac923137c
Reviewed-on: https://chromium-review.googlesource.com/973303
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544703}

|embed_token_| explains better what this field is used for, so use that
name instead of |nonce_|. Update the doc to include a little more info.

BUG=none

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: Ib292618377b7ccc75204cf15096b7544bd120c50
Reviewed-on: https://chromium-review.googlesource.com/972341Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544702}

https://skia.googlesource.com/skia.git/+log/f3015114b51e..0e2eeee3bcf0

$ git log f3015114b..0e2eeee3b --date=short --no-merges --format='%ad %ae %s'
2018-03-20 robertphillips Move DDL TSAN bot to Release & add Release DDL ASAN bot

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=jvanverth@chromium.org

Change-Id: I06b9b7cec1ade8ac174b1ecf668ac2f4f66a3b7e
Reviewed-on: https://chromium-review.googlesource.com/973262Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#544701}

Since dgn@ does not work on Chrome anymore, this change updates the bug
link to add agrieve@ as the bug owner.

Bug: NONE
Change-Id: I00d5de07d8b329d1f95856f3c0582a7f35b0054f
Reviewed-on: https://chromium-review.googlesource.com/973204
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: agrieve <agrieve@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544700}

Remove ability to implicitly convert between mojo type string and
base::string16

See 86836ab2

Bug: 816970
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I5633ff8d5b6bba56ea568d0f49a38d1d4157b6b1
Reviewed-on: https://chromium-review.googlesource.com/965453Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544699}

There's a crash happening when a JSRunner associated with a context
(which is checked to be valid) somehow doesn't exist. This shouldn't
happen, but somehow is. This patch adds checks that if a context is
considered to be valid, it has an associated JSRunner.

This also slightly reorders tear down flow in order to match this
requirement, putting context invalidation prior to JSRunner deletion.

Bug: 819968

Change-Id: I0e0d634f3e8c910cf50a157dfa367119be522d9a
Reviewed-on: https://chromium-review.googlesource.com/972571Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544698}

It can take an order of magnitude more time to spin a message loop and
handle a result asynchronously than it does to handle the same result
synchronously, and tests were timing out as a result. Placing a limit
on async results will hopefully reduce the number of fuzzers using
FuzzedSocket that time out.

Bug: 823012
Change-Id: I110fbf2ce0b96cce12cb84ea21c3f44e6b45005b
Reviewed-on: https://chromium-review.googlesource.com/972377
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544697}

BUG=787020
TBR=dpranke

Change-Id: Icd2361485c27486ef4676ea9c8725bf959d36a21
Reviewed-on: https://chromium-review.googlesource.com/972448Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544696}

This CL adds a unit test for PasswordManagerPresenter (which provides
passwords for exporting on desktop and Android), checking that
blacklisted passwords are not included among those being exported.

Bug: 819138
Change-Id: Ia63eac7abc20179c3f2775186bf11cefdd36f86a
Reviewed-on: https://chromium-review.googlesource.com/971101Reviewed-by: Christos Froussios <cfroussios@chromium.org>
Commit-Queue: Vaclav Brozek <vabr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544695}

BUG=812950

Change-Id: Ic729b195d151480e2123fe490df8d6cce89a3198
Reviewed-on: https://chromium-review.googlesource.com/969333Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544694}

Adds sort key handler for isHigh which will allow users to sort by
"isHigh" when using chrome://media-engagement.

BUG=792906

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I11db5ddf4843faca361eb9016535d582e6230fa5
Reviewed-on: https://chromium-review.googlesource.com/970584Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544693}

Starting from Android O it is no longer possible to run any of the
processes isolated. However, it is not necessary if SELinux is in
permissive mode, which the orderfile generator sets (see
tools/cygprofile/profile_android_startup.py in _SetUpDevice).

This CL therefore removes the orderfile-specific changes to the android
manifest for all builds.

Bug: 758566
Change-Id: If3a8e0a3f0dfe81b034b4e0b080db53f661ef265
Reviewed-on: https://chromium-review.googlesource.com/970660Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Benoit L <lizeb@chromium.org>
Commit-Queue: Matthew Cary <mattcary@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544692}

This prevents ScrollbarTestWithVirtualTimer from polluting global state
for tests following it.

Bug: 791742
Change-Id: Iae3440451833408a6a5bd24b3319b307cd6d3547
Reviewed-on: https://chromium-review.googlesource.com/969582
Commit-Queue: David Bokan <bokan@chromium.org>
Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544691}