- 18 Sep, 2018 40 commits
-
-
Tom Anderson authored
BUG=882854 R=pkasting Change-Id: I8dc419e43882d723a117da19e87abe20505aa01a Reviewed-on: https://chromium-review.googlesource.com/1228201 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#592148}
-
Nico Weber authored
Ports the changes to memory_monitor_linux.cc in https://codereview.chromium.org/2321313002/ to Windows. Bug: 404525 Change-Id: Ibb92bb419292b0dd7298ad8c3ce7ae5268e6000a Reviewed-on: https://chromium-review.googlesource.com/1231673 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#592147}
-
Ryan Hansberry authored
In the process, this also adapts HostConnectionMetricsLogger to use the MultiDevice APIs to properly log to the "Background" versions of its metrics. Bug: 824568, 752273, 854885, 857302 Change-Id: I77fc52b3d07d903fe61ac62de2620216984d28de Reviewed-on: https://chromium-review.googlesource.com/1117897Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#592146}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/804797362e1d..1aa405fd859a git log 804797362e1d..1aa405fd859a --date=short --no-merges --format='%ad %ae %s' 2018-09-18 sergiyb@chromium.org Add an option to disable adding CC emails automatically 2018-09-18 nodir@google.com [gclient] Fix typo in get_gerrit_patch_root 2018-09-18 nodir@google.com [bot_update] Add gclient.get_gerrit_patch_root 2018-09-18 vadimsh@chromium.org [cipd] Pin hashes of CIPD packages. 2018-09-18 borenet@chromium.org Revert "gerrit_util: Support OAuth2 bearer tokens in CookieAuthenticator" Created with: gclient setdep -r src/third_party/depot_tools@1aa405fd859a The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:878303,chromium:694348,chromium:694348,chromium:870166 TBR=agable@chromium.org Change-Id: I439b74e4283ec9962446dd2b14a101175f7fbb4d Reviewed-on: https://chromium-review.googlesource.com/1231496Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#592145}
-
Robert Flack authored
A few changes were needed to get this to work in BGPT: - Create a StubChromeClientForSPv2 so that we have a LayerTreeHost, without which BGPT does not create composited animations. - Change StubChromeClientForSPv2 to tell the LayerTreeHostEmbedder to use layer lists when running with BGPT - Check for filter animations as well as current filters when deciding if we need a filter on a given object. Bug: 874253 Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I7e057d8a225ead67728d68070e62ac62f7a33f19 Reviewed-on: https://chromium-review.googlesource.com/1230438 Commit-Queue: Robert Flack <flackr@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#592144}
-
Andrew Grieve authored
Change-Id: Iaa78ac6b6ad9050479c0e326e36c80cabb9800f3 Reviewed-on: https://chromium-review.googlesource.com/1231386Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#592143}
-
David Black authored
There are instances in which we want links to be able to open new tabs in the browser. With this change, they will be able to do so by specifying target="_blank". Bug: b:115782814 Change-Id: Id4a08c5fbde342c723f47e363c9cf97e76f1578e Reviewed-on: https://chromium-review.googlesource.com/1227502Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#592142}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/892036cb879f..cb44953479a1 Created with: gclient setdep -r src-internal@cb44953479a1 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:856278 TBR=mmoss@chromium.org Change-Id: Ie53026c25d38525322ffee7ac6c19f6f601acf20 Reviewed-on: https://chromium-review.googlesource.com/1231495Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#592141}
-
Weilun Shi authored
When there are multiply profiles opened at the same time. The renderer creation process will be called multiple times which might cause incorrect behavior. Make sure the renderer created only for the corresponding profile. Bug: 847606 Change-Id: I4d47d22220cab2197ad59feedacd3e6a5bc0dabb Reviewed-on: https://chromium-review.googlesource.com/1229193Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Weilun Shi <sweilun@chromium.org> Cr-Commit-Position: refs/heads/master@{#592140}
-
Vladimir Levin authored
This patch disambiguates two functions: - SetDescendantNeedsPaintPropertyUpdate, which is a breadcrumb - SetSubtreeNeedsPaintPropertyUpdate, which is a dirty bit By renaming the latter to: SetSubtreeNeedsForcedPaintPropertyUpdate. R=chrishtr@chromium.org, pdr@chromium.org Change-Id: Ia00d845fc114e1eef94987a650b453e363d431cd Reviewed-on: https://chromium-review.googlesource.com/1231384Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
-
Ben Pastene authored
Cycle time looks good. (Caps out at about 30min for analyze exclusions.) Flake rate looks like it's pretty much 0. Though the bot is currently red due to a broken webrtc roll (that this bot would have caught). Need to wait on reverting that before this can land. Bug: 646404 Change-Id: I26ddec32ad1b90165068c0c17946c2ac6cdc330b Reviewed-on: https://chromium-review.googlesource.com/1229076Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#592138}
-
Erik Chen authored
This CL removes the flag kCheckLayoutTestSysDeps and modifies Content Shell to run CheckLayoutSystemDeps for layout tests. Previously, run_web_tests.py would first run Content Shell with kCheckLayoutTestSysDeps to check system dependencies, and then subsequently run Content Shell with kRunWebTests to run the actual layout tests. The goal was for the former step to discover system misconfigurations and early-exit so that developers would not lose time debugging system configuration failures. This CL's changes has several benefits: * kCheckLayoutTestSysDeps was using a different mechanism for starting and stopping the main thread's run loop. This was likely responsible for flaky crashes. * run_web_tests.py would exit with SYS_DEPS_EXIT_STATUS upon encountering a crash in kCheckLayoutTestSysDeps. This failure was not recoverable. Now, flaky crashes are caught using the normal layout test runner mechanism, and are appropriately retried. * It simplifies the logic for both Content Shell [removing a flag] and web_test_runner.py [removing yet another mechanism for launching the driver and parsing its results]. Bug: 884776 Change-Id: I7472f5e3b90e6d2578d2ed0be906e0e57ae9dbaa Reviewed-on: https://chromium-review.googlesource.com/1229240 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:Emil A Eklund <eae@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#592137}
-
Michael Nye authored
Bug: b/80441180 Change-Id: I66bd3265c724229c818d54289479c6262a2e28a9 Test: Ran on device Reviewed-on: https://chromium-review.googlesource.com/1148803Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Michael Nye <michaelnye@chromium.org> Cr-Commit-Position: refs/heads/master@{#592136}
-
Fan Yang authored
Turn on FLAGS_quic_reloadable_flag_quic_fix_is_useful_for_retrans https://chromium-review.googlesource.com/c/chromium/src/+/1228857 Update IETF QUIC Transport Error codes The IETF QUIC transport error codes are updated to reflect version 14 of the QUIC transport IETF draft: - SERVER_BUSY is added - FRAME_FORMAT_ERROR is changed to FRAME_ENCODING_ERROR - UNSOLICITED_PONG is removed - INVALID_MIGRATION is added Merge internal change: 213016352 https://chromium-review.googlesource.com/c/chromium/src/+/1228548 Fix a ACK frame reporting issue caused by unsigned integer wrap around. Protected by flag FLAGS_quic_reloadable_flag_quic_aggregate_acked_stream_frames_2. Flag FLAGS_quic_reloadable_flag_quic_aggregate_acked_stream_frames_2 is the v2 of the existing flag FLAGS_quic_reloadable_flag_quic_aggregate_acked_stream_frames. Merge internal change: 212991266 https://chromium-review.googlesource.com/c/chromium/src/+/1228894 Implement support for framing QuicCryptoFrames from IETF QUIC. Merge internal change: 212917548 https://chromium-review.googlesource.com/c/chromium/src/+/1228436 Turn on FLAGS_quic_reloadable_flags_quic_fix_reset_zombie_streams in quartc. Merge internal change: 212810521 https://chromium-review.googlesource.com/c/chromium/src/+/1228435 In QUIC, fix a bug that zombie streams cannot be closed when gets reset locally. Protected by FLAGS_quic_reloadable_flag_quic_fix_reset_zombie_streams. Merge internal change: 212676554 https://chromium-review.googlesource.com/c/chromium/src/+/1228434 Split QUIC's FramerVisitor into two methods, OnAckRange and OnAckFrameEnd(). No functional change, not flag protected. Merge internal change: 212629799 https://chromium-review.googlesource.com/c/chromium/src/+/1228394 Move multiple (repeated) definitions of QuicConnectionArena to a single place in quic_one_block_arena.h. Move only, not protected. Merge internal change: 212626492 https://chromium-review.googlesource.com/c/chromium/src/+/1228393 Change-Id: I675e3fbaa9c01aa3e5749f44323ddac6eb45a9d8 Reviewed-on: https://chromium-review.googlesource.com/1228858Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Fan Yang <fayang@chromium.org> Cr-Commit-Position: refs/heads/master@{#592135}
-
Camillo Bruni authored
The new benchmark takes all the metrics from the v8.browsing benchmarks and provides an additional --enable-rcs to switch on the more expensive runtime call stats metrics. - Introduce new _LoadingBaseClusterTelemetry base class - Introduce AugmentOptionsForV8BrowsingMetrics and V8BrowsingShouldAddValue helpers to share metrics setup code with v8.browsing benchmarks - Add new V8LoadingClusterTelemetry benchmark Bug: chromium:883322 Change-Id: I67287fb046993a4cb687ac57073f81a7c006d361 Reviewed-on: https://chromium-review.googlesource.com/1224448 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#592134}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/6fc8d877d745..c3099d1c6942 git log 6fc8d877d745..c3099d1c6942 --date=short --no-merges --format='%ad %ae %s' 2018-09-18 hnakashima@chromium.org Change signature of FPDFPageObjMark_Get(Name|ParamKey). 2018-09-18 rharrison@chromium.org Transfer ownership of nodes to top-level XML doc Created with: gclient setdep -r src/third_party/pdfium@c3099d1c6942 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:884664 TBR=dsinclair@chromium.org Change-Id: Ifcdc87b0ee64b981f34c47a61775113428f8f887 Reviewed-on: https://chromium-review.googlesource.com/1231497Reviewed-by:
-
John Budorick authored
This reverts commit 7d96627b. Reason for revert: Suspect this broke orderfile generation due to conflicting adb binaries. Original change's description: > Orderfile: turn on system health order profiling. > > This sets default orderfile generation to use system health profiling. > > Bug: 758566 > Change-Id: Ie87f8b2623373861c7bdc44d5dfd866ce3597cd9 > Reviewed-on: https://chromium-review.googlesource.com/1228074 > Commit-Queue: Matthew Cary <mattcary@chromium.org> > Reviewed-by: Egor Pasko <pasko@chromium.org> > Reviewed-by: Benoit L <lizeb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#591674} TBR=pasko@chromium.org,lizeb@chromium.org,mattcary@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 758566 Change-Id: Ia3092b00488f332a5348f9aaae13fdb4691f27de Reviewed-on: https://chromium-review.googlesource.com/1231919Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#592132}
-
Caroline Rising authored
Add method to make buttons observers of any widgets that are anchored to them. Change inkdrop highlight for buttons when anchored widgets are shown or removed. Fix cases where a widget is anchored to the location bar but a different view should be highlighted. Change highlighting to SetBackground when used for extension actions in BrowserActionsContainer to protect inkdrop highlight state during layout calls. Bug: 863170, 824536 Change-Id: Id6abdfa7a70955b3cb1873b6c8013f0496455f68 Reviewed-on: https://chromium-review.googlesource.com/1165601Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Caroline Rising <corising@chromium.org> Cr-Commit-Position: refs/heads/master@{#592131}
-
Liquan(Max) Gu authored
1. Register Swap promise only when there is no ongoing swap promise. 2. Add tailing underscore to private attributes. 3. Restructure the while loop in FindLargestPaintCandidate and FindLastPaintCandidate. Bug: 869924 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Iaf19947eb3ef098114f2ab2ca7a4d6cdcec42758 Reviewed-on: https://chromium-review.googlesource.com/1229413Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Liquan (Max) Gǔ <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#592130}
-
Denis Kuznetsov authored
Bug: 885086 Change-Id: I8046229bdb8ae2ab7dbd36254869320331f1f2e1 Reviewed-on: https://chromium-review.googlesource.com/1230022Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Denis Kuznetsov <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#592129}
-
Brian White authored
There are reports from the field that the "maximum" of a histogram does not match what was configured. The working theory is that it is due to rounding errors in the creation of exponential buckets. Verify this assumption. If it's behaving wrong, it should crash during the creation. Bug: 836238 Change-Id: I4cf5e4bc3986e288c728ae37e2ff8cf841b7598d Reviewed-on: https://chromium-review.googlesource.com/1228840Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#592128}
-
Oystein Eftevaag authored
This is a reland of 32c8ebbe Relanding after https://chromium-review.googlesource.com/c/chromium/src/+/1225306 Original change's description: > Enable Perfetto by default for all telemetry tests > > This will use Perfetto instead of TraceLog for all > trace-based Telemetry tests running on Mac/Windows/Android. > > R=nednguyen@google.com > > Bug: 839084 > Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi > Change-Id: I570060cd7f53ea0310f67370b4abec132c8a1a01 > Reviewed-on: https://chromium-review.googlesource.com/1176119 > Commit-Queue: oysteine <oysteine@chromium.org> > Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> > Reviewed-by: Ned Nguyen <nednguyen@google.com> > Cr-Commit-Position: refs/heads/master@{#585368} TBR=nednguyen@google.com Change-Id: I31b69483281f9fb34c5083888b8f45f00ca95e6e Reviewed-on: https://chromium-review.googlesource.com/1208955Reviewed-by:
oysteine <oysteine@chromium.org> Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#592127}
-
Michael Spang authored
Since 57a19db6 ("[fuchsia] Whitelist required Fuchsia services in component manifest.") vulkan fails to initialize. Fix it by adding the vulkan loader service to the policy. Bug: 861853 Test: content_shell --ozone-platform=scenic --enable-vulkan --disable-gpu Change-Id: I38c11f32e0a0dd8b914184a16198c023877a0572 Reviewed-on: https://chromium-review.googlesource.com/1228488Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#592126}
-
Christopher Cameron authored
Add a BridgeFactoryHost structure, which wraps a views_bridge_mac::mojom::BridgeFactory interface. This structure has an BridgeFactoryHost::Observer interface to call back into widgets when the bridge factory they are using is destroyed (e.g, the app shim is force-quit). Bug: 859152 Change-Id: I0c34cf200588ac79d281b31ba85764bca0c02d39 Reviewed-on: https://chromium-review.googlesource.com/1229694 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#592125}
-
Wei Li authored
When Chrome's fullscreen toolbar style changes, it needs to re-layout to make sure the UI is updated. This CL fixed a recent regression due to using |is_exiting_fullscreen| to avoid re-layout. Instead, only when Chrome exits fullscreen mode to non-fullscreen mode, we should avoid doing re-layout because exiting tab fullscreen to browser fullscreen still may requires a re-layout. BUG=884029 Change-Id: I7392c2cb000b184c0f54b9cb6bb3de2b81a79dcf Reviewed-on: https://chromium-review.googlesource.com/1226014 Commit-Queue: Wei Li <weili@chromium.org> Reviewed-by:
Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#592124}
-
Ken MacKay authored
Use the correct config for the audio decoder, and fix a hang due to AV sync on desktop machines. Change-Id: Icb8f1e73d093e58f81a68dd00d8512654c1140d1 Reviewed-on: https://chromium-review.googlesource.com/1229933Reviewed-by:
-
Tommy C. Li authored
This CL continues implementation of the Query in Omnibox feature for Desktop with two main changes: 1. Shows the Default Search Provider favicon in the Omnibox when we are displaying search terms. 2. Don't (erroneously) try to do unelision for Steady State Elisions when we are displaying search terms. Adds a test for that. This also adds a convenience method to OmniboxEditModel to prevent repeated code, and adds a bit of testing code for the convenience method. Bug: 874592 Change-Id: Iafd791db349df434f616697ecbe6122285b5351b Reviewed-on: https://chromium-review.googlesource.com/1229493 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#592122}
-
Moe Ahmadi authored
Fixes the crash in ConfirmInfoBarController and potentially other infobar controllers after the refactoring of infobars in crrev.com/c/1037640. First attempt at fixing this crash: crrev.com/c/1161324 Bug: 880951 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I14cef2eabf0293221de4ea31ac2ea18d4c1522b0 Reviewed-on: https://chromium-review.googlesource.com/1213546 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#592121}
-
Brian White authored
This functionality is used by the FileMetricsProvider, currently based on a Feature to be enabled. Bug: 882892 Change-Id: I55262453b58c5ed9473b33e8839bad423ca7ec84 Reviewed-on: https://chromium-review.googlesource.com/1220310 Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
-
Weidong Guo authored
Changes: 1. Enable blur for suggestion chip and use a mask layer to clip into rounded rect. 2. Enable blur for folder icon and use a mask layer to clip into circle. 3. Since anyway we have to use mask layer for the blur, we don't need rely on Skia to draw clipped folder icon during the folder icon animation. Instead, we use mask layer as well. 4. Opening assistant will recreate layers in app list (bug 879372). Since Layer::Clone() does not copy mask layer (not owned), the mask layer set before will get lost. So override LayerOwner::RecreateLayer() to set mask layer after cloning. Bug: 873288 Change-Id: I7e7ff23cf38bfaece9799810e398c76bd38f8b68 Reviewed-on: https://chromium-review.googlesource.com/1171546 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by:
-
Devlin Cronin authored
When the user selects "On specific sites" from the dropdown in the chrome://extensions page, automatically bring up the dialog to add an allowed site. This makes it clear to the user that they need to specify a site for this setting to work, and also fixes an issue where selecting "On specific sites" and then refreshing the page (or having the data model otherwise update) reset the value to "on click". Bug: 884222 Change-Id: Ie89757f7fba2409774e5fcc2f4a8028aff31f7ba Reviewed-on: https://chromium-review.googlesource.com/1226017Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#592118}
-
rbpotter authored
Match the Print Preview elevation shadow styling to the styling used in other Web UI surfaces (extensions, settings). Bug: 883583 Change-Id: Ida1c4427e401de30c540c5109eb5b45e6b67f79f Reviewed-on: https://chromium-review.googlesource.com/1227395Reviewed-by:
-
Nate Chapin authored
This allows us to hide the HashSet of all current WorkerThreads, which is valuable since the callers outside WorkerThread don't have access to the necessary mutex to access it safely. Convert TimeZoneMonitorClient to use this helper. Change-Id: I5aa743a1fa0c789a8f9496a05d7cfecde9238004 Reviewed-on: https://chromium-review.googlesource.com/1228950Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#592116}
-
Richard Townsend authored
When colgroups are modified via Javascript, Blink uses a stale computed logical width, resulting in incorrect sizing of auto columns if layout was previously done. This patch forces a fresh layout of the affected cells, which corrects this behaviour. Bug: 870296 Change-Id: I4a12d5a8db689ba1457c6c9960ae8ea9c1dd40d9 Reviewed-on: https://chromium-review.googlesource.com/1162224 Commit-Queue: David Grogan <dgrogan@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#592115}
-
Ehsan Karamad authored
This is a second attempt at fixing the crash linked in the bug. It appears that PluginResourceThrottle's lifetime is tied with WebURLLoaderImpl does not synchronously go away with the container. When an <embed> element is removed during a resource request, the MHVCBase (aka WebAssociatedURLLoaderClient in this context) is destroyed immediately. The WebURLLoaderImpl, OTH, goes away when the cancel timer on the ResourceClient is fired. To avoid any potential UaF, this CL changes the raw pointer refernece to MHVCBase in PluginResourceThrottle to a WeakPtr. This also serves as a potential fix for the crashes in the linked bug. Bug: 878359 Change-Id: If8b21f9366bb57394819946e891f9288028dde2c Reviewed-on: https://chromium-review.googlesource.com/1230576Reviewed-by:
James MacLean <wjmaclean@chromium.org> Reviewed-by:
Ehsan Karamad <ekaramad@chromium.org> Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Cr-Commit-Position: refs/heads/master@{#592114}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/debba6d2124e..6fc8d877d745 git log debba6d2124e..6fc8d877d745 --date=short --no-merges --format='%ad %ae %s' 2018-09-18 hnakashima@chromium.org Encode mark names when writing to file. Created with: gclient setdep -r src/third_party/pdfium@6fc8d877d745 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I83b30a33d09b95a8b76523c2a5f455670d30dd66 Reviewed-on: https://chromium-review.googlesource.com/1231413Reviewed-by:
-
Nico Weber authored
win: Remove two exit-time destructors from pdf_child_init and enable -Wexit-time-destructors for chrome/child. The PDF setup code patches up two GDI functions. There's no need to undo that patching at process exit, so use a function-local static base::NoDestructor<> instead of a global. Bug: 404525 Change-Id: I9cb06b857a8b95ba5cbac74be60f8225fbb6f72a Reviewed-on: https://chromium-review.googlesource.com/1231073Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#592112}
-
Nico Weber authored
No need to undo 5 IAT patches at process shutdown, and no need to call a ThreadLocalBoolean dtor either. Bug: 404525 Change-Id: I95e4cc24d7b6ca7171457a0da8dd6b3231fe45a8 Reviewed-on: https://chromium-review.googlesource.com/1231153Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#592111}
-
Michael Spang authored
Fuchsia platform windows are initially 0x0 and this causes vulkan surface creation to crash. Defer creating a renderer until we have a nonempty size. Bug: 861853 Test: run_ozone_demo --ozone-platform=scenic --enable-vulkan Change-Id: I74e14ed07ab47ebc22730b40cf36217e9ae4873a Reviewed-on: https://chromium-review.googlesource.com/1229162 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d89bb9de..345f5513 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I7f2c4436587c174c0640ad366c7439cc5a5b98ad Reviewed-on: https://chromium-review.googlesource.com/1231293Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#592109}
-
