GitLab

DOMWindowLifecycleObserver is used just to notify the observers of
addition/removal of event listeners. The observers are not interested
in observing lifecycle of DOMWindow at all. Hence, this CL removes
DOMWindowLifecycleObserver by replacing it with simple inheritance
of LocalDOMWindow::EventListenerObserver.

BUG=610176

Review-Url: https://codereview.chromium.org/2134063002
Cr-Commit-Position: refs/heads/master@{#404644}

Revert of Roll src/third_party/skia/ 48898561d..4c42eebc5 (1 commit). (patchset #1 id:1 of https://codereview.chromium.org/2136843002/ )

Reason for revert:
Breaking webkit_tests see https://bugs.chromium.org/p/chromium/issues/detail?id=627025

Original issue's description:
> Roll src/third_party/skia/ 48898561d..4c42eebc5 (1 commit).
>
> https://chromium.googlesource.com/skia.git/+log/48898561db7d..4c42eebc5551
>
> $ git log 48898561d..4c42eebc5 --date=short --no-merges --format='%ad %ae %s'
> 2016-07-10 update-skps Update SKP version
>
> CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
> TBR=msarett@google.com
>
> Committed: https://crrev.com/26ecc31bc8a213084a3a111f1ef364bd7faeea7d
> Cr-Commit-Position: refs/heads/master@{#404583}

TBR=msarett@google.com,skia-deps-roller@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review-Url: https://codereview.chromium.org/2137983002
Cr-Commit-Position: refs/heads/master@{#404643}

Revert of Roll src/third_party/skia/ 4c42eebc5..3ab14ca95 (3 commits). (patchset #1 id:1 of https://codereview.chromium.org/2136883002/ )

Reason for revert:
Breaking webkit_tests see https://bugs.chromium.org/p/chromium/issues/detail?id=627025

Original issue's description:
> Roll src/third_party/skia/ 4c42eebc5..3ab14ca95 (3 commits).
>
> https://chromium.googlesource.com/skia.git/+log/4c42eebc5551..3ab14ca950d9
>
> $ git log 4c42eebc5..3ab14ca95 --date=short --no-merges --format='%ad %ae %s'
> 2016-07-10 robertphillips Fix misplaced guard
> 2016-07-10 reed Revert of change mapRectScaleTranslate to pass args/ret by value (patchset #1 id:1 of https://codereview.chromium.org/2137853002/ )
> 2016-07-10 reed change mapRectScaleTranslate to pass args/ret by value
>
> CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
> TBR=msarett@google.com
>
> Committed: https://crrev.com/d486f3ad74364953974e3084c08fb81292170f63
> Cr-Commit-Position: refs/heads/master@{#404593}

TBR=msarett@google.com,skia-deps-roller@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review-Url: https://codereview.chromium.org/2140473004
Cr-Commit-Position: refs/heads/master@{#404642}

and clean up the comments for IsNTPURL and IsInstantNTP to match what the functions actually do.

BUG=624410

Review-Url: https://codereview.chromium.org/2134133002
Cr-Commit-Position: refs/heads/master@{#404641}

This datatype was disused in https://codereview.chromium.org/2033353002/,
but not completely removed.

BUG=webrtc:5708

Review-Url: https://codereview.chromium.org/2137023002
Cr-Commit-Position: refs/heads/master@{#404640}

Adds implementations of abstract methods added to Autofill.

TBR=sdefresne@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2138743002
Cr-Commit-Position: refs/heads/master@{#404639}

Before finishing the test, remove the resize event listener, as we just
resized, and the window is about to be closed.

Otherwise, we might get spurious output from the event listener running
in a detached context

BUG=627030
R=haraken@chromium.org,carlosk@chromium.org

Review-Url: https://codereview.chromium.org/2141573002
Cr-Commit-Position: refs/heads/master@{#404638}

Revert of Roll src/third_party/skia/ 3ab14ca95..6af677ff8 (1 commit). (patchset #1 id:1 of https://codereview.chromium.org/2141473002/ )

Reason for revert:
webkit_tests are failing see https://bugs.chromium.org/p/chromium/issues/detail?id=627025

Original issue's description:
> Roll src/third_party/skia/ 3ab14ca95..6af677ff8 (1 commit).
>
> https://chromium.googlesource.com/skia.git/+log/3ab14ca950d9..6af677ff8f54
>
> $ git log 3ab14ca95..6af677ff8 --date=short --no-merges --format='%ad %ae %s'
> 2016-07-10 dvonbeck Changed SkLightingShader API to take in a shader as color source
>
> CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
> TBR=msarett@google.com
>
> Committed: https://crrev.com/206631d012d8e32ba702698f767cc4c8295198d0
> Cr-Commit-Position: refs/heads/master@{#404597}

TBR=msarett@google.com,skia-deps-roller@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review-Url: https://codereview.chromium.org/2137043002
Cr-Commit-Position: refs/heads/master@{#404637}

It's still called from the same places, but through public functions
that describe what is happening and why, rather than exposing an
implementation detail.

Also, add an enum so that it's immediately obvious at the call site why
EmitNtpStatistics() is being called.

BUG=625990

Review-Url: https://codereview.chromium.org/2127783002
Cr-Commit-Position: refs/heads/master@{#404636}

Currently TraceEvents recorded before the native library load are
silently discarded. This CL adds support for such "early" events.

The events are buffered in Java, and then sent to the native side once
it is available. This support is intentionally simple now. The aim is to
ease performance investigation of early startup, and to ease tracking of
early startup performance regression, since timings are then accessible
to TBM tests.

Also use the newly-introduced events in a couple places, and fix a bug
in the TraceEvent we use to record the launcher activity lifetime (when
an Activity calls finish from onCreate(), onPause() is not called).

BUG=564041

Review-Url: https://codereview.chromium.org/1486053003
Cr-Commit-Position: refs/heads/master@{#404635}

When the URL bar is focused before the NTP is loaded, the UI misses
the events and renders in the incorrect state. This change just runs
the effects of the event later.

BUG=617582

Review-Url: https://codereview.chromium.org/2133753002
Cr-Commit-Position: refs/heads/master@{#404634}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/75f10f91..a12e4d77

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2141553002
Cr-Commit-Position: refs/heads/master@{#404633}

As stated in the spec, <template> tag start token should set frameset-ok
flag to false when in in-body/in-head insertion mode.
https://html.spec.whatwg.org/multipage/syntax.html#parsing-main-inbody

BUG=475002

Review-Url: https://codereview.chromium.org/2135203002
Cr-Commit-Position: refs/heads/master@{#404632}

BUG=600697
TEST=manually

Review-Url: https://codereview.chromium.org/2135163002
Cr-Commit-Position: refs/heads/master@{#404631}

BUG=611329
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq

Review-Url: https://codereview.chromium.org/2137873002
Cr-Commit-Position: refs/heads/master@{#404630}

Revert of Re-enable DataReductionPromoInfoBar tests and fix flakiness (patchset #3 id:60001 of https://codereview.chromium.org/2130083002/ )

Reason for revert:
A number of related tests have started failing (see https://bugs.chromium.org/p/chromium/issues/detail?id=627038)

Original issue's description:
> Re-enable DataReductionPromoInfoBar tests and fix flakiness
>
> StrictMode violation was from Calendar.getInstance() reading
> the /etc/timezone file. Whitelist the StrictMode violation
> to be fixed.
>
> Tests were flaky because the UI thread would not always launch
> the InfoBar before calling addInfoBarAnimationFinished(). Run
> the UI thread blocking so that the InfoBar has always been
> launched.
>
> BUG=625038, 577185
>
> Committed: https://crrev.com/8fcd3f03a3a531f12bb291dc8665834d85511c23
> Cr-Commit-Position: refs/heads/master@{#404506}

TBR=dfalcantara@chromium.org,megjablon@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=625038, 577185

Review-Url: https://codereview.chromium.org/2135193002
Cr-Commit-Position: refs/heads/master@{#404629}

It is unlikely that we'll use the Interests front-end code (though we may still use the back-end for a Cards experiment).

BUG=not really
TBR=bauerb@chromium.org

Review-Url: https://codereview.chromium.org/2122993003
Cr-Commit-Position: refs/heads/master@{#404628}

(original change: https://codereview.chromium.org/2042763002)

In layout tests when preferences were being overridden by specific tests they
were not being properly applied in the browser. The WebPreferences cached by the
RenderViewHost was not updated and so they would not effect the existing window.
This fixes that and changes the way spatial navigation is enabled in layout
tests to adapt to this change.

The problem the original change that caused it to be reverted was that it made
preferences leak between tests when the Shell window was reused. This version
fixes that by storing a clean copy of the test-ready WebPrecerences created with
a brand new RenderView and using that to reset existing windows' preferences.

This is an spin off change to support the moving of mixed content checks to
the browser, which requires the browser to be immediately effected by
preferences updates.

BUG=576270, 620126

Review-Url: https://codereview.chromium.org/2134723002
Cr-Commit-Position: refs/heads/master@{#404627}

Before, prefetch experiment's CSV collection was maintaining a dict
of transfered bytes per URLs as it was iterating over all resource
requests and served from memory cache URLs request would just grabe
the size from this dictionary. But we may have requests served from
memory cache before original request that filled the memory cache,
leading to a KeyError.

This CL fixes this issue by first building the dictionary by going
over resources requests, and then actually sum the bytes using this
dictionary, avoiding the KeyError.

BUG=582080

Review-Url: https://codereview.chromium.org/2134763002
Cr-Commit-Position: refs/heads/master@{#404626}

BUG=None

Review-Url: https://codereview.chromium.org/2133153002
Cr-Commit-Position: refs/heads/master@{#404625}

BUG=627009
BUG=b/30054874

Review-Url: https://codereview.chromium.org/2136933002
Cr-Commit-Position: refs/heads/master@{#404624}

Now that PageLifecycleObserver has only pageVisibilityChanged(),
it would make more sense to rename the class accordingly.

BUG=610176

Review-Url: https://codereview.chromium.org/2138663003
Cr-Commit-Position: refs/heads/master@{#404623}

Revert of Add effect node support in PaintArtifactCompositor for layer list mode [4/4] (patchset #7 id:120001 of https://codereview.chromium.org/2052763002/ )

Reason for revert:
This CL seems making webkit_unit_tests' failures.

https://findit-for-me.appspot.com/waterfall/build-failure?url=https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20(dbg)/builds/8344

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20(dbg)/builds/8334

Original issue's description:
> Add effect node support in PaintArtifactCompositor for layer list mode [4/4]
>
> This CL adds a local EffectStack class similar to ClipManager, that keep track
> of effect state and assign generated cc effect node to layers. This is only
> used for layer list mode.
>
> BUG=609937
>
> Committed: https://crrev.com/889b2a8057be02fefc2fdd9e5deb289844f94040
> Cr-Commit-Position: refs/heads/master@{#404575}

TBR=jbroman@chromium.org,chrishtr@chromium.org,trchen@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=609937

Review-Url: https://codereview.chromium.org/2138663002
Cr-Commit-Position: refs/heads/master@{#404622}

All .strings files that need to be in binary1 format are now
converted by using the "bundle_data_strings" template so the
conversion can be remove from "copy_bundle_data" tool.

BUG=625578

Review-Url: https://codereview.chromium.org/2130813002
Cr-Commit-Position: refs/heads/master@{#404621}

Giving more descriptive name.

BUG=624711
R=mkwst,rdsmith,clamy

Review-Url: https://codereview.chromium.org/2125523003
Cr-Commit-Position: refs/heads/master@{#404620}

BUG=620630

Review-Url: https://codereview.chromium.org/1706193002
Cr-Commit-Position: refs/heads/master@{#404619}

BUG=627008
TBR=nzolghadr

Review-Url: https://codereview.chromium.org/2137923002
Cr-Commit-Position: refs/heads/master@{#404618}

Set --enable-files-quick-view to enable quick view.

BUG=613465
TEST=manually using link.

Review-Url: https://codereview.chromium.org/2127853002
Cr-Commit-Position: refs/heads/master@{#404617}

BUG=617585

Review-Url: https://codereview.chromium.org/2130363002
Cr-Commit-Position: refs/heads/master@{#404616}

No behavioral change.

- Avoid duplicate member init in HTMLConstructionSite c-tor.
- Use Document& instead of Document* as the document can't be nullref
- Clarify that HTMLTreeBuilder can be invoked for generic Document (with a fixme comment)

BUG=None

Review-Url: https://codereview.chromium.org/2126043003
Cr-Commit-Position: refs/heads/master@{#404615}

This file contains an interface that is about to be removed
(https://codereview.webrtc.org/2034013003) since it is no longer used
by chromium (https://codereview.chromium.org/2033353002).

The build files have to be updated before the file is removed from the
webrtc repo or else the webrtc roll will cause chromium to break.

BUG=webrtc:5708, webrtc:5707
NOTRY=true

Review-Url: https://codereview.chromium.org/2120493002
Cr-Commit-Position: refs/heads/master@{#404614}

The previous src tag collides with the one used by desktop NTP (in the
remote NTP).

BUG=626235

Review-Url: https://codereview.chromium.org/2125133004
Cr-Commit-Position: refs/heads/master@{#404613}

Follow-up to https://chromium.googlesource.com/chromium/src/+/3854a2102cfd8a10f28cf5123f593b87aaac3af0

BUG=None

Review-Url: https://codereview.chromium.org/2134043002
Cr-Commit-Position: refs/heads/master@{#404612}

WebURLResponse can directly point to a ResourceResponse object instead.

BUG=625529

Review-Url: https://codereview.chromium.org/2133693002
Cr-Commit-Position: refs/heads/master@{#404611}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/6cad5da3c39e..4160831d2082

$ git log 6cad5da3c..4160831d2 --date=short --no-merges --format='%ad %ae %s'

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2135893002
Cr-Commit-Position: refs/heads/master@{#404610}

There are two cases when cache is flushed:

1) MEMORY_PRESSURE_LEVEL_MODERATE: flush expired sessions only.
2) MEMORY_PRESSURE_LEVEL_CRITICAL: flush everything.

BUG=622069

Review-Url: https://codereview.chromium.org/2131883002
Cr-Commit-Position: refs/heads/master@{#404609}

It's now unused.

BUG=610176

Review-Url: https://codereview.chromium.org/2134033002
Cr-Commit-Position: refs/heads/master@{#404608}

Review-Url: https://codereview.chromium.org/2129083002
Cr-Commit-Position: refs/heads/master@{#404607}

URLRequest::Delegate::OnBeforeNetworkStart is not used by
anything, despite having a lot of plumping.  It was added to
try experimenting with having the ResourceScheduler delay
requests only once they needed to go over the network, so
responses that could be served out of the cache.

BUG=479994

Review-Url: https://codereview.chromium.org/2123093002
Cr-Commit-Position: refs/heads/master@{#404606}

This symbol no longer appears in the codebase.

BUG=27837

Review-Url: https://codereview.chromium.org/2134023002
Cr-Commit-Position: refs/heads/master@{#404605}