- 03 Sep, 2014 40 commits
-
-
shimazu authored
1. [Blink] https://codereview.chromium.org/515083002/ 2. [Chromium] This patch 3. [Blink] https://codereview.chromium.org/512163002/ 4. [Chromium] https://codereview.chromium.org/509283003/ BUG=390894 TEST=N/A Review URL: https://codereview.chromium.org/516823003 Cr-Commit-Position: refs/heads/master@{#293083}
-
iseki authored
BUG=410126 TEST=content_unittests Review URL: https://codereview.chromium.org/536453007 Cr-Commit-Position: refs/heads/master@{#293082}
-
je_julie.kim authored
The Related CL: https://codereview.chromium.org/515843002/ BUG=282040 Review URL: https://codereview.chromium.org/512603003 Cr-Commit-Position: refs/heads/master@{#293081}
-
erikchen authored
In Yosemite, no views can be in front of the traffic lights controls. Move the content view and the tab strip view to the back of the NSThemeFrame. BUG=408094 Review URL: https://codereview.chromium.org/520733004 Cr-Commit-Position: refs/heads/master@{#293080}
-
raymes authored
Revert of Replace NPObject usage in ppapi with gin (patchset #28 id:540001 of https://codereview.chromium.org/459553003/) Reason for revert: Causing a bunch of top crashes: go/crash/c383c0c43c093ea1 go/crash/576a27ecf5f32094 go/crash/08fc74881d1819ac go/crash/a6a00150ba55c0bf Original issue's description: > Replace NPObject usage in ppapi with gin > > This replaces usage of NPObject in pepper with gin-backed V8 objects. It is unfortunate that this CL is so large, but there isn't a nice way to have the old implementation and the new one side-by-side. > > There are 4 major parts to this CL: > 1) Changing the HostVarTracker to track V8ObjectVars rather than NPObjectVars (host_var_tracker.cc). > 2) Changing plugin elements (in plugin_object.cc) to be gin-backed objects. > 3) Changing postMessage bindings (message_channel.cc) be gin-backed objects. > 4) Changing the implementation of PPB_Var_Deprecated (ppb_var_deprecated_impl.cc) to call directly into V8. > > > BUG=351636 > > Committed: https://chromium.googlesource.com/chromium/src/+/21f446ae855d60cc896b40cb9a3249ed07f150b3 > > Committed: https://chromium.googlesource.com/chromium/src/+/ee49e63baf57e503bd71dfe61c8a80df63eac9aa > > Committed: https://chromium.googlesource.com/chromium/src/+/e06bc5d896e494b9ec556f0e89dcc523778a1432 TBR=jochen@chromium.org,dmichael@chromium.org,kolczyk@opera.com NOTREECHECKS=true NOTRY=true BUG=351636 Review URL: https://codereview.chromium.org/537483002 Cr-Commit-Position: refs/heads/master@{#293079}
-
anujk.sharma authored
Changing the order of weak_ptr_factory in src/ui module, to ensure proper cleanup while object is inactive. BUG=303818 Review URL: https://codereview.chromium.org/533553002 Cr-Commit-Position: refs/heads/master@{#293078}
-
tbarzic authored
BUG=410111 Review URL: https://codereview.chromium.org/534073003 Cr-Commit-Position: refs/heads/master@{#293077}
-
je_julie.kim authored
BUG=N/A Review URL: https://codereview.chromium.org/536763002 Cr-Commit-Position: refs/heads/master@{#293076}
-
spang authored
The demo does GL on the main thread, which broken since we now depend on GpuPlatformSupport(Host). Let's deliver these messages directly via a helper class for those applications. BUG=409978 TEST=ozone_demo --ozone-platform=gbm on link_freon NOTRY=true Review URL: https://codereview.chromium.org/533803003 Cr-Commit-Position: refs/heads/master@{#293075}
-
kcarattini authored
BUG=390086 Review URL: https://codereview.chromium.org/521483003 Cr-Commit-Position: refs/heads/master@{#293074}
-
prasadv authored
BUG=410064 NOTRY=true Review URL: https://codereview.chromium.org/530213003 Cr-Commit-Position: refs/heads/master@{#293073}
-
ckocagil authored
BUG=386749 R=msw Review URL: https://codereview.chromium.org/522103002 Cr-Commit-Position: refs/heads/master@{#293072}
-
blink-deps-roller authored
https://chromium.googlesource.com/chromium/blink/+log/b11cd8b47a088b4da9aca6bfb590075ac4833068..c2d22105d9f5430670072c9f31712e1eaca8d86b TBR=hclam@chromium.org,tkent@chromium.org Review URL: https://codereview.chromium.org/534913002 Cr-Commit-Position: refs/heads/master@{#293071}
-
jiajia.qin authored
When use_ozone=1 and use_aura=1, it will produce the following link error: obj/ui/views/widget/desktop_aura/views.desktop_native_widget_aura.o: In function `views::DesktopNativeWidgetAura::InitNativeWidget(views::Widget::InitParams const&)': desktop_native_widget_aura.cc: undefined reference to `views::DesktopCursorLoaderUpdater::Create()' R=sky@chromium.org BUG=none Review URL: https://codereview.chromium.org/510233002 Cr-Commit-Position: refs/heads/master@{#293070}
-
kbr authored
Needed to try to reproduce intermittent failures on tryservers. BUG=407976 Review URL: https://codereview.chromium.org/535743002 Cr-Commit-Position: refs/heads/master@{#293069}
-
sergeyu authored
This adds XMPP implementation that will be used for signaling in the webapp instead of WCS. It depends on TLS support added in the TCP API in Chrome 38. BUG=274652 Review URL: https://codereview.chromium.org/514343002 Cr-Commit-Position: refs/heads/master@{#293068}
-
https://www.google.com/chrome/devices/goodies.htmlandycai authored
BUG=chromium:406628 TEST=manual on daisy Review URL: https://codereview.chromium.org/512323003 Cr-Commit-Position: refs/heads/master@{#293067}
-
mgiuca authored
We're experimenting with a minimal UI and there is no real need to have this button since you don't need to get back to the start page if you find yourself on some other page. BUG=406222 Review URL: https://codereview.chromium.org/527203002 Cr-Commit-Position: refs/heads/master@{#293066}
-
mukai authored
This CL centralizes the dependency to content, so that other files can run independently. BUG=380875 R=xiyuan@chromium.org TEST=build Review URL: https://codereview.chromium.org/518293002 Cr-Commit-Position: refs/heads/master@{#293065}
-
wez authored
This avoids duplication of common VideoPacket initialization across multiple encoders, making addition of new fields (e.g. the recently added shape field) more robust. Review URL: https://codereview.chromium.org/530243002 Cr-Commit-Position: refs/heads/master@{#293064}
-
mtomasz authored
The read-only version is pretty much done, so we should let developers use it on the dev channel for initial feedback. TEST=browser_tests: *FileSystemProvider* BUG=248427 Review URL: https://codereview.chromium.org/531463002 Cr-Commit-Position: refs/heads/master@{#293063}
-
alemate authored
On 32-bit architectures UMA Histogram IDs (enum LoginCustomFlags) are negative. So HistogramBase::Sample (which is int32_t) should be used. BUG=408196 TEST=manual Review URL: https://codereview.chromium.org/509923003 Cr-Commit-Position: refs/heads/master@{#293062}
-
tfarina authored
Looks like nobody is using this script? Checked in Chromium, Blink and Buildbot repos. BUG=338338 TEST=None R=ojan@chromium.org,dpranke@chromium.org Review URL: https://codereview.chromium.org/520373002 Cr-Commit-Position: refs/heads/master@{#293061}
-
rvargas authored
The hang monitor is supposed to wait for 30 seconds of inactivity before deciding that a renderer is not responsive. This CL makes sure that when waiting for multiple input events, receiving an ack is correctly interpreted as a responsive renderer (for that moment) BUG=336198 Review URL: https://codereview.chromium.org/535653002 Cr-Commit-Position: refs/heads/master@{#293060}
-
thestig authored
Revert of Convert chrome_unscaled_resources to use a qualified path. (patchset #1 id:1 of https://codereview.chromium.org/534013002/) Reason for revert: Linux_x64 says: ninja: error: 'gen/chrome/chrome_unscaled_resources.pak', needed by 'gen/repack/resources.pak', missing and no known rule to make it Original issue's description: > Convert chrome_unscaled_resources to use a qualified path. > > BUG=401588 > > Committed: https://chromium.googlesource.com/chromium/src/+/01ac77c0ca2f552d4ff44d5f16dad8844eccd516 TBR=thakis@chromium.org,tfarina@chromium.org NOTREECHECKS=true NOTRY=true BUG=401588 Review URL: https://codereview.chromium.org/533013002 Cr-Commit-Position: refs/heads/master@{#293059}
-
ksakamoto authored
Blink-side change: https://codereview.chromium.org/524553002/ BUG=408451 Review URL: https://codereview.chromium.org/525733004 Cr-Commit-Position: refs/heads/master@{#293058}
-
erg authored
BUG=none Review URL: https://codereview.chromium.org/529163002 Cr-Commit-Position: refs/heads/master@{#293057}
-
zork authored
BUG=None Review URL: https://codereview.chromium.org/524903003 Cr-Commit-Position: refs/heads/master@{#293056}
-
tdanderson authored
Remove the unnecessary code from RootView::DispatchGestureEvent() by condensing it to a single loop and moving parts of the implementation into RootView::PreDispatchEvent() and RootView::PostDispatchEvent(). BUG=404228 TEST=covered by existing unit tests Review URL: https://codereview.chromium.org/517023004 Cr-Commit-Position: refs/heads/master@{#293055}
-
Sergey Ulanov authored
R=kelvinp@chromium.org Review URL: https://codereview.chromium.org/528123003 Cr-Commit-Position: refs/heads/master@{#293054}
-
fsamuel authored
BUG=none Review URL: https://codereview.chromium.org/530043002 Cr-Commit-Position: refs/heads/master@{#293053}
-
thestig authored
BUG=401588 Review URL: https://codereview.chromium.org/534013002 Cr-Commit-Position: refs/heads/master@{#293052}
-
ahernandez.miralles authored
Review URL: https://codereview.chromium.org/531973003 Cr-Commit-Position: refs/heads/master@{#293051}
-
blink-deps-roller authored
https://chromium.googlesource.com/chromium/blink/+log/5d185994db600614dae243adfb09a7e191208e2a..b11cd8b47a088b4da9aca6bfb590075ac4833068 TBR=hclam@chromium.org,tkent@chromium.org Review URL: https://codereview.chromium.org/529193003 Cr-Commit-Position: refs/heads/master@{#293050}
-
mpearson authored
This is a re-land of https://codereview.chromium.org/471673002/ which was reverted because it caused a failure in interactive_ui_tests InstantExtendedPrefetchTest.SetPrefetchQuery (run #1): [ RUN ] InstantExtendedPrefetchTest.SetPrefetchQuery ../../chrome/browser/ui/search/instant_extended_interactive_uitest.cc:867: Failure Value of: SearchProvider::ShouldPrefetch(*( omnibox()->model()->result().default_match())) Actual: false Expected: true [ FAILED ] InstantExtendedPrefetchTest.SetPrefetchQuery, where TypeParam = and GetParam() = (1613 ms) http://build.chromium.org/p/chromium.linux/buildstatus?builder=Linux%20Tests&number=12979 It has two changes: - revises the failing tests - does some requested cleanup of the unit tests The original changelist description follows: --- Calls to the suggest server may normally result in a new inline autocompletion. This can be disruptive because it means pressing enter may bring the user to different places depending on how long he/she waits after typing the last key. This change prevents new suggestions from becoming the default match. In other words, the default match is only allowed to change on a keystroke, not due to a reply coming back from the server. The consequence of this change is that if previously we'd show an inline suggestion on a server reply, now we only show it one keystroke later. I think this trade-off (one keystroke versus inconsistent omnibox behavior) is a good one to make. We still end up with default matches (inline autocompletions within the omnibox) from the suggest server after this change. Here's an example of why: User types "facebo" We send a suggest server request. Server asynchronously returns "facebook" as a top suggestion, beating the server-provided verbatim score for "facebo". We decide not to show it within the omnibox. It's instead shown somewhere in the dropdown. User types "o". We send a suggest server request. We reuse our cached suggestions and suggestion scores. <<< THE KEY We show "facebook" as an inline suggestion because it beats the default verbatim score that gets assigned to "faceboo". (This is the score that we assign by default without having yet received the most recent suggest server response.) We receive the response, which includes "facebook" as a top suggestion, beating the server-provided verbatim score for "faceboo". We show "facebook" as an inline suggestion. i.e., we decide not to demote it because it was already being shown inline TESTED: unit tests plus interactive tests (facebook.com/l, google.com/a) BUG=398135 Review URL: https://codereview.chromium.org/481693004 Cr-Commit-Position: refs/heads/master@{#293049}
-
xhwang authored
BUG=392236 TEST=Existing tests pass. Review URL: https://codereview.chromium.org/526653002 Cr-Commit-Position: refs/heads/master@{#293048}
-
dschuff authored
This pulls in the following Native Client changes: r13676: (uekawa) Convert to use nacl_exception_* helpers instead of NACL_SYSCALL in tests. r13677: (hidehiko) Support NONSFI translation on pnacl-ld.py. r13678: (mseaborn) Use uint32_t for untrusted pointer args: nanosleep() syscall r13679: (dschuff) Update revision for PNaCl r13658->r13673 BUG=none R=mseaborn@chromium.org TEST=browser_tests and nacl_integration CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_rel_precise32,linux_arm_cross_compile,linux_nacl_sdk_build Review URL: https://codereview.chromium.org/533953002 Cr-Commit-Position: refs/heads/master@{#293047}
-
zmo authored
BUG=393331 TEST=bots R=brianderson@chromium.org Review URL: https://codereview.chromium.org/533973002 Cr-Commit-Position: refs/heads/master@{#293046}
-
qinmin authored
Added UMAs for: 1) The % of fullscreen video that is opened in portrait mode 2) The % of the video is suited for portrait mode 3) How long does a video play before user rotate the screen to landscape mode 4) How long video plays after user rotate the screen to landscape mode 5) How long does a video play before user rotate to portrait mode 6) The % of a video that the user switched from portrait to landscape mode BUG=326572 Review URL: https://codereview.chromium.org/297773004 Cr-Commit-Position: refs/heads/master@{#293045}
-
ericzeng authored
Implement WebContentsDelegate::RunFileChooser in GuestViewBase so that <input type=file> tags will work correctly within guest views. BUG=409339 Review URL: https://codereview.chromium.org/531963002 Cr-Commit-Position: refs/heads/master@{#293044}
-