- 20 May, 2019 34 commits
-
-
Fergus Dall authored
TBR=alph@chromium.org Bug: 899710 Change-Id: I341b07d66774d0f8201f68d52dda4ba01fda2463 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619450Reviewed-by:
Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#661270}
-
Abhijeet Kandalkar authored
This CL removes unwanted comment from styled_markup_serializer.cc Bug: 891908 Change-Id: I97d47cc28cb5a20b98f59bed6f69ba87e412ec3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617564Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#661269}
-
Kenichi Ishibashi authored
Note to sheriffs: Feel free to revert this if this breaks something. Bug: 924043 Change-Id: I7164ad621edafebd7fc05d9f4eeee7bd673cbe6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1583168 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#661268}
-
Fergus Dall authored
Mark TestStrippingHeadersFromRequestUsingSimpleURLLoaderWithGlobalSystemNetworkContext as flaky on chrome OS TBR=rmcelrath@chromium.org Bug: 964338 Change-Id: Ic4555abb9602db8dc0151488b0e84a742cce0b9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619525Reviewed-by:
-
Luciano Pacheco authored
This allows screen reader users to know that the column header is clickable and also what is the sorting order it will apply when clicked. Use aria-described to point to the text (with translation) that describes the action performed when clicking in the column header. Use aria role=button so screen reader recognizes column header as a clickable element, Chromevox will say: "Press Search plus Space to activate." Add test that check for those 2 attributes in all column headers. Remove 2 missing files from the test harness: test_util_unittest.js and details_panel.js Change cr.ui.table.TableColumn.headerRenderFunction to accept Element in addition to just plain text, so we can customize further the column header, in this case for add these ARIA attributes, but in the future it needs a "ripple" effect when clicked too. Test: browser_tests --gtest_filter="*fileListAriaAttributes*" Bug: 888620 Change-Id: I6d56d94a2d59aad3b416133106f569cc495fb944 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610669Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#661266}
-
François Degros authored
Replaced some Promise continuations with async / await. Change-Id: I054faccd3e4b60c562a72e981fae86fc06ec2e97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619502 Auto-Submit: François Degros <fdegros@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#661265}
-
Anand K. Mistry authored
The Remount() D-Bus method attmepts to remount the share with the same mount_id. However, mount_id is like a file descriptor and not suitable as a persistent id. Trying to restore a share to the same mount_id causes the remount to unexpectedly fail in certain situations (i.e. if the browser process needs to restart). The alternative is to use the regular Mount() method and have it skip attempting to connect to the share. That will give us a new, non-colliding mount_id. Since there's no way to pass this data to the SmbFileSystem, it is stored in a map in SmbService and looked up by SmbFileSystem when needed. BUG=961183 Change-Id: I40c858541fb065a6f88a51249fd72678bdba862d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609753 Commit-Queue: Anand Mistry <amistry@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#661264}
-
Michael Martis authored
Now that we've merged the logic to default-disable this feature in M75 (crrev.com/c/1607711), we will reenable this feature on trunk for dev / canary users. Change-Id: If250487c206c97cbe7eb6cece72fb5f9d3897e06 Bug: 945228 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617056Reviewed-by:
Jia Meng <jiameng@chromium.org> Reviewed-by:
-
Lin Sun authored
The hang error caused by Intel graphics driver on Linux is fixed from kernel 5.0. Before that, limit the max texture size as a workaround. Bug: 927470 Change-Id: I2fd022af0803af33820dad34a89c74fa1405d161 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612410Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Lin Sun <lin.sun@intel.com> Cr-Commit-Position: refs/heads/master@{#661262}
-
Giovanni Ortuño Urquidi authored
This is part of simplifying the logic in PendingAppManager. Temporarily pass the result of loading the URL to the installation task. A follow up CL will move the loading logic into the task so the argument will be removed. Bug: 916381 Change-Id: I45367c08a3195e2bfb4d0e83e36350b67e61c84b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616709 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#661261}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/f3f5bf480d3b..027a8f6464c5 git log f3f5bf480d3b..027a8f6464c5 --date=short --no-merges --format='%ad %ae %s' 2019-05-20 hao.x.li@intel.com Enable Metal validation layers 2019-05-20 hao.x.li@intel.com Enable Vulkan validation layers Created with: gclient setdep -r src/third_party/dawn@027a8f6464c5 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Change-Id: I240bed8395834e77d0a3f957020aefcea4156921 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619467Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#661260}
-
Donna Wu authored
This CL just moved the //device/usb to //services/device and adjusted the related code, no feature changed or added. Bug: 699790 Change-Id: I6466ce22c749e8c0b4aa28f6fc79a79e04fdec1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611241Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Donna Wu <donna.wu@intel.com> Cr-Commit-Position: refs/heads/master@{#661259}
-
Fergus Dall authored
TBR=foolip@chromium.org, robertma@chromium.org Bug: 964158 Change-Id: I521b594c241cde37c228ebadb578b70a329de247 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616840Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ff9090d033d8..3b6e788f138b Created with: gclient setdep -r src-internal@3b6e788f138b The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=beverloo@google.com,collinbaker@google.com,bcwhite@google.com,tasak@google.com Change-Id: I2b83a995b8d333ddba0859ae46713f38404512bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619462Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#661257}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: Iac1d804651365008791adb64f533222a599e682f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618178Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#661256}
-
Noel Gordon authored
Bug: 935285 Change-Id: Id2810b266440a339f5dbbe7fd9f3814f5e24ad23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616838Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#661255}
-
Fergus Dall authored
Disable a bunch of benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_health.memory_mobile for Nexus 5X due to flake TBR=perezju@chromium.org, eyaich@chromium.org Bug: 964804 Change-Id: Ib482e6565c8f3ccec556298a414964ca8ccd3c52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616837Reviewed-by:
-
Joel Hockey authored
UI test for not sharing Play files root. Original CL is crosreview.com/1616703. Test in separate CL since it is unlikely to merge well. Bug: 958840 Change-Id: I6cd5ab216b77890a748f323cc87a223b8fab5ec6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619443 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
-
Joel Hockey authored
Sharing Play files root also shares Downloads which may be unexpected. UI Test in crosreview.com/1619443 since it is unlikely to merge so well. Bug: 958840 Change-Id: I0b199dc65698aa391c52021a1106a4d7631802ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616703 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
-
Karan Bhatia authored
Enforce inline style CSP checks for isolated worlds and add testing. Since the IsolatedWorldCSP feature is disabled by default, this CL will cause the CSP check to use an empty CSP instead of just bypassing the CSP checks for isolated worlds. In practice, this should cause no behavior change. BUG=896041 Change-Id: Ic1f607f5cb2e0af3eb9724688203a103c2c43b4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1428604Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#661251}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Idb8ff2a56f2bd849a4dc110c9b42164b9ee7ed87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618114Reviewed-by:
-
Kenichi Ishibashi authored
WorkerInspectorProxy doesn't exist anymore. Bug: N/A Tbr: alph@chromium.org Change-Id: I4523f9fee7320dc745969699590c3980fc952f35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617057Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#661249}
-
Alexey Baskakov authored
We will need it to implement InstallWebAppWithOptions. Bug: 901226 Change-Id: I88797140789a06eb9915a22c81b50d0f1bc20471 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616923 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#661248}
-
Jay Harris authored
to toggle between a location bar and custom tab bar. The flag was originally slated for removal in M76. Bug: 964203 Change-Id: I2d13f3af16fcc603d4eb5c6231ac7468737003ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616875Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Jay Harris <harrisjay@chromium.org> Cr-Commit-Position: refs/heads/master@{#661247}
-
Anand K. Mistry authored
On error, an extension API is meant to only set the error, and not a result. However, some APIs didn't follow this convention and both set the error and result. The following fileManagerPrivate functions are affected: getDownloadUrl addFileWatch removeFileWatch executeTask BUG=514135 Change-Id: Ie8116c14e5d3c558bd596594f24ca68a56171696 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614580Reviewed-by:
Wei Lee <wtlee@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#661246}
-
Hiroki Nakagawa authored
Worker: Make sure to install features controlled by origin trial after OriginTrialContext::AddTokens() JavaScript's properties controlled by origin trials are installed for workers in WorkerOrWorkletScriptController::Initialize(). This is too early for shared/service workers with off-the-main-thread worker script fetch. This is because their origin trial tokens are served via worker script's response headers, and are applied to OriginTrialContext *after* WorkerOrWorkletScriptController::Initialize(). This CL separates WorkerOrWorkletScriptController::Initialize() into 2 parts: Initialize() to create and initialize the global object, and ReadyToEvaluate() to install the conditional features. Then, this makes sure to call ReadyToEvaluate() after the tokens are applied. This change fixes a following test with off-the-main-thread service worker script fetch: - virtual/origin-trials-runtimeflags-disabled/http/tests/origin_trials/webexposed/cookiestore-origin-trial-interfaces.html Change-Id: I024915b470600d6dc4835d7d3aef297da616da3e Bug: 945215 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614645 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Auto-Submit: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
-
Fergus Dall authored
TBR=bokan@chromium.org Bug: 963739 Change-Id: I00a2908c78a81f788b5af458dc49bb96a79238d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616936Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/b16d69c32cff..70958d15db70 git log b16d69c32cff..70958d15db70 --date=short --no-merges --format='%ad %ae %s' 2019-05-19 cnorthrop@google.com Let attribute aliasing logic detect overflow Created with: gclient setdep -r src/third_party/angle@70958d15db70 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:964404 TBR=syoussefi@google.com Change-Id: I90dc6429645b10d71367c4e07f4fc6cfec93f8fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618113Reviewed-by:
-
Joel Hockey authored
Added tests for dialog messages, and refactored tests by combining 2 similar tests together. This should reduce overall overhead on the bots and maybe help keep test time within timeout limits. Bug: 946273 Change-Id: I8f0c3ee98c308b45a3ce56eb6fb72931170ec477 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616718Reviewed-by:
-
Joel Hockey authored
This is now enabled by default. Change-Id: I79253ff1f638e341996c80794b61652716b3ec3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616935 Auto-Submit: Joel Hockey <joelhockey@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
-
Giovanni Ortuño Urquidi authored
Previously a PendingBookmarkAppManager could be created with either installation tasks that always succeeded or with installation tasks that always failed. This made writing tests that needed some tasks to fail and some to succeed impossible to write. This CL changes how fake tasks are created and allows tests to control the result of each specific task. Bug: 916381 Change-Id: Ie10b5fd8866713414d3878ce7dd38615a2aec44f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615041 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
-
Darren Shen authored
Currently, the MODECHANGE key just switches to the next IME (same as pressing Ctrl-Shift-Space). However, because users may accidentally press the key, we want it to be a no-op initially. So the user pressing the key once just shows the current IME. Pressing it again while the IME mode indicator is visible will switch to the next IME. TBR=holte@chromium.org Bug: 953901 Test: accelerator_controller_unittest.cc; manual test with fake key. Change-Id: Ibf0cc0379d35c4aae50f5f41a2dceb1e14de3b34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614997 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Oliver Chang <ochang@chromium.org> Cr-Commit-Position: refs/heads/master@{#661239}
-
Edin Kadric authored
This makes it such that when the EditableCombobox is focused but the menu isn't open, a click on the textfield but not the arrow still opens the menu (as would happen with a click on the textfield if the menu weren't focused). We can get in this situation in two ways: 1) After selecting an item or closing the menu with something like Esc, the menu is still in focus. 2) When first opening a View hosting the EditableCombobox, it could have been set not to show the menu on initial focus (as is the case in the password bubble for example). See associated bug for screenshot. We look at mouse release instead of press so that the user can still select the by clicking and dragging the mouse. If we look at mouse press events then the menu will open and the drag will not select text. Note that we added a call to TextfieldController::HandleMouseEvent in Textfield::OnMouseReleased, so we also had to add a check in other users of TextfieldController::HandleMouseEvent. Bug: 960317 Change-Id: Iaba4834be5e0f68ad3191ca572f2ab011825678e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1608805Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Edin Kadric <edinkadric@google.com> Cr-Commit-Position: refs/heads/master@{#661238}
-
Jinsuk Kim authored
TabWebContentsDelegateAndroid should always be able to get the fullscreen manager to return the right control height (https://crrev.com/c/1475677). This CL replaces FullscreenManager.from() which can return |null| while tabs are in transition with the reinstated getFullscreenManager() that always returns the ChromeActivity's FullscreenManager correctly. Bug: 963820 Change-Id: Iafef11ed7dff14de38a305e6494eb0f3f83b6b46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615406Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#661237}
-
- 19 May, 2019 6 commits
-
-
Darren Shen authored
Fullscreen VK was abandoned a long time ago. It seems unlikely to make a comeback. Let's just delete the dead code. TBR=benwells@chromium.org Bug: 845780 Change-Id: I1a31739c21948cc046caa9e8175e28508fe1f489 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611625 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b5938566c985..ff9090d033d8 Created with: gclient setdep -r src-internal@ff9090d033d8 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=beverloo@google.com,collinbaker@google.com,bcwhite@google.com,tasak@google.com Change-Id: I9829afc9fee0037201c89d8a7b38678464c80b3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619243Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/977a0a436918..7ab65834bc02 git log 977a0a436918..7ab65834bc02 --date=short --no-merges --format='%ad %ae %s' 2019-05-19 swiftshader.regress@gmail.com Regres: Update test lists @ 977a0a43 Created with: gclient setdep -r src/third_party/swiftshader@7ab65834bc02 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Change-Id: I5b011250d9ca5d497c29f66aeb141dbb1a5b7014 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618594Reviewed-by:
-
Xianzhu Wang authored
Combine FlipForWritingMode of LayoutInline and LayoutText into LayoutObject. In this way, it's conveinent to convert between PhysicalRect/PhysicalOffset and (flipped) LayoutRect/LayoutPoint for any type of LayoutObject. LayoutBox will also use the new FlipForWritingMode() with almost the same performance as before for normal cases. Actual flipping (in flipped blocks writing mode) will be slightly slower because of the virtual FlipForWritingModeInternal(). If this is shown to impact performance, we can devirtualize it by duplicating some code in LayoutBox's version of FlipForWritingMode() instead of inheriting from LayoutObject. Specifically, this can simplify the following code: if (object->IsBox()) ToLayoutBox(object)->FlipForWritingMode(rect); else object->ContainingBlock()->FlipForWritingMode(rect); into object->FlipForWritingMode(rect), which will be used in next steps of physical rect convertion (e.g. https://chromium-review.googlesource.com/c/chromium/src/+/1619042). Change-Id: I954bfda20a31310f9b53ddee7a16e68cd5f29137 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618805Reviewed-by:Emil A Eklund <eae@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#661233}
-
Jun Mukai authored
aura::Env is now singleton. This doesn't have to exist. Bug: 958467, 960503, 826386 Test: trybot Change-Id: I18a49511d9428204c438af48231f9e89650306a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616326 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/9da165a69140..82728b140ee0 git log 9da165a69140..82728b140ee0 --date=short --no-merges --format='%ad %ae %s' 2019-05-19 treehugger-gerrit@google.com Merge "Fix fuzzer build" Created with: gclient setdep -r src/third_party/perfetto@82728b140ee0 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Ieb341b68f3496e25c2c9e4cf9e8f560d9377d37c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619048Reviewed-by:
-
